Skip to content

[backport core/1.55] fix(agent): keep the turn live across a socket reconnect - #19694

Merged
comfy-pr-bot merged 3 commits into
core/1.55from
backport-18152-to-core-1.55
Oct 1, 2026
Merged

comfy-pr-bot merged 3 commits into
core/1.55from
backport-18152-to-core-1.55

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #18152 to core/1.55. Preserves an active Agent turn across a transient socket disconnect and reconciles its outcome from persisted REST history.

onStatus(false) now only records a drop. onStatus(true) after a drop starts one bounded recovery job per live turn: poll rest.getMessages on a 0/1/2/4/8/16-second backoff under a 60-second whole-job deadline, keep polling while the row is streaming, settle when terminal, forget the thread on a repeated 404, one notice then keep polling on other REST errors. agentConversationStore gains liveTurns() / settleTurn(); agentTranscript hydrates any still-streaming assistant row as pending.

Why this was re-done

The previous head cherry-picked useAgentSession.ts, agentTranscript.ts and agentConversationStore.ts largely as they stand on main, which pulled in main-only drift the reconnect fix does not need — workspace-scoped agent thread storage, trackAgentStopClicked/trackAgentWorkflowBound telemetry, ReportErrorOptions.surface, the turnStartedAt timing rework. That is what the 16 typecheck errors were, and the earlier repair attempt answered them by deleting 1 223 lines of the reconnect regression coverage.

This head is a fresh cherry-pick of #18152's own delta onto core/1.55, resolved against the APIs this branch actually has. useAgentSession.ts is +234/-30 here against +223/-26 upstream; the other nine files are byte-identical to the upstream delta apart from the adaptations below. Every regression pin from #18152 is restored: the three test.fail() pins in agentTurnSurvivesSocketDrop.spec.ts and the two in agentApprovalSurvivesSocketDrop.spec.ts are un-failed, and the new (g3)–(g22) unit cases are present.

Deliberate adaptations

  • Thread storage. Kept this branch's module-local THREAD_STORAGE_KEY. Workspace-scoped StorageKeys.agentThread() and the clearLegacyAgentStorage() migration are an unrelated main-only change, so forgetDeletedThread clears the unscoped key.
  • Error reporting. The recovery job's reportError omits surface, which is not a field of this branch's ReportErrorOptions; it matches the other call site in the same file.
  • start() / hydrateFromServer(). Release signatures kept. Only the everLive → connection state machine and the reconcileLiveTurns() call are taken — readyThreadId, the restore option, initializeWorkflowContext and the workflow.restored boolean contract are main-only and are context lines in fix(agent): keep the turn live across a socket reconnect and reconcile from REST (PM-1199) #18152's diff, not part of it.
  • settleStoppedTurn(event) → markStoppedTurnReady(turn), so the websocket path and the reconcile path share one gate, as on main.
  • Omitted: main-only stop/workflow-bound telemetry and their tests.
  • Added release coverage: (g15) now asserts this branch's observables for a deleted thread — thread id cleared, workflow binding dropped, Comfy.Agent.ThreadId removed, next send opens a new thread — in place of main's workspace-scoping and onThreadActivated assertions.

Verification

Run locally at 48e6ce850 on Node 26:

  • pnpm typecheck — pass (was 16 errors)
  • pnpm lint — pass, 0 problems
  • pnpm knip — pass
  • pnpm format — no changes
  • pnpm vitest run src/workbench/extensions/agent — 127 files, 2 173 passed, 2 expected-fail (pre-existing CRDT pins, unrelated)
  • Playwright pins need the cloud fixture and were not run locally.

Original: #18152

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 1, 2026
@DrJKL
DrJKL self-requested a review October 1, 2026 04:49
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2140 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2119 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 08:37:23 AM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (15 changed files).

Kind Finding Where Usual remedy
Complexity hydrateFromServer() — cyclomatic 12, CRAP 43.1 src/workbench/extensions/agent/composables/agent/useAgentSession.ts:352 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 26c09cf7d67a96062e3a40c0404bc91a60ac4ee7

Full docs: ADR-DEVEX-LINT-0015

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 389ms TBT · 87.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 158ms TBT · 87.0 MB heap
extension-clean-combined-draw: · 56.3 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 76ms TBT · 72.6 MB heap
extension-rgthree-prototype-draw: · 56.2 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 99ms TBT · 83.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 89ms TBT · 78.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 28ms TBT · 177.6 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 244ms TBT · 175.8 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 368ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 57.8 MB
canvas-idle: DOM nodes -259
canvas-idle: event listeners -174
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 46
canvas-mouse-sweep: task duration 640ms
canvas-mouse-sweep: script duration 118ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.0 MB
canvas-mouse-sweep: DOM nodes -259
canvas-mouse-sweep: event listeners -163
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 29
canvas-zoom-sweep: task duration 275ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 363ms
dom-widget-clipping: script duration 133ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.5 MB
dom-widget-clipping: DOM nodes 23
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 659ms
dom-widget-order-dense-n200-w200-i120: script duration 50ms
dom-widget-order-dense-n200-w200-i120: TBT 389ms
dom-widget-order-dense-n200-w200-i120: heap used 87.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -147
dom-widget-order-dense-n200-w200-i120: event listeners -109
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 369ms
dom-widget-order-sparse-n1000-w20-i120: script duration 115ms
dom-widget-order-sparse-n1000-w20-i120: TBT 158ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.0 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 18ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 1ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 2
extension-clean-combined-draw: task duration 6446ms
extension-clean-combined-draw: script duration 5156ms
extension-clean-combined-draw: TBT 76ms
extension-clean-combined-draw: heap used 72.6 MB
extension-clean-combined-draw: DOM nodes -140
extension-clean-combined-draw: event listeners -87
extension-rgthree-prototype-draw: avg frame time 18ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 2
extension-rgthree-prototype-draw: task duration 6442ms
extension-rgthree-prototype-draw: script duration 5157ms
extension-rgthree-prototype-draw: TBT 99ms
extension-rgthree-prototype-draw: heap used 83.5 MB
extension-rgthree-prototype-draw: DOM nodes -138
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 10
large-graph-idle: task duration 482ms
large-graph-idle: script duration 29ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.1 MB
large-graph-idle: DOM nodes -239
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1272ms
large-graph-pan: script duration 663ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 69.6 MB
large-graph-pan: DOM nodes -247
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1414ms
large-graph-zoom: script duration 642ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.1 MB
large-graph-zoom: DOM nodes -248
large-graph-zoom: event listeners -87
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1499ms
legacy-node-drag: script duration 763ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.9 MB
legacy-node-drag: DOM nodes 12
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 6ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 500ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 76.5 MB
minimap-idle: DOM nodes -248
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 50
subgraph-dom-widget-clipping: task duration 327ms
subgraph-dom-widget-clipping: script duration 119ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 80.2 MB
subgraph-dom-widget-clipping: DOM nodes 25
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 371ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.6 MB
subgraph-idle: DOM nodes -276
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 47
subgraph-mouse-sweep: task duration 610ms
subgraph-mouse-sweep: script duration 85ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.0 MB
subgraph-mouse-sweep: DOM nodes -272
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 9ms
subgraph-transition-enter: style recalc duration 22ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 698ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 89ms
subgraph-transition-enter: heap used 78.2 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 251
viewport-pan-sweep: task duration 4700ms
viewport-pan-sweep: script duration 2221ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 64.1 MB
viewport-pan-sweep: DOM nodes -238
viewport-pan-sweep: event listeners -174
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14051ms
vue-large-graph-idle: script duration 200ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.1 MB
vue-large-graph-idle: DOM nodes -8064
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 94
vue-large-graph-pan: task duration 15029ms
vue-large-graph-pan: script duration 723ms
vue-large-graph-pan: TBT 28ms
vue-large-graph-pan: heap used 177.6 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 61ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5105ms
vue-node-resize-workload: script duration 83ms
vue-node-resize-workload: TBT 244ms
vue-node-resize-workload: heap used 175.8 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7109ms
vue-zoom-out-idle: script duration 102ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 167.9 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 21ms
workflow-execution: layout count 5
workflow-execution: style recalc count 19
workflow-execution: task duration 104ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.7 MB
workflow-execution: DOM nodes 151
workflow-execution: event listeners 81
Raw data
{
  "timestamp": "2026-10-01T08:55:16.201Z",
  "gitSha": "55f58b8c7e7d338dbcffdb260789d4f436f2726d",
  "branch": "backport-18152-to-core-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1998.181000000045,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.2860000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.02399999999994,
      "heapDeltaBytes": -7138824,
      "heapUsedBytes": 60608596,
      "domNodes": -259,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 7.723000000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1998.6059999999952,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.278000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 368.467,
      "heapDeltaBytes": -7053036,
      "heapUsedBytes": 60649916,
      "domNodes": -258,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.242999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1669.4029999999884,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 12.664,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 628.895,
      "heapDeltaBytes": -7873608,
      "heapUsedBytes": 59977972,
      "domNodes": -259,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 115.60799999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1711.0209999999597,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 12.299,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.612,
      "heapDeltaBytes": -2197800,
      "heapUsedBytes": 65777896,
      "domNodes": -258,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 119.649,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1692.6180000000386,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.344999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.002,
      "taskDurationMs": 262.191,
      "heapDeltaBytes": 3103116,
      "heapUsedBytes": 70788580,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.668,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1692.9549999999836,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 13.774999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9780000000000001,
      "taskDurationMs": 288.733,
      "heapDeltaBytes": 2990304,
      "heapUsedBytes": 70738768,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.186,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 516.6790000000105,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.89,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 354.546,
      "heapDeltaBytes": 18685736,
      "heapUsedBytes": 86230516,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 128.637,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 532.5670000000855,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.421,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.46599999999995,
      "heapDeltaBytes": 19007876,
      "heapUsedBytes": 86692464,
      "domNodes": 23,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 137.137,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1036.564999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 691.1539999999999,
      "heapDeltaBytes": -17661672,
      "heapUsedBytes": 73203824,
      "domNodes": -294,
      "jsHeapTotalBytes": 21102592,
      "scriptDurationMs": 51.02900000000002,
      "eventListeners": -217,
      "totalBlockingTimeMs": 387,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 995.8859999999277,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 626.7309999999999,
      "heapDeltaBytes": 38762200,
      "heapUsedBytes": 109269444,
      "domNodes": 0,
      "jsHeapTotalBytes": 20082688,
      "scriptDurationMs": 49.96000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 390,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 763.8469999999984,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.3250000000001,
      "heapDeltaBytes": 14626364,
      "heapUsedBytes": 91120504,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 114.269,
      "eventListeners": 0,
      "totalBlockingTimeMs": 158,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 763.8419999999542,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.4620000000003,
      "heapDeltaBytes": 14658320,
      "heapUsedBytes": 91369264,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 115.57599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 158,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7321.574999999995,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.2200000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6524.482,
      "heapDeltaBytes": -6495760,
      "heapUsedBytes": 70792204,
      "domNodes": -262,
      "jsHeapTotalBytes": 3661824,
      "scriptDurationMs": 5244.178000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 7151.76699999995,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.13099999999999917,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6366.5509999999995,
      "heapDeltaBytes": -618900,
      "heapUsedBytes": 81490308,
      "domNodes": -18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 5068.697999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7384.997999999996,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.6939999999999967,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6589.789,
      "heapDeltaBytes": 11655104,
      "heapUsedBytes": 89510260,
      "domNodes": -261,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 5274.198,
      "eventListeners": -174,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 7112.581000000091,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.0989999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6293.732,
      "heapDeltaBytes": 3556444,
      "heapUsedBytes": 85547744,
      "domNodes": -14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 5039.747,
      "eventListeners": 0,
      "totalBlockingTimeMs": 54,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2017.9709999999886,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.127000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.0350000000001,
      "heapDeltaBytes": -3614420,
      "heapUsedBytes": 83628104,
      "domNodes": -240,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 28.643999999999995,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2024.0229999999428,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.441000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.00500000000005,
      "heapDeltaBytes": -7353744,
      "heapUsedBytes": 80055416,
      "domNodes": -237,
      "jsHeapTotalBytes": 290816,
      "scriptDurationMs": 29.536999999999995,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2166.561999999999,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.543999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1354.9829999999997,
      "heapDeltaBytes": -22636420,
      "heapUsedBytes": 65707496,
      "domNodes": -252,
      "jsHeapTotalBytes": 2650112,
      "scriptDurationMs": 669.9119999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2120.781999999963,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.929,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1188.999,
      "heapDeltaBytes": -7779168,
      "heapUsedBytes": 80196464,
      "domNodes": -242,
      "jsHeapTotalBytes": 2088960,
      "scriptDurationMs": 656.963,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3250.0870000000077,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 12.947999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.735999999999997,
      "taskDurationMs": 1390.85,
      "heapDeltaBytes": 8117532,
      "heapUsedBytes": 74176592,
      "domNodes": -247,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 643.482,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3236.4820000000236,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.808000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.720000000000002,
      "taskDurationMs": 1437.7830000000004,
      "heapDeltaBytes": -9919648,
      "heapUsedBytes": 72889148,
      "domNodes": -249,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 640.0160000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2157.147000000009,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.992999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1489.1289999999997,
      "heapDeltaBytes": 21929432,
      "heapUsedBytes": 87932584,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 760.111,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2176.617999999962,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.449000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1508.59,
      "heapDeltaBytes": -13734604,
      "heapUsedBytes": 77568624,
      "domNodes": 16,
      "jsHeapTotalBytes": 7114752,
      "scriptDurationMs": 766.525,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2008.496999999977,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.019000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.778,
      "heapDeltaBytes": -5729648,
      "heapUsedBytes": 83336448,
      "domNodes": -243,
      "jsHeapTotalBytes": -1544192,
      "scriptDurationMs": 31.775,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.8579999999902,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.869000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.5349999999999,
      "heapDeltaBytes": -10635652,
      "heapUsedBytes": 77120828,
      "domNodes": -252,
      "jsHeapTotalBytes": 552960,
      "scriptDurationMs": 32.785,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 505.8440000000246,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 11.055999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 325.8070000000001,
      "heapDeltaBytes": 14112088,
      "heapUsedBytes": 84067476,
      "domNodes": 26,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 119.47500000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 525.7480000000214,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.146,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 329.0110000000001,
      "heapDeltaBytes": 14079188,
      "heapUsedBytes": 84065088,
      "domNodes": 23,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 119.464,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.319000000009,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.628000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 378.871,
      "heapDeltaBytes": -5071852,
      "heapUsedBytes": 65323424,
      "domNodes": -275,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.675000000000002,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1992.3639999999523,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.300000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.911,
      "heapDeltaBytes": 6313432,
      "heapUsedBytes": 76438868,
      "domNodes": -276,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.660999999999999,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.5000000000055,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 618.109,
      "heapDeltaBytes": -9812588,
      "heapUsedBytes": 59573312,
      "domNodes": -269,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 87.247,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1694.3039999999883,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.312,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.113,
      "heapDeltaBytes": -8345296,
      "heapUsedBytes": 61962688,
      "domNodes": -274,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 83.54,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 917.3610000000281,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 22.11,
      "layouts": 5,
      "layoutDurationMs": 9.367,
      "taskDurationMs": 698.2190000000002,
      "heapDeltaBytes": -6229528,
      "heapUsedBytes": 82037252,
      "domNodes": 13667,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 21.330000000000002,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 89,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8179.745999999966,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.011,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4555.729,
      "heapDeltaBytes": -12750380,
      "heapUsedBytes": 67916180,
      "domNodes": -211,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 2171.421,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8327.841000000035,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 41.44499999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4843.794000000001,
      "heapDeltaBytes": -15149096,
      "heapUsedBytes": 66590600,
      "domNodes": -265,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 2270.823,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14294.606999999985,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13982.109999999999,
      "heapDeltaBytes": -53029748,
      "heapUsedBytes": 191124372,
      "domNodes": -8066,
      "jsHeapTotalBytes": -14266368,
      "scriptDurationMs": 201.401,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14359.62900000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14119.221,
      "heapDeltaBytes": -72210060,
      "heapUsedBytes": 171910564,
      "domNodes": -8062,
      "jsHeapTotalBytes": -14266368,
      "scriptDurationMs": 199.32399999999998,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17029.653000000053,
      "styleRecalcs": 118,
      "styleRecalcDurationMs": 14.179999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16797.658000000003,
      "heapDeltaBytes": -47303024,
      "heapUsedBytes": 190060116,
      "domNodes": -8062,
      "jsHeapTotalBytes": -18006016,
      "scriptDurationMs": 719.409,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 6,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13839.565999999992,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 11.724999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13260.878,
      "heapDeltaBytes": -57244948,
      "heapUsedBytes": 182477040,
      "domNodes": -8061,
      "jsHeapTotalBytes": -18690048,
      "scriptDurationMs": 727.1450000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 50,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5185.2839999999105,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.243000000000016,
      "layouts": 20,
      "layoutDurationMs": 22.035,
      "taskDurationMs": 5101.4800000000005,
      "heapDeltaBytes": -51153020,
      "heapUsedBytes": 183486136,
      "domNodes": -8062,
      "jsHeapTotalBytes": 18309120,
      "scriptDurationMs": 86.387,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 277,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5140.4,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.50900000000001,
      "layouts": 20,
      "layoutDurationMs": 21.911,
      "taskDurationMs": 5108.365,
      "heapDeltaBytes": -52282312,
      "heapUsedBytes": 185116384,
      "domNodes": -8062,
      "jsHeapTotalBytes": 19812352,
      "scriptDurationMs": 79.974,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 210,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7364.175000000046,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7096.37,
      "heapDeltaBytes": -26021420,
      "heapUsedBytes": 172433324,
      "domNodes": -1,
      "jsHeapTotalBytes": -30932992,
      "scriptDurationMs": 99.94900000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7272.666000000072,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7122.493,
      "heapDeltaBytes": 8574620,
      "heapUsedBytes": 179769996,
      "domNodes": 0,
      "jsHeapTotalBytes": -19398656,
      "scriptDurationMs": 104.08099999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 445.8480000000691,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 21.686,
      "layouts": 5,
      "layoutDurationMs": 2.1380000000000003,
      "taskDurationMs": 112.198,
      "heapDeltaBytes": 5235956,
      "heapUsedBytes": 67205240,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.711999999999998,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 442.90799999998853,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 19.970000000000002,
      "layouts": 4,
      "layoutDurationMs": 1.7660000000000002,
      "taskDurationMs": 96.566,
      "heapDeltaBytes": 5022360,
      "heapUsedBytes": 70506864,
      "domNodes": 148,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.956999999999999,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52455 79378 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.2% 252
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 8891f933-2c14-4088-b6d6-47918b01fe4a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@datadog-official

This comment has been minimized.

…e from REST (PM-1199) (#18152)

Manual backport of #18152 to core/1.55.

A transient websocket reconnect no longer abandons the running agent turn;
the client keeps the turn live and reconciles its outcome from REST once the
socket is back, within a bounded recovery job (six polls on a 0/1/2/4/8/16-second
backoff under a 60-second whole-job deadline); past that window the live socket
is trusted to deliver the terminal event.

Release-branch adaptations (core/1.55 lacks the main-only APIs #18152 was
written against):

- Thread storage stays on this branch's module-local `THREAD_STORAGE_KEY`.
  Workspace-scoped `StorageKeys.agentThread()` and the `clearLegacyAgentStorage()`
  migration are an unrelated main-only change, so `forgetDeletedThread` clears
  the unscoped key.
- `reportError` for a failed recovery job omits `surface`, which is not a field
  of this branch's `ReportErrorOptions`; it matches the other call site in this
  file.
- `start()` and `hydrateFromServer()` keep their release signatures. Only the
  `everLive` -> `connection` state machine and the `reconcileLiveTurns()` call
  are taken; `readyThreadId`, the `restore` option, `initializeWorkflowContext`
  and the `workflow.restored` boolean contract are main-only.
- `settleStoppedTurn(event)` becomes `markStoppedTurnReady(turn)` so the WS
  path and the reconcile path share one gate, as on main.
- Main-only `trackAgentStopClicked`/`trackAgentWorkflowBound` telemetry and the
  `turnStartedAt` timing rework are not brought along, and their tests are
  omitted.
- (g15) asserts the release branch's observables for a deleted thread — thread
  id cleared, workflow binding dropped, `Comfy.Agent.ThreadId` removed, next
  send opens a new thread — in place of main's workspace-scoping and
  `onThreadActivated` assertions.

Original: #18152
@christian-byrne
christian-byrne force-pushed the backport-18152-to-core-1.55 branch from eece8b6 to 48e6ce8 Compare October 1, 2026 05:29

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 6
🟢 Low 1

Panel: 8/8 reviewers contributed findings.

// generation. The server still accepted this turn, so reporting success
// prevents a future caller from offering a duplicate non-idempotent send.
if (generation !== loadGeneration) return true
if (generation !== loadGeneration) return false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — After accepted = true the server is already running a non-idempotent turn, but a loadGeneration change now returns false (the old code returned true here deliberately, per the deleted comment), and the catch below also returns false unconditionally when acceptTurn throws locally — e.g. localStorage.setItem raising QuotaExceededError/SecurityError. useAgentDraftSubmission passes that to settleSubmission(id, false), which marks the submission failed and restores the draft, inviting a duplicate billable, workflow-mutating send (or a 409 TURN_IN_PROGRESS); acceptTurn is also skipped, so the accepted turn has no transport and its frames are dropped. Report success — or commit the acknowledged turn independently of best-effort persistence — whenever accepted is true. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

// A live `agent_tool_call` frame keys its update on `tool_call_id`, so a
// restored part uses the same id to match a live frame that arrives for
// it later.
callId: toolCallId,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — zPersistedToolCallSummary still declares tool_call_id as z.string().optional() (documented there as "rows recorded before tool_call_id existed have none"), so dropping the ?? id fallback assigns undefined to ToolPart.callId, which is typed string. Beyond the type mismatch, parseToolCalls then keys its dedupe Map on undefined, collapsing every legacy tool call in a row into a single part and losing tool history on restore. Either keep the fallback or make tool_call_id required in the schema so such rows are rejected rather than silently merged. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case, gemini-3.1-pro edge-case).

if (oldest !== undefined) malformedStreamReports.delete(oldest)
}
if (priorVisible === true || (priorVisible === false && !visible)) return
malformedStreamReports.set(turnId, visible)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — The 32-entry eviction is gone while this map is still keyed by the server-supplied message_id that malformedEventTurnId reads straight off the unvalidated frame, so a buggy or hostile peer emitting malformed frames with unique ids grows the map without bound and fires one reportError plus one trackAgentError per id, flooding Sentry/Datadog/PostHog. The deleted test "does not trust attacker-controlled message ids as telemetry keys" asserted exactly one report for 100 such frames; restore a bound on the map. Raised by 7 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

if (turnId === undefined || turnId === conversationStore.activeTurnId) {
forgetActiveTurnStartedAt()
conversationStore.abortActiveTurn()
pushError(i18n.global.t('agent.malformedEvent'))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — pushError is now called inline instead of being gated on trackMalformedStreamEvent's dedupe result, so a repeating malformed agent_message_done stream (each frame with no usable message_id keeps matching the active-turn branch) appends one notice per frame instead of one per turn, and the notices watcher re-opens the error overlay each time. The deleted expect(session.notices.value).toHaveLength(2) assertion in the 20-frame test pinned the old bound. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

): boolean | undefined {
if (state === 'streaming') return undefined
return status === 'ok' || status === 'success'
return status === 'success'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Narrowing success to status === 'success' makes any persisted row with the legacy terminal status ok rehydrate as ok: false and render the failure glyph after a reload or thread switch. zPersistedToolCallSummary still types status as an open optional string and its unchanged doc names ok as a success value precisely because the terminal vocabulary is not settled between the persisted and live wire formats. Raised by 5 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

conversationStore.latestWorkflowId,
isCurrent
)
if (workflowReady === false) return false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — hydrateFromServer commits conversationStore.hydrate(history) and readyThreadId.value = threadId before awaiting workflow.restored, so returning false here leaves the panel displaying the new thread's transcript with isTranscriptReady true while loadThread reports failure and skips localStorage.setItem, onThreadActivated, and resumeBackgroundTurn() — the persisted pointer and the activated-thread callback still name the previous thread. Roll the hydrate/ready commit back on a failed restoration, or apply it only after the restoration resolves. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case).

text: string
): NormalizedAgentTranscript['pending'] {
message.streaming = false
message.streaming = row.status === 'streaming'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Treating every streaming row as pending (not just a mid-ask row) means a row the backend left permanently streaming — a turn the server never finalized — marks that turn live on every hydrate, pinning Stop/isStreaming with no terminal socket event coming and recoverTurn giving up after its six-step backoff. normalizeAgentTranscript also only ever assigns pending and never clears it, so a later terminal row in the same turn cannot undo a pending set by an earlier streaming row. Derive pending from the turn's final row state instead of the first streaming row seen. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

issue_count: cause.issues.length,
issue_codes: cause.issues.slice(0, 10).map(({ code }) => code)
}
context: { issues: cause.issues }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Replacing the bounded { issue_count, issue_codes } with the raw cause.issues ships every Zod issue object — including received/expected values and paths lifted from the agent frame, which can embed conversation content — to the third-party error sinks, with payload size bounded only by the sender's frame. The test assertion expect(options.context).not.toHaveProperty('issues') was deleted in the same change; keep the data minimization. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).

onAskResolved,
workflow
} = deps
const threadStorageKey = StorageKeys.agentThread(getWorkspaceId())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — getWorkspaceId() is read once at composable setup and baked into threadStorageKey, but its own doc states it must be called fresh each time because the workspace identity in sessionStorage changes at runtime. If the workspace is switched (or auth resolves) while the panel stays mounted, acceptTurn, newChat, loadThread, and forgetDeletedThread then read, write, and delete the agent thread pointer under the previous tenant's key. Resolve the key per access rather than caching it. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).

): boolean {
if (accepted) return false
if (error instanceof AgentApiError)
return !NON_RETRYABLE_REQUEST_STATUSES.has(error.status)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The rewrite drops the explicit non-retryable cases: ZodError and AgentResponseUnreadableError now fall through to return true even though they fail identically on retry, and every 4xx outside the hardcoded set (402 payment-denied, 413, 415, 451, ...) flips to retryable. That only mislabels the retryable error-telemetry metadata today, but the function is now exported, so a consumer driving a real retry loop off it would hot-loop on a response that can never parse. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case, gemini-3.1-pro edge-case).

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Rebuilt this head from scratch rather than patching the previous one.

Root cause. The earlier cherry-pick resolved useAgentSession.ts, agentTranscript.ts and agentConversationStore.ts toward main's whole-file state instead of #18152's own delta, so it imported main-only drift the reconnect fix has no dependency on: workspace-scoped agent thread storage (StorageKeys.agentThread + clearLegacyAgentStorage), trackAgentStopClicked / trackAgentWorkflowBound, ReportErrorOptions.surface, and the turnStartedAt timing rework. Upstream changed useAgentSession.ts by +223/-26; that resolution changed it by +618/-240. All 16 typecheck errors were in that imported surface, none in the reconnect logic — a dependency-incomplete backport, not a flaky run.

What changed. Fresh cherry-pick of #18152 onto the release branch, resolved against the APIs the branch actually has. Nine of the eleven files are now byte-identical to the upstream delta; the two that differ do so only where the release branch's own API required it, enumerated in the PR body. The reconnect regression coverage the previous repair deleted is fully restored — all test.fail() pins un-failed and the (g3)–(g22) unit cases present — with (g15) rewritten to assert this branch's observables for a deleted thread instead of main's workspace-scoping.

Gates run locally. pnpm typecheck, pnpm lint (0 problems), pnpm knip, pnpm format (no changes) all pass, and pnpm vitest run src/workbench/extensions/agent is green across 127 files. The Playwright pins need the cloud fixture and were not run locally. Not merging while required checks are in flight.

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts
  • all tests in browser_tests/tests/agent/agentTurnSurvivesSocketDrop.spec.ts

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.32314% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 90.56% 10 Missing ⚠️
...ensions/agent/composables/agent/useAgentSession.ts 97.41% 3 Missing ⚠️
@@             Coverage Diff             @@
##           core/1.55   #19694    +/-   ##
===========================================
  Coverage      84.66%   84.66%            
===========================================
  Files           2315     2315            
  Lines         131694   131853   +159     
  Branches       33266    33312    +46     
===========================================
+ Hits          111495   111636   +141     
- Misses         19840    19858    +18     
  Partials         359      359            
Flag Coverage Δ
e2e 66.12% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...extensions/agent/services/agent/agentRestClient.ts 98.78% <100.00%> (+<0.01%) ⬆️
...extensions/agent/services/agent/agentTranscript.ts 97.67% <100.00%> (-0.04%) ⬇️
...ensions/agent/composables/agent/useAgentSession.ts 98.22% <97.41%> (-0.29%) ⬇️
...sions/agent/stores/agent/agentConversationStore.ts 95.56% <90.56%> (-2.00%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. The port of #18152 is faithful, but the branch now conflicts with core/1.55 in agentTranscript.ts, and it drops the source's one-line SessionNotice un-export.

I compared this branch, against its merge base d173dc6, with #18152's merged diff (d90c109 against its parent 1519cc0).

What matches:

  • Seven files carry exactly the source's added and removed lines: agentTurnLockFixture.ts, agentTurnSurvivesSocketDrop.spec.ts, the approval spec (renamed to agentApprovalSurvivesSocketDrop.spec.ts on this branch), agentRestClient.ts and its test, agentTranscript.test.ts, and agentConversationStore.ts and its test.
  • In useAgentSession.ts and its test, every difference from the source is one of the adaptations named in the description, and I could tie each one to the target:
    • The unscoped THREAD_STORAGE_KEY replaces StorageKeys.agentThread(), because workspace-scoped thread storage is not on core/1.55.
    • onThreadActivated?.(null) is dropped, because that dependency does not exist here.
    • reportError omits surface, because this branch's ReportErrorOptions has no such field.
    • turnStartedAt.clear() is dropped, because that timing map is main-only.
    • The release's settleStoppedTurn(event) becomes the source's markStoppedTurnReady(turn), with the same guard, called from the agent_message_done branch.
    • (g15) asserts this branch's unscoped key in place of the workspace-scoped key and onThreadActivated.
  • All 22 source test additions are present, and the it.fails / test.fail pins are un-failed. The remaining test-file differences are whitespace from the target's pre-image formatting.
  • At 48e6ce8: vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 526/526 across 22 files. All hosted checks at this head passed against the old base.

What needs changing is inline. The conflict comes from #19609 (138fd1f), which landed on core/1.55 after this branch was cut. It replaced the toolCallPartState comment with the same zPersistedToolCallSummary text that #18152's pre-image has on main. I merged origin/core/1.55 into this head locally and resolved the conflict by taking #18152's post-image of that comment. Everything from toolCallPartState to the end of the file was then byte-identical to d90c109, and the same 22 files passed (523 tests).

import type { LiveTurn } from '../../stores/agent/agentConversationStore'
import { useAgentConversationStore } from '../../stores/agent/agentConversationStore'
import { useAgentWorkflowTabBindingStore } from '../../stores/agent/agentWorkflowTabBindingStore'
import type { WorkflowReference } from '../../types/workflowReference'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is about line 50, just outside this hunk. #18152 changes export interface SessionNotice to interface SessionNotice, and this branch keeps the export. On core/1.55, as on main, nothing outside useAgentSession.ts imports SessionNotice, so the target needs no change here. Please carry the un-export.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carried the visibility hunk in the current head, commit 0e9057a.

…o-core-1.55

Amp-Thread-ID: https://ampcode.com/threads/T-01a0f556-cd93-71fc-a424-3acd525c5ea0

# Conflicts:
#	src/workbench/extensions/agent/services/agent/agentTranscript.ts
@DrJKL

DrJKL commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

I merged origin/core/1.55 at 26c09cf7d6 into this branch in 158bac664f.

The only conflict was the doc comment above toolCallPartState in agentTranscript.ts. #19609 had replaced it with the zPersistedToolCallSummary wording that #18152 was written against, so I resolved it by taking #18152's post-image of that comment verbatim. From toolCallPartState to the end of the file now matches d90c109 byte for byte.

After the merge, vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 523/523 across 22 files. vue-tsc --noEmit, oxfmt --check, and eslint on the resolved file also passed.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This is a faithful backport of #18152 to core/1.55, with each adaptation accounted for by the target.

I compared this branch, at 0e9057a against its merge base 26c09cf (the current core/1.55 tip), with #18152's merged diff (d90c109 against its parent 1519cc0). 158bac6 resolved the base conflict by taking #18152's toolCallPartState comment verbatim, and 0e9057a carries the SessionNotice un-export. Together they resolve both of my earlier comments.

Nine files carry exactly the source's added and removed lines: agentTurnLockFixture.ts, agentTurnSurvivesSocketDrop.spec.ts, the approval spec (renamed to agentApprovalSurvivesSocketDrop.spec.ts on this branch), agentRestClient.ts and its test, agentTranscript.ts and its test, and agentConversationStore.ts and its test.

Adaptations, all in useAgentSession.ts and its test:

  • The unscoped THREAD_STORAGE_KEY replaces StorageKeys.agentThread() in forgetDeletedThread, and (g15) asserts that key. Workspace-scoped thread storage is not on core/1.55.
  • onThreadActivated?.(null) is dropped, and so is the matching (g15) assertion, because that dependency does not exist here.
  • turnStartedAt.clear() is dropped, because that timing map is main-only.
  • The recovery job's reportError omits surface, because this branch's ReportErrorOptions has no such field.
  • The release's settleStoppedTurn(event) becomes the source's markStoppedTurnReady(turn), with the same thread and turn guard, called from the agent_message_done branch.

All 22 source test additions are present, and the it.fails / test.fail pins are un-failed. The remaining test-file differences are whitespace from the target's pre-image formatting.

Checks: at 0e9057a, vitest run over useAgentSession.test.ts, services/agent/, and stores/agent/ passed 523/523 across 22 files, and vue-tsc --noEmit passed. All hosted checks at this head passed.

@DrJKL DrJKL assigned christian-byrne and unassigned DrJKL Oct 1, 2026
@comfy-pr-bot
comfy-pr-bot merged commit 0921264 into core/1.55 Oct 1, 2026
106 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18152-to-core-1.55 branch October 1, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants