Repository navigation
[backport core/1.55] fix(agent): restore standing paywall after graph rewrite - #19662
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 57f530810d97a9aa61a09acdd671f0453751a696
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T03:58:14.909Z",
"gitSha": "a76f97cf66a16e53c8139d845cd2e64325bf47bf",
"branch": "backport-standing-paywall-core155-postdeps-5",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.6459999999993,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.107,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.131,
"heapDeltaBytes": -8548892,
"heapUsedBytes": 59042072,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.973000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1999.4530000000168,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.776000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.2380000000001,
"heapDeltaBytes": 9326844,
"heapUsedBytes": 76957952,
"domNodes": -258,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.928000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.4349999999986,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 624.174,
"heapDeltaBytes": -4987636,
"heapUsedBytes": 57513748,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 115.14300000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.4090000000351,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.394,
"heapDeltaBytes": -11267196,
"heapUsedBytes": 56940880,
"domNodes": -261,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 118.88000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.18300000002,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.879000000000001,
"layouts": 6,
"layoutDurationMs": 0.9279999999999999,
"taskDurationMs": 269.79200000000003,
"heapDeltaBytes": 3021800,
"heapUsedBytes": 70985644,
"domNodes": 81,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.221999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.7519999999931,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.177,
"layouts": 6,
"layoutDurationMs": 1.0310000000000001,
"taskDurationMs": 300.268,
"heapDeltaBytes": 3109140,
"heapUsedBytes": 70650220,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.677000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 542.8730000000428,
"styleRecalcs": 14,
"styleRecalcDurationMs": 8.697999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.40399999999994,
"heapDeltaBytes": 18968964,
"heapUsedBytes": 85719924,
"domNodes": 23,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 133.92200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 541.2969999999859,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.965,
"heapDeltaBytes": 18845368,
"heapUsedBytes": 86634868,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 133.358,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1047.932000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.9950000000001,
"heapDeltaBytes": -17525592,
"heapUsedBytes": 73119092,
"domNodes": -295,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 51.68700000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 403,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1017.05800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.7060000000001,
"heapDeltaBytes": 34644372,
"heapUsedBytes": 104004156,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 50.617999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 403,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 779.2270000000485,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.98999999999995,
"heapDeltaBytes": 14182412,
"heapUsedBytes": 91334584,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.15,
"eventListeners": 0,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 767.7899999999909,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.97199999999964,
"heapDeltaBytes": 14743076,
"heapUsedBytes": 91022076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.769,
"eventListeners": 0,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7187.952000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6392.187,
"heapDeltaBytes": -9733344,
"heapUsedBytes": 73189596,
"domNodes": -16,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5301.119,
"eventListeners": 0,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7667.740000000094,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2190000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6808.694,
"heapDeltaBytes": 7583232,
"heapUsedBytes": 85391036,
"domNodes": -270,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 5439.0419999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 29,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7277.417999999954,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.7370000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6443.363,
"heapDeltaBytes": -3005396,
"heapUsedBytes": 73583496,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5161.015,
"eventListeners": -174,
"totalBlockingTimeMs": 88,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7220.781999999986,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.7759999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6346.490999999999,
"heapDeltaBytes": 13452804,
"heapUsedBytes": 95148172,
"domNodes": -14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 5210.832000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 21,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 1992.2559999999976,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.696999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.7490000000001,
"heapDeltaBytes": 19759620,
"heapUsedBytes": 85657824,
"domNodes": 14,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.857999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.8499999999485,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.813999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.2359999999999,
"heapDeltaBytes": -8429524,
"heapUsedBytes": 78922816,
"domNodes": -242,
"jsHeapTotalBytes": 1077248,
"scriptDurationMs": 29.86,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2149.503999999979,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.931999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1324.2730000000001,
"heapDeltaBytes": -23054832,
"heapUsedBytes": 65333804,
"domNodes": -246,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 652.8520000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2236.692000000062,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.720999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1395.429,
"heapDeltaBytes": 9013908,
"heapUsedBytes": 97441768,
"domNodes": -251,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 678.959,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3250.6689999999594,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.973,
"layouts": 60,
"layoutDurationMs": 12.688999999999998,
"taskDurationMs": 1337.943,
"heapDeltaBytes": -16001928,
"heapUsedBytes": 73784268,
"domNodes": -245,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 652.114,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3239.1509999999926,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.743,
"layouts": 60,
"layoutDurationMs": 13.142999999999999,
"taskDurationMs": 1505.392,
"heapDeltaBytes": -16361316,
"heapUsedBytes": 73160208,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 654.4830000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2494.516000000033,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.445,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1542.264,
"heapDeltaBytes": 21317452,
"heapUsedBytes": 86970820,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 799.601,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2333.342000000016,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.608,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.3970000000002,
"heapDeltaBytes": 17162248,
"heapUsedBytes": 83363424,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 789.114,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.5670000000237,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.667999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.41900000000004,
"heapDeltaBytes": -4345088,
"heapUsedBytes": 84520200,
"domNodes": -237,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 29.933,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.3970000000263,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.383000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.7879999999999,
"heapDeltaBytes": -4565892,
"heapUsedBytes": 84122516,
"domNodes": -241,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.07599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.7129999999979,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.278000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.0969999999999,
"heapDeltaBytes": 13766312,
"heapUsedBytes": 76967160,
"domNodes": 21,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 119.775,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.855999999937,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.30099999999993,
"heapDeltaBytes": 14015960,
"heapUsedBytes": 84055188,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 114.22,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2002.9289999999946,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.094999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.76399999999995,
"heapDeltaBytes": -6490256,
"heapUsedBytes": 63428612,
"domNodes": -271,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.087,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2003.3050000000685,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.477,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.98299999999995,
"heapDeltaBytes": -7089836,
"heapUsedBytes": 63124092,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.904999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.9890000000155,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.355999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 594.399,
"heapDeltaBytes": -11357236,
"heapUsedBytes": 58801636,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 82.37899999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.3560000000225,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.181,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.434,
"heapDeltaBytes": -7538584,
"heapUsedBytes": 62485192,
"domNodes": -271,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 78.11900000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 868.0409999999483,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.967999999999993,
"layouts": 5,
"layoutDurationMs": 9.28,
"taskDurationMs": 683.819,
"heapDeltaBytes": -6290364,
"heapUsedBytes": 81809840,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 21.145000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.245999999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4492.195,
"heapDeltaBytes": -10438692,
"heapUsedBytes": 76832108,
"domNodes": -213,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 2170.4399999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8240.956000000097,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.694,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4709.158,
"heapDeltaBytes": -20196952,
"heapUsedBytes": 66992828,
"domNodes": -212,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 2215.4379999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 14327.551999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13982.051000000001,
"heapDeltaBytes": -58026220,
"heapUsedBytes": 179141516,
"domNodes": -8062,
"jsHeapTotalBytes": -14790656,
"scriptDurationMs": 200.1,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14289.240999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14069.949,
"heapDeltaBytes": -50736484,
"heapUsedBytes": 188461016,
"domNodes": -8062,
"jsHeapTotalBytes": -6537216,
"scriptDurationMs": 211.327,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16908.23499999999,
"styleRecalcs": 123,
"styleRecalcDurationMs": 14.178999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16678.578999999998,
"heapDeltaBytes": -51097076,
"heapUsedBytes": 186685220,
"domNodes": -8062,
"jsHeapTotalBytes": -9285632,
"scriptDurationMs": 703.011,
"eventListeners": -14928,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13943.730000000072,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13659.468,
"heapDeltaBytes": -67988104,
"heapUsedBytes": 166723276,
"domNodes": -8062,
"jsHeapTotalBytes": -13934592,
"scriptDurationMs": 670.48,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5241.852999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.910000000000025,
"layouts": 20,
"layoutDurationMs": 23.263999999999992,
"taskDurationMs": 5201.965999999999,
"heapDeltaBytes": -35891384,
"heapUsedBytes": 191380584,
"domNodes": -8062,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 120.825,
"eventListeners": -14928,
"totalBlockingTimeMs": 322,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5120.918999999958,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.260000000000005,
"layouts": 20,
"layoutDurationMs": 20.192,
"taskDurationMs": 5066.59,
"heapDeltaBytes": -17765864,
"heapUsedBytes": 197946796,
"domNodes": -8062,
"jsHeapTotalBytes": 21962752,
"scriptDurationMs": 80.34200000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7215.49200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7106.938000000001,
"heapDeltaBytes": -12484652,
"heapUsedBytes": 169522596,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 98.75500000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7178.942000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7005.028000000001,
"heapDeltaBytes": 2079184,
"heapUsedBytes": 185362420,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 101.67900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 100.13000000003558,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.574,
"layouts": 2,
"layoutDurationMs": 0.494,
"taskDurationMs": 72.062,
"heapDeltaBytes": 3229660,
"heapUsedBytes": 69158476,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.359000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 440.21999999995387,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.557,
"layouts": 4,
"layoutDurationMs": 1.688,
"taskDurationMs": 98.318,
"heapDeltaBytes": 5038380,
"heapUsedBytes": 67090068,
"domNodes": 149,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.626999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 6 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19662 +/- ##
============================================
Coverage 84.65% 84.66%
============================================
Files 2314 2314
Lines 131562 131658 +96
Branches 35103 33260 -1843
============================================
+ Hits 111371 111463 +92
- Misses 19833 19836 +3
- Partials 358 359 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Addresses review feedback:\nhttps://github.com//pull/19662#discussion_r4149117364\nhttps://github.com//pull/19662#discussion_r4149117366\nhttps://github.com//pull/19662#discussion_r4149117374\nhttps://github.com//pull/19662#discussion_r4149117385\nhttps://github.com//pull/19662#discussion_r4149117389\nhttps://github.com//pull/19662#discussion_r4149117397\nhttps://github.com//pull/19662#discussion_r4149117405\nhttps://github.com//pull/19662#discussion_r4149117411\nhttps://github.com//pull/19662#discussion_r4149117418
|
Published the current-head review repair. It now falls back to the normal shared funds field for version-skewed payloads, derives impressions from rendered unresolved entries, suppresses duplicate cards, refreshes billing only on a real completed turn, uses stable workspace identity, and defers telemetry until capabilities are authoritative. Focused suite: 263/263; repository typecheck/lint/format/knip hook passed. I kept the standing surface limited to self-serve presentations: Team-member and sales-managed users retain the existing refusal card with their dedicated remediation copy, and broadening persistent UX for those roles is a product-behavior change that should not be introduced in this release backport without review. |
|
Rotating the human approval gate after the prior sole owner remained silent beyond the two-hour window. @DrJKL is now the sole assignee/reviewer. Exact head |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The first two commits restore #19518 faithfully apart from the dropped checkout source, but the third commit rewrites the restored behavior away from #19518 and main, and the #19518 unit tests for the restored code are not carried.
There is no single merged source PR for this branch, so I compared it against what #19518 added to core/1.55 (merge commit b585cee, itself the backport of #18967, 0997dae on main). #19583 (5497096) overwrote AgentPanelRoot.vue and AgentPanelRoot.test.ts and dropped that content, and later spec merges dropped the browser case. I treated "restore what #19518 added and later merges removed" as the source diff.
What matches:
- d886a02 (identical to 41e50fb) restores the #19518 hunks in
AgentPanelRoot.vue: the billing context and capability fields, CTA and impression telemetry, thecreditsExhaustedgate, the episode-scoped standing impression, the post-turn workspace status refresh, and thecredits-exhaustedprop andstanding-paywall-shownlistener. The one exception is the checkout source, noted inline. - 8c177e3 restores the cloud Playwright case "keeps the standing paywall in sync across turn completion and panel close". It is byte-identical to the case at b585cee.
- Locally at 9a5862e:
vitest runoverAgentPanelRoot.test.ts, the agent stores, and theAgentPanelcomponent tests passed (13 files, 443 tests).vue-tsc --noEmitpassed. Hosted checks are green at this head.
What diverges:
- Both CTAs drop the
{ source: 'agent_paywall' }context, and the unit assertion was left without it. The target'suseAccountPreconditionDialogstill accepts and forwards that context. - 9a5862e changes the restored behavior at seven points (inline).
mainstill has the #18967 semantics at each of them, so these are not backports of a latermainfix. If the review findings they answer are real defects, I think they should be fixed onmainfirst and backported separately. They should not be folded into a restoration. - #19583 removed #19518's
AgentPanelRoot standing credits-exhausted paywallandAgentPanelRoot paywall telemetrysuites (about 40 cases), and this branch does not restore them. Several of them pin exactly the semantics the third commit changes. Examples: "shows the standing card when a normal reply follows an older unresolved inline card", "reports an impression once when the read settles as unavailable", "reports a visible paywall as unknown when the read settles without resolving", and "refreshes workspace billing after an active turn becomes idle". The restored production code currently has no unit coverage.
The PR description also says only AgentPanelRoot.vue and its unit suite change, but the diff also touches agentPanel.spec.ts and agentConversationStore.ts.
Addresses #19662 (comment) Addresses #19662 (comment) Addresses #19662 (comment) Addresses #19662 (comment) Addresses #19662 (comment) Addresses #19662 (comment) Addresses #19662 (comment) Addresses #19662 (comment)
|
Addressed the exact-head review at 37c62fc: restored both Agent CTA attribution contexts, the #19518 funds/impression/standing-card/identity/post-turn semantics, removed the branch-only completion counter, and restored the two missing paywall regression suites from b585cee with only target mock adaptation. Verification: 310/310 AgentPanelRoot tests pass; vue-tsc --noEmit passes; commit hooks passed formatting, stylelint, lint, and app typecheck. DrJKL remains the sole human approval owner; fresh hosted checks are running. |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The restored behavior now matches #19518, but the post-turn watcher is reordered for no reason the target needs, the source's comments are dropped, and one #19518 test hunk is not carried.
There is no single merged source PR for this branch. I compared it against what #19518 added to core/1.55, merge commit b585cee, which is itself the backport of #18967. #19583 (5497096) later overwrote AgentPanelRoot.vue and AgentPanelRoot.test.ts, and later spec merges dropped the browser case. I treated restoring that #19518 content as the source diff.
What matches:
- The
AgentPanelRoot.vuepaywall code matches #19518 token for token, apart from the dropped comments: CTA telemetry with{ source: 'agent_paywall' }, thecapabilityReadSettledimpression gate with the'unknown'reason, thecreditsExhaustedgate, the latest-entry suppression, the episode-scoped standing impression, the template prop and listener, and the post-turn refresh condition. Two adaptations are justified. The import keeps onlyAgentPaywallSurfacebecause #19583 removed theAgentErrorMetadatause, and thereportErrorimport comes back because #19583 dropped it. - The
AgentPanelRoot paywall telemetryandAgentPanelRoot standing credits-exhausted paywallsuites, the mock plumbing, and the remaining paywall-action changes match b585cee. The exception is one test, noted inline. The only other differences in the test file come from the target: thedocOpMinterrename and the consent mock. - The cloud Playwright case "keeps the standing paywall in sync across turn completion and panel close" is byte-identical to b585cee.
- At 37c62fc:
vitest runoverAgentPanelRoot.test.ts, the agent stores, and theAgentPanelcomponent tests passed 490/490 across 13 files, andvue-tsc --noEmitpassed. When I fetched the check runs, hostedtestwas still running, and the cloud Playwright project and every other completed check had passed.
What diverges is inline. I checked the watcher order directly: with the #19518 order put back, AgentPanelRoot.test.ts still passes 310/310 on this branch, so the target does not need the reorder.
Addresses review feedback: #19662 (comment)
Addresses review feedback: #19662 (comment)
Addresses review feedback: #19662 (comment)
Summary
Restores the standing credits-exhausted paywall on
core/1.55after the graph rewrite removed the integration added by #19518. This is the independently scoped target prerequisite for #19609; it does not include any ToolCallSummary changes.Scope
41e50fb69d400a62e686e79234c84216b1293044onto currentcore/1.55.AgentPanelRoot.vueand its focused unit suite.Verification
NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts: 263/263 passed.git diff --check origin/core/1.55...HEAD: passed.agent-credits-exhausted-paywallbehavior.Backport of the standing-paywall restoration from #19609 history, independently scoped so the ToolCallSummary carrier remains narrow.