Skip to content

[backport cloud/1.55] fix(agent): clamp skill names safely (#19726) - #19987

Merged
christian-byrne merged 7 commits into
cloud/1.55from
backport-19726-followup-to-cloud-1.55
Oct 3, 2026
Merged

christian-byrne merged 7 commits into
cloud/1.55from
backport-19726-followup-to-cloud-1.55

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Incremental backport of #19726 for cloud/1.55 after its original carrier #19727 landed.

  • clamps over-long live and persisted skill names instead of rejecting their containing frame or transcript
  • clamps by Unicode code point so a boundary emoji is not split
  • preserves the release branch's relaxed parser for historical persisted rows

Validation

  • adds schema regression coverage for live-frame clamping, persisted transcript retention, and a Unicode boundary
  • git diff --check origin/cloud/1.55..HEAD

Excluded

Review-only activity-row refactors and browser selector cleanup are intentionally omitted from the stable branch.

Backport of #19726.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: 8d02baf0-5fd5-40e1-bf88-c866c7b9b9af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2149 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 2128 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/03/2026, 08:04:28 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since c0070c3e9ef294b76ca8f94fc2575ce1472777ba

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 550ms TBT · 69.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 221ms TBT · 87.1 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 887ms TBT · 80.3 MB heap
extension-rgthree-prototype-draw: · 50.0 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 919ms TBT · 81.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 140ms TBT · 80.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.9 MB heap
vue-large-graph-idle: · 57.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.6 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 90ms TBT · 167.6 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 402ms TBT · 172.6 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 439ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.4 MB
canvas-idle: DOM nodes -261
canvas-idle: event listeners -163
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 45
canvas-mouse-sweep: task duration 775ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.7 MB
canvas-mouse-sweep: DOM nodes -260
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 318ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.4 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 442ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.4 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 875ms
dom-widget-order-dense-n200-w200-i120: script duration 72ms
dom-widget-order-dense-n200-w200-i120: TBT 550ms
dom-widget-order-dense-n200-w200-i120: heap used 69.7 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -296
dom-widget-order-dense-n200-w200-i120: event listeners -217
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 441ms
dom-widget-order-sparse-n1000-w20-i120: script duration 156ms
dom-widget-order-sparse-n1000-w20-i120: TBT 221ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.1 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8953ms
extension-clean-combined-draw: script duration 7501ms
extension-clean-combined-draw: TBT 887ms
extension-clean-combined-draw: heap used 80.3 MB
extension-clean-combined-draw: DOM nodes -17
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 20ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 9200ms
extension-rgthree-prototype-draw: script duration 7731ms
extension-rgthree-prototype-draw: TBT 919ms
extension-rgthree-prototype-draw: heap used 81.1 MB
extension-rgthree-prototype-draw: DOM nodes -139
extension-rgthree-prototype-draw: event listeners -76
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 8ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 451ms
large-graph-idle: script duration 31ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 65.9 MB
large-graph-idle: DOM nodes -249
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1565ms
large-graph-pan: script duration 846ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.4 MB
large-graph-pan: DOM nodes -249
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 69
large-graph-zoom: task duration 1566ms
large-graph-zoom: script duration 773ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 62.6 MB
large-graph-zoom: DOM nodes -97
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1743ms
legacy-node-drag: script duration 982ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 69.0 MB
legacy-node-drag: DOM nodes 10
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 452ms
minimap-idle: script duration 30ms
minimap-idle: TBT 0ms
minimap-idle: heap used 67.0 MB
minimap-idle: DOM nodes -248
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 386ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.8 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 442ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.5 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 47
subgraph-mouse-sweep: task duration 700ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.5 MB
subgraph-mouse-sweep: DOM nodes -274
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 864ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 80.9 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5525ms
viewport-pan-sweep: script duration 2890ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 88.9 MB
viewport-pan-sweep: DOM nodes -243
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15632ms
vue-large-graph-idle: script duration 242ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.6 MB
vue-large-graph-idle: DOM nodes -8062
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 165
vue-large-graph-pan: task duration 19770ms
vue-large-graph-pan: script duration 918ms
vue-large-graph-pan: TBT 90ms
vue-large-graph-pan: heap used 167.6 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5757ms
vue-node-resize-workload: script duration 100ms
vue-node-resize-workload: TBT 402ms
vue-node-resize-workload: heap used 172.6 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7961ms
vue-zoom-out-idle: script duration 124ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 158.2 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 80ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.0 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-10-03T20:16:01.834Z",
  "gitSha": "4fbeea1eb84c8aebcf5174a3d166100bdb69e528",
  "branch": "backport-19726-followup-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2007.7949999999873,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.721000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.157,
      "heapDeltaBytes": -9816360,
      "heapUsedBytes": 59220952,
      "domNodes": -260,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.384999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2001.072000000022,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.113999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.29200000000003,
      "heapDeltaBytes": 5158520,
      "heapUsedBytes": 73784176,
      "domNodes": -261,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.561999999999999,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1759.2619999999783,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.544,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 773.726,
      "heapDeltaBytes": -7193540,
      "heapUsedBytes": 61563752,
      "domNodes": -259,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 159.531,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1733.934999999974,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 12.803000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 776.3420000000001,
      "heapDeltaBytes": -7361424,
      "heapUsedBytes": 61580476,
      "domNodes": -261,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 156.494,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.5720000000038,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 14.447000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.1540000000000001,
      "taskDurationMs": 317.912,
      "heapDeltaBytes": 2932496,
      "heapUsedBytes": 71782140,
      "domNodes": 79,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.442,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.61599999994,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.896000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.9030000000000001,
      "taskDurationMs": 318.577,
      "heapDeltaBytes": 2975880,
      "heapUsedBytes": 71763592,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 9.686,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 645.735000000002,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.372,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.25500000000005,
      "heapDeltaBytes": -7595628,
      "heapUsedBytes": 61235652,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 168.38400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 610.561999999959,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.604000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.86199999999997,
      "heapDeltaBytes": 18461800,
      "heapUsedBytes": 86500720,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 165.70499999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1209.101999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 881.7830000000001,
      "heapDeltaBytes": -18400824,
      "heapUsedBytes": 72920612,
      "domNodes": -295,
      "jsHeapTotalBytes": 19267584,
      "scriptDurationMs": 71.79400000000001,
      "eventListeners": -217,
      "totalBlockingTimeMs": 534,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1216.3369999999532,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 867.619,
      "heapDeltaBytes": -14841368,
      "heapUsedBytes": 73150060,
      "domNodes": -297,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 72.758,
      "eventListeners": -217,
      "totalBlockingTimeMs": 566,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 831.3049999999862,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.0349999999994,
      "heapDeltaBytes": 15184808,
      "heapUsedBytes": 90844848,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 155.48800000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 220,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 841.8530000000146,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.84700000000066,
      "heapDeltaBytes": 15347472,
      "heapUsedBytes": 91904992,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 157.40499999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 222,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9892.040000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9035.773000000001,
      "heapDeltaBytes": -10020088,
      "heapUsedBytes": 71179660,
      "domNodes": -18,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 7563.369,
      "eventListeners": 0,
      "totalBlockingTimeMs": 995,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9748.263000000064,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8870.61,
      "heapDeltaBytes": 15959940,
      "heapUsedBytes": 97293272,
      "domNodes": -16,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 7439.255999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 779,
      "frameDurationMs": 19.996666666666716,
      "p95FrameDurationMs": 49.900000000001455
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9998.357999999997,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.1380000000000027,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9129.093,
      "heapDeltaBytes": 5959348,
      "heapUsedBytes": 84776444,
      "domNodes": -270,
      "jsHeapTotalBytes": 2088960,
      "scriptDurationMs": 7643.914,
      "eventListeners": -152,
      "totalBlockingTimeMs": 885,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10179.055999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9271.470000000001,
      "heapDeltaBytes": 9714240,
      "heapUsedBytes": 85209032,
      "domNodes": -8,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7818.174,
      "eventListeners": 0,
      "totalBlockingTimeMs": 952,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.4039999999754,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.191999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.26599999999996,
      "heapDeltaBytes": -16035336,
      "heapUsedBytes": 73388304,
      "domNodes": -244,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 30.858000000000004,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.688999999943,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.833000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.24800000000005,
      "heapDeltaBytes": -24133324,
      "heapUsedBytes": 64847400,
      "domNodes": -254,
      "jsHeapTotalBytes": 3698688,
      "scriptDurationMs": 30.961000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2201.661999999999,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.393,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1562.634,
      "heapDeltaBytes": -24478060,
      "heapUsedBytes": 65804944,
      "domNodes": -244,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 846.888,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2197.541000000001,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 19.814999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1568.205,
      "heapDeltaBytes": -1726432,
      "heapUsedBytes": 88217780,
      "domNodes": -254,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 846.076,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3444.0290000000005,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 11.817999999999994,
      "layouts": 60,
      "layoutDurationMs": 12.472000000000001,
      "taskDurationMs": 1562.7560000000003,
      "heapDeltaBytes": -232032,
      "heapUsedBytes": 65662600,
      "domNodes": 30,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 771.766,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3511.3959999999906,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.210999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.525,
      "taskDurationMs": 1569.357,
      "heapDeltaBytes": -121340,
      "heapUsedBytes": 65631652,
      "domNodes": -223,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 774.5600000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3034.140999999977,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.460000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1832.671,
      "heapDeltaBytes": -17878052,
      "heapUsedBytes": 75643628,
      "domNodes": 12,
      "jsHeapTotalBytes": 7114752,
      "scriptDurationMs": 987.087,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2753.7790000000086,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 6.713999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1654.099,
      "heapDeltaBytes": 3262336,
      "heapUsedBytes": 69025272,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 976.0360000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2032.451999999978,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.799000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.7270000000001,
      "heapDeltaBytes": -23930044,
      "heapUsedBytes": 66458800,
      "domNodes": -254,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 29.148,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2019.9569999999767,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.315000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.379,
      "heapDeltaBytes": -16733508,
      "heapUsedBytes": 74067540,
      "domNodes": -242,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 30.05,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 590.5730000000062,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.102,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 384.73500000000007,
      "heapDeltaBytes": 13269836,
      "heapUsedBytes": 83863756,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.876,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 575.3010000000813,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 11.241999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.365,
      "heapDeltaBytes": 13780716,
      "heapUsedBytes": 83589032,
      "domNodes": 23,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.624,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.6689999999644,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.139,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 445.27,
      "heapDeltaBytes": 1446192,
      "heapUsedBytes": 71494384,
      "domNodes": -274,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.9910000000000005,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.3339999999716,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.702000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 439.27500000000003,
      "heapDeltaBytes": -7146624,
      "heapUsedBytes": 63805588,
      "domNodes": -275,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.276,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1703.9890000000355,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 15.124000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 692.097,
      "heapDeltaBytes": -11437600,
      "heapUsedBytes": 59401132,
      "domNodes": -274,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 99.39700000000002,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.5049999999455,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.705000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 707.101,
      "heapDeltaBytes": 5440096,
      "heapUsedBytes": 75805084,
      "domNodes": -273,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 102.138,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.0770000000475,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 27.985999999999997,
      "layouts": 5,
      "layoutDurationMs": 12.801,
      "taskDurationMs": 864.444,
      "heapDeltaBytes": -6258216,
      "heapUsedBytes": 84839188,
      "domNodes": 13667,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 28.348,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8297.375999999986,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 35.846999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5502.537,
      "heapDeltaBytes": 5370468,
      "heapUsedBytes": 94600500,
      "domNodes": -240,
      "jsHeapTotalBytes": -8192,
      "scriptDurationMs": 2865.378,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8350.42199999998,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 33.840999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5547.59,
      "heapDeltaBytes": 2588124,
      "heapUsedBytes": 91815960,
      "domNodes": -246,
      "jsHeapTotalBytes": 1007616,
      "scriptDurationMs": 2915.002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16536.88999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15630.865000000002,
      "heapDeltaBytes": -55924780,
      "heapUsedBytes": 185275916,
      "domNodes": -8062,
      "jsHeapTotalBytes": -16453632,
      "scriptDurationMs": 242.675,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16474.403999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15634.059999999998,
      "heapDeltaBytes": -60066912,
      "heapUsedBytes": 174604312,
      "domNodes": -8061,
      "jsHeapTotalBytes": -6303744,
      "scriptDurationMs": 241.786,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20251.914999999997,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 15.805000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19873.349,
      "heapDeltaBytes": -54473004,
      "heapUsedBytes": 181171876,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14540800,
      "scriptDurationMs": 841.75,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 66,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19984.783999999992,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 16.03299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19666.316000000003,
      "heapDeltaBytes": -69550232,
      "heapUsedBytes": 170328612,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17281024,
      "scriptDurationMs": 994.015,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 113,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5850.265000000036,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.322,
      "layouts": 20,
      "layoutDurationMs": 22.618,
      "taskDurationMs": 5734.165999999999,
      "heapDeltaBytes": -57826208,
      "heapUsedBytes": 183690576,
      "domNodes": -8061,
      "jsHeapTotalBytes": 12644352,
      "scriptDurationMs": 98.327,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 420,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5883.204999999975,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.41500000000003,
      "layouts": 20,
      "layoutDurationMs": 21.45000000000001,
      "taskDurationMs": 5780.505,
      "heapDeltaBytes": -36825720,
      "heapUsedBytes": 178285716,
      "domNodes": -8061,
      "jsHeapTotalBytes": 17178624,
      "scriptDurationMs": 101.13999999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 384,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8314.409000000069,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8031.4259999999995,
      "heapDeltaBytes": -18721772,
      "heapUsedBytes": 166254832,
      "domNodes": 0,
      "jsHeapTotalBytes": -25427968,
      "scriptDurationMs": 128.797,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8264.518000000066,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7890.7570000000005,
      "heapDeltaBytes": 4925240,
      "heapUsedBytes": 165462164,
      "domNodes": -1,
      "jsHeapTotalBytes": -11796480,
      "scriptDurationMs": 119.59299999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.28399999996964,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.482,
      "layouts": 2,
      "layoutDurationMs": 0.6179999999999999,
      "taskDurationMs": 84.416,
      "heapDeltaBytes": 3203780,
      "heapUsedBytes": 69889708,
      "domNodes": 111,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.794,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.8680000000013,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.751,
      "layouts": 3,
      "layoutDurationMs": 1.654,
      "taskDurationMs": 76.211,
      "heapDeltaBytes": 3017020,
      "heapUsedBytes": 68607956,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.638,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52776 79778 66.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1168
src/LGraphNode.ts 70.6% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 73.2% 254
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/pnginfo.ts 20.7% 222

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 3, 2026
@github-actions
github-actions Bot requested a review from ryan-di October 3, 2026 06:48

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 6 finding(s).

Severity Count
🟠 High 1
🟡 Medium 1
🟢 Low 2
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.55   #19987   +/-   ##
=============================================
  Coverage              ?   84.94%           
=============================================
  Files                 ?     2327           
  Lines                 ?   133228           
  Branches              ?    33805           
=============================================
  Hits                  ?   113170           
  Misses                ?    19696           
  Partials              ?      362           
Flag Coverage Δ
e2e 66.19% <ø> (?)
unit 81.02% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

A skill name is a display label; nothing resolves against it. Bounding it
with `.max(256)` therefore bought a cosmetic guarantee at the price of the
frame it rides on, and in both directions:

- live, `useAgentSession`'s `onRaw` drops an `agent_tool_call` that fails
  the schema, so the row the user is watching never settles and shimmers
  on "Loading <skill>" indefinitely;
- on reload, `zAgentMessages` runs through `agentRestClient`'s `request`,
  which calls `parse`, so a single over-long row throws away the entire
  thread transcript rather than one tool chip.

Before this branch the field was stripped at the `zAgentMessageContent`
boundary, so neither could happen; routing the persisted parse through
`zPersistedToolCallSummary` is what exposed it. Clamp instead, the same
keep-the-frame choice `zAgentMessageDoneData.usage` makes with `.catch`,
and the opposite of `node_locator_id`, which is an identity later code
resolves and so must refuse a value it cannot honour.

Both regressions fail on the rejecting schema and pass on the clamp.
@christian-byrne
christian-byrne force-pushed the backport-19726-followup-to-cloud-1.55 branch from 9b83777 to 81ef0b3 Compare October 3, 2026 18:14
@christian-byrne christian-byrne assigned dante01yoon and DrJKL and unassigned ryan-di Oct 3, 2026
@christian-byrne
christian-byrne requested a review from DrJKL October 3, 2026 19:49
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Justification: release backport exact-head exception. Human reviewer huang47 approved exact head 5851822; all required checks are terminal green with no open substantive finding. The live cloud/1.55 target advanced by five commits after this head was tested, and the target-aware gate reports zero file overlap between that delta and this three-file Agent skill-name change. I independently verified the disjoint file sets and am using the recorded zero-overlap judgment permitted by the binding gate.

@christian-byrne
christian-byrne merged commit 49fbd54 into cloud/1.55 Oct 3, 2026
111 checks passed
@christian-byrne
christian-byrne deleted the backport-19726-followup-to-cloud-1.55 branch October 3, 2026 20:44

@mrseek-reviews mrseek-reviews Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. The remaining #19726 schema change is carried with the right relocation for cloud/1.55, but it adds a pre-slice that is not in the source and leaves out the source's browser regression test.

I compared against #19726's merge commit 2409252b6459542be6493f05f27305b53f5df829. #19727 (4086964e48) had already carried an earlier revision of #19726, so I compared the combined cloud/1.55 state against the merged source, from before #19727 up to this head.

Accounted for by the target:

  • zAgentMessageContent.tool_calls on cloud/1.55 is the relaxed z.array(z.unknown()) from #19607's backport, so a persisted skill is parsed per entry in parseToolCallEntry, not at the content boundary. That is why the source's "keeps a whole transcript readable when one persisted skill is over-long" case in agentApiSchema.test.ts moves to agentTranscript.test.ts and goes through normalizeAgentTranscript. It is also why zPersistedToolCallSummary only swaps its existing skill field to zSkillName, and why the comment says "the persisted tool call" in place of "the whole persisted transcript". Both describe this branch accurately.
  • zSkillName, the live zAgentToolCallData.skill, and the live-frame and Unicode-boundary cases match the source.

Divergences, each commented inline:

  1. a930719 bounds the input with skill.slice(0, SKILL_NAME_MAX * 2) before the code-point clamp. #19726 does not do this. It answers an automated review finding, and if it is worth having it should land on main first.
  2. The source's browser_tests/tests/agent/agentPersistedSkillActivity.spec.ts and its fixture support are not carried, in this PR or in #19727. That support is completeLatestTurn and the agentPanel fixture in agentPromptHistoryFixture.ts, plus workSummary, chooseWorkflow, openWorkSummary and reload in AgentPanel.ts, and TestIds.agent.activityTrace. The description calls this browser selector cleanup, but it is the end-to-end test that a reloaded transcript names the loaded skill, which is the behavior this backport fixes. Please carry it, or say what cloud/1.55 lacks that keeps it from running.

The activity-row refactor that is also left out (matchingToolStep against the branch's isSameToolStep) behaves the same, so I am not asking for it. CI at 5851822 is green (lint-and-format, test, e2e-status, typecheck).

christian-byrne added a commit that referenced this pull request Oct 3, 2026
@christian-byrne christian-byrne removed the cursor-review Trigger multi-model Cursor agent review on this PR label Oct 3, 2026
christian-byrne added a commit that referenced this pull request Oct 3, 2026
## Summary

- match the merged source clamp exactly by removing the backport-only
pre-slice
- carry the missing browser regression that verifies a reloaded
transcript names its loaded skill

Follow-up to post-merge review on #19987.

## Testing

- `vitest` focused schema and transcript suites: 73 passed
- browser typecheck reaches unrelated existing branch/dependency errors;
the follow-up-specific missing type was fixed

Base branch: `cloud/1.55`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants