Skip to content

feat(website): give workflows and apps their own hub pages, and move app pages to /hub/apps - #19594

Merged
benjcooley merged 11 commits into
mainfrom
maanil/hub-sections
Sep 30, 2026
Merged

benjcooley merged 11 commits into
mainfrom
maanil/hub-sections

Conversation

@MaanilVerma

Copy link
Copy Markdown
Collaborator

Summary

Workflows and apps get their own hub pages, /hub/workflows/ and /hub/apps/, instead of living as ?type= tabs of /hub/models/, and the two app pages move to /hub/apps/<slug>/. /hub/models/ stays models only, with its "ComfyUI models" H1 and A to Z directory.

Part of FE-2912

Deploy order: this PR goes live before the router change (Comfy-Org/comfy-router#49). The router is what sends /hub/workflows/ and /hub/apps/* on comfy.org to this site, so shipping it first would turn both pages into 404s.

Changes

The section pages (first half):

  • src/routes/models/hub-section.astro builds /hub/workflows/ and /hub/apps/, each with its own title, meta description, H1 and self-canonical, and mounts ModelsPage with a section prop. It throws at build time for a pattern it has no section for.
  • Changed from the plan: the title, description and H1 (en and zh-CN) live in hub-section-copy.ts, not translations.ts. translations.ts ships whole to every island, so the six strings would have added about 1 KB for every visitor and pushed /hub/models/ past the models-performance JavaScript ceiling. They are only server-rendered.
  • ModelsCatalogue renders the one section it is given rather than reading ?type=, and counts catalogue_viewed once per page with that section's content type.
  • CatalogueTabs has a links mode that renders <a aria-current="page"> inside a <nav>. The hub pages use it; the homepage toggle keeps its buttons. The Workflows and Apps tabs are gated by the same flags as today.
  • With the workflows or apps flag off, ModelsPage shows the same showcase fallback the workflow detail pages use, and the section heading goes with the rest of the page. The heading is still server-rendered over the loading state.
  • The registry has a new section kind for the two pages: navigable, and out of the sitemap unless indexable. /hub/workflows/ follows launchedWorkflowPages (noindex today); /hub/apps/ is always noindex. The llms.txt test now takes its exclusions from the sitemap policy, so it skips both.
  • /hub/models/?type=workflows (or workflow) and ?type=apps run a small head script that replaces the URL with the section page, keeping the other query parameters and the hash.
  • Back to workflows, the workflow shelf pills, the homepage workflows button and Back to apps now link the section pages. routes.ts gains hubWorkflows and hubApps, both locale-invariant.

The app move (second half):

  • Cinematic Studio and Re-shoot build at /hub/apps/<slug>/. apps/<slug> stays the id for content, flags and analytics.
  • src/config/hub-app-names.json lists the built apps, kept honest by a file-snapshot test like hub-workflow-names.json. The registry, the redirects, the noindex list and the stale-link check all read it.
  • /models/apps/<slug> and /models/apps/<slug>/ send a temporary redirect to /hub/apps/<slug>/, and they go permanent once the router serves /hub/apps/ on production. vercel.json gains exactly those four rows.
  • The README, the content README, model-urls.ts and MODEL_URL_MAP.md describe the new layout.

Review Focus

  • The section pages have no markdown twin (/hub/workflows.md, /hub/apps.md), which is deliberate: like every noindex page they are out of the sitemap, so the twins integration skips them. Router Add windows expectations #49 routes those two .md paths here, so they will 404 until the pages are indexable.
  • Between this deploy and router Add windows expectations #49, /models/apps/<slug> redirects to /hub/apps/<slug>/ on comfy.org before the router sends that path here. Apps are behind workshop-apps-enabled, so only people with the flag are affected, and only for that window.
  • A flag-off visitor who follows an old ?type=workflows link now lands on the showcase at /hub/workflows/ rather than on the models catalogue. That is the owner's call from the plan (hub-section.astro, ModelsPage.vue:34).

QA

  • Unit: the full website suite passes, and each new or changed test failed against the code with its change reverted.
  • /hub/models/ loads 1,824,561 bytes of JavaScript, 357 fewer than main, under the 1,825,000 ceiling.
  • Build with the CI env (WORKSHOP_IN_BUILD=1, indexable), release gate green; check:hreflang, validate:llms-txt-links, validate:jsonld pass.
  • Website e2e on desktop and mobile, run twice.
  • WORKSHOP_IN_BUILD=0 build keeps every Models page, the two new ones included.
  • Browser pass on astro preview: the three hub pages, both app pages, three workflow pages and the ?type= links, flags on and off, desktop and mobile.
  • check:link-slashes failed only on /customers/svedka-silverside, which came from main and is fixed there by fix(website): unblock builds and defer offscreen footer loading #19580.

Proof for each line is in the QA comment.

/hub/workflows/ and /hub/apps/ are static pages with their own title,
description, H1 and canonical, each mounting one section of the
catalogue. The catalogue tabs become links between the three hub pages.
Behind their flags the pages show the showcase, like the workflow
pages, and both stay noindex: /hub/workflows/ follows
launchedWorkflowPages, /hub/apps/ has no switch yet.
/hub/models/?type=workflows (or workflow) and ?type=apps replace
themselves with /hub/workflows/ and /hub/apps/, keeping every other
query parameter and the hash. The script runs in the head, before the
catalogue island loads.
Back to workflows, the workflow shelf pills, the homepage workflows
button and Back to apps now link /hub/workflows/ and /hub/apps/ instead
of a ?type= tab of /hub/models/.
Cinematic Studio and Re-shoot now build at /hub/apps/<slug>/, next to
the /hub/apps/ page that lists them; the apps/<slug> id stays the key
for content, flags and analytics. hub-app-names.json lists the built
apps once, like hub-workflow-names.json, and the URL registry, noindex
list and stale-link check read it. /cinematic-studio follows routes.ts.
Both slash forms of /models/apps/<slug> send a temporary redirect to
/hub/apps/<slug>/. They go permanent once comfy-router sends /hub/apps/
to this site on production. vercel.json is regenerated with sync:redirects
and gains only these four rows.
hub-section.astro picked workflows for any pattern that was not
/hub/apps; it now looks the section up by pattern and throws for one it
does not know.
routes.ts is imported by islands and cannot import hub-models.ts, which
pulls in the model URL map, so each keeps its own copy of the hub and
app paths. The test fails when they drift.
The workflows and apps specs open /hub/workflows/ and /hub/apps/, follow
the tab links, the shelf pills and the old ?type= links, and check the
showcase behind each flag; the app specs use /hub/apps/<slug>/. The
homepage toggle keeps its buttons and its button leads to the page of
the half it shows, and the built hub pages each carry their own title,
H1 and canonical.
translations.ts ships whole to every island, so the six new strings for
the section pages' title, description and H1 grew the translations chunk
by about 1 KB for every visitor and pushed /hub/models/ past the
models-performance JavaScript ceiling (1,825,615 of 1,825,000 bytes).
The copy is only server-rendered, so it moves to hub-section-copy.ts;
the route is back to 1,824,561 bytes, 357 under main.
oxfmt folds the two-entry list onto one line on commit, so the file
snapshot never matched what JSON.stringify writes. The test now reads
the JSON and compares the names.
@MaanilVerma
MaanilVerma requested a review from a team September 30, 2026 07:42
@MaanilVerma MaanilVerma added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 30, 2026
@MaanilVerma MaanilVerma self-assigned this Sep 30, 2026
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 7:42am UTC
billing-web-test Ignored Ignored Sep 30, 2026 7:42am UTC

Request Review

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

This candidate changes nothing the matrix measures, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 2a65cb56f0735b62e66719bf60ac6b7f7c3d8f50

Full docs: ADR-DEVEX-LINT-0015

🔗 Website Preview

Website Preview: https://comfy-website-preview-pr-19594.vercel.app

Models is built and gated by PostHog (workshop-enabled), using staging Cloud.

This commit: https://website-frontend-d9tjr719o-comfyui.vercel.app

Last updated: 2026-09-30T08:24:17Z for 618a784

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 30, 2026
@MaanilVerma

MaanilVerma commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator Author

QA for 618a784

Everything below ran locally on head 618a7842ef, built from origin/main at 07779a14ff. "Main" means a throwaway build of that same base, used for before/after numbers.

Unit, types, lint

Check Command Result
Website unit suite pnpm exec vitest run (apps/website) 563 files, 10,565 passed, 4 skipped
Tests fail without the change each change below reverted, its test rerun 11 of 11 went red
Types pnpm typecheck (apps/website) 0 errors
Lint eslint and oxlint --type-aware on every touched file, eslint apps/website/e2e exit 0
Dead code pnpm knip exit 0

The reverts that went red: the section branch of isIndexableModelPage, hubAppSlugs in the stale-link list, the apps gate in ModelsPage, aria-current and the workflows href in CatalogueTabs, the /models/apps redirect rows, the registry alias, hubAppHref in workshop-app-content, and the three back links (Back to workflows, Back to apps, the homepage workflows button).

Build with the CI env

WORKSHOP_IN_BUILD=1 PUBLIC_WORKSHOP_ROUTER_RUN=1 WEBSITE_INDEXABLE=1 PUBLIC_WORKSHOP_CLOUD_ENV=test pnpm build:e2e: 1,195 pages, release gate green (every built page under /models, /hub/models, /hub/workflows and /hub/apps is registered, and no page links an old /models address).

Check Result
check:hreflang pass, 948 pages
validate:llms-txt-links pass, 225 links
validate:jsonld pass, 950 pages
check:models-html pass, 148 model pages
check:link-slashes one finding, /customers/svedka-silverside on /platform/comfy-api/. Main gives the same finding, and #19580 has since fixed it on main.

WORKSHOP_IN_BUILD=0 pnpm build passes its gate ("every page builds"). list:models-pages gives the same 184 pages with and without Workshop, hub/workflows/index.html and hub/apps/index.html included.

E2E, desktop and mobile, port 4391

Run Result
Final head, run 1 642 passed, 13 failed
Final head, run 2 648 passed, 7 failed
Every failure from both runs, alone (--workers=1) 14 tests, 33 instances, all passed
Main, same machine, same command 638 passed, 11 failed

All the failures are 5 to 6 second timeouts or timing budgets under ten parallel workers, in the same families main fails in (navigation dropdowns, FDCT Q&A, header fit, API tab, render guard). The one that touches this PR is models-render-guard "/hub/models/ with the flag on settles", which fails its 1,000 ms loader grace under load on main as well. Run serially it passes 20 of 20 on both builds. Timed alternately under 6x CPU throttle, the catalogue loader clears at a median of 355 ms here against 377 ms on main, so the change did not slow it down.

Browser pass on astro preview

11 URLs, flags on and off, at Desktop Chrome and Pixel 5: 44 page loads. Mobile matched desktop on every row (H1, final URL, tabs).

Flags Opened Landed on Visible H1 Tabs (* current) Internal links checked
on /hub/models/ /hub/models/ ComfyUI models Models*·Workflows·Apps 187
on /hub/workflows/ /hub/workflows/ ComfyUI workflows Models·Workflows*·Apps 69
on /hub/apps/ /hub/apps/ ComfyUI apps Models·Workflows·Apps* 41
on /hub/apps/cinematic-studio/ same Cinematic Studio none 39
on /hub/apps/reshoot/ same Re-shoot a video none 38
on /hub/workflows/change-material/ same Change a material none 42
on /hub/workflows/remove-background/ same Remove an image background none 42
on /hub/workflows/image-to-video/ same Turn an image into a video none 42
on /hub/models/?type=workflows&q=x /hub/workflows/?q=x ComfyUI workflows Models·Workflows*·Apps 51
on /hub/models/?type=apps /hub/apps/ ComfyUI apps Models·Workflows·Apps* 41
on / / Professional Control of Visual AI Models*·Workflows (buttons) 54
off /hub/models/ /hub/models/ ComfyUI models none 184
off /hub/workflows/ /hub/workflows/ Grok Imagine in ComfyUI (showcase) none 38
off /hub/apps/ /hub/apps/ Grok Imagine in ComfyUI (showcase) none 38
off both app pages same none, "not open yet" notice as on main none 36
off the three workflow pages same Grok Imagine in ComfyUI (showcase) none 38
off /hub/models/?type=workflows&q=x /hub/workflows/?q=x Grok Imagine in ComfyUI (showcase) none 38
off /hub/models/?type=apps /hub/apps/ Grok Imagine in ComfyUI (showcase) none 38
off / / Professional Control of Visual AI none 43

Titles and canonicals, from the same loads:

Page Title Canonical Robots
/hub/models/ ComfyUI Models: Run AI Image, Video & Audio Models - Comfy https://comfy.org/hub/models/ indexable
/hub/workflows/ ComfyUI Workflows: Multi-Step AI Image & Video Workflows - Comfy https://comfy.org/hub/workflows/ noindex, nofollow
/hub/apps/ ComfyUI Apps: Creative Tools Built from Workflows - Comfy https://comfy.org/hub/apps/ noindex, nofollow
/hub/apps/cinematic-studio/ Cinematic Studio - Comfy https://comfy.org/hub/apps/cinematic-studio/ noindex, nofollow
/hub/apps/reshoot/ Re-shoot a video - Comfy https://comfy.org/hub/apps/reshoot/ noindex, nofollow

Console errors: none from site code. The harness blocks every external host, and every console error traces to that (3,905 blocked requests, the footer logo frames and showcase captions on media.comfy.org) or to /_vercel/insights/script.js, which 404s on every page because preview has no Vercel runtime.

Failed requests: /_vercel/insights/script.js on all 44 loads, plus 18 ERR_ABORTED on the two ?type= rows only, which are the old page's requests cut off by location.replace.

Internal links: every /-relative and https://comfy.org link on each page, nav and footer included, fetched without following redirects. None redirects, 404s or lands on a redirect stub, apart from the /workflows/* links in the nav, footer and showcase. Those belong to the Workflows app behind the router, aren't built by this site, and show up the same way on main.

Clicked through, desktop and mobile:

  • The homepage toggle keeps aria-pressed buttons. Its button reads /hub/models/ on Models and /hub/workflows/ on Workflows.
  • Back to workflows lands on /hub/workflows/, and the shelf pill lands on /hub/workflows/?category=product with 1 filter on.
  • Back to apps lands on /hub/apps/.
  • Models → Workflows → Apps → Models through the tabs lands on each page with aria-current="page" and that page's H1.
  • /cinematic-studio/?app=reshoot&ux=d lands on /hub/apps/reshoot/?ux=d.

vercel.json

pnpm sync:redirects, then compared with main: 853 rows before, 857 after, 4 added, 0 removed, the old rows in the same order, and no other key changed.

Source Destination Permanent Destination built Second hop
/models/apps/cinematic-studio /hub/apps/cinematic-studio/ false yes no
/models/apps/cinematic-studio/ /hub/apps/cinematic-studio/ false yes no
/models/apps/reshoot /hub/apps/reshoot/ false yes no
/models/apps/reshoot/ /hub/apps/reshoot/ false yes no

Sitemap, llms.txt and twins

Check Result
Sitemap URLs 855 on main, 855 here, none added or removed
Noindex pages in the sitemap 0 (every sitemap URL's built HTML checked for noindex)
/hub/workflows/, /hub/apps/ or /hub/apps/* in the sitemap none
Markdown twins 856 on main, 856 here; /hub/models.md exists, /hub/workflows.md, /hub/apps.md and the app .md files don't
llms.txt, llms-full.txt no /hub/workflows/, /hub/apps or /models/apps link

Leftover links in dist

A crawl of all 2,323 html, md, json, txt, xml and js files in dist: 0 files contain /models/apps and 0 contain a ?type=workflows or ?type=apps link. Main's build has /models/apps in 5 files and 3 type= links. The only ?type= left anywhere is a civitai download URL on a supported-models page.

Client JavaScript

The chunks this diff touches, main against here:

Chunk Raw bytes Gzip bytes
ModelsCatalogue 45,615 → 44,628 14,238 → 13,931
CatalogueTabs 2,340 → 2,629 1,234 → 1,335
ModelsPage 8,711 → 8,952 3,455 → 3,538
routes 5,986 → 6,086 2,187 → 2,214
HeaderMain 66,251 → 66,251 unchanged
translations unchanged unchanged
All client JS 8,921,900 → 8,921,506 2,550,826 → 2,550,651

models-performance counts the JavaScript /hub/models/ loads: 1,824,918 bytes on main, 1,824,561 here, against a 1,825,000 ceiling.

Self-review against Ben's defect classes

Class What I found Fix or proof
Client bundle growth Six page strings in translations.ts grew the translations chunk by 1,054 bytes for every visitor and pushed /hub/models/ to 1,825,615, over the ceiling, so models-performance failed. 8baff22 moves them to server-only hub-section-copy.ts. The same test passes at 1,824,561, and the chunk table above shows no data module reaching an island.
Hardcoded paths NOINDEX_ROUTES named the two apps by hand. routes.ts keeps its own copy of the hub paths because islands import it and hub-models.ts pulls in the model URL map. The noindex list now derives from hub-app-names.json. 83ea89b fails if routes.ts drifts from HUB_*_PATH or hubAppHref. The dist crawl above finds 0 leftovers.
Tests that can't fail The first hub-app-names test compared file text, and oxfmt folds the two-entry list on commit, so it failed on the committed file. 618a784 compares the parsed JSON with a non-empty guard. Every new test went red with its change reverted (11 of 11). No test.fail in the touched specs.
Silent failures hub-section.astro fell back to workflows for any unknown pattern. A ?type= value other than workflows, workflow or apps stays on /hub/models/, which is the models page it always showed. 7473efe throws at build time for an unknown pattern. An unregistered built page fails the release gate, and a missing app redirect fails redirects.test.
Head, indexing and twins Both new pages are noindex with a self-canonical in the indexable build, which is the #19362 case. They have no hreflang and no JSON-LD, and they stay out of the sitemap, twins and llms.txt. In a preview build every page, these included, is noindex with no canonical. The flags are client-side, so SSR head is the same with them on or off. Head table above; indexing.test rows for both pages with workflows launched on and off; the Hub pages e2e reads canonical and robots from dist.
Duplicated sources of truth The section list is the CatalogueTab union, and each map keyed by it (labels, hrefs, SUBTITLE_KEY, HUB_SECTION_COPY) is satisfies Record<…>, so a missing section is a type error. The built apps are listed once in hub-app-names.json. Registry, redirects, noindex list and stale-link check all read hubAppSlugs.
Cross-PR and deploy Of what router #49 hands to the website, this build has /hub/workflows/, /hub/apps/, /hub/apps/cinematic-studio/ and /hub/apps/reshoot/. It has no /hub/workflows.md or /hub/apps.md, on purpose: noindex pages get no twin, so those two 404 until the pages are indexable. Said in the PR description. /models/apps/* redirects to /hub/apps/*, which comfy.org only serves here once #49 is live, so this PR ships first and #49 soon after.
Description vs code Each behaviour in the description maps to a hunk or a test. Checked against the final diff before posting.
Mutable exports, escaping, stale docs hubAppSlugs is readonly string[] and the new maps are as const. vercel.json comes from JSON.stringify. Astro serialises the define:vars values. routes.ts, the READMEs, model-urls.ts and MODEL_URL_MAP.md no longer say the apps stay at /models/apps. The README's older "Models rollout" section still describes /models from before the hub move. That text isn't touched here, and I've left it for a docs pass.

Cursor review follow-up

Check Result
The 7 Cursor threads, handled in #19605 (head b84045e29e, on main after this merged) ?type= forward waits for the flags and only fires with the section on; /hub/workflows/ noindex whatever launchedWorkflowPages says; zh-CN copy dropped; "All apps" is an h2. Proof is in the #19605 QA comment.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ffcc79f8-3b52-4024-b458-04fdf284b97b

📥 Commits

Reviewing files that changed from the base of the PR and between 2a65cb5 and 618a784.

📒 Files selected for processing (45)
  • apps/website/MODEL_URL_MAP.md
  • apps/website/README.md
  • apps/website/e2e/homepage.spec.ts
  • apps/website/e2e/workshop-apps.spec.ts
  • apps/website/e2e/workshop-workflows.spec.ts
  • apps/website/e2e/workshop.spec.ts
  • apps/website/scripts/generate-model-url-map.ts
  • apps/website/src/components/home/ModelDiscoverySection.test.ts
  • apps/website/src/components/home/ModelDiscoverySection.vue
  • apps/website/src/components/workshop/CatalogueTabs.vue
  • apps/website/src/components/workshop/ModelDetail.test.ts
  • apps/website/src/components/workshop/ModelsCatalogue.test.ts
  • apps/website/src/components/workshop/ModelsCatalogue.vue
  • apps/website/src/components/workshop/ModelsPage.test.ts
  • apps/website/src/components/workshop/ModelsPage.vue
  • apps/website/src/components/workshop/WorkflowCatalogue.test.ts
  • apps/website/src/components/workshop/WorkflowPage.test.ts
  • apps/website/src/components/workshop/WorkflowPage.vue
  • apps/website/src/components/workshop/WorkshopSearchPanel.test.ts
  • apps/website/src/components/workshop/cinematic-studio/AppsBackLink.vue
  • apps/website/src/components/workshop/cinematic-studio/CinematicStudio.test.ts
  • apps/website/src/config/hub-app-names.json
  • apps/website/src/config/hub-app-names.test.ts
  • apps/website/src/config/hub-models.test.ts
  • apps/website/src/config/hub-models.ts
  • apps/website/src/config/indexing.test.ts
  • apps/website/src/config/indexing.ts
  • apps/website/src/config/llms-txt.test.ts
  • apps/website/src/config/model-urls.ts
  • apps/website/src/config/models-url-registry.test.ts
  • apps/website/src/config/models-url-registry.ts
  • apps/website/src/config/redirects.test.ts
  • apps/website/src/config/redirects.ts
  • apps/website/src/config/routes.test.ts
  • apps/website/src/config/routes.ts
  • apps/website/src/config/workshop-app-content.test.ts
  • apps/website/src/config/workshop-app-content.ts
  • apps/website/src/content/README.md
  • apps/website/src/integrations/workshop-release-gate.test.ts
  • apps/website/src/integrations/workshop-release-gate.ts
  • apps/website/src/lib/workshop/apps.test.ts
  • apps/website/src/routes/models/hub-section-copy.ts
  • apps/website/src/routes/models/hub-section.astro
  • apps/website/src/routes/models/index.astro
  • apps/website/vercel.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The website adds dedicated Hub routes for workflows and apps, moves app pages from /models/apps/ to /hub/apps/, and updates catalogue rendering, navigation, feature gating, indexing, redirects, and related tests and documentation.

Changes

Hub catalogue pages

Layer / File(s) Summary
Hub routes and legacy URL handling
apps/website/src/config/*, apps/website/src/integrations/workshop-release-gate.ts, apps/website/src/routes/models/*, apps/website/vercel.json, apps/website/README.md, apps/website/src/content/README.md, apps/website/MODEL_URL_MAP.md, apps/website/scripts/generate-model-url-map.ts
Adds locale-invariant Hub routes and app-page paths. Registers legacy app paths as aliases or redirects, updates indexing rules, and documents the route changes.
Section rendering and feature gates
apps/website/src/components/workshop/CatalogueTabs.vue, apps/website/src/components/workshop/ModelsCatalogue.vue, apps/website/src/components/workshop/ModelsPage.vue, apps/website/src/routes/models/hub-section*, apps/website/e2e/workshop.spec.ts
Renders the requested catalogue section, provides link-based section navigation, and gates workflow and app content with their respective flags. Adds localized section copy and showcase fallbacks.
Hub navigation and page interactions
apps/website/src/components/home/ModelDiscoverySection*, apps/website/src/components/workshop/WorkflowPage*, apps/website/src/components/workshop/cinematic-studio/*, apps/website/e2e/homepage.spec.ts, apps/website/e2e/workshop-apps.spec.ts, apps/website/e2e/workshop-workflows.spec.ts, apps/website/src/components/workshop/*test.ts
Updates homepage and workflow links to use dedicated Hub routes. Updates app and workflow tests for the new paths, tab state, redirects, query preservation, and feature-flag behavior.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant HubSection as hub-section.astro
  participant ModelsPage
  participant FeatureFlags as Workshop feature flags
  participant ModelsCatalogue
  HubSection->>ModelsPage: Render selected section
  ModelsPage->>FeatureFlags: Read workflow or app flag
  FeatureFlags-->>ModelsPage: Return flag state
  ModelsPage->>ModelsCatalogue: Render enabled section
  ModelsPage-->>HubSection: Render showcase fallback when gated
Loading

Suggested reviewers: benjcooley

Merge Risk: ⚪ Minimal · up to 618a7

The Hub migration has no established merge-blocking issue. Coordinate deployment with the production router change; temporary redirects alone do not guarantee the new destinations are reachable.

Security Architecture Review

Security architecture risk: 🟡 Moderate · up to 618a7

Workflow and app pages retain their visibility controls, and legacy redirects use fixed destinations. The main risk is the coordinated URL cutover: existing app links may become unreachable during an incomplete deployment or rollback. Production routing and execution authorization were not fully verified.

Retained concerns

  • Medium · reliability · inferred: Legacy app redirects activate without a destination-readiness precondition while the old static app route is removed. Under the documented website-first deployment, or a router-only rollback, existing app links can lead to destinations that are not yet routed to the website. Temporary redirects mitigate persistent caching, not this intermediate-state reachability risk. Production routing behavior remains unverified.
Security review details

Security Blast Radius

  • observed — The expanded reachability includes website model pages and static catalogue/detail JSON in builds that previously excluded them. Those endpoints serialize configured catalogue/page content rather than reading a visitor's session.

Trust Boundaries and Controls

  • observed — The attacker-controlled type query only selects fixed internal route constants. Other query values and the fragment are appended after that fixed path, rather than selecting destination authority. App migration destinations are generated from static app names.
  • observed — Direct workflow navigation still enters ModelsPage gating, while app detail rendering independently checks global/app visibility. Inspected workflow and app operation components retain frontend session and credit checks; this does not establish server-side enforcement.

Hardening Proposals

  • proposed — Make destination readiness a prerequisite for activating legacy app redirects, and coordinate rollback so destination ownership remains available or legacy app serving is restored. Verify query forwarding across both production routing layers.
🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the primary changes: adding dedicated workflow and app Hub pages and moving app pages to /hub/apps.
Description check ✅ Passed The description is complete and relevant. It includes a summary, detailed changes, deployment considerations, review focus, issue reference, and extensive QA results. Breaking changes and dependencies…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PASS. A commit subject contains the bug-fix signal fix(website), but all listed changes are exclusively under apps/website. The custom check explicitly excludes such changes because the package us…
Website End-To-End Regression Coverage ✅ Passed The PR changes website runtime behavior under apps/website/src/, including new hub routes, redirects, navigation, and feature-flagged catalogue flows. It also adds or updates relevant Playwright ass…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains no files under src/lib/litegraph/, src/ecs/, or graph-entity-related files. This check does not apply.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/website/src/components/workshop/WorkflowPage.vue 0.00% 0 Missing and 1 partial ⚠️
apps/website/src/config/hub-models.ts 87.50% 0 Missing and 1 partial ⚠️
@@            Coverage Diff             @@
##             main   #19594      +/-   ##
==========================================
- Coverage   85.18%   84.23%   -0.95%     
==========================================
  Files        2414     3253     +839     
  Lines      136302   157858   +21556     
  Branches    36903    42840    +5937     
==========================================
+ Hits       116114   132979   +16865     
- Misses      19716    23092    +3376     
- Partials      472     1787    +1315     
Flag Coverage Δ
billing-web-unit ?
website-unit 79.49% <95.45%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...site/src/components/home/ModelDiscoverySection.vue 100.00% <100.00%> (ø)
.../website/src/components/workshop/CatalogueTabs.vue 100.00% <100.00%> (ø)
...ebsite/src/components/workshop/ModelsCatalogue.vue 100.00% <100.00%> (ø)
...pps/website/src/components/workshop/ModelsPage.vue 89.28% <100.00%> (ø)
...ponents/workshop/cinematic-studio/AppsBackLink.vue 100.00% <100.00%> (ø)
apps/website/src/config/indexing.ts 97.56% <100.00%> (ø)
apps/website/src/config/model-urls.ts 100.00% <ø> (ø)
apps/website/src/config/models-url-registry.ts 100.00% <100.00%> (ø)
apps/website/src/config/redirects.ts 100.00% <100.00%> (ø)
apps/website/src/config/routes.ts 100.00% <ø> (ø)
... and 4 more

... and 969 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @MaanilVerma.

Found 7 finding(s).

Severity Count
🟠 High 2
🟡 Medium 2
🟢 Low 2
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

Comment thread apps/website/src/config/routes.ts Resolved
Comment thread apps/website/src/config/indexing.ts Resolved

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👨‍💻 BILL: APPROVED at 618a7842ef, with one required change to the deploy order (not the code).

Severity Count
BLOCKER 0
SHOULD FIX 1 (deploy order)
TRIVIAL 0

SHOULD FIX: deploy comfy-router#49 FIRST, not this PR. Live today, the router answers /hub/apps/, /hub/apps/cinematic-studio/ and /hub/apps/reshoot/ with a 301 and no Cache-Control to /workflows/apps/..., which is 404. This PR sends /models/apps/* to /hub/apps/* and links app cards and tabs there. If it goes live before the router, every visitor in the gap is bounced into that 301, which browsers cache indefinitely and nobody can purge. That would permanently break Cinematic Studio and Re-shoot for them. Router-first only costs a brief, uncached 404 on /hub/workflows/ and /hub/apps/*, which nothing links to yet. So: dispatch the router deploy, then deploy this immediately, then purge /hub, /hub/, /hub/apps(/), /hub/apps/*, /hub/workflows(/) and the .md twins. Please update both PR descriptions.

Code checks out:

  • Section pages: hub-section.astro builds /hub/workflows/ and /hub/apps/ (it throws for an unknown pattern), with server-only copy in hub-section-copy.ts to stay inside the JS budget.
  • Flags: ModelsPage gates each section on its own flag through WorkshopGate, with the heading inside the gate. Reproduced with the apps and workflows flags off: both routes show the gated public fallback under their own section title, not a Models grid under the wrong heading.
  • App pages move to /hub/apps/<slug>/, with temporary /models/apps/* redirects (HUB_APPS_ROUTER_PENDING). App slugs are unchanged (apps/reshoot, apps/cinematic-studio), so #19541's Re-shoot flag and #19456's app_slug analytics keep working.
  • Indexing: /hub/apps/ and the app pages stay noindex, and /hub/workflows/ is indexable only when workflows are launched.
  • /hub redirect: temporary on both layers.

Verified:

  • merges cleanly with current main;
  • full website unit suite 7189 passed (4 skipped), typecheck clean, CI-env build OK;
  • the PR's e2e specs plus models-performance / models-render-guard / workshop-loading-flash pass 124/128 locally. The 4 local failures are the WEBSITE_INDEXABLE noindex artifact of a local build (three canonical checks) and an untouched homepage accordion test; CI is fully green, including all four website e2e shards.
  • The local check:link-slashes Svedka miss is inherited from this branch's base and fixed on main (#19580).

@MaanilVerma

Copy link
Copy Markdown
Collaborator Author

Combined test: router #49 in front of #19594 preview

This simulates deploy day. Router Comfy-Org/comfy-router#49 (head ddec3f6) ran under wrangler dev --local-protocol https, with WEBSITE_ORIGIN pointed at https://comfy-website-preview-pr-19594.vercel.app (head 618a784). Requests used the real Host/SNI for comfy.org and www.comfy.org, and every hop was followed. The run was read-only, and the override was reverted afterwards.

Result: 92/92 HTTP rows pass on both runs, and the two runs match hop for hop. 6/6 browser flows pass, with 0 console errors and 0 failed requests. lychee found 0 broken links and 0 internal redirects. Failures: none.

Group Pass What was checked
Hub root (/hub, /hub/, /hub?x=1, /hub// × apex/www × GET/HEAD/POST) 24/24 One hop to https://comfy.org/hub/models/ (query kept), 302 for GET/HEAD and 307 for POST, no-store, final 200 "ComfyUI models"
Sections (/hub/models/, /hub/workflows/, /hub/apps/, and without the slash) 6/6 200 vercel-website, H1 "ComfyUI models" / "ComfyUI workflows" / "ComfyUI apps"
Apps 8/8 /hub/apps/{cinematic-studio,reshoot}/ 200. /models/apps/<slug> in both slash forms: one 307, then 200. /cinematic-studio/ and ?app=reshoot 200 (noindex, canonical to /hub/apps/cinematic-studio/)
Workflows 7/7 5 listed pages 200. /hub/workflows/x/ 302 no-store to comfy.org/workflows/x/ (the workflows app answers 404). manifest.json 200 JSON
Old /models/workflows/<name> (both slash forms) 10/10 One 307, then 200
Old ?type= links 2/2 200 from the server; the client redirect is checked in the browser
Old model URLs (10 ids × 2 forms, plus /models/ and /models) 22/22 One 307 to the new /hub/models/<slug>/, then 200 with the right H1
.md twins 4/4 /hub/models.md 200. /hub/apps.md, /hub/workflows.md and /hub/workflows/remove-background.md 404, as expected (noindex, no twin)
Unchanged vs prod (/workflows/ + 6 paths, /ja/hub, /ja/hub/) 9/9 Same status chain, final URL, X-Served-By, H1 and title as comfy.org today

Browser (agent-browser, desktop 1440x900 and mobile 393x852, real Chrome UA, PostHog flags stubbed on and off, plus real flags, which this visitor got as off):

Flags /hub Workflows tab Apps tab → Cinematic Studio → Back Workflow card → Back ?type=apps ?type=workflows&q=flux#top
on /hub/models/ /hub/workflows/ /hub/apps/ → /hub/apps/cinematic-studio/ → /hub/apps/ /hub/workflows/image-to-video/ → /hub/workflows/ /hub/apps/ /hub/workflows/?q=flux#top
off / real /hub/models/ tabs hidden (by design); direct load shows the showcase fallback Cinematic Studio shows "not open yet" showcase fallback /hub/apps/ /hub/workflows/?q=flux#top

lychee over the preview's /hub/models/, /hub/workflows/, /hub/apps/ and both app pages: 632 links (237 unique), 0 errors, 0 internal redirects. The one external redirect is support.comfy.org/hc/en-us (301). The 3 /workflows/* links went to the workflows app and returned 200.

For the owner (not failures):

  1. POST /hub gets a correct 307, but the repeated POST to the static /hub/models/ then gets 405 from Vercel. This is harmless.
  2. /hub/workflows and /hub/apps without the slash answer 200 directly, as /hub/models does on prod today, rather than redirecting to the slash form. Should the router redirect them to the slash form?
  3. With the flag off, /hub/workflows/ and /hub/apps/ show the showcase, whose visible H1 is "Grok Imagine in ComfyUI". The PR notes this as the owner's call. Workflow detail pages also server-render that H1 ahead of the gate, and prod already does the same.
  4. The app pages have no server-rendered H1; it appears in the browser when the flag is on. Both pages are noindex.

The full tables are in temp/seo-audit/final-sweep/hub-sections-combined.md in Maanil's workspace.

Merged via the queue into main with commit 67ec51c Sep 30, 2026
126 of 127 checks passed
@benjcooley
benjcooley deleted the maanil/hub-sections branch September 30, 2026 08:35
github-merge-queue Bot pushed a commit that referenced this pull request Sep 30, 2026
## Summary

Keep Hub tab switching animated without the banner flash, loading-screen
clearing or moving controls.

## Changes

- Persist the catalogue across Astro navigation and preload the lazy
Workflows/Apps content before swapping. Models is already loaded with
the catalogue.
- Apply dismissed-banner state before paint and reserve consistent
subtitle height.
- Restore the page crossfade and hero text reveal on every tab,
including returning to Models. Skip animations only for reduced-motion
preferences.
- Preserve destination filters, active-tab resets and browser history;
cached-page restoration reads the current URL, not the initial query.
- Keep #19594's routes, indexing policy and the existing JavaScript
budgets unchanged. No router deployment needed.
- Declare the existing `es-toolkit` loader dependency in the website
package.

## Review Focus

- All three tab directions, Back/Forward, slow destination chunks,
feature flags, mobile menus and reduced motion.
- The reveal's hidden preparation state is immediate; its visible
animation keeps the original timing.
- Local verification: 10,578 website unit tests passed (4 skipped);
typecheck, lint, format, knip, build and JavaScript budget passed. Broad
browser run: 113/115 first pass; the two unchanged homepage-menu tests
passed on one targeted rerun. Animation and restoration regressions were
verified failing before their fixes.
- Independent desktop (1440px) and mobile (390px, Chromium/WebKit)
checks passed on the same build, including sampled motion frames. No
paid generation was run.

## Preview

https://comfy-website-preview-pr-19610.vercel.app/

Before/after screenshots and recordings are retained in the review
workspace under `temp/summaries/hub-navigation/` (`preview-*` before,
`desktop-judge-motion-round4-*` and `mobile-judge-motion-round4-*`
after). GitHub attachment upload is not available in this session.

---------

Co-authored-by: benjcooley <benjcooley@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
zeus-onl pushed a commit to zeus-onl/ComfyUI_frontend that referenced this pull request Sep 30, 2026
…on pages) (Comfy-Org#19605)

## Summary

Follow-up to the Cursor review on Comfy-Org#19594: an old
`/hub/models/?type=workflows|apps` link now forwards only for visitors
who have that section, `/hub/workflows/` stays noindex on its own, and
two small cleanups.

Part of [FE-2912](https://linear.app/comfyorg/issue/FE-2912)

## Changes

- **What**:
- `/hub/models/?type=workflows` (or `workflow`) and `?type=apps` wait
for the flags, then forward to the section page only when
`workshop-enabled` and that section's flag are on. Everyone else stays
on the models catalogue, like the old tab fallback. The loading state
holds until the answer, so nothing flashes. Other query params and the
hash carry over.
- The forward moved from a head script in `index.astro` into
`forwardLegacySection.ts`, loaded only when the URL has `?type=`.
`/hub/models/` without it loads 310 bytes more (1,824,610 to 1,824,920
on the Comfy-Org#19594 head, under the 1,825,000 ceiling).
- `/hub/workflows/` is never indexable now, like `/hub/apps/`, so
flipping `launchedWorkflowPages` no longer puts it in the sitemap or
llms.txt.
- The hub section copy is English only, since the routes are
locale-invariant.
  - "All apps" is an `h2`, matching "All workflows".

## Review Focus

- The forward waits for the page to finish parsing (BaseLayout starts
PostHog before `DOMContentLoaded`), then keeps watching the flags until
the section turns on, the visitor leaves that URL, or the page unmounts.
A flag that answers late, even after sign-in, still forwards, and the
catalogue loads alongside the wait.
- Unchanged on purpose: the section pages keep their title and meta
while the showcase fallback shows, same as the workflow and app detail
pages.

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Ben Cooley <bencooley@comfy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants