Repository navigation
fix(website): load footer animation before it scrolls into view - #19592
benjcooley wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🌐 Website E2ETip All tests passed.
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b1845a0826c44969e7eccd953ce06ca7379413a7
Full docs: ADR-DEVEX-LINT-0015 🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19592.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-kydimt6vn-comfyui.vercel.app Last updated: 2026-09-30T07:33:54Z for |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe footer’s Astro ChangesFooter visibility threshold
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The footer animation is configured to preload earlier than before at the tested desktop size. No concrete user-facing regression is established, so the change is ready to merge subject to normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
benjcooley
left a comment
There was a problem hiding this comment.
👨💻 BILL: APPROVED at 1f16eabbc6. 0 BLOCKER / 0 SHOULD FIX / 0 TRIVIAL.
rootMargin: '100%': a valid IntersectionObserver margin (one viewport). It fixes the blank-logo gap I measured on #19580 (149–221 ms at 200px), and your real-networkdrawImageprobe shows 0 ms at 100%. The markup, CSS and animation are unchanged.- It doesn't re-contend the catalogue load, which was the risk with a wider margin. On a CI-env build,
/hub/models/requests no footer frame before scrolling at 1280×800 (search ready 614–1155 ms) or 393×852 (cards at ~160 ms, footer ~7400 px below the fold), 3/3 each. On short pages the footer hydrates immediately, as it did before #19580. - Test: it now puts the footer 1.5 viewports below the fold, asserts it's off-screen, and requires a frame response, so it fails at 200px. The no-frames-before-search-ready assertion is kept.
- Verified:
models-render-guard+models-performance69/69 at--repeat-each=3, with all budgets unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19592 +/- ##
==========================================
- Coverage 84.22% 84.11% -0.11%
==========================================
Files 3325 3253 -72
Lines 160060 157882 -2178
Branches 41666 40942 -724
==========================================
- Hits 134803 132801 -2002
+ Misses 23357 23291 -66
+ Partials 1900 1790 -110
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing at Ben’s request. This is optional polish for the brief footer-animation delay, not required for the original CI fix or the already-merged Seedance and analytics work. The branch is retained if we choose to revisit it; no changes to main. |
Summary
Give the deferred footer animation enough time to load before scrolling brings it on screen, following #19580.
Changes
client:visiblepreload margin from200pxto100%. No changes to Mar's markup, CSS, images, or animation code; no new dependencies or abstractions.Review Focus
Real-network Chromium measurements at 1280×800, with a three-second read followed by wheel scrolling, showed 48–127 ms of blank canvas across four runs before this change. The same four-run workload measured 0 ms after it. This measures first canvas draw, not merely network completion; it is not a guarantee for every network or scroll speed.
The strengthened test fails against the old built margin and passes with this change. All 69 targeted browser runs pass (performance and render-guard suites, repeated three times). The original 1,000 ms loader, layout-shift, and JavaScript budgets are unchanged. CI-env production build, internal-link check, website typecheck, targeted lint/format, and pre-push checks pass.
Static appearance and translated copy are unchanged; only off-screen loading timing changes. BILL is the sole reviewer for this follow-up.