Skip to content

[backport cloud/1.54] fix: start typing from anywhere in the agent composer prompt area (#19517) - #19577

Merged
comfy-pr-bot merged 1 commit into
Comfy-Org:cloud/1.54from
christian-byrne:backport-19517-to-cloud-1.54
Sep 30, 2026
Merged

comfy-pr-bot merged 1 commit into
Comfy-Org:cloud/1.54from
christian-byrne:backport-19517-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports merged #19517 (79c6bef950) to cloud/1.54.

Conflict resolution

  • Preserved the complete composer hitbox layout from fix: start typing from anywhere in the agent composer prompt area #19517.
  • Preserved cloud/1.54 prompt semantics, including its existing editor event surface.
  • Adapted agentComposerPaste.spec.ts to the Agent page object and below-first-line click.
  • Kept agentCopyPaste.spec.ts deleted because cloud/1.54 does not contain its newer AgentCopyPasteDriver harness.

Verification

  • pnpm exec oxfmt --check <six changed files>
  • pnpm exec eslint <six changed files> (0 errors; one pre-existing import warning)
  • NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck:browser
  • pnpm test:unit src/workbench/extensions/agent/components/agent/Composer.test.ts --testTimeout=30000 — 93/93 passed
  • DISTRIBUTION=cloud NODE_OPTIONS=--max-old-space-size=8192 pnpm build
  • isolated Cloud browser proof, repeat-each=5 — 10/10 passed across the hitbox and paste scenarios

Original PR: #19517
Failed automation: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36673105273

…mfy-Org#19517)

Clicking anywhere in the agent composer's prompt area now starts typing.
Before, only the first 28px line was clickable, and clicks below it
landed on padding.

- **What**: The prompt editor now fills the prompt area and owns its
padding, so a click anywhere lands in the editor and the caret goes
where you click. The empty-state hint sits in the same grid cell as the
editor instead of being pulled up with `-mt-7`, so it can't overflow
when it wraps. This is CSS only, with no new event handlers.

- The placeholder should line up with the first typed line, and the gap
under "Saving workflow…" should stay at 4px (`-mb-2`).
- New e2e test in `agentPanel.spec.ts`: starts typing from a click below
the first prompt line.
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 30, 2026
@vercel

vercel Bot commented Sep 30, 2026

Copy link
Copy Markdown

@ryan-di is attempting to deploy a commit to the ComfyUI Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 142cd14a-c0b0-4a4d-8793-bb66e82e34c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 06:01:50 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 138ms TBT · 101.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.0 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 13ms TBT · 165.8 MB heap
vue-node-resize-workload: · 57.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 348ms TBT · 170.7 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 560ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.2 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 29ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 871ms
canvas-mouse-sweep: script duration 144ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.2 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -196
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 348ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 460ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.8 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 588ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.3 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1620ms
large-graph-pan: script duration 781ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 73.7 MB
large-graph-pan: DOM nodes -276
large-graph-pan: event listeners -164
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1666ms
large-graph-zoom: script duration 729ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.6 MB
large-graph-zoom: DOM nodes -146
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1857ms
legacy-node-drag: script duration 921ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.9 MB
legacy-node-drag: DOM nodes -138
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 599ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 76.8 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -163
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 397ms
subgraph-dom-widget-clipping: script duration 132ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.3 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 487ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 25ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 796ms
subgraph-mouse-sweep: script duration 95ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 62.9 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 877ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 101.8 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 5759ms
viewport-pan-sweep: script duration 2594ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.7 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -178
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14817ms
vue-large-graph-idle: script duration 245ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 173.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 150
vue-large-graph-pan: task duration 18132ms
vue-large-graph-pan: script duration 892ms
vue-large-graph-pan: TBT 13ms
vue-large-graph-pan: heap used 165.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 83ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5407ms
vue-node-resize-workload: script duration 99ms
vue-node-resize-workload: TBT 348ms
vue-node-resize-workload: heap used 170.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7394ms
vue-zoom-out-idle: script duration 130ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 3ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 109ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.5 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-30T06:10:31.415Z",
  "gitSha": "9ce3aa16ed8838f74411bc9c409d56cd71bc9d7d",
  "branch": "backport-19517-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2134.914000000009,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.353,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.602,
      "heapDeltaBytes": 8695808,
      "heapUsedBytes": 78928884,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.469000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2038.1730000000289,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.774000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.377,
      "heapDeltaBytes": -7235916,
      "heapUsedBytes": 64162352,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.255,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1876.7959999999562,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.294999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.303000000000001,
      "taskDurationMs": 868.484,
      "heapDeltaBytes": -5884236,
      "heapUsedBytes": 64525440,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 144.66199999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1884.896000000026,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 27.534000000000002,
      "layouts": 14,
      "layoutDurationMs": 4.34,
      "taskDurationMs": 873.4419999999999,
      "heapDeltaBytes": -6443652,
      "heapUsedBytes": 63731912,
      "domNodes": -283,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 143.776,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1723.2190000000287,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 14.267,
      "layouts": 6,
      "layoutDurationMs": 0.9059999999999999,
      "taskDurationMs": 343.208,
      "heapDeltaBytes": 4583220,
      "heapUsedBytes": 75047508,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.095999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1681.084999999939,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.615,
      "layouts": 6,
      "layoutDurationMs": 1.2399999999999998,
      "taskDurationMs": 353.617,
      "heapDeltaBytes": 4603604,
      "heapUsedBytes": 75800008,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.494999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 661.4930000000072,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.249999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 448.494,
      "heapDeltaBytes": -6550240,
      "heapUsedBytes": 64617668,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 156.14600000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 674.4029999999839,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.041999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.174,
      "heapDeltaBytes": -6594588,
      "heapUsedBytes": 64922440,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 163.54399999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.0899999999824,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.191000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.3919999999999,
      "heapDeltaBytes": 10316232,
      "heapUsedBytes": 87067916,
      "domNodes": -271,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 35.509,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.1080000000275,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.052999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 582.92,
      "heapDeltaBytes": -15638572,
      "heapUsedBytes": 87646736,
      "domNodes": -266,
      "jsHeapTotalBytes": -1376256,
      "scriptDurationMs": 33.492999999999995,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2173.770999999988,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.069999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1589.4409999999998,
      "heapDeltaBytes": 9438780,
      "heapUsedBytes": 86384356,
      "domNodes": -267,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 766.744,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2207.8390000000354,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.392,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1651.042,
      "heapDeltaBytes": -9974536,
      "heapUsedBytes": 68163804,
      "domNodes": -285,
      "jsHeapTotalBytes": 159744,
      "scriptDurationMs": 794.8820000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3486.481999999967,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.347999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.542999999999997,
      "taskDurationMs": 1625.8720000000003,
      "heapDeltaBytes": 9470788,
      "heapUsedBytes": 76721204,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 722.424,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3604.0249999999787,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 12.765000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.159999999999997,
      "taskDurationMs": 1705.245,
      "heapDeltaBytes": -7713400,
      "heapUsedBytes": 71310820,
      "domNodes": -291,
      "jsHeapTotalBytes": 4878336,
      "scriptDurationMs": 734.904,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2959.218999999962,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.560000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1839.2389999999998,
      "heapDeltaBytes": 24604732,
      "heapUsedBytes": 93045032,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 915.288,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2993.204999999989,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.312999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1874.1190000000004,
      "heapDeltaBytes": 21393136,
      "heapUsedBytes": 89192332,
      "domNodes": -276,
      "jsHeapTotalBytes": 2252800,
      "scriptDurationMs": 926.8580000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2040.1089999999726,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.649999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 596.5740000000002,
      "heapDeltaBytes": -4251412,
      "heapUsedBytes": 73578856,
      "domNodes": -285,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 29.85,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2064.5230000000083,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 10.848,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 602.36,
      "heapDeltaBytes": 9336756,
      "heapUsedBytes": 87451276,
      "domNodes": -271,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.928,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.5289999999841,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 10.92,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.97700000000003,
      "heapDeltaBytes": 15189316,
      "heapUsedBytes": 88614416,
      "domNodes": 24,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 133.887,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 584.961999999905,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 8.99,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.876,
      "heapDeltaBytes": 15127460,
      "heapUsedBytes": 88102940,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 130.882,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.7440000000502,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.874,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.15,
      "heapDeltaBytes": -9108332,
      "heapUsedBytes": 64494272,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.287,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.5140000000147,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.6129999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 486.59799999999996,
      "heapDeltaBytes": -5117920,
      "heapUsedBytes": 68321184,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.358999999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1745.5960000000346,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 25.843999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.868,
      "taskDurationMs": 799.0889999999999,
      "heapDeltaBytes": -16071812,
      "heapUsedBytes": 57296528,
      "domNodes": -298,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 94.957,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.3479999999877,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 24.112999999999996,
      "layouts": 18,
      "layoutDurationMs": 4.424000000000001,
      "taskDurationMs": 792.489,
      "heapDeltaBytes": 1159128,
      "heapUsedBytes": 74643812,
      "domNodes": -296,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 94.473,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.429000000031,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 27.508000000000006,
      "layouts": 15,
      "layoutDurationMs": 13.396,
      "taskDurationMs": 877.2560000000001,
      "heapDeltaBytes": 22457936,
      "heapUsedBytes": 106791044,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 29.280999999999995,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8477.093999999965,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 33.542,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5850.4130000000005,
      "heapDeltaBytes": -8390576,
      "heapUsedBytes": 67741000,
      "domNodes": -275,
      "jsHeapTotalBytes": -364544,
      "scriptDurationMs": 2644.905,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8314.433000000008,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 33.39300000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5667.471,
      "heapDeltaBytes": 14162440,
      "heapUsedBytes": 91008212,
      "domNodes": -269,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2543.897,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15513.592000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14750.862000000001,
      "heapDeltaBytes": -36370684,
      "heapUsedBytes": 182773940,
      "domNodes": -8068,
      "jsHeapTotalBytes": -6828032,
      "scriptDurationMs": 250.878,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15630.077999999912,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14884.042,
      "heapDeltaBytes": -60670248,
      "heapUsedBytes": 179931248,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14594048,
      "scriptDurationMs": 238.193,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18565.399000000012,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 15.844999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18246.55,
      "heapDeltaBytes": -38424868,
      "heapUsedBytes": 180991040,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8400896,
      "scriptDurationMs": 934.6050000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 12,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18375.15600000006,
      "styleRecalcs": 150,
      "styleRecalcDurationMs": 15.847,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18016.879000000004,
      "heapDeltaBytes": -66643640,
      "heapUsedBytes": 166702300,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20623360,
      "scriptDurationMs": 849.214,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5546.492,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 91.14099999999998,
      "layouts": 20,
      "layoutDurationMs": 28.690999999999995,
      "taskDurationMs": 5419.352000000001,
      "heapDeltaBytes": -54795228,
      "heapUsedBytes": 177137120,
      "domNodes": -8068,
      "jsHeapTotalBytes": 4804608,
      "scriptDurationMs": 96.78699999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 424,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5504.465999999979,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.26799999999997,
      "layouts": 20,
      "layoutDurationMs": 23.451,
      "taskDurationMs": 5394.312,
      "heapDeltaBytes": -38979540,
      "heapUsedBytes": 180847780,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11739136,
      "scriptDurationMs": 100.72,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 271,
      "frameDurationMs": 17.773333333333298,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7645.100999999954,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7359.905999999999,
      "heapDeltaBytes": 11584228,
      "heapUsedBytes": 177223828,
      "domNodes": 0,
      "jsHeapTotalBytes": -21233664,
      "scriptDurationMs": 144.58899999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7688.394000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7429.017,
      "heapDeltaBytes": 18196408,
      "heapUsedBytes": 176785616,
      "domNodes": 0,
      "jsHeapTotalBytes": -7602176,
      "scriptDurationMs": 116.05599999999994,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 492.78299999997444,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 20.785999999999998,
      "layouts": 3,
      "layoutDurationMs": 4.370000000000001,
      "taskDurationMs": 139.797,
      "heapDeltaBytes": 5069944,
      "heapUsedBytes": 69832832,
      "domNodes": 145,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.839,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.59399999992547,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.286,
      "layouts": 2,
      "layoutDurationMs": 1.604,
      "taskDurationMs": 78.425,
      "heapDeltaBytes": 3028532,
      "heapUsedBytes": 71621980,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.114000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50775 76059 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di September 30, 2026 06:00
@codecov

codecov Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19577   +/-   ##
=============================================
  Coverage              ?   84.00%           
=============================================
  Files                 ?     2121           
  Lines                 ?   126959           
  Branches              ?    34366           
=============================================
  Hits                  ?   106653           
  Misses                ?    20127           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.78% <ø> (?)
unit 79.16% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nch/extensions/agent/components/agent/Composer.vue 99.17% <100.00%> (ø)
...t/components/agent/composer/InlinePromptEditor.vue 97.63% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ryan-di ryan-di left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches #19517. The only omission is the @attach-files binding, which doesn't exist on cloud/1.54; the paste spec adapts to the branch's older panel setup.

@comfy-pr-bot
comfy-pr-bot merged commit cab90b2 into Comfy-Org:cloud/1.54 Sep 30, 2026
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants