Skip to content

[backport cloud/1.54] test(agent): make the grant no-persistence check order-independent and pin the sign-out clear - #19396

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-19184-to-cloud-1.54
Sep 29, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-19184-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #19184 to cloud/1.54

Automatically created by backport workflow.

…d pin the sign-out clear (#19184)

*PR Created by the Glary-Bot Agent*

---

Test-only follow-up to
[#19074](#19074),
which stopped Agent access granted to one signed-in account from
persisting for another account.

## What this changes

The grant-persistence regression test now runs independently of test
order. Each test clears browser storage and resets the module-scoped
cached feature values. The persistence case primes only the two feature
flags that are intentionally stored, takes complete storage snapshots,
and performs one authenticated refresh with Agent access enabled. Any
new persisted key still changes the snapshot and fails the test.

The identity-invalidation test now seeds both the transient Agent grant
and its expiry time before checking that `invalidateRemoteConfig()`
clears them. This prevents either assertion from passing on empty setup.

No production code changes.

## Regression evidence

| Mutation | Result |
|---|---|
| Persist the Agent grant under `agent-in-app-experience` | Caught by
the full-file and isolated test |
| Persist it under `session_whitelist` | Caught by the full-file and
isolated test |
| Persist it under an arbitrary key | Caught by the full-file and
isolated test |
| Stop clearing the grant during identity invalidation | Caught by the
invalidation test |
| Stop clearing the grant expiry during identity invalidation | Caught
independently by the invalidation test |

## Verification

- `src/platform/remoteConfig/refreshRemoteConfig.test.ts`: 24/24 passed
- `src/platform/remoteConfig`: 24/24 passed
- Isolated grant-persistence regression: 1/1 passed
- Format, lint, typecheck, Fallow, hosted unit-test shards, Codecov, and
automated review passed on the reviewed head

---------

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 29, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 29, 2026 09:17
@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 29, 2026 9:17am UTC
billing-web-test Ignored Ignored Sep 29, 2026 9:17am UTC

Request Review

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 09:20:06 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 100.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.2 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 41ms TBT · 158.8 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 406ms TBT · 171.0 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 501ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 62.1 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 81
canvas-mouse-sweep: task duration 961ms
canvas-mouse-sweep: script duration 174ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 60.8 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -195
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 350ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 466ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.2 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 622ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.0 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1662ms
large-graph-pan: script duration 821ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 81.2 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1687ms
large-graph-zoom: script duration 790ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1960ms
legacy-node-drag: script duration 976ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.5 MB
legacy-node-drag: DOM nodes -125
legacy-node-drag: event listeners 87
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 624ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.3 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 417ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 485ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.0 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 800ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 55.8 MB
subgraph-mouse-sweep: DOM nodes -129
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 886ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 100.4 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 35ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5814ms
viewport-pan-sweep: script duration 2755ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 74.2 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16032ms
vue-large-graph-idle: script duration 269ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.6 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14931
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 20655ms
vue-large-graph-pan: script duration 951ms
vue-large-graph-pan: TBT 41ms
vue-large-graph-pan: heap used 158.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6077ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 406ms
vue-node-resize-workload: heap used 171.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14927
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8147ms
vue-zoom-out-idle: script duration 139ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.2 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 73ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.5 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 26
Raw data
{
  "timestamp": "2026-09-29T09:28:40.571Z",
  "gitSha": "c0caf02528ff032ff94709f8506345f75dce4fc6",
  "branch": "backport-19184-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2051.5629999999874,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.167000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 512.0980000000001,
      "heapDeltaBytes": -10467664,
      "heapUsedBytes": 59666504,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.554000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.76700000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.687000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.63499999999993,
      "heapDeltaBytes": -11956,
      "heapUsedBytes": 70485628,
      "domNodes": -278,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.793000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2132.3079999999663,
      "styleRecalcs": 83,
      "styleRecalcDurationMs": 34.244,
      "layouts": 14,
      "layoutDurationMs": 4.322,
      "taskDurationMs": 1038.8500000000001,
      "heapDeltaBytes": -6455796,
      "heapUsedBytes": 63719072,
      "domNodes": -276,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 186.361,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1858.114999999998,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 29.37,
      "layouts": 14,
      "layoutDurationMs": 4.052,
      "taskDurationMs": 882.293,
      "heapDeltaBytes": -6498632,
      "heapUsedBytes": 63712528,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 161.43200000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.2420000001512,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.330000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.123,
      "taskDurationMs": 353.248,
      "heapDeltaBytes": 4587584,
      "heapUsedBytes": 75685496,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.906000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.391000000016,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.806999999999999,
      "layouts": 6,
      "layoutDurationMs": 1.017,
      "taskDurationMs": 347.15200000000004,
      "heapDeltaBytes": 4603724,
      "heapUsedBytes": 75940192,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.972000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 680.5699999999888,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.493,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.18300000000005,
      "heapDeltaBytes": -7850504,
      "heapUsedBytes": 63130568,
      "domNodes": 20,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 168.80999999999997,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 647.9880000001685,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.287999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.947,
      "heapDeltaBytes": -8249820,
      "heapUsedBytes": 63206880,
      "domNodes": 18,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 164.383,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.879000000057,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.262999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.312,
      "heapDeltaBytes": 9010612,
      "heapUsedBytes": 85472844,
      "domNodes": -273,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 32.41300000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2044.411000000082,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.883,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.1289999999999,
      "heapDeltaBytes": -16128728,
      "heapUsedBytes": 86518048,
      "domNodes": -267,
      "jsHeapTotalBytes": 720896,
      "scriptDurationMs": 32.855999999999995,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2231.7910000001575,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.963999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1611.0749999999998,
      "heapDeltaBytes": 11648924,
      "heapUsedBytes": 89147604,
      "domNodes": -275,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 808.6320000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2340.83099999998,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.275000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1712.1409999999998,
      "heapDeltaBytes": 4244432,
      "heapUsedBytes": 81242144,
      "domNodes": -281,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 833.292,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3486.078000000134,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.470000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.682,
      "taskDurationMs": 1661.678,
      "heapDeltaBytes": 12022884,
      "heapUsedBytes": 80375384,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 774.9010000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3592.352000000119,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.732999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.776000000000002,
      "taskDurationMs": 1712.7559999999999,
      "heapDeltaBytes": 8851408,
      "heapUsedBytes": 76422296,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 804.1199999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3073.3040000000074,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.261000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1925.7530000000002,
      "heapDeltaBytes": 24897748,
      "heapUsedBytes": 92636012,
      "domNodes": 2,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 966.76,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3132.142000000158,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.093999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1994.0800000000002,
      "heapDeltaBytes": 8283896,
      "heapUsedBytes": 88697972,
      "domNodes": -251,
      "jsHeapTotalBytes": 315392,
      "scriptDurationMs": 985.078,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2070.376000000124,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.615999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.5540000000001,
      "heapDeltaBytes": 6223400,
      "heapUsedBytes": 84102292,
      "domNodes": -284,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 36.529999999999994,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2067.457000000104,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.093999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 611.514,
      "heapDeltaBytes": 7758448,
      "heapUsedBytes": 86404948,
      "domNodes": -272,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 32.214000000000006,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 571.7460000000756,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.564,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.319,
      "heapDeltaBytes": 14794364,
      "heapUsedBytes": 88122312,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 140.34999999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 625.868999999966,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.629,
      "heapDeltaBytes": 15169648,
      "heapUsedBytes": 88508260,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 148.872,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.9410000001117,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.423000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.94900000000007,
      "heapDeltaBytes": -5652884,
      "heapUsedBytes": 67908816,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.8420000000000005,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.3560000001107,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.147000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.55100000000004,
      "heapDeltaBytes": -8788708,
      "heapUsedBytes": 64114904,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.924000000000003,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.705000000009,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.630000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.204999999999999,
      "taskDurationMs": 775.9580000000001,
      "heapDeltaBytes": -13049984,
      "heapUsedBytes": 59600316,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 103.78899999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1768.6650000000554,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 31.997999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.754,
      "taskDurationMs": 823.229,
      "heapDeltaBytes": -8831120,
      "heapUsedBytes": 57500264,
      "domNodes": 37,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 109.072,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.3269999999848,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.895,
      "layouts": 16,
      "layoutDurationMs": 15.075000000000001,
      "taskDurationMs": 886.3000000000001,
      "heapDeltaBytes": 20996772,
      "heapUsedBytes": 105242164,
      "domNodes": 13831,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 28.87599999999999,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8487.002999999959,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.53399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5903.137,
      "heapDeltaBytes": -7483976,
      "heapUsedBytes": 69160892,
      "domNodes": -270,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 2817.468,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8337.097000000085,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.937999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5724.812999999999,
      "heapDeltaBytes": 10251312,
      "heapUsedBytes": 86503380,
      "domNodes": -268,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 2692.8779999999997,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16677.218999999925,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16053.570999999998,
      "heapDeltaBytes": -38963732,
      "heapUsedBytes": 179374780,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 268.97900000000004,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16774.585000000116,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16010.279999999999,
      "heapDeltaBytes": -61614108,
      "heapUsedBytes": 178423176,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16928768,
      "scriptDurationMs": 269.453,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20994.846999999936,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 17.335000000000043,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20558.353,
      "heapDeltaBytes": -52639132,
      "heapUsedBytes": 166598280,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11022336,
      "scriptDurationMs": 935.4740000000002,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 34,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21164.65100000005,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 18.36399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20752.255999999998,
      "heapDeltaBytes": -52331928,
      "heapUsedBytes": 166352628,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11517952,
      "scriptDurationMs": 966.0730000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 48,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6192.202000000179,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 82.15,
      "layouts": 20,
      "layoutDurationMs": 23.582000000000004,
      "taskDurationMs": 6035.460000000001,
      "heapDeltaBytes": -45289540,
      "heapUsedBytes": 182987108,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10526720,
      "scriptDurationMs": 106.197,
      "eventListeners": -14926,
      "totalBlockingTimeMs": 356,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6237.170999999989,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.162,
      "layouts": 20,
      "layoutDurationMs": 23.01299999999999,
      "taskDurationMs": 6118.073,
      "heapDeltaBytes": -52104448,
      "heapUsedBytes": 175721036,
      "domNodes": -8068,
      "jsHeapTotalBytes": 2473984,
      "scriptDurationMs": 116.80499999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 456,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8452.943999999889,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8197.139,
      "heapDeltaBytes": -6011012,
      "heapUsedBytes": 183017464,
      "domNodes": 0,
      "jsHeapTotalBytes": -9699328,
      "scriptDurationMs": 152.36899999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8463.044999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8096.373999999999,
      "heapDeltaBytes": 19287160,
      "heapUsedBytes": 180298736,
      "domNodes": -1,
      "jsHeapTotalBytes": -11796480,
      "scriptDurationMs": 125.48899999999996,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.4289999999346,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.81,
      "layouts": 2,
      "layoutDurationMs": 1.4820000000000002,
      "taskDurationMs": 76.86500000000002,
      "heapDeltaBytes": 3030740,
      "heapUsedBytes": 71571960,
      "domNodes": 129,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.258999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 93.95900000004076,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 15.594999999999999,
      "layouts": 2,
      "layoutDurationMs": 0.67,
      "taskDurationMs": 69.69,
      "heapDeltaBytes": 3004556,
      "heapUsedBytes": 72006344,
      "domNodes": 106,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.335,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50761 76021 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di September 29, 2026 09:18
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19396   +/-   ##
=============================================
  Coverage              ?   83.97%           
=============================================
  Files                 ?     2119           
  Lines                 ?   126653           
  Branches              ?    32095           
=============================================
  Hits                  ?   106358           
  Misses                ?    20117           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.79% <ø> (?)
unit 79.11% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 0f5da8a into cloud/1.54 Sep 29, 2026
105 of 108 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-19184-to-cloud-1.54 branch September 29, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate greenlight

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants