Repository navigation
Conversation
Backport f77fc6a ("Backport #19219") shipped the production half of the agent gate auth lifecycle fix but not the six test/mock files the upstream PR changed, so cloud/1.54 has been red on `test` since it landed: 60 unit failures across agentPanel, useFeatureFlags and useBillingContext. Two production changes the tests were never told about: - `isAuthenticatedConfigLoaded` now reads `authenticatedRemoteConfigState` instead of `remoteConfigState`, so tests that only set the latter to 'authenticated' no longer reach the authenticated branch. - `agentPanel.ts` now reads `isAuthInitialized` off `useCurrentUser()`, which agentPanel.test.ts's inline mock does not provide — the gate watcher throws `Cannot read properties of undefined` and takes all 53 tests in the file down with it. Ported every upstream change that has a target on this branch, adapted to its idioms: the mock and state writes above, upstream's bounded-window case for the transient session grant, its `remoteConfigRevision` consent-retry case, and its off-cloud `onAuthHeader` case — the last two covering code the parent backported with no direct test at all. Left behind, for cause: upstream's edits to `__mocks__/useCurrentUser.ts` and `__mocks__/remoteConfig.ts`, neither of which exists here; its gate-settle and unifiedWebSession cases, whose surrounding suites are main-only; and its on-cloud `onAuthHeader` case, which spies on `@/platform/auth/firebaseIdentity`, also absent here. Also reset `authenticatedRemoteConfigState` in the hooks of every suite that writes it, so the new writes cannot leak into a sibling test under reordering, and pinned it explicitly in the bounded-window case so that case cannot go vacuous.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
No code change from me here — this is the automated "review skipped" notice rather than review feedback. Taking up the offer to run one explicitly, since a release-branch change is worth a second pass: @coderabbitai review For whoever picks this up: the diff is test-only (4 |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T23:40:20.140Z",
"gitSha": "a3e68e0603635cfa9220cdcc0e7b8c72229234d4",
"branch": "glary/complete-19219-backport-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.366000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.208000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.3209999999999,
"heapDeltaBytes": 10378344,
"heapUsedBytes": 81557928,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.7200000000000015,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2030.8809999999653,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.222999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.28100000000006,
"heapDeltaBytes": -13105024,
"heapUsedBytes": 57391856,
"domNodes": 2,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.204000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.636999999991,
"styleRecalcs": 51,
"styleRecalcDurationMs": 11.374999999999998,
"layouts": 14,
"layoutDurationMs": 3.2230000000000003,
"taskDurationMs": 846.863,
"heapDeltaBytes": -1657188,
"heapUsedBytes": 69324944,
"domNodes": -284,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 128.258,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.4219999999527,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.94,
"layouts": 14,
"layoutDurationMs": 3.376,
"taskDurationMs": 746.788,
"heapDeltaBytes": -9113988,
"heapUsedBytes": 61441056,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 121.203,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.202999999969,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.989,
"layouts": 6,
"layoutDurationMs": 1.155,
"taskDurationMs": 309.67499999999995,
"heapDeltaBytes": 4247512,
"heapUsedBytes": 74781580,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.964,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7699999999923,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.083000000000002,
"layouts": 6,
"layoutDurationMs": 1.0730000000000002,
"taskDurationMs": 314.841,
"heapDeltaBytes": 4550156,
"heapUsedBytes": 75679772,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8.944,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 557.7250000000049,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.8660000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.853,
"heapDeltaBytes": -7586772,
"heapUsedBytes": 63592004,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 133.503,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 545.7640000000197,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.462999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.74300000000005,
"heapDeltaBytes": 18576020,
"heapUsedBytes": 89186072,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 131.801,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.877999999987,
"styleRecalcs": 5,
"styleRecalcDurationMs": 9.499,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.6139999999999,
"heapDeltaBytes": 10973092,
"heapUsedBytes": 87522820,
"domNodes": -268,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 28.640000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2069.2830000000413,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.010000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.9540000000001,
"heapDeltaBytes": 10912212,
"heapUsedBytes": 87559288,
"domNodes": -266,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 27.408999999999995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2177.216000000044,
"styleRecalcs": 68,
"styleRecalcDurationMs": 10.416000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1382.4509999999998,
"heapDeltaBytes": 4519332,
"heapUsedBytes": 81681068,
"domNodes": -277,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 642.4730000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2114.9740000000747,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1304.316,
"heapDeltaBytes": 19980384,
"heapUsedBytes": 86131444,
"domNodes": -273,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 614.6510000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3110.087999999962,
"styleRecalcs": 61,
"styleRecalcDurationMs": 7.844999999999998,
"layouts": 60,
"layoutDurationMs": 9.312000000000001,
"taskDurationMs": 1341.2770000000003,
"heapDeltaBytes": 8111908,
"heapUsedBytes": 75930860,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 582.898,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3157.1579999999813,
"styleRecalcs": 60,
"styleRecalcDurationMs": 7.33,
"layouts": 60,
"layoutDurationMs": 9.271999999999998,
"taskDurationMs": 1360.937,
"heapDeltaBytes": 8044556,
"heapUsedBytes": 76184032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 588.033,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2402.807999999993,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.4559999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1589.948,
"heapDeltaBytes": -4652300,
"heapUsedBytes": 77415816,
"domNodes": 10,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 766.165,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2469.0219999999954,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.0409999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1531.905,
"heapDeltaBytes": 16565232,
"heapUsedBytes": 84589036,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 745.4480000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.4779999999778,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.132000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.27600000000007,
"heapDeltaBytes": 21860356,
"heapUsedBytes": 88276672,
"domNodes": -269,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.716,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.2279999999892,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.6679999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.7799999999999,
"heapDeltaBytes": 10122652,
"heapUsedBytes": 87712576,
"domNodes": -272,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 23.512999999999998,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.734000000019,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.611,
"heapDeltaBytes": 14335948,
"heapUsedBytes": 87058384,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 107.055,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 538.2879999999659,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.074,
"heapDeltaBytes": 14026072,
"heapUsedBytes": 86685088,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 110.25099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.1240000000134,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.889,
"heapDeltaBytes": 7175308,
"heapUsedBytes": 80602868,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.542999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.2829999999676,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.975000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.00600000000003,
"heapDeltaBytes": 1313340,
"heapUsedBytes": 74896868,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.189000000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.451000000016,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.613,
"layouts": 18,
"layoutDurationMs": 3.358,
"taskDurationMs": 664.284,
"heapDeltaBytes": -9798688,
"heapUsedBytes": 62875788,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 75.529,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1699.87500000002,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.076000000000004,
"layouts": 18,
"layoutDurationMs": 3.262,
"taskDurationMs": 686.8319999999999,
"heapDeltaBytes": 6062836,
"heapUsedBytes": 79526856,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 76.005,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 984.4640000000027,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.667,
"layouts": 15,
"layoutDurationMs": 11.160000000000002,
"taskDurationMs": 801.958,
"heapDeltaBytes": -5264376,
"heapUsedBytes": 86184100,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.182,
"eventListeners": 2385,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.744000000015,
"styleRecalcs": 248,
"styleRecalcDurationMs": 24.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4727.496,
"heapDeltaBytes": 2411652,
"heapUsedBytes": 79235568,
"domNodes": -282,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 2041.3329999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.28200000006,
"styleRecalcs": 249,
"styleRecalcDurationMs": 25.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4762.296,
"heapDeltaBytes": 13535820,
"heapUsedBytes": 90415628,
"domNodes": -266,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2081.665,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12715.419999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11958.162999999999,
"heapDeltaBytes": -29501088,
"heapUsedBytes": 183747136,
"domNodes": -8068,
"jsHeapTotalBytes": -10399744,
"scriptDurationMs": 153.376,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12752.730999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12009.024,
"heapDeltaBytes": -55176388,
"heapUsedBytes": 184593924,
"domNodes": -8068,
"jsHeapTotalBytes": -6754304,
"scriptDurationMs": 153.136,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15953.080999999998,
"styleRecalcs": 87,
"styleRecalcDurationMs": 12.991000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15414.675999999998,
"heapDeltaBytes": -39473592,
"heapUsedBytes": 166849888,
"domNodes": -8068,
"jsHeapTotalBytes": -19275776,
"scriptDurationMs": 782.347,
"eventListeners": -14929,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15814.579999999978,
"styleRecalcs": 84,
"styleRecalcDurationMs": 12.707999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15265.682000000003,
"heapDeltaBytes": -61801468,
"heapUsedBytes": 166200328,
"domNodes": -8068,
"jsHeapTotalBytes": -18497536,
"scriptDurationMs": 757.774,
"eventListeners": -14929,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4460.264999999992,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.52399999999997,
"layouts": 20,
"layoutDurationMs": 29.965000000000007,
"taskDurationMs": 4331.294,
"heapDeltaBytes": -41659240,
"heapUsedBytes": 177299864,
"domNodes": -8068,
"jsHeapTotalBytes": 11476992,
"scriptDurationMs": 67.70799999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4588.0750000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.42399999999998,
"layouts": 20,
"layoutDurationMs": 19.001000000000005,
"taskDurationMs": 4460.0740000000005,
"heapDeltaBytes": -27815828,
"heapUsedBytes": 184239004,
"domNodes": -8068,
"jsHeapTotalBytes": 12943360,
"scriptDurationMs": 69.015,
"eventListeners": -14931,
"totalBlockingTimeMs": 69,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6323.144000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5993.532000000002,
"heapDeltaBytes": 731788,
"heapUsedBytes": 178440592,
"domNodes": 0,
"jsHeapTotalBytes": -25952256,
"scriptDurationMs": 76.83000000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6376.152000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6073.4,
"heapDeltaBytes": 5365824,
"heapUsedBytes": 184321196,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 83.31300000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 455.8640000000196,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.669,
"layouts": 3,
"layoutDurationMs": 1.64,
"taskDurationMs": 102.077,
"heapDeltaBytes": 4944336,
"heapUsedBytes": 73620600,
"domNodes": 147,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.334000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 91.829999999959,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.367,
"layouts": 2,
"layoutDurationMs": 1.0799999999999998,
"taskDurationMs": 57.04100000000001,
"heapDeltaBytes": 2989176,
"heapUsedBytes": 71847700,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.7239999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 4ad7a07 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19311 +/- ##
=============================================
Coverage ? 66.82%
=============================================
Files ? 1677
Lines ? 75771
Branches ? 0
=============================================
Hits ? 50635
Misses ? 25136
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing as superseded by #19338 (the release-branch test repair that restored the missing auth/config fixtures) and #19396 (the later Agent grant persistence test backport). Both passed the required test, lint, and browser checks on The remaining coverage-only additions here now conflict with the current release branch and are not needed to restore release health; keeping them out avoids reopening |
|
Agreed — closing is the right call. I verified each part of this before dropping the work, and it all holds up. Both superseding PRs are on the branch, and #19338 fixed the actual blocker better than this PR did:
This PR's blocking half was the Release health is restored without this PR. I ran the four files this PR touches against The conflict is real — And there's no residual coverage to rescue. Only three cases were still unique here — the bounded-window grant expiry, the No changes pushed; leaving this closed. Thanks for the fixture repair in #19338 — that was the real fix. |
PR Created by the Glary-Bot Agent
Summary
cloud/1.54has been red on thetestcheck sincef77fc6af("Backport #19219") landed at 18:20 UTC: 60 unit failures acrossagentPanel.test.ts(53),useFeatureFlags.test.ts(6) anduseBillingContext.test.ts(1). This restores it. Test-only — no production file is touched.Confirmed on PR #19233's run after it merged the branch tip:
testjob 109097426085 →60 failed | 22166 passed.Root cause
Upstream #19219 changed 14 files. The backport carried 8 of them — the production half plus two test files — and dropped the other six, all test/mock updates. So the branch got the new behaviour without telling the tests about it:
isAuthenticatedConfigLoadedmoved offremoteConfigStateonto the newauthenticatedRemoteConfigState. Tests that set only the former to'authenticated'stopped reaching the authenticated branch.agentPanel.tsnow readsisAuthInitializedoffuseCurrentUser().agentPanel.test.tsmocks that composable inline and does not supply the field, so the gate watcher throwsTypeError: Cannot read properties of undefined (reading 'value')atagentPanel.ts:340and takes all 53 tests in the file down with it.Upstream absorbed most of this through
__mocks__/useCurrentUser.tsand__mocks__/remoteConfig.ts. Neither directory exists oncloud/1.54, which is why a clean cherry-pick was never going to carry it.What's here
Every upstream change that has a target on this branch, adapted to its idioms:
isAuthInitializedmock field, andauthenticatedRemoteConfigStatewrites alongside the existingremoteConfigStateones;remoteConfigRevisionconsent-retry case and its off-cloudonAuthHeadercase — both covering code the parent backported with no direct test at all on this branch.Left behind, for cause: the two
__mocks__files (absent here); upstream's gate-settle andunifiedWebSessioncases, whose surrounding suites are main-only; and its on-cloudonAuthHeadercase, which spies on@/platform/auth/firebaseIdentity, also absent here.One assertion gets stronger, not weaker:
is false when the authenticated config omits the keywas passing at the parent for the wrong reason — it took the not-loaded fallback and returnedfalseoffsessionAgentGrant === undefined, never reaching theremoteConfigValue === truecheck its name describes. It now runs on the branch it claims to test.Verification
f77fc6af, four touched suites: 60 failed / 131 passed. This commit: 194 passed / 0 failed.f77fc6af(this sandbox runs node v22 against a repo that wants >=25). None is in a file this PR touches.pnpm typecheckclean; oxfmt, oxlint and eslint clean on the changed files.remoteConfigRevision.valuefrom the gate watcher, and droppingonAuthHeader?.(false)from the off-cloud path. None is vacuous.authenticatedRemoteConfigStatewrites are reset in the hooks of every suite that makes them, and pinned explicitly in the bounded-window case so it cannot go vacuous under reordering.Playwright and interactive-session verification do not apply: nothing renders and no runtime behaviour changes. The real exercise of a unit-test repair is running it, which is what the above is.
Note for a follow-up, not this PR
The gate-settle path the parent shipped (
agentPanel.ts:372-400—GATE_SETTLE_TIMEOUT_MS,scheduleSignedOutFallback,gateSettlednow driven offauthenticatedRemoteConfigState) has no direct test oncloud/1.54. Covering it needs net-new scaffolding rather than a ported upstream case, so it does not belong inside a red-CI repair.Context
This does not fix the
playwright-tests (cloud)failures currently blocking #19238 — those are separately covered by #19236 (conversation screenshot + composer restoration) and #19233 (agentAutogrowTabSwitchReconcile). This is thetestcheck only.