Skip to content

test(cloud/1.54): complete the #19219 backport's test updates - #19311

Closed
DrJKL wants to merge 2 commits into
cloud/1.54from
glary/complete-19219-backport-tests
Closed

DrJKL wants to merge 2 commits into
cloud/1.54from
glary/complete-19219-backport-tests

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

PR Created by the Glary-Bot Agent


Summary

cloud/1.54 has been red on the test check since f77fc6af ("Backport #19219") landed at 18:20 UTC: 60 unit failures across agentPanel.test.ts (53), useFeatureFlags.test.ts (6) and useBillingContext.test.ts (1). This restores it. Test-only — no production file is touched.

Confirmed on PR #19233's run after it merged the branch tip: test job 109097426085 → 60 failed | 22166 passed.

Root cause

Upstream #19219 changed 14 files. The backport carried 8 of them — the production half plus two test files — and dropped the other six, all test/mock updates. So the branch got the new behaviour without telling the tests about it:

  • isAuthenticatedConfigLoaded moved off remoteConfigState onto the new authenticatedRemoteConfigState. Tests that set only the former to 'authenticated' stopped reaching the authenticated branch.
  • agentPanel.ts now reads isAuthInitialized off useCurrentUser(). agentPanel.test.ts mocks that composable inline and does not supply the field, so the gate watcher throws TypeError: Cannot read properties of undefined (reading 'value') at agentPanel.ts:340 and takes all 53 tests in the file down with it.

Upstream absorbed most of this through __mocks__/useCurrentUser.ts and __mocks__/remoteConfig.ts. Neither directory exists on cloud/1.54, which is why a clean cherry-pick was never going to carry it.

What's here

Every upstream change that has a target on this branch, adapted to its idioms:

  • the missing isAuthInitialized mock field, and authenticatedRemoteConfigState writes alongside the existing remoteConfigState ones;
  • upstream's bounded-window case for the transient session grant;
  • upstream's remoteConfigRevision consent-retry case and its off-cloud onAuthHeader case — both covering code the parent backported with no direct test at all on this branch.

Left behind, for cause: the two __mocks__ files (absent here); upstream's gate-settle and unifiedWebSession cases, whose surrounding suites are main-only; and its on-cloud onAuthHeader case, which spies on @/platform/auth/firebaseIdentity, also absent here.

One assertion gets stronger, not weaker: is false when the authenticated config omits the key was passing at the parent for the wrong reason — it took the not-loaded fallback and returned false off sessionAgentGrant === undefined, never reaching the remoteConfigValue === true check its name describes. It now runs on the branch it claims to test.

Verification

  • Parent f77fc6af, four touched suites: 60 failed / 131 passed. This commit: 194 passed / 0 failed.
  • Full unit suite: 22194 passed. The 14 local failures are pre-existing and environmental — I reproduced the same set on a clean checkout of f77fc6af (this sandbox runs node v22 against a repo that wants >=25). None is in a file this PR touches.
  • pnpm typecheck clean; oxfmt, oxlint and eslint clean on the changed files.
  • Mutation-tested. Each of the three new cases was checked against a deliberately broken production line and each failed as intended: dropping remoteConfigRevision.value from the gate watcher, and dropping onAuthHeader?.(false) from the off-cloud path. None is vacuous.
  • Order-stable across shuffled seeds — the new authenticatedRemoteConfigState writes are reset in the hooks of every suite that makes them, and pinned explicitly in the bounded-window case so it cannot go vacuous under reordering.

Playwright and interactive-session verification do not apply: nothing renders and no runtime behaviour changes. The real exercise of a unit-test repair is running it, which is what the above is.

Note for a follow-up, not this PR

The gate-settle path the parent shipped (agentPanel.ts:372-400 — GATE_SETTLE_TIMEOUT_MS, scheduleSignedOutFallback, gateSettled now driven off authenticatedRemoteConfigState) has no direct test on cloud/1.54. Covering it needs net-new scaffolding rather than a ported upstream case, so it does not belong inside a red-CI repair.

Context

This does not fix the playwright-tests (cloud) failures currently blocking #19238 — those are separately covered by #19236 (conversation screenshot + composer restoration) and #19233 (agentAutogrowTabSwitchReconcile). This is the test check only.

Backport f77fc6a ("Backport #19219") shipped the production half of the
agent gate auth lifecycle fix but not the six test/mock files the upstream
PR changed, so cloud/1.54 has been red on `test` since it landed: 60 unit
failures across agentPanel, useFeatureFlags and useBillingContext.

Two production changes the tests were never told about:

- `isAuthenticatedConfigLoaded` now reads `authenticatedRemoteConfigState`
  instead of `remoteConfigState`, so tests that only set the latter to
  'authenticated' no longer reach the authenticated branch.
- `agentPanel.ts` now reads `isAuthInitialized` off `useCurrentUser()`,
  which agentPanel.test.ts's inline mock does not provide — the gate
  watcher throws `Cannot read properties of undefined` and takes all 53
  tests in the file down with it.

Ported every upstream change that has a target on this branch, adapted to
its idioms: the mock and state writes above, upstream's bounded-window
case for the transient session grant, its `remoteConfigRevision`
consent-retry case, and its off-cloud `onAuthHeader` case — the last two
covering code the parent backported with no direct test at all.

Left behind, for cause: upstream's edits to `__mocks__/useCurrentUser.ts`
and `__mocks__/remoteConfig.ts`, neither of which exists here; its
gate-settle and unifiedWebSession cases, whose surrounding suites are
main-only; and its on-cloud `onAuthHeader` case, which spies on
`@/platform/auth/firebaseIdentity`, also absent here.

Also reset `authenticatedRemoteConfigState` in the hooks of every suite
that writes it, so the new writes cannot leak into a sibling test under
reordering, and pinned it explicitly in the bounded-window case so that
case cannot go vacuous.
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 10:29pm UTC
billing-web-test Ignored Ignored Sep 28, 2026 10:29pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: daf7481a-1f78-41a7-95ce-2914384ab33e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@fennuck-bot

fennuck-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

No code change from me here — this is the automated "review skipped" notice rather than review feedback. .coderabbit.yaml disables auto-review on any base other than the default branch, and this PR targets cloud/1.54, so nothing was actually reviewed and there is nothing to address.

Taking up the offer to run one explicitly, since a release-branch change is worth a second pass:

@coderabbitai review

For whoever picks this up: the diff is test-only (4 *.test.ts files, +70/−1, no production file touched). The thing most worth checking is that none of the new/adjusted cases passes vacuously. Each of the three new cases was mutation-tested against a deliberately broken production line and each failed as intended — remoteConfigRevision.value dropped from the gate watcher, and onAuthHeader?.(false) dropped from the off-cloud path in api.ts.

@DrJKL
DrJKL marked this pull request as ready for review September 28, 2026 22:29
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 11:07:01 PM UTC

Links

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 82.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 175.6 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 40ms TBT · 158.8 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 53ms TBT · 172.4 MB heap
vue-zoom-out-idle: · 58.1 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 173.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 470ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.3 MB
canvas-idle: DOM nodes -139
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 16ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 62
canvas-mouse-sweep: task duration 797ms
canvas-mouse-sweep: script duration 125ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.4 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -196
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 312ms
canvas-zoom-sweep: script duration 9ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 379ms
dom-widget-clipping: script duration 133ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.9 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 548ms
large-graph-idle: script duration 28ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1343ms
large-graph-pan: script duration 629ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.0 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 9ms
large-graph-zoom: style recalc duration 8ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1351ms
large-graph-zoom: script duration 585ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 8
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1561ms
legacy-node-drag: script duration 756ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.2 MB
legacy-node-drag: DOM nodes 6
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 515ms
minimap-idle: script duration 24ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.9 MB
minimap-idle: DOM nodes -271
minimap-idle: event listeners -175
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 339ms
subgraph-dom-widget-clipping: script duration 109ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.8 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 455ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 74.1 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 19ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 676ms
subgraph-mouse-sweep: script duration 76ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.9 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -241
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 802ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 128ms
subgraph-transition-enter: heap used 82.2 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 25ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4745ms
viewport-pan-sweep: script duration 2061ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.9 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11984ms
vue-large-graph-idle: script duration 153ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 175.6 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14935
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 86
vue-large-graph-pan: task duration 15340ms
vue-large-graph-pan: script duration 770ms
vue-large-graph-pan: TBT 40ms
vue-large-graph-pan: heap used 158.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 66ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4396ms
vue-node-resize-workload: script duration 68ms
vue-node-resize-workload: TBT 53ms
vue-node-resize-workload: heap used 172.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14932
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 6033ms
vue-zoom-out-idle: script duration 80ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 173.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 80ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-28T23:40:20.140Z",
  "gitSha": "a3e68e0603635cfa9220cdcc0e7b8c72229234d4",
  "branch": "glary/complete-19219-backport-tests",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2068.366000000026,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.208000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 478.3209999999999,
      "heapDeltaBytes": 10378344,
      "heapUsedBytes": 81557928,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.7200000000000015,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2030.8809999999653,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.222999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 462.28100000000006,
      "heapDeltaBytes": -13105024,
      "heapUsedBytes": 57391856,
      "domNodes": 2,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 7.204000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1829.636999999991,
      "styleRecalcs": 51,
      "styleRecalcDurationMs": 11.374999999999998,
      "layouts": 14,
      "layoutDurationMs": 3.2230000000000003,
      "taskDurationMs": 846.863,
      "heapDeltaBytes": -1657188,
      "heapUsedBytes": 69324944,
      "domNodes": -284,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 128.258,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1743.4219999999527,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 20.94,
      "layouts": 14,
      "layoutDurationMs": 3.376,
      "taskDurationMs": 746.788,
      "heapDeltaBytes": -9113988,
      "heapUsedBytes": 61441056,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 121.203,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.202999999969,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.989,
      "layouts": 6,
      "layoutDurationMs": 1.155,
      "taskDurationMs": 309.67499999999995,
      "heapDeltaBytes": 4247512,
      "heapUsedBytes": 74781580,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.964,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1721.7699999999923,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.083000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.0730000000000002,
      "taskDurationMs": 314.841,
      "heapDeltaBytes": 4550156,
      "heapUsedBytes": 75679772,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 8.944,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 557.7250000000049,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 6.8660000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 382.853,
      "heapDeltaBytes": -7586772,
      "heapUsedBytes": 63592004,
      "domNodes": 22,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 133.503,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 545.7640000000197,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.462999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.74300000000005,
      "heapDeltaBytes": 18576020,
      "heapUsedBytes": 89186072,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 131.801,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.877999999987,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 9.499,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 531.6139999999999,
      "heapDeltaBytes": 10973092,
      "heapUsedBytes": 87522820,
      "domNodes": -268,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 28.640000000000004,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2069.2830000000413,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.010000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 563.9540000000001,
      "heapDeltaBytes": 10912212,
      "heapUsedBytes": 87559288,
      "domNodes": -266,
      "jsHeapTotalBytes": -2461696,
      "scriptDurationMs": 27.408999999999995,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2177.216000000044,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 10.416000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1382.4509999999998,
      "heapDeltaBytes": 4519332,
      "heapUsedBytes": 81681068,
      "domNodes": -277,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 642.4730000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2114.9740000000747,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 7.799,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1304.316,
      "heapDeltaBytes": 19980384,
      "heapUsedBytes": 86131444,
      "domNodes": -273,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 614.6510000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3110.087999999962,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 7.844999999999998,
      "layouts": 60,
      "layoutDurationMs": 9.312000000000001,
      "taskDurationMs": 1341.2770000000003,
      "heapDeltaBytes": 8111908,
      "heapUsedBytes": 75930860,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 582.898,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3157.1579999999813,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 7.33,
      "layouts": 60,
      "layoutDurationMs": 9.271999999999998,
      "taskDurationMs": 1360.937,
      "heapDeltaBytes": 8044556,
      "heapUsedBytes": 76184032,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 588.033,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2402.807999999993,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 6.4559999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1589.948,
      "heapDeltaBytes": -4652300,
      "heapUsedBytes": 77415816,
      "domNodes": 10,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 766.165,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2469.0219999999954,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.0409999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1531.905,
      "heapDeltaBytes": 16565232,
      "heapUsedBytes": 84589036,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 745.4480000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.4779999999778,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.132000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.27600000000007,
      "heapDeltaBytes": 21860356,
      "heapUsedBytes": 88276672,
      "domNodes": -269,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 23.716,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.2279999999892,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.6679999999999966,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.7799999999999,
      "heapDeltaBytes": 10122652,
      "heapUsedBytes": 87712576,
      "domNodes": -272,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 23.512999999999998,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 529.734000000019,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.332,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 332.611,
      "heapDeltaBytes": 14335948,
      "heapUsedBytes": 87058384,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 107.055,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 538.2879999999659,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.436,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 346.074,
      "heapDeltaBytes": 14026072,
      "heapUsedBytes": 86685088,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 110.25099999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.1240000000134,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.965,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.889,
      "heapDeltaBytes": 7175308,
      "heapUsedBytes": 80602868,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 6.542999999999998,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2000.2829999999676,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.975000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.00600000000003,
      "heapDeltaBytes": 1313340,
      "heapUsedBytes": 74896868,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.189000000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.451000000016,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.613,
      "layouts": 18,
      "layoutDurationMs": 3.358,
      "taskDurationMs": 664.284,
      "heapDeltaBytes": -9798688,
      "heapUsedBytes": 62875788,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 75.529,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1699.87500000002,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 19.076000000000004,
      "layouts": 18,
      "layoutDurationMs": 3.262,
      "taskDurationMs": 686.8319999999999,
      "heapDeltaBytes": 6062836,
      "heapUsedBytes": 79526856,
      "domNodes": -297,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 76.005,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 984.4640000000027,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.667,
      "layouts": 15,
      "layoutDurationMs": 11.160000000000002,
      "taskDurationMs": 801.958,
      "heapDeltaBytes": -5264376,
      "heapUsedBytes": 86184100,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 21.182,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8230.744000000015,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 24.733,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4727.496,
      "heapDeltaBytes": 2411652,
      "heapUsedBytes": 79235568,
      "domNodes": -282,
      "jsHeapTotalBytes": 909312,
      "scriptDurationMs": 2041.3329999999999,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8227.28200000006,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 25.142,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4762.296,
      "heapDeltaBytes": 13535820,
      "heapUsedBytes": 90415628,
      "domNodes": -266,
      "jsHeapTotalBytes": 647168,
      "scriptDurationMs": 2081.665,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12715.419999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11958.162999999999,
      "heapDeltaBytes": -29501088,
      "heapUsedBytes": 183747136,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10399744,
      "scriptDurationMs": 153.376,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12752.730999999927,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12009.024,
      "heapDeltaBytes": -55176388,
      "heapUsedBytes": 184593924,
      "domNodes": -8068,
      "jsHeapTotalBytes": -6754304,
      "scriptDurationMs": 153.136,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15953.080999999998,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 12.991000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15414.675999999998,
      "heapDeltaBytes": -39473592,
      "heapUsedBytes": 166849888,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19275776,
      "scriptDurationMs": 782.347,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 60,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15814.579999999978,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 12.707999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15265.682000000003,
      "heapDeltaBytes": -61801468,
      "heapUsedBytes": 166200328,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18497536,
      "scriptDurationMs": 757.774,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 19,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4460.264999999992,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.52399999999997,
      "layouts": 20,
      "layoutDurationMs": 29.965000000000007,
      "taskDurationMs": 4331.294,
      "heapDeltaBytes": -41659240,
      "heapUsedBytes": 177299864,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11476992,
      "scriptDurationMs": 67.70799999999998,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 37,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4588.0750000000035,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 64.42399999999998,
      "layouts": 20,
      "layoutDurationMs": 19.001000000000005,
      "taskDurationMs": 4460.0740000000005,
      "heapDeltaBytes": -27815828,
      "heapUsedBytes": 184239004,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12943360,
      "scriptDurationMs": 69.015,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 69,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6323.144000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5993.532000000002,
      "heapDeltaBytes": 731788,
      "heapUsedBytes": 178440592,
      "domNodes": 0,
      "jsHeapTotalBytes": -25952256,
      "scriptDurationMs": 76.83000000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6376.152000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6073.4,
      "heapDeltaBytes": 5365824,
      "heapUsedBytes": 184321196,
      "domNodes": 0,
      "jsHeapTotalBytes": -12582912,
      "scriptDurationMs": 83.31300000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 455.8640000000196,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 19.669,
      "layouts": 3,
      "layoutDurationMs": 1.64,
      "taskDurationMs": 102.077,
      "heapDeltaBytes": 4944336,
      "heapUsedBytes": 73620600,
      "domNodes": 147,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.334000000000001,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 91.829999999959,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.367,
      "layouts": 2,
      "layoutDurationMs": 1.0799999999999998,
      "taskDurationMs": 57.04100000000001,
      "heapDeltaBytes": 2989176,
      "heapUsedBytes": 71847700,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.7239999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50747 75942 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
@datadog-official

datadog-official Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 1 Pipeline job failed

CI: Tests Unit | test — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4ad7a07 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Sep 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19311   +/-   ##
=============================================
  Coverage              ?   66.82%           
=============================================
  Files                 ?     1677           
  Lines                 ?    75771           
  Branches              ?        0           
=============================================
  Hits                  ?    50635           
  Misses                ?    25136           
  Partials              ?        0           
Flag Coverage Δ
e2e 66.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor

Closing as superseded by #19338 (the release-branch test repair that restored the missing auth/config fixtures) and #19396 (the later Agent grant persistence test backport). Both passed the required test, lint, and browser checks on cloud/1.54.

The remaining coverage-only additions here now conflict with the current release branch and are not needed to restore release health; keeping them out avoids reopening cloud/1.54 for non-blocking test expansion.

@fennuck-bot

fennuck-bot Bot commented Sep 29, 2026

Copy link
Copy Markdown

Agreed — closing is the right call. I verified each part of this before dropping the work, and it all holds up.

Both superseding PRs are on the branch, and #19338 fixed the actual blocker better than this PR did:

cloud/1.54
#19338 6c9e44172a
#19396 0f5da8a74f

This PR's blocking half was the isAuthInitialized mock and the authenticatedRemoteConfigState writes. #19338 already carries all of it — 11 authenticatedRemoteConfigState references in useFeatureFlags.test.ts, 3 in useBillingContext.test.ts, and the sessionAgentGrantValidUntil pin on the transient-grant case. It also models auth readiness as a mutable ref(true) wired into the mock and toggled per-test, where I had hardcoded computed(() => true) — mine would have left the uninitialized-auth path untestable. Yours is strictly the better fixture.

Release health is restored without this PR. I ran the four files this PR touches against cloud/1.54 HEAD (150b6c85f0) in a clean worktree:

Test Files  4 passed (4)
     Tests  191 passed (191)

The conflict is real — git merge-tree against current cloud/1.54 conflicts in src/extensions/core/agentPanel.test.ts, on exactly the mock block #19338 rewrote.

And there's no residual coverage to rescue. Only three cases were still unique here — the bounded-window grant expiry, the remoteConfigRevision consent retry, and the off-cloud onAuthHeader assertion. All three already exist on main, which is where they originated in #19219. So there's nothing worth reopening the release branch for, and nothing to port elsewhere either.

No changes pushed; leaving this closed. Thanks for the fixture repair in #19338 — that was the real fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants