Repository navigation
chore: remove AI co-author check - #19393
Conversation
🎭 Playwright: ✅ 2160 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e51671a5dbde87fa8799d64d7b1c3c7aa10ef23a
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzipDetailsSummary
Category Glance App Entry Points — 3.77 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.45 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 133 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 643 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 39.4 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 125 kBReusable component library chunks
Status: 16 added Data & Services — 4.05 MBStores, services, APIs, and repositories
Status: 15 added Utilities & Hooks — 582 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.9 MBBundles that do not match a named category
Status: 300 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T09:15:38.115Z",
"gitSha": "c4201bdda52a962470fa3aa3876c248a181753f6",
"branch": "chore/remove-ai-co-author-check",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.2430000000127,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.592,
"heapDeltaBytes": -21953860,
"heapUsedBytes": 76526392,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.731,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.771000000077,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.805999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.156,
"heapDeltaBytes": -36771372,
"heapUsedBytes": 61788300,
"domNodes": -228,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.165000000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.3610000000067,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.426000000000002,
"layouts": 12,
"layoutDurationMs": 4.356999999999999,
"taskDurationMs": 853.364,
"heapDeltaBytes": -38377056,
"heapUsedBytes": 60136132,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 168.56,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1851.3110000000097,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.331,
"layouts": 12,
"layoutDurationMs": 4.77,
"taskDurationMs": 772.395,
"heapDeltaBytes": -14757216,
"heapUsedBytes": 64246016,
"domNodes": -228,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 180.124,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.4980000000305,
"styleRecalcs": 33,
"styleRecalcDurationMs": 9.598000000000003,
"layouts": 6,
"layoutDurationMs": 1.1460000000000001,
"taskDurationMs": 316.637,
"heapDeltaBytes": 1504600,
"heapUsedBytes": 80246976,
"domNodes": 53,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.096000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.5970000000698,
"styleRecalcs": 34,
"styleRecalcDurationMs": 9.558,
"layouts": 6,
"layoutDurationMs": 1.1009999999999998,
"taskDurationMs": 323.725,
"heapDeltaBytes": -18627508,
"heapUsedBytes": 79948548,
"domNodes": 53,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 11.196000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 680.6589999999915,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.1930000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.788,
"heapDeltaBytes": 18334532,
"heapUsedBytes": 96726948,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 167.491,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 663.9579999999796,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.2780000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.413,
"heapDeltaBytes": -1674356,
"heapUsedBytes": 96816284,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 168.717,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1161.9399999999587,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.5870000000001,
"heapDeltaBytes": 6601260,
"heapUsedBytes": 82264744,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 70.277,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 35.351515151515166,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.5240000000385,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 818.893,
"heapDeltaBytes": 6153016,
"heapUsedBytes": 83755292,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 71.72300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 549,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.6449999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.61099999999954,
"heapDeltaBytes": 15688692,
"heapUsedBytes": 90252360,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 173.307,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.485294117647058,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 880.1849999999831,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.30700000000047,
"heapDeltaBytes": 14435932,
"heapUsedBytes": 92549652,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.47500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.53611111111109,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9849.990999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9104.631,
"heapDeltaBytes": 3850624,
"heapUsedBytes": 84579728,
"domNodes": 0,
"jsHeapTotalBytes": -6553600,
"scriptDurationMs": 7773.794,
"eventListeners": 0,
"totalBlockingTimeMs": 1401,
"frameDurationMs": 35.55812274368231,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11309.502000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10297.787,
"heapDeltaBytes": -8995760,
"heapUsedBytes": 72132036,
"domNodes": 0,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8651.604000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1586,
"frameDurationMs": 33.72985074626866,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10443.472999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9497.957,
"heapDeltaBytes": -1383364,
"heapUsedBytes": 78801184,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7872.463000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1215,
"frameDurationMs": 32.200308641975305,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9738.455000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8872.012999999999,
"heapDeltaBytes": -13347856,
"heapUsedBytes": 67442280,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7303.871,
"eventListeners": 0,
"totalBlockingTimeMs": 892,
"frameDurationMs": 31.600649350649352,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2035.8980000000315,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1330000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.3339999999998,
"heapDeltaBytes": -35797004,
"heapUsedBytes": 83104076,
"domNodes": -228,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 31.612000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.697000000033,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.9780000000001,
"heapDeltaBytes": -36333664,
"heapUsedBytes": 82546364,
"domNodes": -228,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 30.73899999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2431.539999999984,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1626.2920000000001,
"heapDeltaBytes": 24130096,
"heapUsedBytes": 86549508,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 852.381,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666438356164385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2396.8419999999924,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.507000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1618.6730000000002,
"heapDeltaBytes": 20334772,
"heapUsedBytes": 82535576,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 845.219,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.783098591549294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3534.011000000021,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.246000000000002,
"layouts": 60,
"layoutDurationMs": 13.224,
"taskDurationMs": 1647.8360000000002,
"heapDeltaBytes": 8778188,
"heapUsedBytes": 72700076,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.175,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66650943396226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3571.572999999944,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.094,
"layouts": 60,
"layoutDurationMs": 13.336,
"taskDurationMs": 1635.3890000000001,
"heapDeltaBytes": 12205200,
"heapUsedBytes": 77461924,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 779.3820000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3158.0000000000155,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.537,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1914.653,
"heapDeltaBytes": 24370092,
"heapUsedBytes": 89119200,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 980.847,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.754787234042556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3186.2899999999854,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.983000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1893.1379999999997,
"heapDeltaBytes": 25945300,
"heapUsedBytes": 90206892,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 968.128,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753968253968253,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2036.2819999999715,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.2450000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.635,
"heapDeltaBytes": -36834920,
"heapUsedBytes": 83772400,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 30.096999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.6300000000492,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8069999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.78100000000006,
"heapDeltaBytes": 21421092,
"heapUsedBytes": 84289344,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.43899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.3369999999763,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.444000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.00899999999996,
"heapDeltaBytes": 12994024,
"heapUsedBytes": 93772616,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 144.916,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 582.51800000005,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.7280000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.48100000000005,
"heapDeltaBytes": 13195380,
"heapUsedBytes": 93491976,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 152.315,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2042.0759999999518,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.913,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.3370000000001,
"heapDeltaBytes": -20491332,
"heapUsedBytes": 60329368,
"domNodes": -244,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.644000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2051.590000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8310000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.41299999999995,
"heapDeltaBytes": -9737660,
"heapUsedBytes": 70873396,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 7.674999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.6979999999858,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.939000000000002,
"layouts": 16,
"layoutDurationMs": 5.1080000000000005,
"taskDurationMs": 747.071,
"heapDeltaBytes": -20982636,
"heapUsedBytes": 60103308,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.104,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.826923076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.5840000000462,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.902,
"layouts": 16,
"layoutDurationMs": 5.451,
"taskDurationMs": 754.97,
"heapDeltaBytes": -4129956,
"heapUsedBytes": 76655512,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 110.91100000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664761904761907,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.9290000000037,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.413999999999998,
"layouts": 5,
"layoutDurationMs": 12.812000000000001,
"taskDurationMs": 855.5810000000001,
"heapDeltaBytes": 21398700,
"heapUsedBytes": 95795484,
"domNodes": 13667,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 36.167,
"eventListeners": 2383,
"totalBlockingTimeMs": 130,
"frameDurationMs": 19.481690140845068,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8334.136,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.14300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5651.363,
"heapDeltaBytes": -35064436,
"heapUsedBytes": 83626356,
"domNodes": -228,
"jsHeapTotalBytes": 356352,
"scriptDurationMs": 2744.995,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8527.230000000032,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.870999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5691.5869999999995,
"heapDeltaBytes": -36632208,
"heapUsedBytes": 83125824,
"domNodes": -228,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 2818.185,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69862745098039,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16579.835000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15816.369999999999,
"heapDeltaBytes": -33520780,
"heapUsedBytes": 174412948,
"domNodes": -3045,
"jsHeapTotalBytes": 8425472,
"scriptDurationMs": 292.463,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.99073426573426,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 16642.334000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15937.454,
"heapDeltaBytes": -39419980,
"heapUsedBytes": 175968928,
"domNodes": -3045,
"jsHeapTotalBytes": 4399104,
"scriptDurationMs": 249.907,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.94773519163763,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 20557.335999999963,
"styleRecalcs": 166,
"styleRecalcDurationMs": 16.397000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20183.156,
"heapDeltaBytes": -18134576,
"heapUsedBytes": 168282376,
"domNodes": -8049,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 899.562,
"eventListeners": -14923,
"totalBlockingTimeMs": 62,
"frameDurationMs": 38.772075471698116,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20616.193999999952,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.155999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20293.696,
"heapDeltaBytes": -48912804,
"heapUsedBytes": 180077192,
"domNodes": -3045,
"jsHeapTotalBytes": 2301952,
"scriptDurationMs": 878.393,
"eventListeners": -14915,
"totalBlockingTimeMs": 47,
"frameDurationMs": 38.17740740740741,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6006.12000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.692,
"layouts": 20,
"layoutDurationMs": 22.710999999999995,
"taskDurationMs": 5945.482999999999,
"heapDeltaBytes": -24929532,
"heapUsedBytes": 199883344,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 105.73799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 371,
"frameDurationMs": 35.29235294117647,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6178.099999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.69099999999999,
"layouts": 20,
"layoutDurationMs": 22.28100000000001,
"taskDurationMs": 6085.868,
"heapDeltaBytes": -41396660,
"heapUsedBytes": 175639956,
"domNodes": -8049,
"jsHeapTotalBytes": 13627392,
"scriptDurationMs": 110.97000000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 374,
"frameDurationMs": 36.307738095238086,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8273.82799999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7973.146999999999,
"heapDeltaBytes": -36380348,
"heapUsedBytes": 195855692,
"domNodes": -3045,
"jsHeapTotalBytes": 6336512,
"scriptDurationMs": 146.58900000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.452205882352942,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8514.517999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8267.366,
"heapDeltaBytes": 6167432,
"heapUsedBytes": 192183932,
"domNodes": -1,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 123.59100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.77692307692308,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 125.60399999995298,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.617,
"layouts": 4,
"layoutDurationMs": 2.056,
"taskDurationMs": 105.871,
"heapDeltaBytes": -16661724,
"heapUsedBytes": 79888632,
"domNodes": 113,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.811,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.674999999999955,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 486.20899999991707,
"styleRecalcs": 15,
"styleRecalcDurationMs": 13.765999999999998,
"layouts": 3,
"layoutDurationMs": 0.8770000000000001,
"taskDurationMs": 130.83899999999997,
"heapDeltaBytes": -14313068,
"heapUsedBytes": 82467544,
"domNodes": 101,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.259999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 875.5709999999226,
"styleRecalcs": 78,
"styleRecalcDurationMs": 103.504,
"layouts": 76,
"layoutDurationMs": 21.571,
"taskDurationMs": 827.9530000000001,
"heapDeltaBytes": -7406232,
"heapUsedBytes": 84925012,
"domNodes": 76,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 335.63,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 917.2429999999849,
"styleRecalcs": 78,
"styleRecalcDurationMs": 103.811,
"layouts": 76,
"layoutDurationMs": 21.241,
"taskDurationMs": 878.763,
"heapDeltaBytes": 18282056,
"heapUsedBytes": 87416880,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 371.55000000000007,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66545454545455,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1358.983999999964,
"styleRecalcs": 78,
"styleRecalcDurationMs": 235.396,
"layouts": 76,
"layoutDurationMs": 22.918999999999997,
"taskDurationMs": 1349.3570000000002,
"heapDeltaBytes": -19781348,
"heapUsedBytes": 112571952,
"domNodes": -7945,
"jsHeapTotalBytes": -3973120,
"scriptDurationMs": 435.224,
"eventListeners": -1228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.875,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1394.1599999999426,
"styleRecalcs": 78,
"styleRecalcDurationMs": 247.279,
"layouts": 76,
"layoutDurationMs": 24.604999999999997,
"taskDurationMs": 1384.792,
"heapDeltaBytes": -10686680,
"heapUsedBytes": 112560332,
"domNodes": -7945,
"jsHeapTotalBytes": -4497408,
"scriptDurationMs": 450.916,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.29000000000001,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe pull request removes the script that checked commit trailers and author and committer identities for configured AI-agent patterns. It also removes the pull-request workflow that ran the script. ChangesAI co-author check
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change removes an AI co-author commit check from CI. It does not affect runtime behavior, and no merge-blocking risk was found. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19393 +/- ##
==========================================
+ Coverage 84.15% 84.99% +0.84%
==========================================
Files 3226 2332 -894
Lines 155844 133137 -22707
Branches 42175 33944 -8231
==========================================
- Hits 131146 113162 -17984
+ Misses 22970 19621 -3349
+ Partials 1728 354 -1374
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ ## ELI5 A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 ## Motivation This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. ## Provenance - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. ## Reviewer context - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) ## Summary ### The fix (`src/lib/litegraph/src/subgraph/SubgraphNode.ts`) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. ### New tests - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. ### E2E confirmation (CI run [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. ## Test plan - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- Co-authored-by: Claude <noreply@anthropic.com>
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) (The two conflicting test files are byte-identical between core/1.54 and cloud/1.54 at their merge base, so this is the same resolution as the core/1.54 carrier. `SubgraphNode.ts` differs slightly between the two branches but the fix applied cleanly to both.)
<!-- ccr-slack-attribution --> _Requested by **Jo Zhang, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789707519592879?thread_ts=1789707519.592879&cid=C0BGH348Z0C)_ A subgraph node shows several "promoted" widgets from the nodes hidden inside it (like width, height, seed). When you rewire the connection behind just one of those widgets, the others could flicker, duplicate, or vanish for a moment, and the wired-in widget itself could disappear. This PR fixes that and adds tests at both levels: unit tests prove the mechanism, and the browser-level repro tests — which this PR's own CI confirmed now pass with the fix — are kept as plain regression tests. - Fixes #14495 This started as a REPRO-ONLY PR for a reported bug: wiring a new node into a subgraph's promoted "prompt" widget makes the subgraph's *other* promoted widgets render duplicated, and a closely related report has the rewired widget itself disappear with redo misplacing the wire. Investigation traced a confirmed mechanism for the disappearing half at the data-model layer (see Summary). Once that mechanism was nailed down precisely enough to fix without guessing, and a second, more contained duplication theory was checked and refuted, it became worth landing the fix and the validating tests in the same PR rather than leaving a fully-diagnosed, small, well-scoped bug unfixed. - **Authored by:** interactive session, Claude Code - **Verified:** `pnpm exec vitest run src/lib/litegraph/src/subgraph/SubgraphWidgetPromotion.test.ts` — 51 passed, 0 failed (was 50 passed / 1 expected fail before the fix; that case now passes for real and was flipped from `it.fails` to `it`). `pnpm exec vitest run src/lib/litegraph/src/subgraph/ src/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.ts src/stores/widgetValueStore.test.ts src/stores/domWidgetStore.test.ts` — 413 passed, 0 failed. `pnpm typecheck`, `pnpm lint`, `pnpm knip` — clean. E2E confirmation came from this PR's own CI (see Summary). Re-verified after the 2026-10-01 rebase onto main: same scoped suites green, typecheck/lint/knip clean. - **Deviations:** none remaining. The previous push deliberately left the e2e `test.fail()` cases unflipped pending CI evidence; that evidence has now arrived (see "E2E confirmation" below) and they are flipped to plain `test()` in this push, exactly per the plan recorded in the earlier Test plan. - **Type:** fix + test — a small, contained timing fix plus the tests that prove it, validate/refute an alternate duplication theory, and lock in the browser-level symptom as regression coverage - **Slots into:** a subgraph promoted-widget-promotion bug investigation; no project or epic, ad-hoc follow-up to that investigation - **Not in scope:** `createPromotedMultilineWidget`'s visibility/suppression path — that's PR #18085's territory (a sibling investigation into the same widget family) Rewiring the interior link behind a promoted widget (e.g. dragging a new node onto an already-promoted widget's socket) removes the old link before the new one lands. `SubgraphInputNode`'s `'input-disconnected'` handler used to demote the widget **synchronously** — clearing `input.widgetId`/`.widget`/`._widget` immediately — while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick, `hostNode.widgets.length` (synchronous) and the store's tracked id count for that node (deferred) disagreed. The Vue widget grid (`useProcessedWidgets`/`computeProcessedWidgets`) reads its render *order* from the store and its liveness *filter* from `hostNode.widgets` — i.e. from both sides of that exact disagreement. The fix defers the demotion itself by a microtask (mirroring the already-deferred store cleanup), tracked with a per-input cancellation token. The `'input-connected'` listener clears that token on a same-tick reconnect, so a rewire never drops the widget from `hostNode.widgets` at all. A genuine disconnect with no reconnect still fully demotes once the microtask runs — nothing about final-state behavior changes, only the timing of an in-between state that used to be observable. **Deliberate timing-change note** (per this repo's own ecosystem-impact rule for changes touching `node.widgets` access): this changes when a disconnect becomes observable on `hostNode.widgets` — previously synchronous, now one microtask tick later for a genuine disconnect. Two existing tests in `SubgraphWidgetPromotion.test.ts` asserted this synchronously with no `await`; both were updated to `await Promise.resolve()` after the disconnecting call, with a comment explaining why. No public API shape or callback signature changed — only internal timing. - `SubgraphWidgetPromotion.test.ts`, "keeps every promoted widget present while rewiring the interior link behind one of them" (previously `it.fails`, now a plain `it`): builds a host with 4 promoted widgets from 4 different interior nodes, rewires the link behind one of them onto a *new* interior node mid-test, and asserts `hostNode.widgets.length` stays at 4 throughout — including immediately after the disconnect step, before the reconnect lands. - `SubgraphWidgetPromotion.test.ts`, "Promoted textarea dual-registration (PM-1328 duplication lead)": tests a second, independently-raised theory for the duplication symptom — that a promoted textarea's DOM-hosted widget (a `DOMWidgetImpl` living in `useDomWidgetStore`, materialized by `createPromotedHostWidget`) and a store-projected row could both end up registered for the same input, which would duplicate a row in the widget grid. Built a minimal `SubgraphNode` subclass wired the same way the app's real subclass is, exercised it across a rewire and a `configure()` reconfigure. **Both pass as-is — the theory is refuted.** `_projectPromotedWidget`'s `if (input._widget) return input._widget` guard is unconditional across every call site and there's no observable window where `input.widgetId` is set while `input._widget` isn't. Kept as regression coverage. [35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)) CI on the previous head answered the open question the `test.fail()` repros were posted to ask — the fix **does** resolve the browser-level symptom end-to-end: - Both `subgraphPromotedWidgetRewireDuplication.spec.ts` repro scenarios (interior rewire and external boundary wire) were reported "Expected to fail, but passed" on every run and retry (video job + shard 12, 4/4 retries). Flipped to plain `test()` regression tests, and retitled to describe the behavior they now guarantee. - `subgraphPromotion.spec.ts` "Promoted STRING widget edit survives a rebind of the interior link" — a *pre-existing* `test.fail()` for #14495 — also passed on all 4 shard-12 attempts. Flipped to plain `test()`; hence "Fixes #14495" above. - The external-boundary undo test went through two CI-informed revisions after the rebase: which snapshot undo targets depends on change-tracker capture timing the test cannot control (captures fire on window mouseup, before the click handlers that apply promotions, so the entry pushed by the slot drop — #18117 — can lag the built baseline by one action), and an attempt to pin the snapshot with an extra canvas click timed out in CI. The test now asserts the invariant both reported symptoms violate instead of a fixed widget set: whatever state undo restores, the host's model holds no duplicate widgets and the grid renders exactly one row per model widget, none otherwise. - [x] Watch this PR's `playwright-video-new-tests` CI check: the `test.fail()` cases were reported as unexpectedly passed (run 35419314544) - [x] Flip those cases (and the pre-existing #14495 one) to plain `test()` - [x] Make the external-boundary undo test deterministic (it now asserts render/model consistency after undo instead of assuming which snapshot undo targets) - [ ] CI green on the rebased head (the "Check for AI agent co-author trailers" check was removed from main in #19393; the first commit still carries trailers, and rewording it remains a maintainer call since it rewrites shared history) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01U6aDANuoAYDtxd9WiCk44Q --------- (cherry picked from commit 9ee67cb) ## Backport adaptation (core/1.54) The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean and is byte-identical to upstream. Only two test files conflicted, both because the cherry-pick's context included neighbouring code that is not on this branch: - `useErrorClearingHooks.test.ts` — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which main gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" async and await the deferred demotion. - `SubgraphWidgetPromotion.test.ts` — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block; verified all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which main imports from the litegraph barrel in a neighbouring non-conflicting import hunk, so this branch's version of that hunk won and left it out; the test failed with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel on this branch. No backport-only compatibility shim was needed and no public API shape or callback signature changed. The deliberate timing change this PR documents (a genuine disconnect becomes observable on `hostNode.widgets` one microtask later) is carried as-is.
…lues (#19979) (#20561) ## Summary Backports [#19979](#19979) (`fix(agent): apply positional overflow widget values`, merged to `main` as `99c46fe15f974be23379dee6ed456836061db8b7`) onto `cloud/1.55`, so `_extra_N` document widget values resolve to the Nth serializable live widget during Agent graph apply instead of being dropped. `cloud/1.55` currently carries **no** positional-overflow resolution at all — `OVERFLOW_WIDGET_NAME_RE` has 0 occurrences in `liveGraphApplier.ts` on the base — while the detector this fix exists for (`agent_graph_widget_missing`, Linear [BE-16625](https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a)) is firing in production on `1.55.16`/`1.55.17`/`1.55.18`. `#19979` is not an ancestor of `origin/cloud/1.55` (`git merge-base --is-ancestor` → exit 1) and no backport existed. ## Changes - **What**: two commits. 1. `be980c441e` — `git cherry-pick -x 99c46fe`, applied **clean**. The added/removed lines are byte-identical to the upstream commit (1,409 `+`/`-` lines diffed equal; only hunk offsets and blob indexes differ). 2. `7a6fddba1e` — the one release-branch resolution needed to make it compile, described below. - **Breaking**: none. - **Dependencies**: none added. Imports only modules `cloud/1.55` already ships. ### The one resolution, stated plainly `#19979`'s gate reads the node's nested input specs through `@/schemas/nodeDef/inputSpecTree`, **which does not exist on `cloud/1.55`**. That module needs `zDynamicGroupInputSpec`, `zDynamicComboOption`, `zDynamicComboSpecV2` and `isDynamicControlType`, none of which this branch's `object-info-parser` exports; carrying them would drag in the DynamicGroup feature work that [#20289](#20289) is already carrying to this branch separately. So the nested-spec walk is done locally in `liveGraphApplier.ts`, over the two dynamic containers `cloud/1.55` *can* represent, using the branch's own schemas: | Container | Schema used | Nested inputs | | --- | --- | --- | | `COMFY_DYNAMICCOMBO_V3` | `zDynamicComboInputSpec` | `options[].inputs` | | `COMFY_AUTOGROW_V3` | `zAutogrowOptions` | `template.input` | `COMFY_MATCHTYPE_V3` is a leaf and nests nothing. `COMFY_DYNAMICGROUP_V3` is not representable on this branch at all, so there is no shape the local walk misses that a node def here could produce. A container whose options fail to parse yields nothing — the same outcome as `inputSpecTree`, which returns `[]` on a parse failure. **Deliberately not used:** this branch's existing `flattenInputSpecs` (`src/schemas/nodeDef/inputSpecUtil.ts`) covers the same dynamic-combo nesting, but it `assert`s on a malformed combo spec — which throws in DEV and reports to Sentry in prod. Calling it per widget-name resolution on the remote-apply path would add a throwing assertion and Sentry noise that `#19979` does not have. Nothing else in `#19979`'s diff is touched. ### One message-only rewrite, after the first push `cloud/1.55` still runs `ci-check-ai-co-authors.yaml`, which `main` dropped in [#19393](#19393) — so the release branch rejects metadata that `main` accepted, and the cherry-pick carried #19979's own `Co-authored-by: … <noreply@anthropic.com>` trailer into a branch that forbids it. The check failed for that reason alone and the script's own remedy is to rewrite the message and force-push. Done as a message-only rewrite, `46664f77ec` → `7a6fddba1e`, with nothing else changed: | | | | --- | --- | | Removed | exactly one line — the AI co-author trailer. `diff` of the two commit-message streams is a single deletion. | | Preserved | `Co-authored-by: Alexander Brown <drjkl@comfy.org>`, the human trailer | | Tree equality | tip tree `bb4e5f39c265e0c3cfa6cc0ca6633d0bc9e98c2f` **before and after**; cherry-pick tree `5c36c501376a8e10588f4f94af94f0a348036f8a` before and after; `git diff 46664f7 7a6fddb` is empty | | Lease | `--force-with-lease=refs/heads/backport-19979-to-cloud-1.55:46664f77ec` | | Approvals spent | **none** — the PR had 0 reviews of any kind at the time of the push | `bash .github/scripts/check-ai-co-authors.sh d163f33 7a6fddb` passes locally, and the unit suite was re-run at the new head (45 passed) rather than inherited from the old commit identity. ## Review Focus - **The resolution is the only non-mechanical part of this PR.** It is confined to `supportsDynamicWidgetOverflow` and three new module-local helpers; the rest of the backport is a byte-identical cherry-pick. - **The gate is load-bearing in both directions, proven by mutation.** Forcing it to `false` fails 14 of the 45 `liveGraphApplier.test.ts` tests; forcing it to `true` fails 2 (including `rejects an initial positional alias on a node without a dynamic combo`). So the adapted walk is pinned on both arms rather than merely compiling. - **Scope**: `#19979` only. The schema-v5 cutover ([#20096](#20096) + [cloud#11864](Comfy-Org/cloud#11864)), the other remedy named on BE-16625, is **not** in this PR. - **The gate's own scope is unchanged from `main` and is narrower than BE-16625.** A node with no `COMFY_DYNAMICCOMBO_V3` input still drops the value and still reports `agent_graph_widget_missing`. That exclusion arrived in `#19979` itself and is test-pinned there; measured against production it covers ~12% of sampled overflow events, with ~88% (kijai `inputcount` grow nodes, multi-slot component widgets, frontend-built widgets) deliberately out of scope. Whether to widen it is an open ruling on BE-16625, not part of this backport. ## Validation Run on this branch, against `origin/cloud/1.55` at `d163f330b2`. Re-confirmed at the rewritten head `7a6fddba1e`; the tree is provably unchanged by the rewrite, so the browser evidence below is content-identical. ``` pnpm typecheck # all 5 projects pass pnpm typecheck:browser # pass pnpm exec oxfmt --check # pass (4 touched files) pnpm exec oxlint --type-aware # clean eslint (touched files) # clean vitest src/workbench/extensions/agent/crdt/liveGraphApplier.test.ts → 45 passed vitest src/workbench/extensions/agent/crdt → 60 files, 851 passed, 2 expected fail ``` Both browser specs pass on this head and **fail on the parent** with base `liveGraphApplier.ts` swapped in — the same `mode.b` symptom `#19979` recorded (`71` expected, `70` received, the node-def default): ``` # head browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts 1 passed browser_tests/tests/agent/agentDynamicComboSetWidgetSilentlyDropped.spec.ts 1 passed # parent applier (d163f33:liveGraphApplier.ts), specs unchanged 2 failed Expected: "71" Received: "70" ``` ```bash COMFYUI_PORT=8197 bash scripts/start-comfyui-e2e.sh VITE_USE_LEGACY_DEFAULT_GRAPH=true DISTRIBUTION=cloud \ DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8197 pnpm dev --port 6200 --strictPort PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_SETUP_API_URL=http://localhost:8197 \ PLAYWRIGHT_TEST_URL=http://localhost:6200 DISTRIBUTION=cloud \ pnpm exec playwright test \ browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts \ browser_tests/tests/agent/agentDynamicComboSetWidgetSilentlyDropped.spec.ts \ --project=cloud --workers=1 --retries=0 ``` Linear: https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
Summary
Remove the AI commit attribution check that blocks PRs such as #18277.
Changes
Review Focus
Confirm the attribution check should no longer be required.
Failed run: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36543901331/job/109325571458?pr=18277