Repository navigation
[backport cloud/1.55] fix(agent): apply positional overflow widget values (#19979) - #20561
Conversation
## Summary Preserve `_extra_N` document widget values by resolving them to the Nth serializable live widget during Agent graph apply. ## Changes - **What**: - Resolves an `_extra_N` document key to the Nth **serializable** live widget, both on the creation path (`positionalWidgetValues`) and on later document frames (`documentWidget`). A `serialize: false` widget does not consume a position. - A named entry always beats an alias for the same position (`supersededOverflowAlias`), judged against the node's whole document map so an alias-only partial frame cannot overwrite a named value. - Document entries for widgets that only exist after `configure` are applied **after** `configure` (`mountedWidgetValues`), because a dynamic combo's setter mounts those widgets during `configure`. An earlier revision extended `widgets_values` instead, which blanked the position before the alias; `7a6912e` pins that regression out. - Document entries are ordered before application (`ordinaryWidgetEntries`): named entries first, then aliases by position, so a selector mounts its dependent widgets before the aliases that address them. Y.Map insertion order no longer decides the outcome (`f7574fa`, with a red-then-green test). - Partial frames resolve the changed-name set through the alias (`changed`), so a rejected human `set_widget` op — whose name set carries the widget's **real** name — still reverts a value the document stores under an alias. - A pending local write is re-asked under the resolved widget name, so an alias frame cannot rewind an edit the user is still making. - Coverage: 38 unit tests in `liveGraphApplier.test.ts`, plus a new cloud browser spec `agentOverflowWidgetOnNodeCreate.spec.ts` for the creation leg. The sibling `agentDynamicComboSetWidgetSilentlyDropped.spec.ts` covers the update leg. ## Review Focus - **The positional lookup stays scoped to serializable widgets.** `serializableWidgets()` is the only index source on both paths. - **Telemetry, stated precisely.** On the **update** path, both a malformed key (`_extra_01`) and an out-of-range key (`_extra_9`) report `agent_graph_widget_missing` and are not applied. On the **creation** path an out-of-range key reports; a **malformed** key is silently ignored — unchanged from base, because it never resolves to a position and so never reaches `applyWidgets`. Measured, not inferred: with `_extra_01` added to the document before the create frame, widget values stay `[11, 20, 42]` and `reportError` is not called, while the same probe on `_extra_9` catches one report. Routing every unmatched creation-path key through the post-`configure` apply is FE-3036-adjacent and deliberately out of scope here. - **Ordering is load-bearing.** `ordinaryWidgetEntries` is the only thing keeping alias application after selector setters. Linear: https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a ## Screenshots Creation leg, `agentOverflowWidgetOnNodeCreate.spec.ts` run against the cloud distribution with only `liveGraphApplier.ts` swapped between base and this head. The seed carries `widgets_values: ['faithful', 91, 71]`; the catalog names `mode` and `mode.a` only, so the host stores the tail under `_extra_2`, and `mode.b`'s node-def default is 70. `29ef774` extends the same post-`configure` apply to a document entry addressed by the widget's **real name**. `mode.a` is catalogued, so the host stores 91 under that name, but the constructor builds it no sooner than `mode.b`: it is past the array `configure` restores, so the alias and the name are the same lost-value bug. The earlier `mode.a` assertions (`toBeDefined()`, `/^(80|91)$/`) were satisfied by the node-def default of 80 and so passed while 91 was dropped; both now pin 91. | Rendered node | `mode.a` | `mode.b` | | --- | --- | --- | | Base `a24212f` — **before** | 80 | **70** — the node-def default; the document's 71 is lost | | `7a6912e` | 80 | **71** — the aliased document value reaches the widget | | Head `29ef774` — **after** | **91** — the named document value reaches the widget too | **71** | The spec is therefore red on the parent and green on the fix: ``` # before: base liveGraphApplier.ts Error: expect(locator).toHaveValue(expected) failed Expected: "71" Received: "70" 1 failed # after: this head 1 passed ``` ```bash COMFYUI_PORT=8197 bash scripts/start-comfyui-e2e.sh VITE_USE_LEGACY_DEFAULT_GRAPH=true DISTRIBUTION=cloud \ DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8197 pnpm dev --port 6241 --strictPort PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_SETUP_API_URL=http://localhost:8197 \ PLAYWRIGHT_TEST_URL=http://localhost:6241 DISTRIBUTION=cloud \ pnpm exec playwright test \ browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts \ --project=cloud --workers=1 --retries=0 ``` CI also records a walkthrough of **both** agent specs at this head — `playwright-video-new-tests` on run [37127894596](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/37127894596) uploads `test-results-cloud/tests-agent-agentOverflowW-689c7-he-position-before-it-alone-cloud/video.webm` alongside the update-leg recording. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit 99c46fe)
…1.55 `cursor-review` #19979 reads the node's nested input specs through `@/schemas/nodeDef/inputSpecTree`, which does not exist on this release branch: that module needs `zDynamicGroupInputSpec`, `zDynamicComboOption`, `zDynamicComboSpecV2` and `isDynamicControlType`, none of which `object-info-parser` exports here, and carrying them would pull the DynamicGroup feature work that #20289 already carries separately. Walk the two dynamic containers cloud/1.55 can represent instead (`COMFY_DYNAMICCOMBO_V3` options and `COMFY_AUTOGROW_V3` templates), using the branch's own `zDynamicComboInputSpec` and `zAutogrowOptions`. The gate answers the same question for every node-def shape reachable here; a container whose options fail to parse yields nothing, matching `inputSpecTree`. Nothing else in #19979's diff is changed.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2154 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d163f330b27478454ce5363e0351e794123c3526
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-08T15:20:17.479Z",
"gitSha": "c8c9f33333f84daba923bfb9697d1f323ddd808d",
"branch": "backport-19979-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.0439999999976,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.617999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.199,
"heapDeltaBytes": -9931000,
"heapUsedBytes": 59316824,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.437000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1996.9330000000127,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 237.89200000000002,
"heapDeltaBytes": -29480,
"heapUsedBytes": 68701204,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 4.608999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1673.228999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.925,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.47299999999996,
"heapDeltaBytes": -8195856,
"heapUsedBytes": 60705260,
"domNodes": -254,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 86.97200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1671.305000000018,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.922,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.6239999999999,
"heapDeltaBytes": -8993876,
"heapUsedBytes": 59619228,
"domNodes": -256,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 89.87200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.48399999996,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.099000000000002,
"layouts": 6,
"layoutDurationMs": 0.877,
"taskDurationMs": 183.57399999999998,
"heapDeltaBytes": 3069528,
"heapUsedBytes": 71359300,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.099000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.350000000014,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.584999999999999,
"layouts": 6,
"layoutDurationMs": 0.843,
"taskDurationMs": 179.487,
"heapDeltaBytes": 3322908,
"heapUsedBytes": 72397184,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.484000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 409.72599999997783,
"styleRecalcs": 16,
"styleRecalcDurationMs": 7.507,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.533,
"heapDeltaBytes": -7951340,
"heapUsedBytes": 61291032,
"domNodes": 24,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 100.497,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 394.04799999999796,
"styleRecalcs": 17,
"styleRecalcDurationMs": 7.693,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.04,
"heapDeltaBytes": 17916436,
"heapUsedBytes": 86791968,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 99.50200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 876.0159999999928,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.28800000000007,
"heapDeltaBytes": -14899920,
"heapUsedBytes": 73386844,
"domNodes": -291,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 30.710999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 270,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 892.8070000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.06399999999996,
"heapDeltaBytes": -17898784,
"heapUsedBytes": 73309188,
"domNodes": -290,
"jsHeapTotalBytes": 19005440,
"scriptDurationMs": 33.949,
"eventListeners": -217,
"totalBlockingTimeMs": 270,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.162000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 240.12900000000005,
"heapDeltaBytes": 15422840,
"heapUsedBytes": 92338592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 81.07000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 79,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.0839999999507,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 238.1120000000001,
"heapDeltaBytes": 14547140,
"heapUsedBytes": 90447984,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.178,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5089.741000000004,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.4220000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4337.104,
"heapDeltaBytes": 19830244,
"heapUsedBytes": 98551128,
"domNodes": -252,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 3499.46,
"eventListeners": -152,
"totalBlockingTimeMs": 20,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5402.3569999999945,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.416,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4523.7029999999995,
"heapDeltaBytes": -8886612,
"heapUsedBytes": 70334680,
"domNodes": -265,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 3606.699,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5593.401000000029,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5809999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4548.438000000001,
"heapDeltaBytes": 4795528,
"heapUsedBytes": 86564084,
"domNodes": -18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 3616.066,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5558.110999999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.5239999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4620.067,
"heapDeltaBytes": 5151616,
"heapUsedBytes": 69569728,
"domNodes": -266,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3707.1589999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2002.588000000003,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.902999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.38800000000003,
"heapDeltaBytes": 2814972,
"heapUsedBytes": 85479064,
"domNodes": -250,
"jsHeapTotalBytes": 2650112,
"scriptDurationMs": 18.041999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1993.4690000000046,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.8020000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.179,
"heapDeltaBytes": 2793724,
"heapUsedBytes": 85453468,
"domNodes": -254,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 16.229,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2082.3090000000093,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 939.84,
"heapDeltaBytes": -832380,
"heapUsedBytes": 89035812,
"domNodes": -239,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 501.61599999999993,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2099.9360000000706,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.862999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 965.451,
"heapDeltaBytes": -1604368,
"heapUsedBytes": 88588696,
"domNodes": -245,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 513.823,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3078.26399999999,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.701999999999998,
"layouts": 60,
"layoutDurationMs": 13.04,
"taskDurationMs": 1013.7080000000001,
"heapDeltaBytes": 2665700,
"heapUsedBytes": 93905796,
"domNodes": 44,
"jsHeapTotalBytes": 6066176,
"scriptDurationMs": 486.17,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3071.8520000000353,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.972,
"layouts": 60,
"layoutDurationMs": 13.015,
"taskDurationMs": 989.735,
"heapDeltaBytes": 2949580,
"heapUsedBytes": 94440152,
"domNodes": 44,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 470.45899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2106.3010000000304,
"styleRecalcs": 51,
"styleRecalcDurationMs": 9.469000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1094.554,
"heapDeltaBytes": -17616764,
"heapUsedBytes": 75102348,
"domNodes": 18,
"jsHeapTotalBytes": 6852608,
"scriptDurationMs": 585.365,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2119.878000000085,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.828,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1091.683,
"heapDeltaBytes": 12579780,
"heapUsedBytes": 99307268,
"domNodes": 16,
"jsHeapTotalBytes": 5959680,
"scriptDurationMs": 580.8480000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1998.7100000000169,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.442,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.82,
"heapDeltaBytes": 10251996,
"heapUsedBytes": 74567740,
"domNodes": -233,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.134000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.846000000015,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 305.836,
"heapDeltaBytes": -22705036,
"heapUsedBytes": 68175948,
"domNodes": -239,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 18.235999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 378.2749999999737,
"styleRecalcs": 50,
"styleRecalcDurationMs": 10.202000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 241.53699999999998,
"heapDeltaBytes": 13256956,
"heapUsedBytes": 77522136,
"domNodes": 25,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 89.598,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 365.27300000000196,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 238.35600000000002,
"heapDeltaBytes": 13651044,
"heapUsedBytes": 84311668,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 88.285,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1994.3480000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.316000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 257.328,
"heapDeltaBytes": -8758640,
"heapUsedBytes": 62375496,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4.818,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.0109999999577,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.0630000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 252.286,
"heapDeltaBytes": -12869772,
"heapUsedBytes": 57801404,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4.748,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1661.5259999999807,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.487,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.164,
"heapDeltaBytes": -9734372,
"heapUsedBytes": 61537632,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 66.706,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1662.3679999999013,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.001999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.94200000000006,
"heapDeltaBytes": -9525580,
"heapUsedBytes": 61540172,
"domNodes": -273,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 65.252,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 750.2920000000017,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.390000000000004,
"layouts": 5,
"layoutDurationMs": 7.268,
"taskDurationMs": 509.47200000000004,
"heapDeltaBytes": 20104620,
"heapUsedBytes": 103622972,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 17.04,
"eventListeners": 2383,
"totalBlockingTimeMs": 55,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8120.631000000003,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.980000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3228.4429999999998,
"heapDeltaBytes": -7040748,
"heapUsedBytes": 81938396,
"domNodes": -241,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 1711.012,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8408.029000000057,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3568.865,
"heapDeltaBytes": -537828,
"heapUsedBytes": 88821140,
"domNodes": -234,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 1883.5380000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10030.957999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8934.5,
"heapDeltaBytes": -55191180,
"heapUsedBytes": 186056520,
"domNodes": -8062,
"jsHeapTotalBytes": -20041728,
"scriptDurationMs": 122.57100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666607,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 9982.482000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8900.012,
"heapDeltaBytes": -34932616,
"heapUsedBytes": 186053400,
"domNodes": -8062,
"jsHeapTotalBytes": -10731520,
"scriptDurationMs": 115.41900000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13059.590000000015,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.41700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12701.726,
"heapDeltaBytes": -27796136,
"heapUsedBytes": 188102592,
"domNodes": -8062,
"jsHeapTotalBytes": -23195648,
"scriptDurationMs": 547.8629999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 61,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13162.982000000056,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.07899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12797.938,
"heapDeltaBytes": -24715764,
"heapUsedBytes": 194882512,
"domNodes": -8062,
"jsHeapTotalBytes": -17711104,
"scriptDurationMs": 572.4889999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3808.9110000000233,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.483,
"layouts": 20,
"layoutDurationMs": 17.676000000000005,
"taskDurationMs": 3685.355,
"heapDeltaBytes": -55918312,
"heapUsedBytes": 186493000,
"domNodes": -8062,
"jsHeapTotalBytes": 16314368,
"scriptDurationMs": 56.77,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3747.4899999999707,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.870999999999995,
"layouts": 20,
"layoutDurationMs": 17.079000000000004,
"taskDurationMs": 3618.6,
"heapDeltaBytes": -32170756,
"heapUsedBytes": 187910356,
"domNodes": -8062,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 55.826,
"eventListeners": -14928,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5313.265000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4867.4400000000005,
"heapDeltaBytes": -14521772,
"heapUsedBytes": 186120952,
"domNodes": 0,
"jsHeapTotalBytes": -33554432,
"scriptDurationMs": 61.850000000000016,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5153.394999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4552.1500000000015,
"heapDeltaBytes": -20364792,
"heapUsedBytes": 169759880,
"domNodes": 0,
"jsHeapTotalBytes": -34603008,
"scriptDurationMs": 59.388,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 438.5469999999714,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.857,
"layouts": 7,
"layoutDurationMs": 2.26,
"taskDurationMs": 102.338,
"heapDeltaBytes": 5467836,
"heapUsedBytes": 67956852,
"domNodes": 154,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.857,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 411.1410000000433,
"styleRecalcs": 16,
"styleRecalcDurationMs": 14.953000000000001,
"layouts": 3,
"layoutDurationMs": 0.7950000000000002,
"taskDurationMs": 75.75299999999999,
"heapDeltaBytes": 4888568,
"heapUsedBytes": 67417852,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.764999999999995,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
46664f7 to
7a6fddb
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #20561 +/- ##
=============================================
Coverage ? 85.08%
=============================================
Files ? 2357
Lines ? 135239
Branches ? 34361
=============================================
Hits ? 115067
Misses ? 19807
Partials ? 365
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: gpt-5.6-sol-max:adversarial (error)
|
@ryan-di final release-owner escalation after two silent ownership windows: the current head is mergeable and |
|
All ten findings in the Cursor review above describe code that is already on This branch has two commits. The first is the cherry-pick of #19979, and it introduces exactly the change The findings that look like real defects after reading the code are now filed as #20587 against @ryan-di the part of this PR worth your review is the second commit rather than the review findings. It replaces the One difference I did find, which the review did not raise: |
|
Reassigning review: ryan-di has not engaged across two prior windows (see comments above) and the |
christian-byrne
left a comment
There was a problem hiding this comment.
Operator review under the Agent 1.54/1.55 backport grant (program/release-backport-authority.md, Christian 2026-09-16, extended 2026-09-27 to cover core/1.55 and cloud/1.55). Author is also the PR author, so this is an honest COMMENT rather than an approval record.
Evidence:
- Diff reviewed: cherry-pick of #19979 (verified byte-identical against main's squashed 99c46fe for the three browser_tests files and both source files) plus a second commit substituting the cloud/1.55-local dynamic-container walk for the inputSpecTree import this branch lacks.
- All 10 cursor-review findings resolved as threads: 9 sit on main-already-shipped lines (now tracked at #20587, filed against main, not a reason to hold this backport) and the 10th (no depth limit on the input-spec walk) matches main's existing behavior — fixing only here would diverge the branch from main without reducing release risk.
- One known gap not raised by the review, disclosed by the author: a dynamic combo nested inside an option whose sibling is malformed does not get the overflow-gate fix here (differs from main's per-option parsing), left as-is per the author's judgment to avoid widening this backport.
- check-merge-ready.sh --target-branch cloud/1.55: MERGE READY — base is ancestor of head, 104 checks success/neutral/skipped, no unresolved threads, no later reviewer objections.
Proceeding to admin-merge under the grant.
Summary
Backports #19979 (
fix(agent): apply positional overflow widget values, merged tomainas99c46fe15f974be23379dee6ed456836061db8b7) ontocloud/1.55, so_extra_Ndocument widget values resolve to the Nth serializable live widget during Agent graph apply instead of being dropped.cloud/1.55currently carries no positional-overflow resolution at all —OVERFLOW_WIDGET_NAME_REhas 0 occurrences inliveGraphApplier.tson the base — while the detector this fix exists for (agent_graph_widget_missing, Linear BE-16625) is firing in production on1.55.16/1.55.17/1.55.18.#19979is not an ancestor oforigin/cloud/1.55(git merge-base --is-ancestor→ exit 1) and no backport existed.Changes
be980c441e—git cherry-pick -x 99c46fe15f, applied clean. The added/removed lines are byte-identical to the upstream commit (1,409+/-lines diffed equal; only hunk offsets and blob indexes differ).7a6fddba1e— the one release-branch resolution needed to make it compile, described below.cloud/1.55already ships.The one resolution, stated plainly
#19979's gate reads the node's nested input specs through@/schemas/nodeDef/inputSpecTree, which does not exist oncloud/1.55. That module needszDynamicGroupInputSpec,zDynamicComboOption,zDynamicComboSpecV2andisDynamicControlType, none of which this branch'sobject-info-parserexports; carrying them would drag in the DynamicGroup feature work that #20289 is already carrying to this branch separately.So the nested-spec walk is done locally in
liveGraphApplier.ts, over the two dynamic containerscloud/1.55can represent, using the branch's own schemas:COMFY_DYNAMICCOMBO_V3zDynamicComboInputSpecoptions[].inputsCOMFY_AUTOGROW_V3zAutogrowOptionstemplate.inputCOMFY_MATCHTYPE_V3is a leaf and nests nothing.COMFY_DYNAMICGROUP_V3is not representable on this branch at all, so there is no shape the local walk misses that a node def here could produce. A container whose options fail to parse yields nothing — the same outcome asinputSpecTree, which returns[]on a parse failure.Deliberately not used: this branch's existing
flattenInputSpecs(src/schemas/nodeDef/inputSpecUtil.ts) covers the same dynamic-combo nesting, but itasserts on a malformed combo spec — which throws in DEV and reports to Sentry in prod. Calling it per widget-name resolution on the remote-apply path would add a throwing assertion and Sentry noise that#19979does not have. Nothing else in#19979's diff is touched.One message-only rewrite, after the first push
cloud/1.55still runsci-check-ai-co-authors.yaml, whichmaindropped in #19393 — so the release branch rejects metadata thatmainaccepted, and the cherry-pick carried #19979's ownCo-authored-by: … <noreply@anthropic.com>trailer into a branch that forbids it. The check failed for that reason alone and the script's own remedy is to rewrite the message and force-push.Done as a message-only rewrite,
46664f77ec→7a6fddba1e, with nothing else changed:diffof the two commit-message streams is a single deletion.Co-authored-by: Alexander Brown <drjkl@comfy.org>, the human trailerbb4e5f39c265e0c3cfa6cc0ca6633d0bc9e98c2fbefore and after; cherry-pick tree5c36c501376a8e10588f4f94af94f0a348036f8abefore and after;git diff 46664f77ec 7a6fddba1eis empty--force-with-lease=refs/heads/backport-19979-to-cloud-1.55:46664f77ecbash .github/scripts/check-ai-co-authors.sh d163f330b2 7a6fddba1epasses locally, and the unit suite was re-run at the new head (45 passed) rather than inherited from the old commit identity.Review Focus
supportsDynamicWidgetOverflowand three new module-local helpers; the rest of the backport is a byte-identical cherry-pick.falsefails 14 of the 45liveGraphApplier.test.tstests; forcing it totruefails 2 (includingrejects an initial positional alias on a node without a dynamic combo). So the adapted walk is pinned on both arms rather than merely compiling.#19979only. The schema-v5 cutover (#20096 + cloud#11864), the other remedy named on BE-16625, is not in this PR.mainand is narrower than BE-16625. A node with noCOMFY_DYNAMICCOMBO_V3input still drops the value and still reportsagent_graph_widget_missing. That exclusion arrived in#19979itself and is test-pinned there; measured against production it covers ~12% of sampled overflow events, with ~88% (kijaiinputcountgrow nodes, multi-slot component widgets, frontend-built widgets) deliberately out of scope. Whether to widen it is an open ruling on BE-16625, not part of this backport.Validation
Run on this branch, against
origin/cloud/1.55atd163f330b2. Re-confirmed at the rewritten head7a6fddba1e; the tree is provably unchanged by the rewrite, so the browser evidence below is content-identical.Both browser specs pass on this head and fail on the parent with base
liveGraphApplier.tsswapped in — the samemode.bsymptom#19979recorded (71expected,70received, the node-def default):Linear: https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a