Skip to content

[backport cloud/1.55] fix(agent): apply positional overflow widget values (#19979) - #20561

Merged
christian-byrne merged 2 commits into
cloud/1.55from
backport-19979-to-cloud-1.55
Oct 9, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.55from
backport-19979-to-cloud-1.55

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Backports #19979 (fix(agent): apply positional overflow widget values, merged to main as 99c46fe15f974be23379dee6ed456836061db8b7) onto cloud/1.55, so _extra_N document widget values resolve to the Nth serializable live widget during Agent graph apply instead of being dropped.

cloud/1.55 currently carries no positional-overflow resolution at all — OVERFLOW_WIDGET_NAME_RE has 0 occurrences in liveGraphApplier.ts on the base — while the detector this fix exists for (agent_graph_widget_missing, Linear BE-16625) is firing in production on 1.55.16/1.55.17/1.55.18. #19979 is not an ancestor of origin/cloud/1.55 (git merge-base --is-ancestor → exit 1) and no backport existed.

Changes

  • What: two commits.
    1. be980c441e — git cherry-pick -x 99c46fe15f, applied clean. The added/removed lines are byte-identical to the upstream commit (1,409 +/- lines diffed equal; only hunk offsets and blob indexes differ).
    2. 7a6fddba1e — the one release-branch resolution needed to make it compile, described below.
  • Breaking: none.
  • Dependencies: none added. Imports only modules cloud/1.55 already ships.

The one resolution, stated plainly

#19979's gate reads the node's nested input specs through @/schemas/nodeDef/inputSpecTree, which does not exist on cloud/1.55. That module needs zDynamicGroupInputSpec, zDynamicComboOption, zDynamicComboSpecV2 and isDynamicControlType, none of which this branch's object-info-parser exports; carrying them would drag in the DynamicGroup feature work that #20289 is already carrying to this branch separately.

So the nested-spec walk is done locally in liveGraphApplier.ts, over the two dynamic containers cloud/1.55 can represent, using the branch's own schemas:

Container Schema used Nested inputs
COMFY_DYNAMICCOMBO_V3 zDynamicComboInputSpec options[].inputs
COMFY_AUTOGROW_V3 zAutogrowOptions template.input

COMFY_MATCHTYPE_V3 is a leaf and nests nothing. COMFY_DYNAMICGROUP_V3 is not representable on this branch at all, so there is no shape the local walk misses that a node def here could produce. A container whose options fail to parse yields nothing — the same outcome as inputSpecTree, which returns [] on a parse failure.

Deliberately not used: this branch's existing flattenInputSpecs (src/schemas/nodeDef/inputSpecUtil.ts) covers the same dynamic-combo nesting, but it asserts on a malformed combo spec — which throws in DEV and reports to Sentry in prod. Calling it per widget-name resolution on the remote-apply path would add a throwing assertion and Sentry noise that #19979 does not have. Nothing else in #19979's diff is touched.

One message-only rewrite, after the first push

cloud/1.55 still runs ci-check-ai-co-authors.yaml, which main dropped in #19393 — so the release branch rejects metadata that main accepted, and the cherry-pick carried #19979's own Co-authored-by: … <noreply@anthropic.com> trailer into a branch that forbids it. The check failed for that reason alone and the script's own remedy is to rewrite the message and force-push.

Done as a message-only rewrite, 46664f77ec → 7a6fddba1e, with nothing else changed:

Removed exactly one line — the AI co-author trailer. diff of the two commit-message streams is a single deletion.
Preserved Co-authored-by: Alexander Brown <drjkl@comfy.org>, the human trailer
Tree equality tip tree bb4e5f39c265e0c3cfa6cc0ca6633d0bc9e98c2f before and after; cherry-pick tree 5c36c501376a8e10588f4f94af94f0a348036f8a before and after; git diff 46664f77ec 7a6fddba1e is empty
Lease --force-with-lease=refs/heads/backport-19979-to-cloud-1.55:46664f77ec
Approvals spent none — the PR had 0 reviews of any kind at the time of the push

bash .github/scripts/check-ai-co-authors.sh d163f330b2 7a6fddba1e passes locally, and the unit suite was re-run at the new head (45 passed) rather than inherited from the old commit identity.

Review Focus

  • The resolution is the only non-mechanical part of this PR. It is confined to supportsDynamicWidgetOverflow and three new module-local helpers; the rest of the backport is a byte-identical cherry-pick.
  • The gate is load-bearing in both directions, proven by mutation. Forcing it to false fails 14 of the 45 liveGraphApplier.test.ts tests; forcing it to true fails 2 (including rejects an initial positional alias on a node without a dynamic combo). So the adapted walk is pinned on both arms rather than merely compiling.
  • Scope: #19979 only. The schema-v5 cutover (#20096 + cloud#11864), the other remedy named on BE-16625, is not in this PR.
  • The gate's own scope is unchanged from main and is narrower than BE-16625. A node with no COMFY_DYNAMICCOMBO_V3 input still drops the value and still reports agent_graph_widget_missing. That exclusion arrived in #19979 itself and is test-pinned there; measured against production it covers ~12% of sampled overflow events, with ~88% (kijai inputcount grow nodes, multi-slot component widgets, frontend-built widgets) deliberately out of scope. Whether to widen it is an open ruling on BE-16625, not part of this backport.

Validation

Run on this branch, against origin/cloud/1.55 at d163f330b2. Re-confirmed at the rewritten head 7a6fddba1e; the tree is provably unchanged by the rewrite, so the browser evidence below is content-identical.

pnpm typecheck                 # all 5 projects pass
pnpm typecheck:browser         # pass
pnpm exec oxfmt --check        # pass (4 touched files)
pnpm exec oxlint --type-aware  # clean
eslint (touched files)         # clean

vitest src/workbench/extensions/agent/crdt/liveGraphApplier.test.ts
  → 45 passed

vitest src/workbench/extensions/agent/crdt
  → 60 files, 851 passed, 2 expected fail

Both browser specs pass on this head and fail on the parent with base liveGraphApplier.ts swapped in — the same mode.b symptom #19979 recorded (71 expected, 70 received, the node-def default):

# head
browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts            1 passed
browser_tests/tests/agent/agentDynamicComboSetWidgetSilentlyDropped.spec.ts  1 passed

# parent applier (d163f330b2:liveGraphApplier.ts), specs unchanged
2 failed
  Expected: "71"
  Received: "70"
COMFYUI_PORT=8197 bash scripts/start-comfyui-e2e.sh
VITE_USE_LEGACY_DEFAULT_GRAPH=true DISTRIBUTION=cloud \
  DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8197 pnpm dev --port 6200 --strictPort
PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_SETUP_API_URL=http://localhost:8197 \
  PLAYWRIGHT_TEST_URL=http://localhost:6200 DISTRIBUTION=cloud \
  pnpm exec playwright test \
    browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts \
    browser_tests/tests/agent/agentDynamicComboSetWidgetSilentlyDropped.spec.ts \
    --project=cloud --workers=1 --retries=0

Linear: https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a

christian-byrne and others added 2 commits October 8, 2026 07:42
## Summary

Preserve `_extra_N` document widget values by resolving them to the Nth
serializable live widget during Agent graph apply.

## Changes

- **What**:
- Resolves an `_extra_N` document key to the Nth **serializable** live
widget, both on the creation path (`positionalWidgetValues`) and on
later document frames (`documentWidget`). A `serialize: false` widget
does not consume a position.
- A named entry always beats an alias for the same position
(`supersededOverflowAlias`), judged against the node's whole document
map so an alias-only partial frame cannot overwrite a named value.
- Document entries for widgets that only exist after `configure` are
applied **after** `configure` (`mountedWidgetValues`), because a dynamic
combo's setter mounts those widgets during `configure`. An earlier
revision extended `widgets_values` instead, which blanked the position
before the alias; `7a6912e` pins that regression out.
- Document entries are ordered before application
(`ordinaryWidgetEntries`): named entries first, then aliases by
position, so a selector mounts its dependent widgets before the aliases
that address them. Y.Map insertion order no longer decides the outcome
(`f7574fa`, with a red-then-green test).
- Partial frames resolve the changed-name set through the alias
(`changed`), so a rejected human `set_widget` op — whose name set
carries the widget's **real** name — still reverts a value the document
stores under an alias.
- A pending local write is re-asked under the resolved widget name, so
an alias frame cannot rewind an edit the user is still making.
- Coverage: 38 unit tests in `liveGraphApplier.test.ts`, plus a new
cloud browser spec `agentOverflowWidgetOnNodeCreate.spec.ts` for the
creation leg. The sibling
`agentDynamicComboSetWidgetSilentlyDropped.spec.ts` covers the update
leg.

## Review Focus

- **The positional lookup stays scoped to serializable widgets.**
`serializableWidgets()` is the only index source on both paths.
- **Telemetry, stated precisely.** On the **update** path, both a
malformed key (`_extra_01`) and an out-of-range key (`_extra_9`) report
`agent_graph_widget_missing` and are not applied. On the **creation**
path an out-of-range key reports; a **malformed** key is silently
ignored — unchanged from base, because it never resolves to a position
and so never reaches `applyWidgets`. Measured, not inferred: with
`_extra_01` added to the document before the create frame, widget values
stay `[11, 20, 42]` and `reportError` is not called, while the same
probe on `_extra_9` catches one report. Routing every unmatched
creation-path key through the post-`configure` apply is FE-3036-adjacent
and deliberately out of scope here.
- **Ordering is load-bearing.** `ordinaryWidgetEntries` is the only
thing keeping alias application after selector setters.

Linear:
https://linear.app/comfyorg/issue/BE-16625/widget-catalog-arity-mismatch-extra-n-positional-overflow-is-a

## Screenshots

Creation leg, `agentOverflowWidgetOnNodeCreate.spec.ts` run against the
cloud distribution with only `liveGraphApplier.ts` swapped between base
and this head. The seed carries `widgets_values: ['faithful', 91, 71]`;
the catalog names `mode` and `mode.a` only, so the host stores the tail
under `_extra_2`, and `mode.b`'s node-def default is 70.

`29ef774` extends the same post-`configure` apply to a document entry
addressed by the widget's
**real name**. `mode.a` is catalogued, so the host stores 91 under that
name, but the constructor
builds it no sooner than `mode.b`: it is past the array `configure`
restores, so the alias and the
name are the same lost-value bug. The earlier `mode.a` assertions
(`toBeDefined()`, `/^(80|91)$/`)
were satisfied by the node-def default of 80 and so passed while 91 was
dropped; both now pin 91.

| Rendered node | `mode.a` | `mode.b` |
| --- | --- | --- |
| Base `a24212f` — **before** | 80 | **70** — the node-def default; the
document's 71 is lost |
| `7a6912e` | 80 | **71** — the aliased document value reaches the
widget |
| Head `29ef774` — **after** | **91** — the named document value reaches
the widget too | **71** |

The spec is therefore red on the parent and green on the fix:

```
# before: base liveGraphApplier.ts
Error: expect(locator).toHaveValue(expected) failed
  Expected: "71"
  Received: "70"
1 failed

# after: this head
1 passed
```

```bash
COMFYUI_PORT=8197 bash scripts/start-comfyui-e2e.sh
VITE_USE_LEGACY_DEFAULT_GRAPH=true DISTRIBUTION=cloud \
  DEV_SERVER_COMFYUI_URL=http://127.0.0.1:8197 pnpm dev --port 6241 --strictPort
PLAYWRIGHT_LOCAL=1 PLAYWRIGHT_SETUP_API_URL=http://localhost:8197 \
  PLAYWRIGHT_TEST_URL=http://localhost:6241 DISTRIBUTION=cloud \
  pnpm exec playwright test \
    browser_tests/tests/agent/agentOverflowWidgetOnNodeCreate.spec.ts \
    --project=cloud --workers=1 --retries=0
```

CI also records a walkthrough of **both** agent specs at this head —
`playwright-video-new-tests` on run
[37127894596](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/37127894596)
uploads
`test-results-cloud/tests-agent-agentOverflowW-689c7-he-position-before-it-alone-cloud/video.webm`
alongside the update-leg recording.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
(cherry picked from commit 99c46fe)
…1.55

`cursor-review`

#19979 reads the node's nested input specs through
`@/schemas/nodeDef/inputSpecTree`, which does not exist on this release
branch: that module needs `zDynamicGroupInputSpec`, `zDynamicComboOption`,
`zDynamicComboSpecV2` and `isDynamicControlType`, none of which
`object-info-parser` exports here, and carrying them would pull the
DynamicGroup feature work that #20289 already carries separately.

Walk the two dynamic containers cloud/1.55 can represent instead
(`COMFY_DYNAMICCOMBO_V3` options and `COMFY_AUTOGROW_V3` templates), using
the branch's own `zDynamicComboInputSpec` and `zAutogrowOptions`. The gate
answers the same question for every node-def shape reachable here; a
container whose options fail to parse yields nothing, matching
`inputSpecTree`. Nothing else in #19979's diff is changed.
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR labels Oct 8, 2026
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: ee2afc00-33e3-4b89-8569-d2c4e43a9ef9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2154 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2133 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/08/2026, 03:04:44 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since d163f330b27478454ce5363e0351e794123c3526

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 270ms TBT · 70.0 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 79ms TBT · 87.2 MB heap
extension-clean-combined-draw: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 10ms TBT · 80.5 MB heap
extension-rgthree-prototype-draw: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 2ms TBT · 74.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 89.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 55ms TBT · 98.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.4 MB heap
vue-large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 177.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 38ms TBT · 182.6 MB heap
vue-node-resize-workload: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 4ms TBT · 178.5 MB heap
vue-zoom-out-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 258ms
canvas-idle: script duration 5ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.0 MB
canvas-idle: DOM nodes -119
canvas-idle: event listeners -87
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 12ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 48
canvas-mouse-sweep: task duration 464ms
canvas-mouse-sweep: script duration 88ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.4 MB
canvas-mouse-sweep: DOM nodes -255
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 10ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 29
canvas-zoom-sweep: task duration 182ms
canvas-zoom-sweep: script duration 7ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 68.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 17
dom-widget-clipping: task duration 274ms
dom-widget-clipping: script duration 100ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.6 MB
dom-widget-clipping: DOM nodes 24
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 507ms
dom-widget-order-dense-n200-w200-i120: script duration 32ms
dom-widget-order-dense-n200-w200-i120: TBT 270ms
dom-widget-order-dense-n200-w200-i120: heap used 70.0 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -291
dom-widget-order-dense-n200-w200-i120: event listeners -217
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 239ms
dom-widget-order-sparse-n1000-w20-i120: script duration 82ms
dom-widget-order-sparse-n1000-w20-i120: TBT 79ms
dom-widget-order-sparse-n1000-w20-i120: heap used 87.2 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 17ms
extension-clean-combined-draw: p95 frame time 17ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 2ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 5
extension-clean-combined-draw: task duration 4430ms
extension-clean-combined-draw: script duration 3553ms
extension-clean-combined-draw: TBT 10ms
extension-clean-combined-draw: heap used 80.5 MB
extension-clean-combined-draw: DOM nodes -259
extension-clean-combined-draw: event listeners -163
extension-rgthree-prototype-draw: avg frame time 17ms
extension-rgthree-prototype-draw: p95 frame time 17ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 2ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 3
extension-rgthree-prototype-draw: task duration 4584ms
extension-rgthree-prototype-draw: script duration 3662ms
extension-rgthree-prototype-draw: TBT 2ms
extension-rgthree-prototype-draw: heap used 74.5 MB
extension-rgthree-prototype-draw: DOM nodes -142
extension-rgthree-prototype-draw: event listeners -87
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 303ms
large-graph-idle: script duration 17ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.5 MB
large-graph-idle: DOM nodes -252
large-graph-idle: event listeners -174
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 953ms
large-graph-pan: script duration 508ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.7 MB
large-graph-pan: DOM nodes -242
large-graph-pan: event listeners -174
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 74
large-graph-zoom: task duration 1002ms
large-graph-zoom: script duration 478ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 89.8 MB
large-graph-zoom: DOM nodes 44
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 50
legacy-node-drag: task duration 1093ms
legacy-node-drag: script duration 583ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.2 MB
legacy-node-drag: DOM nodes 17
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 11
minimap-idle: task duration 280ms
minimap-idle: script duration 17ms
minimap-idle: TBT 0ms
minimap-idle: heap used 68.1 MB
minimap-idle: DOM nodes -236
minimap-idle: event listeners -87
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 50
subgraph-dom-widget-clipping: task duration 240ms
subgraph-dom-widget-clipping: script duration 89ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 77.2 MB
subgraph-dom-widget-clipping: DOM nodes 24
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 5ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 255ms
subgraph-idle: script duration 5ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.3 MB
subgraph-idle: DOM nodes -272
subgraph-idle: event listeners -220
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 11ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 47
subgraph-mouse-sweep: task duration 431ms
subgraph-mouse-sweep: script duration 66ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.7 MB
subgraph-mouse-sweep: DOM nodes -273
subgraph-mouse-sweep: event listeners -220
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 7ms
subgraph-transition-enter: style recalc duration 17ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 509ms
subgraph-transition-enter: script duration 17ms
subgraph-transition-enter: TBT 55ms
subgraph-transition-enter: heap used 98.8 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3399ms
viewport-pan-sweep: script duration 1797ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.4 MB
viewport-pan-sweep: DOM nodes -238
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 8917ms
vue-large-graph-idle: script duration 119ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 177.4 MB
vue-large-graph-idle: DOM nodes -8062
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 66
vue-large-graph-pan: task duration 12750ms
vue-large-graph-pan: script duration 560ms
vue-large-graph-pan: TBT 38ms
vue-large-graph-pan: heap used 182.6 MB
vue-large-graph-pan: DOM nodes -8062
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 17ms
vue-node-resize-workload: style recalc duration 49ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 3652ms
vue-node-resize-workload: script duration 56ms
vue-node-resize-workload: TBT 4ms
vue-node-resize-workload: heap used 178.5 MB
vue-node-resize-workload: DOM nodes -8062
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 4710ms
vue-zoom-out-idle: script duration 61ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 5
workflow-execution: style recalc count 19
workflow-execution: task duration 89ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.6 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-10-08T15:20:17.479Z",
  "gitSha": "c8c9f33333f84daba923bfb9697d1f323ddd808d",
  "branch": "backport-19979-to-cloud-1.55",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 1993.0439999999976,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.617999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 278.199,
      "heapDeltaBytes": -9931000,
      "heapUsedBytes": 59316824,
      "domNodes": -257,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 5.437000000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1996.9330000000127,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.881,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 237.89200000000002,
      "heapDeltaBytes": -29480,
      "heapUsedBytes": 68701204,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 4.608999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1673.228999999992,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.925,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.47299999999996,
      "heapDeltaBytes": -8195856,
      "heapUsedBytes": 60705260,
      "domNodes": -254,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 86.97200000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1671.305000000018,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.922,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.6239999999999,
      "heapDeltaBytes": -8993876,
      "heapUsedBytes": 59619228,
      "domNodes": -256,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 89.87200000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1688.48399999996,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 10.099000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.877,
      "taskDurationMs": 183.57399999999998,
      "heapDeltaBytes": 3069528,
      "heapUsedBytes": 71359300,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7.099000000000001,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1688.350000000014,
      "styleRecalcs": 28,
      "styleRecalcDurationMs": 9.584999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.843,
      "taskDurationMs": 179.487,
      "heapDeltaBytes": 3322908,
      "heapUsedBytes": 72397184,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 6.484000000000002,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 409.72599999997783,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 7.507,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 277.533,
      "heapDeltaBytes": -7951340,
      "heapUsedBytes": 61291032,
      "domNodes": 24,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 100.497,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 394.04799999999796,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 7.693,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 270.04,
      "heapDeltaBytes": 17916436,
      "heapUsedBytes": 86791968,
      "domNodes": 24,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 99.50200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 876.0159999999928,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 502.28800000000007,
      "heapDeltaBytes": -14899920,
      "heapUsedBytes": 73386844,
      "domNodes": -291,
      "jsHeapTotalBytes": 20840448,
      "scriptDurationMs": 30.710999999999995,
      "eventListeners": -217,
      "totalBlockingTimeMs": 270,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 892.8070000000048,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.06399999999996,
      "heapDeltaBytes": -17898784,
      "heapUsedBytes": 73309188,
      "domNodes": -290,
      "jsHeapTotalBytes": 19005440,
      "scriptDurationMs": 33.949,
      "eventListeners": -217,
      "totalBlockingTimeMs": 270,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 671.162000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 240.12900000000005,
      "heapDeltaBytes": 15422840,
      "heapUsedBytes": 92338592,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 81.07000000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 79,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 671.0839999999507,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 238.1120000000001,
      "heapDeltaBytes": 14547140,
      "heapUsedBytes": 90447984,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 82.178,
      "eventListeners": 0,
      "totalBlockingTimeMs": 78,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5089.741000000004,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.4220000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4337.104,
      "heapDeltaBytes": 19830244,
      "heapUsedBytes": 98551128,
      "domNodes": -252,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 3499.46,
      "eventListeners": -152,
      "totalBlockingTimeMs": 20,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 5402.3569999999945,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.416,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4523.7029999999995,
      "heapDeltaBytes": -8886612,
      "heapUsedBytes": 70334680,
      "domNodes": -265,
      "jsHeapTotalBytes": 1302528,
      "scriptDurationMs": 3606.699,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5593.401000000029,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.5809999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4548.438000000001,
      "heapDeltaBytes": 4795528,
      "heapUsedBytes": 86564084,
      "domNodes": -18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 3616.066,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 5558.110999999997,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.5239999999999982,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4620.067,
      "heapDeltaBytes": 5151616,
      "heapUsedBytes": 69569728,
      "domNodes": -266,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 3707.1589999999997,
      "eventListeners": -174,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2002.588000000003,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.902999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 311.38800000000003,
      "heapDeltaBytes": 2814972,
      "heapUsedBytes": 85479064,
      "domNodes": -250,
      "jsHeapTotalBytes": 2650112,
      "scriptDurationMs": 18.041999999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1993.4690000000046,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.8020000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.179,
      "heapDeltaBytes": 2793724,
      "heapUsedBytes": 85453468,
      "domNodes": -254,
      "jsHeapTotalBytes": 4222976,
      "scriptDurationMs": 16.229,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2082.3090000000093,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 14.032,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 939.84,
      "heapDeltaBytes": -832380,
      "heapUsedBytes": 89035812,
      "domNodes": -239,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 501.61599999999993,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2099.9360000000706,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.862999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 965.451,
      "heapDeltaBytes": -1604368,
      "heapUsedBytes": 88588696,
      "domNodes": -245,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 513.823,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3078.26399999999,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 14.701999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.04,
      "taskDurationMs": 1013.7080000000001,
      "heapDeltaBytes": 2665700,
      "heapUsedBytes": 93905796,
      "domNodes": 44,
      "jsHeapTotalBytes": 6066176,
      "scriptDurationMs": 486.17,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3071.8520000000353,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 14.972,
      "layouts": 60,
      "layoutDurationMs": 13.015,
      "taskDurationMs": 989.735,
      "heapDeltaBytes": 2949580,
      "heapUsedBytes": 94440152,
      "domNodes": 44,
      "jsHeapTotalBytes": 5541888,
      "scriptDurationMs": 470.45899999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2106.3010000000304,
      "styleRecalcs": 51,
      "styleRecalcDurationMs": 9.469000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1094.554,
      "heapDeltaBytes": -17616764,
      "heapUsedBytes": 75102348,
      "domNodes": 18,
      "jsHeapTotalBytes": 6852608,
      "scriptDurationMs": 585.365,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2119.878000000085,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 8.828,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1091.683,
      "heapDeltaBytes": 12579780,
      "heapUsedBytes": 99307268,
      "domNodes": 16,
      "jsHeapTotalBytes": 5959680,
      "scriptDurationMs": 580.8480000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1998.7100000000169,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.442,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 253.82,
      "heapDeltaBytes": 10251996,
      "heapUsedBytes": 74567740,
      "domNodes": -233,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.134000000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.846000000015,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.124,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 305.836,
      "heapDeltaBytes": -22705036,
      "heapUsedBytes": 68175948,
      "domNodes": -239,
      "jsHeapTotalBytes": 3960832,
      "scriptDurationMs": 18.235999999999994,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 378.2749999999737,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 10.202000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 241.53699999999998,
      "heapDeltaBytes": 13256956,
      "heapUsedBytes": 77522136,
      "domNodes": 25,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 89.598,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 365.27300000000196,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 8.614,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 238.35600000000002,
      "heapDeltaBytes": 13651044,
      "heapUsedBytes": 84311668,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 88.285,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1994.3480000000022,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.316000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 257.328,
      "heapDeltaBytes": -8758640,
      "heapUsedBytes": 62375496,
      "domNodes": -272,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 4.818,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.0109999999577,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.0630000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 252.286,
      "heapDeltaBytes": -12869772,
      "heapUsedBytes": 57801404,
      "domNodes": -272,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 4.748,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1661.5259999999807,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.487,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 435.164,
      "heapDeltaBytes": -9734372,
      "heapUsedBytes": 61537632,
      "domNodes": -272,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 66.706,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1662.3679999999013,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.001999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.94200000000006,
      "heapDeltaBytes": -9525580,
      "heapUsedBytes": 61540172,
      "domNodes": -273,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 65.252,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 750.2920000000017,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 17.390000000000004,
      "layouts": 5,
      "layoutDurationMs": 7.268,
      "taskDurationMs": 509.47200000000004,
      "heapDeltaBytes": 20104620,
      "heapUsedBytes": 103622972,
      "domNodes": 13667,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 17.04,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 55,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8120.631000000003,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.980000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3228.4429999999998,
      "heapDeltaBytes": -7040748,
      "heapUsedBytes": 81938396,
      "domNodes": -241,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 1711.012,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8408.029000000057,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.545,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3568.865,
      "heapDeltaBytes": -537828,
      "heapUsedBytes": 88821140,
      "domNodes": -234,
      "jsHeapTotalBytes": 778240,
      "scriptDurationMs": 1883.5380000000002,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10030.957999999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8934.5,
      "heapDeltaBytes": -55191180,
      "heapUsedBytes": 186056520,
      "domNodes": -8062,
      "jsHeapTotalBytes": -20041728,
      "scriptDurationMs": 122.57100000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666607,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 9982.482000000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8900.012,
      "heapDeltaBytes": -34932616,
      "heapUsedBytes": 186053400,
      "domNodes": -8062,
      "jsHeapTotalBytes": -10731520,
      "scriptDurationMs": 115.41900000000003,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13059.590000000015,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.41700000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12701.726,
      "heapDeltaBytes": -27796136,
      "heapUsedBytes": 188102592,
      "domNodes": -8062,
      "jsHeapTotalBytes": -23195648,
      "scriptDurationMs": 547.8629999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 61,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13162.982000000056,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.07899999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12797.938,
      "heapDeltaBytes": -24715764,
      "heapUsedBytes": 194882512,
      "domNodes": -8062,
      "jsHeapTotalBytes": -17711104,
      "scriptDurationMs": 572.4889999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3808.9110000000233,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 49.483,
      "layouts": 20,
      "layoutDurationMs": 17.676000000000005,
      "taskDurationMs": 3685.355,
      "heapDeltaBytes": -55918312,
      "heapUsedBytes": 186493000,
      "domNodes": -8062,
      "jsHeapTotalBytes": 16314368,
      "scriptDurationMs": 56.77,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 5,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 3747.4899999999707,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 47.870999999999995,
      "layouts": 20,
      "layoutDurationMs": 17.079000000000004,
      "taskDurationMs": 3618.6,
      "heapDeltaBytes": -32170756,
      "heapUsedBytes": 187910356,
      "domNodes": -8062,
      "jsHeapTotalBytes": 19914752,
      "scriptDurationMs": 55.826,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5313.265000000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4867.4400000000005,
      "heapDeltaBytes": -14521772,
      "heapUsedBytes": 186120952,
      "domNodes": 0,
      "jsHeapTotalBytes": -33554432,
      "scriptDurationMs": 61.850000000000016,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5153.394999999932,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4552.1500000000015,
      "heapDeltaBytes": -20364792,
      "heapUsedBytes": 169759880,
      "domNodes": 0,
      "jsHeapTotalBytes": -34603008,
      "scriptDurationMs": 59.388,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 438.5469999999714,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 20.857,
      "layouts": 7,
      "layoutDurationMs": 2.26,
      "taskDurationMs": 102.338,
      "heapDeltaBytes": 5467836,
      "heapUsedBytes": 67956852,
      "domNodes": 154,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.857,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 411.1410000000433,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 14.953000000000001,
      "layouts": 3,
      "layoutDurationMs": 0.7950000000000002,
      "taskDurationMs": 75.75299999999999,
      "heapDeltaBytes": 4888568,
      "heapUsedBytes": 67417852,
      "domNodes": 123,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.764999999999995,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 53024 80265 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.3% 1170
src/LGraphNode.ts 70.6% 382
src/platform/workspace/stores/billingOperationStore.ts 8.0% 332
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 78.9% 273
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 73.2% 254
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/pnginfo.ts 20.7% 222
src/renderer/extensions/layerEditor/engine/editor/editor.ts 34.7% 211

@github-actions
github-actions Bot requested a review from thedatalife October 8, 2026 14:56
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 8, 2026
@christian-byrne
christian-byrne force-pushed the backport-19979-to-cloud-1.55 branch from 46664f7 to 7a6fddb Compare October 8, 2026 15:01
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.16667% with 19 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...orkbench/extensions/agent/crdt/liveGraphApplier.ts 84.16% 19 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #20561   +/-   ##
=============================================
  Coverage              ?   85.08%           
=============================================
  Files                 ?     2357           
  Lines                 ?   135239           
  Branches              ?    34361           
=============================================
  Hits                  ?   115067           
  Misses                ?    19807           
  Partials              ?      365           
Flag Coverage Δ
e2e 66.04% <ø> (?)
unit 81.41% <84.16%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...orkbench/extensions/agent/crdt/liveGraphApplier.ts 90.57% <84.16%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 2
🟢 Low 5

Panel: 7/8 reviewers contributed findings.

Reviewers that did not contribute: gpt-5.6-sol-max:adversarial (error)

@christian-byrne
christian-byrne removed the request for review from thedatalife October 8, 2026 15:36
@github-actions
github-actions Bot requested a review from thedatalife October 8, 2026 16:25
@christian-byrne
christian-byrne requested review from ryan-di and removed request for thedatalife October 8, 2026 18:27
@christian-byrne

Copy link
Copy Markdown
Contributor Author

@ryan-di final release-owner escalation after two silent ownership windows: the current head is mergeable and gh pr checks --required is fully green (e2e-status, lint-and-format, test). You are now the sole assignee/reviewer; please approve the current head or leave one concrete finding. Auto-merge is being armed so an approval can deliver without another operator wait.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

All ten findings in the Cursor review above describe code that is already on main, so none of them is a reason to hold this backport.

This branch has two commits. The first is the cherry-pick of #19979, and it introduces exactly the change main carries, checked by comparing the added and removed lines of both commits: the three browser_tests files are identical, and the two source files match line for line against main's squashed commit 99c46fe15f. Nine of the ten findings sit on lines from that commit. The tenth, the missing depth limit on the input-spec walk, sits on the second commit's code, but main's src/schemas/nodeDef/inputSpecTree.ts has no depth limit either, so fixing it only here would make the release branch differ from main without reducing release risk.

The findings that look like real defects after reading the code are now filed as #20587 against main. I changed nothing on this branch, so the head has not moved.

@ryan-di the part of this PR worth your review is the second commit rather than the review findings. It replaces the @/schemas/nodeDef/inputSpecTree import, which this branch does not have, with a local walk over the dynamic containers cloud/1.55 can express. The equivalence holds as far as I can check it: COMFY_DYNAMICGROUP_V3 is absent from this branch's node-def schemas, and COMFY_MATCHTYPE_V3 nests nothing, so COMFY_DYNAMICCOMBO_V3 and COMFY_AUTOGROW_V3 are the complete set here.

One difference I did find, which the review did not raise: main parses each dynamic-combo option separately and keeps the ones that parse, while this version parses the options array as a whole and yields nothing when any single option is malformed. For a dynamic combo nested inside an option whose sibling is malformed, the overflow gate answers false here where main answers true, so #19979's fix does not engage for that node shape. That is a fix not applying rather than a value written to the wrong widget, and closing it would widen the backport, so I left it alone. Tell me if you would rather it match main exactly and I will push it.

@christian-byrne
christian-byrne removed the request for review from ryan-di October 9, 2026 00:37
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Reassigning review: ryan-di has not engaged across two prior windows (see comments above) and the cloud/1.55 branch rule only requires one approving review, not a specific reviewer. @dante01yoon — current head 7a6fddba1 is green and mergeable; could you take this one? It's the FE-19979 backport for N2 row 6 (BE-16625 dynamic-combo overflow).

@github-actions
github-actions Bot requested a review from thedatalife October 9, 2026 00:41

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Operator review under the Agent 1.54/1.55 backport grant (program/release-backport-authority.md, Christian 2026-09-16, extended 2026-09-27 to cover core/1.55 and cloud/1.55). Author is also the PR author, so this is an honest COMMENT rather than an approval record.

Evidence:

  • Diff reviewed: cherry-pick of #19979 (verified byte-identical against main's squashed 99c46fe for the three browser_tests files and both source files) plus a second commit substituting the cloud/1.55-local dynamic-container walk for the inputSpecTree import this branch lacks.
  • All 10 cursor-review findings resolved as threads: 9 sit on main-already-shipped lines (now tracked at #20587, filed against main, not a reason to hold this backport) and the 10th (no depth limit on the input-spec walk) matches main's existing behavior — fixing only here would diverge the branch from main without reducing release risk.
  • One known gap not raised by the review, disclosed by the author: a dynamic combo nested inside an option whose sibling is malformed does not get the overflow-gate fix here (differs from main's per-option parsing), left as-is per the author's judgment to avoid widening this backport.
  • check-merge-ready.sh --target-branch cloud/1.55: MERGE READY — base is ancestor of head, 104 checks success/neutral/skipped, no unresolved threads, no later reviewer objections.

Proceeding to admin-merge under the grant.

@christian-byrne
christian-byrne merged commit c29c2cd into cloud/1.55 Oct 9, 2026
106 checks passed
@christian-byrne
christian-byrne deleted the backport-19979-to-cloud-1.55 branch October 9, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants