Repository navigation
feat(agent): attach user id to agent feedback Typeform hidden fields - #19028
Conversation
Agent-panel feedback carries a `session` hidden field, but it is legitimately absent whenever no thread is active - after New Chat, after a thread 404s on hydrate, or when a first send never acked. Langfuse is not indexed by email, so those responses cannot be traced to the reporting user at all. Attach the resolved user id (Firebase uid, or the API-key user id) so a response stays traceable even when `session` drops out. Requires a matching `userid` hidden field on Typeform MZ6cjWIB: Typeform silently discards refs the form does not declare.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2140 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2ea640aa4d6d01def161e9ec2870acd01ab21e05
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.98 MB (baseline 3.98 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-27T01:12:01.983Z",
"gitSha": "9a7fc516601787ee9b9b989c5a0e1b942e6b366a",
"branch": "glary/agent-feedback-userid-hidden-field",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.3839999999586,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.3359999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.419,
"heapDeltaBytes": -1353156,
"heapUsedBytes": 60652404,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7.277,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.0450000000337,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.2000000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.56699999999995,
"heapDeltaBytes": -1069500,
"heapUsedBytes": 66199828,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.508000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1697.1849999999904,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.993,
"layouts": 12,
"layoutDurationMs": 3.3390000000000004,
"taskDurationMs": 614.09,
"heapDeltaBytes": -7773248,
"heapUsedBytes": 54827108,
"domNodes": 0,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 112.717,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.8080000000036,
"styleRecalcs": 72,
"styleRecalcDurationMs": 12.767000000000001,
"layouts": 12,
"layoutDurationMs": 3.2419999999999995,
"taskDurationMs": 615.847,
"heapDeltaBytes": -5780008,
"heapUsedBytes": 56785344,
"domNodes": -228,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 112.60499999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.2620000000002,
"styleRecalcs": 30,
"styleRecalcDurationMs": 8.162000000000003,
"layouts": 6,
"layoutDurationMs": 1.1900000000000002,
"taskDurationMs": 266.393,
"heapDeltaBytes": 2174376,
"heapUsedBytes": 64603600,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.063,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1693.0679999999256,
"styleRecalcs": 30,
"styleRecalcDurationMs": 7.770999999999999,
"layouts": 6,
"layoutDurationMs": 1.061,
"taskDurationMs": 263.854,
"heapDeltaBytes": 2096664,
"heapUsedBytes": 64395944,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.607000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 531.8510000000174,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.149000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.59,
"heapDeltaBytes": 18715980,
"heapUsedBytes": 81039452,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 115.14399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 532.9080000000204,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.5850000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.74800000000005,
"heapDeltaBytes": 18479180,
"heapUsedBytes": 80925184,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 117.723,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1064.6039999999743,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.431,
"heapDeltaBytes": -13809972,
"heapUsedBytes": 72436772,
"domNodes": -259,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 44.421,
"eventListeners": -207,
"totalBlockingTimeMs": 426,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1028.4530000000132,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 657.8140000000001,
"heapDeltaBytes": 34674324,
"heapUsedBytes": 104944628,
"domNodes": 0,
"jsHeapTotalBytes": 19820544,
"scriptDurationMs": 50.124999999999986,
"eventListeners": 0,
"totalBlockingTimeMs": 417,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 729.8059999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 333.4139999999999,
"heapDeltaBytes": 14749460,
"heapUsedBytes": 90463784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.572,
"eventListeners": 0,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 729.0730000000849,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 319.4079999999997,
"heapDeltaBytes": 14738960,
"heapUsedBytes": 92034352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 99.57900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6775.146000000006,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.21100000000000113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6144.124,
"heapDeltaBytes": 3572704,
"heapUsedBytes": 86014908,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 5022.398,
"eventListeners": 0,
"totalBlockingTimeMs": 57,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6626.47000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.2660000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5919.572999999999,
"heapDeltaBytes": -1616916,
"heapUsedBytes": 81005616,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4596.880999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 44,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6532.793999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5868.266,
"heapDeltaBytes": 23115556,
"heapUsedBytes": 98026636,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 4581.215,
"eventListeners": 0,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6700.304000000074,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3239999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5993.656000000001,
"heapDeltaBytes": -784624,
"heapUsedBytes": 76773792,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 4679.952,
"eventListeners": -164,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2026.3230000000476,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2380000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.17,
"heapDeltaBytes": -7994080,
"heapUsedBytes": 73742532,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 28.949999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.8209999999744,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4029999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.8380000000001,
"heapDeltaBytes": -7150648,
"heapUsedBytes": 72284792,
"domNodes": -228,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 28.479000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2132.7810000000227,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.451,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1247.7659999999998,
"heapDeltaBytes": 6061180,
"heapUsedBytes": 88886540,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 604.2339999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2150.137000000086,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.515000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1166.4160000000002,
"heapDeltaBytes": -5581976,
"heapUsedBytes": 75730204,
"domNodes": -228,
"jsHeapTotalBytes": 2052096,
"scriptDurationMs": 610.914,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3187.36100000001,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.697,
"layouts": 60,
"layoutDurationMs": 13.046,
"taskDurationMs": 1387.372,
"heapDeltaBytes": -13647040,
"heapUsedBytes": 69864464,
"domNodes": -228,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 588.9870000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3122.345999999993,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.56,
"layouts": 60,
"layoutDurationMs": 11.797,
"taskDurationMs": 1269.5859999999998,
"heapDeltaBytes": 7751296,
"heapUsedBytes": 74270776,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 558.797,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2161.0339999999724,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.435000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1350.143,
"heapDeltaBytes": 17591376,
"heapUsedBytes": 83765764,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 653.365,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2187.4090000000024,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1409.796,
"heapDeltaBytes": -11087312,
"heapUsedBytes": 74119588,
"domNodes": -228,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 677.145,
"eventListeners": 16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2037.2009999999818,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4410000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.0519999999999,
"heapDeltaBytes": -13983532,
"heapUsedBytes": 74012692,
"domNodes": -228,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 29.935000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.6210000000337,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1659999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.028,
"heapDeltaBytes": -14371336,
"heapUsedBytes": 74688876,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 29.23499999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 448.7050000000181,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.811,
"heapDeltaBytes": 13467548,
"heapUsedBytes": 77066688,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 103.682,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.5549999999539,
"styleRecalcs": 49,
"styleRecalcDurationMs": 4.562,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.168,
"heapDeltaBytes": 13111104,
"heapUsedBytes": 76870756,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 108.561,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1991.595000000018,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.9530000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.28,
"heapDeltaBytes": 12272176,
"heapUsedBytes": 75766176,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.956,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2002.91500000003,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9759999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.71599999999995,
"heapDeltaBytes": 7418504,
"heapUsedBytes": 71104572,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.460000000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.5850000000373,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.418000000000001,
"layouts": 16,
"layoutDurationMs": 4.507000000000001,
"taskDurationMs": 611.524,
"heapDeltaBytes": 9610764,
"heapUsedBytes": 73236432,
"domNodes": -244,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 79.226,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2279999999291,
"styleRecalcs": 78,
"styleRecalcDurationMs": 13.694,
"layouts": 16,
"layoutDurationMs": 4.4510000000000005,
"taskDurationMs": 608.268,
"heapDeltaBytes": -6909852,
"heapUsedBytes": 56070716,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 78.091,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.5760000000091,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.462000000000003,
"layouts": 5,
"layoutDurationMs": 8.413,
"taskDurationMs": 686.336,
"heapDeltaBytes": 19822532,
"heapUsedBytes": 99863720,
"domNodes": 13667,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 21.89,
"eventListeners": 2383,
"totalBlockingTimeMs": 108,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8152.1490000000085,
"styleRecalcs": 250,
"styleRecalcDurationMs": 26.526,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4106.515000000001,
"heapDeltaBytes": 2801060,
"heapUsedBytes": 84494016,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2141.6879999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.57499999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.913999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4402.075,
"heapDeltaBytes": 7843268,
"heapUsedBytes": 95322256,
"domNodes": -228,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 2051.445,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12490.263000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11556.831,
"heapDeltaBytes": -57729896,
"heapUsedBytes": 182101304,
"domNodes": -8049,
"jsHeapTotalBytes": -20340736,
"scriptDurationMs": 178.15300000000002,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12036.97199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11043.679,
"heapDeltaBytes": -70065432,
"heapUsedBytes": 163850580,
"domNodes": -8049,
"jsHeapTotalBytes": -12857344,
"scriptDurationMs": 173.321,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14921.314999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.991000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14428.944,
"heapDeltaBytes": -64467428,
"heapUsedBytes": 176017952,
"domNodes": -8049,
"jsHeapTotalBytes": -25890816,
"scriptDurationMs": 763.3539999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 54,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14963.051999999949,
"styleRecalcs": 71,
"styleRecalcDurationMs": 12.758000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14339.436999999998,
"heapDeltaBytes": -43797096,
"heapUsedBytes": 191379068,
"domNodes": -8049,
"jsHeapTotalBytes": -13438976,
"scriptDurationMs": 684.125,
"eventListeners": -14923,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4283.405999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.10299999999999,
"layouts": 20,
"layoutDurationMs": 20.990999999999996,
"taskDurationMs": 4180.141999999999,
"heapDeltaBytes": -23172088,
"heapUsedBytes": 194729352,
"domNodes": -8049,
"jsHeapTotalBytes": 13099008,
"scriptDurationMs": 72.851,
"eventListeners": -14923,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4218.6080000000175,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.117000000000004,
"layouts": 20,
"layoutDurationMs": 20.261000000000003,
"taskDurationMs": 4090.5320000000006,
"heapDeltaBytes": -57076708,
"heapUsedBytes": 182759688,
"domNodes": -8049,
"jsHeapTotalBytes": 11640832,
"scriptDurationMs": 71.383,
"eventListeners": -14923,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4339.270999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4016.9559999999988,
"heapDeltaBytes": -2980704,
"heapUsedBytes": 184709024,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 61.32399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6266.569000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5820.022,
"heapDeltaBytes": -18027636,
"heapUsedBytes": 164801700,
"domNodes": 0,
"jsHeapTotalBytes": -25690112,
"scriptDurationMs": 86.50800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 81.90500000000611,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.871000000000002,
"layouts": 4,
"layoutDurationMs": 1.4480000000000002,
"taskDurationMs": 61.45800000000001,
"heapDeltaBytes": 3086812,
"heapUsedBytes": 65078656,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.729000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 447.9509999999891,
"styleRecalcs": 22,
"styleRecalcDurationMs": 16.720000000000002,
"layouts": 6,
"layoutDurationMs": 2.155,
"taskDurationMs": 112.158,
"heapDeltaBytes": 5052444,
"heapUsedBytes": 67110792,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.026999999999997,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe Agent feedback dialog now adds the resolved user ID to its hidden fields when the ID is available. Tests cover dialogs with and without a thread. ChangesAgent feedback dialog
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to The user ID is sent when available. Confirm that the Typeform form declares 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Thanks — acknowledged. CodeRabbit reported no actionable comments and left no inline feedback, so there is nothing to change in the diff. No new commits pushed. Flagging one thing so the approval isn't read as merge-ready: this PR is still blocked on a Typeform configuration change, not on code. A hidden field with the ref exactly Keeping it in draft until that field exists. CI on |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19028 +/- ##
==========================================
+ Coverage 84.02% 84.94% +0.91%
==========================================
Files 3158 2309 -849
Lines 154414 133073 -21341
Branches 41918 34061 -7857
==========================================
- Hits 129750 113038 -16712
+ Misses 23059 19717 -3342
+ Partials 1605 318 -1287
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 859 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
question: The code change looks correct, and I verified the focused tests and changed-file lint/format checks locally. However, the live MZ6cjWIB form still declares only email, intent, source, version, os, and session, so Typeform currently discards userid silently. Since this PR is now marked ready rather than draft, could we keep it blocked until userid is added to the form and confirm that configuration here? Once that external dependency is in place, I have no code findings.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| const { userEmail, resolvedUserInfo } = useCurrentUser() | ||
| const hiddenFields = Object.entries({ | ||
| email: userEmail.value, | ||
| userid: resolvedUserInfo.value?.id, |
There was a problem hiding this comment.
🟢 Low — This sends the authenticated account's stable internal id (Firebase UID, or the Comfy API customer id on the API-key rail) to Typeform as a hidden field on every agent feedback submission, which lets the vendor join responses back to the account record in Comfy's own systems — a step beyond the email already shared. Confirm the account id is covered by the privacy policy/DPA for this processor, or send a scoped correlation token instead. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Fair flag, and not one I can settle in code — escalating rather than resolving it myself. Three things that should inform the call:
The processor already receives a stronger identifier. This same payload has shipped email= since the form launched, and the form additionally asks for an email directly (contact_email). An opaque Firebase UID is less identifying in isolation than the address already being sent, so this widens what Typeform can join on rather than introducing a new category of personal data. Still a real change in linkability, just a smaller delta than it might look.
A scoped correlation token would defeat the purpose. The requirement driving this is that the team cannot look responses up in Langfuse by email — Langfuse is keyed by user id. A token that doesn't equal the Langfuse user id would need a mapping table and a lookup step, which is the problem this change exists to remove. If the DPA answer is "no", the right alternative is probably to drop the field and correlate out-of-band, not to substitute a token.
It's cheap to unwind. The field is inert until someone adds userid to Typeform MZ6cjWIB, which hasn't happened yet — so there's no data in flight and no migration cost if the answer comes back negative. That's a genuine reason not to rush the form-side change.
@christian-byrne — you're closest to this: is the account id covered by the Typeform DPA, or does it need a privacy review before the form field gets added? I'd rather have that answered before the Typeform change lands than after. No code change made pending your call.
| const { userEmail } = useCurrentUser() | ||
| const { userEmail, resolvedUserInfo } = useCurrentUser() | ||
| const hiddenFields = Object.entries({ | ||
| email: userEmail.value, |
There was a problem hiding this comment.
🟢 Low — resolvedUserInfo is null until the Firebase auth-state listener fires or the API-key customer lookup resolves, and the entries are filtered on truthiness, so feedback opened early in a session ships with no userid (and no email). The traceability goal silently fails on exactly that path, and the payload gives no way to distinguish "signed out" from "auth not resolved yet". Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
There was a problem hiding this comment.
Good hypothesis, but I don't think this window is reachable on the agent path. The feedback button can't be on screen until resolvedUserInfo has already resolved.
The chain, all in this repo:
AgentFeedbackCaptionlives inAgentPanel.vue's footer, inside thev-if="!showHistory"block.- The panel only mounts via
DockedAgentPanel.vue:3—v-if="docked", wheredockedisagentPanelStore.isVisible. agentPanelStore.ts:96—isVisible = enabled && isOpen && consentAccepted.agentPanel.ts:179syncsconsentAcceptedfromconsentStore.accepted.agentConsentStore.ts:45—accepted = computed(() => currentIdentity() !== null && acceptedIdentity.value === currentIdentity()).currentIdentity()returnsnullwhen!userId(line 37), andcurrentUserId()is exactlyresolvedUserInfo.value?.id(line 31).
So while resolvedUserInfo is null, accepted is false → isVisible is false → the panel and its footer aren't rendered → there's no button to click. Auth resolution is effectively a precondition of the button existing.
Worth adding that the consent gate is per identity: the watcher at agentConsentStore.ts:51 resets acceptedIdentity whenever identity changes, so a stale accepted-consent from a previous session can't unlock the panel ahead of auth either.
On distinguishing "signed out" from "auth not resolved" — I'd argue that's moot here for the same reason, and I'd rather not encode a sentinel value for a state the form can't be reached in. Typeform would discard an undeclared marker anyway. No change made; happy to revisit if you know a path that renders the caption pre-auth that I've missed.
| const { userEmail, resolvedUserInfo } = useCurrentUser() | ||
| const hiddenFields = Object.entries({ | ||
| email: userEmail.value, | ||
| userid: resolvedUserInfo.value?.id, |
There was a problem hiding this comment.
⚪ Nit — userid is only added on the Agent-enabled branch; openGeneralFeedbackDialog — the path used by the topbar button and WorkflowTabs — still sends only email, so feedback from those entry points stays untraceable to an account. buildFeedbackHiddenFields already accepts extraTags, so the parallel change is one line; worth confirming the omission is deliberate given the two dialogs post to different Typeforms with already-divergent field sets. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
There was a problem hiding this comment.
Deliberate, and there's a stronger reason than the divergent field sets — the other form declares no hidden fields at all, so the one-line change would be a no-op.
Fetching q7azbWPi and parsing its definition:
id: q7azbWPi | title: Feedback Topics Tree
hidden: None
The only "hidden" string in that page is document.visibilityState === "hidden" in Typeform's own bundle — there is no hidden-field declaration. So adding userid to buildFeedbackHiddenFields would be discarded on arrival.
Which surfaces something worth its own ticket, unrelated to this PR: buildFeedbackHiddenFields already sends distribution, source and email to that form, and all three are being silently dropped today for the same reason. The topbar/WorkflowTabs/help-center feedback has no segmentation reaching Typeform at all. That's pre-existing and out of scope here, but I'll raise it separately — fixing it is a Typeform-side change, not a code one.
Keeping this PR confined to the agent form. No change made.
The agent feedback Typeform declares an `intent` hidden field that the frontend never populated, so it arrived blank on every response. The form's own "Report a bug" back-link sends `intent=bug&source=feedback_ending`, pairing intent (why the respondent came) with source (where from). The agent panel's only entry point into this form is the "Share feedback" caption, so send `intent=feedback` to match that vocabulary. Nothing in the form's 11 logic rules branches on `intent`, so this is segmentation metadata only and cannot alter the question flow.
|
@dante01yoon Agreed on all counts, and thanks for catching the draft flip — I opened this as a draft and it's since been marked ready. I can't convert it back myself (my tooling only creates and pushes), so could you flip it back to draft, or add a blocking label? Confirming your finding independently just now:
New commit:
|
| field | declared on the form? | effect on merge today |
|---|---|---|
intent |
yes | works immediately |
userid |
no | silently discarded |
So merging now would ship one working field and one no-op. Still worth holding.
Why intent=feedback. The form declares intent but the frontend never populated it, which is why it has been blank on every response since launch. The form's own "Report a bug" back-link sends intent=bug&source=feedback_ending — so intent records why the respondent came and source records where from, and we already send source=agent-panel. The agent panel's only entry point into this form is the "Share feedback" caption, so feedback is the parallel value.
I checked it can't break the flow: intent appears in zero of the form's 11 logic rules, so it is pure segmentation metadata and cannot alter question routing.
One caveat I can't resolve from outside: intent=bug is the only value observable in the public form definition — feedback is my inference from the welcome question's two-way split ("Something broke…" / "I want to share feedback on the agent"). Typeform doesn't enumerate valid values for hidden fields, so nothing will reject it, but if whoever owns the form expects a different token (share_feedback, agent_feedback, …) it's a one-word change. Worth confirming alongside adding userid.
Also note intent reflects the entry point, not the respondent's own classification — someone can arrive via "Share feedback" and still pick "Something broke" at the welcome question. The welcome answer remains the source of truth for that; intent tells you how they got there.
Verification on 4644ce6
Full pnpm typecheck:app, oxfmt, oxlint --type-aware and eslint pass via the pre-commit hook; 15 test files / 97 tests pass. Exercised against a live dev build, reading the rendered data-tf-hidden — with a live thread and after conversationStore.reset() (what New Chat calls):
email=…,userid=…,intent=feedback,source=agent-panel,version=1.56.0,os=Linux x86_64,session=thread-abc-123
email=…,userid=…,intent=feedback,source=agent-panel,version=1.56.0,os=Linux x86_64
Screenshots
This reverts commit 4644ce6. A hardcoded `intent` cannot be correct from the agent panel, because the panel has exactly one entry point and it is intent-neutral: the button says "Share feedback", but the form's welcome screen says "Found a bug or have thoughts on the agent? Either way this goes straight to the team", and the bug branch is fully reachable through it. So `intent=feedback` would mislabel every bug report filed through the panel, contradicting that response's own `welcome` answer. Being a constant, it is also 1:1 with `source=agent-panel` and adds no segmentation. The survey's `welcome` question already records bug-vs-feedback on every response, and logic rule 2 makes it the answer that routes the branch. `intent` stays meaningful for the form's own `intent=bug` re-entry link, where the entry point does know what the user came to do.
Reverted the
|
|
@dante01yoon Confirmed on both, and I agree the PR should not merge yet. No code changes — 1. Still six refs, no 2. Privacy/DPA — still unanswered. Raised with @christian-byrne on that thread; no verdict yet. Worth settling before the form field is added rather than after, since nothing is in flight today and it's free to unwind. One thing your re-review surfaced that's worth flagging. The PR has since picked up I checked whether any of that could merge it automatically, and it can't — So there's no armed automation, but the labels do create a human trap worth naming: On returning it to draft — I still can't do that with my tooling (it only creates and pushes). Could you convert it, or swap |
christian-byrne
left a comment
There was a problem hiding this comment.
Doing the config change now
|
@christian-byrne 🙏 — polled for ~11 minutes and it hasn't published yet, so flagging in case you hit the "saved but not live" trap. Checked both surfaces, so this isn't CDN caching: Self-check one-liner — should list seven refs including curl -fsSL https://api.typeform.com/forms/MZ6cjWIB | python3 -c 'import json,sys; print(json.load(sys.stdin)["hidden"])'Two things that fail silently if they're off:
Ping me when it's live and I'll run the end-to-end verification against a real dev build and confirm here — that clears blocker 1 of @dante01yoon's two. The privacy/DPA question is the other, and it's still yours to call. No code changes — |
dante01yoon
left a comment
There was a problem hiding this comment.
question: Re-reviewed 948ee339. The Typeform-side blocker is now resolved: the live MZ6cjWIB definition declares all seven refs, including userid. The code tree remains identical to the previously validated revision, all CI checks are complete with no failures, and I have no code findings.
The remaining blocker is the unresolved privacy/DPA question: is sending the stable internal account ID to Typeform covered for this processor? Once the owner confirms that, this is ready for approval.
|
@dante01yoon Confirmed, and I ran the end-to-end verification I owed you now that the field is live. No code changes — Form side verified on both surfaces, and the ref matches our key exactly (lowercase, no separator — so no silent-drop trap): End-to-end against a real dev build. Rather than stopping at our own And with no active thread (post- One thing worth recording, since it looked like a bug mid-investigation and isn't. If you close and reopen the dialog within a single JS tick, the iframe keeps its original fragment — Remaining blocker is yours to unblock, @christian-byrne — the privacy/DPA question is still open. Your "doing the config change now" covered the form field; this is the separate one. Worth noting the calculus shifted slightly: with the field now live, merging does start sending account ids, so this is no longer free to defer. Screenshots |
Yes it's covered |
Thanks @christian-byrne — recording it here so the answer is attached to the PR: account id confirmed covered for this processor by the form owner. That closes the last of @dante01yoon's two conditions. Both now resolved:
Final state on Withdrawing my two earlier process asks, since both were contingent on the blockers:
@dante01yoon — both conditions you were holding on are met, so this should be unblocked for your approval. One note for whoever watches the responses: |
|
Thanks @dante01yoon — no findings to address, so no changes. State: approved by @dante01yoon and CodeRabbit, Leaving the merge to you — I don't merge without being asked, and the backport labels mean this fans out to |
|
@christian-byrne Successfully backported to #19371 |
|
@christian-byrne Successfully backported to #19372 |
|
|
…ypeform hidden fields (#19571) Cherry-picks #19028 onto `cloud/1.54` after resolving the older test mock conflict. Preserves the behavior: authenticated user ID is included in the Agent feedback form, including before a conversation session exists. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
…peform hidden fields (#19570) Cherry-picks #19028 onto `core/1.54` after resolving the older test mock conflict. Preserves the behavior: authenticated user ID is included in the Agent feedback form, including before a conversation session exists. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>


PR Created by the Glary-Bot Agent
Blocked on a Typeform config change — please read first
This PR is inert until a hidden field with the ref exactly
useridis added to TypeformMZ6cjWIB("Comfy Agent Feedback Intake Form"). Typeform silently discards any ref the form does not declare — no error, no warning, the value just never appears on the response. Verified against the live form today:This also extends the approved hidden-field allowlist from 6 refs to 7. The exact-set assertion in
feedback.test.tswas originally added as a mechanical tripwire against unapproved fields, so this note is what replaces it — please confirm the extension is intended.Why
Agent-panel feedback attaches a
sessionhidden field, but it is legitimately absent whenever no thread is active. Langfuse is not indexed by email, so those responses currently cannot be traced back to the reporting user at all. Attaching the user id keeps a response traceable even whensessiondrops out.What
src/workbench/extensions/agent/feedback.tsnow addsuseridto the hidden fields, sourced fromuseCurrentUser().resolvedUserInfo— the Firebase uid when signed in with Firebase, or the API-key user id otherwise. It follows the existing conventions in that code path: absent values are omitted rather than sent as placeholders, and commas are escaped so a value cannot inject an extra field.Verification
Full
pnpm typecheck:app, oxfmt, oxlint--type-awareand eslint all pass (pre-commit hook). Targeted unit tests: 15 files / 97 tests pass.Exercised end-to-end against a real dev build in a browser — the actual
MZ6cjWIBform rendering in the real dialog, driving the real store →feedback.ts→openTypeformDialog→TypeformEmbedpath. Reading the rendereddata-tf-hiddenattribute:And after
conversationStore.reset()(what New Chat calls) — reproducing the reported empty-session case, whereuseridis now the only thing that keeps the response traceable:Notes
intentis declared on the form but never populated by the frontend, which is why it is blank on every response. Out of scope here, but worth a decision — either wire it up or drop it from the form.q7azbWPi, viaplatform/support/feedbackDialog.ts) is a different form with a different field set and is deliberately untouched.Screenshots