Repository navigation
[backport core/1.54] cover reference-only attachment-history previews - #19342
Conversation
Cover image/video attachment previews after reload and chat switching, including reference-only history. <details><summary>Full context for agent readers</summary> - Follow up the non-blocking coverage suggestions on [attachment-history coverage PR18244](#18244). - Keep the single-image case and two distinct image fixtures. Add history containing only `attachment_refs`, so `attachments` cannot hide a broken fallback. - Four cases cover one image, two images with filenames/references, reference-only images, and mixed image/video references. Each verifies reload, an empty new chat and restoration of the original chat. - Assert exact filenames, decoded dimensions and Playwright visibility. Empty video `currentSrc` returns a retryable mismatch; preview assertions retain a ten-second timeout. - No production changes. [Attachment restoration PM-1148](https://linear.app/comfyorg/issue/PM-1148) and [original regression acceptance PM-1149](https://linear.app/comfyorg/issue/PM-1149) remain open for unavailable media, raw-reference presentation, storage identity, video playback and real-service persistence. Controlled-response video and chat-switch coverage are now established. The history response is independently specified rather than copied from the outgoing attachments. The outgoing request still has an exact filename assertion. Two images have different decoded widths (64 and 32), so duplicate-image recovery fails. September 21 review-repair verification: all four cases passed with zero retries against the preserved Cloud build from main `35524d57b8`, whose served index matched SHA256 `23a259c26b2af1638d1018be346bf4d8da30cd36786aea403601399aff24bccd`. The tested helper is byte-identical to [the published repair](507c172). Application/browser typechecks and mandatory commit/push hooks passed. Fresh hosted checks and human re-review remain required. Earlier sensitivity control: replacing only the `attachment_refs` fallback with an empty list made the reference-only case fail after reload, expecting two previews and receiving zero. Restoring production code and rebuilding returned the then-three cases to green. That counterfactual was not rerun for this helper repair and is not included in the PR. Each case emits before-reload, after-reload and after-chat-switch screenshots. The inspected mixed-media after-chat-switch capture shows the image and video preview together; full filenames and decoded dimensions are established by the browser assertions, not the truncated text. Playback is not tested. Glossary: reference-only history contains resolved `attachment_refs` without an `attachments` filename list; counterfactual means deliberately disabling one behavior to verify test sensitivity. </details> --------- Co-authored-by: GitHub Action <action@github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1957 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T21:02:47.042Z",
"gitSha": "1e6fe263806a758fac9dae5ceac51a1d802dd7a4",
"branch": "backport/18247-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2162.969999999973,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.984000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.7139999999999,
"heapDeltaBytes": 2765020,
"heapUsedBytes": 74044248,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 18.023,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2069.0550000000485,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.606,
"heapDeltaBytes": -12429940,
"heapUsedBytes": 57659624,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 14.642999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2225.6830000000036,
"styleRecalcs": 79,
"styleRecalcDurationMs": 38.90299999999999,
"layouts": 14,
"layoutDurationMs": 4.808000000000001,
"taskDurationMs": 1182.131,
"heapDeltaBytes": 3038700,
"heapUsedBytes": 73355364,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 202.19199999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.7400000000507,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.608,
"layouts": 14,
"layoutDurationMs": 4.028,
"taskDurationMs": 952.7779999999999,
"heapDeltaBytes": -12229356,
"heapUsedBytes": 58510960,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 169.197,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.177000000046,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.889999999999997,
"layouts": 6,
"layoutDurationMs": 1.254,
"taskDurationMs": 476.64099999999996,
"heapDeltaBytes": 4657448,
"heapUsedBytes": 75852688,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.92,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.006000000063,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.339,
"layouts": 6,
"layoutDurationMs": 1.191,
"taskDurationMs": 416.268,
"heapDeltaBytes": 4639780,
"heapUsedBytes": 75759168,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.536000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 766.8509999999742,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.539,
"heapDeltaBytes": -7604260,
"heapUsedBytes": 63308960,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 174.221,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 725.3170000000182,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.198,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.3879999999999,
"heapDeltaBytes": -7830088,
"heapUsedBytes": 63394396,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 170.435,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2012.8899999999703,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.238999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 759.543,
"heapDeltaBytes": 22126088,
"heapUsedBytes": 87136276,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 44.71699999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.7219999999597,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.243999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.946,
"heapDeltaBytes": 10524580,
"heapUsedBytes": 87211520,
"domNodes": -270,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 41.868,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3084.9399999999605,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1877.475,
"heapDeltaBytes": 26731548,
"heapUsedBytes": 92986120,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 918.421,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2522.081999999955,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.372999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1739.7690000000002,
"heapDeltaBytes": 22413724,
"heapUsedBytes": 88911268,
"domNodes": -280,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 853.177,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4054.0489999999636,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.852999999999998,
"layouts": 60,
"layoutDurationMs": 12.952000000000002,
"taskDurationMs": 1963.169,
"heapDeltaBytes": -3105160,
"heapUsedBytes": 76062092,
"domNodes": -285,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 863.394,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3710.2450000001,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.200999999999999,
"layouts": 60,
"layoutDurationMs": 12.313999999999998,
"taskDurationMs": 1810.463,
"heapDeltaBytes": 8125240,
"heapUsedBytes": 75840740,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 826.3629999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3180.3160000000616,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2177.121,
"heapDeltaBytes": 26212512,
"heapUsedBytes": 94608472,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1082.152,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3226.839000000041,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.202999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2130.2059999999997,
"heapDeltaBytes": 1659348,
"heapUsedBytes": 82391244,
"domNodes": -290,
"jsHeapTotalBytes": 4771840,
"scriptDurationMs": 1018.3500000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.500999999972,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.359,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.7750000000001,
"heapDeltaBytes": 21859076,
"heapUsedBytes": 87858264,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.599999999999994,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2067.7570000000287,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.5580000000001,
"heapDeltaBytes": 9207208,
"heapUsedBytes": 88114776,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 40.129999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 637.4859999999671,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.946000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.465,
"heapDeltaBytes": 13917748,
"heapUsedBytes": 86455536,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 147.09,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.3049999999921,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.94300000000004,
"heapDeltaBytes": 15094092,
"heapUsedBytes": 88268308,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.118,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2034.7799999999552,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.382,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.437,
"heapDeltaBytes": 7184624,
"heapUsedBytes": 80411668,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 14.081,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.815000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.317999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.1540000000001,
"heapDeltaBytes": -7899948,
"heapUsedBytes": 64712604,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 12.739999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.7079999999842,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.997999999999998,
"layouts": 18,
"layoutDurationMs": 5.523,
"taskDurationMs": 953.5299999999999,
"heapDeltaBytes": -8194956,
"heapUsedBytes": 63991768,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 128.744,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1819.631999999956,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.192999999999998,
"layouts": 18,
"layoutDurationMs": 5.392,
"taskDurationMs": 928.028,
"heapDeltaBytes": -7574212,
"heapUsedBytes": 65374180,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 131.482,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1449.4770000000017,
"styleRecalcs": 18,
"styleRecalcDurationMs": 35.446999999999996,
"layouts": 14,
"layoutDurationMs": 17.699,
"taskDurationMs": 1069.931,
"heapDeltaBytes": 20259984,
"heapUsedBytes": 104051100,
"domNodes": 13831,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 36.46000000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 167,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 10091.696999999953,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.330000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6623.12,
"heapDeltaBytes": -6345432,
"heapUsedBytes": 69645604,
"domNodes": -285,
"jsHeapTotalBytes": 4354048,
"scriptDurationMs": 2976.665,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9095.80500000004,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.428000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6238.870000000001,
"heapDeltaBytes": -14239748,
"heapUsedBytes": 89660804,
"domNodes": -271,
"jsHeapTotalBytes": -1708032,
"scriptDurationMs": 2821.3169999999996,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18385.60099999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17887.481,
"heapDeltaBytes": -39285464,
"heapUsedBytes": 179447056,
"domNodes": -8068,
"jsHeapTotalBytes": -8925184,
"scriptDurationMs": 306.284,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17811.24699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17123.632,
"heapDeltaBytes": -36441792,
"heapUsedBytes": 182557568,
"domNodes": -8068,
"jsHeapTotalBytes": -7135232,
"scriptDurationMs": 284.762,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23113.25599999998,
"styleRecalcs": 175,
"styleRecalcDurationMs": 25.063999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22943.603,
"heapDeltaBytes": -28751000,
"heapUsedBytes": 189543260,
"domNodes": -8068,
"jsHeapTotalBytes": -10567680,
"scriptDurationMs": 999.905,
"eventListeners": -14927,
"totalBlockingTimeMs": 138,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21466.773999999987,
"styleRecalcs": 161,
"styleRecalcDurationMs": 21.743000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21225.088,
"heapDeltaBytes": -25287468,
"heapUsedBytes": 193522980,
"domNodes": -8068,
"jsHeapTotalBytes": -11923456,
"scriptDurationMs": 1020.2389999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 96,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6657.849999999939,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.069,
"layouts": 20,
"layoutDurationMs": 26.252,
"taskDurationMs": 6587.677,
"heapDeltaBytes": -34482368,
"heapUsedBytes": 184194916,
"domNodes": -8068,
"jsHeapTotalBytes": 18075648,
"scriptDurationMs": 123.806,
"eventListeners": -14931,
"totalBlockingTimeMs": 455,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6285.307999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.00299999999999,
"layouts": 20,
"layoutDurationMs": 23.330000000000002,
"taskDurationMs": 6187.155000000001,
"heapDeltaBytes": -41293412,
"heapUsedBytes": 185575032,
"domNodes": -8068,
"jsHeapTotalBytes": 14987264,
"scriptDurationMs": 121.115,
"eventListeners": -14931,
"totalBlockingTimeMs": 399,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9339.633000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9158.365,
"heapDeltaBytes": 8187404,
"heapUsedBytes": 168440732,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 153.93599999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9095.18300000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8787.630000000001,
"heapDeltaBytes": 11936376,
"heapUsedBytes": 182588896,
"domNodes": 0,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 149.94299999999993,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 131.10999999992146,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.163,
"layouts": 3,
"layoutDurationMs": 0.8069999999999999,
"taskDurationMs": 85.392,
"heapDeltaBytes": 3101148,
"heapUsedBytes": 71544520,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.32,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 458.753999999999,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.935000000000002,
"layouts": 5,
"layoutDurationMs": 2.235,
"taskDurationMs": 114.292,
"heapDeltaBytes": 4882680,
"heapUsedBytes": 74264848,
"domNodes": 140,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.607999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19342 +/- ##
=============================================
- Coverage 83.90% 83.89% -0.02%
=============================================
Files 2109 2110 +1
Lines 125925 126206 +281
Branches 31963 33889 +1926
=============================================
+ Hits 105662 105877 +215
- Misses 20084 20150 +66
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 5 prior finding(s) across 1 round(s) (5 never answered).
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 5 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment) Addresses #19342 (comment)
|
Updated attachment-history coverage now checks the user turn only, distinguishes display labels from upload references, waits for every staged asset, closes the history-route race, and covers empty |
ryan-di
left a comment
There was a problem hiding this comment.
This is described as a test-only backport of #18247, but commit 241e718 ("test(agent): harden attachment history coverage") also changes parseUserAttachments in agentTranscript.ts. It now falls back to attachment_refs when attachments is [].
- That change isn't on main or the 1.55 branches. #18247 itself only changed the two browser-test files.
- The current cloud backend doesn't write that shape. It leaves out
attachmentswhen it's empty, and buildsattachment_refsfrom the same names. - #18712 has a fuller version of this fix and is labelled for 1.54, so its backport will conflict on these lines.
Could you drop the agentTranscript.ts / agentTranscript.test.ts changes and the "references when filenames are present but empty" E2E scenario, so this stays a plain backport? Please also update the description: it says the PR changes only two browser-test files (it changes 4) and has 4 scenarios (the spec has 5).
This also needs a merge of core/1.54 to pick up the unit-test fixture fix from #19351, which should turn the test check green.
# Conflicts: # src/workbench/extensions/agent/services/agent/agentTranscript.test.ts # src/workbench/extensions/agent/services/agent/agentTranscript.ts
Addresses review feedback: #19342 (review)
|
Addressed Ryan’s review at ec7893a: removed the production transcript fallback, its unit test, and the empty-filenames scenario. The backport is now limited to the original four test scenarios; the description is updated. |
Backport of #18247 to
core/1.54.Cherry-picked merge commit
45750c60bb5b560d67ae037378e6b9e821e7c6d7and resolved the attachment-history E2E conflict using the target branch's panel/output drag convention. Preserves four scenarios: filename-only, filenames plus references, reference-only images, and reference-only image/video across reload and chat switching.Validation:
reply-asset-groupbut lacks main’sreply-image-preview; the helper now uses the stable group contract while retaining exact count, filename, media kind, dimensions, and visibility assertions3f9dbedd8ajsonata,vuefire, older Tiptap packages) and reports unrelated existing source errorsThe initial full-unit failure was unrelated to this test-only diff: 60 failures were isolated to feature-flag, Agent-panel gate, and billing-context suites; this PR is now narrowed to the browser-test files and helper only. The exact
core/1.54base SHA (d66992c565) also fails the same full-unit workflow (baseline run); fresh CI will determine whether a one-time rerun is sufficient.Do not merge until CI is green.