Repository navigation
[backport cloud/1.55] Report approval asks the panel never delivered (#18952) - #19347
Conversation
A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.
- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.
A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.
A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.
**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.
`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.
It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.
Two sites, tagged by `reason` so they split on the dashboard:
| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |
The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.
Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.
**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.
The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.
Run against a cloud dev server plus the e2e ComfyUI container:
```
✘ 1 the approval card reaches the panel after a reconnect (expected)
✘ 2 the user can answer the ask that arrived after the reconnect (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```
Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:
```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```
- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 29fc37b212340792d477e67701828cf89cef2751
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T18:50:22.335Z",
"gitSha": "91e74d902209fb1f288844ace0f46f7e35c4cdbb",
"branch": "backport-18952-to-cloud-1.55-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.1109999999953,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.272999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.667,
"heapDeltaBytes": -7977240,
"heapUsedBytes": 59937964,
"domNodes": -258,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.059000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1991.1859999999706,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.404999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.7540000000001,
"heapDeltaBytes": 2541828,
"heapUsedBytes": 69564112,
"domNodes": -257,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.584,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.5349999999617,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.306,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 789.3,
"heapDeltaBytes": -5003760,
"heapUsedBytes": 62633864,
"domNodes": -257,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 144.775,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.9130000000978,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.122000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.108,
"heapDeltaBytes": -5572424,
"heapUsedBytes": 62341048,
"domNodes": -258,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 147.933,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.6010000000833,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.798000000000002,
"layouts": 6,
"layoutDurationMs": 1.248,
"taskDurationMs": 365.38000000000005,
"heapDeltaBytes": 3100136,
"heapUsedBytes": 70664756,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.889,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.4499999999807,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.467000000000002,
"layouts": 6,
"layoutDurationMs": 0.9919999999999998,
"taskDurationMs": 325.86199999999997,
"heapDeltaBytes": 3089832,
"heapUsedBytes": 70580700,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.967999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 633.4229999999934,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.655000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.93799999999993,
"heapDeltaBytes": 18666432,
"heapUsedBytes": 86341036,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 162.73499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 617.5380000000814,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.297999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.204,
"heapDeltaBytes": 18603260,
"heapUsedBytes": 86258308,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 156.301,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.0760000000328,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 871.48,
"heapDeltaBytes": -17576828,
"heapUsedBytes": 72556432,
"domNodes": -296,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 60.10600000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 522,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.949999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 804.4769999999999,
"heapDeltaBytes": 36117708,
"heapUsedBytes": 104793528,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 67.17200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 531,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0629999999583,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.9230000000002,
"heapDeltaBytes": 14485144,
"heapUsedBytes": 89962552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 139.719,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7439999999015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.33400000000034,
"heapDeltaBytes": 14625080,
"heapUsedBytes": 91041568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 138.44400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9368.634999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8412.248,
"heapDeltaBytes": -8362472,
"heapUsedBytes": 73573240,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 6803.1410000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 198,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8596.732000000087,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7676.044,
"heapDeltaBytes": 18266416,
"heapUsedBytes": 94202344,
"domNodes": -12,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6430.87,
"eventListeners": 0,
"totalBlockingTimeMs": 140,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9314.280999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8521.934,
"heapDeltaBytes": 2150284,
"heapUsedBytes": 84813752,
"domNodes": -20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 6888.122,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9229.108999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8455.630000000001,
"heapDeltaBytes": 2528576,
"heapUsedBytes": 85259048,
"domNodes": -18,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 6845.351999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 265,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2022.815000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.143,
"heapDeltaBytes": -4128444,
"heapUsedBytes": 83039304,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.031000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.3139999999848,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.612,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.84,
"heapDeltaBytes": -3427448,
"heapUsedBytes": 83556428,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.349000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2344.530999999961,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.329,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1666.6950000000002,
"heapDeltaBytes": -10898408,
"heapUsedBytes": 76669868,
"domNodes": -220,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 831.101,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2206.3889999999446,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1581.6039999999998,
"heapDeltaBytes": -7822948,
"heapUsedBytes": 80533076,
"domNodes": -245,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 820.571,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3638.294000000087,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.994,
"layouts": 60,
"layoutDurationMs": 15.237,
"taskDurationMs": 1848.2720000000002,
"heapDeltaBytes": -14997444,
"heapUsedBytes": 74441556,
"domNodes": -254,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 832.748,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3497.229999999945,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.161999999999999,
"layouts": 60,
"layoutDurationMs": 14.283,
"taskDurationMs": 1710.8780000000002,
"heapDeltaBytes": -9188612,
"heapUsedBytes": 73469444,
"domNodes": -254,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 768.619,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3106.563000000051,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.7219999999998,
"heapDeltaBytes": 23578064,
"heapUsedBytes": 89436272,
"domNodes": 4,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 988.207,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2758.9379999999437,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.092000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.4170000000001,
"heapDeltaBytes": 21346840,
"heapUsedBytes": 87454012,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 950.604,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1998.568999999975,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.783000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.336,
"heapDeltaBytes": 20087560,
"heapUsedBytes": 84701956,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.812999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.401000000027,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.5749999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.5469999999999,
"heapDeltaBytes": -5710328,
"heapUsedBytes": 82810056,
"domNodes": -248,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 33.11600000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.8710000000174,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.061000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.481,
"heapDeltaBytes": 13983236,
"heapUsedBytes": 83759252,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.35000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 548.1429999999818,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.449,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.163,
"heapDeltaBytes": 14131676,
"heapUsedBytes": 83855908,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 135.92,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.530999999919,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.095,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.828,
"heapDeltaBytes": 14105624,
"heapUsedBytes": 78201984,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.67,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.9560000000592,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.65,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.138,
"heapDeltaBytes": -4739848,
"heapUsedBytes": 58632372,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.612000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.8479999999226,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.902999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 715.905,
"heapDeltaBytes": 7386588,
"heapUsedBytes": 77242044,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 99.023,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.2120000000032,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.982999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.334,
"heapDeltaBytes": 4133236,
"heapUsedBytes": 74111820,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 98.676,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.5320000000202,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.004999999999995,
"layouts": 5,
"layoutDurationMs": 11.760000000000003,
"taskDurationMs": 864.738,
"heapDeltaBytes": -6327812,
"heapUsedBytes": 81353500,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 27.554999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 123,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8332.873999999947,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5872.744,
"heapDeltaBytes": -6348216,
"heapUsedBytes": 80889084,
"domNodes": -244,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2709.1409999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8252.550999999927,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5456.034,
"heapDeltaBytes": -7218932,
"heapUsedBytes": 80365784,
"domNodes": -242,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2619.009,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17725.555999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17582.963,
"heapDeltaBytes": -16976148,
"heapUsedBytes": 197996972,
"domNodes": -8061,
"jsHeapTotalBytes": -7921664,
"scriptDurationMs": 287.418,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17290.142999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16742.408,
"heapDeltaBytes": -57218064,
"heapUsedBytes": 182690780,
"domNodes": -8061,
"jsHeapTotalBytes": -17207296,
"scriptDurationMs": 264.17199999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22221.980000000032,
"styleRecalcs": 159,
"styleRecalcDurationMs": 23.250999999999966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22118.595999999998,
"heapDeltaBytes": -25164240,
"heapUsedBytes": 189759200,
"domNodes": -8061,
"jsHeapTotalBytes": -14295040,
"scriptDurationMs": 926.9360000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21230.89600000003,
"styleRecalcs": 160,
"styleRecalcDurationMs": 18.66999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20927.801000000003,
"heapDeltaBytes": -70560204,
"heapUsedBytes": 170263908,
"domNodes": -8061,
"jsHeapTotalBytes": -17682432,
"scriptDurationMs": 873.9330000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 114,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5020.704000000023,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.737,
"layouts": 20,
"layoutDurationMs": 25.111000000000008,
"taskDurationMs": 4925.771,
"heapDeltaBytes": -54681344,
"heapUsedBytes": 186780632,
"domNodes": -8061,
"jsHeapTotalBytes": 18411520,
"scriptDurationMs": 101.77799999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 138,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6192.859999999882,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.084,
"layouts": 20,
"layoutDurationMs": 24.85899999999999,
"taskDurationMs": 6109.956999999999,
"heapDeltaBytes": -65124352,
"heapUsedBytes": 176549732,
"domNodes": -8061,
"jsHeapTotalBytes": 12906496,
"scriptDurationMs": 109.404,
"eventListeners": -14928,
"totalBlockingTimeMs": 426,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8968.705999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8841.210000000003,
"heapDeltaBytes": 8437664,
"heapUsedBytes": 184728864,
"domNodes": 0,
"jsHeapTotalBytes": -5505024,
"scriptDurationMs": 143.56100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8766.646000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8505.277000000002,
"heapDeltaBytes": 1380804,
"heapUsedBytes": 193426616,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 130.92899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 473.61100000000533,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.649,
"layouts": 6,
"layoutDurationMs": 2.765,
"taskDurationMs": 140.935,
"heapDeltaBytes": 5360736,
"heapUsedBytes": 71216872,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.497999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 440.2029999998831,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.196999999999996,
"layouts": 3,
"layoutDurationMs": 1.021,
"taskDurationMs": 108.58600000000001,
"heapDeltaBytes": 4904108,
"heapUsedBytes": 70453024,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.742,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🔴 Critical | 1 |
| 🟡 Medium | 3 |
| 🟢 Low | 4 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
| ) | ||
| return false | ||
| } | ||
| dropDraft() |
There was a problem hiding this comment.
🔴 Critical — dropDraft() is called here but is neither declared in this file nor imported — reviewers' repo-wide searches found this call site as the identifier's only occurrence, making it a TS2304 typecheck failure and, on any transpile-only path, a ReferenceError on every run_approval ask. The throw escapes handleAskEvent and ingest into the websocket frame handler, so the approval card never renders even on a healthy socket — the exact dead-panel failure this PR instruments. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| let hydratedMessageIds = new Set<string>() | ||
| let hydratedAssistantTurnIds = new Set<TurnId>() | ||
| const reportedPaywallImpressions = new Set<TurnId>() | ||
| const approvalShownAtByAsk = new Map<string, number>() |
There was a problem hiding this comment.
🟡 Medium — approvalShownAtByAsk (line 89) and shownApprovalIds (line 90) are never read or written anywhere, and reportedPaywallImpressions (line 88) is only .clear()ed in reset() and never populated. Remove all three: the unread ones trip the unused-variable/noUnusedLocals gate, and the two approval-named collections imply an impression-tracking path that does not exist. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).
| eventMessageId === undefined | ||
| ? undefined | ||
| : departedTurns.get(departedTurnKey(eventThreadId, eventMessageId)) | ||
| if (reason) reportUndeliverableAsk(event, reason) |
There was a problem hiding this comment.
🟡 Medium — This reports only when departedTurns already holds the (thread, message) pair, so an ask whose turn was never recorded — one racing the POST acknowledgement and startTurn(), or whose entry was evicted past MAX_DEPARTED_TURNS — is still dropped in silence while the server parks waiting for an answer. That is precisely the stall this telemetry exists to surface; consider reporting any unroutable agent_ask on the current thread rather than only known-departed turns. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
| ): void { | ||
| if (reportedAskIds.has(data.ask_id)) return | ||
| reportedAskIds.add(data.ask_id) | ||
| if (reportedAskIds.size > MAX_REPORTED_ASKS) { |
There was a problem hiding this comment.
🟡 Medium — The 32-entry set bounds memory but not report volume: past 32 distinct ids FIFO eviction lets an old ask report again, and a stream of fresh ask_ids (both ask_id and kind are server-controlled) yields one reportError per ask, each fanning out to Sentry, Datadog and console.warn with no ceiling. A backend rolling out an ask kind this client cannot render would report on every ask in every session — add a total cap or rate limit independent of ask identity. Raised by 3 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).
| * the server parks the turn waiting for an answer, the panel keeps showing | ||
| * whatever it last had, and nothing errors. The only report we have of this | ||
| * class reached us through a feedback form that happened to include a | ||
| * session id, so every `return` that can swallow an ask says so here. |
There was a problem hiding this comment.
🟢 Low — The claim that every return which can swallow an ask reports here does not hold: useAgentSession.onRaw drops an agent_ask that fails parseAgentWsEvent with only a console.warn. A server-side shape change to the loosely-typed ask frame produces the same dead-panel symptom and stays invisible on the dashboard, so either instrument that path too or soften the comment. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| reason: UndeliverableAskReason, | ||
| context: UndeliverableAskContext = {} | ||
| ): void { | ||
| if (reportedAskIds.has(data.ask_id)) return |
There was a problem hiding this comment.
🟢 Low — Dedup is keyed on ask_id alone, so only the first failure mode an ask hits is reported: a redelivered ask (what happens after a reconnect) first reported as unknown-kind has its later no-live-turn or settled-turn drop silently suppressed. Keying on ask_id plus reason keeps each distinct routing defect visible while still reporting once per mode. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| level: 'warning', | ||
| tags: { | ||
| reason, | ||
| ask_kind: data.kind?.slice(0, 64) || 'missing', |
There was a problem hiding this comment.
🟢 Low — data.kind is server-controlled and goes straight into an indexed telemetry tag; the 64-character slice bounds payload size but not cardinality, so unexpected values can inflate Sentry/Datadog tag cardinality and cost. Tag an allowlisted value such as unknown and put the raw kind in the non-indexed context block below. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
| turnLock.push(reconnected, RUN_APPROVAL_EVENT) | ||
| expect(turnLock.pendingAskIsPrimed()).toBe(false) | ||
|
|
||
| test.fail() |
There was a problem hiding this comment.
🟢 Low — test.fail() reports this test green for any failure, not just the socket-drop routing defect it documents — the undefined dropDraft() in handleAskEvent, a feature gate, or a renamed testid would all keep it green while certifying a defect it never exercised. The control test at line 95 is the only thing keeping these two honest; consider asserting the current broken observable state directly instead of a reason-agnostic expected failure. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
| */ | ||
| await page.route('**/api/agent/threads/*/asks/*/answer', (route) => { | ||
| const url = new URL(route.request().url()) | ||
| const segments = url.pathname.split('/').map(decodeURIComponent) |
There was a problem hiding this comment.
⚪ Nit — decodeURIComponent throws URIError on malformed percent-encoding and sits outside the try that guards postDataJSON() below, so the handler would reject without fulfilling and the request hangs until the Playwright timeout. Every other bad input in this route answers with a status code. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19347 +/- ##
=============================================
Coverage ? 84.70%
=============================================
Files ? 2323
Lines ? 132979
Branches ? 35968
=============================================
Hits ? 112637
Misses ? 19990
Partials ? 352
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…19475) ## Summary Follow-up to #19347 (the cloud/1.55 backport for approval prompts surviving reconnects). This carries the review hardening that was omitted when the earlier backport merged. - avoids reporting already-delivered prompts as failures - separates unknown turns, bounds identifiers, and caps reports per session - hashes prompt identity for deduplication and avoids treating `ask_user` as an approval-card delivery failure ## Validation - `pnpm exec vitest run src/workbench/extensions/agent/services/agent/agentEventTransport.test.ts src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts` (98 tests passed)
Manual backport of #18952 (reports approval prompts that the panel drops after a socket disconnect) after the automated cherry-pick reported conflicts. The resolution preserves the release branch active-turn state while adding the telemetry thread identity and unsupported-ask reporting.
Validation: conflict markers and diff checks pass. Focused local tests could not start because the available shared dependency tree does not match this release branch; hosted CI is required.