Skip to content

[backport cloud/1.55] Report approval asks the panel never delivered (#18952) - #19347

Merged
christian-byrne merged 3 commits into
cloud/1.55from
backport-18952-to-cloud-1.55-manual
Sep 29, 2026
Merged

christian-byrne merged 3 commits into
cloud/1.55from
backport-18952-to-cloud-1.55-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual backport of #18952 (reports approval prompts that the panel drops after a socket disconnect) after the automated cherry-pick reported conflicts. The resolution preserves the release branch active-turn state while adding the telemetry thread identity and unsupported-ask reporting.

Validation: conflict markers and diff checks pass. Focused local tests could not start because the available shared dependency tree does not match this release branch; hosted CI is required.

A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.

- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.

A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.

A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.

**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.

`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.

It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.

Two sites, tagged by `reason` so they split on the dashboard:

| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |

The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.

Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.

**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.

The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.

Run against a cloud dev server plus the e2e ComfyUI container:

```
✘ 1 the approval card reaches the panel after a reconnect          (expected)
✘ 2 the user can answer the ask that arrived after the reconnect   (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```

Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:

```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```

- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 484d9157-272a-4733-864a-efca4ec9ff85

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 29fc37b212340792d477e67701828cf89cef2751

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2100 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 06:43:28 PM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 527ms TBT · 84.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 225ms TBT · 86.3 MB heap
extension-clean-combined-draw: · 55.4 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 169ms TBT · 80.0 MB heap
extension-rgthree-prototype-draw: · 55.4 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 241ms TBT · 81.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 123ms TBT · 77.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 181.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 106ms TBT · 171.7 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 282ms TBT · 173.2 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 180.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 12
canvas-idle: task duration 461ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.8 MB
canvas-idle: DOM nodes -258
canvas-idle: event listeners -163
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 47
canvas-mouse-sweep: task duration 799ms
canvas-mouse-sweep: script duration 146ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.6 MB
canvas-mouse-sweep: DOM nodes -258
canvas-mouse-sweep: event listeners -174
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 346ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.4 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 13
dom-widget-clipping: task duration 440ms
dom-widget-clipping: script duration 160ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.3 MB
dom-widget-clipping: DOM nodes 21
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 838ms
dom-widget-order-dense-n200-w200-i120: script duration 64ms
dom-widget-order-dense-n200-w200-i120: TBT 527ms
dom-widget-order-dense-n200-w200-i120: heap used 84.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -148
dom-widget-order-dense-n200-w200-i120: event listeners -109
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 463ms
dom-widget-order-sparse-n1000-w20-i120: script duration 139ms
dom-widget-order-sparse-n1000-w20-i120: TBT 225ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.3 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 18ms
extension-clean-combined-draw: p95 frame time 33ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 8044ms
extension-clean-combined-draw: script duration 6617ms
extension-clean-combined-draw: TBT 169ms
extension-clean-combined-draw: heap used 80.0 MB
extension-clean-combined-draw: DOM nodes -12
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 18ms
extension-rgthree-prototype-draw: p95 frame time 33ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 8489ms
extension-rgthree-prototype-draw: script duration 6867ms
extension-rgthree-prototype-draw: TBT 241ms
extension-rgthree-prototype-draw: heap used 81.1 MB
extension-rgthree-prototype-draw: DOM nodes -19
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 522ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.4 MB
large-graph-idle: DOM nodes -241
large-graph-idle: event listeners -152
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1624ms
large-graph-pan: script duration 826ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.0 MB
large-graph-pan: DOM nodes -233
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 15ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1780ms
large-graph-zoom: script duration 801ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.5 MB
large-graph-zoom: DOM nodes -254
large-graph-zoom: event listeners -174
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 1808ms
legacy-node-drag: script duration 969ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.3 MB
legacy-node-drag: DOM nodes 6
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 587ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 79.9 MB
minimap-idle: DOM nodes -120
minimap-idle: event listeners -87
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 403ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.9 MB
subgraph-dom-widget-clipping: DOM nodes 22
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 452ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.2 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -209
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 15ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 46
subgraph-mouse-sweep: task duration 718ms
subgraph-mouse-sweep: script duration 99ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 72.2 MB
subgraph-mouse-sweep: DOM nodes -275
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 865ms
subgraph-transition-enter: script duration 28ms
subgraph-transition-enter: TBT 123ms
subgraph-transition-enter: heap used 77.6 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5664ms
viewport-pan-sweep: script duration 2664ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.9 MB
viewport-pan-sweep: DOM nodes -243
viewport-pan-sweep: event listeners -163
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17163ms
vue-large-graph-idle: script duration 276ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 181.5 MB
vue-large-graph-idle: DOM nodes -8061
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 21ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 160
vue-large-graph-pan: task duration 21523ms
vue-large-graph-pan: script duration 900ms
vue-large-graph-pan: TBT 106ms
vue-large-graph-pan: heap used 171.7 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 73ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5518ms
vue-node-resize-workload: script duration 106ms
vue-node-resize-workload: TBT 282ms
vue-node-resize-workload: heap used 173.2 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8673ms
vue-zoom-out-idle: script duration 137ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 180.3 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 25ms
workflow-execution: layout count 5
workflow-execution: style recalc count 18
workflow-execution: task duration 125ms
workflow-execution: script duration 13ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.6 MB
workflow-execution: DOM nodes 140
workflow-execution: event listeners 81
Raw data
{
  "timestamp": "2026-09-29T18:50:22.335Z",
  "gitSha": "91e74d902209fb1f288844ace0f46f7e35c4cdbb",
  "branch": "backport-18952-to-cloud-1.55-manual",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2022.1109999999953,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.272999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.667,
      "heapDeltaBytes": -7977240,
      "heapUsedBytes": 59937964,
      "domNodes": -258,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.059000000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 1991.1859999999706,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.404999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.7540000000001,
      "heapDeltaBytes": 2541828,
      "heapUsedBytes": 69564112,
      "domNodes": -257,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.584,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1757.5349999999617,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 15.306,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 789.3,
      "heapDeltaBytes": -5003760,
      "heapUsedBytes": 62633864,
      "domNodes": -257,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 144.775,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1783.9130000000978,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 15.122000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 809.108,
      "heapDeltaBytes": -5572424,
      "heapUsedBytes": 62341048,
      "domNodes": -258,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 147.933,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.6010000000833,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.798000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.248,
      "taskDurationMs": 365.38000000000005,
      "heapDeltaBytes": 3100136,
      "heapUsedBytes": 70664756,
      "domNodes": 80,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.889,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.4499999999807,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.467000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.9919999999999998,
      "taskDurationMs": 325.86199999999997,
      "heapDeltaBytes": 3089832,
      "heapUsedBytes": 70580700,
      "domNodes": 78,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.967999999999998,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 633.4229999999934,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.655000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.93799999999993,
      "heapDeltaBytes": 18666432,
      "heapUsedBytes": 86341036,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 162.73499999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 617.5380000000814,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.297999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.204,
      "heapDeltaBytes": 18603260,
      "heapUsedBytes": 86258308,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 156.301,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1178.0760000000328,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 871.48,
      "heapDeltaBytes": -17576828,
      "heapUsedBytes": 72556432,
      "domNodes": -296,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 60.10600000000001,
      "eventListeners": -217,
      "totalBlockingTimeMs": 522,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1146.949999999947,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 804.4769999999999,
      "heapDeltaBytes": 36117708,
      "heapUsedBytes": 104793528,
      "domNodes": 0,
      "jsHeapTotalBytes": 18509824,
      "scriptDurationMs": 67.17200000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 531,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 846.0629999999583,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.9230000000002,
      "heapDeltaBytes": 14485144,
      "heapUsedBytes": 89962552,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 139.719,
      "eventListeners": 0,
      "totalBlockingTimeMs": 223,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 843.7439999999015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.33400000000034,
      "heapDeltaBytes": 14625080,
      "heapUsedBytes": 91041568,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 138.44400000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 226,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9368.634999999926,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8412.248,
      "heapDeltaBytes": -8362472,
      "heapUsedBytes": 73573240,
      "domNodes": -12,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 6803.1410000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 198,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 8596.732000000087,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7676.044,
      "heapDeltaBytes": 18266416,
      "heapUsedBytes": 94202344,
      "domNodes": -12,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 6430.87,
      "eventListeners": 0,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 18.329999999999988,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9314.280999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8521.934,
      "heapDeltaBytes": 2150284,
      "heapUsedBytes": 84813752,
      "domNodes": -20,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 6888.122,
      "eventListeners": 0,
      "totalBlockingTimeMs": 216,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 33.30000000000109
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9229.108999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8455.630000000001,
      "heapDeltaBytes": 2528576,
      "heapUsedBytes": 85259048,
      "domNodes": -18,
      "jsHeapTotalBytes": 9699328,
      "scriptDurationMs": 6845.351999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 265,
      "frameDurationMs": 18.33666666666662,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.815000000037,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.143,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.143,
      "heapDeltaBytes": -4128444,
      "heapUsedBytes": 83039304,
      "domNodes": -240,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 33.031000000000006,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2020.3139999999848,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.612,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.84,
      "heapDeltaBytes": -3427448,
      "heapUsedBytes": 83556428,
      "domNodes": -242,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 34.349000000000004,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2344.530999999961,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 16.329,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1666.6950000000002,
      "heapDeltaBytes": -10898408,
      "heapUsedBytes": 76669868,
      "domNodes": -220,
      "jsHeapTotalBytes": 2088960,
      "scriptDurationMs": 831.101,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2206.3889999999446,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.051,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1581.6039999999998,
      "heapDeltaBytes": -7822948,
      "heapUsedBytes": 80533076,
      "domNodes": -245,
      "jsHeapTotalBytes": 253952,
      "scriptDurationMs": 820.571,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3638.294000000087,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.994,
      "layouts": 60,
      "layoutDurationMs": 15.237,
      "taskDurationMs": 1848.2720000000002,
      "heapDeltaBytes": -14997444,
      "heapUsedBytes": 74441556,
      "domNodes": -254,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 832.748,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3497.229999999945,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.161999999999999,
      "layouts": 60,
      "layoutDurationMs": 14.283,
      "taskDurationMs": 1710.8780000000002,
      "heapDeltaBytes": -9188612,
      "heapUsedBytes": 73469444,
      "domNodes": -254,
      "jsHeapTotalBytes": -532480,
      "scriptDurationMs": 768.619,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3106.563000000051,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 7.236,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1926.7219999999998,
      "heapDeltaBytes": 23578064,
      "heapUsedBytes": 89436272,
      "domNodes": 4,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 988.207,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2758.9379999999437,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.092000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1689.4170000000001,
      "heapDeltaBytes": 21346840,
      "heapUsedBytes": 87454012,
      "domNodes": 8,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 950.604,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 1998.568999999975,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 2.783000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 590.336,
      "heapDeltaBytes": 20087560,
      "heapUsedBytes": 84701956,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.812999999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2057.401000000027,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.5749999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.5469999999999,
      "heapDeltaBytes": -5710328,
      "heapUsedBytes": 82810056,
      "domNodes": -248,
      "jsHeapTotalBytes": 290816,
      "scriptDurationMs": 33.11600000000001,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 613.8710000000174,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.061000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.481,
      "heapDeltaBytes": 13983236,
      "heapUsedBytes": 83759252,
      "domNodes": 21,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 150.35000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 548.1429999999818,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.449,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.163,
      "heapDeltaBytes": 14131676,
      "heapUsedBytes": 83855908,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 135.92,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.530999999919,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.095,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.828,
      "heapDeltaBytes": 14105624,
      "heapUsedBytes": 78201984,
      "domNodes": -274,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.67,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.9560000000592,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.65,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.138,
      "heapDeltaBytes": -4739848,
      "heapUsedBytes": 58632372,
      "domNodes": -275,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 7.612000000000001,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1706.8479999999226,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.902999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 715.905,
      "heapDeltaBytes": 7386588,
      "heapUsedBytes": 77242044,
      "domNodes": -275,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 99.023,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1708.2120000000032,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 14.982999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 720.334,
      "heapDeltaBytes": 4133236,
      "heapUsedBytes": 74111820,
      "domNodes": -275,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 98.676,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1351.5320000000202,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 27.004999999999995,
      "layouts": 5,
      "layoutDurationMs": 11.760000000000003,
      "taskDurationMs": 864.738,
      "heapDeltaBytes": -6327812,
      "heapUsedBytes": 81353500,
      "domNodes": 13667,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 27.554999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 123,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8332.873999999947,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.158,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5872.744,
      "heapDeltaBytes": -6348216,
      "heapUsedBytes": 80889084,
      "domNodes": -244,
      "jsHeapTotalBytes": 516096,
      "scriptDurationMs": 2709.1409999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8252.550999999927,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 39,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5456.034,
      "heapDeltaBytes": -7218932,
      "heapUsedBytes": 80365784,
      "domNodes": -242,
      "jsHeapTotalBytes": 745472,
      "scriptDurationMs": 2619.009,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17725.555999999982,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17582.963,
      "heapDeltaBytes": -16976148,
      "heapUsedBytes": 197996972,
      "domNodes": -8061,
      "jsHeapTotalBytes": -7921664,
      "scriptDurationMs": 287.418,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17290.142999999945,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16742.408,
      "heapDeltaBytes": -57218064,
      "heapUsedBytes": 182690780,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17207296,
      "scriptDurationMs": 264.17199999999997,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22221.980000000032,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 23.250999999999966,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22118.595999999998,
      "heapDeltaBytes": -25164240,
      "heapUsedBytes": 189759200,
      "domNodes": -8061,
      "jsHeapTotalBytes": -14295040,
      "scriptDurationMs": 926.9360000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 98,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21230.89600000003,
      "styleRecalcs": 160,
      "styleRecalcDurationMs": 18.66999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20927.801000000003,
      "heapDeltaBytes": -70560204,
      "heapUsedBytes": 170263908,
      "domNodes": -8061,
      "jsHeapTotalBytes": -17682432,
      "scriptDurationMs": 873.9330000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 114,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5020.704000000023,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.737,
      "layouts": 20,
      "layoutDurationMs": 25.111000000000008,
      "taskDurationMs": 4925.771,
      "heapDeltaBytes": -54681344,
      "heapUsedBytes": 186780632,
      "domNodes": -8061,
      "jsHeapTotalBytes": 18411520,
      "scriptDurationMs": 101.77799999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6192.859999999882,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.084,
      "layouts": 20,
      "layoutDurationMs": 24.85899999999999,
      "taskDurationMs": 6109.956999999999,
      "heapDeltaBytes": -65124352,
      "heapUsedBytes": 176549732,
      "domNodes": -8061,
      "jsHeapTotalBytes": 12906496,
      "scriptDurationMs": 109.404,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 426,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8968.705999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8841.210000000003,
      "heapDeltaBytes": 8437664,
      "heapUsedBytes": 184728864,
      "domNodes": 0,
      "jsHeapTotalBytes": -5505024,
      "scriptDurationMs": 143.56100000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8766.646000000037,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8505.277000000002,
      "heapDeltaBytes": 1380804,
      "heapUsedBytes": 193426616,
      "domNodes": 0,
      "jsHeapTotalBytes": -9437184,
      "scriptDurationMs": 130.92899999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 473.61100000000533,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 28.649,
      "layouts": 6,
      "layoutDurationMs": 2.765,
      "taskDurationMs": 140.935,
      "heapDeltaBytes": 5360736,
      "heapUsedBytes": 71216872,
      "domNodes": 155,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 15.497999999999998,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 440.2029999998831,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 21.196999999999996,
      "layouts": 3,
      "layoutDurationMs": 1.021,
      "taskDurationMs": 108.58600000000001,
      "heapDeltaBytes": 4904108,
      "heapUsedBytes": 70453024,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.742,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52425 79368 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.8% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/scripts/pnginfo.ts 20.8% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@datadog-official

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 9 finding(s).

Severity Count
🔴 Critical 1
🟡 Medium 3
🟢 Low 4
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

)
return false
}
dropDraft()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — dropDraft() is called here but is neither declared in this file nor imported — reviewers' repo-wide searches found this call site as the identifier's only occurrence, making it a TS2304 typecheck failure and, on any transpile-only path, a ReferenceError on every run_approval ask. The throw escapes handleAskEvent and ingest into the websocket frame handler, so the approval card never renders even on a healthy socket — the exact dead-panel failure this PR instruments. Raised by 6 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

let hydratedMessageIds = new Set<string>()
let hydratedAssistantTurnIds = new Set<TurnId>()
const reportedPaywallImpressions = new Set<TurnId>()
const approvalShownAtByAsk = new Map<string, number>()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — approvalShownAtByAsk (line 89) and shownApprovalIds (line 90) are never read or written anywhere, and reportedPaywallImpressions (line 88) is only .clear()ed in reset() and never populated. Remove all three: the unread ones trip the unused-variable/noUnusedLocals gate, and the two approval-named collections imply an impression-tracking path that does not exist. Raised by 6 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, kimi-k3-max edge-case).

eventMessageId === undefined
? undefined
: departedTurns.get(departedTurnKey(eventThreadId, eventMessageId))
if (reason) reportUndeliverableAsk(event, reason)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — This reports only when departedTurns already holds the (thread, message) pair, so an ask whose turn was never recorded — one racing the POST acknowledgement and startTurn(), or whose entry was evicted past MAX_DEPARTED_TURNS — is still dropped in silence while the server parks waiting for an answer. That is precisely the stall this telemetry exists to surface; consider reporting any unroutable agent_ask on the current thread rather than only known-departed turns. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).

): void {
if (reportedAskIds.has(data.ask_id)) return
reportedAskIds.add(data.ask_id)
if (reportedAskIds.size > MAX_REPORTED_ASKS) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The 32-entry set bounds memory but not report volume: past 32 distinct ids FIFO eviction lets an old ask report again, and a stream of fresh ask_ids (both ask_id and kind are server-controlled) yields one reportError per ask, each fanning out to Sentry, Datadog and console.warn with no ceiling. A backend rolling out an ask kind this client cannot render would report on every ask in every session — add a total cap or rate limit independent of ask identity. Raised by 3 of 8 reviewers (gemini-3.1-pro adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial).

* the server parks the turn waiting for an answer, the panel keeps showing
* whatever it last had, and nothing errors. The only report we have of this
* class reached us through a feedback form that happened to include a
* session id, so every `return` that can swallow an ask says so here.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The claim that every return which can swallow an ask reports here does not hold: useAgentSession.onRaw drops an agent_ask that fails parseAgentWsEvent with only a console.warn. A server-side shape change to the loosely-typed ask frame produces the same dead-panel symptom and stays invisible on the dashboard, so either instrument that path too or soften the comment. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

reason: UndeliverableAskReason,
context: UndeliverableAskContext = {}
): void {
if (reportedAskIds.has(data.ask_id)) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Dedup is keyed on ask_id alone, so only the first failure mode an ask hits is reported: a redelivered ask (what happens after a reconnect) first reported as unknown-kind has its later no-live-turn or settled-turn drop silently suppressed. Keying on ask_id plus reason keeps each distinct routing defect visible while still reporting once per mode. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

level: 'warning',
tags: {
reason,
ask_kind: data.kind?.slice(0, 64) || 'missing',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — data.kind is server-controlled and goes straight into an indexed telemetry tag; the 64-character slice bounds payload size but not cardinality, so unexpected values can inflate Sentry/Datadog tag cardinality and cost. Tag an allowlisted value such as unknown and put the raw kind in the non-indexed context block below. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).

turnLock.push(reconnected, RUN_APPROVAL_EVENT)
expect(turnLock.pendingAskIsPrimed()).toBe(false)

test.fail()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — test.fail() reports this test green for any failure, not just the socket-drop routing defect it documents — the undefined dropDraft() in handleAskEvent, a feature gate, or a renamed testid would all keep it green while certifying a defect it never exercised. The control test at line 95 is the only thing keeping these two honest; consider asserting the current broken observable state directly instead of a reason-agnostic expected failure. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

*/
await page.route('**/api/agent/threads/*/asks/*/answer', (route) => {
const url = new URL(route.request().url())
const segments = url.pathname.split('/').map(decodeURIComponent)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — decodeURIComponent throws URIError on malformed percent-encoding and sits outside the try that guards postDataJSON() below, so the handler would reject without fulfilling and the request hangs until the Playwright timeout. Every other bad input in this route answers with a status code. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 93.47% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #19347   +/-   ##
=============================================
  Coverage              ?   84.70%           
=============================================
  Files                 ?     2323           
  Lines                 ?   132979           
  Branches              ?    35968           
=============================================
  Hits                  ?   112637           
  Misses                ?    19990           
  Partials              ?      352           
Flag Coverage Δ
e2e 66.05% <ø> (?)
unit 80.67% <95.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
...s/agent/services/agent/undeliverableAskReporter.ts 100.00% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 97.46% <93.47%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit d906e62 into cloud/1.55 Sep 29, 2026
104 checks passed
@christian-byrne
christian-byrne deleted the backport-18952-to-cloud-1.55-manual branch September 29, 2026 20:13
christian-byrne added a commit that referenced this pull request Sep 29, 2026
…19475)

## Summary

Follow-up to #19347 (the cloud/1.55 backport for approval prompts
surviving reconnects). This carries the review hardening that was
omitted when the earlier backport merged.

- avoids reporting already-delivered prompts as failures
- separates unknown turns, bounds identifiers, and caps reports per
session
- hashes prompt identity for deduplication and avoids treating
`ask_user` as an approval-card delivery failure

## Validation

- `pnpm exec vitest run
src/workbench/extensions/agent/services/agent/agentEventTransport.test.ts
src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts`
(98 tests passed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants