Repository navigation
[backport cloud/1.55] Report approval asks the panel cannot deliver (#18952) - #19336
christian-byrne wants to merge 3 commits into
Conversation
A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.
- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.
A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.
A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.
**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.
`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.
It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.
Two sites, tagged by `reason` so they split on the dashboard:
| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |
The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.
Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.
**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.
The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.
Run against a cloud dev server plus the e2e ComfyUI container:
```
✘ 1 the approval card reaches the panel after a reconnect (expected)
✘ 2 the user can answer the ask that arrived after the reconnect (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```
Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:
```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```
- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
(cherry picked from commit 8223a93)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a52d4540a02ef16839b4daf6194413241174fde
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T07:39:31.379Z",
"gitSha": "c2d0d01e53e2b842f77db20467359d35f2016607",
"branch": "cbyrne/backport-18952-cloud-155",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.4590000000067,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.086000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.653,
"heapDeltaBytes": 8100488,
"heapUsedBytes": 75742896,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.641,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2022.3760000000084,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.812000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.196,
"heapDeltaBytes": -3446800,
"heapUsedBytes": 64222284,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.831999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.5679999999784,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.636000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.008,
"heapDeltaBytes": -4190632,
"heapUsedBytes": 63495320,
"domNodes": -260,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.61999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1752.083999999968,
"styleRecalcs": 44,
"styleRecalcDurationMs": 12.775000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.266,
"heapDeltaBytes": 11928348,
"heapUsedBytes": 79476664,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 156.577,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.3600000000238,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.322,
"layouts": 6,
"layoutDurationMs": 1.2429999999999999,
"taskDurationMs": 376.517,
"heapDeltaBytes": 3147548,
"heapUsedBytes": 70636824,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.955999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.3849999999074,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.596,
"layouts": 6,
"layoutDurationMs": 1.0890000000000002,
"taskDurationMs": 343.30499999999995,
"heapDeltaBytes": 3136584,
"heapUsedBytes": 70541388,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.941999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.2350000000038,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.103,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.096,
"heapDeltaBytes": 18526152,
"heapUsedBytes": 86457656,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 168.92200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.7089999999871,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.523999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.42499999999995,
"heapDeltaBytes": 18804696,
"heapUsedBytes": 86784976,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.53,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.7340000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 845.4649999999999,
"heapDeltaBytes": 34420880,
"heapUsedBytes": 105936644,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 76.556,
"eventListeners": 0,
"totalBlockingTimeMs": 562,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1189.0710000000126,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.474,
"heapDeltaBytes": 38526128,
"heapUsedBytes": 107856112,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 70.186,
"eventListeners": 0,
"totalBlockingTimeMs": 580,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.3349999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.6530000000001,
"heapDeltaBytes": 15023596,
"heapUsedBytes": 90204788,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.83900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 233,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.3250000000598,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.61500000000024,
"heapDeltaBytes": 14966728,
"heapUsedBytes": 91737284,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.39899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 246,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11180.78700000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10243.952,
"heapDeltaBytes": -1775844,
"heapUsedBytes": 80359328,
"domNodes": -14,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8443.877,
"eventListeners": 0,
"totalBlockingTimeMs": 1454,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10486.45799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9616.73,
"heapDeltaBytes": -13968668,
"heapUsedBytes": 68287388,
"domNodes": -16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7886.412,
"eventListeners": 0,
"totalBlockingTimeMs": 1240,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10577.241000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9753.154,
"heapDeltaBytes": 18418364,
"heapUsedBytes": 93267832,
"domNodes": -4,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8097.2390000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 1277,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11323.677999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10469.768,
"heapDeltaBytes": 11565332,
"heapUsedBytes": 93419532,
"domNodes": -14,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 8701.859,
"eventListeners": 0,
"totalBlockingTimeMs": 1657,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2035.2410000000418,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.7780000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.214,
"heapDeltaBytes": -3432356,
"heapUsedBytes": 83484756,
"domNodes": -241,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.928,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.7630000000408,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.725999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.04,
"heapDeltaBytes": -2869684,
"heapUsedBytes": 84013396,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 37.01700000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2394.8049999999625,
"styleRecalcs": 70,
"styleRecalcDurationMs": 15.267,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1764.503,
"heapDeltaBytes": -19353908,
"heapUsedBytes": 68705304,
"domNodes": -223,
"jsHeapTotalBytes": 2125824,
"scriptDurationMs": 896.31,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2177.701999999954,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.052000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1475.6509999999998,
"heapDeltaBytes": 11709488,
"heapUsedBytes": 75811768,
"domNodes": -243,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 860.8,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3582.5810000000047,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.378999999999996,
"layouts": 60,
"layoutDurationMs": 13.331,
"taskDurationMs": 1731.096,
"heapDeltaBytes": 11331432,
"heapUsedBytes": 76448272,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 841.324,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3621.346000000017,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.992000000000003,
"layouts": 60,
"layoutDurationMs": 13.479000000000001,
"taskDurationMs": 1726.8969999999997,
"heapDeltaBytes": 9870316,
"heapUsedBytes": 74977756,
"domNodes": -253,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 803.158,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3118.8040000000115,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.831999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1929.2119999999998,
"heapDeltaBytes": 25201704,
"heapUsedBytes": 91351772,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1000.8140000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3122.4660000000313,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.697000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1957.185,
"heapDeltaBytes": 23288072,
"heapUsedBytes": 89399628,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 998.348,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.8209999999317,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.067,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.5310000000001,
"heapDeltaBytes": 20600896,
"heapUsedBytes": 84970932,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.926,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2007.5380000000678,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.8410000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.052,
"heapDeltaBytes": 20235980,
"heapUsedBytes": 84653248,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.245,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.2250000000126,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.651000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.07099999999997,
"heapDeltaBytes": 13785048,
"heapUsedBytes": 83666716,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.71699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.243000000024,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.166,
"heapDeltaBytes": 13781168,
"heapUsedBytes": 83520860,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.816,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1990.1679999999828,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.744000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.005,
"heapDeltaBytes": 9917176,
"heapUsedBytes": 79655220,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.8210000000000015,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.1370000000143,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.997999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.93500000000006,
"heapDeltaBytes": -14494912,
"heapUsedBytes": 55331636,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.872,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.0319999999838,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.921,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.517,
"heapDeltaBytes": 2927676,
"heapUsedBytes": 72785560,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 106.472,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.4990000000134,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.543000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 710.82,
"heapDeltaBytes": 8833008,
"heapUsedBytes": 78336792,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 103.918,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.8010000000013,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.423000000000005,
"layouts": 5,
"layoutDurationMs": 13.460999999999997,
"taskDurationMs": 965.303,
"heapDeltaBytes": 20269076,
"heapUsedBytes": 104458380,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.942,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8374.363000000016,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.59899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5831.973,
"heapDeltaBytes": -6453384,
"heapUsedBytes": 80493852,
"domNodes": -245,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2838.5220000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8500.325999999972,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.788999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5937.32,
"heapDeltaBytes": -2553796,
"heapUsedBytes": 84396136,
"domNodes": -242,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 2902.993,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17284.68499999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16906.506,
"heapDeltaBytes": -48625976,
"heapUsedBytes": 178763424,
"domNodes": -8061,
"jsHeapTotalBytes": -13438976,
"scriptDurationMs": 284.226,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17394.71800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16980.486,
"heapDeltaBytes": -59830596,
"heapUsedBytes": 181278240,
"domNodes": -8065,
"jsHeapTotalBytes": -20676608,
"scriptDurationMs": 310.414,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20807.942000000025,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.646000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20526.257,
"heapDeltaBytes": -33781204,
"heapUsedBytes": 191836120,
"domNodes": -8061,
"jsHeapTotalBytes": -15020032,
"scriptDurationMs": 913.1940000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20560.543000000052,
"styleRecalcs": 163,
"styleRecalcDurationMs": 17.954000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20313.438,
"heapDeltaBytes": -21386736,
"heapUsedBytes": 192145544,
"domNodes": -8061,
"jsHeapTotalBytes": -9564160,
"scriptDurationMs": 909.919,
"eventListeners": -14928,
"totalBlockingTimeMs": 114,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4693.619000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.838,
"layouts": 20,
"layoutDurationMs": 24.016999999999996,
"taskDurationMs": 4543.717000000001,
"heapDeltaBytes": -56018692,
"heapUsedBytes": 185220540,
"domNodes": -8061,
"jsHeapTotalBytes": 15527936,
"scriptDurationMs": 89.40100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5984.258999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.045,
"layouts": 20,
"layoutDurationMs": 22.548,
"taskDurationMs": 5918.078,
"heapDeltaBytes": -40794616,
"heapUsedBytes": 184733372,
"domNodes": -8061,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 105.48599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 361,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8406.109000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8258.315,
"heapDeltaBytes": 8356276,
"heapUsedBytes": 184276256,
"domNodes": 0,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 132.68199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8644.898000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8397.116999999998,
"heapDeltaBytes": -233288,
"heapUsedBytes": 183071480,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 136.463,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 110.8960000000252,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.474,
"layouts": 2,
"layoutDurationMs": 0.552,
"taskDurationMs": 86.10800000000002,
"heapDeltaBytes": 3222180,
"heapUsedBytes": 69118408,
"domNodes": 109,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.120000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 101.6540000000532,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.893,
"layouts": 3,
"layoutDurationMs": 1.6129999999999998,
"taskDurationMs": 74.581,
"heapDeltaBytes": 3004844,
"heapUsedBytes": 68502348,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.666999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19336 +/- ##
=============================================
Coverage ? 84.70%
=============================================
Files ? 2323
Lines ? 132891
Branches ? 35936
=============================================
Hits ? 112568
Misses ? 19971
Partials ? 352
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Superseded by merged #19347. Closing to avoid applying the same cloud/1.55 telemetry backport twice. |
Summary
Backports #18952 (source merge
8223a93de30cd630338924e923e2f6fe9bb9d6e6) tocloud/1.55after the automatic carrier failed with conflicts inagentEventTransport.tsandagentConversationStore.ts.The carrier preserves the release branch's transport shape while adding the source telemetry contract: a bounded ask-ID dedupe ledger, discriminating
no-live-turn/settled-turn/unknown-kind/unrendered-kindreasons, and retained departed-turn identity. All sourcebrowser_tests/hunks are carried: the fixture expansion andagentApprovalSurvivesSocketDrop.spec.ts.Conflict resolution
agentEventTransport.ts: retained the release branch, which has no main-onlyagent_message_draftlifecycle, and applied only fix(agent): report an approval ask the panel never delivered #18952's reporter injection, unrendered-kind reporting, and settled-turn reporting.agentConversationStore.ts: retained the release branch's absence of main-only approval timing/paywall-impression state and applied fix(agent): report an approval ask the panel never delivered #18952's reporter, active-thread identity, departed-turn ledger, routing, reset, and hydrate behavior.browser_tests/files, applied cleanly.Verification
reportedAskIds.add(data.ask_id)madededupes one ask across the transport and store routing pathsfail with 2 reports instead of 1; restored with a clean tree.agentApprovalSurvivesSocketDrop.spec.ts). The first two remain intentionaltest.fail()pins for fix(agent): keep the turn live across a socket reconnect and reconcile from REST (PM-1199) #18152; the live-socket control passed.git diff --checkpassed; no AI co-author trailer.Merge conditions
Do not merge until hosted checks and review threads are terminal, and the target-aware exact-head gate passes against the unchanged carrier and live
cloud/1.55tip.