Skip to content

[backport cloud/1.55] Report approval asks the panel cannot deliver (#18952) - #19336

Closed
christian-byrne wants to merge 3 commits into
cloud/1.55from
cbyrne/backport-18952-cloud-155
Closed

christian-byrne wants to merge 3 commits into
cloud/1.55from
cbyrne/backport-18952-cloud-155

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Backports #18952 (source merge 8223a93de30cd630338924e923e2f6fe9bb9d6e6) to cloud/1.55 after the automatic carrier failed with conflicts in agentEventTransport.ts and agentConversationStore.ts.

The carrier preserves the release branch's transport shape while adding the source telemetry contract: a bounded ask-ID dedupe ledger, discriminating no-live-turn / settled-turn / unknown-kind / unrendered-kind reasons, and retained departed-turn identity. All source browser_tests/ hunks are carried: the fixture expansion and agentApprovalSurvivesSocketDrop.spec.ts.

Conflict resolution

Verification

  • Focused target-native vitest: 96/96 passed.
  • Discriminating mutation: removing reportedAskIds.add(data.ask_id) made dedupes one ask across the transport and store routing paths fail with 2 reports instead of 1; restored with a clean tree.
  • Required cloud Playwright spec: 3/3 passed using an isolated ComfyUI devtools backend and cloud dev server (agentApprovalSurvivesSocketDrop.spec.ts). The first two remain intentional test.fail() pins for fix(agent): keep the turn live across a socket reconnect and reconcile from REST (PM-1199) #18152; the live-socket control passed.
  • Full workspace typecheck passed (app, account-core, billing-web, account-ui, billing-contract).
  • git diff --check passed; no AI co-author trailer.

Merge conditions

Do not merge until hosted checks and review threads are terminal, and the target-aware exact-head gate passes against the unchanged carrier and live cloud/1.55 tip.

A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.

- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.

A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.

A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.

**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.

`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.

It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.

Two sites, tagged by `reason` so they split on the dashboard:

| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |

The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.

Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.

**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.

The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.

Run against a cloud dev server plus the e2e ComfyUI container:

```
✘ 1 the approval card reaches the panel after a reconnect          (expected)
✘ 2 the user can answer the ask that arrived after the reconnect   (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```

Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:

```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```

- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.

(cherry picked from commit 8223a93)
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 1f240b13-f6de-454c-8541-38e9255ef518

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added agent-backport Agent changes targeting a stable cloud/core release branch cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 29, 2026
@github-actions
github-actions Bot requested a review from ryan-di September 29, 2026 03:10
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 3a52d4540a02ef16839b4daf6194413241174fde

Full docs: ADR-DEVEX-LINT-0015

🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2100 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 07:31:31 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
dom-widget-order-dense-n200-w200-i120: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 571ms TBT · 101.9 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 240ms TBT · 86.8 MB heap
extension-clean-combined-draw: · 51.4 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1347ms TBT · 70.9 MB heap
extension-rgthree-prototype-draw: · 52.9 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 1467ms TBT · 89.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 140ms TBT · 99.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 74ms TBT · 183.1 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 259ms TBT · 176.4 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 175.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 476ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.7 MB
canvas-idle: DOM nodes -261
canvas-idle: event listeners -163
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 0ms
canvas-mouse-sweep: style recalc duration 15ms
canvas-mouse-sweep: layout count 0
canvas-mouse-sweep: style recalc count 45
canvas-mouse-sweep: task duration 798ms
canvas-mouse-sweep: script duration 160ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.2 MB
canvas-mouse-sweep: DOM nodes -261
canvas-mouse-sweep: event listeners -163
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 360ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.3 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 447ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 82.6 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 17ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 852ms
dom-widget-order-dense-n200-w200-i120: script duration 73ms
dom-widget-order-dense-n200-w200-i120: TBT 571ms
dom-widget-order-dense-n200-w200-i120: heap used 101.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 475ms
dom-widget-order-sparse-n1000-w20-i120: script duration 172ms
dom-widget-order-sparse-n1000-w20-i120: TBT 240ms
dom-widget-order-sparse-n1000-w20-i120: heap used 86.8 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 19ms
extension-clean-combined-draw: p95 frame time 50ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9930ms
extension-clean-combined-draw: script duration 8165ms
extension-clean-combined-draw: TBT 1347ms
extension-clean-combined-draw: heap used 70.9 MB
extension-clean-combined-draw: DOM nodes -15
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 19ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10111ms
extension-rgthree-prototype-draw: script duration 8400ms
extension-rgthree-prototype-draw: TBT 1467ms
extension-rgthree-prototype-draw: heap used 89.0 MB
extension-rgthree-prototype-draw: DOM nodes -9
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 571ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 79.9 MB
large-graph-idle: DOM nodes -242
large-graph-idle: event listeners -163
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1620ms
large-graph-pan: script duration 879ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 68.9 MB
large-graph-pan: DOM nodes -233
large-graph-pan: event listeners -163
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1729ms
large-graph-zoom: script duration 822ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.2 MB
large-graph-zoom: DOM nodes -252
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1943ms
legacy-node-drag: script duration 1000ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.2 MB
legacy-node-drag: DOM nodes 4
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 539ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.9 MB
minimap-idle: DOM nodes -248
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 398ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 79.7 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 408ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.4 MB
subgraph-idle: DOM nodes -275
subgraph-idle: event listeners -198
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 0ms
subgraph-mouse-sweep: style recalc duration 14ms
subgraph-mouse-sweep: layout count 0
subgraph-mouse-sweep: style recalc count 46
subgraph-mouse-sweep: task duration 677ms
subgraph-mouse-sweep: script duration 105ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 72.1 MB
subgraph-mouse-sweep: DOM nodes -276
subgraph-mouse-sweep: event listeners -198
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 965ms
subgraph-transition-enter: script duration 34ms
subgraph-transition-enter: TBT 140ms
subgraph-transition-enter: heap used 99.6 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5885ms
viewport-pan-sweep: script duration 2871ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 78.6 MB
viewport-pan-sweep: DOM nodes -244
viewport-pan-sweep: event listeners -152
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16943ms
vue-large-graph-idle: script duration 297ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.7 MB
vue-large-graph-idle: DOM nodes -8063
vue-large-graph-idle: event listeners -14928
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 20420ms
vue-large-graph-pan: script duration 912ms
vue-large-graph-pan: TBT 74ms
vue-large-graph-pan: heap used 183.1 MB
vue-large-graph-pan: DOM nodes -8061
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5231ms
vue-node-resize-workload: script duration 97ms
vue-node-resize-workload: TBT 259ms
vue-node-resize-workload: heap used 176.4 MB
vue-node-resize-workload: DOM nodes -8061
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8328ms
vue-zoom-out-idle: script duration 135ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 175.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 80ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 65.6 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-29T07:39:31.379Z",
  "gitSha": "c2d0d01e53e2b842f77db20467359d35f2016607",
  "branch": "cbyrne/backport-18952-cloud-155",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2006.4590000000067,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.086000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.653,
      "heapDeltaBytes": 8100488,
      "heapUsedBytes": 75742896,
      "domNodes": -261,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.641,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.3760000000084,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.812000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 468.196,
      "heapDeltaBytes": -3446800,
      "heapUsedBytes": 64222284,
      "domNodes": -261,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.831999999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1772.5679999999784,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 16.636000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 815.008,
      "heapDeltaBytes": -4190632,
      "heapUsedBytes": 63495320,
      "domNodes": -260,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 163.61999999999998,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1752.083999999968,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 12.775000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 780.266,
      "heapDeltaBytes": 11928348,
      "heapUsedBytes": 79476664,
      "domNodes": -261,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 156.577,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.3600000000238,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.322,
      "layouts": 6,
      "layoutDurationMs": 1.2429999999999999,
      "taskDurationMs": 376.517,
      "heapDeltaBytes": 3147548,
      "heapUsedBytes": 70636824,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.955999999999996,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.3849999999074,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.596,
      "layouts": 6,
      "layoutDurationMs": 1.0890000000000002,
      "taskDurationMs": 343.30499999999995,
      "heapDeltaBytes": 3136584,
      "heapUsedBytes": 70541388,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.941999999999995,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 631.2350000000038,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.103,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.096,
      "heapDeltaBytes": 18526152,
      "heapUsedBytes": 86457656,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 168.92200000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 646.7089999999871,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.523999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.42499999999995,
      "heapDeltaBytes": 18804696,
      "heapUsedBytes": 86784976,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 170.53,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1176.7340000000104,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 845.4649999999999,
      "heapDeltaBytes": 34420880,
      "heapUsedBytes": 105936644,
      "domNodes": 0,
      "jsHeapTotalBytes": 19034112,
      "scriptDurationMs": 76.556,
      "eventListeners": 0,
      "totalBlockingTimeMs": 562,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1189.0710000000126,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 859.474,
      "heapDeltaBytes": 38526128,
      "heapUsedBytes": 107856112,
      "domNodes": 0,
      "jsHeapTotalBytes": 18247680,
      "scriptDurationMs": 70.186,
      "eventListeners": 0,
      "totalBlockingTimeMs": 580,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 849.3349999999964,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.6530000000001,
      "heapDeltaBytes": 15023596,
      "heapUsedBytes": 90204788,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 169.83900000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 233,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 857.3250000000598,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.61500000000024,
      "heapDeltaBytes": 14966728,
      "heapUsedBytes": 91737284,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 173.39899999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 246,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11180.78700000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10243.952,
      "heapDeltaBytes": -1775844,
      "heapUsedBytes": 80359328,
      "domNodes": -14,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 8443.877,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1454,
      "frameDurationMs": 20,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10486.45799999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9616.73,
      "heapDeltaBytes": -13968668,
      "heapUsedBytes": 68287388,
      "domNodes": -16,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 7886.412,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1240,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 50
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10577.241000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9753.154,
      "heapDeltaBytes": 18418364,
      "heapUsedBytes": 93267832,
      "domNodes": -4,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 8097.2390000000005,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1277,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11323.677999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10469.768,
      "heapDeltaBytes": 11565332,
      "heapUsedBytes": 93419532,
      "domNodes": -14,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 8701.859,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1657,
      "frameDurationMs": 18.886666666666617,
      "p95FrameDurationMs": 50
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2035.2410000000418,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.7780000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.214,
      "heapDeltaBytes": -3432356,
      "heapUsedBytes": 83484756,
      "domNodes": -241,
      "jsHeapTotalBytes": -1019904,
      "scriptDurationMs": 32.928,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.7630000000408,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.725999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 566.04,
      "heapDeltaBytes": -2869684,
      "heapUsedBytes": 84013396,
      "domNodes": -242,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 37.01700000000001,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2394.8049999999625,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.267,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1764.503,
      "heapDeltaBytes": -19353908,
      "heapUsedBytes": 68705304,
      "domNodes": -223,
      "jsHeapTotalBytes": 2125824,
      "scriptDurationMs": 896.31,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2177.701999999954,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.052000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1475.6509999999998,
      "heapDeltaBytes": 11709488,
      "heapUsedBytes": 75811768,
      "domNodes": -243,
      "jsHeapTotalBytes": 2060288,
      "scriptDurationMs": 860.8,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3582.5810000000047,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.378999999999996,
      "layouts": 60,
      "layoutDurationMs": 13.331,
      "taskDurationMs": 1731.096,
      "heapDeltaBytes": 11331432,
      "heapUsedBytes": 76448272,
      "domNodes": -251,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 841.324,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3621.346000000017,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.992000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.479000000000001,
      "taskDurationMs": 1726.8969999999997,
      "heapDeltaBytes": 9870316,
      "heapUsedBytes": 74977756,
      "domNodes": -253,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 803.158,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3118.8040000000115,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.831999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1929.2119999999998,
      "heapDeltaBytes": 25201704,
      "heapUsedBytes": 91351772,
      "domNodes": 4,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1000.8140000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3122.4660000000313,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 6.697000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1957.185,
      "heapDeltaBytes": 23288072,
      "heapUsedBytes": 89399628,
      "domNodes": 4,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 998.348,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.8209999999317,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.067,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.5310000000001,
      "heapDeltaBytes": 20600896,
      "heapUsedBytes": 84970932,
      "domNodes": -244,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.926,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2007.5380000000678,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.8410000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 563.052,
      "heapDeltaBytes": 20235980,
      "heapUsedBytes": 84653248,
      "domNodes": -251,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.245,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.2250000000126,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.651000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.07099999999997,
      "heapDeltaBytes": 13785048,
      "heapUsedBytes": 83666716,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 144.71699999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 574.243000000024,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.629,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 399.166,
      "heapDeltaBytes": 13781168,
      "heapUsedBytes": 83520860,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 144.816,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1990.1679999999828,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.744000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.005,
      "heapDeltaBytes": 9917176,
      "heapUsedBytes": 79655220,
      "domNodes": -275,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.8210000000000015,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2004.1370000000143,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.997999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.93500000000006,
      "heapDeltaBytes": -14494912,
      "heapUsedBytes": 55331636,
      "domNodes": -275,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 6.872,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.0319999999838,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 13.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 642.517,
      "heapDeltaBytes": 2927676,
      "heapUsedBytes": 72785560,
      "domNodes": -275,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 106.472,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1725.4990000000134,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 14.543000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 710.82,
      "heapDeltaBytes": 8833008,
      "heapUsedBytes": 78336792,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 103.918,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.8010000000013,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.423000000000005,
      "layouts": 5,
      "layoutDurationMs": 13.460999999999997,
      "taskDurationMs": 965.303,
      "heapDeltaBytes": 20269076,
      "heapUsedBytes": 104458380,
      "domNodes": 13667,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 33.942,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8374.363000000016,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.59899999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5831.973,
      "heapDeltaBytes": -6453384,
      "heapUsedBytes": 80493852,
      "domNodes": -245,
      "jsHeapTotalBytes": 745472,
      "scriptDurationMs": 2838.5220000000004,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8500.325999999972,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 36.788999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5937.32,
      "heapDeltaBytes": -2553796,
      "heapUsedBytes": 84396136,
      "domNodes": -242,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 2902.993,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17284.68499999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16906.506,
      "heapDeltaBytes": -48625976,
      "heapUsedBytes": 178763424,
      "domNodes": -8061,
      "jsHeapTotalBytes": -13438976,
      "scriptDurationMs": 284.226,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17394.71800000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16980.486,
      "heapDeltaBytes": -59830596,
      "heapUsedBytes": 181278240,
      "domNodes": -8065,
      "jsHeapTotalBytes": -20676608,
      "scriptDurationMs": 310.414,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20807.942000000025,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 17.646000000000022,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20526.257,
      "heapDeltaBytes": -33781204,
      "heapUsedBytes": 191836120,
      "domNodes": -8061,
      "jsHeapTotalBytes": -15020032,
      "scriptDurationMs": 913.1940000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 33,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20560.543000000052,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 17.954000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20313.438,
      "heapDeltaBytes": -21386736,
      "heapUsedBytes": 192145544,
      "domNodes": -8061,
      "jsHeapTotalBytes": -9564160,
      "scriptDurationMs": 909.919,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 114,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4693.619000000012,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.838,
      "layouts": 20,
      "layoutDurationMs": 24.016999999999996,
      "taskDurationMs": 4543.717000000001,
      "heapDeltaBytes": -56018692,
      "heapUsedBytes": 185220540,
      "domNodes": -8061,
      "jsHeapTotalBytes": 15527936,
      "scriptDurationMs": 89.40100000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 156,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5984.258999999952,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.045,
      "layouts": 20,
      "layoutDurationMs": 22.548,
      "taskDurationMs": 5918.078,
      "heapDeltaBytes": -40794616,
      "heapUsedBytes": 184733372,
      "domNodes": -8061,
      "jsHeapTotalBytes": 15458304,
      "scriptDurationMs": 105.48599999999999,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 361,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8406.109000000015,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8258.315,
      "heapDeltaBytes": 8356276,
      "heapUsedBytes": 184276256,
      "domNodes": 0,
      "jsHeapTotalBytes": -11010048,
      "scriptDurationMs": 132.68199999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8644.898000000012,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8397.116999999998,
      "heapDeltaBytes": -233288,
      "heapUsedBytes": 183071480,
      "domNodes": 0,
      "jsHeapTotalBytes": -11534336,
      "scriptDurationMs": 136.463,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 110.8960000000252,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 14.474,
      "layouts": 2,
      "layoutDurationMs": 0.552,
      "taskDurationMs": 86.10800000000002,
      "heapDeltaBytes": 3222180,
      "heapUsedBytes": 69118408,
      "domNodes": 109,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 10.120000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 101.6540000000532,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 15.893,
      "layouts": 3,
      "layoutDurationMs": 1.6129999999999998,
      "taskDurationMs": 74.581,
      "heapDeltaBytes": 3004844,
      "heapUsedBytes": 68502348,
      "domNodes": 126,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.666999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 52408 79289 66.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.8% 1153
src/LGraphNode.ts 70.5% 382
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 330
src/LGraph.ts 78.8% 269
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/scripts/app.ts 73.1% 252
src/scripts/pnginfo.ts 20.8% 221

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@datadog-official

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 9 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 3
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Playwright videos for new tests

Download the recorded videos and HTML report

Recorded projects: cloud

Recorded test titles:

  • all tests in browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/agent/services/agent/undeliverableAskReporter.ts 93.18% 3 Missing ⚠️
...sions/agent/stores/agent/agentConversationStore.ts 93.75% 3 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.55   #19336   +/-   ##
=============================================
  Coverage              ?   84.70%           
=============================================
  Files                 ?     2323           
  Lines                 ?   132891           
  Branches              ?    35936           
=============================================
  Hits                  ?   112568           
  Misses                ?    19971           
  Partials              ?      352           
Flag Coverage Δ
e2e 66.10% <ø> (?)
unit 80.67% <94.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
...s/agent/services/agent/undeliverableAskReporter.ts 93.18% <93.18%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 97.48% <93.75%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne removed the request for review from ryan-di September 29, 2026 06:54
@github-actions
github-actions Bot requested a review from ryan-di September 29, 2026 07:11
@christian-byrne
christian-byrne removed the request for review from ryan-di September 29, 2026 07:18
@github-actions
github-actions Bot requested a review from ryan-di September 29, 2026 07:29
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by merged #19347. Closing to avoid applying the same cloud/1.55 telemetry backport twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-backport Agent changes targeting a stable cloud/core release branch cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants