Repository navigation
[backport cloud/1.55] fix(agent): harden undeliverable ask telemetry - #19475
christian-byrne merged 1 commit into
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d0ab834c8001a02fd93df8064535220a80a95fe9
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2125 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T21:27:14.347Z",
"gitSha": "784125f923248dc6a9e8d4e95d431db0ecd7ee8e",
"branch": "fix/cloud-1.55-undeliverable-ask-telemetry-hardening",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.0770000000666,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.279,
"heapDeltaBytes": -10955324,
"heapUsedBytes": 57058464,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.575000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2006.774999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.438999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.401,
"heapDeltaBytes": 7997664,
"heapUsedBytes": 76028096,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.725000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1733.4819999999809,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.758,
"heapDeltaBytes": 9742156,
"heapUsedBytes": 77411268,
"domNodes": -263,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.325,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1756.4789999998993,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 865.581,
"heapDeltaBytes": 7502512,
"heapUsedBytes": 75494864,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 166.45200000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.1340000000728,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.855,
"layouts": 6,
"layoutDurationMs": 1.041,
"taskDurationMs": 359.661,
"heapDeltaBytes": 3161528,
"heapUsedBytes": 70724912,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.398,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.2139999999872,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.385,
"layouts": 6,
"layoutDurationMs": 0.935,
"taskDurationMs": 326.55699999999996,
"heapDeltaBytes": 3148688,
"heapUsedBytes": 70749516,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.744,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 681.4749999999776,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.424000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.03100000000006,
"heapDeltaBytes": 18969088,
"heapUsedBytes": 86667104,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 169.627,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 634.4799999999395,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.39099999999996,
"heapDeltaBytes": 18910812,
"heapUsedBytes": 86608452,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.53300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1160.2080000000115,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.195,
"heapDeltaBytes": 35339108,
"heapUsedBytes": 106930436,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 70.05099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 550,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.8710000000228,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 956.383,
"heapDeltaBytes": -16464628,
"heapUsedBytes": 73782272,
"domNodes": -293,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 76.99199999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 590,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 853.9400000000796,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.8370000000001,
"heapDeltaBytes": 14603176,
"heapUsedBytes": 91459408,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 175.00900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.7109999999338,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.4320000000007,
"heapDeltaBytes": 15805904,
"heapUsedBytes": 93028444,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 178.095,
"eventListeners": 0,
"totalBlockingTimeMs": 247,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10857.85999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9906.458,
"heapDeltaBytes": -9772476,
"heapUsedBytes": 72258584,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8171.486,
"eventListeners": 0,
"totalBlockingTimeMs": 1313,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10428.996000000097,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9412.258,
"heapDeltaBytes": 4217040,
"heapUsedBytes": 86288620,
"domNodes": -20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8010.659000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1451,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10338.86700000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9491.266,
"heapDeltaBytes": 82580,
"heapUsedBytes": 81994652,
"domNodes": -12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7824.539000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1077,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10679.744999999912,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9748.155,
"heapDeltaBytes": 16207164,
"heapUsedBytes": 98175680,
"domNodes": -14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8340.641,
"eventListeners": 0,
"totalBlockingTimeMs": 1369,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2047.7309999999989,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.1309999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.798,
"heapDeltaBytes": -3318160,
"heapUsedBytes": 83570060,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 35.785,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.7710000001625,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.802000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.616,
"heapDeltaBytes": -3853436,
"heapUsedBytes": 83260600,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.91499999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2504.6990000000733,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.437000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1732.9750000000001,
"heapDeltaBytes": 19776888,
"heapUsedBytes": 84144592,
"domNodes": -246,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 890.805,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2579.6309999998357,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.28,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1787.2240000000002,
"heapDeltaBytes": 16297248,
"heapUsedBytes": 80515056,
"domNodes": -246,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 906.899,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3931.6690000000563,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.483,
"layouts": 60,
"layoutDurationMs": 14.327,
"taskDurationMs": 1894.0870000000002,
"heapDeltaBytes": 8307036,
"heapUsedBytes": 74295984,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 862.448,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3886.109999999917,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.326,
"layouts": 60,
"layoutDurationMs": 14.106,
"taskDurationMs": 1899.727,
"heapDeltaBytes": 10065176,
"heapUsedBytes": 75075712,
"domNodes": -3,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 898.4929999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3244.5510000000013,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.079000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2210.14,
"heapDeltaBytes": 561712,
"heapUsedBytes": 66719160,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1144.872,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3146.056999999928,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.8050000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2057.5299999999997,
"heapDeltaBytes": 25684732,
"heapUsedBytes": 92166424,
"domNodes": 2,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1052.4419999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.6940000000013,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.61,
"heapDeltaBytes": -4006088,
"heapUsedBytes": 84642720,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.568,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2045.9469999998419,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.337,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.241,
"heapDeltaBytes": -6345956,
"heapUsedBytes": 82408176,
"domNodes": -246,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 32.08899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.2380000000703,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.759,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.279,
"heapDeltaBytes": 13740064,
"heapUsedBytes": 83697520,
"domNodes": 20,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 145.429,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.9340000000084,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.03599999999994,
"heapDeltaBytes": 14021036,
"heapUsedBytes": 83406964,
"domNodes": 23,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.9810000000198,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.232,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.749,
"heapDeltaBytes": -6315888,
"heapUsedBytes": 63572940,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.368999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.4850000000315,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.806999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.46900000000005,
"heapDeltaBytes": 11720420,
"heapUsedBytes": 81619124,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.057,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.2100000000082,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.472,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 751.1190000000001,
"heapDeltaBytes": 6751336,
"heapUsedBytes": 75679528,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 107.928,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.9410000001244,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.398000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.4259999999999,
"heapDeltaBytes": 2863888,
"heapUsedBytes": 72162104,
"domNodes": -276,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 109.961,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1081.0290000001714,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.177999999999997,
"layouts": 5,
"layoutDurationMs": 13.644,
"taskDurationMs": 775.3790000000002,
"heapDeltaBytes": -6253952,
"heapUsedBytes": 83515936,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.524000000000008,
"eventListeners": 2383,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8465.422999999873,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5822.393,
"heapDeltaBytes": 16699252,
"heapUsedBytes": 80212360,
"domNodes": -244,
"jsHeapTotalBytes": 978944,
"scriptDurationMs": 2806.1760000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8954.007000000047,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6224.05,
"heapDeltaBytes": -4740932,
"heapUsedBytes": 82086896,
"domNodes": -241,
"jsHeapTotalBytes": -565248,
"scriptDurationMs": 2949.563,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17578.763999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17109.013000000003,
"heapDeltaBytes": -58153036,
"heapUsedBytes": 167553912,
"domNodes": -8061,
"jsHeapTotalBytes": -11018240,
"scriptDurationMs": 272.381,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17006.789000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16503.694000000003,
"heapDeltaBytes": -36531872,
"heapUsedBytes": 186507660,
"domNodes": -8061,
"jsHeapTotalBytes": -14389248,
"scriptDurationMs": 269.961,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21131.51600000015,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20918.010000000002,
"heapDeltaBytes": -35282684,
"heapUsedBytes": 185697736,
"domNodes": -8061,
"jsHeapTotalBytes": -11665408,
"scriptDurationMs": 902.436,
"eventListeners": -14928,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21050.077999999987,
"styleRecalcs": 155,
"styleRecalcDurationMs": 19.761000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20871.032,
"heapDeltaBytes": -27391776,
"heapUsedBytes": 191745356,
"domNodes": -8061,
"jsHeapTotalBytes": -17641472,
"scriptDurationMs": 967.208,
"eventListeners": -14928,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6377.554000000146,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.88600000000002,
"layouts": 20,
"layoutDurationMs": 26.525000000000006,
"taskDurationMs": 6301.201,
"heapDeltaBytes": -25670840,
"heapUsedBytes": 195754744,
"domNodes": -8061,
"jsHeapTotalBytes": 12644352,
"scriptDurationMs": 116.73599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 465,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6296.060000000125,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.762,
"layouts": 20,
"layoutDurationMs": 23.587999999999997,
"taskDurationMs": 6218.217999999999,
"heapDeltaBytes": -53386348,
"heapUsedBytes": 187315472,
"domNodes": -8061,
"jsHeapTotalBytes": 2727936,
"scriptDurationMs": 115.33500000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8505.578999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8308.578000000001,
"heapDeltaBytes": -10781636,
"heapUsedBytes": 171640416,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 124.224,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8975.06599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8814.992,
"heapDeltaBytes": -9065244,
"heapUsedBytes": 173595428,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 142.84899999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 451.69000000009873,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.705,
"layouts": 3,
"layoutDurationMs": 1.504,
"taskDurationMs": 124.203,
"heapDeltaBytes": 4992392,
"heapUsedBytes": 70978044,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.919,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 111.95700000007491,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.726,
"layouts": 3,
"layoutDurationMs": 1.5840000000000003,
"taskDurationMs": 86.96000000000001,
"heapDeltaBytes": 3008084,
"heapUsedBytes": 68239288,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.193,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.55 #19475 +/- ##
=============================================
Coverage ? 84.68%
=============================================
Files ? 2323
Lines ? 132730
Branches ? 33618
=============================================
Hits ? 112398
Misses ? 19972
Partials ? 360
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Summary
Follow-up to #19347 (the cloud/1.55 backport for approval prompts surviving reconnects). This carries the review hardening that was omitted when the earlier backport merged.
ask_useras an approval-card delivery failureValidation
pnpm exec vitest run src/workbench/extensions/agent/services/agent/agentEventTransport.test.ts src/workbench/extensions/agent/stores/agent/agentConversationStore.test.ts(98 tests passed)