Repository navigation
[backport cloud/1.54] Report approval asks the panel never delivered (#18952) - #19345
christian-byrne wants to merge 6 commits into
Conversation
A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.
- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.
A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.
A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.
**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.
`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.
It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.
Two sites, tagged by `reason` so they split on the dashboard:
| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |
The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.
Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.
**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.
The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.
Run against a cloud dev server plus the e2e ComfyUI container:
```
✘ 1 the approval card reaches the panel after a reconnect (expected)
✘ 2 the user can answer the ask that arrived after the reconnect (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```
Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:
```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```
- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1958 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T02:44:25.514Z",
"gitSha": "9903c9f220559099075eb644d8fd57015d568a44",
"branch": "backport-18952-to-cloud-1.54-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2100.9689999999637,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.897999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 743.724,
"heapDeltaBytes": -3169156,
"heapUsedBytes": 67334724,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.857000000000003,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2089.772000000039,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.615,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 654.5079999999999,
"heapDeltaBytes": -10452168,
"heapUsedBytes": 60108248,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 14.714999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1936.2650000000485,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.108000000000004,
"layouts": 14,
"layoutDurationMs": 4.220000000000001,
"taskDurationMs": 982.2900000000001,
"heapDeltaBytes": 6159396,
"heapUsedBytes": 77065636,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 171.76200000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1917.8769999999759,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.734,
"layouts": 14,
"layoutDurationMs": 4.423,
"taskDurationMs": 991.066,
"heapDeltaBytes": 4783792,
"heapUsedBytes": 75752536,
"domNodes": -284,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 178.934,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.0159999999778,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.741,
"layouts": 6,
"layoutDurationMs": 1.1989999999999998,
"taskDurationMs": 459.31899999999996,
"heapDeltaBytes": 4646492,
"heapUsedBytes": 75958256,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 16.781000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.5410000000547,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.147000000000006,
"layouts": 6,
"layoutDurationMs": 1.1080000000000003,
"taskDurationMs": 458.04999999999995,
"heapDeltaBytes": 4617712,
"heapUsedBytes": 75938028,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 17.003,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 779.1110000000003,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.387999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.4399999999999,
"heapDeltaBytes": -7572128,
"heapUsedBytes": 63382392,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 196.317,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.0400000000254,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.955000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.1139999999999,
"heapDeltaBytes": -7545512,
"heapUsedBytes": 63430728,
"domNodes": 16,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 171.11,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2064.292000000023,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.0280000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.9620000000001,
"heapDeltaBytes": 9722620,
"heapUsedBytes": 86549388,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 44.21,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2072.7749999999787,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.1160000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.835,
"heapDeltaBytes": 7703816,
"heapUsedBytes": 84376956,
"domNodes": -274,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 43.25400000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3185.580000000016,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1997.5870000000002,
"heapDeltaBytes": 12878656,
"heapUsedBytes": 90159944,
"domNodes": -278,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 994.9839999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3160.4489999999714,
"styleRecalcs": 68,
"styleRecalcDurationMs": 18.637,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1983.2669999999998,
"heapDeltaBytes": 15213720,
"heapUsedBytes": 92066204,
"domNodes": -250,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 985.063,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3904.6940000000063,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.382,
"layouts": 60,
"layoutDurationMs": 12.373999999999999,
"taskDurationMs": 1940.3590000000002,
"heapDeltaBytes": -3388872,
"heapUsedBytes": 76154852,
"domNodes": -284,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 832.9530000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3876.5730000000076,
"styleRecalcs": 62,
"styleRecalcDurationMs": 19,
"layouts": 60,
"layoutDurationMs": 12.402,
"taskDurationMs": 1948.294,
"heapDeltaBytes": -3176924,
"heapUsedBytes": 75835800,
"domNodes": -285,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 832.2479999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3149.0229999999997,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.197,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2082.6349999999998,
"heapDeltaBytes": 26345996,
"heapUsedBytes": 96375092,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1019.0219999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3162.661999999955,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.342000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2143.5959999999995,
"heapDeltaBytes": -2696920,
"heapUsedBytes": 67749084,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 1061.434,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2041.5179999999964,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5020000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 745.759,
"heapDeltaBytes": 10179240,
"heapUsedBytes": 87260808,
"domNodes": -274,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 44.447,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2001.0310000000118,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.04,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 723.288,
"heapDeltaBytes": 22122764,
"heapUsedBytes": 88744852,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.507,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 699.9309999999923,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.919000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.275,
"heapDeltaBytes": 15160896,
"heapUsedBytes": 88576368,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.363,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 669.8639999999614,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.239,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.46000000000004,
"heapDeltaBytes": 15469660,
"heapUsedBytes": 88772596,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.228,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.1780000000258,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.185999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.302,
"heapDeltaBytes": 7992516,
"heapUsedBytes": 81158956,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.086000000000004,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2035.1180000000113,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.254,
"heapDeltaBytes": -12312620,
"heapUsedBytes": 60850848,
"domNodes": -300,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.845999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1840.40600000003,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.768,
"layouts": 18,
"layoutDurationMs": 5.6,
"taskDurationMs": 958.8970000000002,
"heapDeltaBytes": 343720,
"heapUsedBytes": 73953096,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 128.01800000000003,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.090000000062,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.698999999999998,
"layouts": 18,
"layoutDurationMs": 5.0409999999999995,
"taskDurationMs": 910.572,
"heapDeltaBytes": -2542880,
"heapUsedBytes": 70198200,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 123.09,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.4760000000138,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.439,
"layouts": 14,
"layoutDurationMs": 17.227999999999998,
"taskDurationMs": 1081.3410000000001,
"heapDeltaBytes": 22178552,
"heapUsedBytes": 106567268,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 35.424,
"eventListeners": 2387,
"totalBlockingTimeMs": 154,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10069.357999999966,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.44,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6590.045,
"heapDeltaBytes": 13832800,
"heapUsedBytes": 90715560,
"domNodes": -270,
"jsHeapTotalBytes": 352256,
"scriptDurationMs": 2934.568,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11079.823000000033,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.040000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6850.355,
"heapDeltaBytes": 8171168,
"heapUsedBytes": 84813996,
"domNodes": -280,
"jsHeapTotalBytes": 1138688,
"scriptDurationMs": 3100.0879999999997,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18127.654000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17509.853999999996,
"heapDeltaBytes": -39281404,
"heapUsedBytes": 178957020,
"domNodes": -8068,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 314.49899999999997,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18466.573999999924,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17865.301,
"heapDeltaBytes": -38035980,
"heapUsedBytes": 180798272,
"domNodes": -8068,
"jsHeapTotalBytes": -10280960,
"scriptDurationMs": 318.809,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22358.001,
"styleRecalcs": 176,
"styleRecalcDurationMs": 23.970999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22032.864,
"heapDeltaBytes": -29936800,
"heapUsedBytes": 188261148,
"domNodes": -8068,
"jsHeapTotalBytes": -11399168,
"scriptDurationMs": 1014.111,
"eventListeners": -14929,
"totalBlockingTimeMs": 225,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22982.388000000014,
"styleRecalcs": 178,
"styleRecalcDurationMs": 24.88299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22623.685999999998,
"heapDeltaBytes": -53331256,
"heapUsedBytes": 186502724,
"domNodes": -8068,
"jsHeapTotalBytes": -16748544,
"scriptDurationMs": 997.545,
"eventListeners": -14929,
"totalBlockingTimeMs": 127,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6487.693999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.29399999999998,
"layouts": 20,
"layoutDurationMs": 38.376999999999995,
"taskDurationMs": 6384.903,
"heapDeltaBytes": -40906828,
"heapUsedBytes": 177759276,
"domNodes": -8068,
"jsHeapTotalBytes": 11739136,
"scriptDurationMs": 116.93500000000002,
"eventListeners": -14931,
"totalBlockingTimeMs": 392,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6605.040000000031,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.115,
"layouts": 20,
"layoutDurationMs": 25.942000000000007,
"taskDurationMs": 6520.697,
"heapDeltaBytes": -21931040,
"heapUsedBytes": 184674552,
"domNodes": -3070,
"jsHeapTotalBytes": 18321408,
"scriptDurationMs": 118.92499999999998,
"eventListeners": -14925,
"totalBlockingTimeMs": 499,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9072.584000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8713.414000000002,
"heapDeltaBytes": 9118952,
"heapUsedBytes": 180020932,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 148.90499999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9316.880999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8959.633000000002,
"heapDeltaBytes": 5349408,
"heapUsedBytes": 177496652,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 231.46100000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 480.4790000000594,
"styleRecalcs": 17,
"styleRecalcDurationMs": 21.813,
"layouts": 4,
"layoutDurationMs": 1.7479999999999998,
"taskDurationMs": 118.25599999999997,
"heapDeltaBytes": 4992552,
"heapUsedBytes": 73628248,
"domNodes": 143,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.187,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 124.0020000000186,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.867,
"layouts": 2,
"layoutDurationMs": 1.555,
"taskDurationMs": 83.839,
"heapDeltaBytes": 2996020,
"heapUsedBytes": 72364800,
"domNodes": 130,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.961999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🔴 Critical | 1 |
| 🟡 Medium | 2 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #19345 +/- ##
=============================================
Coverage ? 84.00%
=============================================
Files ? 2121
Lines ? 126907
Branches ? 34338
=============================================
Hits ? 106614
Misses ? 20115
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…to-cloud-1.54-manual
Addresses review feedback on report volume, failure-reason dedupe, tag cardinality, and missing departure records.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. #18952 is already on cloud/1.54 verbatim through #19335, so this branch now only conflicts with it, and the changes it would add beyond that are not part of #18952 or main.
I compared this branch, against its merge base f5c19ea, with #18952's merged diff (8223a93 against its parent 26e657f).
- #19335 merged into
cloud/1.54at 4eeba25 on 2026-09-30. Its added and removed lines match #18952 in all seven files.undeliverableAskReporter.ts,agentTurnLockFixture.ts, andagentApprovalSurvivesSocketDrop.spec.tson the currentcloud/1.54tip are byte-identical tomainat 8223a93. That is why GitHub reports this PR as not mergeable:git merge-treeagainstorigin/cloud/1.54conflicts in all six files besidesagentEventTransport.ts, including add/add conflicts on the reporter and the spec. - On this branch,
agentEventTransport.tsmatches the source exactly. The other six files diverge from #18952 in the inline-marked places. These divergences come from fb4fbcc, 441bfb1, and 5699b16. Onmain, the only later change to the reporter is #19230's error surface tags. So these are new behavior on a release branch, not a backport of amainfix. - At 5699b16,
vitest runoveragentEventTransport.test.tsandagentConversationStore.test.tspassed 98/98, and hosted checks passed against the old base. Passing checks do not change the outcome, because the intended change has already landed through #19335.
I think this PR should be closed as superseded by #19335. If the reporting changes below are wanted, they should go to main first and then be backported on their own.
| activeTurnId?: string | null | ||
| } | ||
|
|
||
| const MAX_REPORTS_PER_SESSION = 32 |
There was a problem hiding this comment.
#18952 keeps a 32-entry LRU of reported ask_ids (MAX_REPORTED_ASKS, evicting the oldest), and that is what is on cloud/1.54 now through #19335. This replaces it with a hard cap of 32 reports per session, so after 32 reports in a session every later undeliverable ask goes unreported. Neither #18952 nor main has this.
| reason: UndeliverableAskReason, | ||
| context: UndeliverableAskContext = {} | ||
| ): void { | ||
| const reportKey = `${data.thread_id}\u0000${data.ask_id}\u0000${reason}` |
There was a problem hiding this comment.
#18952 dedupes on ask_id alone. Keying on thread, ask, and reason changes how many reports a single ask can produce. The new test "reports distinct failure reasons for the same ask once each" pins that, and it is not in the source.
| level: 'warning', | ||
| tags: { | ||
| reason, | ||
| ask_kind: askKind, |
There was a problem hiding this comment.
#18952 tags ask_kind: data.kind?.slice(0, 64) || 'missing'. Normalizing to run_approval / ask_user / other and moving the raw kind into context.askKind changes the emitted telemetry shape relative to main and to what cloud/1.54 already reports.
| eventMessageId === undefined | ||
| ? undefined | ||
| : departedTurns.get(departedTurnKey(eventThreadId, eventMessageId)) | ||
| reportUndeliverableAsk(event, reason ?? 'no-live-turn') |
There was a problem hiding this comment.
#18952 reports only when the departed-turn lookup yields a reason (if (reason) reportUndeliverableAsk(event, reason)). Falling back to 'no-live-turn' makes an ask for an untracked thread report too, which the source deliberately left quiet. This also inverts the source test "stays quiet for an ask belonging to an untracked thread", now "reports an ask belonging to an untracked thread" at agentConversationStore.test.ts:945.
| expect(reportError).not.toHaveBeenCalled() | ||
| }) | ||
|
|
||
| it('reports an ask belonging to an untracked thread', () => { |
There was a problem hiding this comment.
This is the source's "stays quiet for an ask belonging to an untracked thread" with the assertion inverted. The same goes for the ask_kind: 'other' expectation further down, which the source writes as ask_kind: 'pick_a_model'. Both follow the non-source behavior changes above.
| ) | ||
| }) | ||
|
|
||
| it('caps reports per session', () => { |
There was a problem hiding this comment.
The source's "bounds reported ask identities and evicts the oldest" (34 calls) is replaced by "caps reports per session" (32 calls). "reports distinct failure reasons for the same ask once each" is new, and "reports an unknown ask kind once with a bounded tag" now expects 'other'. These tests follow the reporter changes, not #18952.
| status: this.streaming ? 'streaming' : 'complete', | ||
| workflow_id: WORKFLOW_ID | ||
| workflow_id: WORKFLOW_ID, | ||
| pending_ask: undefined |
There was a problem hiding this comment.
| // The server is parked on this ask and will not proceed without an | ||
| // answer. `ws.send()` throws on a dead route, so pushing stays above | ||
| // test.fail() too. | ||
| turnLock.push(reconnected, RUN_APPROVAL_EVENT) |
There was a problem hiding this comment.
|
Closing as superseded: #19335 already carried the source change into |
Manual backport of #18952 (reports approval prompts that the panel drops after a socket disconnect) after the automated cherry-pick reported conflicts. The resolution preserves the release branch active-turn state while adding the telemetry thread identity and unsupported-ask reporting.
Validation: conflict markers and diff checks pass. Focused local tests could not start because the available shared dependency tree does not match this release branch; hosted CI is required.