Skip to content

[backport cloud/1.54] Report approval asks the panel never delivered (#18952) - #19345

Closed
christian-byrne wants to merge 6 commits into
cloud/1.54from
backport-18952-to-cloud-1.54-manual
Closed

christian-byrne wants to merge 6 commits into
cloud/1.54from
backport-18952-to-cloud-1.54-manual

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Manual backport of #18952 (reports approval prompts that the panel drops after a socket disconnect) after the automated cherry-pick reported conflicts. The resolution preserves the release branch active-turn state while adding the telemetry thread identity and unsupported-ask reporting.

Validation: conflict markers and diff checks pass. Focused local tests could not start because the available shared dependency tree does not match this release branch; hosted CI is required.

A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.

- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.

A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.

A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.

**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.

`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.

It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.

Two sites, tagged by `reason` so they split on the dashboard:

| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |

The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.

Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.

**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.

The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.

Run against a cloud dev server plus the e2e ComfyUI container:

```
✘ 1 the approval card reaches the panel after a reconnect          (expected)
✘ 2 the user can answer the ask that arrived after the reconnect   (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```

Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:

```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```

- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
@christian-byrne christian-byrne added backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Sep 29, 2026
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 30, 2026 2:10am UTC
billing-web-test Ignored Ignored Sep 30, 2026 2:10am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 1a88f534-1cf5-40c6-ae85-0f0a60368cfc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1958 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1937 / ❌ 0 / ⚠️ 3 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/30/2026, 02:18:25 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 1ms TBT · 86.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 154ms TBT · 101.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.5 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 176ms TBT · 178.7 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 446ms TBT · 172.8 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 12ms TBT · 170.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 699ms
canvas-idle: script duration 15ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.8 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -181
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 987ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.9 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -164
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 459ms
canvas-zoom-sweep: script duration 17ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 21
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 523ms
dom-widget-clipping: script duration 184ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.5 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 801ms
large-graph-idle: script duration 44ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.5 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -192
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1990ms
large-graph-pan: script duration 990ms
large-graph-pan: TBT 1ms
large-graph-pan: heap used 86.9 MB
large-graph-pan: DOM nodes -264
large-graph-pan: event listeners -190
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1944ms
large-graph-zoom: script duration 833ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.5 MB
large-graph-zoom: DOM nodes -285
large-graph-zoom: event listeners -188
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2113ms
legacy-node-drag: script duration 1040ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 735ms
minimap-idle: script duration 42ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.9 MB
minimap-idle: DOM nodes -135
minimap-idle: event listeners -78
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 456ms
subgraph-dom-widget-clipping: script duration 150ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.6 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 616ms
subgraph-idle: script duration 14ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.7 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 32ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 935ms
subgraph-mouse-sweep: script duration 126ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1081ms
subgraph-transition-enter: script duration 35ms
subgraph-transition-enter: TBT 154ms
subgraph-transition-enter: heap used 101.6 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 38ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6720ms
viewport-pan-sweep: script duration 3017ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.7 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -171
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17688ms
vue-large-graph-idle: script duration 317ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.5 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 24ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 177
vue-large-graph-pan: task duration 22328ms
vue-large-graph-pan: script duration 1006ms
vue-large-graph-pan: TBT 176ms
vue-large-graph-pan: heap used 178.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 32ms
vue-node-resize-workload: style recalc duration 86ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6453ms
vue-node-resize-workload: script duration 118ms
vue-node-resize-workload: TBT 446ms
vue-node-resize-workload: heap used 172.8 MB
vue-node-resize-workload: DOM nodes -5569
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8837ms
vue-zoom-out-idle: script duration 190ms
vue-zoom-out-idle: TBT 12ms
vue-zoom-out-idle: heap used 170.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -13
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 101ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.6 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-30T02:44:25.514Z",
  "gitSha": "9903c9f220559099075eb644d8fd57015d568a44",
  "branch": "backport-18952-to-cloud-1.54-manual",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2100.9689999999637,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.897999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 743.724,
      "heapDeltaBytes": -3169156,
      "heapUsedBytes": 67334724,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 14.857000000000003,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2089.772000000039,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.615,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 654.5079999999999,
      "heapDeltaBytes": -10452168,
      "heapUsedBytes": 60108248,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 14.714999999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1936.2650000000485,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 31.108000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.220000000000001,
      "taskDurationMs": 982.2900000000001,
      "heapDeltaBytes": 6159396,
      "heapUsedBytes": 77065636,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 171.76200000000003,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1917.8769999999759,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.734,
      "layouts": 14,
      "layoutDurationMs": 4.423,
      "taskDurationMs": 991.066,
      "heapDeltaBytes": 4783792,
      "heapUsedBytes": 75752536,
      "domNodes": -284,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 178.934,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1730.0159999999778,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 18.741,
      "layouts": 6,
      "layoutDurationMs": 1.1989999999999998,
      "taskDurationMs": 459.31899999999996,
      "heapDeltaBytes": 4646492,
      "heapUsedBytes": 75958256,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 16.781000000000002,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.5410000000547,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.147000000000006,
      "layouts": 6,
      "layoutDurationMs": 1.1080000000000003,
      "taskDurationMs": 458.04999999999995,
      "heapDeltaBytes": 4617712,
      "heapUsedBytes": 75938028,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 17.003,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 779.1110000000003,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 10.387999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.4399999999999,
      "heapDeltaBytes": -7572128,
      "heapUsedBytes": 63382392,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 196.317,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 711.0400000000254,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.955000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.1139999999999,
      "heapDeltaBytes": -7545512,
      "heapUsedBytes": 63430728,
      "domNodes": 16,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 171.11,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2064.292000000023,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.0280000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 806.9620000000001,
      "heapDeltaBytes": 9722620,
      "heapUsedBytes": 86549388,
      "domNodes": -274,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 44.21,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.7749999999787,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 7.1160000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 795.835,
      "heapDeltaBytes": 7703816,
      "heapUsedBytes": 84376956,
      "domNodes": -274,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 43.25400000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3185.580000000016,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.508,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1997.5870000000002,
      "heapDeltaBytes": 12878656,
      "heapUsedBytes": 90159944,
      "domNodes": -278,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 994.9839999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3160.4489999999714,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 18.637,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1983.2669999999998,
      "heapDeltaBytes": 15213720,
      "heapUsedBytes": 92066204,
      "domNodes": -250,
      "jsHeapTotalBytes": -401408,
      "scriptDurationMs": 985.063,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3904.6940000000063,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.382,
      "layouts": 60,
      "layoutDurationMs": 12.373999999999999,
      "taskDurationMs": 1940.3590000000002,
      "heapDeltaBytes": -3388872,
      "heapUsedBytes": 76154852,
      "domNodes": -284,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 832.9530000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3876.5730000000076,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 19,
      "layouts": 60,
      "layoutDurationMs": 12.402,
      "taskDurationMs": 1948.294,
      "heapDeltaBytes": -3176924,
      "heapUsedBytes": 75835800,
      "domNodes": -285,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 832.2479999999999,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3149.0229999999997,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.197,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2082.6349999999998,
      "heapDeltaBytes": 26345996,
      "heapUsedBytes": 96375092,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 1019.0219999999998,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3162.661999999955,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.342000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2143.5959999999995,
      "heapDeltaBytes": -2696920,
      "heapUsedBytes": 67749084,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 1061.434,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 2041.5179999999964,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.5020000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 745.759,
      "heapDeltaBytes": 10179240,
      "heapUsedBytes": 87260808,
      "domNodes": -274,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 44.447,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.0310000000118,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.04,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 723.288,
      "heapDeltaBytes": 22122764,
      "heapUsedBytes": 88744852,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.507,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 699.9309999999923,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.919000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.275,
      "heapDeltaBytes": 15160896,
      "heapUsedBytes": 88576368,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 150.363,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 669.8639999999614,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 12.239,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.46000000000004,
      "heapDeltaBytes": 15469660,
      "heapUsedBytes": 88772596,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 150.228,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.1780000000258,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.185999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.302,
      "heapDeltaBytes": 7992516,
      "heapUsedBytes": 81158956,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 13.086000000000004,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2035.1180000000113,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.882,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 619.254,
      "heapDeltaBytes": -12312620,
      "heapUsedBytes": 60850848,
      "domNodes": -300,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 14.845999999999998,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1840.40600000003,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 33.768,
      "layouts": 18,
      "layoutDurationMs": 5.6,
      "taskDurationMs": 958.8970000000002,
      "heapDeltaBytes": 343720,
      "heapUsedBytes": 73953096,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 128.01800000000003,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.090000000062,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.698999999999998,
      "layouts": 18,
      "layoutDurationMs": 5.0409999999999995,
      "taskDurationMs": 910.572,
      "heapDeltaBytes": -2542880,
      "heapUsedBytes": 70198200,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 123.09,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1451.4760000000138,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 34.439,
      "layouts": 14,
      "layoutDurationMs": 17.227999999999998,
      "taskDurationMs": 1081.3410000000001,
      "heapDeltaBytes": 22178552,
      "heapUsedBytes": 106567268,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 35.424,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 154,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10069.357999999966,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.44,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6590.045,
      "heapDeltaBytes": 13832800,
      "heapUsedBytes": 90715560,
      "domNodes": -270,
      "jsHeapTotalBytes": 352256,
      "scriptDurationMs": 2934.568,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11079.823000000033,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.040000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6850.355,
      "heapDeltaBytes": 8171168,
      "heapUsedBytes": 84813996,
      "domNodes": -280,
      "jsHeapTotalBytes": 1138688,
      "scriptDurationMs": 3100.0879999999997,
      "eventListeners": -170,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18127.654000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17509.853999999996,
      "heapDeltaBytes": -39281404,
      "heapUsedBytes": 178957020,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9711616,
      "scriptDurationMs": 314.49899999999997,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18466.573999999924,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17865.301,
      "heapDeltaBytes": -38035980,
      "heapUsedBytes": 180798272,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10280960,
      "scriptDurationMs": 318.809,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22358.001,
      "styleRecalcs": 176,
      "styleRecalcDurationMs": 23.970999999999965,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22032.864,
      "heapDeltaBytes": -29936800,
      "heapUsedBytes": 188261148,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11399168,
      "scriptDurationMs": 1014.111,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 225,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000004366
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22982.388000000014,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 24.88299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22623.685999999998,
      "heapDeltaBytes": -53331256,
      "heapUsedBytes": 186502724,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16748544,
      "scriptDurationMs": 997.545,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 127,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6487.693999999976,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.29399999999998,
      "layouts": 20,
      "layoutDurationMs": 38.376999999999995,
      "taskDurationMs": 6384.903,
      "heapDeltaBytes": -40906828,
      "heapUsedBytes": 177759276,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11739136,
      "scriptDurationMs": 116.93500000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 392,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6605.040000000031,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.115,
      "layouts": 20,
      "layoutDurationMs": 25.942000000000007,
      "taskDurationMs": 6520.697,
      "heapDeltaBytes": -21931040,
      "heapUsedBytes": 184674552,
      "domNodes": -3070,
      "jsHeapTotalBytes": 18321408,
      "scriptDurationMs": 118.92499999999998,
      "eventListeners": -14925,
      "totalBlockingTimeMs": 499,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9072.584000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8713.414000000002,
      "heapDeltaBytes": 9118952,
      "heapUsedBytes": 180020932,
      "domNodes": 0,
      "jsHeapTotalBytes": -6029312,
      "scriptDurationMs": 148.90499999999994,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9316.880999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8959.633000000002,
      "heapDeltaBytes": 5349408,
      "heapUsedBytes": 177496652,
      "domNodes": 0,
      "jsHeapTotalBytes": -11534336,
      "scriptDurationMs": 231.46100000000004,
      "eventListeners": -14,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 480.4790000000594,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 21.813,
      "layouts": 4,
      "layoutDurationMs": 1.7479999999999998,
      "taskDurationMs": 118.25599999999997,
      "heapDeltaBytes": 4992552,
      "heapUsedBytes": 73628248,
      "domNodes": 143,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 12.187,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 124.0020000000186,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 18.867,
      "layouts": 2,
      "layoutDurationMs": 1.555,
      "taskDurationMs": 83.839,
      "heapDeltaBytes": 2996020,
      "heapUsedBytes": 72364800,
      "domNodes": 130,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 5.961999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50768 76060 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@datadog-official

This comment has been minimized.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🔴 Critical 1
🟡 Medium 2
🟢 Low 3
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.12195% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 93.87% 3 Missing ⚠️
...s/agent/services/agent/undeliverableAskReporter.ts 95.45% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #19345   +/-   ##
=============================================
  Coverage              ?   84.00%           
=============================================
  Files                 ?     2121           
  Lines                 ?   126907           
  Branches              ?    34338           
=============================================
  Hits                  ?   106614           
  Misses                ?    20115           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.77% <ø> (?)
unit 79.15% <95.12%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
...s/agent/services/agent/undeliverableAskReporter.ts 95.45% <95.45%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 97.72% <93.87%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Addresses review feedback on report volume, failure-reason dedupe, tag cardinality, and missing departure records.
@ryan-di

ryan-di commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

#19335 already backports #18952 to cloud/1.54 unchanged and is approved, so I think this one is a duplicate. The extra behavior here (per-session report cap, per-reason dedupe, unknown-kind tag) isn't on main. If we want it, could it land on main first and then be backported?

@ryan-di ryan-di removed their assignment Sep 30, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as superseded: cloud/1.54 already contains this approval-ask recovery through #19335 (merge commit 4eeba25), including the later hardening now on the branch. Re-merging this stale branch would regress newer release-line work.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. #18952 is already on cloud/1.54 verbatim through #19335, so this branch now only conflicts with it, and the changes it would add beyond that are not part of #18952 or main.

I compared this branch, against its merge base f5c19ea, with #18952's merged diff (8223a93 against its parent 26e657f).

  • #19335 merged into cloud/1.54 at 4eeba25 on 2026-09-30. Its added and removed lines match #18952 in all seven files. undeliverableAskReporter.ts, agentTurnLockFixture.ts, and agentApprovalSurvivesSocketDrop.spec.ts on the current cloud/1.54 tip are byte-identical to main at 8223a93. That is why GitHub reports this PR as not mergeable: git merge-tree against origin/cloud/1.54 conflicts in all six files besides agentEventTransport.ts, including add/add conflicts on the reporter and the spec.
  • On this branch, agentEventTransport.ts matches the source exactly. The other six files diverge from #18952 in the inline-marked places. These divergences come from fb4fbcc, 441bfb1, and 5699b16. On main, the only later change to the reporter is #19230's error surface tags. So these are new behavior on a release branch, not a backport of a main fix.
  • At 5699b16, vitest run over agentEventTransport.test.ts and agentConversationStore.test.ts passed 98/98, and hosted checks passed against the old base. Passing checks do not change the outcome, because the intended change has already landed through #19335.

I think this PR should be closed as superseded by #19335. If the reporting changes below are wanted, they should go to main first and then be backported on their own.

activeTurnId?: string | null
}

const MAX_REPORTS_PER_SESSION = 32

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 keeps a 32-entry LRU of reported ask_ids (MAX_REPORTED_ASKS, evicting the oldest), and that is what is on cloud/1.54 now through #19335. This replaces it with a hard cap of 32 reports per session, so after 32 reports in a session every later undeliverable ask goes unreported. Neither #18952 nor main has this.

reason: UndeliverableAskReason,
context: UndeliverableAskContext = {}
): void {
const reportKey = `${data.thread_id}\u0000${data.ask_id}\u0000${reason}`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 dedupes on ask_id alone. Keying on thread, ask, and reason changes how many reports a single ask can produce. The new test "reports distinct failure reasons for the same ask once each" pins that, and it is not in the source.

level: 'warning',
tags: {
reason,
ask_kind: askKind,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 tags ask_kind: data.kind?.slice(0, 64) || 'missing'. Normalizing to run_approval / ask_user / other and moving the raw kind into context.askKind changes the emitted telemetry shape relative to main and to what cloud/1.54 already reports.

eventMessageId === undefined
? undefined
: departedTurns.get(departedTurnKey(eventThreadId, eventMessageId))
reportUndeliverableAsk(event, reason ?? 'no-live-turn')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 reports only when the departed-turn lookup yields a reason (if (reason) reportUndeliverableAsk(event, reason)). Falling back to 'no-live-turn' makes an ask for an untracked thread report too, which the source deliberately left quiet. This also inverts the source test "stays quiet for an ask belonging to an untracked thread", now "reports an ask belonging to an untracked thread" at agentConversationStore.test.ts:945.

expect(reportError).not.toHaveBeenCalled()
})

it('reports an ask belonging to an untracked thread', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the source's "stays quiet for an ask belonging to an untracked thread" with the assertion inverted. The same goes for the ask_kind: 'other' expectation further down, which the source writes as ask_kind: 'pick_a_model'. Both follow the non-source behavior changes above.

)
})

it('caps reports per session', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source's "bounds reported ask identities and evicts the oldest" (34 calls) is replaced by "caps reports per session" (32 calls). "reports distinct failure reasons for the same ask once each" is new, and "reports an unknown ask kind once with a bounded tag" now expects 'other'. These tests follow the reporter changes, not #18952.

status: this.streaming ? 'streaming' : 'complete',
workflow_id: WORKFLOW_ID
workflow_id: WORKFLOW_ID,
pending_ask: undefined

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 adds the fake server's pendingAsk state, recordAsk, primePendingAsk, and pendingAskIsPrimed, and serves pending_ask: this.pendingAsk here. cloud/1.54 already has zAgentPendingAsk and, through #19335, this exact fixture code. Removing it diverges from the source and from the target.

// The server is parked on this ask and will not proceed without an
// answer. `ws.send()` throws on a dead route, so pushing stays above
// test.fail() too.
turnLock.push(reconnected, RUN_APPROVAL_EVENT)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18952 asserts expect(turnLock.pendingAskIsPrimed()).toBe(false) in each of the three cases, which proves the approval cannot reach the panel through transcript hydration. This branch drops all three assertions. The copy of this spec now on cloud/1.54 through #19335 has them.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #19335 already carried the source change into cloud/1.54, and this branch now only adds divergent behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants