Repository navigation
[backport core/1.54] Report approval asks the panel never delivered (#18952) - #19344
Conversation
A turn parked waiting for the user to approve a tool call, the approval
prompt never reached the panel, and nothing anywhere recorded it — so
this PR makes that drop report, and pins the user's journey as a spec.
- **What**: `reportError('failure_delivering_agent_approval_ask')` at
the two reachable sites where an `agent_ask` frame is discarded, plus
`browser_tests/tests/agent/agentApprovalSurvivesSocketDrop.spec.ts`
reproducing the reported flow through the real socket and the rendered
panel.
A user asked for an img2img workflow, then for img2video, and the panel
went dead. They restarted the agent tab to get out of it.
A session-id trace established that **the backend never hung.** The turn
was alive the whole time, parked waiting for the user to approve a tool
call, and the approval prompt never made it into the panel. That is the
worst shape a stall can take: the product is working and waiting on the
user, while the user sees a dead panel and no way to answer.
**There was no telemetry for it at all.** It reached us through a
feedback form, not a dashboard — and only because that one user happened
to paste a session id.
`useAgentSession.onStatus(false)` answers a transient websocket close
with `abortActiveTurn()` + `dropBackgroundTurns()`. The server never
learned the socket went away, so it keeps running the turn and then
emits `agent_ask` for the approval it is parked on. By then `transport`
is null and `backgroundTurns` is empty, so the frame reaches
`ingestBackgroundTurnEvent`, hits `if (!entry …) return`, and is gone.
Nothing errors.
It is specifically the *socket blip*, not a refresh. On a refresh the
ask comes back, because the persisted row carries `pending_ask` and
`normalizeAgentTranscript` rebuilds the card — which is why restarting
the tab "fixed" it for this user, and why this class only ever surfaces
through a form.
Two sites, tagged by `reason` so they split on the dashboard:
| `reason` | Site | Why it is the same user-visible outcome |
|---|---|---|
| `no-live-turn` | `ingestBackgroundTurnEvent`, `!entry` | The
socket-drop teardown left nothing to route the ask to. |
| `unknown-kind` | `handleAskEvent`, `kind !== 'run_approval'` | Renders
no card while the server still parks on the ask. |
The third `return` in `ingest` (`eventThreadId === undefined`) is
**unreachable for an ask** — `zAgentAskEvent` is
`zAgentPendingAsk.extend({ thread_id: z.string() })`, and
`agent_active_tab` is the only event with an optional `thread_id`,
handled above it. It is commented rather than instrumented, because a
report at a dead branch is noise that reads as coverage.
Deliberately **not** a `pushError`: the user cannot act on it, and a
notice would replace a silent stall with a stall plus a scary message.
This is for the dashboard.
**The spec's first two cases are `test.fail()` pins, on purpose.**
Fixing the delivery itself needs the turn to survive the blip, and that
is [#18152](#18152) —
on `main` there is no turn-recovery path at all. So this PR lands the
telemetry and the reproduction now, standing alone, and the pins flip
green when the delivery fix lands on top of #18152. Neither piece is
hostage to that stack.
The third case pushes the **same ask with no socket drop** and must stay
green. That is what stops the two pins from going vacuous on a renamed
locator, a gate, or reworded copy — without it, a card that never
renders under this fixture at all would look exactly like the defect.
Run against a cloud dev server plus the e2e ComfyUI container:
```
✘ 1 the approval card reaches the panel after a reconnect (expected)
✘ 2 the user can answer the ask that arrived after the reconnect (expected)
✓ 3 the same ask renders when the socket never drops
✓ 4 the fixture pushes an ask the client can parse
4 passed (33.4s)
```
Pin 1 fails for the stated reason, not an incidental one — with
`test.fail()` removed:
```
Error: expect(locator).toBeVisible() failed
Locator: locator('#agent-panel-root').getByText('Do you approve?')
Error: element(s) not found
```
- Store and transport unit suites: `392 passed (392)`.
- Agent subtree: `Test Files 137 passed (137)`, `Tests 2338 passed | 17
expected fail (2355)` (the expected fails are pre-existing).
- The four new store cases are **red on `main` production code** (`2
failed | 2 passed`), and the two that fail are the two reporting
assertions while both "stays quiet" guards pass — so they are not
tautological.
- `typecheck:app`, `typecheck:browser`, ESLint, type-aware Oxlint, Oxfmt
and Knip clean.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1957 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T23:32:13.435Z",
"gitSha": "42dbcdc0227b77293ac199c3c3e82807a025696c",
"branch": "backport-18952-to-core-1.54-manual",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.2759999999244,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.225000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.684,
"heapDeltaBytes": -3783720,
"heapUsedBytes": 67359152,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.045,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2026.8200000000434,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.941,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.118,
"heapDeltaBytes": -10560244,
"heapUsedBytes": 59791632,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 6.823999999999996,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.2019999999484,
"styleRecalcs": 75,
"styleRecalcDurationMs": 20.517999999999997,
"layouts": 14,
"layoutDurationMs": 2.8179999999999996,
"taskDurationMs": 559.5550000000001,
"heapDeltaBytes": 24198932,
"heapUsedBytes": 87988592,
"domNodes": 37,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 95.83,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1736.4989999999807,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.805999999999997,
"layouts": 14,
"layoutDurationMs": 3.1830000000000003,
"taskDurationMs": 606.743,
"heapDeltaBytes": 5781224,
"heapUsedBytes": 76765572,
"domNodes": -277,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 93.766,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.5430000000897,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.599,
"layouts": 6,
"layoutDurationMs": 0.915,
"taskDurationMs": 253.529,
"heapDeltaBytes": 4636308,
"heapUsedBytes": 75412472,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.457,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.5440000000926,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.544,
"layouts": 6,
"layoutDurationMs": 1.115,
"taskDurationMs": 275.945,
"heapDeltaBytes": 4645608,
"heapUsedBytes": 76067552,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.413,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 532.9909999999245,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.922999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.312,
"heapDeltaBytes": 18104760,
"heapUsedBytes": 88311852,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 119.35299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 513.4550000000218,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.08,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.02500000000003,
"heapDeltaBytes": -8285512,
"heapUsedBytes": 63057088,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 109.60700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.9510000000964,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.836,
"heapDeltaBytes": 10678428,
"heapUsedBytes": 87549048,
"domNodes": -268,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 25.179999999999993,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.2099999999782,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.127999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.18,
"heapDeltaBytes": 9413028,
"heapUsedBytes": 85657348,
"domNodes": -267,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 30.109999999999992,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2137.0880000000625,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.221,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1215.7450000000001,
"heapDeltaBytes": 8269080,
"heapUsedBytes": 85476352,
"domNodes": -270,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 564.371,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2117.6719999999705,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.232000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1167.096,
"heapDeltaBytes": 7348020,
"heapUsedBytes": 84876552,
"domNodes": -272,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 543.346,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3231.1109999999417,
"styleRecalcs": 61,
"styleRecalcDurationMs": 12.161999999999999,
"layouts": 60,
"layoutDurationMs": 13.99,
"taskDurationMs": 1367.151,
"heapDeltaBytes": 7756496,
"heapUsedBytes": 75426368,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 593.1220000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3270.8790000000363,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.108,
"layouts": 60,
"layoutDurationMs": 12.729999999999999,
"taskDurationMs": 1317.4660000000001,
"heapDeltaBytes": 536884,
"heapUsedBytes": 79765816,
"domNodes": -288,
"jsHeapTotalBytes": 1208320,
"scriptDurationMs": 556.7740000000001,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2292.0070000000123,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.880000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1449.526,
"heapDeltaBytes": -8903288,
"heapUsedBytes": 71732116,
"domNodes": -253,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 688.64,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2137.6599999999826,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.811,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1274.375,
"heapDeltaBytes": 13912140,
"heapUsedBytes": 82134904,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 593.032,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.0280000000203,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.219999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.9039999999999,
"heapDeltaBytes": 5673024,
"heapUsedBytes": 82830708,
"domNodes": -278,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 34.92499999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.6620000000912,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.621999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.729,
"heapDeltaBytes": 9538524,
"heapUsedBytes": 88224416,
"domNodes": -266,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 24.547999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 429.9620000000459,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 282.862,
"heapDeltaBytes": 14754984,
"heapUsedBytes": 88119216,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 90.599,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 492.6749999999629,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.537000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.80400000000003,
"heapDeltaBytes": 14226716,
"heapUsedBytes": 86511600,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 95.74199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.5189999999548,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.6129999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.36400000000003,
"heapDeltaBytes": 7615924,
"heapUsedBytes": 80106592,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.712000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1994.1460000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.594999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.788,
"heapDeltaBytes": 3032044,
"heapUsedBytes": 76185776,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.778,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2310000000589,
"styleRecalcs": 77,
"styleRecalcDurationMs": 19.272,
"layouts": 18,
"layoutDurationMs": 3.6830000000000007,
"taskDurationMs": 629.503,
"heapDeltaBytes": -8318324,
"heapUsedBytes": 64257228,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 78.972,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.471000000026,
"styleRecalcs": 79,
"styleRecalcDurationMs": 18.733,
"layouts": 18,
"layoutDurationMs": 3.413,
"taskDurationMs": 589.1959999999999,
"heapDeltaBytes": -2954388,
"heapUsedBytes": 69336288,
"domNodes": -265,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 67.439,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 881.4910000000964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.433,
"layouts": 16,
"layoutDurationMs": 9.690999999999999,
"taskDurationMs": 630.1269999999998,
"heapDeltaBytes": -6949672,
"heapUsedBytes": 83546996,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.770999999999997,
"eventListeners": 2385,
"totalBlockingTimeMs": 99,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.802999999992,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.979,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4112.870999999999,
"heapDeltaBytes": -8334280,
"heapUsedBytes": 68256464,
"domNodes": -276,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 1823.15,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8113.269999999943,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.160999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4005.4620000000004,
"heapDeltaBytes": -13677384,
"heapUsedBytes": 89607600,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 1763.8529999999998,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12366.396999999892,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11424.197999999999,
"heapDeltaBytes": -39960084,
"heapUsedBytes": 179612092,
"domNodes": -8068,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 188.90699999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12137.350999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11288.941,
"heapDeltaBytes": -39323164,
"heapUsedBytes": 178587124,
"domNodes": -8068,
"jsHeapTotalBytes": -12595200,
"scriptDurationMs": 185.629,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14986.234999999964,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.036999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14459.502,
"heapDeltaBytes": -55180732,
"heapUsedBytes": 164178464,
"domNodes": -8068,
"jsHeapTotalBytes": -17784832,
"scriptDurationMs": 800.713,
"eventListeners": -14933,
"totalBlockingTimeMs": 49,
"frameDurationMs": 16.670000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14175.136000000066,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.254000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13619.551000000001,
"heapDeltaBytes": -66142764,
"heapUsedBytes": 166665832,
"domNodes": -8068,
"jsHeapTotalBytes": -19337216,
"scriptDurationMs": 802.965,
"eventListeners": -14933,
"totalBlockingTimeMs": 10,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4401.373000000035,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.579,
"layouts": 20,
"layoutDurationMs": 35.979,
"taskDurationMs": 4261.397999999999,
"heapDeltaBytes": -30736964,
"heapUsedBytes": 177807216,
"domNodes": -8068,
"jsHeapTotalBytes": 7405568,
"scriptDurationMs": 75.562,
"eventListeners": -14933,
"totalBlockingTimeMs": 143,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4239.66299999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.73799999999999,
"layouts": 20,
"layoutDurationMs": 22.763000000000005,
"taskDurationMs": 4092.732000000001,
"heapDeltaBytes": -34915124,
"heapUsedBytes": 178435020,
"domNodes": -8068,
"jsHeapTotalBytes": 5189632,
"scriptDurationMs": 99.074,
"eventListeners": -14933,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6221.441000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5750.662,
"heapDeltaBytes": 9307232,
"heapUsedBytes": 182952844,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 107.86800000000008,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5694.449000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5346.0199999999995,
"heapDeltaBytes": 877292,
"heapUsedBytes": 168634168,
"domNodes": -1,
"jsHeapTotalBytes": -11010048,
"scriptDurationMs": 73.56400000000002,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 444.3610000000717,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.389,
"layouts": 2,
"layoutDurationMs": 0.9910000000000001,
"taskDurationMs": 90.39699999999999,
"heapDeltaBytes": 4900680,
"heapUsedBytes": 73129716,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.839999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 442.37599999996746,
"styleRecalcs": 19,
"styleRecalcDurationMs": 14.015,
"layouts": 2,
"layoutDurationMs": 0.9390000000000001,
"taskDurationMs": 79.899,
"heapDeltaBytes": 4883004,
"heapUsedBytes": 72548972,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.0539999999999985,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🔴 Critical | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 5 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19344 +/- ##
============================================
Coverage 83.90% 83.90%
============================================
Files 2109 2110 +1
Lines 125971 126053 +82
Branches 33837 31991 -1846
============================================
+ Hits 105701 105771 +70
- Misses 20091 20103 +12
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
#19337 and #19344 both backport #18952 to core/1.54, so only one should land. Which one should it be? Both also add telemetry hardening beyond #18952 that isn't on |
Manual backport of #18952 (reports approval prompts that the panel drops after a socket disconnect) after the automated cherry-pick reported conflicts. The resolution preserves the release branch active-turn state while adding the telemetry thread identity and unsupported-ask reporting.
Validation: conflict markers and diff checks pass. Focused local tests could not start because the available shared dependency tree does not match this release branch; hosted CI is required.