Repository navigation
[backport core/1.54] fix(agent): report an approval ask the panel never delivered (#18952) - #19337
christian-byrne wants to merge 4 commits into
Conversation
(cherry picked from commit 8223a93)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
Release-backport self-review at exact head 70df068e2ed4eb84cff8ef837f74b766d9875eb3: reviewed all seven source paths against merged #18952 and live core/1.54. Both conflicts preserve the target line’s transport/store shape while adding only the source telemetry ledger and routing behavior; all browser fixture/spec hunks are retained. Focused tests pass 95/95, both app/browser typechecks pass, lint has zero errors, and removing the ask-id ledger insertion makes the dedupe oracle fail with two reports. The release browser run currently stops at the target gate-settlement precondition before the approval oracle; no assertion was weakened. Hosted exact-head checks and target-aware merge guard remain required.
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1957 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T06:54:46.146Z",
"gitSha": "29c56c4c41862a271ce8fa8b739a73eae15619c5",
"branch": "backport-18952-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.525999999928,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.36,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.00000000000006,
"heapDeltaBytes": -11731528,
"heapUsedBytes": 58968812,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.416,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2009.9079999999958,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.7299999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.028,
"heapDeltaBytes": -11780744,
"heapUsedBytes": 59221736,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.28,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.790000000069,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.457,
"layouts": 14,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 583.5740000000001,
"heapDeltaBytes": 7648084,
"heapUsedBytes": 78967328,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 87.05499999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1716.9400000000223,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.334000000000003,
"layouts": 14,
"layoutDurationMs": 2.947,
"taskDurationMs": 611.337,
"heapDeltaBytes": -7926404,
"heapUsedBytes": 62222848,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 93.551,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.239000000025,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.991,
"layouts": 6,
"layoutDurationMs": 0.9430000000000001,
"taskDurationMs": 259.34100000000007,
"heapDeltaBytes": 4311896,
"heapUsedBytes": 73839616,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.407999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.425999999954,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.517999999999999,
"layouts": 6,
"layoutDurationMs": 0.9420000000000002,
"taskDurationMs": 273.845,
"heapDeltaBytes": 4314100,
"heapUsedBytes": 74455616,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.196000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 524.0529999999808,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.704,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.26599999999996,
"heapDeltaBytes": 18428968,
"heapUsedBytes": 88817384,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 101.87599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 500.1729999999043,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.765,
"heapDeltaBytes": 18633404,
"heapUsedBytes": 88212024,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 104.573,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.004999999912,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.835999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.334,
"heapDeltaBytes": 22164524,
"heapUsedBytes": 87764972,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.147000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2025.1909999999498,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.384999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.39799999999997,
"heapDeltaBytes": 6284520,
"heapUsedBytes": 82786828,
"domNodes": -272,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 30.830000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2088.820999999939,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.235000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1043.594,
"heapDeltaBytes": -18092236,
"heapUsedBytes": 85442672,
"domNodes": -270,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 473.928,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2117.0019999999568,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.344,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1228.661,
"heapDeltaBytes": 4165092,
"heapUsedBytes": 81562584,
"domNodes": -245,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 586.2819999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3059.1229999999996,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.238,
"layouts": 60,
"layoutDurationMs": 10.767000000000001,
"taskDurationMs": 1179.103,
"heapDeltaBytes": 8090308,
"heapUsedBytes": 75847188,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 501.62600000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3165.7749999999396,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.564000000000002,
"layouts": 60,
"layoutDurationMs": 12.213999999999999,
"taskDurationMs": 1242.1419999999998,
"heapDeltaBytes": 9184840,
"heapUsedBytes": 76613384,
"domNodes": -278,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 537.213,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2152.4799999999686,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.394999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1296.013,
"heapDeltaBytes": 14066696,
"heapUsedBytes": 81708204,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 620.875,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2153.4900000000334,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.017000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1257.0420000000001,
"heapDeltaBytes": 13589292,
"heapUsedBytes": 81529828,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 588.5250000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2011.4869999999883,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.2230000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.1830000000001,
"heapDeltaBytes": 10520280,
"heapUsedBytes": 87753212,
"domNodes": -272,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 28.830000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.4000000001706,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.254,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.80600000000004,
"heapDeltaBytes": 9874768,
"heapUsedBytes": 88238664,
"domNodes": -266,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 29.852000000000004,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.5380000000696,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.807,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.86600000000004,
"heapDeltaBytes": 13942672,
"heapUsedBytes": 86444712,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 87.83,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 462.6189999999042,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.571000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.204,
"heapDeltaBytes": 14276864,
"heapUsedBytes": 86759452,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 87.86400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2019.1300000000183,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.367,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 353.921,
"heapDeltaBytes": 9312928,
"heapUsedBytes": 81736552,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.721000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1993.141000000037,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.013999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 317.236,
"heapDeltaBytes": 1214992,
"heapUsedBytes": 67418984,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6.135999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.9410000000134,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.267,
"layouts": 18,
"layoutDurationMs": 3.056,
"taskDurationMs": 567.328,
"heapDeltaBytes": -4224688,
"heapUsedBytes": 68568068,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 63.577999999999996,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.9139999999406,
"styleRecalcs": 79,
"styleRecalcDurationMs": 17.984,
"layouts": 18,
"layoutDurationMs": 3.104,
"taskDurationMs": 583.1990000000001,
"heapDeltaBytes": -11564,
"heapUsedBytes": 72493140,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 66.054,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 865.8370000000559,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.931,
"layouts": 16,
"layoutDurationMs": 10.238999999999997,
"taskDurationMs": 661.481,
"heapDeltaBytes": -3407084,
"heapUsedBytes": 89612784,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 20.857,
"eventListeners": 2385,
"totalBlockingTimeMs": 109,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8147.870000000012,
"styleRecalcs": 250,
"styleRecalcDurationMs": 35.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4090.675,
"heapDeltaBytes": 10409980,
"heapUsedBytes": 86542856,
"domNodes": -265,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 1811.164,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8111.006999999972,
"styleRecalcs": 248,
"styleRecalcDurationMs": 28.322,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3811.292,
"heapDeltaBytes": 23131384,
"heapUsedBytes": 89798064,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 1699.967,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11108.411999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10162.521,
"heapDeltaBytes": -36688804,
"heapUsedBytes": 177277700,
"domNodes": -8068,
"jsHeapTotalBytes": -14475264,
"scriptDurationMs": 175.34499999999997,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11653.714000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10720.246,
"heapDeltaBytes": -36506096,
"heapUsedBytes": 182264832,
"domNodes": -8068,
"jsHeapTotalBytes": -11792384,
"scriptDurationMs": 159.51299999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 11458.124999999996,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.300000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10698.001999999999,
"heapDeltaBytes": -33438464,
"heapUsedBytes": 174563220,
"domNodes": -8068,
"jsHeapTotalBytes": -9396224,
"scriptDurationMs": 645.492,
"eventListeners": -14935,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14633.015999999998,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.462000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14038.896999999999,
"heapDeltaBytes": -33526392,
"heapUsedBytes": 171192568,
"domNodes": -8068,
"jsHeapTotalBytes": -9740288,
"scriptDurationMs": 753.591,
"eventListeners": -14931,
"totalBlockingTimeMs": 33,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4134.565000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.97099999999999,
"layouts": 20,
"layoutDurationMs": 22.204,
"taskDurationMs": 4002.2209999999995,
"heapDeltaBytes": -34379788,
"heapUsedBytes": 183913428,
"domNodes": -8068,
"jsHeapTotalBytes": 12361728,
"scriptDurationMs": 71.40499999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 1,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4185.120999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.268000000000015,
"layouts": 20,
"layoutDurationMs": 24.377999999999997,
"taskDurationMs": 4119.228000000001,
"heapDeltaBytes": -49803264,
"heapUsedBytes": 168473320,
"domNodes": -8072,
"jsHeapTotalBytes": 17305600,
"scriptDurationMs": 72.93100000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 71,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6285.651999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5742.494000000001,
"heapDeltaBytes": 7883696,
"heapUsedBytes": 186028220,
"domNodes": 0,
"jsHeapTotalBytes": -18087936,
"scriptDurationMs": 89.50099999999999,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6214.627000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5830.774,
"heapDeltaBytes": -1198168,
"heapUsedBytes": 180325224,
"domNodes": 0,
"jsHeapTotalBytes": -27525120,
"scriptDurationMs": 87.41500000000002,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 81.55099999999038,
"styleRecalcs": 6,
"styleRecalcDurationMs": 9.014999999999999,
"layouts": 2,
"layoutDurationMs": 0.8939999999999999,
"taskDurationMs": 48.717999999999996,
"heapDeltaBytes": 3138668,
"heapUsedBytes": 71898836,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.6160000000000005,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 76.63900000011381,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.716000000000001,
"layouts": 2,
"layoutDurationMs": 1.268,
"taskDurationMs": 46.80899999999999,
"heapDeltaBytes": 2981060,
"heapUsedBytes": 71423368,
"domNodes": 122,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.156000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #19337 +/- ##
=============================================
+ Coverage 83.84% 83.90% +0.06%
=============================================
Files 2109 2110 +1
Lines 125512 125627 +115
Branches 31799 31854 +55
=============================================
+ Hits 105230 105403 +173
+ Misses 20103 20045 -58
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head self-review at b647c8d25aba77a6094f0bedd1c627df164db4c8: reviewed all ten automated findings against current source. Five lifecycle/idempotency/cardinality defects were fixed in one ordinary commit; five findings were invalid or stale with evidence in-thread. The fix preserves every #18952 production, telemetry, browser, expected-failure, and non-vacuity hunk while adding focused regressions. Focused transport/store suites pass 98/98; app and browser typechecks pass. A three-guard mutation made exactly the report-budget, post-settle replay, and replaced-background-turn regressions fail, then restoration returned green. All automated threads are replied to and resolved. This head movement spent no approval because none existed; fresh hosted checks and the target-aware core/1.54 gate remain required, and no merge is attempted.
|
#19337 and #19344 both backport #18952 to core/1.54, so only one should land. Which one should it be? Both also add telemetry hardening beyond #18952 that isn't on |
Backport of merged #18952 to
core/1.54.Source merge:
8223a93de30cd630338924e923e2f6fe9bb9d6e6.Target tip at construction:
d66992c56516a8076bc1e774a4f2097bb96429a6.All seven source paths are retained, including the complete
browser_tests/fixture and black-box spec contract. The two product conflicts were adapted to the release-line transport/store shape without importing unrelated main-only draft, paywall, approval-timing, or active-thread context. Source authorship is preserved; the copied AI co-author trailers were removed under the standing release message-only exception, with tree content unchanged by that message rewrite.Local evidence at exact head
70df068e2ed4eb84cff8ef837f74b766d9875eb3:typecheck:appandtypecheck:browser: passeddata-agent-gate-settledbecause the target fixture never observes gate settlement, before the approval oracle. This carrier does not weaken that precondition. Hosted release checks and the exact-head target guard remain binding.