Repository navigation
[backport core/1.55] FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success - #19308
Conversation
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (47 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b5f3d2e3dbcf672d12c49cc3483ddc2dfc571442
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2119 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T04:08:41.530Z",
"gitSha": "ffa7da49435b7179b988f27ace94f3b529d69206",
"branch": "backport-19099-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.4110000000042,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.415000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.93199999999996,
"heapDeltaBytes": -9149784,
"heapUsedBytes": 58556200,
"domNodes": -257,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.4540000000000015,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2000.2979999999866,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 369.843,
"heapDeltaBytes": -8077972,
"heapUsedBytes": 59921440,
"domNodes": -259,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.467000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.262999999978,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.5279999999999,
"heapDeltaBytes": -4540380,
"heapUsedBytes": 57959588,
"domNodes": -257,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.43400000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1691.7139999999904,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.834000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.669,
"heapDeltaBytes": 11188024,
"heapUsedBytes": 78728072,
"domNodes": -257,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.505,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.1500000000365,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.147,
"layouts": 6,
"layoutDurationMs": 0.701,
"taskDurationMs": 199.64300000000003,
"heapDeltaBytes": 3090960,
"heapUsedBytes": 70426240,
"domNodes": 79,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8.335000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1701.0759999999436,
"styleRecalcs": 28,
"styleRecalcDurationMs": 10.653999999999998,
"layouts": 6,
"layoutDurationMs": 0.8130000000000001,
"taskDurationMs": 249.427,
"heapDeltaBytes": 3165060,
"heapUsedBytes": 70904852,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.832999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 520.1150000000325,
"styleRecalcs": 15,
"styleRecalcDurationMs": 6.912999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.986,
"heapDeltaBytes": 18996416,
"heapUsedBytes": 85647032,
"domNodes": 25,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 117.68599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 461.9519999999966,
"styleRecalcs": 15,
"styleRecalcDurationMs": 6.545999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.94599999999997,
"heapDeltaBytes": 18658192,
"heapUsedBytes": 86288104,
"domNodes": 25,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 117.35200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1018.0270000000178,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 677.4889999999999,
"heapDeltaBytes": -17869156,
"heapUsedBytes": 72727636,
"domNodes": -293,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 43.462,
"eventListeners": -217,
"totalBlockingTimeMs": 389,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 971.2089999999876,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.477,
"heapDeltaBytes": 38547128,
"heapUsedBytes": 107593112,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 42.26999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 382,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 716.557000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.10400000000016,
"heapDeltaBytes": 14582760,
"heapUsedBytes": 89998740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 95.666,
"eventListeners": 0,
"totalBlockingTimeMs": 111,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 732.0979999999508,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.06100000000004,
"heapDeltaBytes": 14623668,
"heapUsedBytes": 91540100,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 93.668,
"eventListeners": 0,
"totalBlockingTimeMs": 109,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6539.31399999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.9410000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5733.056,
"heapDeltaBytes": 15294004,
"heapUsedBytes": 97661904,
"domNodes": -14,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 4727.727,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6090.1690000000035,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.7330000000000019,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5125.664,
"heapDeltaBytes": 12718728,
"heapUsedBytes": 89314892,
"domNodes": -257,
"jsHeapTotalBytes": 9428992,
"scriptDurationMs": 4166.599,
"eventListeners": -174,
"totalBlockingTimeMs": 22,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6386.149999999987,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.390999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5623.490000000001,
"heapDeltaBytes": 20213456,
"heapUsedBytes": 94429088,
"domNodes": 2,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 4440.188,
"eventListeners": 0,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6171.857999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.5929999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5195.308,
"heapDeltaBytes": -9503668,
"heapUsedBytes": 72892764,
"domNodes": -12,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 4037.006,
"eventListeners": 0,
"totalBlockingTimeMs": 29,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 1998.2409999999504,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.919,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.887,
"heapDeltaBytes": 19805916,
"heapUsedBytes": 83780072,
"domNodes": -237,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.058999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2012.7430000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.6880000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.614,
"heapDeltaBytes": -4069784,
"heapUsedBytes": 83569744,
"domNodes": -237,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 21.926999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2098.871000000031,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.661999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1115.8359999999998,
"heapDeltaBytes": 15710220,
"heapUsedBytes": 80115496,
"domNodes": -239,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 542.096,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2104.577000000063,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1158.251,
"heapDeltaBytes": -12978548,
"heapUsedBytes": 69243156,
"domNodes": -205,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 542.7220000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3120.117999999991,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.609000000000002,
"layouts": 60,
"layoutDurationMs": 8.516000000000002,
"taskDurationMs": 1205.293,
"heapDeltaBytes": -17814940,
"heapUsedBytes": 65545732,
"domNodes": -257,
"jsHeapTotalBytes": 3698688,
"scriptDurationMs": 509.3759999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3058.87400000006,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.058,
"layouts": 60,
"layoutDurationMs": 8.341999999999999,
"taskDurationMs": 1136.8300000000002,
"heapDeltaBytes": 9436588,
"heapUsedBytes": 74490760,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 495.85,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2228.771999999992,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.099,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1351.2210000000002,
"heapDeltaBytes": -17600076,
"heapUsedBytes": 73910196,
"domNodes": -213,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 647.1279999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2153.9920000000166,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.018999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1280.1299999999999,
"heapDeltaBytes": 20880496,
"heapUsedBytes": 86884056,
"domNodes": 10,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 625.783,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.0559999999973,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.474000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.196,
"heapDeltaBytes": -10381872,
"heapUsedBytes": 78976680,
"domNodes": -245,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 21.944000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1994.8669999999993,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.2039999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.85200000000003,
"heapDeltaBytes": 20142216,
"heapUsedBytes": 84772452,
"domNodes": 14,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.523000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 429.8860000000104,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.40600000000006,
"heapDeltaBytes": 13718736,
"heapUsedBytes": 76876136,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 95.68900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 447.4519999999984,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.254000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 282.04200000000003,
"heapDeltaBytes": 14088568,
"heapUsedBytes": 83959340,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 97.19599999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2007.045000000005,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.329999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.54900000000004,
"heapDeltaBytes": 9699320,
"heapUsedBytes": 79789464,
"domNodes": -271,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.148000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.6970000000447,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.558999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.333,
"heapDeltaBytes": -6036128,
"heapUsedBytes": 64052896,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 5.963000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.6540000000182,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.664,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.4159999999999,
"heapDeltaBytes": -4247388,
"heapUsedBytes": 58997496,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 64.98799999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.049000000011,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.204,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.2629999999999,
"heapDeltaBytes": -4496464,
"heapUsedBytes": 58774396,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 64.187,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 833.2560000000058,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.053,
"layouts": 5,
"layoutDurationMs": 8.276999999999997,
"taskDurationMs": 642.5779999999999,
"heapDeltaBytes": -10087464,
"heapUsedBytes": 82908780,
"domNodes": 13667,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 17.350000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 100,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8158.201000000019,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.347,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3747.8679999999995,
"heapDeltaBytes": -15625416,
"heapUsedBytes": 72140972,
"domNodes": -207,
"jsHeapTotalBytes": 5795840,
"scriptDurationMs": 1959.0189999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8143.705999999952,
"styleRecalcs": 252,
"styleRecalcDurationMs": 21.688000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3968.651,
"heapDeltaBytes": -19491824,
"heapUsedBytes": 67889524,
"domNodes": -236,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 1838.6719999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10537.410000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9783.344,
"heapDeltaBytes": -45610488,
"heapUsedBytes": 174681420,
"domNodes": -8062,
"jsHeapTotalBytes": -12386304,
"scriptDurationMs": 107.22499999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10501.34199999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9790.618999999999,
"heapDeltaBytes": -27898684,
"heapUsedBytes": 184870316,
"domNodes": -8062,
"jsHeapTotalBytes": -10731520,
"scriptDurationMs": 104.324,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12849.63700000003,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.606000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12208.439000000002,
"heapDeltaBytes": -49673424,
"heapUsedBytes": 191074184,
"domNodes": -8062,
"jsHeapTotalBytes": -22417408,
"scriptDurationMs": 596.133,
"eventListeners": -14928,
"totalBlockingTimeMs": 105,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 12740.552999999978,
"styleRecalcs": 66,
"styleRecalcDurationMs": 7.733000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12032.294,
"heapDeltaBytes": -43186344,
"heapUsedBytes": 182520180,
"domNodes": -8062,
"jsHeapTotalBytes": -17571840,
"scriptDurationMs": 516.88,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3772.4430000000098,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.74999999999999,
"layouts": 20,
"layoutDurationMs": 14.632999999999994,
"taskDurationMs": 3636.4159999999997,
"heapDeltaBytes": -17889448,
"heapUsedBytes": 195518800,
"domNodes": -8061,
"jsHeapTotalBytes": 17055744,
"scriptDurationMs": 45.916000000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 3892.533999999955,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.318000000000005,
"layouts": 20,
"layoutDurationMs": 14.700000000000005,
"taskDurationMs": 3724.056,
"heapDeltaBytes": -68913120,
"heapUsedBytes": 176636012,
"domNodes": -8062,
"jsHeapTotalBytes": 851968,
"scriptDurationMs": 96.391,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5284.0119999999615,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5011.346,
"heapDeltaBytes": -33695180,
"heapUsedBytes": 169650436,
"domNodes": 0,
"jsHeapTotalBytes": -33816576,
"scriptDurationMs": 49.61099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5274.535000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4982.671000000001,
"heapDeltaBytes": -9619824,
"heapUsedBytes": 179133000,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 52.599000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.13000000001557,
"styleRecalcs": 21,
"styleRecalcDurationMs": 21.448999999999998,
"layouts": 5,
"layoutDurationMs": 1.791,
"taskDurationMs": 109.30599999999998,
"heapDeltaBytes": 5251420,
"heapUsedBytes": 71131124,
"domNodes": 154,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.484,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 64.49600000007649,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.618,
"layouts": 2,
"layoutDurationMs": 0.3879999999999999,
"taskDurationMs": 43.888999999999996,
"heapDeltaBytes": 3055284,
"heapUsedBytes": 68138804,
"domNodes": 102,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.453,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
This comment has been minimized.
This comment has been minimized.
…tor, card form and success (#19099) - Linear: FE-3046 **Merge order:** #19096 (ADR 0034 amendment) merges first. Until it does, ADR 0034 rule 4 still forbids account-ui from using the design system, which B does. ## Why billing-web is the cloud app's embedded checkout moved to a new tab, with no UX change (ADR BILLING-WEB-0038, #19096). Today billing-web renders a checkout of its own (`EmbeddedCheckout`, `CheckoutPayment`, `CheckoutSubmit`) that has drifted from the app's: different price layout, no saved-card selection, different copy. For both to render the same screens, the app's confirm, price breakdown, saved-card selector, card form, terms notice and success step have to live where both can import them. This PR adds them to `@comfyorg/account-ui`. Nothing renders them yet, so no visual change. ## How - New entry `@comfyorg/account-ui/billing/checkout`, ported line for line from the app components. Same markup, same classes, same conditions: - `CheckoutSubscribeConfirm` ← `SubscriptionAddPaymentPreviewWorkspace.vue` (plan header, credits, total due, discounts, promo code, saved methods, card form, 3DS prompt, parked-checkout recovery, terms). - `CheckoutTransitionConfirm` ← `SubscriptionTransitionPreviewWorkspace.vue` (immediate vs scheduled change, reactivation banner and threshold checkbox). - `CheckoutSavedMethods` + `CheckoutSavedMethodSelect` ← the saved-method row / `SingleSelect` picker (Reka select with the app's select classes). - `CheckoutPaymentForm` ← `UnifiedStripePaymentSelector.vue` minus the app bindings (key, theme and telemetry become props and a `phase` event). - `CheckoutSuccess` ← `SubscriptionSuccessWorkspace.vue`, with `details`/`actions` slots for the app's team invite. - `CheckoutTermsNote`, `CheckoutPromotionCode`, `CheckoutPaymentNotices`, `CheckoutVerificationPrompt`: blocks both confirms repeated. `CheckoutSubscribeSummary`/`CheckoutSubscribeActions` and `CheckoutReactivationBanner`/`CheckoutTransitionSummary` split the two confirm templates under the fallow complexity gate; the rendered markup is the same. - `checkoutQuote.ts`: the app's `subscriptionQuoteFormatting.ts` + `planDuration.ts`. - `@comfyorg/account-ui/billing/catalog` (TS-only entry): the tiers' prices and monthly credit grants (the numbers in the app's `TIER_PRICING`). The app's confirm reads the grant from this table (`TIER_PRICING`), not from the quote's `new_plan.credits_cents`, so billing-web reads the same table to show the same number; C points the app at it. A separate entry so non-Vue consumers (the Playwright runner imports `tierPricing`) never load the components. - The package has no i18n runtime. Hosts pass a typed `CheckoutCopy`; interpolated strings are functions, and sentences that wrap an element (terms links, reactivation amount) keep `{token}`s that the component splits. - Hosts pass a resolved `CheckoutPlan` (name, monthly/yearly price, credits, `pricedByQuote`) instead of the package reading the tier catalog. - `selectVariants` moves to `@comfyorg/design-system/select.variants` (same move as `buttonVariants` in #19098), so the picker renders the app's select classes. - Packaging: `design-system` variants and `tailwind-utils`'s `cn` are bundled into the published build (dev dependencies). `tailwind-utils` is not on npm and `design-system` ships TS source, so neither can be a runtime dependency of a published package. `reka-ui` is a peer. The rendered classes need the design-system theme and primeicons at runtime, so `@comfyorg/design-system` and `primeicons` are peers too, and the package description says to load their CSS and add the package's dist to the consumer's Tailwind sources. The smoke test imports the new entry in the typed consumer and treats it as bundler-only, like `billing/stripe`. ### Reactivation renewal date (live testcloud recording) The reactivation notice and the summary could name different renewal days for the same quote. On `m2-qa-0925-3ds` the notice said "renew … on Oct 27" and the summary "Renews … on Oct 25, 2026". - **Summary:** reads `renewal_at ?? new_plan.period_end` (`resolveRenewalDate`). - **Notice:** read `new_plan.period_end` only. When that was absent, it computed `effective_at` + one period on the client (Sep 27 + 1 month = Oct 27). - **Not a server inconsistency:** the server sent one renewal date, `renewal_at`, which the contract defines as "the next recurring charge and target-plan period end". - **Fix:** the notice now reads the same server date as the summary (`resolveRenewalDate`: `renewal_at`, else the plan's server `period_end`). The client-side computation is gone. With no server date, the notice drops its renewal clause through new `reactivation.withoutRenewalDate` copy, the way the summary drops its date. - **Contract:** `renewal_at` is optional in `PreviewSubscribeResponse` ("Optional in the schema for older clients"; "current servers always return this"). The server should always send it; the client no longer computes one when it doesn't. - **Tests:** - A new test fails on the old code (Oct 27 vs Oct 25). - The tests that pinned the client computation (account-ui and the app's `SubscriptionTransitionPreviewWorkspaceReactivation.test.ts`, in C) are replaced by a no-renewal-date test. - C adds the app's `withoutRenewalDate` strings. ## Review Focus - The ports are meant to be verbatim. C (the next PR) swaps the app onto these components and the app's existing component tests (about 2,100 lines across the two confirms and the success step) pass with only stub names changed. That is the parity check. - `CheckoutPlan.pricedByQuote` reproduces the app's price rules exactly, including the odd ones: a tier plan shows the quote's price once one arrives and `$0` on the success step without one; a team credit stop always shows its own price. ## Stack | PR | branch | base | title | |---|---|---|---| | #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection` | | A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system` | | **B (this PR)** | **`jaewon/account-ui-checkout-surfaces`** | **A** | **`FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success`** | | C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046 refactor(workspace): render the subscription checkout steps from account-ui` | | D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046 feat(billing-web): render the shared embedded checkout` | | E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046 feat(billing-web): invite your team from the checkout success step` | | F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047 fix(account-ui): clear decline toasts once a retry succeeds` | | G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048 fix(billing-web): return to the host by closing the checkout tab` | | H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step` | ```mermaid graph LR P0[#19097: remove plan grid] --> A[A: design-system buttonVariants] A --> B[B: account-ui checkout surfaces] B --> C[C: workspace adopts account-ui] C --> D[D: billing-web shared checkout] D --> E[E: billing-web success invite] E --> F[F: stale decline toasts] F --> G[G: close the billing tab] G --> H[H: reachable checkout CTA] style B fill:#f9d71c,stroke:#333,color:#000 ``` ## AS IS / TO BE No rendered change: nothing renders these components in this PR. The parity screenshots are on C (#19100, app before/after, pixel-identical) and D (#19101, billing-web before/after next to the app). --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
aaeb3c7 to
4e98802
Compare
…9099, #19100, #19101, #19104) (#19442) ## Why Backport of the FE-3046 billing-web shared-checkout stack to `core/1.55`. The auto-backport bot hit cherry-pick conflicts on each of these. The 1.55 release needs billing-web to render the same checkout as the app, including the team invite on success. ## How ### Cherry-picked (in order, `-x`) | PR | main squash | | |---|---|---| | #19098 (A) | | skipped: already on `core/1.55` via #19231 | | #19099 (B) | | skipped: already on `core/1.55` via #19308 | | #19100 (C) | `4bfdc8a68c` | render the subscription checkout steps from account-ui | | #19101 (D) | `d5cf71ce27` | billing-web renders the shared embedded checkout | | #19104 (E) | `592588bdd6` | team invite on the checkout success step (squash includes #19105, #19106, #19115) | No other prerequisite was cherry-picked. ### Conflicts and resolutions - **C, `SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`** (renamed from `UnifiedStripePaymentSelector.test.ts`). 1.55 mocks telemetry with an explicit factory because it lacks #18497; main automocks it. Took C's file as is. `src/platform/telemetry/__mocks__/index.ts` exists on 1.55, so the automock resolves and the test passes. - **D, `apps/billing-web/src/views/CheckoutView.vue`**. 1.55 has #19305 (backport of #19185, show the server's refusal reason), which main does not have yet. Kept D's checkout and kept 1.55's `refusal()` on the subscribe failure and the quote-failure panel. Also used `refusal()` for D's new promotion-code re-quote failure, as the upstream `jaewon/checkout-quote-stale-recovery` stack does. Dropped the now-unused `coded`. - **E, `apps/billing-web/src/session/billingWebAuth.ts`** (modify/delete). The file does not exist on 1.55 because the unified web session work (#18880, #18881) is not backported. Deleted it and applied E's change to what 1.55 has: `billingWebClient.ts` gains the `BillingWebClient` type (`BillingClient & { invites }`) and `invites: createWorkspaceInviteCommands({ transport })` on its single `createBillingWebClient`. - **E, `BillingShell.vue`**. Kept 1.55's `createBillingWebClient(billingWebSessionClient())` and added E's `provideWorkspaceInvites(client.invites)`. - **E, `HostedSurface.vue`**. Kept 1.55's `useBillingWebSession` and added E's `returnToHost` import (the return link now closes the tab, from #19106). - **E, `CheckoutView.vue`**. Kept `refusal` as above and took E's `inviteCopy` and `useWorkspaceInvites()`. - **E, `useSubscriptionCheckout.ts`**. Kept 1.55's `useEventListener` import and added E's `watch` and `ToastMessageOptions`. 1.55 does not use `onScopeDispose`, so it is not imported. - **E, `useSubscriptionCheckout.test.ts`**. The toast mock gains E's `remove`. 1.55 has no `removeGroup` usage, so `mockToastRemoveGroup` is not added. One extra commit updates a #19305 test case. For a refused subscribe with `OPERATION_ALREADY_PENDING`, it expected the generic failure copy because 1.55 had no copy for that code. D adds that copy, so the case now expects billing-web's own wording, matching the upstream stack. ## Verification - `pnpm typecheck` (app, account-core, billing-web, account-ui, billing-contract): pass - billing-web unit tests: 277/277 - account-ui unit tests: 224/224 - account-core unit tests: 1227/1227 - `src/platform/workspace` + `src/platform/cloud/subscription`: 2320 passed, 1 expected fail - oxfmt, oxlint and eslint on the changed files: clean ## AS IS / TO BE Same UI as the original PRs; see the AS IS / TO BE media in #19101 and #19104. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Backport of #19099 to
core/1.55Automatically created by backport workflow.