Repository navigation
[backport core/1.55] FE-3046 billing-web shared embedded checkout (#19099, #19100, #19101, #19104) - #19442
Conversation
…rom account-ui (#19100) - Linear: FE-3046 the app renders those components, the package holds a second copy that nothing keeps in step. This PR makes the app render them, so the app and (in D) billing-web share one implementation. No visual change in the app. - `SubscriptionAddPaymentPreviewWorkspace.vue`, `SubscriptionTransitionPreviewWorkspace.vue` and `SubscriptionSuccessWorkspace.vue` keep their props and events, so their parents are untouched. Each now renders `CheckoutSubscribeConfirm`, `CheckoutTransitionConfirm` or `CheckoutSuccess` and binds what only the app knows: - copy from vue-i18n (`useCheckoutCopy`), including the `CheckoutPlan` built from the tier catalog or the team credit stop, - the Stripe publishable key, the colour-palette theme key and checkout-journey telemetry (previously in `UnifiedStripePaymentSelector.vue`), - subscription status from `useBillingContext` (loaded, cancelled, end date) for the reactivation banner, - the team invite block and Send invites action through `CheckoutSuccess`'s slots. - Deleted, now in the package: `UnifiedStripePaymentSelector.vue`, `SubscriptionTermsNote.vue`, `subscriptionQuoteFormatting.ts` and `planDuration.ts` (plus their tests, which the package's `checkoutQuote.test.ts` and component tests cover). `useSubscriptionCheckout` imports `amountDueTodayChanged` from the package. - `TIER_PRICING` spreads the shared `TIER_CATALOG` (same numbers) and keeps its app-only `videoEstimate`. - `UnifiedStripePaymentSelector.test.ts` becomes `SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`: the same key, copy, theme and telemetry assertions against the binding. Parity evidence: the existing component tests for the three steps (`SubscriptionAddPaymentPreviewWorkspace.test.ts`, `SubscriptionTransitionPreviewWorkspace*.test.ts`, `SubscriptionSuccessWorkspace.test.ts`) pass unchanged, apart from renaming the stubbed children (`UnifiedStripePaymentSelector` → `CheckoutPaymentForm`, `SingleSelect` → `CheckoutSavedMethodSelect`, `SubscriptionTermsNote` → `CheckoutTermsNote`). | PR | branch | base | title | |---|---|---|---| | #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection` | | A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system` | | B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success` | | **C (this PR)** | **`jaewon/workspace-adopt-account-ui-checkout`** | **B** | **`FE-3046 refactor(workspace): render the subscription checkout steps from account-ui`** | | D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046 feat(billing-web): render the shared embedded checkout` | | E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046 feat(billing-web): invite your team from the checkout success step` | | F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047 fix(account-ui): clear decline toasts once a retry succeeds` | | G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048 fix(billing-web): return to the host by closing the checkout tab` | | H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step` | ```mermaid graph LR P0[#19097: remove plan grid] --> A[A: design-system buttonVariants] A --> B[B: account-ui checkout surfaces] B --> C[C: workspace adopts account-ui] C --> D[D: billing-web shared checkout] D --> E[E: billing-web success invite] E --> F[F: stale decline toasts] F --> G[G: close the billing tab] G --> H[H: reachable checkout CTA] style C fill:#f9d71c,stroke:#333,color:#000 ``` Each image: **left = AS IS** (app on #19099, old components), **right = TO BE** (this PR). Rendered in Storybook (a temporary story, not committed) with the app components' real props, the checkout dialog's frame classes, dark theme, 1440x900, and a fake `js.stripe.com` (the same fake billing-web's e2e uses), so the card element area is blank in both. Not against a live backend. AS IS and TO BE are pixel-identical for all four steps (PIL diff: no differing pixels). **Confirm + card entry (new subscription, no saved method)** <img width="1448" alt="card" src="https://github.com/user-attachments/assets/c00c89fb-1eaa-46bd-b335-9bf51e09fff1" /> **Confirm + saved-card selector (two saved cards)** <img width="1448" alt="saved" src="https://github.com/user-attachments/assets/d2db71b9-2e7f-4e99-bd89-45624e771ce5" /> **Plan change (upgrade, no card form)** <img width="1448" alt="change" src="https://github.com/user-attachments/assets/740beba9-fbb0-41ac-a2a6-9bb3815665da" /> **Success** <img width="1448" alt="success" src="https://github.com/user-attachments/assets/42a18550-21fa-41b7-8e7d-c2ebc7349520" /> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 4bfdc8a)
- Linear: FE-3046 billing-web is the cloud app's embedded checkout moved to a new tab, with no UX change (ADR BILLING-WEB-0038, #19096). Its checkout was a separate implementation (`EmbeddedCheckout`, `CheckoutPayment`, `CheckoutSubmit`) with its own layout and copy, no saved-card selection and no promo code. With the app now rendering `@comfyorg/account-ui/billing/checkout` (#19100), billing-web can render the same steps. - `CheckoutView.vue` renders the shared steps inside `CheckoutFrame.vue`, which reproduces the app's checkout dialog box (the dialog content class from `useSubscriptionDialog` and the embedded-step classes from `SubscriptionRequiredDialogContentUnified`): - `new_subscription` quote → `CheckoutSubscribeConfirm` with the card form, the saved methods from `usePaymentMethods` (default preselected; Change / Add new payment method swap in the card form) and the promo code. - any other transition → `CheckoutTransitionConfirm`, single column, no card form: the server charges the method on file (the #18684 rule, now through the same component as the app). A reactivation the quote or the server demands shows the app's banner and threshold checkbox. - success → `CheckoutSuccess` (plan card, credits per month); Close returns to the product with the outcome. - Through the payment it behaves like the app: the confirm stays with the pay button busy and a processing (or "verify your payment") toast; a verification that fails in the tab shows the confirm's inline notice; a decline, timeout or refused subscribe shows the app's error toast with its detail copy and leaves the confirm, and a card already typed, in place. `CheckoutToast.vue` is that toast. - Subscribe carries `saved_payment_method_id` for a saved method and `promotion_code` for an applied promo, next to the existing token, quote identity, proration and return URL. - Plan: tier name and monthly credits from `@comfyorg/account-ui/billing/catalog` (#19099). A team stop's price and credits come from the `/billing/plans` stop the link names, through the same catalog functions as the app's slider and confirm. - Copy: billing-web's `checkout.*` keys are replaced with the app's English strings, key for key. - Page environment: the frame applies what the app's page applies around the dialog — its dark palette's `--interface-stroke`, `color-scheme: dark`, and browser defaults for inputs, the select trigger and links (the app has no Tailwind preflight). `styles.css` sources all of account-ui's billing components (the Stripe form's layout classes were missing); `primeicons` and `reka-ui` are added. - Tests: `CheckoutView.test.ts` rewritten against the shared components (saved method, Change, promo, reactivation, decline/3DS outcomes, #18684 cases kept); `e2e/checkout.spec.ts` updated plus a saved-method e2e. billing-web e2e 29/29 locally. - `EmbeddedCheckout`'s split card layout (5/12 summary sidebar, its own card, muted `h1`, lucide back arrow and close X). - Plan title `{tier} · {duration}` ("Pro · Monthly"), hero `$28.00` with "USD per month"/"USD per year", "{amount} billed yearly", "Starting today". - "Credits refill every month" showing `credits_cents` as dollars ("$211.00" for 21,100 credits). - The terms line "By subscribing, you agree to recurring charges until cancellation." (no links). - `CheckoutSubmit`'s pay button and its reactivation checkbox on the card form ("Your subscription was cancelled. I confirm the {amount} charge to reactivate it."); reactivation now uses the app's banner on the plan-change confirm. - Its own Stripe copy ("Choose how you would like to pay.", "The payment form isn't available right now…", its Alipay note, "Something went wrong. Please try again."). - The inline failure paragraph above the pay button. - The `CheckoutSteps` panel that replaced the checkout while paying and after a failure ("Review payment", "Payment declined", "Payment could not be processed", Try again / Use a different payment method / Contact support). - The success panel (tinted check circle, "Your plan was updated. A receipt was sent to your email.", plan line, "Return to {product}" link button). - The way back to the host: Close (the dialog's X and the success step's Close) leaves for the product's return URL instead of closing a dialog. - "Loading…" while the quote loads, and the quote-refused panel with Back (the app never opens the confirm without a quote). - `CheckoutToast`, standing in for the app's toast host (outside the checkout panel). - Team plan success: the app's "Invite your team" step lands in E (#19104). - Stripe Payment/Address Element options differ in the live recording (Google Pay and a full address on billing-web vs card/Alipay/US bank and name-only in the app). Both hosts now render the same `StripePaymentForm` with the same options; what remains comes from the server's `payment_method_configuration_id` and Stripe's per-domain wallet registration, which need a live backend check. - **Decline copy:** `declineDetailKey(reason)` in account-core is one exhaustive switch over the contract's `BillingDeclineReason`. The app's SDK rail (`topupOperationView.declineDetail`) and billing-web both call it. Before this, billing-web had its own list that omitted `generic`. A reason-less decline (account-core defaults it to `generic`) therefore read "We couldn't update your subscription." on billing-web and "Your bank declined this payment." in the app. The list also carried 15 strings outside the enum. - **Processing vs verify toast:** superseded below. The app's rule is `awaitsHostedAction`, now shared, not `awaitsVerification`. - **Team hero price:** `mapApiTeamCreditStops` and `getStopDiscountedMonthlyUsd` move from the app into `@comfyorg/account-ui/billing/catalog`. The app's pricing table, credit slider and subscription dialog import them from there, and billing-web's `teamCheckoutPlan` prices the stop with them instead of `price_cents / months`. - Tests: table tests for `declineDetailKey` (all 8 reasons) and `awaitsVerification`, the moved stop tests, billing-web decline rows for `generic` / `incorrect_cvc` / `processing_error`, and team monthly/annual stop prices. The e2e that pinned the old reason-less copy now expects the app's decline copy. - Harness: new step P6a2, the server declines with no `decline_reason`. Rerun on D: 0% copy/element difference on every step except P7T, whose team invite is E. Rerun on G (top of stack): 0% on all 15 steps. - **Why a replica:** billing-web's toast is a measured replica of the app's PrimeVue Aura toast, because AGENTS.md forbids new PrimeVue usage. The parity harness compares every toast (size, colors, fonts, icon, close button, each part's position) and fails on drift. - **Assistive tech:** every toast is `role="alert"`, `aria-live="assertive"`, `aria-atomic="true"`, as PrimeVue renders the app's. The harness compares these too. - **Anchor:** toasts sit top-right. The app anchors its message toasts to the graph canvas panel, which billing-web does not have. - **End date:** the reactivation notice's "set to end on" date now comes from the billing status's `cancel_at`, the field the app reads, instead of the quote's `current_plan.period_end`. Harness step P2e gives the two server values different dates; both hosts show `cancel_at` (Oct 25 vs the quote's Oct 27). - **Toast:** `CheckoutToast` was a look-alike: neutral, no close button, one at a time. It now renders the app's dark Aura PrimeVue toast. - Styling: the severity tint, 36% border and shadow, `blur(10px)`, and a 28px close button. - Layout: the two hosts the app uses. The operation toast is a spinner or prompt beside one line; the message toast is a severity icon, summary and detail. - The numbers come from the app's computed styles, captured by the harness. It is not PrimeVue itself, because AGENTS.md rules out new PrimeVue use in billing-web. - **Lifetimes match the app:** - The progress toast stays while the payment is pending. A closed one stays closed until the operation's state changes. - Errors stay until closed. - "Subscription updated successfully" shows for 5 s after a subscribe the server charged for, like the app's SDK rail (`requiredPayment`). A plan the server activated on the spot gets none. - **Prompt vs spinner:** the app shows the "Verify your payment" prompt only when a hosted action page is waiting. An in-page 3DS challenge keeps the spinner. `awaitsVerification` (adopted in review) also counted the challenge, and the harness showed it disagreed with the app. The app's rule is now `awaitsHostedAction` in account-core, used by the app's `billingSdkStore` and by billing-web. - **Success frame:** the app pins the success frame only after a new subscription. After a plan change it uses the dialog's content-sized box. `CheckoutFrame` gets that `fit` step, so the blank band above "Send invites" is gone. - **Harness:** it now captures the toast region and the frame box on both sides, not just the panel. Toasts are paired by text and compared on size, colors, fonts, icon, close button and each part's position. New step P7C covers success after a plan change that took a payment. At the stack top, all 19 steps show no copy or element difference, the same toasts with the same measurements, and equal frame boxes. **Toasts, app (left) vs billing-web (right): progress, decline, success** <img width="824" alt="D-toasts" src="https://github.com/user-attachments/assets/06d04e8e-6aba-46a8-9287-f43d3019844a" /> **billing-web progress toast, AS IS | TO BE** <img width="1092" alt="D-toast-web-asis-tobe" src="https://github.com/user-attachments/assets/d860df11-e1eb-49e2-ba17-e30efec5723c" /> **P7C success after a plan change: billing-web AS IS | TO BE, then app | billing-web** <img width="1448" alt="D-frame-web" src="https://github.com/user-attachments/assets/36c3a98f-591f-48ca-8a58-03a3273ae90f" /> <img width="1448" alt="D-frame-appweb" src="https://github.com/user-attachments/assets/ecd2c4ee-fbbd-48ba-b55c-b0645b0b5662" /> - On mount the view adopts the operation the billing status names (`lifecycle.recover()`), the way the app resumes `pending_billing_op_id`. Before this, opening checkout while an earlier subscription was pending showed a fresh card form or an enabled confirm. Pressing it sent nothing and showed "Something went wrong." - The confirm now gets the app's `action-url`, `authentication-error` and `parked-checkout-recovery`, and `paying` follows the app's `isPolling` rule. An operation parked on `awaiting_payment_method` offers "Complete your payment", and a settling invoice holds the pay action. - A subscribe the core refuses with `OPERATION_ALREADY_PENDING` shows the app's sentence ("A payment you started earlier is still going through…") instead of the generic failure. - Tests: view tests for a parked op and a settling-invoice op, both red without the fix. Harness steps P8a (parked) and P8b (settling invoice) match the app with 0% copy/element difference. - Same on both hosts: the core refuses a second subscribe while the status names a pending one, so on the SDK rail "Complete your payment" answers with that sentence in the app and in billing-web alike. **P8a: parked checkout, Cloud app (left) | billing-web (right)** <img width="1448" alt="D-parked" src="https://github.com/user-attachments/assets/7316e0da-e4df-4fe9-bf7b-5e8d34754efc" /> **P8b: settling invoice, Cloud app (left) | billing-web (right)** <img width="1448" alt="D-held" src="https://github.com/user-attachments/assets/1940763e-3f0a-4b91-9c71-c0d175b0c69a" /> **P6a2: reason-less decline, Cloud app (left) | billing-web (right)** <img width="1448" alt="D-no-reason" src="https://github.com/user-attachments/assets/75d0ed13-bb14-453d-8b73-eda7b23ff754" /> - The two gaps above. | PR | branch | base | title | |---|---|---|---| | #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection` | | A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system` | | B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success` | | C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046 refactor(workspace): render the subscription checkout steps from account-ui` | | **D (this PR)** | **`jaewon/billing-web-shared-checkout`** | **C** | **`FE-3046 feat(billing-web): render the shared embedded checkout`** | | E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046 feat(billing-web): invite your team from the checkout success step` | | F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047 fix(account-ui): clear decline toasts once a retry succeeds` | | G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048 fix(billing-web): return to the host by closing the checkout tab` | | H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step` | ```mermaid graph LR P0[#19097: remove plan grid] --> A[A: design-system buttonVariants] A --> B[B: account-ui checkout surfaces] B --> C[C: workspace adopts account-ui] C --> D[D: billing-web shared checkout] D --> E[E: billing-web success invite] E --> F[F: stale decline toasts] F --> G[G: close the billing tab] G --> H[H: reachable checkout CTA] style D fill:#f9d71c,stroke:#333,color:#000 ``` Real app and real billing-web against testcloud, not the harness. Same account and plan change on both sides: Team Monthly team_700 → team_1400 ($1,295/mo) on a cancelled team workspace, which reactivates it (the "Confirm your upgrade" path). Both subscriptions were cancelled again afterwards. - **AS IS:** `main` ec7764f. Embedded = local app on testcloud with `ff:hosted_billing_destination="stripe"`. billing-web = testcloud (`billing_web`) → testbilling. Team Monthly team_700, new subscription. - **TO BE:** stack top f02bdd6 (H #19115, includes this PR) for both surfaces. Local app (`DEV_SERVER_COMFYUI_URL=https://testcloud.comfy.org/`, testcloud `pk_test`) and local billing-web on :5174 (`VITE_BILLING_ENV=test`). Embedded = `ff:hosted_billing_destination="stripe"` on `m2-qa-0925-3ds` (saved card needs 3DS). billing-web = `"billing_web"` on `m2-qa-0927-full`, handed off from the app's Change plan; the server's `billing_web_url` was cleared in the page so the app opens the local billing-web. **TO BE video, embedded (left) | billing-web (right).** Plan picked in the app → confirm → pay → (3DS on the embedded side's saved card) → "You're all set" with Invite your team → Close. On billing-web, Close closes the tab and the app shows the new credit balance. https://github.com/user-attachments/assets/a4a527e4-9a89-4808-8e27-90b143cc9bce Full-size recordings: embedded https://github.com/user-attachments/assets/fd8f0ea7-6480-4b54-bb28-afc7fffbfdd6 · billing-web https://github.com/user-attachments/assets/1da3540f-fcf6-4691-a075-997b07c364f1 **AS IS video, embedded (left) | billing-web (right)** (new subscription, recorded separately so the timelines do not line up). https://github.com/user-attachments/assets/b653c5ba-2e82-4bfa-bed5-f151109e580e **TO BE per step, embedded (left) | billing-web (right)** 1. Plan chosen in the host app (same dialog; billing-web has no plan picker) <img width="1400" alt="1-plan-picker-in-host" src="https://github.com/user-attachments/assets/2b59d096-c13f-4e8f-a96b-9e86ebee4f58" /> 2. Confirm your upgrade: same notice, summary, discount, total, promo and CTA <img width="1400" alt="2-confirm-top" src="https://github.com/user-attachments/assets/20bbd27d-361c-48d4-8857-ddd6bc71ced3" /> 3. Confirm scrolled inside its frame: terms line reachable on both <img width="1400" alt="3-confirm-scrolled-terms" src="https://github.com/user-attachments/assets/2f3d6e40-6819-4f52-b2f8-b76d829fca1c" /> 4. Paying: busy CTA and "Processing payment — setting up your workspace…" toast <img width="1400" alt="4-processing" src="https://github.com/user-attachments/assets/f5372838-c85d-4113-aece-019ce940cf40" /> 5. Embedded only: Stripe 3DS2 test page for the saved card (billing-web's workspace card did not ask for 3DS) <img width="700" alt="5-embedded-3ds-challenge" src="https://github.com/user-attachments/assets/dbd3abe9-3d90-4da5-b398-945e6f9cefb2" /> 6. You're all set: plan card, 295,400 / month, Invite your team, Send invites, Close <img width="1400" alt="6-success" src="https://github.com/user-attachments/assets/42b820df-b6b8-4748-a768-5969d7474fb4" /> 7. After Close: embedded dialog closes; billing-web tab closes and the app shows 294,054 credits with no Resubscribe <img width="1400" alt="7-after-close" src="https://github.com/user-attachments/assets/4989f353-1d96-4255-b7a4-cd78a092f86e" /> **AS IS per step, embedded (left) | billing-web (right)** <img width="1400" alt="AS IS P1 confirm" src="https://github.com/user-attachments/assets/a027af94-3f09-4ed1-8d13-5a561cb7a788" /> <img width="1400" alt="AS IS P6 decline 0002" src="https://github.com/user-attachments/assets/ec0e267a-8255-4460-98a7-5ef466dcbe8b" /> <img width="1400" alt="AS IS P7 success" src="https://github.com/user-attachments/assets/381b0a9b-93fd-42ef-9200-adc39d42b179" /> <img width="1400" alt="AS IS P7 return to app" src="https://github.com/user-attachments/assets/2754cf9e-e300-4a73-8889-76ed5dbab082" /> **Differences still visible live (TO BE)** - Processing toast: the app's is the blue info toast with a close button; billing-web's `CheckoutToast` is a neutral dark toast without one. - Success: the app's dialog fits its content; billing-web's frame keeps the confirm step's fixed height, so a blank band sits between the email field and Send invites. The app also shows a "Subscription updated successfully" toast; billing-web does not. - Embedded only (pre-existing, N4): a "Couldn't open the payment page — please allow popups" warning appears during the in-page 3DS challenge. - Embedded confirm on `m2-qa-0925-3ds`: the notice says it renews on Oct 27, 2026 while the summary says "Renews at $1,295.00 on Oct 25, 2026". Not compared on billing-web, whose workspace has both dates on Oct 27. **Not recorded live yet** - ~~New subscription (card entry, decline 0002, 3DS 3184 complete and fail).~~ Recorded on billing-web in the live rerun below (workspace `m2-qa-0927-new`). An embedded new-subscription run on the same build was not possible: the account has one free workspace, so the embedded side is covered by the AS IS recording above and the upgrade side-by-side below. - Failed 3DS on the upgrade path: not run, because a failed reactivating upgrade leaves the operation pending and the workspace cannot be cancelled (N6). **Upgrade, AS IS embedded (left) | TO BE billing-web (right):** Team 147.7K → 295.4K in the app dialog and Team 295.4K → 527.5K on billing-web, both with 3DS complete; same confirm, 3DS and success screens. https://github.com/user-attachments/assets/d4d49d40-27bc-4bbe-8886-99f2df7acd8f **TO BE billing-web, new Team Monthly subscription:** decline (0002) → 3DS fail (3184) → 3DS complete → "You're all set" with Invite your team → Close closes the tab and the app shows the plan. https://github.com/user-attachments/assets/a4c58e5d-429a-4332-bfa4-e10d8621f082 Checkout parity harness (`temp/scripts/checkout-parity`, same fixtures on both surfaces, fake `js.stripe.com` masking the Stripe elements; mocked Cloud, not a live backend). Each image: **billing-web AS IS** (`main` ec7764f) | **billing-web TO BE** (this PR, d24d242) | **cloud app** (same build). Copy/element diff app vs billing-web TO BE: none on all 11 steps. Panel pixel diff (app vs TO BE) below; the non-zero ones are the busy button's spinner frame. The harness's style notes that remain pair two same-named elements (the two Stripe masks, the two Close buttons) and are identical in the structure dumps. **P1-confirm-new-personal** — pixel diff 0% <img width="1400" alt="P1-confirm-new-personal" src="https://github.com/user-attachments/assets/062a2b68-9299-4920-b321-0a72b3102918" /> **P1T-confirm-new-team** — pixel diff 0% <img width="1400" alt="P1T-confirm-new-team" src="https://github.com/user-attachments/assets/786f38b6-5f02-4a43-ad63-6a44cb7465a8" /> **P2a-confirm-upgrade-immediate** — pixel diff 0% <img width="1400" alt="P2a-confirm-upgrade-immediate" src="https://github.com/user-attachments/assets/f4fc2395-9cc2-4668-b338-52051f84189f" /> **P2b-confirm-downgrade-zero-due** — pixel diff 0% <img width="1400" alt="P2b-confirm-downgrade-zero-due" src="https://github.com/user-attachments/assets/a4cef7bc-4f04-48e2-b740-85a50ad2b1de" /> **P3-saved-card-selector** — pixel diff 0% <img width="1400" alt="P3-saved-card-selector" src="https://github.com/user-attachments/assets/f4ef89a3-d681-4db3-9209-2f9e7350dae0" /> **P3b-no-saved-cards** — pixel diff 0.000% <img width="1400" alt="P3b-no-saved-cards" src="https://github.com/user-attachments/assets/ac51ce04-ea6b-4a06-a706-5092bbd77b5d" /> **P4-card-entry** — pixel diff 0.000% <img width="1400" alt="P4-card-entry" src="https://github.com/user-attachments/assets/705d93bf-e33c-4376-b357-d4be86f332d3" /> **P5-3ds-in-progress** — pixel diff 0.003% <img width="1400" alt="P5-3ds-in-progress" src="https://github.com/user-attachments/assets/39f72aaa-28b1-4266-bdd5-b14fe4b6a99b" /> **P6a-declined** — pixel diff 0% <img width="1400" alt="P6a-declined" src="https://github.com/user-attachments/assets/66ef6af7-c82b-4f76-b5ca-37896d734420" /> **P6b-3ds-failed** — pixel diff 0.003% <img width="1400" alt="P6b-3ds-failed" src="https://github.com/user-attachments/assets/e18807f0-b0d8-4584-a9fc-86ae86ec26f9" /> **P7-success** — pixel diff 0% <img width="1400" alt="P7-success" src="https://github.com/user-attachments/assets/ecd05652-cee7-4464-bae9-61da565904c8" /> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit d5cf71c)
… step (#19104) - Linear: FE-3046 After a multi-seat (team) subscribe, the cloud app's success step invites the team (`SubscriptionSuccessWorkspace` + `InviteMembersForm`). billing-web's success step (#19101) showed the plan card and Close only. billing-web is the embedded checkout in a new tab (ADR BILLING-WEB-0038), so it gets the same step. - `@comfyorg/account-core/billing`: `createWorkspaceInviteCommands({ transport })` with `listPendingInvites` and `createInvite` (`GET`/`POST /workspace/invites`, parsed against the generated contract). It runs over the billing session transport, so invites go to the workspace the entry link bound — no second client, no hand-rolled fetch. - `@comfyorg/account-ui/billing/checkout`: `CheckoutTeamSuccess` wraps `CheckoutSuccess` with the app's invite block: same heading, subtext, email tags, invalid / already-invited / seat-cap hints, one invite per address, confirmation message, "Send invites" leading and Close demoted. The invite rules (`inviteEmails.ts`) move from the app into the package and the app imports them from there. - `@comfyorg/design-system/tag.variants`: the tag recipe moves out of the app, as `buttonVariants`/`selectVariants` did, so the package's email tags use the app's classes. - billing-web: the client carries the invite commands; `CheckoutView` reads seats from billing status on success (and again after invites, as the app refreshes status) and renders `CheckoutTeamSuccess`. A failed invite shows the app's "Couldn't send N invites" toast. - `CheckoutFrame`: the app's browser defaults for inputs and links move to a base-layer rule, so a utility (the tags input's `text-sm`) still wins, as it does in the app. - The app still renders its own `InviteMembersForm` (also used by the invite dialog, with telemetry and the app toast). Switching the app to `CheckoutTeamSuccess` is a follow-up; this PR moves the shared rules, recipe and client so that step is small. - CORS for `/api/workspace/invites` from the billing-web origin is not verified against a live backend (mocked here). The app has no Tailwind preflight, so its reactivation checkbox keeps the browser's margin. `[data-app-defaults]` now reverts that margin too, which removes a 2px shift in the reactivation notice (harness P2e: 3.4% to 0.01%). | PR | branch | base | title | |---|---|---|---| | #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection` | | A #19098 | `jaewon/design-system-button-variants` | #19097 | `FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system` | | B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success` | | C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046 refactor(workspace): render the subscription checkout steps from account-ui` | | D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046 feat(billing-web): render the shared embedded checkout` | | **E (this PR)** | **`jaewon/billing-web-success-invite`** | **D** | **`FE-3046 feat(billing-web): invite your team from the checkout success step`** | | F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047 fix(account-ui): clear decline toasts once a retry succeeds` | | G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048 fix(billing-web): return to the host by closing the checkout tab` | | H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step` | ```mermaid graph LR P0[#19097: remove plan grid] --> A[A: design-system buttonVariants] A --> B[B: account-ui checkout surfaces] B --> C[C: workspace adopts account-ui] C --> D[D: billing-web shared checkout] D --> E[E: billing-web success invite] E --> F[F: stale decline toasts] F --> G[G: close the billing tab] G --> H[H: reachable checkout CTA] style E fill:#f9d71c,stroke:#333,color:#000 ``` Live (testcloud) recordings of the whole stack (stack top f02bdd6, embedded vs billing-web, AS IS and TO BE videos and per-step screenshots) are in #19101 under "Live (testcloud) AS IS / TO BE". TO BE live, team reactivating upgrade paid on both hosts: "You're all set" with Invite your team on the embedded checkout (left) and billing-web (right). <img width="1400" alt="live-success-invite" src="https://github.com/user-attachments/assets/42b820df-b6b8-4748-a768-5969d7474fb4" /> Checkout parity harness step P7T (new: team subscribe → success; mocked Cloud, not a live backend). **billing-web AS IS** (#19101) | **billing-web TO BE** (this PR) | **cloud app**. TO BE vs app: 0% panel pixel diff, no copy or element differences. The other 11 steps are unchanged (all 0% except the busy spinner frame on P5/P6b, 0.003%). <img width="1558" alt="P7T" src="https://github.com/user-attachments/assets/2af1e0c9-d5f3-4270-8621-b2fb71cdeff3" /> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 592588b)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (90 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6635cb05905e0086d88ea7de51f1e61295f6e685
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T18:35:38.520Z",
"gitSha": "92654ce8411b4d65ffa05db0ec1102e1983dc5b3",
"branch": "backport-fe3046-checkout-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.698999999926,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.918999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.86899999999997,
"heapDeltaBytes": 8719304,
"heapUsedBytes": 76256672,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.991999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2012.805999999955,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.115000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.855,
"heapDeltaBytes": -5735116,
"heapUsedBytes": 61914404,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.735,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1772.9739999999765,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 815.836,
"heapDeltaBytes": 10759736,
"heapUsedBytes": 78176356,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 163.478,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.9410000000335,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.299000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.1370000000001,
"heapDeltaBytes": 8230448,
"heapUsedBytes": 75946664,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 163.47899999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.770000000035,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.593,
"layouts": 6,
"layoutDurationMs": 1.295,
"taskDurationMs": 381.517,
"heapDeltaBytes": 3086144,
"heapUsedBytes": 70798848,
"domNodes": 77,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 14.232000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.766000000076,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.189,
"layouts": 6,
"layoutDurationMs": 0.9809999999999999,
"taskDurationMs": 270.21,
"heapDeltaBytes": 3084368,
"heapUsedBytes": 70666428,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.515,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 601.3679999998658,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.473,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.51800000000003,
"heapDeltaBytes": 18584584,
"heapUsedBytes": 86542416,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 167.429,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 631.0829999999896,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.089999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.66700000000003,
"heapDeltaBytes": 18872552,
"heapUsedBytes": 86410800,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 170.393,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.725999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.8969999999999,
"heapDeltaBytes": 38270428,
"heapUsedBytes": 104856828,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 72.25300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 581,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.734000000204,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.3199999999999,
"heapDeltaBytes": 36178140,
"heapUsedBytes": 104693244,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 69.95000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 548,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.4279999999326,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.0800000000007,
"heapDeltaBytes": 15805520,
"heapUsedBytes": 91415604,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 168.86499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.2140000000363,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.19899999999984,
"heapDeltaBytes": 14644068,
"heapUsedBytes": 91004192,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.55600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11883.685000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10904.859999999999,
"heapDeltaBytes": 1698624,
"heapUsedBytes": 84056644,
"domNodes": -16,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 9112.597000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 2031,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10912.041000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10085.395,
"heapDeltaBytes": 10319568,
"heapUsedBytes": 92360284,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8322.665,
"eventListeners": 0,
"totalBlockingTimeMs": 1202,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10321.44100000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9457.199,
"heapDeltaBytes": -12306940,
"heapUsedBytes": 69884848,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7802.4,
"eventListeners": 0,
"totalBlockingTimeMs": 946,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10449.50300000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9485.842,
"heapDeltaBytes": -4590724,
"heapUsedBytes": 72362108,
"domNodes": -12,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8078.960999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1280,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2054.0750000000116,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.2429999999999,
"heapDeltaBytes": -6434528,
"heapUsedBytes": 80799516,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 33.340999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.882000000105,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.522000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.2850000000001,
"heapDeltaBytes": -3458600,
"heapUsedBytes": 83520288,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.429,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2270.344000000023,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.496000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1629.6209999999999,
"heapDeltaBytes": 19405524,
"heapUsedBytes": 84129664,
"domNodes": 10,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 857.8399999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2216.9000000001233,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.48,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1452.68,
"heapDeltaBytes": 14999080,
"heapUsedBytes": 79729036,
"domNodes": -245,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 862.007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3679.049999999961,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.083999999999998,
"layouts": 60,
"layoutDurationMs": 14.190999999999999,
"taskDurationMs": 1773.2109999999998,
"heapDeltaBytes": 9400936,
"heapUsedBytes": 74669004,
"domNodes": -7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.029,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3684.9919999999656,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.93,
"layouts": 60,
"layoutDurationMs": 13.874999999999998,
"taskDurationMs": 1763.41,
"heapDeltaBytes": 7994740,
"heapUsedBytes": 74172116,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 819.6999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3212.10700000006,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.861,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2065.34,
"heapDeltaBytes": -6786476,
"heapUsedBytes": 83393232,
"domNodes": -226,
"jsHeapTotalBytes": 1495040,
"scriptDurationMs": 1048.473,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3121.1430000000746,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1936.9779999999998,
"heapDeltaBytes": 1419432,
"heapUsedBytes": 67177496,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1002.823,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2015.2749999999742,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.275,
"heapDeltaBytes": 20182588,
"heapUsedBytes": 84717796,
"domNodes": -251,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.21099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.7529999998806,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.481999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.11099999999993,
"heapDeltaBytes": -4693872,
"heapUsedBytes": 83835496,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 35.013000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.0569999999971,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.522,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.216,
"heapDeltaBytes": 13756360,
"heapUsedBytes": 83541920,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.905,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.9880000000048,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.843000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.30600000000004,
"heapDeltaBytes": 13774704,
"heapUsedBytes": 83543792,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.487,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.577000000083,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.564,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.757,
"heapDeltaBytes": -5574200,
"heapUsedBytes": 64702624,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.355999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.3679999999658,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.814999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.697,
"heapDeltaBytes": 10345132,
"heapUsedBytes": 80276936,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.474999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.6640000000461,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.426999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.4570000000001,
"heapDeltaBytes": 2572932,
"heapUsedBytes": 71804208,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.19299999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.3959999999606,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.216,
"heapDeltaBytes": 9405200,
"heapUsedBytes": 79250644,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.19000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.001999999935,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.747000000000003,
"layouts": 5,
"layoutDurationMs": 13.437000000000001,
"taskDurationMs": 918.4539999999998,
"heapDeltaBytes": 20274848,
"heapUsedBytes": 103781876,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.498000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8618.650000000116,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.382,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6059.685,
"heapDeltaBytes": -10048244,
"heapUsedBytes": 76504764,
"domNodes": -243,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2892.479,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8745.811000000003,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.20700000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6058.24,
"heapDeltaBytes": -2095360,
"heapUsedBytes": 84900180,
"domNodes": -241,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2884.14,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17381.745000000137,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16980.354,
"heapDeltaBytes": -36393144,
"heapUsedBytes": 178163644,
"domNodes": -8065,
"jsHeapTotalBytes": -8896512,
"scriptDurationMs": 274.49,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17388.332999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16995.769000000004,
"heapDeltaBytes": -50661328,
"heapUsedBytes": 190421852,
"domNodes": -8092,
"jsHeapTotalBytes": -18550784,
"scriptDurationMs": 267.71700000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22038.98800000002,
"styleRecalcs": 159,
"styleRecalcDurationMs": 23.390999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21873.734000000004,
"heapDeltaBytes": -49224272,
"heapUsedBytes": 192237888,
"domNodes": -8090,
"jsHeapTotalBytes": -19668992,
"scriptDurationMs": 970.4209999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 74,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20798.395999999913,
"styleRecalcs": 150,
"styleRecalcDurationMs": 16.57800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20561.126,
"heapDeltaBytes": -71518884,
"heapUsedBytes": 170134696,
"domNodes": -8061,
"jsHeapTotalBytes": -17698816,
"scriptDurationMs": 875.7,
"eventListeners": -14928,
"totalBlockingTimeMs": 70,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6521.985000000086,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.639,
"layouts": 20,
"layoutDurationMs": 31.96700000000001,
"taskDurationMs": 6472.643999999999,
"heapDeltaBytes": -26198712,
"heapUsedBytes": 188606660,
"domNodes": -8061,
"jsHeapTotalBytes": 3469312,
"scriptDurationMs": 144.85500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 553,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6230.203000000074,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.43400000000003,
"layouts": 20,
"layoutDurationMs": 24.171,
"taskDurationMs": 6173.285999999999,
"heapDeltaBytes": -44794420,
"heapUsedBytes": 169381916,
"domNodes": -8061,
"jsHeapTotalBytes": 11472896,
"scriptDurationMs": 131.134,
"eventListeners": -14928,
"totalBlockingTimeMs": 472,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6780.694999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6442.209000000002,
"heapDeltaBytes": 19062196,
"heapUsedBytes": 196973368,
"domNodes": -1519,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 109.31299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8704.071999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8539.805999999999,
"heapDeltaBytes": 15719684,
"heapUsedBytes": 171471080,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 132.529,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 130.63099999999395,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.56,
"layouts": 3,
"layoutDurationMs": 1.8930000000000002,
"taskDurationMs": 97.67499999999998,
"heapDeltaBytes": 3214160,
"heapUsedBytes": 68941508,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.868000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 104.92200000021512,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.27,
"layouts": 3,
"layoutDurationMs": 1.7989999999999997,
"taskDurationMs": 72.008,
"heapDeltaBytes": 3041028,
"heapUsedBytes": 65258948,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.548,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved. The core/1.55 backport remains faithful to the merged checkout changes; its older-base adaptations are required, and the package manifests and exports remain intact.
Why
Backport of the FE-3046 billing-web shared-checkout stack to
core/1.55. The auto-backport bot hit cherry-pick conflicts on each of these. The 1.55 release needs billing-web to render the same checkout as the app, including the team invite on success.How
Cherry-picked (in order,
-x)core/1.55via #19231core/1.55via #193084bfdc8a68cd5cf71ce27592588bdd6No other prerequisite was cherry-picked.
Conflicts and resolutions
SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts(renamed fromUnifiedStripePaymentSelector.test.ts). 1.55 mocks telemetry with an explicit factory because it lacks test: migrate workspace tests to shared mocks #18497; main automocks it. Took C's file as is.src/platform/telemetry/__mocks__/index.tsexists on 1.55, so the automock resolves and the test passes.apps/billing-web/src/views/CheckoutView.vue. 1.55 has [backport core/1.55] FE-2642 show server refusal reason (#19185) #19305 (backport of FE-2642 fix(billing-web): show the reason the server gave for a refused quote or subscribe #19185, show the server's refusal reason), which main does not have yet. Kept D's checkout and kept 1.55'srefusal()on the subscribe failure and the quote-failure panel. Also usedrefusal()for D's new promotion-code re-quote failure, as the upstreamjaewon/checkout-quote-stale-recoverystack does. Dropped the now-unusedcoded.apps/billing-web/src/session/billingWebAuth.ts(modify/delete). The file does not exist on 1.55 because the unified web session work (FE-2898 feat(billing-web): recognise the shared web session behind unified_web_session (1/2) #18880, FE-2898 feat(billing-web): workspace scope and cookie transport on the shared web session (2/2) #18881) is not backported. Deleted it and applied E's change to what 1.55 has:billingWebClient.tsgains theBillingWebClienttype (BillingClient & { invites }) andinvites: createWorkspaceInviteCommands({ transport })on its singlecreateBillingWebClient.BillingShell.vue. Kept 1.55'screateBillingWebClient(billingWebSessionClient())and added E'sprovideWorkspaceInvites(client.invites).HostedSurface.vue. Kept 1.55'suseBillingWebSessionand added E'sreturnToHostimport (the return link now closes the tab, from FE-3048 fix(billing-web): return to the host by closing the checkout tab #19106).CheckoutView.vue. Keptrefusalas above and took E'sinviteCopyanduseWorkspaceInvites().useSubscriptionCheckout.ts. Kept 1.55'suseEventListenerimport and added E'swatchandToastMessageOptions. 1.55 does not useonScopeDispose, so it is not imported.useSubscriptionCheckout.test.ts. The toast mock gains E'sremove. 1.55 has noremoveGroupusage, somockToastRemoveGroupis not added.One extra commit updates a #19305 test case. For a refused subscribe with
OPERATION_ALREADY_PENDING, it expected the generic failure copy because 1.55 had no copy for that code. D adds that copy, so the case now expects billing-web's own wording, matching the upstream stack.Verification
pnpm typecheck(app, account-core, billing-web, account-ui, billing-contract): passsrc/platform/workspace+src/platform/cloud/subscription: 2320 passed, 1 expected failAS IS / TO BE
Same UI as the original PRs; see the AS IS / TO BE media in #19101 and #19104.