Repository navigation
[backport cloud/1.54] fix(telemetry): close the E1 and E3 agent paywall attribution gaps (#18974) - #19238
Conversation
…ll attribution gaps (#18974) Manual backport of 787ed0b. comfy-pr-bot's cherry-pick failed on four files and left no branch behind. Resolved per file against the cloud/1.54 baseline rather than by taking main's side, because main carries work this branch does not: - useTopupOperation.ts does not exist on cloud/1.54. The composable is a main-only refactor, so its paymentIntentSource parameter has no home here; the equivalent change is applied directly at the component's own billingOperationStore.startOperation call. - The dialog has five top-up emit sites here, not six. The sixth is the `intent` stage from #17300, which is not on this branch — taking main's side would have imported an unbackported event. - AgentPanelRoot.test.ts and the store test use a module-level `telemetry` and `mockTrackBillingEvent` here rather than reading through useTelemetry(), so the assertions are written to those. The store test's hunks merged cleanly and still failed to compile, which is the reason to typecheck a backport rather than trust a clean apply. - SubscribeButton's test builds the billing context explicitly: the __mocks__/useBillingContext manual mock does not exist on this branch. Verification on this branch: vue-tsc clean, lint 0 errors, 512 tests passing across the five affected suites.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T13:17:29.058Z",
"gitSha": "565d746e51b872dc79301768619e4ef3ac38ec87",
"branch": "backport-18974-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2104.1119999999864,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.732999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.044,
"heapDeltaBytes": 837292,
"heapUsedBytes": 71813860,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 12.844000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2032.447999999988,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.9780000000001,
"heapDeltaBytes": -5799476,
"heapUsedBytes": 63504192,
"domNodes": -282,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 10.265000000000004,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2022.2830000000158,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.44,
"layouts": 14,
"layoutDurationMs": 4.136000000000001,
"taskDurationMs": 1029.0549999999998,
"heapDeltaBytes": 3359216,
"heapUsedBytes": 74688368,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 182.584,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1802.2020000000225,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.825999999999997,
"layouts": 14,
"layoutDurationMs": 3.5580000000000003,
"taskDurationMs": 780.9150000000001,
"heapDeltaBytes": -4122928,
"heapUsedBytes": 66904580,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 159.17800000000003,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.903000000024,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.795,
"layouts": 6,
"layoutDurationMs": 0.9700000000000002,
"taskDurationMs": 364.471,
"heapDeltaBytes": 4612476,
"heapUsedBytes": 75866908,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.382,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.2120000000632,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.413,
"layouts": 6,
"layoutDurationMs": 1.001,
"taskDurationMs": 362.37699999999995,
"heapDeltaBytes": 4602892,
"heapUsedBytes": 75946112,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.597999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 707.5480000000312,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.854000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.384,
"heapDeltaBytes": -7297104,
"heapUsedBytes": 62911672,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.882,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 680.7029999999941,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.507,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.12600000000003,
"heapDeltaBytes": 18575808,
"heapUsedBytes": 89224600,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.12400000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2060.653000000002,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.7940000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.3199999999999,
"heapDeltaBytes": 10710104,
"heapUsedBytes": 87029052,
"domNodes": -269,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.679,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2066.8479999999363,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.111999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.488,
"heapDeltaBytes": 5579880,
"heapUsedBytes": 82158556,
"domNodes": -285,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 41.215,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2373.0350000000158,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.417000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1682.114,
"heapDeltaBytes": 12982108,
"heapUsedBytes": 90207332,
"domNodes": -274,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 813.231,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2378.5609999999906,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.776000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1701.832,
"heapDeltaBytes": 8941364,
"heapUsedBytes": 86453684,
"domNodes": -273,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 828.106,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3716.3869999999974,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.902999999999999,
"layouts": 60,
"layoutDurationMs": 11.976,
"taskDurationMs": 1775.5020000000004,
"heapDeltaBytes": 8783880,
"heapUsedBytes": 76538792,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 814.2349999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3651.37900000002,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.459,
"layouts": 60,
"layoutDurationMs": 11.992999999999999,
"taskDurationMs": 1773.393,
"heapDeltaBytes": -6433192,
"heapUsedBytes": 71838488,
"domNodes": -287,
"jsHeapTotalBytes": 4354048,
"scriptDurationMs": 793.396,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3112.2119999999995,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.151,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2033.4079999999997,
"heapDeltaBytes": 690964,
"heapUsedBytes": 68848200,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 978.3919999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.660000000048,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1923.644,
"heapDeltaBytes": 24494756,
"heapUsedBytes": 93082940,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 954.977,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.998999999998,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.2259999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.6759999999999,
"heapDeltaBytes": 21855452,
"heapUsedBytes": 87236696,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.303,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2029.4770000000426,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.4060000000002,
"heapDeltaBytes": 4747108,
"heapUsedBytes": 82700832,
"domNodes": -285,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 34.746000000000016,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.9810000000148,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.982,
"heapDeltaBytes": 15161876,
"heapUsedBytes": 88586772,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.76,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.6139999999996,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.18,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.04300000000006,
"heapDeltaBytes": 15229000,
"heapUsedBytes": 88071916,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 148.597,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2006.8959999999834,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.822000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.4430000000001,
"heapDeltaBytes": -8754600,
"heapUsedBytes": 63856392,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 7.760999999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.835000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.17900000000003,
"heapDeltaBytes": -6438024,
"heapUsedBytes": 67029412,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.409,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1769.3510000000288,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.497999999999998,
"layouts": 18,
"layoutDurationMs": 4.465999999999999,
"taskDurationMs": 848.8059999999999,
"heapDeltaBytes": -7011728,
"heapUsedBytes": 65387504,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.24300000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.092999999939,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.423000000000002,
"layouts": 18,
"layoutDurationMs": 4.907,
"taskDurationMs": 730.506,
"heapDeltaBytes": 4114952,
"heapUsedBytes": 77503736,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.194,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5779999999959,
"styleRecalcs": 20,
"styleRecalcDurationMs": 33.516000000000005,
"layouts": 16,
"layoutDurationMs": 16.334,
"taskDurationMs": 971.816,
"heapDeltaBytes": 20950300,
"heapUsedBytes": 104016068,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.236000000000008,
"eventListeners": 2385,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8989.044999999976,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6034.106,
"heapDeltaBytes": 10756960,
"heapUsedBytes": 86820248,
"domNodes": -240,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2737.619,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9127.577000000088,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.785,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6239.436000000001,
"heapDeltaBytes": 21487988,
"heapUsedBytes": 97959260,
"domNodes": -268,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2888.341,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17793.14999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16985.593,
"heapDeltaBytes": -39174248,
"heapUsedBytes": 179693892,
"domNodes": -8068,
"jsHeapTotalBytes": -9494528,
"scriptDurationMs": 302.885,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17210.47299999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16711.195999999996,
"heapDeltaBytes": -62172436,
"heapUsedBytes": 178461740,
"domNodes": -8097,
"jsHeapTotalBytes": -21147648,
"scriptDurationMs": 286.678,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21154.79600000003,
"styleRecalcs": 168,
"styleRecalcDurationMs": 19.53699999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20807.863,
"heapDeltaBytes": -24238380,
"heapUsedBytes": 193915036,
"domNodes": -8068,
"jsHeapTotalBytes": -9781248,
"scriptDurationMs": 923.219,
"eventListeners": -14929,
"totalBlockingTimeMs": 108,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21674.54399999997,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.82299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21398.998,
"heapDeltaBytes": -44704716,
"heapUsedBytes": 184047280,
"domNodes": -8068,
"jsHeapTotalBytes": -18042880,
"scriptDurationMs": 899.5110000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6286.334000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.158,
"layouts": 20,
"layoutDurationMs": 22.176000000000002,
"taskDurationMs": 6194.043000000001,
"heapDeltaBytes": -35029112,
"heapUsedBytes": 177794708,
"domNodes": -8077,
"jsHeapTotalBytes": 4018176,
"scriptDurationMs": 113.54,
"eventListeners": -14929,
"totalBlockingTimeMs": 446,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6300.567000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.77399999999996,
"layouts": 20,
"layoutDurationMs": 21.645999999999997,
"taskDurationMs": 6170.493,
"heapDeltaBytes": -30387928,
"heapUsedBytes": 180983636,
"domNodes": -8068,
"jsHeapTotalBytes": 8007680,
"scriptDurationMs": 107.54899999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 466,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8949.729000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8543.313999999998,
"heapDeltaBytes": 22631532,
"heapUsedBytes": 183119904,
"domNodes": 0,
"jsHeapTotalBytes": -5767168,
"scriptDurationMs": 146.82099999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8974.935999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8532.582,
"heapDeltaBytes": -6038272,
"heapUsedBytes": 179329336,
"domNodes": 0,
"jsHeapTotalBytes": -9699328,
"scriptDurationMs": 148.72600000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.15299999999252,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.174,
"layouts": 2,
"layoutDurationMs": 0.8290000000000001,
"taskDurationMs": 80.44699999999999,
"heapDeltaBytes": 3109476,
"heapUsedBytes": 71355028,
"domNodes": 109,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.476,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 443.6909999999443,
"styleRecalcs": 12,
"styleRecalcDurationMs": 15.653,
"layouts": 2,
"layoutDurationMs": 0.415,
"taskDurationMs": 96.60600000000001,
"heapDeltaBytes": 4766668,
"heapUsedBytes": 73351224,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.905,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19238 +/- ##
=============================================
Coverage ? 83.99%
=============================================
Files ? 2117
Lines ? 126309
Branches ? 32013
=============================================
Hits ? 106095
Misses ? 20037
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The red here is pre-existing
Neither is reachable from this diff. The whole Both are already owned by other work on this branch:
Sibling backport #19222 shows the same So the sequencing is: this PR goes green once the harness repairs land. I've deliberately not touched those specs — they belong to #19236/#19233, and pulling them in would widen a backport that is otherwise a faithful, verified port. Local verification on this branch is unchanged and green: |
|
Correction to my comment above. I said the only real failure was
On the Vercel one specifically: What is green and is mine to answer for: So the conclusion doesn't change, but the evidence for it should have been stated correctly the first time: three of the six are cancelled rather than failed, one is a branch-wide Vercel failure reproducible on a sibling PR, and the remaining two are the harness breakage #19236/#19233/#19237 are fixing. |
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #18974 and checked the diff for conflict markers. The omitted useTopupOperation.ts change is not applicable because that composable does not exist on cloud/1.54; the remaining file set preserves the target-branch implementation.
Manual backport of #18974 (
787ed0b53e) tocloud/1.54. Production serves a SHA pinned on this branch, so PM-1473's E1 and E3 fixes — and revenue attribution R4 — are not actually delivered until this lands.comfy-pr-bot's cherry-pick failed on four files and left no branch behind, so this was done by hand.Resolved per file, not by taking main's side
cloud/1.54is missing work thatmainhas, so a union resolution would have imported unbackported code. Each conflict was resolved against the 1.54 baseline and my hunks reapplied to its shapes:useTopupOperation.tsdoes not exist on this branch. The composable is a main-only refactor, so itspaymentIntentSourceparameter has no home here. The equivalent change is applied directly at the component's ownbillingOperationStore.startOperationcall, which is what 1.54 uses instead.intentstage from feat(billing): instrument capability reads and purchase phases #17300, which is not on this branch. Taking main's side would have silently added an event that does not exist in 1.54.AgentPanelRoot.test.tsand the store test read telemetry through a module-leveltelemetry/mockTrackBillingEventhere rather thanuseTelemetry(), so the assertions are written to those idioms.SubscribeButton.test.tsbuilds the billing context explicitly —src/composables/billing/__mocks__/useBillingContext.tsdoes not exist on this branch, so the auto-mock supplies nothing.Worth flagging: the store test's hunks merged cleanly and still failed to compile, because they referenced a
useTelemetryimport this branch's test file does not have. A clean apply is not evidence a backport is correct.Verification on this branch
vue-tscclean,pnpm lint0 errors (193 pre-existing warnings), 512 tests passing across the five affected suites:AgentPanelRoot,SubscribeButton,billingOperationStore,TopUpCreditsDialogContentWorkspace,checkoutJourney.Scope
Closes E1 and E3 only. Not E4's
allowance_exhausted, which is blocked on whether billing-status will exposefunding_classclient-side.I have not approved this and will not — approval is the release action for a
backport-labelled PR againstcloud/*, and I am its author.