Skip to content

[backport cloud/1.54] fix(telemetry): close the E1 and E3 agent paywall attribution gaps (#18974) - #19238

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18974-to-cloud-1.54
Sep 28, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18974-to-cloud-1.54

Conversation

@huntcsg

@huntcsg huntcsg commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Manual backport of #18974 (787ed0b53e) to cloud/1.54. Production serves a SHA pinned on this branch, so PM-1473's E1 and E3 fixes — and revenue attribution R4 — are not actually delivered until this lands.

comfy-pr-bot's cherry-pick failed on four files and left no branch behind, so this was done by hand.

Resolved per file, not by taking main's side

cloud/1.54 is missing work that main has, so a union resolution would have imported unbackported code. Each conflict was resolved against the 1.54 baseline and my hunks reapplied to its shapes:

  • useTopupOperation.ts does not exist on this branch. The composable is a main-only refactor, so its paymentIntentSource parameter has no home here. The equivalent change is applied directly at the component's own billingOperationStore.startOperation call, which is what 1.54 uses instead.
  • The dialog has five top-up emit sites here, not six. The sixth is the intent stage from feat(billing): instrument capability reads and purchase phases #17300, which is not on this branch. Taking main's side would have silently added an event that does not exist in 1.54.
  • AgentPanelRoot.test.ts and the store test read telemetry through a module-level telemetry / mockTrackBillingEvent here rather than useTelemetry(), so the assertions are written to those idioms.
  • SubscribeButton.test.ts builds the billing context explicitly — src/composables/billing/__mocks__/useBillingContext.ts does not exist on this branch, so the auto-mock supplies nothing.

Worth flagging: the store test's hunks merged cleanly and still failed to compile, because they referenced a useTelemetry import this branch's test file does not have. A clean apply is not evidence a backport is correct.

Verification on this branch

vue-tsc clean, pnpm lint 0 errors (193 pre-existing warnings), 512 tests passing across the five affected suites: AgentPanelRoot, SubscribeButton, billingOperationStore, TopUpCreditsDialogContentWorkspace, checkoutJourney.

Scope

Closes E1 and E3 only. Not E4's allowance_exhausted, which is blocked on whether billing-status will expose funding_class client-side.

I have not approved this and will not — approval is the release action for a backport-labelled PR against cloud/*, and I am its author.

…ll attribution gaps (#18974)

Manual backport of 787ed0b. comfy-pr-bot's cherry-pick failed on four
files and left no branch behind.

Resolved per file against the cloud/1.54 baseline rather than by taking
main's side, because main carries work this branch does not:

- useTopupOperation.ts does not exist on cloud/1.54. The composable is a
  main-only refactor, so its paymentIntentSource parameter has no home
  here; the equivalent change is applied directly at the component's own
  billingOperationStore.startOperation call.
- The dialog has five top-up emit sites here, not six. The sixth is the
  `intent` stage from #17300, which is not on this branch — taking main's
  side would have imported an unbackported event.
- AgentPanelRoot.test.ts and the store test use a module-level `telemetry`
  and `mockTrackBillingEvent` here rather than reading through
  useTelemetry(), so the assertions are written to those. The store test's
  hunks merged cleanly and still failed to compile, which is the reason to
  typecheck a backport rather than trust a clean apply.
- SubscribeButton's test builds the billing context explicitly: the
  __mocks__/useBillingContext manual mock does not exist on this branch.

Verification on this branch: vue-tsc clean, lint 0 errors, 512 tests
passing across the five affected suites.
@huntcsg huntcsg added the backport Backporting a PR onto a release candidate label Sep 28, 2026
@vercel

vercel Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 10:25pm UTC
billing-web-test Ignored Ignored Sep 28, 2026 10:25pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: ebca5e24-667f-4e7c-b973-ac363d955db7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 10:57:48 PM UTC

Links

🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1941 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 145ms TBT · 99.2 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.8 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 78ms TBT · 180.2 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 456ms TBT · 171.1 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 587ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.5 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -165
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 905ms
canvas-mouse-sweep: script duration 171ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.5 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 363ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 467ms
dom-widget-clipping: script duration 167ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.5 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 638ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.7 MB
large-graph-idle: DOM nodes -277
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1692ms
large-graph-pan: script duration 821ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 84.2 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1774ms
large-graph-zoom: script duration 804ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.8 MB
large-graph-zoom: DOM nodes -144
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1979ms
legacy-node-drag: script duration 967ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 77.2 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 617ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.0 MB
minimap-idle: DOM nodes -280
minimap-idle: event listeners -192
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 437ms
subgraph-dom-widget-clipping: script duration 149ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 496ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.4 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -241
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 790ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.1 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 972ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 99.2 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 6137ms
viewport-pan-sweep: script duration 2813ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 88.1 MB
viewport-pan-sweep: DOM nodes -254
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16848ms
vue-large-graph-idle: script duration 295ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.8 MB
vue-large-graph-idle: DOM nodes -8083
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 166
vue-large-graph-pan: task duration 21103ms
vue-large-graph-pan: script duration 911ms
vue-large-graph-pan: TBT 78ms
vue-large-graph-pan: heap used 180.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 78ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6182ms
vue-node-resize-workload: script duration 111ms
vue-node-resize-workload: TBT 456ms
vue-node-resize-workload: heap used 171.1 MB
vue-node-resize-workload: DOM nodes -8073
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8538ms
vue-zoom-out-idle: script duration 148ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 16ms
workflow-execution: layout count 2
workflow-execution: style recalc count 10
workflow-execution: task duration 89ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.0 MB
workflow-execution: DOM nodes 113
workflow-execution: event listeners 51
Raw data
{
  "timestamp": "2026-09-28T13:17:29.058Z",
  "gitSha": "565d746e51b872dc79301768619e4ef3ac38ec87",
  "branch": "backport-18974-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2104.1119999999864,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.732999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 618.044,
      "heapDeltaBytes": 837292,
      "heapUsedBytes": 71813860,
      "domNodes": -280,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 12.844000000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2032.447999999988,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.68,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.9780000000001,
      "heapDeltaBytes": -5799476,
      "heapUsedBytes": 63504192,
      "domNodes": -282,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 10.265000000000004,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2022.2830000000158,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 37.44,
      "layouts": 14,
      "layoutDurationMs": 4.136000000000001,
      "taskDurationMs": 1029.0549999999998,
      "heapDeltaBytes": 3359216,
      "heapUsedBytes": 74688368,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 182.584,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1802.2020000000225,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 27.825999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.5580000000000003,
      "taskDurationMs": 780.9150000000001,
      "heapDeltaBytes": -4122928,
      "heapUsedBytes": 66904580,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 159.17800000000003,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.903000000024,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.795,
      "layouts": 6,
      "layoutDurationMs": 0.9700000000000002,
      "taskDurationMs": 364.471,
      "heapDeltaBytes": 4612476,
      "heapUsedBytes": 75866908,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.382,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.2120000000632,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.413,
      "layouts": 6,
      "layoutDurationMs": 1.001,
      "taskDurationMs": 362.37699999999995,
      "heapDeltaBytes": 4602892,
      "heapUsedBytes": 75946112,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.597999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 707.5480000000312,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.854000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.384,
      "heapDeltaBytes": -7297104,
      "heapUsedBytes": 62911672,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 166.882,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 680.7029999999941,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.507,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 469.12600000000003,
      "heapDeltaBytes": 18575808,
      "heapUsedBytes": 89224600,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 167.12400000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2060.653000000002,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.7940000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.3199999999999,
      "heapDeltaBytes": 10710104,
      "heapUsedBytes": 87029052,
      "domNodes": -269,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 33.679,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.8479999999363,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.111999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 670.488,
      "heapDeltaBytes": 5579880,
      "heapUsedBytes": 82158556,
      "domNodes": -285,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 41.215,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2373.0350000000158,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.417000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1682.114,
      "heapDeltaBytes": 12982108,
      "heapUsedBytes": 90207332,
      "domNodes": -274,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 813.231,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2378.5609999999906,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.776000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1701.832,
      "heapDeltaBytes": 8941364,
      "heapUsedBytes": 86453684,
      "domNodes": -273,
      "jsHeapTotalBytes": -925696,
      "scriptDurationMs": 828.106,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3716.3869999999974,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.902999999999999,
      "layouts": 60,
      "layoutDurationMs": 11.976,
      "taskDurationMs": 1775.5020000000004,
      "heapDeltaBytes": 8783880,
      "heapUsedBytes": 76538792,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 814.2349999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3651.37900000002,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.459,
      "layouts": 60,
      "layoutDurationMs": 11.992999999999999,
      "taskDurationMs": 1773.393,
      "heapDeltaBytes": -6433192,
      "heapUsedBytes": 71838488,
      "domNodes": -287,
      "jsHeapTotalBytes": 4354048,
      "scriptDurationMs": 793.396,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3112.2119999999995,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.151,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2033.4079999999997,
      "heapDeltaBytes": 690964,
      "heapUsedBytes": 68848200,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 978.3919999999999,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3115.660000000048,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.822,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1923.644,
      "heapDeltaBytes": 24494756,
      "heapUsedBytes": 93082940,
      "domNodes": 0,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 954.977,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.998999999998,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.2259999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 586.6759999999999,
      "heapDeltaBytes": 21855452,
      "heapUsedBytes": 87236696,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.303,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.4770000000426,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.66,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 647.4060000000002,
      "heapDeltaBytes": 4747108,
      "heapUsedBytes": 82700832,
      "domNodes": -285,
      "jsHeapTotalBytes": -1150976,
      "scriptDurationMs": 34.746000000000016,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 623.9810000000148,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 11.036,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.982,
      "heapDeltaBytes": 15161876,
      "heapUsedBytes": 88586772,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 149.76,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 646.6139999999996,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.18,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.04300000000006,
      "heapDeltaBytes": 15229000,
      "heapUsedBytes": 88071916,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 148.597,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.8959999999834,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.822000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.4430000000001,
      "heapDeltaBytes": -8754600,
      "heapUsedBytes": 63856392,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 7.760999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.835000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.595,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.17900000000003,
      "heapDeltaBytes": -6438024,
      "heapUsedBytes": 67029412,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.409,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1769.3510000000288,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.497999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.465999999999999,
      "taskDurationMs": 848.8059999999999,
      "heapDeltaBytes": -7011728,
      "heapUsedBytes": 65387504,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 110.24300000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.092999999939,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.423000000000002,
      "layouts": 18,
      "layoutDurationMs": 4.907,
      "taskDurationMs": 730.506,
      "heapDeltaBytes": 4114952,
      "heapUsedBytes": 77503736,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 111.194,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.5779999999959,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 33.516000000000005,
      "layouts": 16,
      "layoutDurationMs": 16.334,
      "taskDurationMs": 971.816,
      "heapDeltaBytes": 20950300,
      "heapUsedBytes": 104016068,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 31.236000000000008,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8989.044999999976,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.369,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6034.106,
      "heapDeltaBytes": 10756960,
      "heapUsedBytes": 86820248,
      "domNodes": -240,
      "jsHeapTotalBytes": -139264,
      "scriptDurationMs": 2737.619,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9127.577000000088,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.785,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6239.436000000001,
      "heapDeltaBytes": 21487988,
      "heapUsedBytes": 97959260,
      "domNodes": -268,
      "jsHeapTotalBytes": -172032,
      "scriptDurationMs": 2888.341,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17793.14999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16985.593,
      "heapDeltaBytes": -39174248,
      "heapUsedBytes": 179693892,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9494528,
      "scriptDurationMs": 302.885,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17210.47299999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16711.195999999996,
      "heapDeltaBytes": -62172436,
      "heapUsedBytes": 178461740,
      "domNodes": -8097,
      "jsHeapTotalBytes": -21147648,
      "scriptDurationMs": 286.678,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21154.79600000003,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 19.53699999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20807.863,
      "heapDeltaBytes": -24238380,
      "heapUsedBytes": 193915036,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9781248,
      "scriptDurationMs": 923.219,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 108,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21674.54399999997,
      "styleRecalcs": 164,
      "styleRecalcDurationMs": 17.82299999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21398.998,
      "heapDeltaBytes": -44704716,
      "heapUsedBytes": 184047280,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18042880,
      "scriptDurationMs": 899.5110000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 48,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6286.334000000011,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.158,
      "layouts": 20,
      "layoutDurationMs": 22.176000000000002,
      "taskDurationMs": 6194.043000000001,
      "heapDeltaBytes": -35029112,
      "heapUsedBytes": 177794708,
      "domNodes": -8077,
      "jsHeapTotalBytes": 4018176,
      "scriptDurationMs": 113.54,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 446,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6300.567000000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.77399999999996,
      "layouts": 20,
      "layoutDurationMs": 21.645999999999997,
      "taskDurationMs": 6170.493,
      "heapDeltaBytes": -30387928,
      "heapUsedBytes": 180983636,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8007680,
      "scriptDurationMs": 107.54899999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 466,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8949.729000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8543.313999999998,
      "heapDeltaBytes": 22631532,
      "heapUsedBytes": 183119904,
      "domNodes": 0,
      "jsHeapTotalBytes": -5767168,
      "scriptDurationMs": 146.82099999999997,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8974.935999999958,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8532.582,
      "heapDeltaBytes": -6038272,
      "heapUsedBytes": 179329336,
      "domNodes": 0,
      "jsHeapTotalBytes": -9699328,
      "scriptDurationMs": 148.72600000000003,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 121.15299999999252,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.174,
      "layouts": 2,
      "layoutDurationMs": 0.8290000000000001,
      "taskDurationMs": 80.44699999999999,
      "heapDeltaBytes": 3109476,
      "heapUsedBytes": 71355028,
      "domNodes": 109,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.476,
      "eventListeners": 35,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 443.6909999999443,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 15.653,
      "layouts": 2,
      "layoutDurationMs": 0.415,
      "taskDurationMs": 96.60600000000001,
      "heapDeltaBytes": 4766668,
      "heapUsedBytes": 73351224,
      "domNodes": 117,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 7.905,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50727 75880 66.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19238   +/-   ##
=============================================
  Coverage              ?   83.99%           
=============================================
  Files                 ?     2117           
  Lines                 ?   126309           
  Branches              ?    32013           
=============================================
  Hits                  ?   106095           
  Misses                ?    20037           
  Partials              ?      177           
Flag Coverage Δ
e2e 66.85% <ø> (?)
unit 79.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../cloud/subscription/components/SubscribeButton.vue 85.00% <ø> (ø)
src/platform/telemetry/types.ts 92.59% <ø> (ø)
.../components/TopUpCreditsDialogContentWorkspace.vue 86.76% <ø> (ø)
...platform/workspace/stores/billingOperationStore.ts 93.51% <ø> (ø)
src/workbench/extensions/agent/AgentPanelRoot.vue 91.47% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@huntcsg

huntcsg commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

The red here is pre-existing cloud/1.54 breakage, not this backport. No fix to push from my side.

e2e-status is the aggregate; the real failure is playwright-tests (cloud), in two agent specs:

  • agentConversationReplay.spec.ts — screenshot gate
  • agentAutogrowTabSwitchReconcile.spec.ts — CRDT autogrow across a tab switch

Neither is reachable from this diff. The whole AgentPanelRoot.vue change is four lines inside onPaywallAction, after the add-credits early return — no template change, and git diff --name-only origin/cloud/1.54...HEAD touches no browser_tests. That function only runs when a user clicks a paywall CTA; neither spec renders or clicks one.

Both are already owned by other work on this branch:

Sibling backport #19222 shows the same e2e-status failure — and additionally a failing test job, which this PR does not have.

So the sequencing is: this PR goes green once the harness repairs land. I've deliberately not touched those specs — they belong to #19236/#19233, and pulling them in would widen a backport that is otherwise a faithful, verified port.

Local verification on this branch is unchanged and green: vue-tsc clean, lint 0 errors, 512 tests passing across the five affected suites.

@huntcsg

huntcsg commented Sep 28, 2026

Copy link
Copy Markdown
Contributor Author

Correction to my comment above. I said the only real failure was playwright-tests (cloud) behind the e2e-status aggregate. That understated it — there are six red checks. I was filtering gh pr checks on a fixed column, and every check name containing a space shifted the columns and hid five of them. My apologies; here is the full set, each attributed.

Check Status Attribution
playwright-tests (cloud) fail cloud/1.54 agent-harness breakage — #19236 repairs the exact conversation-replay spec
e2e-status fail aggregate of the above
pr-risk / Resolve enablement cancelled no failed steps; gh pr checks renders cancelled as "fail"
pr-risk / Grade PR risk cancelled same
pr-risk / Publish the risk Check Run cancelled same
Vercel – billing-web-test fail same failure on sibling backport #19222, an unrelated change — broken on this branch, not from this diff

On the Vercel one specifically: apps/billing-web has no imports from any path this diff touches, and the diff contains zero files under apps/. Vercel – billing-web (the non-test project) passes.

What is green and is mine to answer for: test (21m25s), lint, typecheck, fallow, and the full ecosystem matrix all pass. The ported unit tests — the substance of this backport — are sound.

So the conclusion doesn't change, but the evidence for it should have been stated correctly the first time: three of the six are cancelled rather than failed, one is a branch-wide Vercel failure reproducible on a sibling PR, and the remaining two are the harness breakage #19236/#19233/#19237 are fixing.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against #18974 and checked the diff for conflict markers. The omitted useTopupOperation.ts change is not applicable because that composable does not exist on cloud/1.54; the remaining file set preserves the target-branch implementation.

@christian-byrne
christian-byrne merged commit 06cb6ee into cloud/1.54 Sep 28, 2026
28 of 29 checks passed
@christian-byrne
christian-byrne deleted the backport-18974-to-cloud-1.54 branch September 28, 2026 22:26
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants