Repository navigation
test(cloud/1.54): complete AgentPanelRoot app mock - #19233
christian-byrne wants to merge 14 commits into
Conversation
Backports db5e105 onto cloud/1.54. Preserve the release line’s deleted legacy reconciliation surfaces and numeric link handling while carrying the scope-race retry and its canvas-level regression.
Carries the hardened black-box proof from c6b4d27, including the pre-marker canvas assertion that prevents a later reconcile from repairing a false green.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T21:25:20.944Z",
"gitSha": "2baa205689918ef2b7a0674720e99ea890eaf0da",
"branch": "fix/duckunit-cloud154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2084.799999999973,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.3589999999999,
"heapDeltaBytes": 2589928,
"heapUsedBytes": 72866928,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.556000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2069.2399999999793,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.227,
"heapDeltaBytes": -12466716,
"heapUsedBytes": 57682548,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 14.623000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2077.171000000021,
"styleRecalcs": 81,
"styleRecalcDurationMs": 37.739,
"layouts": 14,
"layoutDurationMs": 4.199,
"taskDurationMs": 1035.2060000000001,
"heapDeltaBytes": 12259632,
"heapUsedBytes": 82560576,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 188.107,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2022.3669999999743,
"styleRecalcs": 81,
"styleRecalcDurationMs": 37.989,
"layouts": 14,
"layoutDurationMs": 4.252,
"taskDurationMs": 1052.295,
"heapDeltaBytes": -3985964,
"heapUsedBytes": 67427628,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 183.30100000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.5160000000187,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.116,
"layouts": 6,
"layoutDurationMs": 1.036,
"taskDurationMs": 366.3569999999999,
"heapDeltaBytes": 4574048,
"heapUsedBytes": 75647716,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.271000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1727.3209999999608,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.088,
"layouts": 6,
"layoutDurationMs": 1.223,
"taskDurationMs": 444.971,
"heapDeltaBytes": 4536024,
"heapUsedBytes": 75488580,
"domNodes": 75,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 16.604999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 677.5900000000092,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.526000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.746,
"heapDeltaBytes": -7596396,
"heapUsedBytes": 63418472,
"domNodes": 20,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 168.94799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 794.9219999999855,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.063,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.762,
"heapDeltaBytes": -7566404,
"heapUsedBytes": 62954344,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 180.853,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.1519999999919,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.966000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.934,
"heapDeltaBytes": 10451908,
"heapUsedBytes": 87580036,
"domNodes": -265,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 33.29,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2059.2809999999417,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.419999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.998,
"heapDeltaBytes": 10396544,
"heapUsedBytes": 87034592,
"domNodes": -269,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 43.735,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2324.0780000000427,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.249999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1702.854,
"heapDeltaBytes": 11620176,
"heapUsedBytes": 89043968,
"domNodes": -270,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 862.8739999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3049.0009999999756,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1982.5349999999999,
"heapDeltaBytes": 13753040,
"heapUsedBytes": 91078992,
"domNodes": -278,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 939.098,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3564.975000000004,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.699000000000003,
"layouts": 60,
"layoutDurationMs": 11.731,
"taskDurationMs": 1690.282,
"heapDeltaBytes": 8217784,
"heapUsedBytes": 76624880,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.149,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4041.518999999994,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.862,
"layouts": 60,
"layoutDurationMs": 13.876,
"taskDurationMs": 1991.899,
"heapDeltaBytes": -12089772,
"heapUsedBytes": 66576188,
"domNodes": -291,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 859.86,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3187.669000000028,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.195999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2002.6539999999998,
"heapDeltaBytes": -33064,
"heapUsedBytes": 67402348,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 991.8779999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3452.4579999999787,
"styleRecalcs": 41,
"styleRecalcDurationMs": 7.975999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2301.361,
"heapDeltaBytes": 18287088,
"heapUsedBytes": 99277664,
"domNodes": -293,
"jsHeapTotalBytes": 3723264,
"scriptDurationMs": 1106.3780000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.5600000000027,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6739999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.5830000000002,
"heapDeltaBytes": 21374816,
"heapUsedBytes": 87936248,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.307,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.134000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.6290000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.7210000000001,
"heapDeltaBytes": 9507148,
"heapUsedBytes": 88263496,
"domNodes": -273,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 40.09,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.1859999999847,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.059999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.4440000000001,
"heapDeltaBytes": 13960620,
"heapUsedBytes": 86723068,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.684,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 679.1170000000193,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.307,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.04699999999997,
"heapDeltaBytes": 15129792,
"heapUsedBytes": 88304848,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.038,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.578000000024,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.362000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.231,
"heapDeltaBytes": -10483068,
"heapUsedBytes": 61312680,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.2970000000000015,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2055.825999999911,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.034999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.58,
"heapDeltaBytes": -340648,
"heapUsedBytes": 72881604,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 14.019,
"eventListeners": -244,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.8269999999957,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.822,
"layouts": 18,
"layoutDurationMs": 4.374,
"taskDurationMs": 817.002,
"heapDeltaBytes": 6115308,
"heapUsedBytes": 79521028,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.59200000000001,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1747.7420000000166,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.031000000000006,
"layouts": 18,
"layoutDurationMs": 5.4719999999999995,
"taskDurationMs": 975.698,
"heapDeltaBytes": -9925880,
"heapUsedBytes": 62541440,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 128.579,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.590999999984,
"styleRecalcs": 18,
"styleRecalcDurationMs": 37.455000000000005,
"layouts": 14,
"layoutDurationMs": 18.786000000000005,
"taskDurationMs": 1135.295,
"heapDeltaBytes": 17506608,
"heapUsedBytes": 108140440,
"domNodes": 13831,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 36.51,
"eventListeners": 2387,
"totalBlockingTimeMs": 174,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8482.249999999965,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5880.116,
"heapDeltaBytes": 10440956,
"heapUsedBytes": 86623684,
"domNodes": -269,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2697.811,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10158.622000000036,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.336999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6523.133000000001,
"heapDeltaBytes": 9836356,
"heapUsedBytes": 86188028,
"domNodes": -283,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2931.824,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17184.61500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16681.54,
"heapDeltaBytes": -41466012,
"heapUsedBytes": 177232132,
"domNodes": -8068,
"jsHeapTotalBytes": -11808768,
"scriptDurationMs": 316.389,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18284.315000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17583.404,
"heapDeltaBytes": -56199728,
"heapUsedBytes": 182399112,
"domNodes": -8068,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 312.465,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21261.897999999972,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.284999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20818.868,
"heapDeltaBytes": -24278028,
"heapUsedBytes": 194139360,
"domNodes": -8068,
"jsHeapTotalBytes": -11849728,
"scriptDurationMs": 948.1629999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 45,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22050.205000000005,
"styleRecalcs": 168,
"styleRecalcDurationMs": 22.82200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21814.908000000003,
"heapDeltaBytes": -43898324,
"heapUsedBytes": 180301856,
"domNodes": -8068,
"jsHeapTotalBytes": -14430208,
"scriptDurationMs": 1017.2240000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 63,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6296.029999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.14500000000002,
"layouts": 20,
"layoutDurationMs": 24.009000000000018,
"taskDurationMs": 6194.938999999999,
"heapDeltaBytes": -57564452,
"heapUsedBytes": 182758236,
"domNodes": -8068,
"jsHeapTotalBytes": 13979648,
"scriptDurationMs": 116.356,
"eventListeners": -14927,
"totalBlockingTimeMs": 514,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6435.436999999979,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.87600000000002,
"layouts": 20,
"layoutDurationMs": 24.43400000000001,
"taskDurationMs": 6326.442999999999,
"heapDeltaBytes": -47008216,
"heapUsedBytes": 176584792,
"domNodes": -8068,
"jsHeapTotalBytes": 5427200,
"scriptDurationMs": 137.32699999999997,
"eventListeners": -14931,
"totalBlockingTimeMs": 443,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9063.077000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8856.591999999999,
"heapDeltaBytes": 22513988,
"heapUsedBytes": 179709776,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 151.48700000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9210.345999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8785.338000000002,
"heapDeltaBytes": 9315168,
"heapUsedBytes": 179357828,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 149.21499999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 97.88099999997257,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.607999999999999,
"layouts": 2,
"layoutDurationMs": 0.7010000000000001,
"taskDurationMs": 73.37500000000003,
"heapDeltaBytes": 3022748,
"heapUsedBytes": 72429192,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.420000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 133.98300000005747,
"styleRecalcs": 10,
"styleRecalcDurationMs": 26.514999999999997,
"layouts": 3,
"layoutDurationMs": 1.697,
"taskDurationMs": 95.65899999999999,
"heapDeltaBytes": 3399200,
"heapUsedBytes": 71961884,
"domNodes": 195,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.860999999999998,
"eventListeners": 55,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Self-review at c793565: the new mock matches the production call's Promise contract; the existing role/name assertion remains unchanged and proves the visible tab affordance. Full target-native AgentPanelRoot suite passes (307/307), and deleting this line restores the TypeError plus visible-control failure. No product behavior or frozen remote-apply code changed.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent release review at c793565: no blocking findings in the complete cloud/1.54 carrier diff. I reviewed the production retry/batch changes, clear/delete behavior, tab-return widget and missing-model repairs, harness delivery barrier, black-box positive controls, and the final Promise-shaped app mock. The no-scope retry is cancelled on reset/unbind, validation rejection stays fail-closed, and the visible tests distinguish a delivered clear from an unprocessed frame. Target-native evidence is appropriate, but merge remains held: the exact-head gate currently reports cursor-review / Consolidate panel, playwright-tests (cloud), and test as incomplete. Standing 1.54 backport authority permits an honest COMMENT review; this is not a manufactured approval.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 5c3cba2 | Docs | View more details | Give us feedback! |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 3 |
| 🟡 Medium | 6 |
| 🟢 Low | 1 |
Panel: 8/8 reviewers contributed findings.
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.54 #19233 +/- ##
=============================================
Coverage ? 83.96%
=============================================
Files ? 2119
Lines ? 126580
Branches ? 32361
=============================================
Hits ? 106286
Misses ? 20116
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Addresses review feedback: #19219 (comment)
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the complete cloud/1.54 diff at exact head a5943103ec01e9d7c4734d2559fcb63b37ac0686 against target f77fc6af7d8bdba95394437439d5fa7b078d6508; I found no current-head blocking defect. The target-native auth and remote-config mocks match the production exports, the thread-list mock now satisfies the ingest schema, and the composer cases distinguish an acknowledged send plus unsent draft from the three restoration failures. The delete/clear production files and both black-box pins are byte-identical to reviewed head 046f61b244; their controls bind the selected workflow/conversation and require an applied catch-up plus visible marker before accepting an empty canvas. Focused evidence is 173/173 auth/config tests green and 114 passed plus one expected failure in the follower suites; removing isAuthInitialized makes the focused panel test fail at agentPanel.ts:340. The selected local cloud browser cases remain blocked before assertions by the known cloud/1.54 Agent-button auth gate, so I did not count that run as acceptance.
Landing is not ready yet: the target-aware guard correctly refuses while test, cloud Playwright, browser shards, and ecosystem checks are in progress, and DrJKL’s displayed approval is attached to old head 046f61b2448b0c73859f85061ed16df2733f0a9f. Wake when exact-head hosted checks are terminal and non-adverse, except for the documented Vercel – billing-web-test release-line waiver, and a human has reviewed a5943103ec01e9d7c4734d2559fcb63b37ac0686.
Yes they can receive those repairs. |
|
Closing as superseded/stale after #19236, #19238, and #19222 landed. This stacked branch can no longer be updated cleanly and would now revert the telemetry backport, remove its tests, and roll back generated locale/node-definition content. Any still-useful mock-only delta should be extracted from the current cloud/1.54 head rather than merging this historical stack. |
Summary
Restore the cloud/1.54 AgentPanelRoot unit suite by including the target-native missing-model refresh method in its app mock.
Changes
refreshMissingModelsmock while preserving the visibleOpen duckrole/name assertion.Review Focus
The release carrier introduced an activation-time
app.refreshMissingModels(...)call. Without this method, the watcher rejects before tab activation completes and the existing accessible button assertion fails downstream.Test Plan
NODE_OPTIONS=--no-experimental-webstorage pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts(307 passed)TypeError: app.refreshMissingModels is not a functionand the missingOpen duckbutton.Screenshots (if applicable)
Not applicable; test-only repair.