Repository navigation
[backport core/1.55] FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system - #19231
Conversation
…esign-system (#19098) - Linear: FE-3046 **Merge order:** #19096 (ADR 0034 amendment) merges first. Until it does, ADR 0034 rule 4 still forbids account-ui from using the design system, which B does. ## Why `buttonVariants` lived in `src/components/ui/button/button.variants.ts`, inside the private root package, so a workspace package could not render a button with the app's exact classes. PR B (`@comfyorg/account-ui` checkout surfaces) needs those classes to render the embedded checkout identically in the cloud app and in billing-web. No visual change. ## How - `git mv` of `button.variants.ts` into `packages/design-system/src/`, content unchanged. - `packages/design-system/package.json`: new export `./button.variants`, a `files` entry, and `cva` (`catalog:`) as a dependency. - Every importer in `src/` (Button.vue, Button.stories.ts, CloudSocialAuthButtons.vue, InlinePromptEditor.vue, and the ten components that import the `ButtonVariants` type) now reads from `@comfyorg/design-system/button.variants`. The old path is deleted, no re-export shim. `apps/website` keeps its own copy. ## Review Focus The file content is byte-identical (rename only). The only decision is the entry name `./button.variants`, mirroring `./workspaceAvatar`. ## Stack | PR | branch | base | title | |---|---|---|---| | #19097 | `jaewon/billing-web-remove-plan-grid` | `main` | `FE-3045 refactor(billing-web): drop the billing-web plan grid; hosts own plan selection` | | **A #19098 (this PR)** | **`jaewon/design-system-button-variants`** | **#19097** | **`FE-3046 refactor(design-system): move buttonVariants into @comfyorg/design-system`** | | B #19099 | `jaewon/account-ui-checkout-surfaces` | A | `FE-3046 feat(account-ui): shared checkout confirm, saved-method selector, card form and success` | | C #19100 | `jaewon/workspace-adopt-account-ui-checkout` | B | `FE-3046 refactor(workspace): render the subscription checkout steps from account-ui` | | D #19101 | `jaewon/billing-web-shared-checkout` | C | `FE-3046 feat(billing-web): render the shared embedded checkout` | | E #19104 | `jaewon/billing-web-success-invite` | D | `FE-3046 feat(billing-web): invite your team from the checkout success step` | | F #19105 | `jaewon/checkout-3ds-failure-copy` | E | `FE-3047 fix(account-ui): clear decline toasts once a retry succeeds` | | G #19106 | `jaewon/billing-web-return-close-tab` | F | `FE-3048 fix(billing-web): return to the host by closing the checkout tab` | | H #19115 | `jaewon/checkout-cta-reachable` | G | `FE-3050 fix(account-ui): keep the checkout CTA reachable when notices grow the confirm step` | ```mermaid graph LR P0[#19097: remove plan grid] --> A[A: design-system buttonVariants] A --> B[B: account-ui checkout surfaces] B --> C[C: workspace adopts account-ui] C --> D[D: billing-web shared checkout] D --> E[E: billing-web success invite] E --> F[F: stale decline toasts] F --> G[G: close the billing tab] G --> H[H: reachable checkout CTA] style A fill:#f9d71c,stroke:#333,color:#000 ``` ## AS IS / TO BE Rename only, no rendered change, so no screenshots. | AS IS | TO BE | | --- | --- | | `@/components/ui/button/button.variants` | `@comfyorg/design-system/button.variants` | --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🌐 Website E2ECaution A shard failed before producing a report, so the suite did not fully run. No pass/fail counts are available.
🎭 Playwright: ✅ 2123 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a6d9028a5fc31b934d06e6528dd016cdd4e745cb
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-28T11:33:28.296Z",
"gitSha": "b5cb4aeb81e57a4b356b19e901f0f614a8f86908",
"branch": "backport-19098-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2001.0760000000118,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.782000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.0930000000001,
"heapDeltaBytes": 5161100,
"heapUsedBytes": 72870824,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.982,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.156000000109,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.011000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.4160000000001,
"heapDeltaBytes": 4550380,
"heapUsedBytes": 72259804,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.73,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1786.02699999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.467,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 860.1569999999999,
"heapDeltaBytes": 10660832,
"heapUsedBytes": 78169752,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 174.423,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.925999999965,
"styleRecalcs": 44,
"styleRecalcDurationMs": 15.927999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 841.648,
"heapDeltaBytes": 11296884,
"heapUsedBytes": 78719704,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 175.536,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.8119999999526,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.963999999999999,
"layouts": 6,
"layoutDurationMs": 1.1890000000000003,
"taskDurationMs": 392.671,
"heapDeltaBytes": 3169480,
"heapUsedBytes": 70287652,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.785999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.8809999999894,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.375999999999998,
"layouts": 6,
"layoutDurationMs": 1.013,
"taskDurationMs": 319.285,
"heapDeltaBytes": 3107408,
"heapUsedBytes": 70961552,
"domNodes": 80,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.694999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 683.495999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.888,
"heapDeltaBytes": 18903300,
"heapUsedBytes": 86541784,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 176.811,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 687.498000000005,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.95200000000006,
"heapDeltaBytes": 18319216,
"heapUsedBytes": 80800116,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 171.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.7830000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 907.0749999999999,
"heapDeltaBytes": 38794712,
"heapUsedBytes": 106813608,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 80.871,
"eventListeners": 0,
"totalBlockingTimeMs": 604,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1292.242999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 986.019,
"heapDeltaBytes": -16950324,
"heapUsedBytes": 73152968,
"domNodes": -295,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 83.11500000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 608,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.2829999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.1629999999992,
"heapDeltaBytes": 15823308,
"heapUsedBytes": 92390628,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.90099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 854.7610000000532,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.7080000000005,
"heapDeltaBytes": 14649476,
"heapUsedBytes": 91310700,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.73400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10576.061000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9579.629,
"heapDeltaBytes": -13119356,
"heapUsedBytes": 68911556,
"domNodes": -12,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 8135.088000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1337,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11464.034999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10578.129,
"heapDeltaBytes": -11218072,
"heapUsedBytes": 70441740,
"domNodes": -14,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8736.152,
"eventListeners": 0,
"totalBlockingTimeMs": 1795,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11241.809000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10326.632,
"heapDeltaBytes": -9781620,
"heapUsedBytes": 72297120,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8523.285000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 1376,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11964.526999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10995.618999999999,
"heapDeltaBytes": -8772248,
"heapUsedBytes": 73429192,
"domNodes": -16,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 9161.792,
"eventListeners": 0,
"totalBlockingTimeMs": 1926,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2088.3269999999925,
"styleRecalcs": 10,
"styleRecalcDurationMs": 13.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 718.6679999999999,
"heapDeltaBytes": -5184736,
"heapUsedBytes": 81624340,
"domNodes": -239,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 38.88799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2048.7119999999095,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.253999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.323,
"heapDeltaBytes": -3757588,
"heapUsedBytes": 83032768,
"domNodes": -238,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 42.50000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2451.808999999969,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.243000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1569.969,
"heapDeltaBytes": 19303576,
"heapUsedBytes": 83762964,
"domNodes": -247,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 904.37,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2684.5050000000583,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.582999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1820.1260000000002,
"heapDeltaBytes": -7087168,
"heapUsedBytes": 81059740,
"domNodes": -216,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 943.5229999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3740.9299999999917,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.717000000000002,
"layouts": 60,
"layoutDurationMs": 14.801000000000002,
"taskDurationMs": 1846.752,
"heapDeltaBytes": 9736596,
"heapUsedBytes": 98948856,
"domNodes": 12,
"jsHeapTotalBytes": 5541888,
"scriptDurationMs": 865.14,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3737.7010000000155,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.490999999999998,
"layouts": 60,
"layoutDurationMs": 14.054,
"taskDurationMs": 1802.2690000000002,
"heapDeltaBytes": 8745244,
"heapUsedBytes": 74537872,
"domNodes": 8,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 842.101,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3509.568999999999,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.934999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2290.393,
"heapDeltaBytes": 1463568,
"heapUsedBytes": 67340252,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1192.1390000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3113.7630000000627,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.424000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1986.4009999999998,
"heapDeltaBytes": 25835116,
"heapUsedBytes": 91902308,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1042.0980000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2027.4290000000406,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.627999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.5790000000001,
"heapDeltaBytes": -4231632,
"heapUsedBytes": 84460172,
"domNodes": -247,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 41.403999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.688000000031,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.813000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.84999999999997,
"heapDeltaBytes": -7519392,
"heapUsedBytes": 81509912,
"domNodes": -246,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 31.39700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 634.9500000000035,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.501999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.82399999999996,
"heapDeltaBytes": 14045356,
"heapUsedBytes": 83305704,
"domNodes": 19,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.725,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.510000000042,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.334,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.25600000000003,
"heapDeltaBytes": 13791532,
"heapUsedBytes": 83627044,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.647,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2013.6170000000106,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.263,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.961,
"heapDeltaBytes": -4693976,
"heapUsedBytes": 65206156,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.850999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.2179999999662,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.123000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.01300000000003,
"heapDeltaBytes": 10468004,
"heapUsedBytes": 79491108,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.200999999999997,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.1510000000162,
"styleRecalcs": 45,
"styleRecalcDurationMs": 18.317,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.0869999999999,
"heapDeltaBytes": 7194436,
"heapUsedBytes": 77234240,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 114.14099999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.252000000106,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 807.2199999999999,
"heapDeltaBytes": 9780672,
"heapUsedBytes": 79493764,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 119.02499999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0769999999866,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.935000000000002,
"layouts": 5,
"layoutDurationMs": 13.107999999999999,
"taskDurationMs": 1017.504,
"heapDeltaBytes": -6300784,
"heapUsedBytes": 81979732,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 34.609,
"eventListeners": 2383,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9472.802000000001,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6441.941,
"heapDeltaBytes": -1827756,
"heapUsedBytes": 85001496,
"domNodes": -242,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 3073.1430000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9094.273000000045,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.066,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6180.828,
"heapDeltaBytes": -6070236,
"heapUsedBytes": 80830300,
"domNodes": -243,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2942.491,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17142.862999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16667.118000000002,
"heapDeltaBytes": -67857148,
"heapUsedBytes": 177173192,
"domNodes": -8061,
"jsHeapTotalBytes": -19988480,
"scriptDurationMs": 291.57,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16377.45300000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15392.702,
"heapDeltaBytes": -56858960,
"heapUsedBytes": 164653736,
"domNodes": -8062,
"jsHeapTotalBytes": -11341824,
"scriptDurationMs": 242.808,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21807.966000000022,
"styleRecalcs": 167,
"styleRecalcDurationMs": 21.264000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21595.297000000002,
"heapDeltaBytes": -70277776,
"heapUsedBytes": 170089492,
"domNodes": -8061,
"jsHeapTotalBytes": -18243584,
"scriptDurationMs": 986.549,
"eventListeners": -14928,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.77666666666652,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20469.509000000016,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.471000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20257.157,
"heapDeltaBytes": -62054568,
"heapUsedBytes": 179052932,
"domNodes": -8061,
"jsHeapTotalBytes": -20647936,
"scriptDurationMs": 895.269,
"eventListeners": -14928,
"totalBlockingTimeMs": 59,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6082.332999999949,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.41899999999997,
"layouts": 20,
"layoutDurationMs": 24.435,
"taskDurationMs": 5987.004000000001,
"heapDeltaBytes": -8275372,
"heapUsedBytes": 180100260,
"domNodes": -8061,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 107.667,
"eventListeners": -14928,
"totalBlockingTimeMs": 448,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6006.125999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.63799999999999,
"layouts": 20,
"layoutDurationMs": 22.484000000000005,
"taskDurationMs": 5914.701999999999,
"heapDeltaBytes": -53227252,
"heapUsedBytes": 174566320,
"domNodes": -8061,
"jsHeapTotalBytes": 3731456,
"scriptDurationMs": 102.325,
"eventListeners": -14928,
"totalBlockingTimeMs": 397,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8765.643999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8579.513000000003,
"heapDeltaBytes": -15550700,
"heapUsedBytes": 171573316,
"domNodes": -1520,
"jsHeapTotalBytes": -27000832,
"scriptDurationMs": 133.63500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8374.24599999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7956.140999999999,
"heapDeltaBytes": -8895264,
"heapUsedBytes": 171193956,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 142.34200000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 476.24500000006265,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.622999999999998,
"layouts": 5,
"layoutDurationMs": 2.513,
"taskDurationMs": 141.198,
"heapDeltaBytes": 5255676,
"heapUsedBytes": 70936500,
"domNodes": 151,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 16.099999999999998,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 98.17899999995916,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.731000000000002,
"layouts": 3,
"layoutDurationMs": 1.499,
"taskDurationMs": 71.86499999999998,
"heapDeltaBytes": 2969964,
"heapUsedBytes": 68614016,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.171,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19231 +/- ##
=============================================
- Coverage 84.66% 83.72% -0.94%
=============================================
Files 2301 3026 +725
Lines 132083 149711 +17628
Branches 35679 40605 +4926
=============================================
+ Hits 111823 125346 +13523
- Misses 19937 23042 +3105
- Partials 323 1323 +1000
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 732 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against #19098: exact file list, no conflict markers, and all required checks pass. The package/lockfile change is scoped to adding the existing catalog cva dependency to the internal design-system importer; it does not refresh versions or transitive dependencies.
…9099, #19100, #19101, #19104) (#19442) ## Why Backport of the FE-3046 billing-web shared-checkout stack to `core/1.55`. The auto-backport bot hit cherry-pick conflicts on each of these. The 1.55 release needs billing-web to render the same checkout as the app, including the team invite on success. ## How ### Cherry-picked (in order, `-x`) | PR | main squash | | |---|---|---| | #19098 (A) | | skipped: already on `core/1.55` via #19231 | | #19099 (B) | | skipped: already on `core/1.55` via #19308 | | #19100 (C) | `4bfdc8a68c` | render the subscription checkout steps from account-ui | | #19101 (D) | `d5cf71ce27` | billing-web renders the shared embedded checkout | | #19104 (E) | `592588bdd6` | team invite on the checkout success step (squash includes #19105, #19106, #19115) | No other prerequisite was cherry-picked. ### Conflicts and resolutions - **C, `SubscriptionAddPaymentPreviewWorkspace.stripe.test.ts`** (renamed from `UnifiedStripePaymentSelector.test.ts`). 1.55 mocks telemetry with an explicit factory because it lacks #18497; main automocks it. Took C's file as is. `src/platform/telemetry/__mocks__/index.ts` exists on 1.55, so the automock resolves and the test passes. - **D, `apps/billing-web/src/views/CheckoutView.vue`**. 1.55 has #19305 (backport of #19185, show the server's refusal reason), which main does not have yet. Kept D's checkout and kept 1.55's `refusal()` on the subscribe failure and the quote-failure panel. Also used `refusal()` for D's new promotion-code re-quote failure, as the upstream `jaewon/checkout-quote-stale-recovery` stack does. Dropped the now-unused `coded`. - **E, `apps/billing-web/src/session/billingWebAuth.ts`** (modify/delete). The file does not exist on 1.55 because the unified web session work (#18880, #18881) is not backported. Deleted it and applied E's change to what 1.55 has: `billingWebClient.ts` gains the `BillingWebClient` type (`BillingClient & { invites }`) and `invites: createWorkspaceInviteCommands({ transport })` on its single `createBillingWebClient`. - **E, `BillingShell.vue`**. Kept 1.55's `createBillingWebClient(billingWebSessionClient())` and added E's `provideWorkspaceInvites(client.invites)`. - **E, `HostedSurface.vue`**. Kept 1.55's `useBillingWebSession` and added E's `returnToHost` import (the return link now closes the tab, from #19106). - **E, `CheckoutView.vue`**. Kept `refusal` as above and took E's `inviteCopy` and `useWorkspaceInvites()`. - **E, `useSubscriptionCheckout.ts`**. Kept 1.55's `useEventListener` import and added E's `watch` and `ToastMessageOptions`. 1.55 does not use `onScopeDispose`, so it is not imported. - **E, `useSubscriptionCheckout.test.ts`**. The toast mock gains E's `remove`. 1.55 has no `removeGroup` usage, so `mockToastRemoveGroup` is not added. One extra commit updates a #19305 test case. For a refused subscribe with `OPERATION_ALREADY_PENDING`, it expected the generic failure copy because 1.55 had no copy for that code. D adds that copy, so the case now expects billing-web's own wording, matching the upstream stack. ## Verification - `pnpm typecheck` (app, account-core, billing-web, account-ui, billing-contract): pass - billing-web unit tests: 277/277 - account-ui unit tests: 224/224 - account-core unit tests: 1227/1227 - `src/platform/workspace` + `src/platform/cloud/subscription`: 2320 passed, 1 expected fail - oxfmt, oxlint and eslint on the changed files: clean ## AS IS / TO BE Same UI as the original PRs; see the AS IS / TO BE media in #19101 and #19104. --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Backport of #19098 to
core/1.55Automatically created by backport workflow.