Repository navigation
[backport cloud/1.55] feat(agent): attach user id to agent feedback Typeform hidden fields - #19372
Conversation
…19028) *PR Created by the Glary-Bot Agent* --- ## Blocked on a Typeform config change — please read first This PR is inert until a hidden field with the ref **exactly `userid`** is added to Typeform **`MZ6cjWIB`** ("Comfy Agent Feedback Intake Form"). Typeform silently discards any ref the form does not declare — no error, no warning, the value just never appears on the response. Verified against the live form today: ``` $ curl -fsSL https://form.typeform.com/to/MZ6cjWIB | grep -o '"hidden":\[[^]]*\]' "hidden":["email","intent","source","version","os","session"] ``` This also extends the approved hidden-field allowlist from 6 refs to 7. The exact-set assertion in `feedback.test.ts` was originally added as a mechanical tripwire against unapproved fields, so this note is what replaces it — please confirm the extension is intended. ## Why Agent-panel feedback attaches a `session` hidden field, but it is legitimately absent whenever no thread is active. Langfuse is not indexed by email, so those responses currently cannot be traced back to the reporting user at all. Attaching the user id keeps a response traceable even when `session` drops out. ## What `src/workbench/extensions/agent/feedback.ts` now adds `userid` to the hidden fields, sourced from `useCurrentUser().resolvedUserInfo` — the Firebase uid when signed in with Firebase, or the API-key user id otherwise. It follows the existing conventions in that code path: absent values are omitted rather than sent as placeholders, and commas are escaped so a value cannot inject an extra field. ## Verification Full `pnpm typecheck:app`, oxfmt, oxlint `--type-aware` and eslint all pass (pre-commit hook). Targeted unit tests: 15 files / 97 tests pass. Exercised end-to-end against a real dev build in a browser — the actual `MZ6cjWIB` form rendering in the real dialog, driving the real store → `feedback.ts` → `openTypeformDialog` → `TypeformEmbed` path. Reading the rendered `data-tf-hidden` attribute: ``` email=…,userid=ixHDSYNamEOlkRtXtkEuvq9X1EC2,source=agent-panel,version=1.56.0,os=Linux x86_64,session=thread-abc-123 ``` And after `conversationStore.reset()` (what **New Chat** calls) — reproducing the reported empty-session case, where `userid` is now the only thing that keeps the response traceable: ``` email=…,userid=ixHDSYNamEOlkRtXtkEuvq9X1EC2,source=agent-panel,version=1.56.0,os=Linux x86_64 ``` ## Notes - `intent` is declared on the form but never populated by the frontend, which is why it is blank on every response. Out of scope here, but worth a decision — either wire it up or drop it from the form. - The general feedback form (`q7azbWPi`, via `platform/support/feedbackDialog.ts`) is a different form with a different field set and is deliberately untouched. ## Screenshots \n\nJustification: Program-owned bot carrier at exact head 948ee33 has Dante Yoon approval, all required exact-head checks green, no open human objection, and zero file overlap with the 120-commit main delta; independent review confirms the delta only adds the approved userid hidden field and tests. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a52d4540a02ef16839b4daf6194413241174fde
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2121 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T07:29:37.279Z",
"gitSha": "5dc7c7de1c65e7b0f5cb3ad4b84ab1f122581db7",
"branch": "backport-19028-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.01800000004,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.932000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.21199999999993,
"heapDeltaBytes": -3460824,
"heapUsedBytes": 64216936,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.921999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.8070000000043,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.838999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.63300000000004,
"heapDeltaBytes": -5370896,
"heapUsedBytes": 62374692,
"domNodes": -262,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 7.83,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1701.8709999999828,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 773.451,
"heapDeltaBytes": 12351868,
"heapUsedBytes": 80070640,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 159.36800000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.506999999956,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.461000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 782.301,
"heapDeltaBytes": 11686372,
"heapUsedBytes": 79276024,
"domNodes": -259,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 157.391,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.4740000000238,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.552000000000001,
"layouts": 6,
"layoutDurationMs": 1.073,
"taskDurationMs": 323.60699999999997,
"heapDeltaBytes": 3168692,
"heapUsedBytes": 70775604,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.988,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.5110000000377,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.314,
"layouts": 6,
"layoutDurationMs": 0.99,
"taskDurationMs": 322.189,
"heapDeltaBytes": 3080472,
"heapUsedBytes": 70769512,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.418000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 638.5859999999752,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.671000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.897,
"heapDeltaBytes": 18911644,
"heapUsedBytes": 86558028,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 167.834,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 620.6369999999879,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.436,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.0660000000001,
"heapDeltaBytes": 18633340,
"heapUsedBytes": 86153724,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 163.412,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1175.2269999999498,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.0959999999999,
"heapDeltaBytes": 8842568,
"heapUsedBytes": 82836148,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 67.85400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 563,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1141.2880000000314,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 753.3069999999999,
"heapDeltaBytes": 38321284,
"heapUsedBytes": 106754824,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 64.48499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 536,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0190000000125,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.27300000000037,
"heapDeltaBytes": 14663656,
"heapUsedBytes": 91008740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.54999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.0559999999759,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.0519999999999,
"heapDeltaBytes": 14495880,
"heapUsedBytes": 89679600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.664,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10581.16000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9719.133,
"heapDeltaBytes": -8021784,
"heapUsedBytes": 69114128,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8063.407,
"eventListeners": 0,
"totalBlockingTimeMs": 1212,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10774.99499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9882.952,
"heapDeltaBytes": 6504960,
"heapUsedBytes": 89016900,
"domNodes": -16,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 8529.548,
"eventListeners": 0,
"totalBlockingTimeMs": 1590,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10984.33399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10135.056999999999,
"heapDeltaBytes": -275104,
"heapUsedBytes": 81804504,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8462.893,
"eventListeners": 0,
"totalBlockingTimeMs": 1321,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10308.446000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9463.961000000001,
"heapDeltaBytes": -1235492,
"heapUsedBytes": 81116400,
"domNodes": -10,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7823.512999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1119,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2049.917999999991,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.645000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.103,
"heapDeltaBytes": -3139484,
"heapUsedBytes": 83693668,
"domNodes": -242,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 35.077999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.0120000000134,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.131,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.9649999999999,
"heapDeltaBytes": -3411468,
"heapUsedBytes": 83537796,
"domNodes": -244,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.447,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2334.987999999953,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.149,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1689.5950000000003,
"heapDeltaBytes": -1752540,
"heapUsedBytes": 86021696,
"domNodes": -246,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 903.23,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2269.8449999999184,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.452,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1620.4979999999998,
"heapDeltaBytes": 15673288,
"heapUsedBytes": 80190592,
"domNodes": 10,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 860.4929999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3493.7450000000467,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.886,
"layouts": 60,
"layoutDurationMs": 12.633,
"taskDurationMs": 1648.0119999999997,
"heapDeltaBytes": 8389452,
"heapUsedBytes": 74917488,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.264,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3589.289000000008,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.950999999999999,
"layouts": 60,
"layoutDurationMs": 12.931,
"taskDurationMs": 1733.5550000000003,
"heapDeltaBytes": -15853796,
"heapUsedBytes": 73733300,
"domNodes": -250,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 787.884,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 2966.4679999999635,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.921999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1746.0040000000001,
"heapDeltaBytes": 17988920,
"heapUsedBytes": 83976532,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1001.101,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3131.6269999999804,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.311000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.973,
"heapDeltaBytes": 29263396,
"heapUsedBytes": 95435240,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 981.8889999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.0400000000286,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.856999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.7810000000001,
"heapDeltaBytes": -6690820,
"heapUsedBytes": 82438928,
"domNodes": -249,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 30.449000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2003.665000000069,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.4019999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.572,
"heapDeltaBytes": 20218616,
"heapUsedBytes": 84264356,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.30599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.9069999999724,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.406999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.41499999999996,
"heapDeltaBytes": 14105484,
"heapUsedBytes": 83942264,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.091,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.2909999999538,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.703999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 361.89700000000005,
"heapDeltaBytes": 13760744,
"heapUsedBytes": 83584780,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.706,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.8500000000195,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.421000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.099,
"heapDeltaBytes": -6223748,
"heapUsedBytes": 63503296,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.378,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.8770000000222,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.15200000000004,
"heapDeltaBytes": -12674520,
"heapUsedBytes": 57095012,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.5619999999999985,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0129999999704,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.189000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 727.348,
"heapDeltaBytes": 369060,
"heapUsedBytes": 63344412,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 103.362,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.116999999911,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.6600000000001,
"heapDeltaBytes": 1791460,
"heapUsedBytes": 71770584,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.545,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.366,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.745,
"layouts": 5,
"layoutDurationMs": 12.829,
"taskDurationMs": 871.9389999999999,
"heapDeltaBytes": -6320492,
"heapUsedBytes": 81733400,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.219,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8292.311999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.696,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5136.697,
"heapDeltaBytes": -4946172,
"heapUsedBytes": 81676904,
"domNodes": -217,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2862.149,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8327.173000000017,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.749,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5751.739,
"heapDeltaBytes": -18600960,
"heapUsedBytes": 68030528,
"domNodes": -239,
"jsHeapTotalBytes": 4222976,
"scriptDurationMs": 2788.563,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16774.766999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16172.527000000002,
"heapDeltaBytes": -35128792,
"heapUsedBytes": 195268148,
"domNodes": -8061,
"jsHeapTotalBytes": -18309120,
"scriptDurationMs": 283.32199999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16626.77999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16037.993999999997,
"heapDeltaBytes": -27691724,
"heapUsedBytes": 195261768,
"domNodes": -8062,
"jsHeapTotalBytes": -20418560,
"scriptDurationMs": 283.552,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20363.972999999987,
"styleRecalcs": 164,
"styleRecalcDurationMs": 16.47399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20055.877000000004,
"heapDeltaBytes": -48649112,
"heapUsedBytes": 192511032,
"domNodes": -8061,
"jsHeapTotalBytes": -19406848,
"scriptDurationMs": 876.2189999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 8,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20418.285999999967,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.02300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20028.501000000004,
"heapDeltaBytes": -72107856,
"heapUsedBytes": 169157912,
"domNodes": -8061,
"jsHeapTotalBytes": -16715776,
"scriptDurationMs": 927.4689999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 79,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6106.143999999972,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.735,
"layouts": 20,
"layoutDurationMs": 22.83600000000001,
"taskDurationMs": 5991.33,
"heapDeltaBytes": -43194712,
"heapUsedBytes": 196788836,
"domNodes": -8061,
"jsHeapTotalBytes": 12165120,
"scriptDurationMs": 106.357,
"eventListeners": -14928,
"totalBlockingTimeMs": 410,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5999.680000000012,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.568,
"layouts": 20,
"layoutDurationMs": 22.83199999999999,
"taskDurationMs": 5924.796,
"heapDeltaBytes": -52621280,
"heapUsedBytes": 181595380,
"domNodes": -8061,
"jsHeapTotalBytes": 16240640,
"scriptDurationMs": 103.33399999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 359,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8379.587000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8152.504000000001,
"heapDeltaBytes": 12267728,
"heapUsedBytes": 186782320,
"domNodes": 0,
"jsHeapTotalBytes": -23592960,
"scriptDurationMs": 122.36500000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8255.820999999969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7987.130999999999,
"heapDeltaBytes": -35699380,
"heapUsedBytes": 165927652,
"domNodes": 0,
"jsHeapTotalBytes": -32243712,
"scriptDurationMs": 117.43200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 118.83000000000266,
"styleRecalcs": 10,
"styleRecalcDurationMs": 19.630000000000003,
"layouts": 4,
"layoutDurationMs": 1.955,
"taskDurationMs": 87.90400000000001,
"heapDeltaBytes": 3324720,
"heapUsedBytes": 68963260,
"domNodes": 113,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.305,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 96.76999999999225,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.925999999999998,
"layouts": 4,
"layoutDurationMs": 1.9969999999999997,
"taskDurationMs": 72.739,
"heapDeltaBytes": 2933680,
"heapUsedBytes": 68885376,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.639000000000003,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #19372 +/- ##
=============================================
Coverage ? 84.70%
=============================================
Files ? 2322
Lines ? 132793
Branches ? 33736
=============================================
Hits ? 112485
Misses ? 19956
Partials ? 352
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Backport verified against the release branch. CI is green and the prerequisite stack is complete.
Backport of #19028 to
cloud/1.55Automatically created by backport workflow.