Repository navigation
[backport core/1.54] feat(agent): attach user id to agent feedback Typeform hidden fields - #19570
Conversation
…19028) *PR Created by the Glary-Bot Agent* --- This PR is inert until a hidden field with the ref **exactly `userid`** is added to Typeform **`MZ6cjWIB`** ("Comfy Agent Feedback Intake Form"). Typeform silently discards any ref the form does not declare — no error, no warning, the value just never appears on the response. Verified against the live form today: ``` $ curl -fsSL https://form.typeform.com/to/MZ6cjWIB | grep -o '"hidden":\[[^]]*\]' "hidden":["email","intent","source","version","os","session"] ``` This also extends the approved hidden-field allowlist from 6 refs to 7. The exact-set assertion in `feedback.test.ts` was originally added as a mechanical tripwire against unapproved fields, so this note is what replaces it — please confirm the extension is intended. Agent-panel feedback attaches a `session` hidden field, but it is legitimately absent whenever no thread is active. Langfuse is not indexed by email, so those responses currently cannot be traced back to the reporting user at all. Attaching the user id keeps a response traceable even when `session` drops out. `src/workbench/extensions/agent/feedback.ts` now adds `userid` to the hidden fields, sourced from `useCurrentUser().resolvedUserInfo` — the Firebase uid when signed in with Firebase, or the API-key user id otherwise. It follows the existing conventions in that code path: absent values are omitted rather than sent as placeholders, and commas are escaped so a value cannot inject an extra field. Full `pnpm typecheck:app`, oxfmt, oxlint `--type-aware` and eslint all pass (pre-commit hook). Targeted unit tests: 15 files / 97 tests pass. Exercised end-to-end against a real dev build in a browser — the actual `MZ6cjWIB` form rendering in the real dialog, driving the real store → `feedback.ts` → `openTypeformDialog` → `TypeformEmbed` path. Reading the rendered `data-tf-hidden` attribute: ``` email=…,userid=ixHDSYNamEOlkRtXtkEuvq9X1EC2,source=agent-panel,version=1.56.0,os=Linux x86_64,session=thread-abc-123 ``` And after `conversationStore.reset()` (what **New Chat** calls) — reproducing the reported empty-session case, where `userid` is now the only thing that keeps the response traceable: ``` email=…,userid=ixHDSYNamEOlkRtXtkEuvq9X1EC2,source=agent-panel,version=1.56.0,os=Linux x86_64 ``` - `intent` is declared on the form but never populated by the frontend, which is why it is blank on every response. Out of scope here, but worth a decision — either wire it up or drop it from the form. - The general feedback form (`q7azbWPi`, via `platform/support/feedbackDialog.ts`) is a different form with a different field set and is deliberately untouched. \n\nJustification: Program-owned bot carrier at exact head 948ee33 has Dante Yoon approval, all required exact-head checks green, no open human objection, and zero file overlap with the 120-commit main delta; independent review confirms the delta only adds the approved userid hidden field and tests. --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1960 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-30T09:59:11.491Z",
"gitSha": "09978964289317207be45d4c08753e6ac49bf8fb",
"branch": "backport-19028-manual-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2086.7749999999887,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.213999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.7769999999999,
"heapDeltaBytes": 8513104,
"heapUsedBytes": 78745616,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.96,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2077.979999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.9570000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.725,
"heapDeltaBytes": 11445672,
"heapUsedBytes": 81787776,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.221,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2002.36799999999,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.175,
"layouts": 14,
"layoutDurationMs": 4.569,
"taskDurationMs": 1044.139,
"heapDeltaBytes": 11985432,
"heapUsedBytes": 82825600,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 190.30700000000002,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1842.712000000006,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.456000000000003,
"layouts": 14,
"layoutDurationMs": 3.995,
"taskDurationMs": 889.39,
"heapDeltaBytes": -12271856,
"heapUsedBytes": 58860408,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 161.933,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.0960000000177,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.279,
"layouts": 6,
"layoutDurationMs": 1.1239999999999999,
"taskDurationMs": 360.239,
"heapDeltaBytes": 4688576,
"heapUsedBytes": 75722112,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.576999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1681.3489999999547,
"styleRecalcs": 29,
"styleRecalcDurationMs": 15.719000000000001,
"layouts": 6,
"layoutDurationMs": 1.1099999999999999,
"taskDurationMs": 359.94300000000004,
"heapDeltaBytes": 4275972,
"heapUsedBytes": 74803264,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.61,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.5080000000085,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.573999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 468.52700000000004,
"heapDeltaBytes": 18370208,
"heapUsedBytes": 88838684,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.889,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 662.0319999999538,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.417,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.778,
"heapDeltaBytes": -7787224,
"heapUsedBytes": 63503488,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.393,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2053.059000000019,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.241999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.601,
"heapDeltaBytes": 10614508,
"heapUsedBytes": 87127960,
"domNodes": -274,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 34.785999999999994,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.1240000000198,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9380000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.5410000000002,
"heapDeltaBytes": 10154168,
"heapUsedBytes": 86640360,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.371,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2219.912000000022,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.851,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.0099999999998,
"heapDeltaBytes": 22258128,
"heapUsedBytes": 88983984,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 825.399,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2447.765000000004,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.267000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1771.203,
"heapDeltaBytes": 6496260,
"heapUsedBytes": 83669796,
"domNodes": -248,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 874.47,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3688.7800000000084,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.342999999999998,
"layouts": 60,
"layoutDurationMs": 12.225,
"taskDurationMs": 1835.3790000000001,
"heapDeltaBytes": -3251496,
"heapUsedBytes": 75825268,
"domNodes": -288,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 794.721,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3874.4630000001052,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.729999999999999,
"layouts": 60,
"layoutDurationMs": 12.896,
"taskDurationMs": 1906.6830000000002,
"heapDeltaBytes": 5366332,
"heapUsedBytes": 84488876,
"domNodes": -288,
"jsHeapTotalBytes": 3043328,
"scriptDurationMs": 827.827,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3133.9759999999615,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.903,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1981.22,
"heapDeltaBytes": 4446436,
"heapUsedBytes": 85989280,
"domNodes": -279,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 967.705,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.792000000005,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.148,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2031.4990000000003,
"heapDeltaBytes": 25594256,
"heapUsedBytes": 93133820,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1001.7449999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2056.4390000000117,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.191000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.1220000000001,
"heapDeltaBytes": 7930112,
"heapUsedBytes": 85175224,
"domNodes": -280,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 40.035000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1999.955,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.6310000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.2759999999998,
"heapDeltaBytes": 21801508,
"heapUsedBytes": 88360264,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.746999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.2629999999845,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.647,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.856,
"heapDeltaBytes": 14507776,
"heapUsedBytes": 86227696,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.77100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.2570000000333,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.241,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.663,
"heapDeltaBytes": 15050672,
"heapUsedBytes": 87913896,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 149.31699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2030.050000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.989,
"heapDeltaBytes": -7461184,
"heapUsedBytes": 65113220,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.341,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2016.2540000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.427999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.3379999999999,
"heapDeltaBytes": -14258964,
"heapUsedBytes": 58624116,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.223999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1784.1070000000059,
"styleRecalcs": 79,
"styleRecalcDurationMs": 30.785000000000004,
"layouts": 18,
"layoutDurationMs": 4.904000000000001,
"taskDurationMs": 887.554,
"heapDeltaBytes": -7602648,
"heapUsedBytes": 64991596,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 119.146,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1797.689000000105,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.717000000000002,
"layouts": 18,
"layoutDurationMs": 5.42,
"taskDurationMs": 901.299,
"heapDeltaBytes": -15197652,
"heapUsedBytes": 57143144,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 120.197,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.3150000000192,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.686000000000007,
"layouts": 15,
"layoutDurationMs": 13.336999999999998,
"taskDurationMs": 908.4110000000001,
"heapDeltaBytes": -5022008,
"heapUsedBytes": 87831308,
"domNodes": 13831,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 30.370999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8856.239000000016,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.229,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6162.689,
"heapDeltaBytes": 8804384,
"heapUsedBytes": 85333460,
"domNodes": -271,
"jsHeapTotalBytes": -172032,
"scriptDurationMs": 2796.7599999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8403.1490000001,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.652,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5956.678,
"heapDeltaBytes": 14718752,
"heapUsedBytes": 91638136,
"domNodes": -267,
"jsHeapTotalBytes": -925696,
"scriptDurationMs": 2807.701,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17056.337000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16595.985999999997,
"heapDeltaBytes": -37304920,
"heapUsedBytes": 182110636,
"domNodes": -8068,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 277.72999999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17845.081999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17129.632,
"heapDeltaBytes": -37069216,
"heapUsedBytes": 182306896,
"domNodes": -8068,
"jsHeapTotalBytes": -4468736,
"scriptDurationMs": 301.709,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21327.688000000024,
"styleRecalcs": 179,
"styleRecalcDurationMs": 17.51400000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20903.659,
"heapDeltaBytes": -33323368,
"heapUsedBytes": 179562464,
"domNodes": -8068,
"jsHeapTotalBytes": -19861504,
"scriptDurationMs": 880.3270000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 62,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22025.544999999966,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21668.619999999995,
"heapDeltaBytes": -39327068,
"heapUsedBytes": 179510832,
"domNodes": -8068,
"jsHeapTotalBytes": -11067392,
"scriptDurationMs": 927.9939999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6325.521999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.96500000000002,
"layouts": 20,
"layoutDurationMs": 23.02799999999999,
"taskDurationMs": 6140.533,
"heapDeltaBytes": -34596884,
"heapUsedBytes": 183859128,
"domNodes": -8068,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 114.863,
"eventListeners": -14929,
"totalBlockingTimeMs": 464,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6391.92700000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.87099999999998,
"layouts": 20,
"layoutDurationMs": 29.57399999999999,
"taskDurationMs": 6287.794,
"heapDeltaBytes": -41484612,
"heapUsedBytes": 177786016,
"domNodes": -8068,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 133.67800000000003,
"eventListeners": -14929,
"totalBlockingTimeMs": 562,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8730.544000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8443.722000000002,
"heapDeltaBytes": 9254440,
"heapUsedBytes": 179854844,
"domNodes": 0,
"jsHeapTotalBytes": -9175040,
"scriptDurationMs": 135.80899999999997,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9070.076999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8749.673999999999,
"heapDeltaBytes": 6598000,
"heapUsedBytes": 177518708,
"domNodes": -1,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 196.87999999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.54999999999382,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.955,
"layouts": 2,
"layoutDurationMs": 1.115,
"taskDurationMs": 77.89699999999999,
"heapDeltaBytes": 3021452,
"heapUsedBytes": 67456936,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.3809999999999985,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 483.02699999999277,
"styleRecalcs": 12,
"styleRecalcDurationMs": 20.224,
"layouts": 3,
"layoutDurationMs": 0.8299999999999997,
"taskDurationMs": 121.07199999999999,
"heapDeltaBytes": 4772380,
"heapUsedBytes": 74011180,
"domNodes": 115,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.197,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟢 Low | 1 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #19570 +/- ##
==========================================
Coverage 84.17% 84.18%
==========================================
Files 2112 2112
Lines 126487 126487
Branches 32158 32157 -1
==========================================
+ Hits 106475 106477 +2
+ Misses 19826 19824 -2
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Cherry-picks #19028 onto
core/1.54after resolving the older test mock conflict. Preserves the behavior: authenticated user ID is included in the Agent feedback form, including before a conversation session exists.