Repository navigation
[backport core/1.55] feat(agent): update consent card launch video - #18784
Conversation
## Summary Linear issue: [DES-1204](https://linear.app/comfyorg/issue/DES-1204/des-update-launch-video-file-in-the-consent-card) The Comfy Agent consent card now plays the new launch video. ## Changes - **What**: - The consent card shows the new Comfy Agent launch video. It replaces the previous video. - The new video is 45 seconds long. The previous video was 22 seconds long. - The video is on the Comfy media server, not in this repository. The card uses three files: a WebM video, an MP4 video for older iPhones, and a still image that shows before the video starts. - The card plays the video muted. For this reason, the video files have no sound track. - The card layout does not change. ## Review Focus - The three files have new names (`agent-consent-v2-*`). As a result, the new video shows only after this PR merges. No browser shows an old cached copy. - The previous video files stay on the media server. The current release continues to use them. - Each new video file is approximately 5 MB. This is approximately 2 MB more than before, because the new video is two times longer. - The browser test now expects the new MP4 file name. The Storybook preview also uses the new files. ## Screenshots (if applicable) New Video https://media.comfy.org/website/comfy-agent/agent-consent-v2-1280.mp4
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a98216aca69eceb499622ed009caa3faf2539f00
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T04:35:43.211Z",
"gitSha": "20b14ae04a6181533e8903394dc28702f94b8e9d",
"branch": "backport-18765-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.2009999999664,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.784000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.46999999999997,
"heapDeltaBytes": -8367228,
"heapUsedBytes": 59352588,
"domNodes": -256,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.696,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 1989.7409999999809,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.636999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.779,
"heapDeltaBytes": -8245280,
"heapUsedBytes": 59370736,
"domNodes": -256,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 5.663999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1706.641999999988,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.199,
"heapDeltaBytes": 10285396,
"heapUsedBytes": 77339812,
"domNodes": -254,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 92.516,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.9909999999827,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.095000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.454,
"heapDeltaBytes": -4567784,
"heapUsedBytes": 57954504,
"domNodes": -257,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 96.845,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.5619999999622,
"styleRecalcs": 28,
"styleRecalcDurationMs": 9.397,
"layouts": 6,
"layoutDurationMs": 0.8080000000000002,
"taskDurationMs": 218.785,
"heapDeltaBytes": 3104448,
"heapUsedBytes": 70964468,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.097000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.5250000000751,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.661999999999999,
"layouts": 6,
"layoutDurationMs": 0.759,
"taskDurationMs": 217.05599999999998,
"heapDeltaBytes": 2158484,
"heapUsedBytes": 64575912,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.848,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 410.3410000000167,
"styleRecalcs": 14,
"styleRecalcDurationMs": 5.755000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 269.381,
"heapDeltaBytes": 18581496,
"heapUsedBytes": 86004148,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 100.45599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 449.2960000000039,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.1789999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.285,
"heapDeltaBytes": 18968024,
"heapUsedBytes": 86570700,
"domNodes": 23,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 102.53999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 955.9319999999616,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.74,
"heapDeltaBytes": -17178188,
"heapUsedBytes": 72730060,
"domNodes": -293,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 37.61000000000001,
"eventListeners": -217,
"totalBlockingTimeMs": 336,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 968.9940000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.907,
"heapDeltaBytes": -17207632,
"heapUsedBytes": 72913684,
"domNodes": -293,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 43.944,
"eventListeners": -217,
"totalBlockingTimeMs": 343,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 699.0989999999897,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.66500000000025,
"heapDeltaBytes": 14826980,
"heapUsedBytes": 91098152,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 82.05999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 683.2819999999629,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.3479999999998,
"heapDeltaBytes": 13740164,
"heapUsedBytes": 90223376,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 77.454,
"eventListeners": 0,
"totalBlockingTimeMs": 92,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6628.785999999991,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5289999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5376.438,
"heapDeltaBytes": -10604080,
"heapUsedBytes": 71262148,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 4254.683,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6236.760000000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.1760000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5042.589000000001,
"heapDeltaBytes": 3406296,
"heapUsedBytes": 80594708,
"domNodes": -260,
"jsHeapTotalBytes": 8118272,
"scriptDurationMs": 4005.9270000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6290.655000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5208.924,
"heapDeltaBytes": 21112140,
"heapUsedBytes": 94758756,
"domNodes": -6,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 4064.342999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6421.232999999973,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.0290000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5392.276,
"heapDeltaBytes": 18254816,
"heapUsedBytes": 96822156,
"domNodes": -268,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 4270.1900000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2012.6579999999876,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.854999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.95799999999997,
"heapDeltaBytes": -3137604,
"heapUsedBytes": 82986788,
"domNodes": -240,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 17.278000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.403999999904,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.515,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.874,
"heapDeltaBytes": -3053908,
"heapUsedBytes": 84008972,
"domNodes": -236,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 18.832,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2074.23,
"styleRecalcs": 67,
"styleRecalcDurationMs": 6.989999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 966.439,
"heapDeltaBytes": 15702176,
"heapUsedBytes": 79964420,
"domNodes": -244,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 472.483,
"eventListeners": -5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2059.6160000000054,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.7349999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 899.3050000000001,
"heapDeltaBytes": 15356904,
"heapUsedBytes": 79704452,
"domNodes": -237,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 483.44200000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3104.0310000000204,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.546,
"layouts": 60,
"layoutDurationMs": 9.063999999999998,
"taskDurationMs": 1164.178,
"heapDeltaBytes": -16002096,
"heapUsedBytes": 73806000,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 486.13,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3070.968999999991,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.342,
"layouts": 60,
"layoutDurationMs": 8.434000000000001,
"taskDurationMs": 1037.569,
"heapDeltaBytes": 6881616,
"heapUsedBytes": 75138720,
"domNodes": 10,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 458.19999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2104.648999999995,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1058.8130000000003,
"heapDeltaBytes": 17693460,
"heapUsedBytes": 83503448,
"domNodes": 12,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 548.796,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2104.665999999952,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.9910000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1134.16,
"heapDeltaBytes": 17752960,
"heapUsedBytes": 87866160,
"domNodes": 10,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 542.149,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.4980000000319,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 337.261,
"heapDeltaBytes": -9718720,
"heapUsedBytes": 78824756,
"domNodes": -242,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 17.244999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.2069999999467,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.449999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.176,
"heapDeltaBytes": -6688960,
"heapUsedBytes": 82583968,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 19.474000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 399.19899999995323,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 235.76399999999998,
"heapDeltaBytes": 13402612,
"heapUsedBytes": 83502836,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 89.54899999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 395.01400000006015,
"styleRecalcs": 50,
"styleRecalcDurationMs": 7.787999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 236.207,
"heapDeltaBytes": 13434576,
"heapUsedBytes": 83501608,
"domNodes": 25,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 86.336,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.4390000000376,
"styleRecalcs": 13,
"styleRecalcDurationMs": 6.240000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.983,
"heapDeltaBytes": -5574292,
"heapUsedBytes": 64285236,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.995999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.0140000000165,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.044,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.704,
"heapDeltaBytes": -3259688,
"heapUsedBytes": 59974528,
"domNodes": -275,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 4.918000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1672.0579999999927,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.885999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.316,
"heapDeltaBytes": -7626704,
"heapUsedBytes": 62189600,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 62.945,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.7709999999834,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.457,
"heapDeltaBytes": -9066040,
"heapUsedBytes": 60884020,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 57.06,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.7049999999604,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.761,
"layouts": 5,
"layoutDurationMs": 7.3950000000000005,
"taskDurationMs": 561.337,
"heapDeltaBytes": 20267436,
"heapUsedBytes": 103708300,
"domNodes": 13667,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 16.167999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 86,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8136.084000000039,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.105999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3701.729,
"heapDeltaBytes": -14085980,
"heapUsedBytes": 66458788,
"domNodes": -211,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 1682.224,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8103.366000000051,
"styleRecalcs": 251,
"styleRecalcDurationMs": 21.509999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3477.022,
"heapDeltaBytes": -3996840,
"heapUsedBytes": 77189004,
"domNodes": -208,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 1575.165,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9782.196,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8883.855000000001,
"heapDeltaBytes": -78831952,
"heapUsedBytes": 168501256,
"domNodes": -8066,
"jsHeapTotalBytes": -22347776,
"scriptDurationMs": 129.35399999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 8687.365999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8187.371000000001,
"heapDeltaBytes": -52639316,
"heapUsedBytes": 172944172,
"domNodes": -8062,
"jsHeapTotalBytes": -16785408,
"scriptDurationMs": 80.632,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 9796.528999999964,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.509999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9056.388,
"heapDeltaBytes": -15138840,
"heapUsedBytes": 199619448,
"domNodes": -8062,
"jsHeapTotalBytes": -6168576,
"scriptDurationMs": 539.19,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 11596.148999999969,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.169999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10776.771,
"heapDeltaBytes": -58095924,
"heapUsedBytes": 166704420,
"domNodes": -8062,
"jsHeapTotalBytes": -22552576,
"scriptDurationMs": 556.559,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3309.89900000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.63100000000001,
"layouts": 20,
"layoutDurationMs": 16.173,
"taskDurationMs": 3156.3719999999994,
"heapDeltaBytes": -48498584,
"heapUsedBytes": 192504576,
"domNodes": -8062,
"jsHeapTotalBytes": 7401472,
"scriptDurationMs": 43.568999999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3292.7379999999857,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.927,
"layouts": 20,
"layoutDurationMs": 17.301,
"taskDurationMs": 3163.437,
"heapDeltaBytes": -27040148,
"heapUsedBytes": 198560200,
"domNodes": -8066,
"jsHeapTotalBytes": 18079744,
"scriptDurationMs": 43.714000000000006,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4641.957000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4322.365,
"heapDeltaBytes": 120644,
"heapUsedBytes": 183114592,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 49.41600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4581.00300000001,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.10000000000001674,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4236.482000000001,
"heapDeltaBytes": 21752812,
"heapUsedBytes": 197420560,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 44.049999999999976,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 421.50500000002467,
"styleRecalcs": 15,
"styleRecalcDurationMs": 12.058000000000002,
"layouts": 3,
"layoutDurationMs": 0.7340000000000001,
"taskDurationMs": 77.95200000000001,
"heapDeltaBytes": 4995064,
"heapUsedBytes": 70849244,
"domNodes": 126,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.904999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 77.78299999995397,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.980000000000002,
"layouts": 2,
"layoutDurationMs": 1.099,
"taskDurationMs": 48.315999999999995,
"heapDeltaBytes": 2982196,
"heapUsedBytes": 68496988,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.578999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18784 +/- ##
=============================================
- Coverage 84.59% 84.58% -0.01%
=============================================
Files 2294 2294
Lines 131267 131267
Branches 35426 33535 -1891
=============================================
- Hits 111044 111035 -9
- Misses 19923 19932 +9
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified rather than rubber-stamped: the changed-file list matches the original PR exactly, and the diff contains no conflict markers. Required checks on this branch are lint-and-format, test and e2e-status; any other red check here is advisory and does not gate the merge.
Backport of #18765 to
core/1.55Automatically created by backport workflow.