Repository navigation
[backport core/1.55] FE-2891 fix(flags): guard the dev-override storage read - #18761
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a98216aca69eceb499622ed009caa3faf2539f00
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T01:54:43.934Z",
"gitSha": "8ec2aeb2dcb683be91643e721dbd6f700fdedabb",
"branch": "backport-18744-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.700999999964,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.418000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.42600000000004,
"heapDeltaBytes": 9935296,
"heapUsedBytes": 77325664,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.469,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2000.391000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.0849999999999,
"heapDeltaBytes": -8339640,
"heapUsedBytes": 59211976,
"domNodes": -262,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.295000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.9410000000012,
"styleRecalcs": 47,
"styleRecalcDurationMs": 15.120999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.171,
"heapDeltaBytes": -6801116,
"heapUsedBytes": 61117288,
"domNodes": -258,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 154.01500000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.0230000000174,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.338,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.648,
"heapDeltaBytes": -1833292,
"heapUsedBytes": 60593864,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 162.736,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.09399999997,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.610000000000001,
"layouts": 6,
"layoutDurationMs": 0.952,
"taskDurationMs": 317.255,
"heapDeltaBytes": 3071388,
"heapUsedBytes": 70836152,
"domNodes": 78,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.451999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1691.7839999999842,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.645999999999999,
"layouts": 6,
"layoutDurationMs": 0.889,
"taskDurationMs": 317.99300000000005,
"heapDeltaBytes": 2819368,
"heapUsedBytes": 69592112,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.165,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 625.6999999999948,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.93,
"heapDeltaBytes": 18923728,
"heapUsedBytes": 86480540,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 163.688,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 643.1430000000091,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.61,
"heapDeltaBytes": 18604600,
"heapUsedBytes": 86500612,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.662,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.8380000000147,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.619,
"heapDeltaBytes": 12745784,
"heapUsedBytes": 102966896,
"domNodes": -294,
"jsHeapTotalBytes": 24006656,
"scriptDurationMs": 62.635999999999996,
"eventListeners": -195,
"totalBlockingTimeMs": 605,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.5439999999217,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 831.3199999999999,
"heapDeltaBytes": 38470568,
"heapUsedBytes": 107859908,
"domNodes": 0,
"jsHeapTotalBytes": 17985536,
"scriptDurationMs": 72.45899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 566,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.0630000000483,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.37399999999974,
"heapDeltaBytes": 14714716,
"heapUsedBytes": 93913472,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 167.027,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.5630000000128,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.5859999999995,
"heapDeltaBytes": 15122776,
"heapUsedBytes": 91640548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 172.10199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10459.35800000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9535.449,
"heapDeltaBytes": 17249792,
"heapUsedBytes": 93266516,
"domNodes": -8,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7924.33,
"eventListeners": 0,
"totalBlockingTimeMs": 1162,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10057.226000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9180.182999999999,
"heapDeltaBytes": 11715844,
"heapUsedBytes": 94352244,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7647.662,
"eventListeners": 0,
"totalBlockingTimeMs": 891,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9716.590999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8897.844000000001,
"heapDeltaBytes": -13650528,
"heapUsedBytes": 68279276,
"domNodes": -14,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7395.92,
"eventListeners": 0,
"totalBlockingTimeMs": 899,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10558.874999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9717.85,
"heapDeltaBytes": 1933268,
"heapUsedBytes": 84157844,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8116.706000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 1216,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2033.9570000000435,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.858000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.855,
"heapDeltaBytes": -3434908,
"heapUsedBytes": 83263992,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.824,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2037.7569999999423,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.340000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.409,
"heapDeltaBytes": -2951016,
"heapUsedBytes": 83681200,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 28.311000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2227.5359999999864,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.643999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1599.729,
"heapDeltaBytes": 15676600,
"heapUsedBytes": 80311076,
"domNodes": -243,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 846.491,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2206.8249999999807,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.688999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1588.1790000000003,
"heapDeltaBytes": -7091948,
"heapUsedBytes": 80582256,
"domNodes": -246,
"jsHeapTotalBytes": 1564672,
"scriptDurationMs": 832.435,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3437.6700000000255,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.326999999999996,
"layouts": 60,
"layoutDurationMs": 12.382000000000001,
"taskDurationMs": 1451.728,
"heapDeltaBytes": 8192160,
"heapUsedBytes": 74218280,
"domNodes": -7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.119,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3521.9899999999598,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.381000000000004,
"layouts": 60,
"layoutDurationMs": 12.234,
"taskDurationMs": 1659.6760000000002,
"heapDeltaBytes": -15754544,
"heapUsedBytes": 73413840,
"domNodes": -258,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 766.37,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3091.887999999983,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.796,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1907.447,
"heapDeltaBytes": 26774056,
"heapUsedBytes": 92824448,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1011.4450000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2930.2240000000666,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.181999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1856.0250000000003,
"heapDeltaBytes": 21439412,
"heapUsedBytes": 87868476,
"domNodes": -250,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 971.8609999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.8829999999894,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.092999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.4140000000001,
"heapDeltaBytes": -6600292,
"heapUsedBytes": 82406216,
"domNodes": -244,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 28.043,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2020.5249999999069,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.962999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.594,
"heapDeltaBytes": -4619100,
"heapUsedBytes": 84231576,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.550999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.7039999999874,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.139,
"heapDeltaBytes": 13640176,
"heapUsedBytes": 83604744,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.17499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.1990000001015,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.302,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.38899999999995,
"heapDeltaBytes": 14148520,
"heapUsedBytes": 83591988,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.166,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.153000000003,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.674000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.00600000000003,
"heapDeltaBytes": -14637680,
"heapUsedBytes": 55150936,
"domNodes": -274,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.825999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1990.5499999999847,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.00100000000003,
"heapDeltaBytes": 11861260,
"heapUsedBytes": 81548880,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.105999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2739999999976,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.159999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.117,
"heapDeltaBytes": -9286876,
"heapUsedBytes": 59807100,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 99.58600000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0140000000247,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.719,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 704.99,
"heapDeltaBytes": -2295008,
"heapUsedBytes": 67629876,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 100.586,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.082000000035,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.497999999999994,
"layouts": 5,
"layoutDurationMs": 12.689000000000002,
"taskDurationMs": 861.796,
"heapDeltaBytes": -6411768,
"heapUsedBytes": 86737200,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 29.459,
"eventListeners": 2383,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8252.684000000045,
"styleRecalcs": 252,
"styleRecalcDurationMs": 36.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4954.067,
"heapDeltaBytes": -18144652,
"heapUsedBytes": 68193940,
"domNodes": -235,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 2741.862,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8273.528000000057,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.431000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5510.862999999999,
"heapDeltaBytes": 12640980,
"heapUsedBytes": 76505660,
"domNodes": -243,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 2698.277,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15911.680000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14974.688,
"heapDeltaBytes": -37025156,
"heapUsedBytes": 177253188,
"domNodes": -8061,
"jsHeapTotalBytes": -11284480,
"scriptDurationMs": 250.89499999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 15731.948999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14927.477999999997,
"heapDeltaBytes": -59850080,
"heapUsedBytes": 180776424,
"domNodes": -8061,
"jsHeapTotalBytes": -14311424,
"scriptDurationMs": 224.18899999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20221.997999999985,
"styleRecalcs": 169,
"styleRecalcDurationMs": 15.964000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19791.889,
"heapDeltaBytes": -71996976,
"heapUsedBytes": 169201160,
"domNodes": -8061,
"jsHeapTotalBytes": -15929344,
"scriptDurationMs": 901.224,
"eventListeners": -14928,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19843.694999999912,
"styleRecalcs": 168,
"styleRecalcDurationMs": 15.80799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19489.655,
"heapDeltaBytes": -58777336,
"heapUsedBytes": 169166656,
"domNodes": -8061,
"jsHeapTotalBytes": -20385792,
"scriptDurationMs": 854.544,
"eventListeners": -14928,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5812.46699999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 96.01599999999999,
"layouts": 20,
"layoutDurationMs": 27.142,
"taskDurationMs": 5704.46,
"heapDeltaBytes": -31607204,
"heapUsedBytes": 189935640,
"domNodes": -8062,
"jsHeapTotalBytes": 10416128,
"scriptDurationMs": 97.43599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 433,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5743.159999999989,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.422,
"layouts": 20,
"layoutDurationMs": 22.116999999999997,
"taskDurationMs": 5634.427000000001,
"heapDeltaBytes": -36612940,
"heapUsedBytes": 181534748,
"domNodes": -8061,
"jsHeapTotalBytes": 13094912,
"scriptDurationMs": 98.162,
"eventListeners": -14928,
"totalBlockingTimeMs": 414,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6060.83000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5470.262999999999,
"heapDeltaBytes": -14139752,
"heapUsedBytes": 183214368,
"domNodes": -1,
"jsHeapTotalBytes": -29097984,
"scriptDurationMs": 92.29800000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7996.345000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7616.092,
"heapDeltaBytes": 3206708,
"heapUsedBytes": 190395068,
"domNodes": 0,
"jsHeapTotalBytes": -26476544,
"scriptDurationMs": 134.468,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 131.91600000004655,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.900999999999996,
"layouts": 3,
"layoutDurationMs": 1.6150000000000002,
"taskDurationMs": 101.99899999999998,
"heapDeltaBytes": 3264276,
"heapUsedBytes": 68832892,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.368,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 458.19799999992483,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.642,
"layouts": 3,
"layoutDurationMs": 0.935,
"taskDurationMs": 107.451,
"heapDeltaBytes": 4911052,
"heapUsedBytes": 70662280,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.509,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18761 +/- ##
=============================================
+ Coverage 83.65% 84.58% +0.93%
=============================================
Files 3019 2294 -725
Lines 148883 131269 -17614
Branches 40342 33546 -6796
=============================================
- Hits 124553 111040 -13513
+ Misses 23027 19929 -3098
+ Partials 1303 300 -1003
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 734 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against the original PR. One difference, checked and benign: src/composables/useFeatureFlags.ts is in #18744 but not in this cherry-pick. That hunk is a two-line comment and no code — the actual override guard lives in devFeatureFlagOverride.ts, which carried in full. Functionally complete.
Required checks on this branch are lint-and-format, test and e2e-status; any other red check is advisory.
Backport of #18744 to
core/1.55, done by hand because the automatic backport hit a conflict insrc/composables/useFeatureFlags.ts.Why
getDevOverridereadlocalStorageoutside itstry. In a dev build with blocked or partitioned storage, theSecurityErrorescaped into every flag getter that reads a dev override. Production builds are unaffected: the function returns early on!import.meta.env.DEV.Root cause
In dev builds, only
JSON.parsewas guarded; the storage read before it was not.How
src/utils/devFeatureFlagOverride.tsand its regression test, cherry-picked from FE-2891 fix(flags): guard the dev-override storage read and note the override bypass #18744.unifiedWebSessionEnabled. That getter comes from FE-2891 feat(flags): unified_web_session client flag, off by default #18708, which is not oncore/1.55, and it caused the automatic backport's conflict.AS IS / TO BE
No UI; the evidence is the test.
localStorage.getItempropagates out ofgetDevOverridein a dev build.undefined.pnpm exec vitest run src/utils/devFeatureFlagOverride.test.ts→ 9 passed.