Repository navigation
[backport cloud/1.55] FE-2891 fix(flags): guard the dev-override storage read - #18762
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 63632c70b94deada6e78dbb85a52991c313b979f
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T01:55:24.803Z",
"gitSha": "4cc350270511912da5e41dc8eaa1dc32229755b8",
"branch": "backport-18744-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.9220000000269,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.496,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.051,
"heapDeltaBytes": -7232036,
"heapUsedBytes": 60056872,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 12.045,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2038.118000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.359999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.1160000000001,
"heapDeltaBytes": 10636784,
"heapUsedBytes": 78182576,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 13.455000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1749.872000000039,
"styleRecalcs": 46,
"styleRecalcDurationMs": 16.564,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.92,
"heapDeltaBytes": 13007504,
"heapUsedBytes": 80527048,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 171.397,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.600000000025,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 880.376,
"heapDeltaBytes": -8744724,
"heapUsedBytes": 59091604,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 174.679,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.9119999999944,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.807,
"layouts": 6,
"layoutDurationMs": 1.355,
"taskDurationMs": 392.308,
"heapDeltaBytes": 3153948,
"heapUsedBytes": 70756256,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.612999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.9289999999392,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.283000000000001,
"layouts": 6,
"layoutDurationMs": 1.152,
"taskDurationMs": 362.89400000000006,
"heapDeltaBytes": 3089876,
"heapUsedBytes": 70711724,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.899999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 705.1529999999957,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.108,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.21899999999994,
"heapDeltaBytes": 18600936,
"heapUsedBytes": 86467484,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 172.65800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.6910000000871,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.718000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.857,
"heapDeltaBytes": 18804224,
"heapUsedBytes": 86529028,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 175.196,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1241.9950000000313,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 929.8400000000001,
"heapDeltaBytes": 38242352,
"heapUsedBytes": 108217628,
"domNodes": 0,
"jsHeapTotalBytes": 19034112,
"scriptDurationMs": 79.842,
"eventListeners": 0,
"totalBlockingTimeMs": 618,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1218.6679999999797,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 923.5300000000001,
"heapDeltaBytes": 35669336,
"heapUsedBytes": 102789276,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 76.652,
"eventListeners": 0,
"totalBlockingTimeMs": 606,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 875.1169999999888,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.0680000000001,
"heapDeltaBytes": 14908500,
"heapUsedBytes": 90097820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.63099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.7459999999392,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.91,
"heapDeltaBytes": 14605664,
"heapUsedBytes": 89582336,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.70200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11703.705000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10714.706,
"heapDeltaBytes": -12781156,
"heapUsedBytes": 69505612,
"domNodes": -14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8821.707,
"eventListeners": 0,
"totalBlockingTimeMs": 1679,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11169.91399999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10241.045,
"heapDeltaBytes": -13224088,
"heapUsedBytes": 69118156,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8452.661999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 1453,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11390.233000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10501.595,
"heapDeltaBytes": 2475084,
"heapUsedBytes": 84227804,
"domNodes": -12,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8677.852,
"eventListeners": 0,
"totalBlockingTimeMs": 1431,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10843.046999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9972.538999999999,
"heapDeltaBytes": -10475092,
"heapUsedBytes": 71413296,
"domNodes": -12,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8172.185,
"eventListeners": 0,
"totalBlockingTimeMs": 1282,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2020.808000000045,
"styleRecalcs": 9,
"styleRecalcDurationMs": 12.684000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 689.459,
"heapDeltaBytes": -3563096,
"heapUsedBytes": 83094096,
"domNodes": -240,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 37.56799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2018.8530000000355,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.7860000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.2270000000001,
"heapDeltaBytes": -3505836,
"heapUsedBytes": 83247764,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.191,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2610.80800000002,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.495999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1788.3389999999997,
"heapDeltaBytes": 20222428,
"heapUsedBytes": 84366788,
"domNodes": -244,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 900.7570000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2455.282000000011,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1722.655,
"heapDeltaBytes": 20706796,
"heapUsedBytes": 84819168,
"domNodes": -245,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 893.556,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3662.2489999999743,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.031,
"layouts": 60,
"layoutDurationMs": 14.309000000000003,
"taskDurationMs": 1808.97,
"heapDeltaBytes": 8736796,
"heapUsedBytes": 74823596,
"domNodes": -5,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 830.684,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3607.221999999979,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.779999999999998,
"layouts": 60,
"layoutDurationMs": 13.908,
"taskDurationMs": 1676.593,
"heapDeltaBytes": -14631848,
"heapUsedBytes": 74605624,
"domNodes": -253,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 836.347,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3154.627000000005,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.089999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2048.2599999999998,
"heapDeltaBytes": 20959156,
"heapUsedBytes": 87045592,
"domNodes": -7,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1039.172,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3145.9670000000415,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.4959999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.549,
"heapDeltaBytes": 17535408,
"heapUsedBytes": 83373488,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.7589999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2001.3950000000023,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.8459999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.5269999999999,
"heapDeltaBytes": 20185372,
"heapUsedBytes": 84682024,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 45.10600000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2003.6910000000034,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.420999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.98,
"heapDeltaBytes": 19404784,
"heapUsedBytes": 83777240,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.40099999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 629.9580000000446,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.207,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.82300000000004,
"heapDeltaBytes": 14086176,
"heapUsedBytes": 82970604,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 149.29899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.3900000000331,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.4680000000001,
"heapDeltaBytes": 14055896,
"heapUsedBytes": 83600968,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 149.39,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.294999999995,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.722000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.61,
"heapDeltaBytes": 8391744,
"heapUsedBytes": 78139288,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.775,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2014.5659999999452,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.03,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 551.079,
"heapDeltaBytes": -13129944,
"heapUsedBytes": 56873868,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.879,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.147999999961,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.061000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.4339999999999,
"heapDeltaBytes": -7741384,
"heapUsedBytes": 62203320,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 117.66099999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.5460000000085,
"styleRecalcs": 47,
"styleRecalcDurationMs": 18.862,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.4599999999999,
"heapDeltaBytes": 6917904,
"heapUsedBytes": 76180908,
"domNodes": -273,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 119.94200000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.609999999907,
"styleRecalcs": 17,
"styleRecalcDurationMs": 30.456999999999997,
"layouts": 5,
"layoutDurationMs": 14.432000000000004,
"taskDurationMs": 1006.5519999999999,
"heapDeltaBytes": 20257204,
"heapUsedBytes": 103955244,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 35.68,
"eventListeners": 2383,
"totalBlockingTimeMs": 153,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8714.793999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6160.895,
"heapDeltaBytes": -1949236,
"heapUsedBytes": 84788936,
"domNodes": -245,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2870.701,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8658.843000000048,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.57000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6002.009999999999,
"heapDeltaBytes": -9883968,
"heapUsedBytes": 76512068,
"domNodes": -244,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2866.491,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17419.826999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17099.961,
"heapDeltaBytes": -62626028,
"heapUsedBytes": 177676788,
"domNodes": -8061,
"jsHeapTotalBytes": -17195008,
"scriptDurationMs": 276.04300000000006,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17444.488000000092,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17061.761000000002,
"heapDeltaBytes": -73381060,
"heapUsedBytes": 167762576,
"domNodes": -8061,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 283.351,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16172.289000000035,
"styleRecalcs": 90,
"styleRecalcDurationMs": 14.877000000000029,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15877.001999999997,
"heapDeltaBytes": -67264280,
"heapUsedBytes": 168116208,
"domNodes": -8061,
"jsHeapTotalBytes": -21147648,
"scriptDurationMs": 1002.1739999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20938.58499999999,
"styleRecalcs": 152,
"styleRecalcDurationMs": 19.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20834.322,
"heapDeltaBytes": -22829940,
"heapUsedBytes": 191812692,
"domNodes": -8065,
"jsHeapTotalBytes": -13246464,
"scriptDurationMs": 901.775,
"eventListeners": -14928,
"totalBlockingTimeMs": 179,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6298.381000000063,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.179,
"layouts": 20,
"layoutDurationMs": 25.151999999999994,
"taskDurationMs": 6251.304999999999,
"heapDeltaBytes": -54599396,
"heapUsedBytes": 187186524,
"domNodes": -8061,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 112.35100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 476,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6345.826999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.70699999999998,
"layouts": 20,
"layoutDurationMs": 25.141999999999996,
"taskDurationMs": 6296.857,
"heapDeltaBytes": -42411116,
"heapUsedBytes": 176588304,
"domNodes": -8061,
"jsHeapTotalBytes": 7856128,
"scriptDurationMs": 163.74999999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 474,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8631.528000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8531.516,
"heapDeltaBytes": 19734492,
"heapUsedBytes": 174023308,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 143.17099999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8730.058999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8468.253,
"heapDeltaBytes": 1443900,
"heapUsedBytes": 193475896,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 133.243,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 141.5079999999307,
"styleRecalcs": 11,
"styleRecalcDurationMs": 23.81,
"layouts": 6,
"layoutDurationMs": 3.2230000000000003,
"taskDurationMs": 121.55300000000003,
"heapDeltaBytes": 3359128,
"heapUsedBytes": 68769016,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.52,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.0750000000562,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.606999999999996,
"layouts": 3,
"layoutDurationMs": 1.383,
"taskDurationMs": 79.25400000000002,
"heapDeltaBytes": 3029852,
"heapUsedBytes": 68986460,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.153,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #18762 +/- ##
=============================================
Coverage ? 84.58%
=============================================
Files ? 2294
Lines ? 131273
Branches ? 33547
=============================================
Hits ? 111041
Misses ? 19932
Partials ? 300
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Verified against the original PR. One difference, checked and benign: src/composables/useFeatureFlags.ts is in #18744 but not in this cherry-pick. That hunk is a two-line comment and no code — the actual override guard lives in devFeatureFlagOverride.ts, which carried in full. Functionally complete.
Required checks on this branch are lint-and-format, test and e2e-status; any other red check is advisory.
Backport of #18744 to
cloud/1.55, done by hand because the automatic backport hit a conflict insrc/composables/useFeatureFlags.ts.Why
getDevOverridereadlocalStorageoutside itstry. In a dev build with blocked or partitioned storage, theSecurityErrorescaped into every flag getter that reads a dev override. Production builds are unaffected: the function returns early on!import.meta.env.DEV.Root cause
In dev builds, only
JSON.parsewas guarded; the storage read before it was not.How
src/utils/devFeatureFlagOverride.tsand its regression test, cherry-picked from FE-2891 fix(flags): guard the dev-override storage read and note the override bypass #18744.unifiedWebSessionEnabled. That getter comes from FE-2891 feat(flags): unified_web_session client flag, off by default #18708, which is not oncloud/1.55, and it caused the automatic backport's conflict.AS IS / TO BE
No UI; the evidence is the test.
localStorage.getItempropagates out ofgetDevOverridein a dev build.undefined.pnpm exec vitest run src/utils/devFeatureFlagOverride.test.ts→ 9 passed.