Repository navigation
[backport cloud/1.54] fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) - #18385
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1934 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T06:15:29.336Z",
"gitSha": "1d77cfbb1ca8ee6ce6dc1755056d71ce694d7536",
"branch": "backport-18278-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.499999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.857999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.607,
"heapDeltaBytes": 9400632,
"heapUsedBytes": 79207388,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.729000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2055.1940000000286,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.556,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.1550000000001,
"heapDeltaBytes": -4025020,
"heapUsedBytes": 64998488,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.292000000000002,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2102.1769999999833,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.145,
"layouts": 14,
"layoutDurationMs": 6.252,
"taskDurationMs": 1057.1779999999999,
"heapDeltaBytes": 11494332,
"heapUsedBytes": 81545496,
"domNodes": -283,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 187.415,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.033000000025,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.084,
"layouts": 14,
"layoutDurationMs": 4.433000000000001,
"taskDurationMs": 903.3339999999998,
"heapDeltaBytes": -13189728,
"heapUsedBytes": 57378268,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 164.979,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.8270000000057,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.83,
"layouts": 6,
"layoutDurationMs": 1.2239999999999998,
"taskDurationMs": 369.28099999999995,
"heapDeltaBytes": 3335948,
"heapUsedBytes": 67727512,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.193000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1679.2760000000726,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.168000000000003,
"layouts": 6,
"layoutDurationMs": 1.175,
"taskDurationMs": 348.28400000000005,
"heapDeltaBytes": 4564408,
"heapUsedBytes": 75724556,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.644,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 667.507999999998,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.009000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.65,
"heapDeltaBytes": 18442808,
"heapUsedBytes": 88835752,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 162.775,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.3629999999848,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.363,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.76099999999997,
"heapDeltaBytes": 18377408,
"heapUsedBytes": 88103860,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 164.83900000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.0679999999525,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.629999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.099,
"heapDeltaBytes": 10742076,
"heapUsedBytes": 86600912,
"domNodes": -271,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 34.694,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2033.4930000000213,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.180000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.2960000000002,
"heapDeltaBytes": 10447660,
"heapUsedBytes": 87066000,
"domNodes": -269,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 33.375,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2305.8130000000006,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.669000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1625.1230000000003,
"heapDeltaBytes": 17743128,
"heapUsedBytes": 83956196,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 826.7520000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2339.415000000031,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1684.8970000000004,
"heapDeltaBytes": 205320,
"heapUsedBytes": 76679268,
"domNodes": -250,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 850.089,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3502.962000000025,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.393000000000002,
"layouts": 60,
"layoutDurationMs": 11.685,
"taskDurationMs": 1678.801,
"heapDeltaBytes": 8176376,
"heapUsedBytes": 75420752,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 776.4499999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3596.8270000000757,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.128999999999998,
"layouts": 60,
"layoutDurationMs": 11.831,
"taskDurationMs": 1755.894,
"heapDeltaBytes": -7800204,
"heapUsedBytes": 71017052,
"domNodes": -289,
"jsHeapTotalBytes": 4087808,
"scriptDurationMs": 777.87,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3067.4769999999967,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.466000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1928.6699999999998,
"heapDeltaBytes": 22809416,
"heapUsedBytes": 90133264,
"domNodes": 2,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 953.7909999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3073.20900000002,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.701999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1938.1979999999999,
"heapDeltaBytes": 22711052,
"heapUsedBytes": 90333268,
"domNodes": -279,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 967.856,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.0530000000372,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.1000000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.6270000000002,
"heapDeltaBytes": -2278440,
"heapUsedBytes": 75289684,
"domNodes": -285,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 30.754000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2029.7150000000101,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.538,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.862,
"heapDeltaBytes": 10387880,
"heapUsedBytes": 86938044,
"domNodes": -268,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 36.86300000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.3409999999903,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.635,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.44800000000004,
"heapDeltaBytes": 14688816,
"heapUsedBytes": 87786448,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.43699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.6040000000748,
"styleRecalcs": 49,
"styleRecalcDurationMs": 11.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.29799999999994,
"heapDeltaBytes": 15076348,
"heapUsedBytes": 87880748,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.346,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2020.8170000000223,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.942000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.41,
"heapDeltaBytes": -14869072,
"heapUsedBytes": 57824476,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.139999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2033.3399999999529,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.922000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.309,
"heapDeltaBytes": -3303348,
"heapUsedBytes": 68770844,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.193999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.806000000021,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.311000000000003,
"layouts": 18,
"layoutDurationMs": 5.4590000000000005,
"taskDurationMs": 836.8310000000001,
"heapDeltaBytes": 5204688,
"heapUsedBytes": 78396692,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 113.973,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.3649999999498,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.674,
"layouts": 18,
"layoutDurationMs": 5.654,
"taskDurationMs": 829.5440000000001,
"heapDeltaBytes": -8771516,
"heapUsedBytes": 63170620,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 110.408,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3419999999996,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.403,
"layouts": 14,
"layoutDurationMs": 15.714000000000002,
"taskDurationMs": 929.9809999999998,
"heapDeltaBytes": -5273964,
"heapUsedBytes": 84596528,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.643000000000004,
"eventListeners": 2385,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8653.593,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.07299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5903.608,
"heapDeltaBytes": 1668092,
"heapUsedBytes": 77025292,
"domNodes": -243,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 2756.678,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8548.666000000027,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.802,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5805.777000000001,
"heapDeltaBytes": 7048840,
"heapUsedBytes": 82597048,
"domNodes": -242,
"jsHeapTotalBytes": 1953792,
"scriptDurationMs": 2670.317,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17340.309999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16772.764,
"heapDeltaBytes": -45496492,
"heapUsedBytes": 177867756,
"domNodes": -8068,
"jsHeapTotalBytes": -14688256,
"scriptDurationMs": 292.20900000000006,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17039.06500000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16548.424,
"heapDeltaBytes": -38314384,
"heapUsedBytes": 178402488,
"domNodes": -8068,
"jsHeapTotalBytes": -10235904,
"scriptDurationMs": 265.733,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21021.929999999997,
"styleRecalcs": 169,
"styleRecalcDurationMs": 18.433000000000032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20732.557,
"heapDeltaBytes": -46977968,
"heapUsedBytes": 178617756,
"domNodes": -8068,
"jsHeapTotalBytes": -18571264,
"scriptDurationMs": 944.4200000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 56,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21290.697000000022,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.946999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20885.280000000002,
"heapDeltaBytes": -25521032,
"heapUsedBytes": 192544140,
"domNodes": -8068,
"jsHeapTotalBytes": -11083776,
"scriptDurationMs": 910.3149999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 137,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6332.8089999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 101.61999999999999,
"layouts": 20,
"layoutDurationMs": 35.322,
"taskDurationMs": 6223.7390000000005,
"heapDeltaBytes": -57720460,
"heapUsedBytes": 174372376,
"domNodes": -8068,
"jsHeapTotalBytes": -1863680,
"scriptDurationMs": 135.12800000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 449,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6303.986000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 92.83600000000003,
"layouts": 20,
"layoutDurationMs": 23.03100000000001,
"taskDurationMs": 6206.732000000001,
"heapDeltaBytes": -63109696,
"heapUsedBytes": 175447596,
"domNodes": -8068,
"jsHeapTotalBytes": 2482176,
"scriptDurationMs": 142.93699999999998,
"eventListeners": -14927,
"totalBlockingTimeMs": 401,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9120.226999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8616.041000000001,
"heapDeltaBytes": 6371832,
"heapUsedBytes": 178736016,
"domNodes": 0,
"jsHeapTotalBytes": -10485760,
"scriptDurationMs": 141.2429999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8662.755000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8403.724000000002,
"heapDeltaBytes": 3190588,
"heapUsedBytes": 176814128,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 178.49899999999997,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 101.78700000005847,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.783000000000001,
"layouts": 2,
"layoutDurationMs": 0.5569999999999999,
"taskDurationMs": 70.06,
"heapDeltaBytes": 3114472,
"heapUsedBytes": 72226340,
"domNodes": 110,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.359999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 450.219000000061,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.546,
"layouts": 3,
"layoutDurationMs": 0.8599999999999999,
"taskDurationMs": 99.728,
"heapDeltaBytes": 4761788,
"heapUsedBytes": 73544932,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.689,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
christian-byrne
left a comment
There was a problem hiding this comment.
Hand-port matches the source contract at 2785b7f; no blocking code finding.
Merge remains gated on terminal exact-head CI and target-native acceptance.
Full context for agent readers
Reviewed the complete five-file diff against source merge be12830ba0b4f186aa0e25ea59d0a15ca676c372 and current cloud/1.54 06068f39fd5a3d4a6199b6171e614b966c71370c.
The pre-refactor integration preserves the source invariants: only a selected tab lacking a workflow ID and session binding emits current_tab_unbound; that turn carries its draft; the accepted workflow ID prevents repeated minting; persisted tab bindings avoid re-flagging after reload; and the REST client serializes or omits the wire field correctly. The carrier is one commit atop the current target, mergeable, and has no unresolved review threads.
This is an agent-authored exact-head review, not independent human peer review. Do not merge from this approval alone: hosted checks are still running, and served acceptance still depends on a compatible deployed backend and authenticated selected-workflow verification.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18385 +/- ##
=============================================
Coverage ? 78.52%
=============================================
Files ? 2006
Lines ? 110746
Branches ? 33441
=============================================
Hits ? 86960
Misses ? 23607
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
## Summary Backports the second batch of merged `main` Agent fixes to `cloud/1.54`: the Agent paywall and admission-error handling with its follow-ups, workflow-scoped node selection, the bounded attachment upload contract, and the turn request contract without the draft version. ## Changes - **What**: `cherry-pick -x` of #16856, #18204, #17327, #18229, #16985 and #18224, in `main` merge order. Two adaptation commits: #16856's PM-1430 behavior is replayed in #18278's split form, since this line had it in the old single-function form via #18385; #16985 brings #18104's version of the Undo test. `DraftSnapshot` is `Pick<..., 'content'>` because this line's ingest types keep the draft version optional. - **Excluded**: #18251 (its lint rule needs its `src/lib/litegraph/` hunks, and its lockfile change does not apply to this line). ## Review Focus - #16856 restores the Agent paywall on this line, which is billing-facing. - `useAttachment.ts` and its test are taken whole from `main`, because #16985 asserts `reportError` on its new fetch path. - The four e2e specs this changes were not run locally; hosted e2e covers them. Linear: [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) No new visuals. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Backport of #18278 to
cloud/1.54.Why this is a hand-port, not a cherry-pick
cloud/1.54'suseAgentSession.tspredates #16856's refactor that split the monolithicsendMessageintobuildPostInput/acceptTurn/etc. onmain. A mechanical cherry-pick of #18278'sisUnboundTarget()/buildTargetFields()helpers has nothing to attach to on this branch, so the fix is re-implemented directly inside the oldsendMessage/postTurnclosure, using the same inputs (wfContext,boundWorkflowId) that are available there. This is the same approach as the sibling hand-port #18381 tocore/1.54;cloud/1.54'suseAgentSession.ts/agentRestClient.ts/their tests andAgentPanelRoot.vue/AgentPanelRoot.test.tswere byte-identical tocore/1.54's pre-port versions, so #18381's diff ported over directly.The bug
A brand-new, never-saved tab plus a brand-new chat session sends a turn with neither
workflow_idnor any signal that a tab was selected at all — indistinguishable, server-side, from no tab being selected. The agent then refuses to edit: "I can't because you don't have a workflow selected to edit," even though the panel shows the tab as bound.The port
postTurn(nested insendMessage), computeunboundTarget = wfContext !== undefined && wfContext.id === undefined && boundWorkflowId.value === null— the same condition fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) #18278'sisUnboundTarget()expresses, evaluated with the old shape's own capturedwfContextand the session'sboundWorkflowIdref.unboundTargetis true, addcurrentTabUnbound: trueto the outboundinput, and extendshouldSendDraftso the draft rides along even past a thread's literal first ("new") turn — otherwise the server's mint of a workflow for this tab would start from an empty canvas.agentRestClient.ts: addedPostMessageInput.currentTabUnboundand serialize it ascurrent_tab_unboundon the wire, mirroring fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) #18278.packages/ingest-typesoncloud/1.54already generatescurrent_tab_unboundonAgentPostMessageRequest(unlikecore/1.54, where cloud#10068 hasn't landed in the generated types yet). But this branch'spostMessagepredates the refactor and already types its outboundbodyas a plainRecord<string, unknown>, not the generatedAgentPostMessageRequest, so there's nothing to shim around either way — the field is just another key on that loosely-typed body.core/1.54's:AgentPanelRoot.test.ts: fresh unsaved tab + fresh chat is flagged unbound; an unbound tab on a restored thread is flagged and keeps its draft; a workflow bound before reload resolves from persistedlocalStoragebinding storage without re-flagging.useAgentSession.test.ts: an unbound target on an existing thread is flagged and keeps its draft; a second turn on a still-unbound tab does not re-flag it.agentRestClient.test.ts:currentTabUnboundserializes tocurrent_tab_unbound; it's omitted when not provided.Testing
pnpm exec vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts src/workbench/extensions/agent/services/agent/agentRestClient.test.ts: 322 passed, 2 expected-fail, 3 pre-existing/unrelated failures (verified identical on a cleancloud/1.54checkout before this change — an attach-flow content/attachments assertion and an uploading-chip test that throws on aBlob.streampolyfill gap, unrelated to this change)pnpm exec oxlint/pnpm exec oxfmt --checkon the changed files: cleanpnpm typecheck: cleanDeviations
Same caveat as #18278/#18381:
current_tab_unboundis merged to cloud'smain(cloud#10068), but not yet deployed to production — no production release PR has been opened yet — so this PR cannot fully close the loop (the agent actually acting instead of refusing) until that server-side change ships to prod.🤖 Generated with Claude Code
https://claude.ai/code/session_01JJ6wnHBJsZs88S22MCKGLT
Generated by Claude Code