Repository navigation
[backport cloud/1.54] Agent fixes catch-up 2b (PM-1656) - #18641
Conversation
…#16856) Ports the completed agent admission-error and paywall UI work onto current `main` from the closed slice successor sources. Includes permanent tests and Storybook coverage for admission errors, capability-driven actions, responsive layout, and billing-policy presentation. Carrier: [FE-2005](https://linear.app/comfy-org/issue/FE-2005) Fixes [FE-1706](https://linear.app/comfy-org/issue/FE-1706) (paywall handling in the agent panel) Fixes [PM-518](https://linear.app/comfy-org/issue/PM-518) (admission errors surfaced to the user) Verification: - Focused Vitest: 7 files, 246 tests passed - Pre-commit formatting, lint, and full typecheck passed - Pre-push Knip passed Backport note (cloud/1.54): - Main's end state (mechanical): AgentPanelRoot.vue imports both RootGraphId and isCloud, and its paywall block is main's combination of this change with #18405. AgentPanelRoot.test.ts takes the hasResolvedCapabilities stub and keeps #18405's paywall-dismissal test after this change's Subscribe test. - This line's side kept (test-only): AgentPanelRoot.test.ts's LGraph type import and useCurrentUser factory mock. Main's factory-less mock relies on a __mocks__ file this line does not have. - Not taken: __mocks__/useBillingCapabilities.ts, main's shared mock from #17726, which nothing here uses; and agentPanel.spec.ts's diagnostic report tests, from #17773. Only this change's admission test is added. - useAgentSession.ts takes this change's split of sendMessage, which drops this line's unbound-tab rule (PM-1430). The next commit restores it as main has it (#18278), labelled runtime. (cherry picked from commit 058efef)
…16856 Backport resolution (runtime) for #16856 on cloud/1.54. #16856 splits sendMessage into helpers, and its version of the send path predates the unbound-tab rule (PM-1430) that this line already carries through #18385. main added the rule to the split helpers in #18278. Replay #18278's useAgentSession.ts change as main has it: isUnboundTarget, buildTargetFields, and the unboundTarget case in canSendDraft.
## Summary Addresses three review threads that were still open when [#16856](#16856) merged, all mechanical and behavior-preserving. ## Changes - **What**: removes the dead `agent.retryAfter` locale entry (the rendered admission copy uses `agent.retryAfterSeconds`, nothing in `src` or `browser_tests` reads the pluralized key, and no other locale carries it); drops the four-line comment above the paywall prompt assertions in `agentPanel.spec.ts`, since the two distinct locators already say which outcomes are observed; builds the new `msg-paywall` ids with `toTurnId` rather than casting through the `TurnId` brand. ## Review Focus Threads addressed: [dead locale key](#16856 (comment)), [redundant spec comment](#16856 (comment)), [`toTurnId` in the paywall cases](#16856 (comment)). The pre-existing `as TurnId` casts elsewhere in `AgentPanelRoot.test.ts` (lines around 2272, 2341, 3103, 5097) predate #16856 and are left alone; only the cases that PR added are converted. The remaining open threads from #16856 are tracked in Linear rather than fixed here: FE-2307, FE-2309, FE-2310, FE-2311, FE-2314, FE-2315, FE-2387, FE-2388, FE-2389, FE-2460, FE-2461, FE-2462, FE-2463, FE-2464, FE-2519, plus the new paywall-policy-ownership and `test.step` items. Verified at this head: `AgentPanelRoot.test.ts` 226/226 pass (`NODE_OPTIONS=--no-experimental-webstorage`, required on node 26), `vue-tsc --noEmit` and `tsc --noEmit` clean, changed-file `eslint` and `oxfmt --check` clean. (cherry picked from commit d09ca50)
Scopes selected nodes to their owning workflow. Selected-node context now names its owning workflow, so the agent can distinguish a referenced node from the currently focused tab. <details><summary>Full context for agent readers</summary> ## Changes - Capture the workflow that owns the selected node when the send begins, and resolve its cloud workflow ID afterwards, once the pre-send refresh has run. The ID is not read when the reference chip is created. - Send that ID as `selection.workflow_id` alongside `selection.node_ids`. - Preserve the legacy node-only payload when no cloud workflow identity is available. The agent service already accepts the selection as an open map and serializes every key into the turn prompt, so no cloud change is required. ## Evidence - `pnpm test:unit src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts` — 173 passed. - `pnpm typecheck` — passed. - Scoped ESLint — passed. - Rebased onto `origin/main` at `70e7e0269` before final verification. Linear: [workflow context issue](https://linear.app/comfyorg/issue/PM-856/agent-doesnt-recognize-selected-nodes-belong-to-a-non-focused-tab) Re-carried from the fork-hosted PR [fix(agent): scope selected nodes to their workflow](#16946) so it can be rebased. </details> --------- Co-authored-by: Terry Jia <terryjia88@gmail.com> Backport note (cloud/1.54): - Main's end state (mechanical): in useAgentSession.ts buildPostInput, the unboundTarget line (#18278, restored by this stack's #16856 runtime commit) comes before this change's selectedWorkflowId. The function now equals main's. (cherry picked from commit 314fe52)
…ion message seam (#18229) Fixes the `Retry-After` parser contract and the admission-message component seam left by [#16856](#16856). Latest behavior-changing commit: [`1e517cb1`](1e517cb). [Remote CI](https://github.com/Comfy-Org/ComfyUI_frontend/pull/18229/checks) is the verification authority. <details><summary>Full context for agent readers</summary> ## Changes - [FE-2461](https://linear.app/comfyorg/issue/FE-2461): `parseRetryAfter` now returns only safe non-negative integer seconds or `undefined`. HTTP dates are parsed as the three RFC 9110 formats rather than through permissive `Date.parse` behavior. Calendar/time components, four-digit years from 1900 onward, leap seconds, and the RFC 850 full-timestamp 50-year window are handled explicitly. - [FE-2313](https://linear.app/comfyorg/issue/FE-2313): a component test renders the real `AgentMessage` → `AgentMessageGroup` → `AgentPaywallCard` chain and verifies that the server denial reason reaches the user instead of generic fallback copy. - Browser coverage drives the delay-seconds retry notice through the shared agent fixture; parser rejection policy remains in the unit contract suite. ## Review focus - Accepted: delay-seconds, IMF-fixdate, RFC 850, and asctime. - Rejected: malformed or non-HTTP dates, impossible calendar/time values, pre-1900 four-digit years, negative/fractional/unsafe/overflowing delay-seconds. - A mismatched weekday remains deliberately tolerated because it carries no deadline information and RFC 9110 asks recipients to parse robustly. Out of scope: [FE-2460](https://linear.app/comfyorg/issue/FE-2460), the older admission `reason` contract question. </details> --------- Co-authored-by: GitHub Action <action@github.com> (cherry picked from commit ddbcb9a)
## Summary Use the server's upload-size limit for agent attachments, upload up to three files concurrently, and cancel pending uploads when the panel closes. Removing a reference keeps its upload available for Undo, matching the current composer behavior. ## Changes - Apply one extension allowlist to the picker and runtime validation. - Reserve 1 KiB for request overhead; fall back to 20 MiB for invalid server limits and cap advertised limits at 512 MiB. - Scale upload deadlines with file size, abort expired requests, and refresh the asset library after each completed batch. - Remove cancelled attachments immediately on panel disposal so reopening preserves a usable draft. - Keep user-removed references detached while their uploads finish; only Undo brings them back. - Dependencies: none. ## Review focus Panel-close cancellation versus undoable reference removal, persisted drafts, and file-size validation. The existing human findings have fixes and regression coverage; their threads remain open for the reviewer. <details><summary>Verification and source context</summary> - The first published integration failed the existing inline-reference browser test after Undo. Cancelling a removed reference permanently retired its attachment; current main intentionally preserves that upload for Undo. The repair removes the parent cancellation listener, preserving panel-disposal cancellation. - Three cloud browser scenarios, each repeated twice: six passes. They cover reference removal and Undo, closing/reopening during an upload, and accepting/rejecting files against the server limit. - Four unit/component suites: 336 passes. The component regression was also rerun after using the repository-supported deferred-promise pattern. - Commit hooks passed formatting, stylelint, type-aware Oxlint, ESLint, application/package typechecks, unused-translation and frozen-directory checks. GitHub checks run separately on the pushed revision. - The earlier preparation also verified cancellation and invalid-limit cases fail without their fixes. Browser commands use a private browser cache and a 60-second test timeout for dev-server startup and large fixture transfer. This remains the main-based attachment subset of #16385. It does not replace that PR's non-attachment work. Glossary: MiB = 1,048,576 bytes; KiB = 1,024 bytes. </details> <!-- authored-by:agent lane-revfold-10-1515 --> Backport note (cloud/1.54). Adapted in this commit, because every commit here must pass the pre-commit lint and typecheck: - runtime: useAttachment.ts is taken whole from this change. It builds on two changes this line does not have: #16917 (reportError when an upload fails) and #18104 (the upload url becomes the composer preview). Their useAttachment slivers come with it; #18104's message-rendering part does not. - test-only: useAttachment.test.ts is taken whole from this change, including #16917's and #18104's expectations for those slivers. - runtime: AgentPanelRoot.vue's upload option is this change's version: abort signal, filename fallback, /view url. - runtime: agentApiSchema.ts drops zUploadImageResult as this change does. main's zDisownedWorkflowError, from another change, is not added. - test-only: useAgentSession.test.ts imports UploadImageResponse and keeps this line's pinia setup. The next commit updates this line's Undo preview test to #18104's version, labelled test-only. (cherry picked from commit 6b60a3f)
…16985 Backport resolution (test-only) for #16985 on cloud/1.54. #16985 brings #18104's durable preview: once an upload lands, the composer chip shows the server's /view url and the local blob is revoked. This line's Undo test, from #17437, still expected the blob to survive until unmount. Apply #18104's own update to that test: it checks the /view preview, restores the chip with Undo, and counts the single revoke.
…8224) ## Summary Companion to [Comfy-Org/cloud#9938](https://github.com/Comfy-Org/cloud/pull/9938), which removes `version` from the turn endpoint's `draft` request schema. Raised in [review on that PR](https://github.com/Comfy-Org/cloud/pull/9938#discussion_r4057472499): the frontend hand-declares this request shape instead of taking it from the generated ingest package, so the contract change does not propagate on its own. ## Changes - **What**: `DraftSnapshot` becomes content-only and its doc comment is corrected. `postMessage` now builds the wire `draft` as `{ content }` from the snapshot instead of assigning the snapshot object wholesale, so a wider object handed in by a caller cannot leak extra fields onto the request. The test that forwarded `draft.version` is replaced by one that passes a wider `{ content, version }` snapshot and asserts the serialized body carries `content` only. - **Breaking**: no. `targetWorkflowDraft()`, the only producer, already returned `{ content }`; nothing ever set `version`, so no shipped request payload changes. Two things were wrong once the cloud change lands. The type kept advertising an optional `version` the server has no schema for, which is a field a caller could reasonably set and then spend a while working out why nothing happened. And the doc comment said an omitted version *"makes this content authoritative for the backend CAS"*, which states the opposite of the decision it was describing. After the retirement there is no backend CAS for an omission to be authoritative against; `workflow_draft.version` is a projection-cache snapshot counter, not a concurrency token. That comment was the thing most likely to mislead a future frontend author, so it mattered more than the field. `GET /api/agent/draft` still returns a version and callers still read and display it. That asymmetry is deliberate and is now stated on the type rather than left to be inferred. ## Review Focus The wire narrowing in `agentRestClient.ts` is one line. The test for it deliberately passes the snapshot through a variable typed wider than `DraftSnapshot` so the compiler cannot close the case for us; the assertion is on the serialized request body, not on the type. Still open from review: `DraftSnapshot` should be derived from the generated `AgentPostMessageRequest['draft']` rather than hand-declared. That is blocked until the cloud contract lands and `packages/ingest-types` regenerates, because today the generated type still carries `version` and makes `content` optional. This PR stays a draft until that lands; see Merge order. ## Regression testing No Playwright test is added. The change is to the shape of an outgoing request body (`draft` narrowed to `{ content }`), and the shipped producer already emits exactly that shape, so there is no user-visible behaviour before or after this change for a browser test to observe. The only observable is the serialized JSON body, which the unit test in `agentRestClient.test.ts` asserts directly against the fetch mock. A browser test would need a cloud stub that rejects `version` to fail meaningfully, and that rejection is the cloud PR's contract, not this client's. ## Test evidence Original commit: `pnpm exec vitest run` on `agentRestClient.test.ts` and `useAgentSession.test.ts` passed (2 files, 109 passed, 2 expected fail); `vue-tsc --noEmit` and `oxlint --type-aware` clean; pre-commit chain passed. Follow-up commit 2a28c93 was committed with `HUSKY=0` and no local checks because the dev host was under a resource hold; GitHub CI on this PR is the verification for that commit. ## Merge order Contract first. Sequence: 1. https://github.com/Comfy-Org/cloud/pull/9938 merges. 2. Ingest types regenerate and the generated-types PR merges. 3. This PR switches `DraftSnapshot` to the derived type and is marked ready. Landing this PR before step 2 is still safe at runtime (no shipped caller sets `version`), but the derived-type change cannot be written correctly until then, so the PR waits. <details><summary>Full context for agent readers</summary> Files: `src/workbench/extensions/agent/services/agent/agentRestClient.ts` (type, doc comment, wire narrowing at the `body.draft` assignment), `src/workbench/extensions/agent/services/agent/agentRestClient.test.ts` (new content-only wire test), `src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts` (fixture drops `version: 1`). Review threads addressed: wire narrowing (done in the commit above), type derivation (deferred, blocked on the cloud PR and ingest regeneration). Cloud PR head at last check: https://github.com/Comfy-Org/cloud/commit/a375caf69dfdc543337d5981dd937fc105bfc968, awaiting human review. </details> Backport note (cloud/1.54). Adapted in this commit, because every commit here must pass the pre-commit lint and typecheck: - runtime: DraftSnapshot is Pick<Required<NonNullable< AgentPostMessageRequest['draft']>>, 'content'>. This line's ingest-types (1.0.0) still declares an optional draft version, which main's Required<...> alias would make mandatory. The Pick keeps the snapshot content-only and derived from the generated contract. - The postMessage body takes main's AgentPostMessageRequest type. This line's 1.0.0 type already declares current_tab_unbound, so it needs no augmentation. (cherry picked from commit 390fe43)
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1945 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T21:54:52.525Z",
"gitSha": "ac27f6d652e6c566b295c540916c45ea13e01cc0",
"branch": "backport-agent-fixes-2b-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2093.133000000023,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.446,
"heapDeltaBytes": -6920004,
"heapUsedBytes": 56554844,
"domNodes": 0,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.514999999999997,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.2910000000347,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.626000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.9079999999999,
"heapDeltaBytes": 12073844,
"heapUsedBytes": 83128012,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.27,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1956.2660000000278,
"styleRecalcs": 81,
"styleRecalcDurationMs": 34.194,
"layouts": 14,
"layoutDurationMs": 4.773000000000001,
"taskDurationMs": 944.421,
"heapDeltaBytes": 626992,
"heapUsedBytes": 71581888,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 177.274,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.5579999999504,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.525999999999996,
"layouts": 14,
"layoutDurationMs": 4.092999999999999,
"taskDurationMs": 916.022,
"heapDeltaBytes": -6796516,
"heapUsedBytes": 63652828,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 170.827,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1676.807999999994,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.795,
"layouts": 6,
"layoutDurationMs": 1.1909999999999998,
"taskDurationMs": 386.049,
"heapDeltaBytes": 4568552,
"heapUsedBytes": 75464044,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.129999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.72299999996,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.160000000000004,
"layouts": 6,
"layoutDurationMs": 1.344,
"taskDurationMs": 422.82499999999993,
"heapDeltaBytes": 4249004,
"heapUsedBytes": 74903848,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.950999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 719.3859999999859,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.60999999999996,
"heapDeltaBytes": -7972948,
"heapUsedBytes": 63337460,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 164.123,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 693.6510000000453,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.034999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.276,
"heapDeltaBytes": 18680172,
"heapUsedBytes": 89062464,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 172.376,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.6520000000087,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.751,
"heapDeltaBytes": 5882160,
"heapUsedBytes": 82208264,
"domNodes": -280,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 34.304,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.7879999999595,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.575999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 669.177,
"heapDeltaBytes": 8619308,
"heapUsedBytes": 85108108,
"domNodes": -275,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 36.094,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2345.906999999954,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.382000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1628.632,
"heapDeltaBytes": 22971668,
"heapUsedBytes": 89206904,
"domNodes": -279,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 836.346,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2669.475000000034,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.814000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1774.5460000000003,
"heapDeltaBytes": 26384368,
"heapUsedBytes": 92678708,
"domNodes": -276,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 899.9639999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3601.3289999999643,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.939999999999998,
"layouts": 60,
"layoutDurationMs": 12.113000000000001,
"taskDurationMs": 1795.379,
"heapDeltaBytes": -7305924,
"heapUsedBytes": 71711344,
"domNodes": -251,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 783.157,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3767.6999999999907,
"styleRecalcs": 62,
"styleRecalcDurationMs": 14.822,
"layouts": 60,
"layoutDurationMs": 12.559000000000001,
"taskDurationMs": 1827.6820000000002,
"heapDeltaBytes": 10391924,
"heapUsedBytes": 76513612,
"domNodes": -280,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 814.643,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3157.7459999999746,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.663,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1965.8529999999998,
"heapDeltaBytes": 26151168,
"heapUsedBytes": 94643820,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 993.231,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3148.1959999999845,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.344999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2037.1430000000005,
"heapDeltaBytes": 26726500,
"heapUsedBytes": 94637344,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1006.584,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1998.7920000000372,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.115,
"heapDeltaBytes": 21786732,
"heapUsedBytes": 88571304,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.604000000000006,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.6909999999434,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.6899999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 650.737,
"heapDeltaBytes": 8874692,
"heapUsedBytes": 87363272,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 39.403000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 683.2140000000209,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.461,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.196,
"heapDeltaBytes": 15022556,
"heapUsedBytes": 88431236,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 144.815,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.5339999999978,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.319,
"heapDeltaBytes": 15014892,
"heapUsedBytes": 88355092,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.953,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.5889999999781,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.25,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.468,
"heapDeltaBytes": -6832128,
"heapUsedBytes": 65820388,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 7.370000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.7099999999846,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.146,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 537.181,
"heapDeltaBytes": -6533876,
"heapUsedBytes": 66863700,
"domNodes": -293,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.887,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.3560000000043,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.743999999999996,
"layouts": 18,
"layoutDurationMs": 4.9319999999999995,
"taskDurationMs": 805.268,
"heapDeltaBytes": -5624616,
"heapUsedBytes": 60250792,
"domNodes": -297,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 108.68499999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1750.8730000000696,
"styleRecalcs": 80,
"styleRecalcDurationMs": 29.242,
"layouts": 18,
"layoutDurationMs": 4.705,
"taskDurationMs": 871.575,
"heapDeltaBytes": -3327816,
"heapUsedBytes": 70064960,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 119.366,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.6550000000207,
"styleRecalcs": 18,
"styleRecalcDurationMs": 33.969,
"layouts": 14,
"layoutDurationMs": 16.546000000000003,
"taskDurationMs": 1061.7760000000003,
"heapDeltaBytes": -7178912,
"heapUsedBytes": 83299544,
"domNodes": 13751,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 36.936,
"eventListeners": 2387,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9915.855000000021,
"styleRecalcs": 247,
"styleRecalcDurationMs": 42.865,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6492.522,
"heapDeltaBytes": 19577640,
"heapUsedBytes": 96415580,
"domNodes": -273,
"jsHeapTotalBytes": -1744896,
"scriptDurationMs": 2982.398,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8882.629000000066,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6146.919,
"heapDeltaBytes": 1812156,
"heapUsedBytes": 77764372,
"domNodes": -281,
"jsHeapTotalBytes": 352256,
"scriptDurationMs": 2812.107,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18354.877999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17455.173,
"heapDeltaBytes": -56922844,
"heapUsedBytes": 178248052,
"domNodes": -8068,
"jsHeapTotalBytes": -17215488,
"scriptDurationMs": 313.572,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18135.313999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17336.185,
"heapDeltaBytes": -60140728,
"heapUsedBytes": 176702708,
"domNodes": -8068,
"jsHeapTotalBytes": -16408576,
"scriptDurationMs": 336.275,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22736.260000000017,
"styleRecalcs": 177,
"styleRecalcDurationMs": 23.57199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22486.055999999997,
"heapDeltaBytes": -28652504,
"heapUsedBytes": 189391648,
"domNodes": -8068,
"jsHeapTotalBytes": -11370496,
"scriptDurationMs": 983.6879999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.77333333333348,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 21400.318999999967,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.345999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21021.366,
"heapDeltaBytes": -41943168,
"heapUsedBytes": 183425796,
"domNodes": -8068,
"jsHeapTotalBytes": -14585856,
"scriptDurationMs": 997.302,
"eventListeners": -14927,
"totalBlockingTimeMs": 120,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6503.830999999991,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.901,
"layouts": 20,
"layoutDurationMs": 23.81,
"taskDurationMs": 6393.72,
"heapDeltaBytes": -61226972,
"heapUsedBytes": 178058176,
"domNodes": -8068,
"jsHeapTotalBytes": 5066752,
"scriptDurationMs": 117.83699999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 480,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6407.238000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.31100000000002,
"layouts": 20,
"layoutDurationMs": 23.844000000000005,
"taskDurationMs": 6290.121000000001,
"heapDeltaBytes": -47577968,
"heapUsedBytes": 176117564,
"domNodes": -8068,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 114.093,
"eventListeners": -14927,
"totalBlockingTimeMs": 459,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9301.585999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8859.393,
"heapDeltaBytes": 11794612,
"heapUsedBytes": 178973456,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 154.007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9129.255999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8663.329000000002,
"heapDeltaBytes": -12753736,
"heapUsedBytes": 178710692,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 145.953,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 131.93100000000868,
"styleRecalcs": 10,
"styleRecalcDurationMs": 22.281000000000002,
"layouts": 3,
"layoutDurationMs": 1.766,
"taskDurationMs": 97.19,
"heapDeltaBytes": 3145920,
"heapUsedBytes": 72206680,
"domNodes": 139,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.675999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 121.82700000005298,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.866999999999999,
"layouts": 2,
"layoutDurationMs": 0.71,
"taskDurationMs": 79.707,
"heapDeltaBytes": 3001312,
"heapUsedBytes": 71761032,
"domNodes": 110,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.471,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18641 +/- ##
=============================================
Coverage ? 83.73%
=============================================
Files ? 2110
Lines ? 125103
Branches ? 31699
=============================================
Hits ? 104757
Misses ? 20167
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports the second batch of merged
mainAgent fixes tocloud/1.54: the Agent paywall and admission-error handling with its follow-ups, workflow-scoped node selection, the bounded attachment upload contract, and the turn request contract without the draft version.Changes
cherry-pick -xof Restore agent paywall (FE-1706) and admission-error handling (PM-518) #16856, chore(agent): address post-merge review nits from #16856 #18204, PM-856: fix(agent): scope selected nodes to their workflow #17327, fix(agent): keep Retry-After parsing in contract and cover the admission message seam #18229, fix(agent): bound attachment upload contract #16985 and fix(agent): drop the draft version from the turn request contract #18224, inmainmerge order. Two adaptation commits: Restore agent paywall (FE-1706) and admission-error handling (PM-518) #16856's PM-1430 behavior is replayed in fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) #18278's split form, since this line had it in the old single-function form via [backport cloud/1.54] fix: flag a freshly created, unsaved tab as unbound for the agent (PM-1430) #18385; fix(agent): bound attachment upload contract #16985 brings fix: prefer previewUrl over type=input lookup for dragged batch-output attachments #18104's version of the Undo test.DraftSnapshotisPick<..., 'content'>because this line's ingest types keep the draft version optional.src/lib/litegraph/hunks, and its lockfile change does not apply to this line).Review Focus
useAttachment.tsand its test are taken whole frommain, because fix(agent): bound attachment upload contract #16985 assertsreportErroron its new fetch path.Linear: PM-1656
Screenshots (if applicable)
No new visuals.