Repository navigation
[backport cloud/1.54] fix: copy/paste beside the agent panel (#18062) - #18336
Conversation
Backport of ec5da77 to cloud/1.54. Dropped the agentConversationFixture and agent replay spec hunks: those files do not exist on cloud/1.54. Dropped AgentCopyPasteDriver.ts and agentCopyPaste.spec.ts: the agent conversation replay fixture they depend on is absent on cloud/1.54.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1573 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T02:41:51.830Z",
"gitSha": "1afdcda15bdb57c9556577e432213bf25e593cd9",
"branch": "backport-18062-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.5459999999862,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.134000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.225,
"heapDeltaBytes": -10657788,
"heapUsedBytes": 59546016,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.457999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2023.527999999942,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.303999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.192,
"heapDeltaBytes": 8781836,
"heapUsedBytes": 79329896,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.087000000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1863.9529999999809,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.916,
"layouts": 14,
"layoutDurationMs": 3.8709999999999996,
"taskDurationMs": 834.534,
"heapDeltaBytes": -5105724,
"heapUsedBytes": 64725432,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 139.353,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.916999999944,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.025000000000002,
"layouts": 14,
"layoutDurationMs": 3.577,
"taskDurationMs": 682.866,
"heapDeltaBytes": -5828520,
"heapUsedBytes": 64019620,
"domNodes": -278,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 114.38199999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.7300000000264,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.996,
"layouts": 6,
"layoutDurationMs": 0.9500000000000001,
"taskDurationMs": 273.20500000000004,
"heapDeltaBytes": 3556440,
"heapUsedBytes": 68100140,
"domNodes": 76,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 9.601,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1656.9350000000895,
"styleRecalcs": 29,
"styleRecalcDurationMs": 13.113000000000001,
"layouts": 6,
"layoutDurationMs": 0.998,
"taskDurationMs": 284.753,
"heapDeltaBytes": 4382492,
"heapUsedBytes": 75521248,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.382000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 589.1189999999824,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.995000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.515,
"heapDeltaBytes": 18725792,
"heapUsedBytes": 88010636,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 139.82899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 566.9719999999643,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.946000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.068,
"heapDeltaBytes": 18111192,
"heapUsedBytes": 88320376,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 132.944,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2035.9170000000404,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.013999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.82900000000006,
"heapDeltaBytes": 11021040,
"heapUsedBytes": 87395356,
"domNodes": -265,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 33.107,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2028.866999999991,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.141999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.89599999999996,
"heapDeltaBytes": 22270872,
"heapUsedBytes": 87704268,
"domNodes": -263,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.418000000000006,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2131.416999999999,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.424999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1322.115,
"heapDeltaBytes": -1061028,
"heapUsedBytes": 75975156,
"domNodes": -276,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 620.135,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2165.2109999999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.932999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1306,
"heapDeltaBytes": -776856,
"heapUsedBytes": 76503184,
"domNodes": -274,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 645.028,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3160.3380000000243,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.143,
"layouts": 60,
"layoutDurationMs": 11.376,
"taskDurationMs": 1367.357,
"heapDeltaBytes": 8543408,
"heapUsedBytes": 76072016,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 618.4099999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3147.3969999999554,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.312,
"layouts": 60,
"layoutDurationMs": 11.498,
"taskDurationMs": 1359.7130000000002,
"heapDeltaBytes": 8206688,
"heapUsedBytes": 75963856,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 621.7860000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2201.4389999999935,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.373000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1502.6299999999999,
"heapDeltaBytes": 13824300,
"heapUsedBytes": 81730828,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 737.402,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2273.8749999999754,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.837000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1529.3000000000002,
"heapDeltaBytes": 14157400,
"heapUsedBytes": 94711388,
"domNodes": 12,
"jsHeapTotalBytes": 3825664,
"scriptDurationMs": 750.36,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.7219999999688,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.486000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.4679999999999,
"heapDeltaBytes": 5207960,
"heapUsedBytes": 82844888,
"domNodes": -276,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 28.630000000000003,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.4750000000322,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.6510000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.5659999999999,
"heapDeltaBytes": 21842156,
"heapUsedBytes": 87407344,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.713,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.1919999999668,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.232000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.398,
"heapDeltaBytes": 14735304,
"heapUsedBytes": 87756840,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.732,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.2639999999737,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.00899999999996,
"heapDeltaBytes": 14974376,
"heapUsedBytes": 87761472,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 107.959,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2001.0369999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.889000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.343,
"heapDeltaBytes": -5614056,
"heapUsedBytes": 67461196,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 6.962,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1991.5280000000166,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.425,
"heapDeltaBytes": -9270856,
"heapUsedBytes": 62445424,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.023999999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.9739999999929,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.820999999999998,
"layouts": 18,
"layoutDurationMs": 4.3549999999999995,
"taskDurationMs": 692.104,
"heapDeltaBytes": -8709916,
"heapUsedBytes": 64546620,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 87.56700000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.904999999977,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.679999999999996,
"layouts": 18,
"layoutDurationMs": 3.922,
"taskDurationMs": 662.905,
"heapDeltaBytes": 5046996,
"heapUsedBytes": 78268468,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 85.028,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.3490000000056,
"styleRecalcs": 21,
"styleRecalcDurationMs": 25.186999999999994,
"layouts": 17,
"layoutDurationMs": 11.785,
"taskDurationMs": 724.0120000000001,
"heapDeltaBytes": -5539280,
"heapUsedBytes": 87360592,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 21.051999999999996,
"eventListeners": 2385,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8210.735,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.286,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4609.999,
"heapDeltaBytes": -7044928,
"heapUsedBytes": 68901116,
"domNodes": -279,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 2132.412,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8213.879000000019,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.332,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4542.787,
"heapDeltaBytes": 4974476,
"heapUsedBytes": 81125728,
"domNodes": -266,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2083.4260000000004,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14804.547000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14359.586,
"heapDeltaBytes": -41851260,
"heapUsedBytes": 176570956,
"domNodes": -8068,
"jsHeapTotalBytes": -13352960,
"scriptDurationMs": 220.74300000000002,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14758.663999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14217.039,
"heapDeltaBytes": -41412056,
"heapUsedBytes": 176501332,
"domNodes": -8068,
"jsHeapTotalBytes": -13090816,
"scriptDurationMs": 236.66799999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17439.006000000005,
"styleRecalcs": 141,
"styleRecalcDurationMs": 14.71900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17071.292,
"heapDeltaBytes": -29309356,
"heapUsedBytes": 188378512,
"domNodes": -8068,
"jsHeapTotalBytes": -12648448,
"scriptDurationMs": 734.576,
"eventListeners": -14931,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 17189.87799999991,
"styleRecalcs": 137,
"styleRecalcDurationMs": 14.096999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16911.831,
"heapDeltaBytes": -53087496,
"heapUsedBytes": 165110844,
"domNodes": -8068,
"jsHeapTotalBytes": -14159872,
"scriptDurationMs": 733.466,
"eventListeners": -14931,
"totalBlockingTimeMs": 14,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5333.068000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.831999999999994,
"layouts": 20,
"layoutDurationMs": 20.897,
"taskDurationMs": 5252.292,
"heapDeltaBytes": -33495828,
"heapUsedBytes": 184690900,
"domNodes": -8072,
"jsHeapTotalBytes": 20451328,
"scriptDurationMs": 91.22300000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 198,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5258.416000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.710999999999984,
"layouts": 20,
"layoutDurationMs": 20.913999999999987,
"taskDurationMs": 5154.641,
"heapDeltaBytes": -33472324,
"heapUsedBytes": 183858960,
"domNodes": -8068,
"jsHeapTotalBytes": 18092032,
"scriptDurationMs": 88.59999999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 221,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7358.688000000029,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7022.639999999999,
"heapDeltaBytes": 7315004,
"heapUsedBytes": 177108784,
"domNodes": 0,
"jsHeapTotalBytes": -31719424,
"scriptDurationMs": 103.97100000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7357.089999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7168.745,
"heapDeltaBytes": 6676468,
"heapUsedBytes": 166026232,
"domNodes": 0,
"jsHeapTotalBytes": -10223616,
"scriptDurationMs": 103.94099999999995,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 441.6990000000851,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.929,
"layouts": 3,
"layoutDurationMs": 1.205,
"taskDurationMs": 92.47999999999999,
"heapDeltaBytes": 5088204,
"heapUsedBytes": 74229184,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.898,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 430.2790000000414,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.656999999999998,
"layouts": 2,
"layoutDurationMs": 0.44300000000000006,
"taskDurationMs": 74.325,
"heapDeltaBytes": 4746124,
"heapUsedBytes": 73699768,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.131000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18336 +/- ##
=============================================
Coverage ? 82.94%
=============================================
Files ? 2093
Lines ? 123089
Branches ? 33424
=============================================
Hits ? 102091
Misses ? 20820
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 0386f1b | Docs | View more details | Give us feedback! |
…eir real slot after an agent slot sync (PM-1449) (#18279) (#18340) Backport of #18279 to `cloud/1.54`. Manual cherry-pick — the automated backport reported a merge conflict. ## Summary (from #18279) A hand-wired connection into an autogrow port could be serialized against the wrong input after an agent slot sync. `updateNodeSlots` replaced the store's slot arrays even though the live `LGraphNode` retained the original arrays, leaving serialization and the canvas with different slot layouts. The fix preserves the registered input/output arrays and patches matching slot objects in place instead of replacing them, matching duplicate names occurrence by occurrence. ## Conflict resolution Conflicts were in `src/stores/nodeDataStore.ts` and `src/stores/nodeDataStore.test.ts`: - `src/stores/nodeDataStore.ts`: `updateNodeSlots` on `cloud/1.54` still had the pre-fix naive assignment (`state.inputs = slots.inputs`; `state.outputs = slots.outputs`). Took the incoming version, which calls the new `mergeSlotsByName` helper (added earlier in the same diff, which applied cleanly) for both inputs and outputs. - `src/stores/nodeDataStore.test.ts`: two conflicts. The import line conflicted because `cloud/1.54`'s test file already pulls in `createTestingPinia`/`setActivePinia`/`beforeEach` (used by describe blocks not present on `main`), while the incoming diff needed `vi` for its new spies. Resolved by keeping both sets of imports. The second conflict was a pure addition (a new `'keeps live slot edits visible after a remote slot sync'` test) with no `cloud/1.54`-side change, so it was taken as-is. **Is this a real conflict, or a stacking conflict?** I checked the three other PRs the backport bot flagged as still open against `cloud/1.54` (#18336, #18333, #18330). None of them touch `src/stores/nodeDataStore.ts` or `src/stores/nodeDataStore.test.ts`, so this is not a stacking conflict with those PRs — it's a genuine divergence: `cloud/1.54` simply hadn't yet picked up the array-mutation-in-place semantics that #18279 introduces on `main`. ## Verification - `pnpm vitest run src/stores/nodeDataStore.test.ts` — 31 passed. - `pnpm vitest run src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 48 passed, 1 expected failure (matches #18279's own reported result). - `pnpm typecheck` — passed. - `pnpm oxlint` (on changed files) — no new warnings/errors. - `oxfmt --check` on changed files — all correctly formatted. <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789965308493739)_ 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6 --- _Generated by [Claude Code](https://claude.ai/code/session_01PqHg3D8o2RbujF1t4dz4J6)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
Requested by Christian Byrne · Slack thread
Summary
Source: #18062, merged as
ec5da77d0ff9a45d637bcfe128772ac8557e8a06. Target:cloud/1.54at19a4f18b799f228a0faf39d951c22a4fdb53daf8.Before: With the agent panel open, copying a node after text in the transcript had been selected pasted an older node or nothing: the canvas cancels the default pointerdown, so the transcript selection survived the click on the node and
shouldIgnoreCopyPaste()swallowed both the Ctrl+C and the Ctrl+V, leaving the next paste to fall back to the stalelocalStoragenode clipboard. Pasting into the composer (a contenteditable editor) could likewise drop a stale node onto the canvas.After: Clicking into the graph collapses a text selection made outside the clicked element, so the copy and paste that follow reach the graph. Copy respects text selection: with non-editable text selected, Ctrl+C copies the text and canvas copy/paste stays out of the way, and a later text copy clears the canvas clipboard slot when it still holds the node copy it superseded. Ownership is tracked by a per-copy id (
localStorage['litegrapheditor_clipboard_id']) stamped by everyLGraphCanvas.copyToClipboard(), souseCopyonly clears the slot while its own Ctrl+C copy is still current. Contenteditable editors count as text inputs, and selections inside a textarea or text/search input are detected throughselectionStart/selectionEnd.Changes
src/workbench/eventHelpers.ts:collapseTextSelectionOutside(),collapseOutsideSelectionOnPrimaryPointerDown(),hasTextSelection()(textarea/input selections, whitespace-only selections),shouldIgnoreCopyPaste()treats contenteditable as a text input.src/components/graph/GraphCanvas.vue: collapses an outside text selection on primary pointerdown into the graph.src/composables/useCopy.ts: remembers the id of its own Ctrl+C node copy and clears the canvas clipboard slot when a later text copy supersedes it.src/lib/litegraph/src/LGraphCanvas.ts:copyToClipboard()stamps a freshlitegrapheditor_clipboard_id.browser_tests/fixtures/components/Topbar.ts:getWorkflowTabLabel()helper.src/composables/useCopy.test.ts,src/workbench/eventHelpers.test.ts(new),src/lib/litegraph/src/LGraphCanvas.clipboard.test.ts,browser_tests/tests/canvas/copyPasteAfterTextSelection.spec.ts(new canvas regression spec).Backport adaptations
Dropped the hunks touching
browser_tests/fixtures/agentConversationFixture.tsand the agent replay specs (agentConversationReplay,agentHumanAddTabSwitch,agentHumanDeleteTabSwitch,agentLayoutQuality,agentNewChatClearedCanvas,agentPastedNodeOrphanedOnRetarget,agentTabSwitchCatchUp,agentTabSwitchRunSubmission,cmpDocumentAcceptance): none of these files exist oncloud/1.54(modify/delete conflicts), so they stay absent.Dropped
browser_tests/fixtures/AgentCopyPasteDriver.tsandbrowser_tests/tests/agent/agentCopyPaste.spec.ts: they build onagentConversationTestfrom the recorded-conversation replay fixture, which has no equivalent on this branch (noagentConversationFixture, no recorded conversation data). The canvas regression speccopyPasteAfterTextSelection.spec.tsand the unit tests carry the coverage here.src/composables/useCopy.test.ts: content conflict resolved by taking the fix: copy/paste beside the agent panel #18062 version wholesale; its imports (fromPartial,useCanvasStore,eventHelpers) all resolve on the branch.src/lib/litegraph/src/LGraphCanvas.clipboard.test.ts: the auto-merge dropped the source commit's import hunk, socreateTestNode(@/lib/litegraph/src/__fixtures__/nodeHelpers) andcreateTestRootGraph(@/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers) were re-added; both helpers already exist on the branch.Review Focus
Straight cherry-pick of the source files; only e2e files tied to the absent agent replay harness were dropped. Unit tests and the canvas e2e spec remain.
🤖 Generated with Claude Code
https://claude.ai/code/session_01M9ZKkgcvdGt7LHjkvJUq63