Repository navigation
fix: release an agent workflow binding the server disowns - #18280
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2071 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9a76712291ccfdce6b0912f3d513f597c00edd8
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.95 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T11:35:54.124Z",
"gitSha": "28f0feb7cd0c35779a8e3dd0cb68b35bd6ae0339",
"branch": "fix/agent-release-disowned-workflow-binding",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.163000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.291999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.042,
"heapDeltaBytes": 16405496,
"heapUsedBytes": 78422664,
"domNodes": -260,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.292000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1991.3060000000087,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.295,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.882,
"heapDeltaBytes": -2429372,
"heapUsedBytes": 59690224,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.361999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1766.9910000000186,
"styleRecalcs": 76,
"styleRecalcDurationMs": 24.538,
"layouts": 14,
"layoutDurationMs": 4.321000000000001,
"taskDurationMs": 789.4499999999999,
"heapDeltaBytes": 18910656,
"heapUsedBytes": 81247168,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 137.943,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1795.2280000000655,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.034,
"layouts": 14,
"layoutDurationMs": 4.085,
"taskDurationMs": 818.45,
"heapDeltaBytes": -1460460,
"heapUsedBytes": 60835168,
"domNodes": -263,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 142.14499999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.1420000000098,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.632,
"layouts": 6,
"layoutDurationMs": 1.0510000000000002,
"taskDurationMs": 324.963,
"heapDeltaBytes": 2074388,
"heapUsedBytes": 64269868,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.522,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9219999999395,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.231,
"layouts": 6,
"layoutDurationMs": 1.157,
"taskDurationMs": 321.49699999999996,
"heapDeltaBytes": 2249464,
"heapUsedBytes": 64397588,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.842,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 609.3230000000176,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.574000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.688,
"heapDeltaBytes": 18207340,
"heapUsedBytes": 80147220,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.599,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 582.3879999999235,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.249999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.068,
"heapDeltaBytes": 18186788,
"heapUsedBytes": 80234248,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 153.589,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1147.3639999999818,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 814.4559999999999,
"heapDeltaBytes": 34630544,
"heapUsedBytes": 107769616,
"domNodes": 0,
"jsHeapTotalBytes": 18771968,
"scriptDurationMs": 58.885999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 534,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1162.8140000000258,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.414,
"heapDeltaBytes": -13102884,
"heapUsedBytes": 73138612,
"domNodes": -297,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 59.60299999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 519,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.8819999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.2419999999997,
"heapDeltaBytes": 14293156,
"heapUsedBytes": 90584644,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 143.79400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 197,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 797.2240000000284,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.1450000000001,
"heapDeltaBytes": 14411596,
"heapUsedBytes": 89692024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.64,
"eventListeners": 0,
"totalBlockingTimeMs": 183,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9798.729000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8949.215,
"heapDeltaBytes": -802932,
"heapUsedBytes": 81232356,
"domNodes": -18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7165.139,
"eventListeners": 0,
"totalBlockingTimeMs": 585,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8732.543999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7995.422,
"heapDeltaBytes": -12997008,
"heapUsedBytes": 69476060,
"domNodes": -16,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 6356.566,
"eventListeners": 0,
"totalBlockingTimeMs": 303,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9171.154999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8288.289999999999,
"heapDeltaBytes": -2225660,
"heapUsedBytes": 80112376,
"domNodes": -14,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6625.664,
"eventListeners": 0,
"totalBlockingTimeMs": 245,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8647.063000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7787.282000000001,
"heapDeltaBytes": 18802640,
"heapUsedBytes": 93133356,
"domNodes": -4,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6148.017,
"eventListeners": 0,
"totalBlockingTimeMs": 109,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "large-graph-idle",
"durationMs": 2044.1119999999842,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.209999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.5369999999999,
"heapDeltaBytes": 1320628,
"heapUsedBytes": 82655292,
"domNodes": -250,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 33.742,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.6689999999462,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 556.5700000000002,
"heapDeltaBytes": 1644960,
"heapUsedBytes": 82639728,
"domNodes": -251,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 31.797000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2234.6430000000055,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.709,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1598.4180000000001,
"heapDeltaBytes": 16906584,
"heapUsedBytes": 80932892,
"domNodes": -253,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 826.534,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2188.769999999977,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1587.4730000000002,
"heapDeltaBytes": 20205860,
"heapUsedBytes": 84558304,
"domNodes": -249,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 798.865,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3506.7660000000274,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.609999999999998,
"layouts": 60,
"layoutDurationMs": 12.771,
"taskDurationMs": 1626.0380000000002,
"heapDeltaBytes": 7979424,
"heapUsedBytes": 74163920,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 747.432,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3527.0060000000285,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.237,
"layouts": 60,
"layoutDurationMs": 12.664000000000001,
"taskDurationMs": 1615.7389999999998,
"heapDeltaBytes": 8732992,
"heapUsedBytes": 74398256,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 750.0329999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3097.927000000027,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.2250000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1862.272,
"heapDeltaBytes": 23641044,
"heapUsedBytes": 89842408,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.831,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3058.265000000006,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.9,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1904.872,
"heapDeltaBytes": -9180456,
"heapUsedBytes": 75773296,
"domNodes": -226,
"jsHeapTotalBytes": 2088960,
"scriptDurationMs": 941.574,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8200000000343,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.784,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.3290000000001,
"heapDeltaBytes": -7344944,
"heapUsedBytes": 81704040,
"domNodes": -253,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 32.623,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2043.9380000000256,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.4810000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.6020000000001,
"heapDeltaBytes": -6396212,
"heapUsedBytes": 81972784,
"domNodes": -256,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 33.82800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.2920000000236,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.35600000000005,
"heapDeltaBytes": 13646544,
"heapUsedBytes": 77032936,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.937,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 572.6760000000013,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.087,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.522,
"heapDeltaBytes": 14621388,
"heapUsedBytes": 78314072,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 130.845,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.5919999999883,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.114999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.76899999999995,
"heapDeltaBytes": 17276280,
"heapUsedBytes": 80594140,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.554999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1999.371999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.824000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.811,
"heapDeltaBytes": 15400948,
"heapUsedBytes": 78850208,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.672999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.6729999999802,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.197,
"layouts": 18,
"layoutDurationMs": 4.841,
"taskDurationMs": 642.6460000000001,
"heapDeltaBytes": 17365204,
"heapUsedBytes": 80957520,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 89.957,
"eventListeners": -214,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.35299999995,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.599,
"layouts": 18,
"layoutDurationMs": 4.609,
"taskDurationMs": 751.857,
"heapDeltaBytes": 1057944,
"heapUsedBytes": 64693836,
"domNodes": -277,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 91.013,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.1730000000325,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.442,
"layouts": 5,
"layoutDurationMs": 10.721000000000002,
"taskDurationMs": 839.9450000000002,
"heapDeltaBytes": 20274924,
"heapUsedBytes": 103504456,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.173000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8270.627999999988,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.036,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5588.543000000001,
"heapDeltaBytes": -4780300,
"heapUsedBytes": 76368992,
"domNodes": -248,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 2616.953,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8241.933000000017,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.00499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5475.756,
"heapDeltaBytes": -5032892,
"heapUsedBytes": 75993492,
"domNodes": -249,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2580.669,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15225.644999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14748.699999999999,
"heapDeltaBytes": -57886940,
"heapUsedBytes": 173623844,
"domNodes": -8061,
"jsHeapTotalBytes": -5304320,
"scriptDurationMs": 228.385,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14650.933000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14321.475,
"heapDeltaBytes": -26552792,
"heapUsedBytes": 197576336,
"domNodes": -8061,
"jsHeapTotalBytes": -6676480,
"scriptDurationMs": 225.998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18215.77000000002,
"styleRecalcs": 135,
"styleRecalcDurationMs": 15.140000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17953.141000000003,
"heapDeltaBytes": -32277736,
"heapUsedBytes": 190359772,
"domNodes": -8061,
"jsHeapTotalBytes": -15515648,
"scriptDurationMs": 846.7059999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17829.934000000096,
"styleRecalcs": 139,
"styleRecalcDurationMs": 14.64299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17639.715,
"heapDeltaBytes": -48074508,
"heapUsedBytes": 168178812,
"domNodes": -8061,
"jsHeapTotalBytes": -15724544,
"scriptDurationMs": 812.5609999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4109.07800000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.93700000000003,
"layouts": 20,
"layoutDurationMs": 23.220000000000006,
"taskDurationMs": 3965.695,
"heapDeltaBytes": -23553220,
"heapUsedBytes": 192438772,
"domNodes": -8061,
"jsHeapTotalBytes": 9326592,
"scriptDurationMs": 80.563,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5304.287000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.30699999999999,
"layouts": 20,
"layoutDurationMs": 23.342000000000002,
"taskDurationMs": 5277.3820000000005,
"heapDeltaBytes": -27198960,
"heapUsedBytes": 196284128,
"domNodes": -8061,
"jsHeapTotalBytes": 12382208,
"scriptDurationMs": 93.79899999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 241,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7629.827999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7432.58,
"heapDeltaBytes": -22352192,
"heapUsedBytes": 163852416,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 137.16099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7449.994000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7305.217000000001,
"heapDeltaBytes": -7657800,
"heapUsedBytes": 174807988,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 120.81500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 104.520999999977,
"styleRecalcs": 9,
"styleRecalcDurationMs": 19.962,
"layouts": 4,
"layoutDurationMs": 1.7650000000000001,
"taskDurationMs": 85.33600000000003,
"heapDeltaBytes": 3329036,
"heapUsedBytes": 64818116,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.828000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 466.51199999996606,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.794,
"layouts": 4,
"layoutDurationMs": 2.015,
"taskDurationMs": 111.398,
"heapDeltaBytes": 5007420,
"heapUsedBytes": 66658352,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.844000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
A turn posted with a workflow_id the agent service will not serve to the caller's workspace comes back 403 "workflow not found or access denied". The tab -> workflow binding that produced that id is persisted, so the tab stayed wired to the dead workflow: every later turn from it re-posted the same id, and a reload re-affirmed the binding through the thread's own workflow pointer. Only opening a fresh tab escaped it. Release the binding (and the session's bound workflow) on that specific 403 so the next turn resolves the tab again. A thread-scoped 403 carries a different subject and leaves the binding alone.
c8289e2 to
62a7163
Compare
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/workbench/extensions/agent/schemas/agentApiSchema.ts:138— 🟢 Low — This matches only the flat{ error: '<exact literal>' }, butparseErrorBodycan also yield the nested ingest envelope{ error: { message } }thatgetErrorMessage/isIngestErrorBodyinagentRestClient.tsexplicitly support — that shape, or any server rewording, punctuation change, or localization, silently disables the release with no type error and no test failure. Discriminate on the already-normalized message (covering both shapes) or a stable machine-readable error code, and report unmatched 403s viareportError()so wording drift is observable. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18280 +/- ##
==========================================
+ Coverage 83.01% 83.99% +0.98%
==========================================
Files 2959 2262 -697
Lines 145950 128913 -17037
Branches 37646 32887 -4759
==========================================
- Hits 121163 108283 -12880
+ Misses 23515 20339 -3176
+ Partials 1272 291 -981
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 705 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Review of the previous commit surfaced three real races in the release path: - The release sat below the `generation !== loadGeneration` guard, but the binding store is page-global and persisted. A refusal landing after a mid-flight newChat()/loadThread() returned early and left the dead binding in place, which is the exact state this is meant to clear. - `unbind(tabPath)` removed whatever workflow occupied the path at that moment. agent_active_tab, reference navigation and commitWorkflowTarget all rebind a path without bumping the generation, so a late refusal could delete a newly bound, perfectly valid workflow. New store method `unbindWorkflow(id)` removes the named record wherever it now sits, and also covers the mirror case of a refused id that moved to another path. - Releasing the binding alone did not stop the next turn re-posting the id: `cloudIdFor` prefers the resolver's name-derived cloud index, and `refreshCloudWorkflowIds` swallows errors and races a 3s timeout. The session now reports the refused id through a `disowned` hook that evicts it from that index too. Attribution was also questioned, on the theory that workflow_references or open_tabs could trigger the same 403. They cannot: both go through resolveWorkflowContext, which drops or marks unavailable entries and never fails the turn. Only req.WorkflowID produces this refusal, so the turn's own workflow id is the correct and only attribution.
Backports [frontend PR 18280](#18280) to Cloud 1.54. - Parent-red/head-green target units proven. - Focused unit, lint, format, and typechecks green. - Hold: exact-head hosted browser result and non-author review remain open. <details><summary>Full context for agent readers</summary> Source merge: [36b1f0e](36b1f0e). The release branch predates main's send-path helper refactor, so this carrier preserves Cloud 1.54's inline send, billing, draft, and navigation behavior. It adds only the specific workflow-403 release path: remove the refused ID from persisted tab bindings, resolver cache, and session memory without disturbing a newer binding for the same tab. Evidence at head a4c4089: - Parent with target-native units: 4 failures, 108 passed, 2 expected failures. - Head units: 112 passed, 2 expected failures. - Frontend and browser vue-tsc checks: passed. - ESLint on all changed files: passed. - oxfmt check on all changed files: passed. - Target merge: cloud/1.54 at 3310bb4 merged without conflicts. - Added a mocked Cloud browser path that saves and binds a workflow, receives the exact workflow-scoped 403, reloads, and proves the retry omits the refused workflow ID. - Hosted Cloud Playwright at prior head `48f8a3b904` reached the new case but timed out because reload persisted the already-open Agent panel while the test waited for the absent launcher button. Head `a4c4089538` removes that redundant click; fresh hosted execution is required. - Local Playwright execution is not acceptance evidence: this checkout's existing Agent workflow-selection case and the new case both stop before their bodies because the local Cloud app does not expose the Agent launcher. Still required before merge: terminal hosted checks including the new browser case, authenticated workflow edit/persist/reload acceptance with visibly populated widgets and retained edited prompt, non-author review or honest COMMENT disposition under release authority, no unresolved human objection, and target-aware merge guard. Served-environment acceptance and the server-side cause of disownership remain separate. </details>
Requested by Christian Byrne · Slack thread
Summary
Before: once the agent service refuses a turn's
workflow_idwith403 {"error":"workflow not found or access denied"}, the tab that produced that id is broken permanently. Every later message from that tab posts the same dead id and fails the same way, and reloading the page does not help. The only escape is opening a brand new workflow tab. This is what a user hit after completing the subscribe flow: credits landed, the prompt never ran, and re-sending in the same tab kept failing with "Message failed to send: workflow not found or access denied".After: that refusal releases the tab's workflow binding and the session's bound workflow instead of keeping them. The failed send still reports the failure, and the next send from the same tab resolves the tab again rather than re-posting an id the server has already rejected. No new tab needed.
Changes
useAgentSession's send-failure path now recognises the workflow-scoped 403 and callsbindingStore.unbind()for the tab the turn was posted from, clearingboundWorkflowIdand the page-lifetime remembered workflow when they name the same id. AzDisownedWorkflowErrorschema sits next tozAgentAdmissionErrorand matches that one body.Review Focus
The mechanism, and the limits of what is proven here.
The tab → workflow binding lives in
localStorage, and the thread carries its own server-side workflow pointer, so the bad state is doubly persistent:onWorkflowRestored()re-affirms the binding from the thread's pointer on every boot, which is why a refresh does not clear it. Nothing in the client ever treated a server refusal as evidence that the binding is dead. That is the divergence this fixes, and it is the reason a recoverable one-off becomes a permanently broken tab. It is the same family as #18077 (fresh tab inherits a stale binding) and #18196 (new chat inherits a stale target), one layer further out.What this does not prove is why the workflow becomes unservable around the subscribe round trip. The backend collapses two cases into one message (the row is gone, or it belongs to another workspace), deliberately, so the response cannot tell them apart. Confirming which one it is needs a live repro with a network capture plus the server-side log line for the rejected
workflow_id; until then this is a fix for the persistence of the failure, not for its trigger. Worth noting the thread itself passes its own workspace check in the same handler, so whatever happens, it separates the thread from its workflow rather than moving both.Discrimination is by response body, because a 403 refusing the thread or the message has the same shape with a different subject; the regression test pins both directions so a thread-scoped refusal cannot start eating workflow bindings.
Testing
pnpm vitest run src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts— the new(k2)table-driven case was committed red first (binding survived the workflow-scoped 403) and goes green with the fix; the thread-scoped row passed in both states.pnpm vitest run src/workbench/extensions/agent— 121 files, 1868 passed.pnpm typecheckclean,pnpm lint0 errors (warnings all pre-existing),pnpm knipclean,pnpm formatapplied.Not exercised against a live checkout round trip; no browser test added, since the behaviour under test is a client-side reaction to one HTTP response and the composable is the lowest level that proves it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GNFfTjWvYLP9CZ1udGpjdA
Generated by Claude Code