Repository navigation
[backport cloud/1.54] Release disowned Agent workflow bindings - #18346
Conversation
Backport #18280 to cloud/1.54 while preserving the release branch's inline send path.
…/backport-18280-cloud-154
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1962 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-28T05:10:31.626Z",
"gitSha": "70d12e5e6ad1ab21ff1450f12b55015e03566f96",
"branch": "christian-byrne/backport-18280-cloud-154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2086.6720000000214,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.130000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.55299999999994,
"heapDeltaBytes": 6836920,
"heapUsedBytes": 77696928,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.708999999999996,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2034.1210000000274,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.4079999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.944,
"heapDeltaBytes": -11030808,
"heapUsedBytes": 59173584,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.237999999999998,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1741.0460000000398,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.675,
"layouts": 14,
"layoutDurationMs": 2.5,
"taskDurationMs": 600.392,
"heapDeltaBytes": -8440468,
"heapUsedBytes": 61475932,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 98.9,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1688.0149999999503,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.186,
"layouts": 14,
"layoutDurationMs": 2.5669999999999997,
"taskDurationMs": 590.1030000000001,
"heapDeltaBytes": 24205440,
"heapUsedBytes": 89188216,
"domNodes": 39,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 98.54299999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.7889999999802,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.898,
"layouts": 6,
"layoutDurationMs": 1.0070000000000001,
"taskDurationMs": 249.252,
"heapDeltaBytes": 4841660,
"heapUsedBytes": 76033072,
"domNodes": 80,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8.459,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1673.7090000000308,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.049999999999999,
"layouts": 6,
"layoutDurationMs": 1.0330000000000001,
"taskDurationMs": 275.653,
"heapDeltaBytes": 4593128,
"heapUsedBytes": 75914104,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.483,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 496.85299999998733,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.071,
"heapDeltaBytes": 18984204,
"heapUsedBytes": 89202344,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 98.266,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 534.9310000000287,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.887999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.156,
"heapDeltaBytes": -7874572,
"heapUsedBytes": 63249320,
"domNodes": 22,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 113.41999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2013.261,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.136999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.188,
"heapDeltaBytes": 10826576,
"heapUsedBytes": 86405752,
"domNodes": -264,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 22.949000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2029.8649999999725,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.645,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.249,
"heapDeltaBytes": 6163108,
"heapUsedBytes": 85696580,
"domNodes": -264,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 27.067000000000007,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.805000000037,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.794999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1036.079,
"heapDeltaBytes": 3388808,
"heapUsedBytes": 80739412,
"domNodes": -276,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 461.57900000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2178.7140000000136,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1132.985,
"heapDeltaBytes": -7036296,
"heapUsedBytes": 70492628,
"domNodes": -245,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 521.981,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3105.6389999999965,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.104999999999999,
"layouts": 60,
"layoutDurationMs": 8.487,
"taskDurationMs": 1151.286,
"heapDeltaBytes": -12149852,
"heapUsedBytes": 66650336,
"domNodes": 14,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 474.018,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3088.8650000000553,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.306999999999999,
"layouts": 60,
"layoutDurationMs": 11.402,
"taskDurationMs": 1204.8719999999998,
"heapDeltaBytes": 9186872,
"heapUsedBytes": 76428788,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 519.107,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2252.494000000013,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.475999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1251.77,
"heapDeltaBytes": 3825308,
"heapUsedBytes": 85353692,
"domNodes": -248,
"jsHeapTotalBytes": 577536,
"scriptDurationMs": 585.441,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2139.0709999999444,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.16,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1317.7179999999998,
"heapDeltaBytes": -11809048,
"heapUsedBytes": 71674400,
"domNodes": -239,
"jsHeapTotalBytes": 159744,
"scriptDurationMs": 598.176,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.0019999999909,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.0489999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.74700000000007,
"heapDeltaBytes": 8612604,
"heapUsedBytes": 87235652,
"domNodes": -274,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 28.839000000000002,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.7420000000502,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.884,
"heapDeltaBytes": 22116504,
"heapUsedBytes": 88196216,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.566999999999993,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.7230000000004,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.069000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.83099999999996,
"heapDeltaBytes": 14810084,
"heapUsedBytes": 88200648,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 80.61,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.01100000001225,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.214999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 271.88800000000003,
"heapDeltaBytes": 15142620,
"heapUsedBytes": 88596468,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 85.195,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.4400000000214,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.566,
"heapDeltaBytes": -8118588,
"heapUsedBytes": 65158736,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 5.539000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2000.3659999999854,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.364,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.834,
"heapDeltaBytes": 9196124,
"heapUsedBytes": 82236128,
"domNodes": -293,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.040999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.923000000017,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.441999999999998,
"layouts": 18,
"layoutDurationMs": 2.514,
"taskDurationMs": 556.334,
"heapDeltaBytes": -9082736,
"heapUsedBytes": 64519760,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 62.21600000000001,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.2739999999503,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.328000000000003,
"layouts": 18,
"layoutDurationMs": 2.9450000000000003,
"taskDurationMs": 548.357,
"heapDeltaBytes": -7380724,
"heapUsedBytes": 65136748,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 63.004000000000005,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 849.4460000000572,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.938,
"layouts": 16,
"layoutDurationMs": 9.317,
"taskDurationMs": 605.056,
"heapDeltaBytes": -3272564,
"heapUsedBytes": 85378620,
"domNodes": 13831,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 20.907999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 89,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8102.224999999976,
"styleRecalcs": 249,
"styleRecalcDurationMs": 20.083999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3556.076,
"heapDeltaBytes": 24949492,
"heapUsedBytes": 90571804,
"domNodes": -267,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 1564.3780000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8127.076999999986,
"styleRecalcs": 248,
"styleRecalcDurationMs": 29.427999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3949.8360000000002,
"heapDeltaBytes": -11856844,
"heapUsedBytes": 92028072,
"domNodes": -268,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 1771.353,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10739.784999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9908.939,
"heapDeltaBytes": -50558688,
"heapUsedBytes": 184042480,
"domNodes": -8068,
"jsHeapTotalBytes": -9900032,
"scriptDurationMs": 143.724,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11973.355999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11141.28,
"heapDeltaBytes": -61910084,
"heapUsedBytes": 177008996,
"domNodes": -8068,
"jsHeapTotalBytes": -22720512,
"scriptDurationMs": 190.92000000000002,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13827.951999999983,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.071,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13261.858999999999,
"heapDeltaBytes": -51752576,
"heapUsedBytes": 166405108,
"domNodes": -8068,
"jsHeapTotalBytes": -12054528,
"scriptDurationMs": 689.083,
"eventListeners": -14929,
"totalBlockingTimeMs": 18,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14535.491999999977,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.702999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13881.582999999999,
"heapDeltaBytes": -45781384,
"heapUsedBytes": 166683512,
"domNodes": -8068,
"jsHeapTotalBytes": -21409792,
"scriptDurationMs": 708.075,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3989.1399999999635,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.32400000000001,
"layouts": 20,
"layoutDurationMs": 20.862000000000005,
"taskDurationMs": 3849.64,
"heapDeltaBytes": -32214088,
"heapUsedBytes": 180437136,
"domNodes": -8068,
"jsHeapTotalBytes": 7139328,
"scriptDurationMs": 60.91699999999999,
"eventListeners": -14933,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4107.543999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.55600000000002,
"layouts": 20,
"layoutDurationMs": 21.359,
"taskDurationMs": 4005.6660000000006,
"heapDeltaBytes": -22041380,
"heapUsedBytes": 184402836,
"domNodes": -8068,
"jsHeapTotalBytes": 12402688,
"scriptDurationMs": 66.95700000000001,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5554.503999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5272.7970000000005,
"heapDeltaBytes": 5849120,
"heapUsedBytes": 176998716,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 111.21700000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6254.286999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5740.928999999999,
"heapDeltaBytes": 4773684,
"heapUsedBytes": 179905588,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 86.80100000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 421.0769999999684,
"styleRecalcs": 19,
"styleRecalcDurationMs": 17.000999999999998,
"layouts": 4,
"layoutDurationMs": 1.541,
"taskDurationMs": 85.94699999999999,
"heapDeltaBytes": 5033320,
"heapUsedBytes": 73968436,
"domNodes": 149,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.439,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 92.58599999998296,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.070000000000002,
"layouts": 2,
"layoutDurationMs": 1.374,
"taskDurationMs": 57.92699999999999,
"heapDeltaBytes": 3000724,
"heapUsedBytes": 71651640,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.002999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
…/backport-18280-cloud-154
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18346 +/- ##
=============================================
Coverage ? 83.97%
=============================================
Files ? 2117
Lines ? 126308
Branches ? 32809
=============================================
Hits ? 106071
Misses ? 20060
Partials ? 177
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
Blocked — and I am deliberately not resolving this one myself. State: DIRTY against Why I stopped at the rebase. Merging
This is also not a clean cherry-pick of #18280 — it carries two hand-written test commits ( Needs whoever wrote it to resolve, or an explicit decision on |
## Summary Backports the user-visible delete-all recovery from #18404 (`db5e105e9af91fe1fea22e25795edf62a7e285e9`) to `cloud/1.54`. The retry clears a stale canvas after workflow scope returns without requiring another agent frame. This target deliberately keeps its release-native numeric link handling and the deletions of `agentCrdtProjection.ts`, `followerSubscription.test.ts`, `agentCrdtReconcileOverwrite.spec.ts`, and `agentTabSwitchRunSubmission.spec.ts`; those old reconciliation surfaces are not resurrected. The new `agentDeleteAndClearWorkflow.spec.ts` and its fixture support are carried. ## Verification - `NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/ecsFollowerAdapter.integration.test.ts src/workbench/extensions/agent/crdt/graphMutations.test.ts` — 144 passed, 3 pre-existing expected failures - app and browser `vue-tsc` — passed - oxfmt, type-aware oxlint, eslint, commit hooks — passed - local Cloud Playwright reaches the release app but the Agent launcher is absent, matching the known `cloud/1.54` local-harness limitation recorded by #18346; hosted Cloud Playwright is required for browser acceptance and the pre-clear assertion mutation check - no AI co-author trailer ## Source - Source PR: #18404 - Source merge: `db5e105e9af91fe1fea22e25795edf62a7e285e9` - Failed automation: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36399580042 ## Merge conditions Do not merge until hosted checks, the focused Cloud browser case (including mutation evidence for the pre-clear canvas assertion), target-aware exact-head gate, and review disposition are current at this head. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org>
Backports frontend PR 18280 to Cloud 1.54.
Full context for agent readers
Source merge: 36b1f0ec.
The release branch predates main's send-path helper refactor, so this carrier preserves Cloud 1.54's inline send, billing, draft, and navigation behavior. It adds only the specific workflow-403 release path: remove the refused ID from persisted tab bindings, resolver cache, and session memory without disturbing a newer binding for the same tab.
Evidence at head a4c4089:
48f8a3b904reached the new case but timed out because reload persisted the already-open Agent panel while the test waited for the absent launcher button. Heada4c4089538removes that redundant click; fresh hosted execution is required.Still required before merge: terminal hosted checks including the new browser case, authenticated workflow edit/persist/reload acceptance with visibly populated widgets and retained edited prompt, non-author review or honest COMMENT disposition under release authority, no unresolved human objection, and target-aware merge guard. Served-environment acceptance and the server-side cause of disownership remain separate.