Skip to content

[backport cloud/1.54] adopt multiplayer 0.3.2 - #18304

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18270-to-cloud-1.54
Sep 21, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18270-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor
  • Removes the cloud/1.54 multiplayer skew.
  • Moves directly from 0.2.1 to 0.3.2.
  • Focused tests and typecheck pass.
Full context for agent readers

Backports the multiplayer 0.3.0 adoption from #18163 and the 0.3.2 promoted-widget fix from #18270 directly to cloud/1.54, avoiding an obsolete intermediate carrier.

Changes

  • What: Pins @comfyorg/comfy-multi-player 0.3.2, carries the current operation-envelope fixture repair, and adds the real-package insert_workflow promoted-widget regression.
  • Dependencies: @comfyorg/comfy-multi-player 0.2.1 → 0.3.2.

Review focus

Confirm the release branch should move directly to 0.3.2 and retain both source PRs' regression coverage.

Verification

  • Frozen install and supply-chain policy check passed.
  • Focused Vitest: 3 passed.
  • pnpm typecheck passed.
  • Oxfmt and type-aware Oxlint passed on changed files.

Backport of #18163 and #18270.

@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 21, 2026
@christian-byrne christian-byrne self-assigned this Sep 21, 2026
@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 21, 2026 8:54pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2912a1a6-c2bd-4c43-a349-9fcb213a35fc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1931 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1910 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/21/2026, 08:56:32 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.2 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 67ms TBT · 80.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.5 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 46ms TBT · 176.7 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 33ms TBT · 169.3 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 175.3 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 397ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.2 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -195
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 712ms
canvas-mouse-sweep: script duration 121ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.0 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -193
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 14ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 270ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.1 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 342ms
dom-widget-clipping: script duration 116ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.8 MB
dom-widget-clipping: DOM nodes 22
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 409ms
large-graph-idle: script duration 27ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.6 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -176
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 15ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1195ms
large-graph-pan: script duration 555ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.7 MB
large-graph-pan: DOM nodes -241
large-graph-pan: event listeners -190
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1258ms
large-graph-zoom: script duration 542ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.8 MB
large-graph-zoom: DOM nodes -141
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 10ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 47
legacy-node-drag: task duration 1443ms
legacy-node-drag: script duration 673ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 71.9 MB
legacy-node-drag: DOM nodes -245
legacy-node-drag: event listeners -10
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 410ms
minimap-idle: script duration 26ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.8 MB
minimap-idle: DOM nodes -134
minimap-idle: event listeners -94
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 298ms
subgraph-dom-widget-clipping: script duration 97ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 342ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -242
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 655ms
subgraph-mouse-sweep: script duration 93ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.8 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -239
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 11ms
subgraph-transition-enter: style recalc duration 23ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 588ms
subgraph-transition-enter: script duration 19ms
subgraph-transition-enter: TBT 67ms
subgraph-transition-enter: heap used 80.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4425ms
viewport-pan-sweep: script duration 2010ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 87.5 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11832ms
vue-large-graph-idle: script duration 190ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 77
vue-large-graph-pan: task duration 14503ms
vue-large-graph-pan: script duration 674ms
vue-large-graph-pan: TBT 46ms
vue-large-graph-pan: heap used 176.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 54ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4377ms
vue-node-resize-workload: script duration 74ms
vue-node-resize-workload: TBT 33ms
vue-node-resize-workload: heap used 169.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14931
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5989ms
vue-zoom-out-idle: script duration 89ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 175.3 MB
vue-zoom-out-idle: DOM nodes -2
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 3
workflow-execution: style recalc count 12
workflow-execution: task duration 68ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.8 MB
workflow-execution: DOM nodes 136
workflow-execution: event listeners 41
Raw data
{
  "timestamp": "2026-09-21T21:03:48.531Z",
  "gitSha": "9d31bcfbf97b3a645b70c06870f91edaf56c79b3",
  "branch": "backport-18270-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2088.5600000000013,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.231,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 464.55600000000004,
      "heapDeltaBytes": -7497264,
      "heapUsedBytes": 63441420,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 11.048000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2002.1090000000186,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.02,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 328.515,
      "heapDeltaBytes": -11781060,
      "heapUsedBytes": 58628696,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 6.909,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1848.5089999999786,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.186,
      "layouts": 14,
      "layoutDurationMs": 4.774,
      "taskDurationMs": 809.444,
      "heapDeltaBytes": -3954156,
      "heapUsedBytes": 66697220,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 138.032,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1704.119999999989,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.536999999999995,
      "layouts": 14,
      "layoutDurationMs": 4.095,
      "taskDurationMs": 613.6510000000001,
      "heapDeltaBytes": -6485216,
      "heapUsedBytes": 63373160,
      "domNodes": -277,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 104.38,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1657.9569999999535,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.578,
      "layouts": 6,
      "layoutDurationMs": 1.0579999999999998,
      "taskDurationMs": 271.574,
      "heapDeltaBytes": 4347512,
      "heapUsedBytes": 73981016,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.284999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.931999999998,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 14.973000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1190000000000002,
      "taskDurationMs": 267.56600000000003,
      "heapDeltaBytes": 4640408,
      "heapUsedBytes": 75146480,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.024000000000001,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 528.5749999999894,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.075999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 349.992,
      "heapDeltaBytes": -7827152,
      "heapUsedBytes": 62759676,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 117.46099999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 536.4839999999731,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 8.934,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 334.966,
      "heapDeltaBytes": 17805824,
      "heapUsedBytes": 87847404,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 115.122,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2058.696999999995,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.023,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.079,
      "heapDeltaBytes": 7760840,
      "heapUsedBytes": 83891204,
      "domNodes": -271,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 30.616999999999997,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2010.953000000029,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.356999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 362.47,
      "heapDeltaBytes": 10944036,
      "heapUsedBytes": 87319356,
      "domNodes": -269,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 23.395,
      "eventListeners": -160,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2248.151000000007,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.577000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1191.0210000000002,
      "heapDeltaBytes": 5075888,
      "heapUsedBytes": 81796628,
      "domNodes": -243,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 555.838,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2295.0850000000287,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 15.613,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1198.27,
      "heapDeltaBytes": 1029048,
      "heapUsedBytes": 81207316,
      "domNodes": -239,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 554.5420000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3267.5199999999904,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.153,
      "layouts": 60,
      "layoutDurationMs": 13.325999999999999,
      "taskDurationMs": 1252.292,
      "heapDeltaBytes": 803544,
      "heapUsedBytes": 79582720,
      "domNodes": -287,
      "jsHeapTotalBytes": 3563520,
      "scriptDurationMs": 532.045,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3485.2260000000115,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.77,
      "layouts": 60,
      "layoutDurationMs": 13.506,
      "taskDurationMs": 1263.6970000000001,
      "heapDeltaBytes": 8936652,
      "heapUsedBytes": 77222108,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 552.921,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2369.944999999973,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.799999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1406.291,
      "heapDeltaBytes": -7527608,
      "heapUsedBytes": 72154604,
      "domNodes": -243,
      "jsHeapTotalBytes": -630784,
      "scriptDurationMs": 648.895,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2570.664000000022,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.075000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1479.0949999999998,
      "heapDeltaBytes": -1113584,
      "heapUsedBytes": 78664412,
      "domNodes": -247,
      "jsHeapTotalBytes": -737280,
      "scriptDurationMs": 696.449,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.5440000000062,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.562000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.865,
      "heapDeltaBytes": 6637180,
      "heapUsedBytes": 83150844,
      "domNodes": -275,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 23.593999999999998,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 1993.5760000000187,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.151000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 415.269,
      "heapDeltaBytes": 21768420,
      "heapUsedBytes": 88393872,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 28.950999999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 447.8599999999915,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.933000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 293.06,
      "heapDeltaBytes": 13951068,
      "heapUsedBytes": 86582940,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 95.592,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 528.9180000000329,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.87,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 302.131,
      "heapDeltaBytes": 14785612,
      "heapUsedBytes": 87945048,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 98.206,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.534000000021,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.297,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 356.53999999999996,
      "heapDeltaBytes": -6939944,
      "heapUsedBytes": 65083376,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.984000000000002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.6630000000168,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.454999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.488,
      "heapDeltaBytes": -6903948,
      "heapUsedBytes": 65391180,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.770999999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1701.7740000000003,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.452999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.112,
      "taskDurationMs": 655.478,
      "heapDeltaBytes": 1257304,
      "heapUsedBytes": 73551272,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 90.88300000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.9079999999844,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 27.493999999999996,
      "layouts": 18,
      "layoutDurationMs": 6.305,
      "taskDurationMs": 654.6139999999999,
      "heapDeltaBytes": -7622864,
      "heapUsedBytes": 64386144,
      "domNodes": -295,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 95.21800000000002,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 816.7409999999791,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 23.181999999999995,
      "layouts": 17,
      "layoutDurationMs": 11.444,
      "taskDurationMs": 588.0719999999999,
      "heapDeltaBytes": -7277048,
      "heapUsedBytes": 84522524,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 19.031,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 67,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8741.197999999997,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.567,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4420.67,
      "heapDeltaBytes": 15110660,
      "heapUsedBytes": 91788028,
      "domNodes": -267,
      "jsHeapTotalBytes": -1716224,
      "scriptDurationMs": 2014.9869999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9148.247000000027,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 41.602,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4429.749,
      "heapDeltaBytes": -11590032,
      "heapUsedBytes": 91628176,
      "domNodes": -268,
      "jsHeapTotalBytes": 155648,
      "scriptDurationMs": 2005.487,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12452.782000000014,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11533.721,
      "heapDeltaBytes": -40836744,
      "heapUsedBytes": 176274788,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13627392,
      "scriptDurationMs": 192.953,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12711.368999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12130.747,
      "heapDeltaBytes": -63129820,
      "heapUsedBytes": 178938280,
      "domNodes": -8068,
      "jsHeapTotalBytes": -24408064,
      "scriptDurationMs": 186.405,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14778.542000000016,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 14.046000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14244.385999999999,
      "heapDeltaBytes": -26791156,
      "heapUsedBytes": 185903296,
      "domNodes": -8068,
      "jsHeapTotalBytes": -3727360,
      "scriptDurationMs": 625.892,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 35,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15112.916999999925,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 15.743000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14761.914999999999,
      "heapDeltaBytes": -34032780,
      "heapUsedBytes": 184694124,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12664832,
      "scriptDurationMs": 723.053,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 56,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4360.90200000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 53.70699999999998,
      "layouts": 20,
      "layoutDurationMs": 21.177,
      "taskDurationMs": 4275.0380000000005,
      "heapDeltaBytes": -33596768,
      "heapUsedBytes": 184568504,
      "domNodes": -8068,
      "jsHeapTotalBytes": 20987904,
      "scriptDurationMs": 67.99,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4576.53700000003,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.538000000000004,
      "layouts": 20,
      "layoutDurationMs": 22.611000000000008,
      "taskDurationMs": 4479.589000000001,
      "heapDeltaBytes": -63609396,
      "heapUsedBytes": 170572576,
      "domNodes": -8068,
      "jsHeapTotalBytes": 14479360,
      "scriptDurationMs": 79.223,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 48,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6268.013000000054,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5846.373,
      "heapDeltaBytes": 8722272,
      "heapUsedBytes": 183837140,
      "domNodes": 0,
      "jsHeapTotalBytes": -17563648,
      "scriptDurationMs": 87.37800000000001,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6391.471999999908,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6132.398999999999,
      "heapDeltaBytes": -1599916,
      "heapUsedBytes": 183694528,
      "domNodes": -3,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 91.13100000000001,
      "eventListeners": -11,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 436.9869999999878,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 17.549,
      "layouts": 5,
      "layoutDurationMs": 1.78,
      "taskDurationMs": 88.218,
      "heapDeltaBytes": 5053696,
      "heapUsedBytes": 74293780,
      "domNodes": 149,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.443000000000001,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 78.89700000009725,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 10.034999999999998,
      "layouts": 1,
      "layoutDurationMs": 0.7679999999999998,
      "taskDurationMs": 46.85400000000002,
      "heapDeltaBytes": 2936476,
      "heapUsedBytes": 72007108,
      "domNodes": 123,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 3.3279999999999994,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50311 75334 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​comfyorg/​comfy-multi-player@​0.2.1 ⏵ 0.3.2100 +18100100 +195 +270

View full report

@github-actions
github-actions Bot requested a review from huang47 September 21, 2026 20:55
@codecov

codecov Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18304   +/-   ##
=============================================
  Coverage              ?   82.06%           
=============================================
  Files                 ?     2524           
  Lines                 ?   131294           
  Branches              ?    35274           
=============================================
  Hits                  ?   107743           
  Misses                ?    23038           
  Partials              ?      513           
Flag Coverage Δ
e2e 66.79% <ø> (?)
unit 78.49% <ø> (?)
website-unit 57.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 19a4f18 into cloud/1.54 Sep 21, 2026
104 of 107 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18270-to-cloud-1.54 branch September 21, 2026 21:22
CodeJuggernaut added a commit that referenced this pull request Sep 23, 2026
Backport adaptation: test-only.

The #18063 carrier's race test mints its ops by hand with the
three-part stamp of comfy-multi-player 0.2.1. core/1.54 runs 0.3.6,
whose applyOps rejects that stamp as malformed_op, so two cases failed
during setup. Cloud made the same fix when it adopted 0.3.2 (#18304):
the test now mints through the runtime's mintWireOps.

This takes main's file, which is byte-identical to cloud's after
#18304. No runtime file changes, and #18304 changed none of the
carrier's runtime code either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants