Repository navigation
[backport cloud/1.54] fix: stop dropping a later completed download after a premature failed status (PM-1302) - #18208
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1930 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-21T02:31:55.773Z",
"gitSha": "34033ee25ad2956dc0878fe62f6da8d123baeae6",
"branch": "backport-18082-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.0779999999845,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.062,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.36800000000005,
"heapDeltaBytes": 11396832,
"heapUsedBytes": 81989620,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.729000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2044.2920000000413,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.385,
"heapDeltaBytes": 5146340,
"heapUsedBytes": 76036468,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.802999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2084.9919999999997,
"styleRecalcs": 79,
"styleRecalcDurationMs": 35.812,
"layouts": 14,
"layoutDurationMs": 4.879,
"taskDurationMs": 1010.553,
"heapDeltaBytes": -5236804,
"heapUsedBytes": 64305144,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 185.57800000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1782.8719999999976,
"styleRecalcs": 73,
"styleRecalcDurationMs": 26.450000000000003,
"layouts": 14,
"layoutDurationMs": 4.039,
"taskDurationMs": 870.2690000000001,
"heapDeltaBytes": -2802372,
"heapUsedBytes": 67879908,
"domNodes": -276,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 158.091,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.9579999999683,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.7,
"layouts": 6,
"layoutDurationMs": 1.2730000000000001,
"taskDurationMs": 383.088,
"heapDeltaBytes": 4365056,
"heapUsedBytes": 73917600,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.758000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.8030000000308,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.974000000000004,
"layouts": 6,
"layoutDurationMs": 1.1920000000000002,
"taskDurationMs": 362.57099999999997,
"heapDeltaBytes": 4716444,
"heapUsedBytes": 75703764,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.839000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.3840000000082,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.877,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.147,
"heapDeltaBytes": 17811344,
"heapUsedBytes": 87923804,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 173.586,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 648.7379999999803,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.866,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.892,
"heapDeltaBytes": 18089696,
"heapUsedBytes": 88111316,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.676,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.7560000000117,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.148999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.0029999999999,
"heapDeltaBytes": 5146340,
"heapUsedBytes": 80969276,
"domNodes": -282,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 33.63000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.8259999999955,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.6480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.112,
"heapDeltaBytes": 6298228,
"heapUsedBytes": 82418540,
"domNodes": -278,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 34.136,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2299.901000000034,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.984000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1595.1060000000002,
"heapDeltaBytes": 22279388,
"heapUsedBytes": 88706396,
"domNodes": -275,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 800.57,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2289.677000000097,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.444,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1704.413,
"heapDeltaBytes": 7897532,
"heapUsedBytes": 85074328,
"domNodes": -249,
"jsHeapTotalBytes": 380928,
"scriptDurationMs": 847.744,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3584.382000000005,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.621000000000002,
"layouts": 60,
"layoutDurationMs": 11.727000000000002,
"taskDurationMs": 1719.0629999999999,
"heapDeltaBytes": 10378040,
"heapUsedBytes": 75786344,
"domNodes": -283,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.528,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3504.44600000003,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.420000000000002,
"layouts": 60,
"layoutDurationMs": 11.264,
"taskDurationMs": 1682.801,
"heapDeltaBytes": 9885796,
"heapUsedBytes": 76781052,
"domNodes": -281,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 763.974,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3011.4920000000325,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.5950000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1917.2939999999999,
"heapDeltaBytes": 23883444,
"heapUsedBytes": 93945884,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 957.7789999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3092.6359999999704,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1947.3930000000003,
"heapDeltaBytes": 8430624,
"heapUsedBytes": 88925748,
"domNodes": -280,
"jsHeapTotalBytes": -737280,
"scriptDurationMs": 933.577,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.2269999999862,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.1009999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.148,
"heapDeltaBytes": 21848992,
"heapUsedBytes": 87666996,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.748000000000005,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2060.05899999991,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.049000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.1059999999999,
"heapDeltaBytes": 5889476,
"heapUsedBytes": 83025124,
"domNodes": -285,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 36.15,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4119999999775,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.748,
"heapDeltaBytes": 14506388,
"heapUsedBytes": 86826328,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.988,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.0740000000351,
"styleRecalcs": 48,
"styleRecalcDurationMs": 14.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.59600000000006,
"heapDeltaBytes": 14294076,
"heapUsedBytes": 86294320,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.721,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.1690000000135,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.523999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.3190000000001,
"heapDeltaBytes": -4784124,
"heapUsedBytes": 68338596,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 7.949000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.574000000016,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.80800000000005,
"heapDeltaBytes": 4706040,
"heapUsedBytes": 77223324,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.362,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3649999999775,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.984999999999996,
"layouts": 18,
"layoutDurationMs": 4.898,
"taskDurationMs": 804.6880000000001,
"heapDeltaBytes": -5287476,
"heapUsedBytes": 67795212,
"domNodes": -294,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 111.622,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.7759999999917,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.48,
"layouts": 18,
"layoutDurationMs": 4.775,
"taskDurationMs": 810.42,
"heapDeltaBytes": -14496024,
"heapUsedBytes": 58279752,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 106.94200000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3619999999687,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.97,
"layouts": 14,
"layoutDurationMs": 16.046000000000003,
"taskDurationMs": 924.493,
"heapDeltaBytes": 21973080,
"heapUsedBytes": 105974644,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 29.483,
"eventListeners": 2387,
"totalBlockingTimeMs": 146,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8619.943999999976,
"styleRecalcs": 246,
"styleRecalcDurationMs": 32.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5810.703,
"heapDeltaBytes": 19213340,
"heapUsedBytes": 84881076,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2669.5930000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8540.489999999976,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.626000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5876.923,
"heapDeltaBytes": -6540704,
"heapUsedBytes": 69692068,
"domNodes": -248,
"jsHeapTotalBytes": 2777088,
"scriptDurationMs": 2762.487,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17001.332999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16570.548,
"heapDeltaBytes": -40135832,
"heapUsedBytes": 177567656,
"domNodes": -8072,
"jsHeapTotalBytes": -9207808,
"scriptDurationMs": 269.5690000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16887.19400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16428.357000000004,
"heapDeltaBytes": -55524552,
"heapUsedBytes": 182760764,
"domNodes": -8068,
"jsHeapTotalBytes": -12759040,
"scriptDurationMs": 272.256,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20416.44199999996,
"styleRecalcs": 162,
"styleRecalcDurationMs": 16.633999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19966.887,
"heapDeltaBytes": -39497572,
"heapUsedBytes": 192709276,
"domNodes": -8068,
"jsHeapTotalBytes": -19402752,
"scriptDurationMs": 954.848,
"eventListeners": -14929,
"totalBlockingTimeMs": 107,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20699.08499999997,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.46199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20368.559,
"heapDeltaBytes": -34139264,
"heapUsedBytes": 192391928,
"domNodes": -8068,
"jsHeapTotalBytes": -17854464,
"scriptDurationMs": 903.7040000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6090.01900000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.52500000000002,
"layouts": 20,
"layoutDurationMs": 23.048,
"taskDurationMs": 5958.693000000001,
"heapDeltaBytes": -38868028,
"heapUsedBytes": 178684348,
"domNodes": -8068,
"jsHeapTotalBytes": 12099584,
"scriptDurationMs": 103.926,
"eventListeners": -14929,
"totalBlockingTimeMs": 381,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6150.3459999998995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 89.66499999999999,
"layouts": 20,
"layoutDurationMs": 22.705000000000002,
"taskDurationMs": 6008.324999999999,
"heapDeltaBytes": -41762076,
"heapUsedBytes": 177135752,
"domNodes": -8068,
"jsHeapTotalBytes": 10100736,
"scriptDurationMs": 104.88600000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 574,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8423.715000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8248.463999999998,
"heapDeltaBytes": 4924048,
"heapUsedBytes": 178173776,
"domNodes": -3,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 130.722,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8490.363000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8296.198999999999,
"heapDeltaBytes": -120528,
"heapUsedBytes": 178136156,
"domNodes": 0,
"jsHeapTotalBytes": -20185088,
"scriptDurationMs": 142.52600000000004,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.55799999998226,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.809,
"layouts": 2,
"layoutDurationMs": 0.51,
"taskDurationMs": 103.52900000000001,
"heapDeltaBytes": 4779656,
"heapUsedBytes": 73756900,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.852999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 437.8480000000309,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.849000000000004,
"layouts": 3,
"layoutDurationMs": 1.206,
"taskDurationMs": 93.77999999999999,
"heapDeltaBytes": 4754788,
"heapUsedBytes": 73341876,
"domNodes": 119,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.251999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18208 +/- ##
=============================================
Coverage ? 83.55%
=============================================
Files ? 2094
Lines ? 123508
Branches ? 34439
=============================================
Hits ? 103192
Misses ? 20138
Partials ? 178
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…d status (PM-1302) (#18082) ## Before A premature failed download status stayed failed after a successful retry. Polling ignored failed downloads. Dismissing a failed toast while a status request was in flight could also reopen it when the response arrived. ## After Only completed downloads are terminal. Failed downloads accept later status messages and are rechecked by polling. Poll responses are discarded if the tracked item was removed or replaced while the request was in flight. Failed downloads still leave the active-download list so the failure state and close button remain available. Running-download cancellation and the original Auto Mode missing-model import remain separate acceptance work, not completed by this PR. ## Test plan - 19 unit tests pass; one existing expected-failing test records the unresolved active-download presentation choice. - The new dismissal-race unit and browser cases fail without the guard and pass with it. Manual failed-toast dismissal also passes. - Source and browser typechecks, lint, formatting and commit hooks pass. - Recovery text assertions pass locally. The recovery screenshot differed by four pixels on the first local run; its baseline was not changed. Fresh native CI remains a merge gate. ## Tracking [Original Slack report](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729) · [original Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). Related issues: PM-1302 (download/import failure) and PM-1309 (download progress and cancellation). Christian's completion lane owns remaining acceptance and core/1.54 plus cloud/1.54 qualification in the [program completion record](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/slack-claude-pilot.md), task `claude-handoff-13`. Correction: [the paired backend retry fix](Comfy-Org/cloud#9823) is **open**, not merged as the earlier description claimed. This frontend recovery is independently useful; it does not establish backend retry correctness. Glossary: CI means automated pull-request checks; expected-failing means an assertion deliberately records unimplemented behavior, not a passing feature. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
7d370f2 to
cf3f2d0
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Independent target-adaptation review: COMMENT / HOLD for head 41b9fe4 against cloud/1.54 tip 194fed4. Source #18082 intent is preserved: failed statuses remain recoverable by WebSocket and polling, completed remains terminal, and the identity guard discards stale in-flight poll responses after dismissal/replacement. Release imports correctly retain schemas/apiSchema rather than the main-only relocated API. The two carrier patches are identical; browser adaptation adds @cloud plus the CI-rendered Cloud baseline. Hosted Cloud browser jobs passed (Core carrier 188; Cloud carrier 191). The existing expected-failure active-download presentation test is not counted as implemented acceptance. Running cancellation, Auto Mode missing-model import and backend retry correctness remain outside this narrow proof. Full target patch, source intent/review, affected release contracts, hosted checks and discussions inspected; no target-specific code defect or human objection found. All hosted checks on this head are terminal non-adverse, and the current-target merge-tree simulation is clean. However the authoritative target-aware guard returns NOT MERGE READY because current cloud/1.54 is not an ancestor of this head. Refresh onto the current release target and rerun required target-native acceptance and hosted checks, then obtain a new exact-head/target receipt. Green old-base checks do not certify the current integration. REVIEW_REQUIRED is not itself a defect. Review lease on this exact launch head is RELEASED for the sole finalizer to refresh; this is not permission to merge. COMMENT is also the honest review mode when authenticated as this PR's author.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent refresh review: COMMENT / HOLD at exact head 2bcd198 against cloud/1.54@194fed4da53941c6ca59f18af55647fac9ded5a8. The target-ancestry blocker is fixed. I independently verified that this head has the prior reviewed head and current target as parents, its entire tree exactly equals Git merge-tree's clean automatic merge, and the target-relative stable patch ID is unchanged. The prior source-intent/full-adaptation review therefore carries forward with no target-specific defect; no unresolved review thread or human objection appeared. Finalizer reports focused tests passing (attachments 40/40 per target; downloads 19 passing plus one preserved expected-failure), scoped lint/format/trailer checks and pre-push knip. I have not independently rerun these local tests. The authoritative target-aware guard now rejects only at incomplete hosted checks; required refreshed target-native browser acceptance is also still pending. The activeDownloads presentation test remains an explicit expected-failure residual, not passing acceptance. Running-download cancellation, Auto Mode import and backend retry correctness remain open. This is an adaptation-clear receipt, NOT merge-ready. Bounded review lease RELEASED. Complete and inspect acceptance plus terminal non-adverse hosted evidence and run the live target-aware guard before any authorized merge. An unchanged head/target does not need duplicate code review; a changed head or target invalidates this receipt. REVIEW_REQUIRED itself is not a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent post-history download refresh review: COMMENT / HOLD at 0dace4a against cloud/1.54@78ab9ed884cd588026bb52c23755a04045585d72. Independently verified exact clean automatic merge tree of the prior reviewed carrier and the new history target, target ancestry and unchanged source #18082 patch ID e31ee6613bb4a4001293643491eb4783478aeb13. Trailer script passes. No additional product change, target-specific adaptation defect, unresolved discussion or human objection found. Finalizer reports 59 passing tests plus one preserved expected failure per target (download 19 + history 40), source/browser types, scoped lint/format and knip; these fresh local runs are reported rather than independently rerun. The activeDownloads presentation expected-failure remains an explicit open residual. Previous-target affected browser acceptance passed all three cases retry=0, but cannot substitute for pending fresh affected-browser evidence on this head. The authoritative target-aware guard rejects incomplete hosted checks. Adaptation-clear; bounded review lease RELEASED, NOT merge-ready. Complete exact-head acceptance and terminal non-adverse hosted evidence and rerun live guard before any authorized merge. Cloud also has a separate deployment-side-effect authorization hold; review/check readiness does not clear it. Head/target changes invalidate this receipt; REVIEW_REQUIRED alone is not a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Release-finalizer COMMENT, not human approval. Christian's September 16/20 grant and September 21 explicit automatic testcloud/staging deployment clarification authorize this qualified Cloud backport merge. Exact head 0dace4a against cloud/1.54@78ab9ed884cd588026bb52c23755a04045585d72 independently adaptation-reviewed (#5262621279), unchanged source #18082 patch/automatic merge tree/ancestry. Fresh59 unit passes (download19+history40) plus1 preserved expected-failure; source/browser types, lint/format and knip pass (existing apiSchema warning). Reviewer inspected current hosted report35553839913/job106193947266: merge34033ee25ad2956dc0878fe62f6da8d123baeae6 tree equals this head, all3 affected browser cases passed retry0 including recovery screenshot. Whole Cloud project211pass/1promoted-widget flake/2skip,0unexpected; bundle34ddcfda0d5fed7c1a85b431c4336d3dc173772bd64b0ce5959334e91b50307b. Prior local4pixel screenshot mismatch retained, not relabeled passed. Current target guard passed89 terminal non-adverse check runs/statuses; all discussions read, no unresolved human objection/thread. REVIEW_REQUIRED only bypass; no human peer approval asserted. PM-1302/PM-1309 activeDownloads presentation expected-failure and broader backend/import/cancellation acceptance remain with Christian's completion lane, claude-handoff-13; this mocked frontend evidence does not establish deployed backend retry correctness. Prior history target's generated AI trailer is unchanged pending separate authority. To prevent new generated attribution, use explicit clean squash body, preserve human/non-AI trailers and source provenance, and verify actual merged trailer. Prior automatic cloud run35553641155 succeeded; new merge's exact downstream run will be recorded and monitored terminal before another Cloud merge. No manual dispatch, production release/tag or rollback authorized. Prevention Justification is in BODY; live guard will run immediately before head-bound admin squash.
|
Merge receipt: c0ce3d31 has the exact reviewed/tested carrier tree. The actual merged commit passes the AI coauthor trailer check; explicit squash body preserves github-actions and bymyself attribution without the generated AI trailer. The immediate target-aware guard passed 91 terminal non-adverse check runs. Automatic testcloud/staging run 35555330547 is bound to this exact commit by its resolve log and is currently in progress, under Christian’s September 21 authorization. No subsequent Cloud merge until this downstream run succeeds; failure stops the lane. PM-1302/PM-1309 activeDownloads presentation expected-failure, backend/import/cancellation acceptance, and the older history-target metadata issue remain explicit residuals. |
Backport of #18082 to
cloud/1.54Automatically created by backport workflow.
Justification: Agent 1.54 release backport authorized by Christian's September 16/20 grant; exact head 0dace4a was independently adaptation-reviewed against cloud/1.54@78ab9ed884cd588026bb52c23755a04045585d72, required target-native acceptance and terminal hosted checks passed, the current target-aware merge guard passed, and no unresolved human objection remains. REVIEW_REQUIRED is the only branch-protection condition bypassed. Christian additionally authorized automatic testcloud/staging deployment from qualified Cloud merges on September 21; its downstream run will be monitored to terminal status. Residuals retained: PM-1302/PM-1309 activeDownloads expected-failure/product decision, backend retry and broader import/cancellation acceptance; prior local four-pixel screenshot mismatch; historical target AI trailer pending separate disposition.