Repository navigation
chore(agent): address post-merge review nits from #16856 - #18204
Conversation
Three mechanical follow-ups on threads left open when #16856 merged: - Remove the dead `agent.retryAfter` locale entry. The rendered admission copy uses `agent.retryAfterSeconds`; nothing in src or browser_tests reads the pluralized key, and no other locale carries it. - Drop the four-line comment above the paywall prompt assertions. The two distinct locators already say which outcomes are observed. - Build the new `msg-paywall` ids with `toTurnId` instead of casting through the `TurnId` brand, matching the module's authoritative parser. No behavior change. Verified: AgentPanelRoot.test.ts 226/226 pass, vue-tsc and tsc clean, changed-file eslint and oxfmt clean.
🎭 Playwright: ✅ 2061 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since d3e5db5474610a528cb4ded3a61e68d12e9935e8
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.95 MB gzip 🟢 -498 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • 🟢 -1.46 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • 🟢 -79 BBundles that do not match a named category
Status: 81 added / 81 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T12:32:58.653Z",
"gitSha": "1c3d8fd8b1620cd83a0cd4f40232656cfc58c731",
"branch": "christian-byrne/fe-16856-postmerge-nits",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.7890000000398,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.971,
"heapDeltaBytes": 12284576,
"heapUsedBytes": 74058936,
"domNodes": -258,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 7.922999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1992.4060000000168,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.922000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.62399999999997,
"heapDeltaBytes": 70332,
"heapUsedBytes": 62081224,
"domNodes": -260,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 5.325,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.5010000000025,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.935000000000002,
"layouts": 14,
"layoutDurationMs": 4.321000000000001,
"taskDurationMs": 635.9449999999999,
"heapDeltaBytes": 832412,
"heapUsedBytes": 61966544,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 117.25,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1678.6020000000121,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.592000000000002,
"layouts": 14,
"layoutDurationMs": 3.708,
"taskDurationMs": 496.447,
"heapDeltaBytes": 2502540,
"heapUsedBytes": 64659044,
"domNodes": -257,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 91.72800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.7719999999867,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.973,
"layouts": 6,
"layoutDurationMs": 1.0699999999999998,
"taskDurationMs": 231.507,
"heapDeltaBytes": 2112504,
"heapUsedBytes": 64294240,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.697000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.1690000000076,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.897,
"layouts": 6,
"layoutDurationMs": 1.0119999999999998,
"taskDurationMs": 192.956,
"heapDeltaBytes": 2184156,
"heapUsedBytes": 64357700,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.681999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 510.34599999997,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.196999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.976,
"heapDeltaBytes": 18527968,
"heapUsedBytes": 80195328,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 109.982,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 385.26899999999387,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.3759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.305,
"heapDeltaBytes": 18935428,
"heapUsedBytes": 86212368,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 103.50000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2010.3799999999978,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.671,
"heapDeltaBytes": 19845100,
"heapUsedBytes": 83139008,
"domNodes": -239,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.878000000000007,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2006.5120000000434,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.056999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.13599999999997,
"heapDeltaBytes": -7255652,
"heapUsedBytes": 78663508,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 23.447999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2278.8790000000176,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1172.606,
"heapDeltaBytes": -1242244,
"heapUsedBytes": 79950556,
"domNodes": -245,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 591.234,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2139.4639999999754,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1016.45,
"heapDeltaBytes": -1404872,
"heapUsedBytes": 79432408,
"domNodes": -244,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 519.8960000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3084.8890000000324,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.298,
"layouts": 60,
"layoutDurationMs": 13.562,
"taskDurationMs": 1092.959,
"heapDeltaBytes": 8449932,
"heapUsedBytes": 73703012,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 489.225,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3189.095000000009,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.852,
"layouts": 60,
"layoutDurationMs": 13.376000000000001,
"taskDurationMs": 1148.9,
"heapDeltaBytes": -6176236,
"heapUsedBytes": 75453376,
"domNodes": -242,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 521.221,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2210.141999999962,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.599000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1278.5159999999998,
"heapDeltaBytes": 8360308,
"heapUsedBytes": 74368360,
"domNodes": 8,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 646.153,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2224.0659999999934,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.472999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1237.7420000000002,
"heapDeltaBytes": 18570360,
"heapUsedBytes": 84575856,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 644.3919999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2016.744000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.3439999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.72099999999995,
"heapDeltaBytes": -5553908,
"heapUsedBytes": 82254080,
"domNodes": -242,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 27.758000000000006,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2022.7329999999597,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.477999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.081,
"heapDeltaBytes": -5252256,
"heapUsedBytes": 82711928,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 19.951999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 416.8940000000134,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.552000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 266.049,
"heapDeltaBytes": 13294404,
"heapUsedBytes": 76591052,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 93.875,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 398.3400000000188,
"styleRecalcs": 46,
"styleRecalcDurationMs": 8.825999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 264.564,
"heapDeltaBytes": 13294548,
"heapUsedBytes": 76893776,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 92.852,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1988.0209999999465,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.81,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.1,
"heapDeltaBytes": -7348604,
"heapUsedBytes": 61431600,
"domNodes": -272,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.953999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1988.5679999999866,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.9460000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 311.562,
"heapDeltaBytes": -2553632,
"heapUsedBytes": 60213116,
"domNodes": -271,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.158999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1679.239999999993,
"styleRecalcs": 78,
"styleRecalcDurationMs": 20.173,
"layouts": 18,
"layoutDurationMs": 4.3020000000000005,
"taskDurationMs": 489.942,
"heapDeltaBytes": -1468916,
"heapUsedBytes": 61302160,
"domNodes": -273,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 73.788,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.8939999999475,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.210999999999995,
"layouts": 18,
"layoutDurationMs": 5.043,
"taskDurationMs": 514.794,
"heapDeltaBytes": -5537524,
"heapUsedBytes": 56958948,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 75.55300000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.7899999999536,
"styleRecalcs": 19,
"styleRecalcDurationMs": 18.337,
"layouts": 5,
"layoutDurationMs": 7.637000000000001,
"taskDurationMs": 544.342,
"heapDeltaBytes": -6441552,
"heapUsedBytes": 80474740,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 18.793999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 67,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8289.95100000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.73800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3977.7380000000003,
"heapDeltaBytes": -2755956,
"heapUsedBytes": 77401252,
"domNodes": -240,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 1909.782,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8274.057000000028,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.96300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3769.2419999999997,
"heapDeltaBytes": -3799232,
"heapUsedBytes": 76282864,
"domNodes": -243,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 1817.208,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11648.977000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11022.368,
"heapDeltaBytes": -8706032,
"heapUsedBytes": 200417584,
"domNodes": -8062,
"jsHeapTotalBytes": -11280384,
"scriptDurationMs": 151.687,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10793.66200000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9894.981,
"heapDeltaBytes": -56305548,
"heapUsedBytes": 175128092,
"domNodes": -8062,
"jsHeapTotalBytes": -15785984,
"scriptDurationMs": 136.614,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13594.351999999959,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.827000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13283.964000000002,
"heapDeltaBytes": -55453488,
"heapUsedBytes": 180151220,
"domNodes": -8062,
"jsHeapTotalBytes": -15179776,
"scriptDurationMs": 565.8610000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13767.184999999983,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.53600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13291.258,
"heapDeltaBytes": -43721356,
"heapUsedBytes": 187625288,
"domNodes": -8062,
"jsHeapTotalBytes": -11661312,
"scriptDurationMs": 568.836,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4126.845000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 59.02200000000002,
"layouts": 20,
"layoutDurationMs": 20.733,
"taskDurationMs": 4047.4990000000003,
"heapDeltaBytes": -49195984,
"heapUsedBytes": 175232360,
"domNodes": -8070,
"jsHeapTotalBytes": 11476992,
"scriptDurationMs": 87.183,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 4105.348000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.596000000000004,
"layouts": 20,
"layoutDurationMs": 21.363,
"taskDurationMs": 4010.638999999999,
"heapDeltaBytes": -19662300,
"heapUsedBytes": 195205308,
"domNodes": -8062,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 61.703,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5845.4370000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5637.4749999999985,
"heapDeltaBytes": 10947796,
"heapUsedBytes": 196212732,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 77.88400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5652.190000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5370.613,
"heapDeltaBytes": 24948404,
"heapUsedBytes": 202773304,
"domNodes": 0,
"jsHeapTotalBytes": -28311552,
"scriptDurationMs": 73.95600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 415.21399999999176,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.154000000000002,
"layouts": 3,
"layoutDurationMs": 0.7779999999999999,
"taskDurationMs": 71.992,
"heapDeltaBytes": 4824792,
"heapUsedBytes": 66299756,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.361,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 421.5480000000298,
"styleRecalcs": 16,
"styleRecalcDurationMs": 15.698999999999998,
"layouts": 3,
"layoutDurationMs": 1.3339999999999999,
"taskDurationMs": 79.60600000000001,
"heapDeltaBytes": 5055580,
"heapUsedBytes": 66612456,
"domNodes": 146,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.358,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe changes update paywall test fixtures to use ChangesAgent test cleanup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18204 +/- ##
==========================================
+ Coverage 82.94% 83.91% +0.96%
==========================================
Files 2956 2260 -696
Lines 145565 128540 -17025
Branches 37499 32751 -4748
==========================================
- Hits 120743 107859 -12884
+ Misses 23552 20391 -3161
+ Partials 1270 290 -980
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Verdict: approve — all three nits addressed, nothing extra rode along.
I verified each thread independently rather than taking the description's word for it:
-
Dead
agent.retryAfterlocale key. Confirmed dead. Every production reference in the agent tree is toretryAfterSeconds, not the pluralized key:AgentMessageGroup.vue:87renders$t('agent.retryAfterSeconds', { seconds }), andagentMessageParts.ts:38,agentConversationStore.ts:107anduseAgentSession.ts:109,373all carry theretryAfterSecondsfield. I also checked the sibling locale bundles —zh,ja,ko,fr,es,ru,deeach haveagent.retryAfterSecondsand none hasagent.retryAfter, so removing it fromenleaves no orphaned translations behind. -
Redundant spec comment. Removed exactly the four lines; the two assertions below it are untouched, and the
getByTestId('user-message-bubble')locator that the comment was justifying stays in place, so the disambiguation it described is still enforced by the code. -
toTurnIdin the paywall cases.toTurnIdis a real export (agentApiSchema.ts:33,zTurnId.parse), andzTurnIdis a barez.string().brand<'TurnId'>()with no runtime constraints, sotoTurnId('msg-paywall')cannot throw on these fixtures. All eightas TurnIdcasts inside theAgentPanelRoot paywall actionsdescribe are converted. The four remainingas TurnIdcasts (lines 2272, 2341, 3103, 5097) sit outside that block and are correctly left alone, which also keeps theimport type { ... TurnId }on line 251 in use rather than dangling.
The diff contains exactly these three changes and no production-code edits. All 106 CI checks on this head are successful or skipped; none failed. No findings.
Validation I did not run: read-only review through the GitHub API — I did not execute AgentPanelRoot.test.ts or the typecheck locally, so the 226/226 figure is author-reported here.
## Summary Backports six merged `main` Agent fixes to `cloud/1.54` and repairs the `agentCanvasLagsToolCallCompletion` e2e spec that #18586 landed with, which fails `typecheck:browser` on the current branch tip. ## Changes - **What**: `cherry-pick -x` of #17568, #17628, #16491, #18453, #17767 and #18603, in `main` merge order. The spec fix uses `entryButton` and the "Worked for" summary instead of the labels #18622 removed, and adds `HostDoc.graph()` to the conversation host-doc fixture. #18391 itself is already on the line via #18586 and is unchanged here. - **Excluded**: #18066 (Christian's request), #16908 (refactor), #18375 (needs its `src/lib/litegraph/` half). ## Review Focus - #18603 forwards two new onboarding telemetry events for every user, not only Agent users. - `AgentPanelRoot.vue` changes come from #16491 and #17767 on top of #18391's merged code; `useAgentCrdtFollower.ts` is identical to the tip. - Merging the tip resolved two conflicts: the spec (this copy) and `AgentPanelRoot.test.ts` (the tip's #18391 test plus these picks). - Second batch (#16856, #18204, #18229, #17327, #18251, #16985, #18224) follows on this tip. Linear: [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) No new visuals; #17568 and #17767 were reviewed on `main`. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org>
## Summary Backports the second batch of merged `main` Agent fixes to `cloud/1.54`: the Agent paywall and admission-error handling with its follow-ups, workflow-scoped node selection, the bounded attachment upload contract, and the turn request contract without the draft version. ## Changes - **What**: `cherry-pick -x` of #16856, #18204, #17327, #18229, #16985 and #18224, in `main` merge order. Two adaptation commits: #16856's PM-1430 behavior is replayed in #18278's split form, since this line had it in the old single-function form via #18385; #16985 brings #18104's version of the Undo test. `DraftSnapshot` is `Pick<..., 'content'>` because this line's ingest types keep the draft version optional. - **Excluded**: #18251 (its lint rule needs its `src/lib/litegraph/` hunks, and its lockfile change does not apply to this line). ## Review Focus - #16856 restores the Agent paywall on this line, which is billing-facing. - `useAttachment.ts` and its test are taken whole from `main`, because #16985 asserts `reportError` on its new fetch path. - The four e2e specs this changes were not run locally; hosted e2e covers them. Linear: [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) No new visuals. --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Summary
Addresses three review threads that were still open when #16856 merged, all mechanical and behavior-preserving.
Changes
agent.retryAfterlocale entry (the rendered admission copy usesagent.retryAfterSeconds, nothing insrcorbrowser_testsreads the pluralized key, and no other locale carries it); drops the four-line comment above the paywall prompt assertions inagentPanel.spec.ts, since the two distinct locators already say which outcomes are observed; builds the newmsg-paywallids withtoTurnIdrather than casting through theTurnIdbrand.Review Focus
Threads addressed: dead locale key, redundant spec comment,
toTurnIdin the paywall cases.The pre-existing
as TurnIdcasts elsewhere inAgentPanelRoot.test.ts(lines around 2272, 2341, 3103, 5097) predate #16856 and are left alone; only the cases that PR added are converted.The remaining open threads from #16856 are tracked in Linear rather than fixed here: FE-2307, FE-2309, FE-2310, FE-2311, FE-2314, FE-2315, FE-2387, FE-2388, FE-2389, FE-2460, FE-2461, FE-2462, FE-2463, FE-2464, FE-2519, plus the new paywall-policy-ownership and
test.stepitems.Verified at this head:
AgentPanelRoot.test.ts226/226 pass (NODE_OPTIONS=--no-experimental-webstorage, required on node 26),vue-tsc --noEmitandtsc --noEmitclean, changed-fileeslintandoxfmt --checkclean.