Repository navigation
fix(agent): allow .json in agent chat attach filter - #18122
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2035 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 298 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T01:43:22.063Z",
"gitSha": "3c42323e3d9f064af326e70d9fcd66e0cf8a921b",
"branch": "fix/agent-attach-json-filetype",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.5730000000312,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.711999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.752,
"heapDeltaBytes": 16207044,
"heapUsedBytes": 76986352,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.640999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1990.9679999999526,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.735000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.201,
"heapDeltaBytes": -5574152,
"heapUsedBytes": 56624600,
"domNodes": -261,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.841000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.2189999999464,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.04,
"layouts": 14,
"layoutDurationMs": 3.7089999999999996,
"taskDurationMs": 676.052,
"heapDeltaBytes": 1521260,
"heapUsedBytes": 63548048,
"domNodes": -262,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 122.67000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1708.0700000000206,
"styleRecalcs": 73,
"styleRecalcDurationMs": 23.011999999999997,
"layouts": 14,
"layoutDurationMs": 4.07,
"taskDurationMs": 680.16,
"heapDeltaBytes": 4478756,
"heapUsedBytes": 65185052,
"domNodes": -259,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 124.45599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.8140000000512,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.135,
"layouts": 6,
"layoutDurationMs": 0.9890000000000001,
"taskDurationMs": 261.17199999999997,
"heapDeltaBytes": 1754052,
"heapUsedBytes": 63977852,
"domNodes": 75,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.834999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.189999999945,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.766,
"layouts": 6,
"layoutDurationMs": 0.9819999999999998,
"taskDurationMs": 268.54699999999997,
"heapDeltaBytes": 2117512,
"heapUsedBytes": 64321248,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.110999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 585.0690000000895,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.755999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.54200000000003,
"heapDeltaBytes": 17549664,
"heapUsedBytes": 79834320,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.111,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 542.8889999999456,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.541999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.3,
"heapDeltaBytes": 17599560,
"heapUsedBytes": 79839332,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 133.103,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.3839999999882,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.898000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.4680000000001,
"heapDeltaBytes": 2118712,
"heapUsedBytes": 82852384,
"domNodes": -243,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.439,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2012.467000000015,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.136000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.817,
"heapDeltaBytes": 2029428,
"heapUsedBytes": 82884952,
"domNodes": -246,
"jsHeapTotalBytes": -2068480,
"scriptDurationMs": 28.119999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2157.9699999999775,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.096,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1315.9540000000002,
"heapDeltaBytes": -12318356,
"heapUsedBytes": 74739348,
"domNodes": -221,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 684.894,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2111.695999999938,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.822999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1258.2849999999999,
"heapDeltaBytes": 14338460,
"heapUsedBytes": 78507816,
"domNodes": -248,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 650.554,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3178.908000000092,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.65,
"layouts": 60,
"layoutDurationMs": 12.621,
"taskDurationMs": 1351.372,
"heapDeltaBytes": 8318720,
"heapUsedBytes": 74177692,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 636.537,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3199.820000000045,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.524,
"layouts": 60,
"layoutDurationMs": 12.395,
"taskDurationMs": 1360.9119999999998,
"heapDeltaBytes": 7690392,
"heapUsedBytes": 73494388,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 636.451,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2405.8449999999993,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.961999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1543.8,
"heapDeltaBytes": 14481680,
"heapUsedBytes": 80452060,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 788.0749999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2444.340000000011,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.192999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1572.4460000000001,
"heapDeltaBytes": 16024992,
"heapUsedBytes": 81836648,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 811.98,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2003.5449999999173,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.1290000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.4819999999999,
"heapDeltaBytes": 20142520,
"heapUsedBytes": 83869988,
"domNodes": -247,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.48100000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2011.7390000000341,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.545999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.1669999999999,
"heapDeltaBytes": -6221032,
"heapUsedBytes": 81963032,
"domNodes": -249,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 32.32899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 497.98199999997905,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.512000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.855,
"heapDeltaBytes": 13810452,
"heapUsedBytes": 76437028,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 121.10199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 526.4670000000251,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.988000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.495,
"heapDeltaBytes": 13306252,
"heapUsedBytes": 76737468,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 118.44300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.4649999999483,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.5230000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.96200000000005,
"heapDeltaBytes": 1491640,
"heapUsedBytes": 64974116,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.591999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1992.729000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.865999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 290.068,
"heapDeltaBytes": 920672,
"heapUsedBytes": 64399292,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.523999999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.3170000000027,
"styleRecalcs": 78,
"styleRecalcDurationMs": 21.504,
"layouts": 18,
"layoutDurationMs": 4.065,
"taskDurationMs": 620.703,
"heapDeltaBytes": 476980,
"heapUsedBytes": 63962156,
"domNodes": -277,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 84.236,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.209000000048,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.622999999999998,
"layouts": 18,
"layoutDurationMs": 3.9179999999999997,
"taskDurationMs": 626.489,
"heapDeltaBytes": 437360,
"heapUsedBytes": 63906656,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 83.31700000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 900.794000000019,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.649,
"layouts": 5,
"layoutDurationMs": 9.61,
"taskDurationMs": 720.8919999999998,
"heapDeltaBytes": -6426412,
"heapUsedBytes": 80958760,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 23.010999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 91,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8193.085999999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.237,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4547.423999999999,
"heapDeltaBytes": -5647312,
"heapUsedBytes": 75340744,
"domNodes": -245,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 2164.576,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8202.141999999982,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4594.848,
"heapDeltaBytes": 2384828,
"heapUsedBytes": 83371852,
"domNodes": -246,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 2175.376,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14106.135999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13933.985,
"heapDeltaBytes": -43998096,
"heapUsedBytes": 177766764,
"domNodes": -8061,
"jsHeapTotalBytes": -9420800,
"scriptDurationMs": 206.12900000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14172.865999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14113.848999999998,
"heapDeltaBytes": -13527032,
"heapUsedBytes": 188860312,
"domNodes": -8061,
"jsHeapTotalBytes": -8646656,
"scriptDurationMs": 201.93,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16893.933999999943,
"styleRecalcs": 116,
"styleRecalcDurationMs": 13.468999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16661.025,
"heapDeltaBytes": -65809880,
"heapUsedBytes": 165365484,
"domNodes": -8061,
"jsHeapTotalBytes": -11517952,
"scriptDurationMs": 689.069,
"eventListeners": -14928,
"totalBlockingTimeMs": 11,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17148.977000000057,
"styleRecalcs": 120,
"styleRecalcDurationMs": 14.45100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16974.828,
"heapDeltaBytes": -44146296,
"heapUsedBytes": 165314244,
"domNodes": -8066,
"jsHeapTotalBytes": -14721024,
"scriptDurationMs": 704.4240000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5131.197999999927,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.65400000000001,
"layouts": 20,
"layoutDurationMs": 22.009,
"taskDurationMs": 5093.512,
"heapDeltaBytes": -51890144,
"heapUsedBytes": 176545344,
"domNodes": -8062,
"jsHeapTotalBytes": 11550720,
"scriptDurationMs": 86.465,
"eventListeners": -14928,
"totalBlockingTimeMs": 205,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5126.288999999929,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.74799999999998,
"layouts": 20,
"layoutDurationMs": 23.16700000000001,
"taskDurationMs": 5086.449,
"heapDeltaBytes": -53113996,
"heapUsedBytes": 175480840,
"domNodes": -8061,
"jsHeapTotalBytes": 11288576,
"scriptDurationMs": 103.831,
"eventListeners": -14928,
"totalBlockingTimeMs": 310,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7186.544000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7114.647000000002,
"heapDeltaBytes": -5478192,
"heapUsedBytes": 173374512,
"domNodes": 0,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 121.58599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7087.381999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7023.619,
"heapDeltaBytes": -11876768,
"heapUsedBytes": 168022868,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 123.033,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 84.36799999992672,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.129999999999999,
"layouts": 4,
"layoutDurationMs": 1.9040000000000001,
"taskDurationMs": 69.34400000000001,
"heapDeltaBytes": 3167192,
"heapUsedBytes": 64775628,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.942,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 440.9530000000359,
"styleRecalcs": 14,
"styleRecalcDurationMs": 16.451,
"layouts": 2,
"layoutDurationMs": 0.5399999999999999,
"taskDurationMs": 84.357,
"heapDeltaBytes": 4845720,
"heapUsedBytes": 66339516,
"domNodes": 123,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.524000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
76a1c06 to
64d1ea1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18122 +/- ##
==========================================
+ Coverage 82.78% 83.79% +1.01%
==========================================
Files 2946 2250 -696
Lines 145057 128030 -17027
Branches 39230 34481 -4749
==========================================
- Hits 120081 107285 -12796
+ Misses 23710 20455 -3255
+ Partials 1266 290 -976
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 704 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
6ac8bdc to
856e070
Compare
22d4985 to
d96548e
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Picker/drop boundary reviewed and exercised. One nonblocking test-cleanup suggestion; backend JSON readability is outside this change. Merge still requires a current-base head and green checks.
| // The OS picker filters on this attribute; a missing `.json`/ | ||
| // `application/json` entry is exactly what hid JSON files from it. | ||
| await expect(fileInput).toHaveAttribute('accept', AGENT_ATTACH_ACCEPT) | ||
| expect(AGENT_ATTACH_ACCEPT.split(',')).toEqual( |
There was a problem hiding this comment.
minor: Remove the direct AGENT_ATTACH_ACCEPT.split(',') membership assertion from this browser test. The unit table already owns the exact .json and application/json entries, while this E2E test should own only behavior unavailable there: that the real input is wired to the accept value and that selecting JSON reaches the composer. Repeating the constant's contents here is an implementation-level change detector rather than complementary browser proof.
There was a problem hiding this comment.
Done, agreed. Removed the expect(AGENT_ATTACH_ACCEPT.split(',')).toEqual(expect.arrayContaining(['.json', 'application/json'])) line from the test — that exact-entry table already lives in attachableFiles.test.ts (it.for(['.mp4', ..., '.json', 'application/json'])('includes %s in the picker accept list', ...)). The E2E spec now only asserts the real <input>'s accept attribute equals AGENT_ATTACH_ACCEPT (toHaveAttribute('accept', AGENT_ATTACH_ACCEPT)) and that browsing to a .json fixture actually lands it in the composer, which is the behavior this test uniquely proves.
Pushed as 9a24cd1.
Generated by Claude Code
d96548e to
98d2457
Compare
|
I am taking over the remaining branch refresh and merge work under Christian’s authorization. Please leave further branch writes to this completion lane. I am preserving the latest assertion removal and repairing the rejected commit metadata; renewed review is still required. |
9a24cd1 to
476c0f6
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
JSON picker acceptance and native workflow-drop ownership reviewed at this head. The affected 251 unit/component tests and both offline browser cases pass; mocked upload does not establish backend JSON readability. Merge remains gated on current-base checks.
|
The This is already failing on No action needed on this PR beyond that. Will re-run once #18167 lands (or once now, to check if it's still red). Generated by Claude Code |
The agent chat composer's attach-file picker and drag-in gate (isAgentAttachable / AGENT_ATTACH_ACCEPT) omitted .json, so the OS file dialog defaulted to hiding .json files and the drag-drop gate rejected them outright. Add json to both the accept-list and the extra-extensions set so a .json file can be attached like the existing glb/md/txt formats.
Verifies the attach-file accept list advertises .json/application/json and that a .json file is actually accepted end to end through both the file-input browse flow and the panel's drag-and-drop gate.
The previous commit widened AGENT_ATTACH_ACCEPT to fix the reported bug (the OS file picker hid .json files from agent chat attach), but also added 'json' to EXTRA_ATTACHABLE_EXTENSIONS. That second change was out of scope: EXTRA_ATTACHABLE_EXTENSIONS backs isAgentAttachable(), which AgentPanelRoot.vue's drop handler uses to decide whether a raw drag-and-dropped file is claimed by the chat composer or left unclaimed for the pre-existing "drop a workflow .json onto the canvas to load it" graph loader. Claiming .json drops broke that existing feature (and the two AgentPanelRoot.test.ts unit tests asserting it). Revert EXTRA_ATTACHABLE_EXTENSIONS to exclude 'json' (the OS-picker accept list change stays, since that is the actual fix) and correct the attachableFiles.test.ts and agentAttachJsonFile.spec.ts assertions that had locked in the regression, so a dropped .json still falls through to the graph loader instead of being swallowed by the chat composer.
The E2E spec re-asserted AGENT_ATTACH_ACCEPT.split(',') contains
'.json'/'application/json' directly, duplicating the exact-entry table
already owned by attachableFiles.test.ts. Drop it and keep the browser
test scoped to what only it can prove: the real input's accept
attribute is wired, and selecting a JSON file reaches the composer.
476c0f6 to
82ae1e0
Compare
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
<!-- ccr-slack-attribution -->
Requested by Jo Zhang · Slack thread
Before / After
Before: the agent chat composer's attach-file picker (
AGENT_ATTACH_ACCEPT) did not include.json. The OS file picker's default filter hid.jsonfiles entirely (the user had to switch the picker to "All files" to even select one).After:
.jsonis included in the picker's accept list, so a.jsonfile can now be selected directly from the default file-picker filter and attached through the browse flow.Scope correction (2026-09-19)
An earlier revision of this PR also added
jsontoEXTRA_ATTACHABLE_EXTENSIONS, the set that backsisAgentAttachable(). That function is also consulted byAgentPanelRoot.vue's drag-and-drop handler to decide whether a raw file dropped on the panel is claimed by the chat composer or left unclaimed for the pre-existing "drop a workflow.json, onto the canvas to load it" graph-loader feature. Claiming.jsondrops for chat broke that existing, unrelated feature — and the twoAgentPanelRoot.test.tsunit tests asserting it stays unclaimed.This has been corrected:
EXTRA_ATTACHABLE_EXTENSIONSno longer includesjson(drag-and-drop of a.jsonfile keeps going to the graph loader, unchanged from before this PR). Only the OS file-picker filter (AGENT_ATTACH_ACCEPT) is widened, which is the actual reported bug.Changes
src/workbench/extensions/agent/utils/attachableFiles.ts: add.json/application/jsontoAGENT_ATTACH_ACCEPT(the picker fix).EXTRA_ATTACHABLE_EXTENSIONS(the drag-and-drop gate) intentionally does not includejson, with a comment explaining why.src/workbench/extensions/agent/utils/attachableFiles.test.ts: covers.jsonin the accept-list assertion, and assertsisAgentAttachable('workflow.json')isfalse(drag-and-drop stays ungated for the graph loader).browser_tests/tests/agent/agentAttachJsonFile.spec.ts: e2e spec covering the real fix — the file input'sacceptattribute includes.json/application/json, and browsing to a.jsonfixture viasetInputFilesattaches it to the composer. A second test proves a drag-and-dropped.jsonis not claimed by the composer (left for the graph loader, which already has its own drag-and-drop e2e coverage inmetadataWorkflowImport.spec.ts).Test plan
pnpm exec vitest run src/workbench/extensions/agent/utils/attachableFiles.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts— 230 tests pass, including the two pre-existingAgentPanelRoot.test.tstests that assert a dropped.jsonis left unclaimed for the graph loader.pnpm exec eslinton all three changed files — clean.pnpm exec vue-tsc --noEmit— clean.pnpm typecheckandpnpm typecheck:browseron commit — both passed.cloud-tagged project).Scope note
This fixes only the file-type filter gap in the OS picker. Drag-and-drop of a
.jsonfile intentionally keeps going to the pre-existing graph-loader "open workflow" path, not the chat composer. It also does not change what the agent can do with an attached.jsonfile once uploaded — that is a separate, deeper gap (no tool currently reads an arbitrary uploaded asset's contents as text/JSON) that is out of scope for this PR.🤖 Generated with Claude Code
https://claude.ai/code/session_01JbnJ4RxoJA8aRva1EA7g5K
Generated by Claude Code