Repository navigation
[backport core/1.54] fix: stop dropping a later completed download after a premature failed status (PM-1302) - #18207
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1934 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-21T03:45:10.656Z",
"gitSha": "5d04d5345632e6d040d8de0e03cbb43e7157be7a",
"branch": "backport-18082-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.3429999998916,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 284.22999999999996,
"heapDeltaBytes": -11983268,
"heapUsedBytes": 58897432,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.806,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1988.8009999999667,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.367000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 243.305,
"heapDeltaBytes": 234160,
"heapUsedBytes": 65173556,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 4.803999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.2469999999948,
"styleRecalcs": 74,
"styleRecalcDurationMs": 21.311,
"layouts": 14,
"layoutDurationMs": 3.688,
"taskDurationMs": 551.2790000000001,
"heapDeltaBytes": 13433408,
"heapUsedBytes": 83934824,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 94.515,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.420999999973,
"styleRecalcs": 73,
"styleRecalcDurationMs": 20.692999999999998,
"layouts": 14,
"layoutDurationMs": 3.81,
"taskDurationMs": 519.165,
"heapDeltaBytes": -2186956,
"heapUsedBytes": 68438060,
"domNodes": -279,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 92.863,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.340000000043,
"styleRecalcs": 30,
"styleRecalcDurationMs": 10.400999999999998,
"layouts": 6,
"layoutDurationMs": 0.905,
"taskDurationMs": 199.166,
"heapDeltaBytes": 4424020,
"heapUsedBytes": 75481992,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6.565000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.6100000001243,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.002,
"layouts": 6,
"layoutDurationMs": 1.0240000000000002,
"taskDurationMs": 234.65,
"heapDeltaBytes": 4403788,
"heapUsedBytes": 75064424,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.324,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 416.41100000003917,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.159999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.668,
"heapDeltaBytes": -8106612,
"heapUsedBytes": 62562740,
"domNodes": 20,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 93.029,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 413.74800000016876,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.773,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 277.90600000000006,
"heapDeltaBytes": 17771916,
"heapUsedBytes": 87907348,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 97.295,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 1994.105999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.4599999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.15799999999996,
"heapDeltaBytes": 22301880,
"heapUsedBytes": 87660212,
"domNodes": -265,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.969999999999995,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.8720000001103,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.668000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.541,
"heapDeltaBytes": 5770428,
"heapUsedBytes": 82217504,
"domNodes": -273,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 22.251,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2047.9870000000346,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.441999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 941.4070000000002,
"heapDeltaBytes": 16177600,
"heapUsedBytes": 82080228,
"domNodes": 10,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 484.004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2179.5270000000073,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1100.806,
"heapDeltaBytes": 3768448,
"heapUsedBytes": 80910752,
"domNodes": -241,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 558.5640000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3253.123999999957,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.199,
"layouts": 60,
"layoutDurationMs": 15.496999999999998,
"taskDurationMs": 1214.055,
"heapDeltaBytes": 9507728,
"heapUsedBytes": 76401628,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 563.25,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3233.201000000008,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.353,
"layouts": 60,
"layoutDurationMs": 13.049999999999999,
"taskDurationMs": 1177.1509999999998,
"heapDeltaBytes": -3600488,
"heapUsedBytes": 74962236,
"domNodes": -287,
"jsHeapTotalBytes": 3563520,
"scriptDurationMs": 489.78,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2143.0349999999407,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.2410000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1171.4009999999998,
"heapDeltaBytes": 13533476,
"heapUsedBytes": 81258924,
"domNodes": 8,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 583.8520000000001,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2277.9269999998633,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.682999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1303.334,
"heapDeltaBytes": 730080,
"heapUsedBytes": 81128420,
"domNodes": -247,
"jsHeapTotalBytes": -212992,
"scriptDurationMs": 618.3879999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.06699999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.922,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.047,
"heapDeltaBytes": 10616540,
"heapUsedBytes": 87429432,
"domNodes": -265,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 16.592000000000002,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.9199999999564,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.31200000000007,
"heapDeltaBytes": 4897596,
"heapUsedBytes": 82118736,
"domNodes": -273,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 27.712,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 393.22200000003704,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.066999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.70999999999998,
"heapDeltaBytes": 15112492,
"heapUsedBytes": 88016736,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 86.47399999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.7920000001104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.402000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 270.082,
"heapDeltaBytes": 15042216,
"heapUsedBytes": 87855456,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 90.892,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1989.957000000004,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.595000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 278.14099999999996,
"heapDeltaBytes": -6995804,
"heapUsedBytes": 65851544,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 4.680999999999999,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.3240000000915,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 279.57599999999996,
"heapDeltaBytes": -4015760,
"heapUsedBytes": 68809936,
"domNodes": -300,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 4.490000000000001,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1661.4039999999477,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.073,
"layouts": 18,
"layoutDurationMs": 4.632000000000001,
"taskDurationMs": 499.62600000000003,
"heapDeltaBytes": -9757068,
"heapUsedBytes": 62732796,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 70.65100000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1661.0450000000583,
"styleRecalcs": 77,
"styleRecalcDurationMs": 20.42,
"layouts": 18,
"layoutDurationMs": 4.356,
"taskDurationMs": 500.1599999999999,
"heapDeltaBytes": -4712736,
"heapUsedBytes": 68419196,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 70.396,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.1209999999901,
"styleRecalcs": 20,
"styleRecalcDurationMs": 20.404,
"layouts": 16,
"layoutDurationMs": 9.675999999999998,
"taskDurationMs": 530.013,
"heapDeltaBytes": 21828144,
"heapUsedBytes": 105131848,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 16.633000000000003,
"eventListeners": 2385,
"totalBlockingTimeMs": 62,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.47699999997,
"styleRecalcs": 248,
"styleRecalcDurationMs": 40.732,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3584.734,
"heapDeltaBytes": -13553312,
"heapUsedBytes": 89298940,
"domNodes": -263,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 1775.144,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8442.590999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.916000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4046.024999999999,
"heapDeltaBytes": 13990152,
"heapUsedBytes": 89492560,
"domNodes": -266,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 1785.4240000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10731.53400000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9822.827,
"heapDeltaBytes": -39892540,
"heapUsedBytes": 184463000,
"domNodes": -8068,
"jsHeapTotalBytes": -10465280,
"scriptDurationMs": 136.601,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11903.489000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11001.191,
"heapDeltaBytes": -36028200,
"heapUsedBytes": 176494636,
"domNodes": -8068,
"jsHeapTotalBytes": -26415104,
"scriptDurationMs": 209.90099999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14016.737000000034,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.771000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13335.579999999998,
"heapDeltaBytes": -45897296,
"heapUsedBytes": 178211136,
"domNodes": -8068,
"jsHeapTotalBytes": -18817024,
"scriptDurationMs": 639.5809999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 50,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14816.397000000052,
"styleRecalcs": 75,
"styleRecalcDurationMs": 14.47100000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14341.07,
"heapDeltaBytes": -63383356,
"heapUsedBytes": 166108732,
"domNodes": -8068,
"jsHeapTotalBytes": -20123648,
"scriptDurationMs": 653.1260000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3881.3749999999345,
"styleRecalcs": 20,
"styleRecalcDurationMs": 48.99899999999999,
"layouts": 20,
"layoutDurationMs": 17.029000000000003,
"taskDurationMs": 3769.2209999999995,
"heapDeltaBytes": -26794164,
"heapUsedBytes": 185829988,
"domNodes": -8072,
"jsHeapTotalBytes": 10285056,
"scriptDurationMs": 57.552,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4270.870000000059,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.289,
"layouts": 20,
"layoutDurationMs": 21.960999999999995,
"taskDurationMs": 4198.404999999999,
"heapDeltaBytes": -48766336,
"heapUsedBytes": 177250088,
"domNodes": -8072,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 96.794,
"eventListeners": -14931,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5265.9889999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4949.197999999999,
"heapDeltaBytes": -13897608,
"heapUsedBytes": 170884016,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 65.45200000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6104.759999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5820.492999999999,
"heapDeltaBytes": 899756,
"heapUsedBytes": 171016840,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 86.92700000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 57.208999999943444,
"styleRecalcs": 4,
"styleRecalcDurationMs": 7.831000000000001,
"layouts": 2,
"layoutDurationMs": 0.659,
"taskDurationMs": 40.111999999999995,
"heapDeltaBytes": 3034076,
"heapUsedBytes": 72247300,
"domNodes": 100,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.209000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 68.70899999989888,
"styleRecalcs": 5,
"styleRecalcDurationMs": 11.391,
"layouts": 2,
"layoutDurationMs": 0.7100000000000001,
"taskDurationMs": 48.36300000000001,
"heapDeltaBytes": 3000808,
"heapUsedBytes": 70850044,
"domNodes": 102,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 3.359000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18207 +/- ##
=============================================
- Coverage 83.54% 83.54% -0.01%
=============================================
Files 2094 2094
Lines 123487 123495 +8
Branches 31436 31440 +4
=============================================
- Hits 103170 103168 -2
- Misses 20138 20148 +10
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…d status (PM-1302) (#18082) ## Before A premature failed download status stayed failed after a successful retry. Polling ignored failed downloads. Dismissing a failed toast while a status request was in flight could also reopen it when the response arrived. ## After Only completed downloads are terminal. Failed downloads accept later status messages and are rechecked by polling. Poll responses are discarded if the tracked item was removed or replaced while the request was in flight. Failed downloads still leave the active-download list so the failure state and close button remain available. Running-download cancellation and the original Auto Mode missing-model import remain separate acceptance work, not completed by this PR. ## Test plan - 19 unit tests pass; one existing expected-failing test records the unresolved active-download presentation choice. - The new dismissal-race unit and browser cases fail without the guard and pass with it. Manual failed-toast dismissal also passes. - Source and browser typechecks, lint, formatting and commit hooks pass. - Recovery text assertions pass locally. The recovery screenshot differed by four pixels on the first local run; its baseline was not changed. Fresh native CI remains a merge gate. ## Tracking [Original Slack report](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729) · [original Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). Related issues: PM-1302 (download/import failure) and PM-1309 (download progress and cancellation). Christian's completion lane owns remaining acceptance and core/1.54 plus cloud/1.54 qualification in the [program completion record](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/slack-claude-pilot.md), task `claude-handoff-13`. Correction: [the paired backend retry fix](Comfy-Org/cloud#9823) is **open**, not merged as the earlier description claimed. This frontend recovery is independently useful; it does not establish backend retry correctness. Glossary: CI means automated pull-request checks; expected-failing means an assertion deliberately records unimplemented behavior, not a passing feature. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
a2b5c14 to
48aa848
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Independent target-adaptation review: COMMENT / HOLD for head 83a2c9a against core/1.54 tip e79d6ae. Source #18082 intent is preserved: failed statuses remain recoverable by WebSocket and polling, completed remains terminal, and the identity guard discards stale in-flight poll responses after dismissal/replacement. Release imports correctly retain schemas/apiSchema rather than the main-only relocated API. The two carrier patches are identical; browser adaptation adds @cloud plus the CI-rendered Cloud baseline. Hosted Cloud browser jobs passed (Core carrier 188; Cloud carrier 191). The existing expected-failure active-download presentation test is not counted as implemented acceptance. Running cancellation, Auto Mode missing-model import and backend retry correctness remain outside this narrow proof. Full target patch, source intent/review, affected release contracts, hosted checks and discussions inspected; no target-specific code defect or human objection found. All hosted checks on this head are terminal non-adverse, and the current-target merge-tree simulation is clean. However the authoritative target-aware guard returns NOT MERGE READY because current core/1.54 is not an ancestor of this head. Refresh onto the current release target and rerun required target-native acceptance and hosted checks, then obtain a new exact-head/target receipt. Green old-base checks do not certify the current integration. REVIEW_REQUIRED is not itself a defect. Review lease on this exact launch head is RELEASED for the sole finalizer to refresh; this is not permission to merge. COMMENT is also the honest review mode when authenticated as this PR's author.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent refresh review: COMMENT / HOLD at exact head 6c7b485 against core/1.54@e79d6ae0ad4e1a0923cf2d92bef4383a387e8dfb. The target-ancestry blocker is fixed. I independently verified that this head has the prior reviewed head and current target as parents, its entire tree exactly equals Git merge-tree's clean automatic merge, and the target-relative stable patch ID is unchanged. The prior source-intent/full-adaptation review therefore carries forward with no target-specific defect; no unresolved review thread or human objection appeared. Finalizer reports focused tests passing (attachments 40/40 per target; downloads 19 passing plus one preserved expected-failure), scoped lint/format/trailer checks and pre-push knip. I have not independently rerun these local tests. The authoritative target-aware guard now rejects only at incomplete hosted checks; required refreshed target-native browser acceptance is also still pending. The activeDownloads presentation test remains an explicit expected-failure residual, not passing acceptance. Running-download cancellation, Auto Mode import and backend retry correctness remain open. This is an adaptation-clear receipt, NOT merge-ready. Bounded review lease RELEASED. Complete and inspect acceptance plus terminal non-adverse hosted evidence and run the live target-aware guard before any authorized merge. An unchanged head/target does not need duplicate code review; a changed head or target invalidates this receipt. REVIEW_REQUIRED itself is not a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent post-history download refresh review: COMMENT / HOLD at 6f95b0e against core/1.54@40c021cfddfcc5bb1fed7bc784b1e28bb5d49699. Independently verified exact clean automatic merge tree of the prior reviewed carrier and the new history target, target ancestry and unchanged source #18082 patch ID e31ee6613bb4a4001293643491eb4783478aeb13. Trailer script passes. No additional product change, target-specific adaptation defect, unresolved discussion or human objection found. Finalizer reports 59 passing tests plus one preserved expected failure per target (download 19 + history 40), source/browser types, scoped lint/format and knip; these fresh local runs are reported rather than independently rerun. The activeDownloads presentation expected-failure remains an explicit open residual. Previous-target affected browser acceptance passed all three cases retry=0, but cannot substitute for pending fresh affected-browser evidence on this head. The authoritative target-aware guard rejects incomplete hosted checks. Adaptation-clear; bounded review lease RELEASED, NOT merge-ready. Complete exact-head acceptance and terminal non-adverse hosted evidence and rerun live guard before any authorized merge. Cloud also has a separate deployment-side-effect authorization hold; review/check readiness does not clear it. Head/target changes invalidate this receipt; REVIEW_REQUIRED alone is not a defect.
christian-byrne
left a comment
There was a problem hiding this comment.
Independent post-dynamic Core adaptation review: COMMENT / HOLD for head 5823386 against core/1.54@ebd07f32ff02e9864aabea3619064966f537d7a0. Independently verified exact clean automatic merge tree of previously reviewed 6f95b0e plus current target, target ancestry and unchanged #18082 source patch ID e31ee6613bb4a4001293643491eb4783478aeb13. Carrier-range trailer script passes. No additional product change, adaptation defect, unresolved thread or new human objection found. Finalizer reports 87 unit passes plus one preserved activeDownloads expected failure, source/browser types, scoped lint/format and knip; these fresh local results are reported, not independently rerun. Fresh exact-head affected-browser acceptance is pending; prior-target browser success is not substituted. The current target-aware guard returns NOT MERGE READY because hosted checks are incomplete. Adaptation-clear; bounded review lease RELEASED, NOT merge-ready. Complete current acceptance and terminal checks, run immediate live guard, supply an explicit clean squash body, and verify actual postmerge tree/trailers. Historical forbidden target trailers are explicitly accepted unrepaired residuals under Christian disposition, not a new carrier defect. No history/protection rewrite is authorized by this review. Head/target movement invalidates the receipt.
christian-byrne
left a comment
There was a problem hiding this comment.
Authorized finalizer COMMENT, not a human approval. Exact head 5823386 against core/1.54@ebd07f32ff02e9864aabea3619064966f537d7a0 has independent adaptation review #18207 (review) and completed independent raw acceptance inspection. Head/target remained unchanged; no unresolved human objection was found.
Exact-head local checks: 87 unit passes plus one preserved activeDownloads expected failure, source/browser types, scoped lint (existing apiSchema warning only), format and knip. Hosted run https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35558105121 embeds merge 5d04d53/base ebd07f3. Its tree 0dba8a36140d445627e1c04d165e6a0a1b61fa02 was independently verified equal to the reviewed head. All three affected browser cases passed retry=0 with the native 15000ms timeout, including recovery snapshot comparison. Whole Cloud-project suite: 208 passed, one unrelated inline-prompt flake that passed on retry, two skipped, zero unexpected failures. The evidence archive SHA256 is 8f0879aace3c2b23cccd71ee5318987ca94330d4911a2555aa970260c4816e2a. Its PNG is explicitly a checked-in baseline, not a fresh runtime capture; successful-case attachments are empty. The reviewer inspected evidence, not reran tests.
The current target-aware guard passed with 89 completed success/neutral/skipped check-runs and no stale receipts/unresolved threads. The PR body contains the prevention-mode Justification line. Christian's September 16/20 grant and latest accepted-residual disposition authorize this guarded admin squash merge, bypassing REVIEW_REQUIRED only. I will rerun the immediate live guard after any body-triggered checks, use the explicit cleaned squash body, and verify actual merged tree/trailers and target push checks.
Residuals retained: historical three forbidden generated trailers (accepted, unrepaired), activeDownloads PM-1302/PM-1309 expected failure, and broader backend/media/import/cancellation acceptance. Mocked Cloud browser boundaries on this Core tree do not certify live-model or deployed-backend behavior. No ruleset change, release-history rewrite, manual dispatch, production release or tag is included.
|
Finalizer terminal receipt: merged at 04:01:04Z as 40adb70 after the immediate current-target guard passed with 91 terminal non-adverse check-runs. Actual product tree 0dba8a36140d445627e1c04d165e6a0a1b61fa02 exactly equals the independently reviewed carrier 5823386 and hosted merge 5d04d53. Exact parent ebd07f3 and target ancestry pass. Actual merged-commit trailer check passes, retaining github-actions and bymyself via the explicit clean squash body. Independent reviewer corroborated the final merge/tree/parent/trailers. Target-push workflows are now all terminal SUCCESS: lint 35559463922, performance 35559463920, E2E 35559464144, unit 35559463892, and dispatch 35559463887. Current check-runs have no unfinished or adverse result; commit statuses are successful. Live Core tip remains this merge. Acceptance: exact-head local 87 unit passes plus one retained activeDownloads expected failure; types/lint/format/knip passed. All three affected hosted browser cases passed retry=0, including recovery snapshot comparison. The premerge Cloud-project suite had 208 passes, one unrelated inline-prompt flake that passed retry=1, two skips, zero unexpected failures. Raw report/tree linkage was independently inspected. The included PNG is a checked-in baseline, not a fresh capture. Evidence archive SHA256: 8f0879aace3c2b23cccd71ee5318987ca94330d4911a2555aa970260c4816e2a. All six scoped carriers are MERGED: dynamic 18172/18173, history 18222/18223, downloads 18207/18208. Cloud tip is 1bbcdc6; its automatic deployment https://github.com/Comfy-Org/cloud/actions/runs/35557895812 is terminal SUCCESS for staging/testcloud and both runtime-verification steps. Residuals remain explicit: Christian accepted the three historical generated Claude squash trailers without repair; activeDownloads PM-1302/PM-1309 expected failure, broader backend/media/import/cancellation acceptance, and the known inline-prompt flake remain open. No rulesets or release history were changed. Mocked boundary acceptance is not deployed-backend or live-model certification. No human approval, production release/tag, or manual deployment is claimed. |
Backport of #18082 to
core/1.54Automatically created by backport workflow.
Justification: Agent 1.54 release backport authorized by Christian's September 16/20 grant; exact head 5823386 was independently adaptation-reviewed against core/1.54@ebd07f32ff02e9864aabea3619064966f537d7a0, required target-native acceptance and terminal hosted checks passed, the current target-aware merge guard passed, and no unresolved human objection remains. REVIEW_REQUIRED is the only branch-protection condition bypassed. Residuals retained: the three historical generated Claude squash trailers are explicitly accepted by Christian, not repaired; activeDownloads expected-failure PM-1302/PM-1309 and broader backend/media/import/cancellation acceptance remain open; the broader hosted Cloud-project suite had one inline-prompt flake that passed on retry, while all three affected download cases passed retry=0. No human approval is claimed.