Repository navigation
[backport core/1.54] fix: guard reportError against re-entrant reports from Sentry normalization - #18528
Conversation
…zation Backport of #18041 to core/1.54.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1938 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T04:20:24.670Z",
"gitSha": "3b11e160900ac59ba24ef3f27bf486a7fa8e2a6a",
"branch": "backport-18041-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2032.3549999999955,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.100999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.11600000000004,
"heapDeltaBytes": -9306344,
"heapUsedBytes": 61369144,
"domNodes": -279,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.216,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2000.5590000000097,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.418000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.82000000000005,
"heapDeltaBytes": 2071728,
"heapUsedBytes": 72832876,
"domNodes": -277,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.127,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1886.2210000000061,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.559,
"layouts": 14,
"layoutDurationMs": 4.871,
"taskDurationMs": 768.2439999999999,
"heapDeltaBytes": 11315068,
"heapUsedBytes": 81289304,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 131.78400000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.2409999999632,
"styleRecalcs": 74,
"styleRecalcDurationMs": 25.984,
"layouts": 14,
"layoutDurationMs": 4.188,
"taskDurationMs": 654.183,
"heapDeltaBytes": -5561216,
"heapUsedBytes": 64061216,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.889,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.5110000000427,
"styleRecalcs": 32,
"styleRecalcDurationMs": 11.921999999999999,
"layouts": 6,
"layoutDurationMs": 0.9579999999999999,
"taskDurationMs": 273.441,
"heapDeltaBytes": 4379728,
"heapUsedBytes": 74702968,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.708,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.873999999993,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.851,
"layouts": 6,
"layoutDurationMs": 1.0040000000000002,
"taskDurationMs": 260.216,
"heapDeltaBytes": 4382068,
"heapUsedBytes": 75244460,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.129000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 515.008999999992,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.35200000000003,
"heapDeltaBytes": -8166924,
"heapUsedBytes": 62857276,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 109.291,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 477.49899999996614,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.733000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.219,
"heapDeltaBytes": 18606196,
"heapUsedBytes": 87992744,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 102.055,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2026.0599999999727,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.618,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.27000000000004,
"heapDeltaBytes": 5049232,
"heapUsedBytes": 81498140,
"domNodes": -277,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 25.996000000000006,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2023.8749999999754,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.606000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.21999999999997,
"heapDeltaBytes": 5004056,
"heapUsedBytes": 81170748,
"domNodes": -275,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 29.26,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2378.477000000032,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.620000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1185.7769999999998,
"heapDeltaBytes": 3210284,
"heapUsedBytes": 80188528,
"domNodes": -275,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 564.167,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2384.514000000024,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.601999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1092.2659999999998,
"heapDeltaBytes": 22120268,
"heapUsedBytes": 88744496,
"domNodes": 10,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 544.8430000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3338.4120000000053,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.991,
"layouts": 60,
"layoutDurationMs": 14.086,
"taskDurationMs": 1241.7240000000002,
"heapDeltaBytes": 9515944,
"heapUsedBytes": 76576296,
"domNodes": 8,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 547.025,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3271.8120000000113,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.645999999999999,
"layouts": 60,
"layoutDurationMs": 13.832,
"taskDurationMs": 1172.508,
"heapDeltaBytes": 9934060,
"heapUsedBytes": 76827156,
"domNodes": -271,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 516.43,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2721.4700000000107,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1518.4630000000002,
"heapDeltaBytes": -7121208,
"heapUsedBytes": 72556536,
"domNodes": -248,
"jsHeapTotalBytes": -368640,
"scriptDurationMs": 733.151,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2746.7060000000174,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.642000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1489.2210000000002,
"heapDeltaBytes": -10486028,
"heapUsedBytes": 69076912,
"domNodes": -250,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 704.032,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.4139999999688,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.478999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.31499999999994,
"heapDeltaBytes": 1123344,
"heapUsedBytes": 78220160,
"domNodes": -284,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 31.201999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.0569999999998,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.915000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.90200000000004,
"heapDeltaBytes": 8338368,
"heapUsedBytes": 86140632,
"domNodes": -271,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 28.248,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.11799999995765,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.575999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.61099999999993,
"heapDeltaBytes": 14753804,
"heapUsedBytes": 87905400,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 98.92300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 480.8489999999779,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.215,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 288.119,
"heapDeltaBytes": 14561280,
"heapUsedBytes": 86654608,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 96.652,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.862000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.629000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.344,
"heapDeltaBytes": 6506172,
"heapUsedBytes": 79697892,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.123,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.1949999999815,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.4559999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.434,
"heapDeltaBytes": -4647612,
"heapUsedBytes": 68262760,
"domNodes": -293,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.775000000000001,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.8990000000208,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.046000000000003,
"layouts": 18,
"layoutDurationMs": 5.047999999999999,
"taskDurationMs": 595.0500000000001,
"heapDeltaBytes": 7217060,
"heapUsedBytes": 80258164,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 85.26,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9890000000073,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.842,
"layouts": 18,
"layoutDurationMs": 4.678,
"taskDurationMs": 574.8559999999999,
"heapDeltaBytes": 4794676,
"heapUsedBytes": 76823644,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 79.626,
"eventListeners": -208,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 834.1440000000375,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.72500000000001,
"layouts": 16,
"layoutDurationMs": 11.275,
"taskDurationMs": 650.2239999999999,
"heapDeltaBytes": 21547584,
"heapUsedBytes": 105608480,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 20.548,
"eventListeners": 2385,
"totalBlockingTimeMs": 71,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9137.047999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 44.675999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4259.134999999999,
"heapDeltaBytes": -13440632,
"heapUsedBytes": 89524836,
"domNodes": -267,
"jsHeapTotalBytes": -106496,
"scriptDurationMs": 1946.678,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 9220.68900000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.833999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4275.648,
"heapDeltaBytes": 17657108,
"heapUsedBytes": 94228016,
"domNodes": -279,
"jsHeapTotalBytes": 905216,
"scriptDurationMs": 1937.8280000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12840.38700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12226.829,
"heapDeltaBytes": -40590868,
"heapUsedBytes": 184033132,
"domNodes": -8068,
"jsHeapTotalBytes": -9678848,
"scriptDurationMs": 184.049,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12718.906999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12074.220000000001,
"heapDeltaBytes": -33837968,
"heapUsedBytes": 171341752,
"domNodes": -8068,
"jsHeapTotalBytes": -6303744,
"scriptDurationMs": 181.861,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15070.77700000002,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.117999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14704.342,
"heapDeltaBytes": -22165080,
"heapUsedBytes": 187884316,
"domNodes": -8068,
"jsHeapTotalBytes": -19304448,
"scriptDurationMs": 705.511,
"eventListeners": -14929,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14843.38299999996,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.199000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14407.654,
"heapDeltaBytes": -31405888,
"heapUsedBytes": 188285152,
"domNodes": -8068,
"jsHeapTotalBytes": -16379904,
"scriptDurationMs": 693.218,
"eventListeners": -14935,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4256.077000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.875000000000014,
"layouts": 20,
"layoutDurationMs": 31.862000000000002,
"taskDurationMs": 4180.937,
"heapDeltaBytes": -47128784,
"heapUsedBytes": 177265964,
"domNodes": -8068,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 95.128,
"eventListeners": -14929,
"totalBlockingTimeMs": 111,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4599.835999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.51600000000001,
"layouts": 20,
"layoutDurationMs": 21.87,
"taskDurationMs": 4521.198,
"heapDeltaBytes": -46760440,
"heapUsedBytes": 172073180,
"domNodes": -8068,
"jsHeapTotalBytes": 19415040,
"scriptDurationMs": 75.35799999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 113,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6173.533999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5776.929000000001,
"heapDeltaBytes": -283780,
"heapUsedBytes": 176806088,
"domNodes": 0,
"jsHeapTotalBytes": -30670848,
"scriptDurationMs": 115.079,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6246.37800000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5981.681,
"heapDeltaBytes": 14321760,
"heapUsedBytes": 192459264,
"domNodes": -1,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 90.96300000000002,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 428.58000000001084,
"styleRecalcs": 16,
"styleRecalcDurationMs": 16.538999999999998,
"layouts": 3,
"layoutDurationMs": 1.38,
"taskDurationMs": 79.587,
"heapDeltaBytes": 4975644,
"heapUsedBytes": 74081660,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.352000000000002,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 59.99999999994543,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.206999999999999,
"layouts": 2,
"layoutDurationMs": 0.622,
"taskDurationMs": 41.745000000000005,
"heapDeltaBytes": 3032680,
"heapUsedBytes": 71348000,
"domNodes": 102,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 3.504,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18528 +/- ##
============================================
Coverage 83.58% 83.59%
============================================
Files 2096 2096
Lines 123796 123807 +11
Branches 31538 33390 +1852
============================================
+ Hits 103481 103492 +11
Misses 20136 20136
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Backport of #18041 to
core/1.54.Before: on
core/1.54, a report raised whilereportErroris already dispatching (for example Sentry's normalizer callingSubgraph.toJSON()) re-enters the reporter and fans out into an error storm.After: the nested report is logged to the console only and the original report completes; one mismatch produces one event.
Manual backport: the automated cherry-pick conflicted in
src/platform/telemetry/reportError.tsbecause this branch's reporter predates the current one; the guard was ported onto the branch's existing dispatch path. Only surrounding context differed:core/1.54lacks main'sRESERVED_TAG_KEYSconstant and the expandedreportErrordoc comment, so thedispatchingflag,logReporthelper and the new tests applied unchanged around the branch's Sentry/Datadog dispatch.Generated by Claude Code