Skip to content

[backport cloud/1.54] fix: guard reportError against re-entrant reports from Sentry normalization - #18530

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18041-to-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18041-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Backport of #18041 to cloud/1.54.

Before: on cloud/1.54, a report raised while reportError is already dispatching (for example Sentry's normalizer calling Subgraph.toJSON()) re-enters the reporter and fans out into an error storm.

After: the nested report is logged to the console only and the original report completes; one mismatch produces one event.

Manual backport: the automated cherry-pick conflicted in src/platform/telemetry/reportError.ts because this branch's reporter predates the current one; the guard was ported onto the branch's existing dispatch path. Only surrounding context differed: cloud/1.54 lacks main's RESERVED_TAG_KEYS constant and the expanded reportError doc comment, so the dispatching flag, logReport helper and the new tests applied unchanged around the branch's Sentry/Datadog dispatch.


Generated by Claude Code

@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@claude
claude Bot requested a review from christian-byrne September 23, 2026 04:12
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 4:12am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: ef8f7c73-3391-42bb-a480-4e32f544728f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1935 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1914 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 04:32:17 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.5 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 53ms TBT · 82.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.9 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 174.0 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 39.9 P5 FPS ❌ (target: ≥52) · 38ms TBT · 174.5 MB heap
vue-zoom-out-idle: · 59.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 165.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 5ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 319ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.3 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -78
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 23ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 545ms
canvas-mouse-sweep: script duration 96ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.9 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -163
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 12ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 244ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 286ms
dom-widget-clipping: script duration 98ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.0 MB
dom-widget-clipping: DOM nodes 23
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 436ms
large-graph-idle: script duration 25ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.2 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -191
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 1177ms
large-graph-pan: script duration 545ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.7 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -191
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1186ms
large-graph-zoom: script duration 517ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 70.0 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 9ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 46
legacy-node-drag: task duration 1299ms
legacy-node-drag: script duration 626ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.5 MB
legacy-node-drag: DOM nodes -119
legacy-node-drag: event listeners 87
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 7ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 371ms
minimap-idle: script duration 23ms
minimap-idle: TBT 0ms
minimap-idle: heap used 81.7 MB
minimap-idle: DOM nodes -266
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 286ms
subgraph-dom-widget-clipping: script duration 95ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.7 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 12
subgraph-idle: task duration 292ms
subgraph-idle: script duration 6ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -223
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 22ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 80
subgraph-mouse-sweep: task duration 558ms
subgraph-mouse-sweep: script duration 78ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.2 MB
subgraph-mouse-sweep: DOM nodes -294
subgraph-mouse-sweep: event listeners -224
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 10ms
subgraph-transition-enter: style recalc duration 21ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 552ms
subgraph-transition-enter: script duration 18ms
subgraph-transition-enter: TBT 53ms
subgraph-transition-enter: heap used 82.7 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 3948ms
viewport-pan-sweep: script duration 1808ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.7 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 10758ms
vue-large-graph-idle: script duration 156ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.9 MB
vue-large-graph-idle: DOM nodes -8085
vue-large-graph-idle: event listeners -14942
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 13ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 69
vue-large-graph-pan: task duration 13560ms
vue-large-graph-pan: script duration 589ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 174.0 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 25ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 53ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4176ms
vue-node-resize-workload: script duration 95ms
vue-node-resize-workload: TBT 38ms
vue-node-resize-workload: heap used 174.5 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 5303ms
vue-zoom-out-idle: script duration 76ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 165.6 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 4
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 4
workflow-execution: style recalc count 12
workflow-execution: task duration 67ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.5 MB
workflow-execution: DOM nodes 126
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-23T04:31:36.930Z",
  "gitSha": "024f84095e3e80a9b05caeffd2377952c87c53bb",
  "branch": "backport-18041-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2013.4119999999598,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.686000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 271.59900000000005,
      "heapDeltaBytes": 425616,
      "heapUsedBytes": 64267800,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 5.759,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2007.4449999999615,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.998999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.847,
      "heapDeltaBytes": 397724,
      "heapUsedBytes": 70474364,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.749999999999998,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1678.4079999999904,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 20.644,
      "layouts": 14,
      "layoutDurationMs": 3.6250000000000004,
      "taskDurationMs": 508.58000000000004,
      "heapDeltaBytes": -13623628,
      "heapUsedBytes": 56880652,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 89.586,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1702.1579999999972,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.818,
      "layouts": 14,
      "layoutDurationMs": 3.985,
      "taskDurationMs": 580.697,
      "heapDeltaBytes": 11336988,
      "heapUsedBytes": 81287748,
      "domNodes": -279,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 102.741,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1654.6069999999986,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 11.105,
      "layouts": 6,
      "layoutDurationMs": 0.888,
      "taskDurationMs": 201.836,
      "heapDeltaBytes": 4471140,
      "heapUsedBytes": 74892620,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 7.042,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1660.3649999999561,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 13.818,
      "layouts": 6,
      "layoutDurationMs": 1.051,
      "taskDurationMs": 286.01200000000006,
      "heapDeltaBytes": 4434328,
      "heapUsedBytes": 75299200,
      "domNodes": 76,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 13.048999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 426.1319999999955,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 7.482,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 280.13100000000003,
      "heapDeltaBytes": 18448560,
      "heapUsedBytes": 88226456,
      "domNodes": 24,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 99.826,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 465.97900000000436,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 7.3359999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 292.594,
      "heapDeltaBytes": -8113684,
      "heapUsedBytes": 62795752,
      "domNodes": 22,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 96.96199999999999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2007.8139999999962,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.192,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.124,
      "heapDeltaBytes": 9616908,
      "heapUsedBytes": 85255720,
      "domNodes": -263,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 19.241,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2008.3500000000072,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.811000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.959,
      "heapDeltaBytes": 3357568,
      "heapUsedBytes": 78787412,
      "domNodes": -279,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 29.884000000000007,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2144.162999999992,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.31,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1090.434,
      "heapDeltaBytes": -10863004,
      "heapUsedBytes": 66241768,
      "domNodes": -281,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 514.956,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2797.9689999999664,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.574,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1264.2,
      "heapDeltaBytes": 6965864,
      "heapUsedBytes": 84167328,
      "domNodes": -275,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 574.702,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3138.5499999999524,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 13.059,
      "layouts": 60,
      "layoutDurationMs": 12.290999999999999,
      "taskDurationMs": 1091.745,
      "heapDeltaBytes": -7947668,
      "heapUsedBytes": 70509176,
      "domNodes": -287,
      "jsHeapTotalBytes": 3825664,
      "scriptDurationMs": 483.122,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3758.434999999963,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.440999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.767,
      "taskDurationMs": 1280.2069999999999,
      "heapDeltaBytes": 9810972,
      "heapUsedBytes": 76232296,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 550.452,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2205.412000000024,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.443999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1206.5359999999998,
      "heapDeltaBytes": 17863708,
      "heapUsedBytes": 85429336,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 592.908,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2703.3369999999195,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.738000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1392.413,
      "heapDeltaBytes": 842864,
      "heapUsedBytes": 81277796,
      "domNodes": -245,
      "jsHeapTotalBytes": -212992,
      "scriptDurationMs": 659.1720000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.166000000008,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.087999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 340.102,
      "heapDeltaBytes": 10413360,
      "heapUsedBytes": 88141460,
      "domNodes": -265,
      "jsHeapTotalBytes": -2727936,
      "scriptDurationMs": 18.775999999999993,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.9899999999834,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.332999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 402.282,
      "heapDeltaBytes": 5424092,
      "heapUsedBytes": 83261428,
      "domNodes": -267,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 27.869999999999997,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 397.37800000000334,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 8.307,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 250.035,
      "heapDeltaBytes": 14958420,
      "heapUsedBytes": 87586088,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 86.53000000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.0339999999633,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.125,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 322.56399999999996,
      "heapDeltaBytes": 15066112,
      "heapUsedBytes": 87924540,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 104.08300000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1988.2130000000302,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.732000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 284.193,
      "heapDeltaBytes": -12937268,
      "heapUsedBytes": 59733640,
      "domNodes": -294,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 5.337999999999999,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1991.8399999999679,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.781999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 300.39099999999996,
      "heapDeltaBytes": 9313796,
      "heapUsedBytes": 82486656,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.47,
      "eventListeners": -238,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1689.5930000000021,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 21.478,
      "layouts": 18,
      "layoutDurationMs": 4.119000000000001,
      "taskDurationMs": 508.83500000000004,
      "heapDeltaBytes": -6057248,
      "heapUsedBytes": 66815820,
      "domNodes": -293,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 69.78899999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1728.6579999999958,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 22.691000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.38,
      "taskDurationMs": 607.056,
      "heapDeltaBytes": 5528196,
      "heapUsedBytes": 78405416,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 85.45899999999999,
      "eventListeners": -208,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 800.3780000000233,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 21.266000000000002,
      "layouts": 16,
      "layoutDurationMs": 10.154,
      "taskDurationMs": 551.853,
      "heapDeltaBytes": -5372416,
      "heapUsedBytes": 86723828,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 18.466000000000005,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 53,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8094.799999999964,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.50000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3436.894,
      "heapDeltaBytes": 6492480,
      "heapUsedBytes": 82146528,
      "domNodes": -267,
      "jsHeapTotalBytes": -1454080,
      "scriptDurationMs": 1689.0590000000002,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9940.535999999953,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 43.184,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4458.18,
      "heapDeltaBytes": 13451276,
      "heapUsedBytes": 89210608,
      "domNodes": -270,
      "jsHeapTotalBytes": -143360,
      "scriptDurationMs": 1927.7440000000001,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10503.616000000022,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9608.231,
      "heapDeltaBytes": -41297480,
      "heapUsedBytes": 178673260,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14999552,
      "scriptDurationMs": 134.935,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12478.894999999966,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11907.853,
      "heapDeltaBytes": -50834536,
      "heapUsedBytes": 183991492,
      "domNodes": -8102,
      "jsHeapTotalBytes": -6012928,
      "scriptDurationMs": 177.946,
      "eventListeners": -14951,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13902.184000000034,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.022000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13402.056999999999,
      "heapDeltaBytes": -6256960,
      "heapUsedBytes": 198985340,
      "domNodes": -8068,
      "jsHeapTotalBytes": -5324800,
      "scriptDurationMs": 575.1460000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14158.009999999991,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 13.178999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13718.479,
      "heapDeltaBytes": -52531732,
      "heapUsedBytes": 165851100,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14139392,
      "scriptDurationMs": 603.478,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4288.131999999961,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 54.07700000000001,
      "layouts": 20,
      "layoutDurationMs": 22.12600000000001,
      "taskDurationMs": 4211.952,
      "heapDeltaBytes": -23111044,
      "heapUsedBytes": 188901720,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12931072,
      "scriptDurationMs": 69.47599999999998,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 66,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4264.15499999996,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 52.19000000000001,
      "layouts": 20,
      "layoutDurationMs": 20.614000000000008,
      "taskDurationMs": 4140.219999999999,
      "heapDeltaBytes": -47431636,
      "heapUsedBytes": 177051708,
      "domNodes": -8068,
      "jsHeapTotalBytes": 6311936,
      "scriptDurationMs": 119.57799999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 10,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 5378.406999999981,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4964.032000000001,
      "heapDeltaBytes": -9963432,
      "heapUsedBytes": 176698544,
      "domNodes": 0,
      "jsHeapTotalBytes": -48758784,
      "scriptDurationMs": 67.04100000000001,
      "eventListeners": 14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6119.044999999915,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5642.007999999999,
      "heapDeltaBytes": 1793936,
      "heapUsedBytes": 170562644,
      "domNodes": 0,
      "jsHeapTotalBytes": -14155776,
      "scriptDurationMs": 84.698,
      "eventListeners": -6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 436.57300000000987,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 18.902999999999995,
      "layouts": 5,
      "layoutDurationMs": 1.827,
      "taskDurationMs": 92.112,
      "heapDeltaBytes": 5120676,
      "heapUsedBytes": 73391748,
      "domNodes": 149,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.251999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 73.1829999999718,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 8.379000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.659,
      "taskDurationMs": 42.717000000000006,
      "heapDeltaBytes": 3001564,
      "heapUsedBytes": 72265316,
      "domNodes": 102,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 3.1719999999999993,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18530   +/-   ##
=============================================
  Coverage              ?   78.60%           
=============================================
  Files                 ?     2009           
  Lines                 ?   111120           
  Branches              ?    31423           
=============================================
  Hits                  ?    87350           
  Misses                ?    23591           
  Partials              ?      179           
Flag Coverage Δ
unit 78.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/reportError.ts 95.71% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 1b4814a into cloud/1.54 Sep 23, 2026
100 of 103 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18041-to-cloud-1.54 branch September 23, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants