Repository navigation
test: establish a shared scripts/app automock - #18018
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2092 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.96 MB gzip 🔴 +271 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +13.7 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.31 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.92 MB (baseline 3.6 MB) • 🔴 +314 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.8 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.42 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T20:00:24.029Z",
"gitSha": "ae23749f15f05389fe00370956aea8a633cd128a",
"branch": "test/scripts-app-automock",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.431000000035,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.098,
"heapDeltaBytes": 9843144,
"heapUsedBytes": 77292864,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.666999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.8550000000205,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.610000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.82500000000005,
"heapDeltaBytes": 4676096,
"heapUsedBytes": 66864352,
"domNodes": -264,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.748,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.7259999999796,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.578,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.99,
"heapDeltaBytes": -6082656,
"heapUsedBytes": 61475372,
"domNodes": -260,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 162.69799999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.1149999999752,
"styleRecalcs": 45,
"styleRecalcDurationMs": 17.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.2719999999999,
"heapDeltaBytes": -4987984,
"heapUsedBytes": 62551880,
"domNodes": -260,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 169.072,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.1439999999507,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.093,
"layouts": 6,
"layoutDurationMs": 0.9840000000000001,
"taskDurationMs": 347.805,
"heapDeltaBytes": 3164852,
"heapUsedBytes": 70709172,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.451999999999996,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.743000000044,
"styleRecalcs": 31,
"styleRecalcDurationMs": 12.974,
"layouts": 6,
"layoutDurationMs": 0.9910000000000001,
"taskDurationMs": 329.39000000000004,
"heapDeltaBytes": 3049156,
"heapUsedBytes": 70582772,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.629,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 664.9360000000115,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.574000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.17599999999993,
"heapDeltaBytes": 18571284,
"heapUsedBytes": 80833700,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.95300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 723.6240000000862,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.561999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.06000000000006,
"heapDeltaBytes": 18917444,
"heapUsedBytes": 86332248,
"domNodes": 18,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 171.05499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.7499999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 945.4079999999999,
"heapDeltaBytes": -16955060,
"heapUsedBytes": 73035376,
"domNodes": -297,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 74.42000000000002,
"eventListeners": -217,
"totalBlockingTimeMs": 578,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.5239999999112,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.9960000000001,
"heapDeltaBytes": 34953716,
"heapUsedBytes": 104164656,
"domNodes": 0,
"jsHeapTotalBytes": 17723392,
"scriptDurationMs": 76.815,
"eventListeners": 0,
"totalBlockingTimeMs": 577,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.8579999999642,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.0249999999998,
"heapDeltaBytes": 14605260,
"heapUsedBytes": 90978180,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 173.05300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6279999999724,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.0159999999998,
"heapDeltaBytes": 14800400,
"heapUsedBytes": 90389232,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.02399999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 236,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10063.306999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9082.391,
"heapDeltaBytes": 700276,
"heapUsedBytes": 83196776,
"domNodes": -14,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7726.503,
"eventListeners": 0,
"totalBlockingTimeMs": 1219,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10152.158999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9242.273,
"heapDeltaBytes": -13385812,
"heapUsedBytes": 68881796,
"domNodes": -16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 7865.168,
"eventListeners": 0,
"totalBlockingTimeMs": 1148,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10463.255000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9610.42,
"heapDeltaBytes": 17721156,
"heapUsedBytes": 93399000,
"domNodes": -8,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7910.883,
"eventListeners": 0,
"totalBlockingTimeMs": 1164,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10955.123999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10070.01,
"heapDeltaBytes": 11645828,
"heapUsedBytes": 93274992,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 8329.077,
"eventListeners": 0,
"totalBlockingTimeMs": 1154,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2033.7370000000305,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.328,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.9479999999999,
"heapDeltaBytes": 1919916,
"heapUsedBytes": 83532908,
"domNodes": -241,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 34.08599999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.3290000000134,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.494000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.57399999999996,
"heapDeltaBytes": -3872160,
"heapUsedBytes": 83430676,
"domNodes": -240,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 39.424,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2387.6450000000204,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.283000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1704.285,
"heapDeltaBytes": 20215108,
"heapUsedBytes": 85086252,
"domNodes": -249,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 905.8580000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2267.029999999977,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.354999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1529.79,
"heapDeltaBytes": -3570340,
"heapUsedBytes": 84303280,
"domNodes": -246,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 859.8240000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3596.123000000034,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.929,
"layouts": 60,
"layoutDurationMs": 13.091000000000001,
"taskDurationMs": 1712.212,
"heapDeltaBytes": 10575416,
"heapUsedBytes": 74753404,
"domNodes": -255,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 789.674,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3574.6659999999792,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.221000000000002,
"layouts": 60,
"layoutDurationMs": 13.213,
"taskDurationMs": 1652.3540000000003,
"heapDeltaBytes": 7677240,
"heapUsedBytes": 73868392,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.836,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3175.77399999999,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.258999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2008.0269999999998,
"heapDeltaBytes": -4241512,
"heapUsedBytes": 86952480,
"domNodes": -228,
"jsHeapTotalBytes": 970752,
"scriptDurationMs": 1024.527,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3154.2800000000852,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.042000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1946.892,
"heapDeltaBytes": 22605472,
"heapUsedBytes": 88163364,
"domNodes": -252,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 999.6629999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.2739999999912,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.175,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.726,
"heapDeltaBytes": -5217552,
"heapUsedBytes": 83743928,
"domNodes": -246,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.591,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.8810000000503,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.711000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.6529999999999,
"heapDeltaBytes": -4615692,
"heapUsedBytes": 84128396,
"domNodes": -246,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.553,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.8289999999852,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.759,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.36000000000007,
"heapDeltaBytes": 13701468,
"heapUsedBytes": 83469544,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.191,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.2069999999494,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.209999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.149,
"heapDeltaBytes": 13738692,
"heapUsedBytes": 76710696,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.75500000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.2169999999828,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.417000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.094,
"heapDeltaBytes": 9491664,
"heapUsedBytes": 78475724,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.371000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.6440000000648,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.083,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.20199999999994,
"heapDeltaBytes": -5390576,
"heapUsedBytes": 64487516,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.371999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.8119999999662,
"styleRecalcs": 45,
"styleRecalcDurationMs": 16.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.1370000000001,
"heapDeltaBytes": -4196236,
"heapUsedBytes": 65709112,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 111.992,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.779000000036,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.007000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 761.109,
"heapDeltaBytes": 3306420,
"heapUsedBytes": 66877184,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 106.709,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.5159999999914,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.209,
"layouts": 5,
"layoutDurationMs": 13.288999999999998,
"taskDurationMs": 952.0020000000001,
"heapDeltaBytes": -6217092,
"heapUsedBytes": 81708360,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 32.252,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8454.294000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.962999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5946.153,
"heapDeltaBytes": -6286068,
"heapUsedBytes": 80479600,
"domNodes": -239,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2838.3109999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8294.983000000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 36.11000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5636.346,
"heapDeltaBytes": -2034632,
"heapUsedBytes": 85128956,
"domNodes": -240,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2763.6440000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17286.19900000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16874.961,
"heapDeltaBytes": -49185860,
"heapUsedBytes": 177635804,
"domNodes": -8061,
"jsHeapTotalBytes": -15532032,
"scriptDurationMs": 278.75600000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17058.234000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16607.511000000002,
"heapDeltaBytes": -35183008,
"heapUsedBytes": 191979904,
"domNodes": -8061,
"jsHeapTotalBytes": -13434880,
"scriptDurationMs": 258.28799999999995,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20427.620000000046,
"styleRecalcs": 159,
"styleRecalcDurationMs": 17.598999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20183.045,
"heapDeltaBytes": -58944780,
"heapUsedBytes": 169268868,
"domNodes": -8061,
"jsHeapTotalBytes": -18485248,
"scriptDurationMs": 892.098,
"eventListeners": -14928,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20694.035000000098,
"styleRecalcs": 164,
"styleRecalcDurationMs": 17.896999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20343.948,
"heapDeltaBytes": -33426016,
"heapUsedBytes": 180788728,
"domNodes": -8061,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 867.1110000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 84,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6240.958999999975,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.36100000000003,
"layouts": 20,
"layoutDurationMs": 33.03399999999999,
"taskDurationMs": 6190.61,
"heapDeltaBytes": -66641388,
"heapUsedBytes": 168782068,
"domNodes": -8061,
"jsHeapTotalBytes": 9977856,
"scriptDurationMs": 108.37599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 622,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6186.88700000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.792,
"layouts": 20,
"layoutDurationMs": 26.532000000000014,
"taskDurationMs": 6112.923000000002,
"heapDeltaBytes": -55479180,
"heapUsedBytes": 172240156,
"domNodes": -8061,
"jsHeapTotalBytes": 9236480,
"scriptDurationMs": 112.08699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 548,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8736.159999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8541.734,
"heapDeltaBytes": 23048448,
"heapUsedBytes": 183687592,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 133.614,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6713.418999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6424.448,
"heapDeltaBytes": 10360888,
"heapUsedBytes": 174782624,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 114.19900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 491.1179999999149,
"styleRecalcs": 23,
"styleRecalcDurationMs": 28.805999999999997,
"layouts": 4,
"layoutDurationMs": 2.029,
"taskDurationMs": 141.18999999999997,
"heapDeltaBytes": 5166036,
"heapUsedBytes": 70812508,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.245999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 472.2980000000234,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.117,
"layouts": 3,
"layoutDurationMs": 1.4950000000000003,
"taskDurationMs": 127.46999999999997,
"heapDeltaBytes": 5049764,
"heapUsedBytes": 70514060,
"domNodes": 148,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.316,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9e4e22a4a11c268226f4e80eaa85787f104655fb
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughChangesSlotLinkReveal test mocking
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The shared mock and migrated test are mergeable with no identified actionable risk. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18018 +/- ##
==========================================
+ Coverage 83.36% 84.30% +0.93%
==========================================
Files 2984 2285 -699
Lines 147253 130169 -17084
Branches 38063 36262 -1801
==========================================
- Hits 122764 109743 -13021
+ Misses 23207 20130 -3077
+ Partials 1282 296 -986
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 719 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Approving at 3b2ffad6. The mock is carefully built and the single migration is faithful.
What I checked
- Export surface matches.
src/scripts/app.tshas exactly four runtime exports (app,ComfyApp,sanitizeNodeName,ANIM_PREVIEW_WIDGET;QueuePromptOptionsis type-only). The mock provides all four, sovi.mock(import('@/scripts/app'))cannot leave a consumer with anundefinedimport. - Drift is compile-checked. Every field in
AppState,Canvas,canvasActions,actions,settings,setting,uiActionsis derived fromRealComfyApp[...]viaPick/indexed access rather than hand-written. A signature change on the real class becomes a type error here, which is the right property for a mock that 132 more suites are meant to adopt. - Getter semantics line up with production.
isGraphReadymirrors!!rootGraphInternal;rootGraphfails where production logsComfyApp graph accessed before initialization;rootGraphOrUndefinedstays tolerant. - Shared spy identity is safe here.
createState()spreads module-levelvi.mockObject(..., { spy: true })functions into every test's state, so call history would accumulate — exceptvite.config.mtssetsmockReset: trueandrestoreMocks: trueglobally, which clears history and restores the declared implementations (including theassert.faildefaults) before each test. I also confirmed the repo has notest.concurrent/describe.concurrentusage insrc/, soTestRunner.getCurrentTest()keying state onto the test context is not exposed to the concurrency hazard today. - The migration preserves coverage.
SlotLinkReveal.test.tskeeps all four assertions with identical payloads. The old factory suppliedcanvas.graph = { id: 'root-a', rootGraph: { id: 'root-a' } }; the automock supplies a realLGraphwhoserootGraphresolves to itself, and the newbeforeEachpinsidto'root-a', so the scope the test asserts against is unchanged. The addedvi.mocked(app.canvas.setDirty).mockClear()narrows thetoHaveBeenCalledWith(false, true)assertion to the post-error render, which is a tightening, not a loosening.
One non-blocking suggestion inline.
| state().rootGraph = value | ||
| }, | ||
| get graph(): RealComfyApp['graph'] { | ||
| return app.rootGraph |
There was a problem hiding this comment.
suggestion (non-blocking): graph is stricter than production here, which will make one production path unreachable for the 132 suites queued behind this.
Production tolerates an uninitialised graph:
// src/scripts/app.ts
get graph() {
return this.rootGraphInternal! // undefined at runtime, no throw
}
get rootGraph(): LGraph {
if (!this.rootGraphInternal) console.error('ComfyApp graph accessed before initialization')
return this.rootGraphInternal!
}In the mock, graph delegates to rootGraph, which assert.exists(...). So a test that wants to exercise the not-ready path — set app.rootGraphOrUndefined = undefined, then assert the consumer degrades gracefully instead of crashing — cannot express it: reading app.graph throws inside the mock before the consumer's own guard runs. isGraphReady correctly reports false in that state, which makes the mismatch easy to trip over.
For rootGraph the strictness is a deliberate and good call (production only console.errors, so failing loudly in tests is better). But graph is the property consumers actually read behind an isGraphReady / truthiness check, so having it return state().rootGraph directly would let those branches be tested. Not blocking this PR — SlotLinkReveal.test.ts never hits it — but worth settling before the bulk migration locks the contract in.
There was a problem hiding this comment.
Fixed in c324618. graph now returns the nullable test-owned root directly, with its type derived from rootGraphOrUndefined. The stricter rootGraph getter is unchanged.
Removed the mock-only regression test in 537a80b. The existing SlotLinkReveal, useSlotLinkReveal, and linkRevealState suites pass all eight tests. Full typechecking and Knip also pass locally. The nullability fix is unchanged.
There was a problem hiding this comment.
Tracked as FE-2778. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
c324618
Summary
Add a shared
scripts/appmanual mock so existing factory mocks can migrate in separate PRs. Related to FE-2343.Changes
unknown, 31 typed/inferred, including aliases, relative imports, and six module-reset suites.SlotLinkReveal.test.ts, preserving its assertions and payloads. No production changes or dependencies. Open-PR and sibling ownership checks found only the approved, identical inherited copy in feat(settings): hoist the workspace header and collapse it on scroll #16438.Review Focus
Configure mutable state in
beforeEachor sequential tests. Reacquire the module aftervi.resetModules().Loading and queueing resolve
falseby default. Graph conversion, missing-model refresh, deserialization, setting registration, and sanitization require explicit configuration.ComfyAppexposes clipboard statics, not a constructor.Later migrations still need scenario results and real graph fixtures. The mock does not reproduce renderer behavior or output-store synchronization. The obsolete
revokePreviewsstub and test-only__mockAppmarker are omitted. The other 132 factories remain unchanged.Local validation
Remaining test suites to migrate (132)
From this PR's inventory. Recheck open-PR ownership before each migration; this list does not reserve files.
src/App.test.tssrc/components/TopMenuSection.test.tssrc/components/boundingBoxes/WidgetBoundingBoxes.test.tssrc/components/builder/AppBuilder.test.tssrc/components/builder/BuilderFooterToolbar.test.tssrc/components/builder/builderViewOptions.test.tssrc/components/builder/useResolvedSelectedInputs.test.tssrc/components/error/ErrorOverlay.test.tssrc/components/error/useErrorOverlayState.test.tssrc/components/graph/GraphCanvas.test.tssrc/components/graph/NodeTooltip.test.tssrc/components/graph/selectionToolbox/ColorPickerButton.test.tssrc/components/graph/widgets/TextPreviewWidget.test.tssrc/components/rightSidePanel/RightSidePanel.test.tssrc/components/rightSidePanel/errors/ErrorGroupList.test.tssrc/components/rightSidePanel/errors/ErrorNodeCard.test.tssrc/components/rightSidePanel/errors/TabErrors.test.tssrc/components/rightSidePanel/errors/swapNodeGroups.test.tssrc/components/rightSidePanel/errors/useErrorGroups.test.tssrc/components/rightSidePanel/errors/useErrorReport.test.tssrc/components/videoEdit/WidgetVideoEdit.test.tssrc/composables/boundingBoxes/useBoundingBoxes.test.tssrc/composables/canvas/useFocusNode.test.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectionToolboxPosition.test.tssrc/composables/graph/useGroupMenuOptions.test.tssrc/composables/graph/useNodeMenuOptions.test.tssrc/composables/graph/useSelectionOperations.deleteGuard.test.tssrc/composables/maskeditor/useBrushAdjustment.test.tssrc/composables/maskeditor/useBrushDrawing.test.tssrc/composables/maskeditor/useMaskEditorLoader.test.tssrc/composables/maskeditor/useMaskEditorSaver.test.tssrc/composables/maskeditor/useToolManager.test.tssrc/composables/node/useNodeAnimatedImage.test.tssrc/composables/node/useNodeBadge.test.tssrc/composables/node/usePartnerNodesInGraph.test.tssrc/composables/painter/usePainter.test.tssrc/composables/useCoreCommands.test.tssrc/composables/usePaste.test.tssrc/composables/useViewErrorsInGraph.test.tssrc/composables/video/useVideoSourceUrl.test.tssrc/extensions/core/editAttention.test.tssrc/extensions/core/groupNode.test.tssrc/extensions/core/groupOptions.test.tssrc/extensions/core/load3d.test.tssrc/extensions/core/load3d/Load3DConfiguration.test.tssrc/extensions/core/load3dLazy.test.tssrc/extensions/core/load3dPreviewExtensions.test.tssrc/extensions/core/nodeTemplates.test.tssrc/extensions/core/previewAny.test.tssrc/extensions/core/saveImageExtraOutput.test.tssrc/extensions/core/saveMesh.test.tssrc/extensions/core/textPreviewWidgets.test.tssrc/extensions/core/uploadAudio.test.tssrc/extensions/core/widgetInputs.refreshCombo.test.tssrc/extensions/core/widgetInputs.test.tssrc/extensions/core/widgetValuePropagation.test.tssrc/platform/assets/composables/useMediaAssetActions.test.tssrc/platform/assets/services/assetService.test.tssrc/platform/assets/utils/assetPreviewUtil.test.tssrc/platform/auth/session/useSessionCookie.test.tssrc/platform/cloud/subscription/composables/useFreeTierQuota.test.tssrc/platform/keybindings/keybindingService.dialog.test.tssrc/platform/keybindings/keybindingService.escape.test.tssrc/platform/keybindings/presetService.test.tssrc/platform/missingMedia/components/MissingMediaCard.test.tssrc/platform/missingMedia/missingMediaStore.test.tssrc/platform/missingModel/components/MissingModelRow.test.tssrc/platform/missingModel/composables/useMissingModelInteractions.test.tssrc/platform/missingModel/missingModelPipeline.test.tssrc/platform/nodeReplacement/missingNodeScan.test.tssrc/platform/nodeReplacement/nodeReplacementStore.test.tssrc/platform/nodeReplacement/useNodeReplacement.test.tssrc/platform/settings/settingStore.test.tssrc/platform/telemetry/utils/getExecutionContext.test.tssrc/platform/updates/common/useFrontendVersionMismatchWarning.test.tssrc/platform/updates/components/WhatsNewPopup.test.tssrc/platform/workflow/core/services/workflowService.insertWorkflow.test.tssrc/platform/workflow/core/services/workflowService.test.tssrc/platform/workflow/management/stores/workflowStore.test.tssrc/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.tssrc/platform/workflow/persistence/stores/workflowDraftStoreV2.fsm.test.tssrc/platform/workflow/persistence/stores/workflowDraftStoreV2.test.tssrc/platform/workflow/sharing/composables/useSharedWorkflowUrlLoader.test.tssrc/platform/workflow/sharing/services/workflowShareService.test.tssrc/platform/workflow/templates/composables/useTemplateWorkflows.test.tssrc/renderer/core/canvas/canvasStore.test.tssrc/renderer/core/canvas/useCanvasInteractions.test.tssrc/renderer/extensions/compositor/components/WidgetCompositor.test.tssrc/renderer/extensions/compositor/composables/compositorSession.test.tssrc/renderer/extensions/firstRunTour/tour/firstRunTourDefinition.test.tssrc/renderer/extensions/linearMode/LinearPreview.test.tssrc/renderer/extensions/minimap/composables/useMinimap.intervalLifecycle.test.tssrc/renderer/extensions/minimap/composables/useMinimap.progressBaseline.test.tssrc/renderer/extensions/minimap/composables/useMinimap.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.subgraph.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.test.tssrc/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.autoPan.test.tssrc/renderer/extensions/vueNodes/composables/useSlotLinkReveal.test.tssrc/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.tssrc/renderer/extensions/vueNodes/layout/ensureCorrectLayoutScale.test.tssrc/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.test.tssrc/renderer/extensions/vueNodes/widgets/composables/useImagePreviewWidget.test.tssrc/renderer/extensions/vueNodes/widgets/composables/useMarkdownWidget.test.tssrc/renderer/extensions/vueNodes/widgets/composables/useStringWidget.test.tssrc/renderer/extensions/vueNodes/widgets/utils/forwardMiddleButtonToCanvas.test.tssrc/renderer/extensions/vueNodes/widgets/utils/multilineTextarea.promoted.test.tssrc/renderer/glsl/glslPreviewStoreContract.test.tssrc/scripts/changeTracker.test.tssrc/scripts/ui.setStatus.test.tssrc/scripts/ui.test.tssrc/scripts/ui/toggleSwitch.test.tssrc/services/autoQueueService.test.tssrc/services/litegraphService.test.tssrc/stores/appModeStore.test.tssrc/stores/executionStore.test.tssrc/stores/missingMediaPreviewRegression.test.tssrc/stores/nodeOutputStore.test.tssrc/stores/nodeOutputStore.workflowSwitch.test.tssrc/stores/subgraphNavigationStore.navigateToHash.test.tssrc/stores/subgraphNavigationStore.test.tssrc/stores/subgraphNavigationStore.viewport.test.tssrc/stores/subgraphStore.test.tssrc/views/GraphView.test.tssrc/workbench/extensions/agent/AgentPanelRoot.test.tssrc/workbench/extensions/agent/crdt/CrdtDevPanel.clipboard.test.tssrc/workbench/extensions/agent/crdt/CrdtDevPanel.test.tssrc/workbench/extensions/agent/crdt/apiTransport.test.tssrc/workbench/extensions/agent/crdt/crossWorkflowPending.test.tssrc/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.tssrc/workbench/extensions/manager/composables/nodePack/useMissingNodes.test.tssrc/workbench/extensions/manager/composables/useManagerQueue.test.ts