Repository navigation
ci: skip test suites that a PR's changed test files cannot affect - #18648
Conversation
Split changes-filter's should-run into should-run-unit, should-run-e2e and should-run-source. Playwright specs, snapshots, plans and configs no longer trigger Vitest; **/*.test.ts no longer triggers the Playwright suites or the perf project; neither triggers the ecosystem matrix, size data, dist telemetry scan or OSS asset validation. Over the last 300 merged PRs this would have skipped unit tests on 12.7% (from 6.3%), E2E on 11.3% and the source-only jobs on 18.0%. Amp-Thread-ID: https://ampcode.com/threads/T-01a0d072-69e2-778c-9910-050bcb8a3af5
🎭 Playwright: ✅ 2129 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 4346841849b93cf02b8d80e3751d5479c2553f28
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.99 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.83 kB (baseline 3.83 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.44 MB (baseline 1.44 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.96 MB (baseline 3.96 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 578 kB (baseline 578 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T23:38:28.672Z",
"gitSha": "20b1e6ffb49e35821c2c78276b217efb4b91ef73",
"branch": "ci/skip-irrelevant-test-suites",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.566999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.407,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.897,
"heapDeltaBytes": -5977188,
"heapUsedBytes": 61708528,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.185,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.4969999999912,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.300000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.91600000000005,
"heapDeltaBytes": 3931764,
"heapUsedBytes": 71610776,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.443,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1736.4789999999743,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.747000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 697.39,
"heapDeltaBytes": -5867432,
"heapUsedBytes": 61802448,
"domNodes": -261,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 162.737,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1765.476999999919,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.187999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 824.887,
"heapDeltaBytes": -5372620,
"heapUsedBytes": 62597304,
"domNodes": -262,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 166.81799999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.445000000107,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.808,
"layouts": 6,
"layoutDurationMs": 0.975,
"taskDurationMs": 319.46799999999996,
"heapDeltaBytes": 2750332,
"heapUsedBytes": 70270292,
"domNodes": 79,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.955,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.108000000063,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.317999999999998,
"layouts": 6,
"layoutDurationMs": 1.209,
"taskDurationMs": 418.08,
"heapDeltaBytes": 2701036,
"heapUsedBytes": 70483396,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 17.708000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 703.9210000000367,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.271,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.661,
"heapDeltaBytes": 18598568,
"heapUsedBytes": 86343792,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 168.19299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 740.0330000000395,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.684000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.76200000000006,
"heapDeltaBytes": 18867892,
"heapUsedBytes": 86233192,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 177.32899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.8880000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 885.1549999999999,
"heapDeltaBytes": 13267116,
"heapUsedBytes": 103446172,
"domNodes": -295,
"jsHeapTotalBytes": 24530944,
"scriptDurationMs": 65.236,
"eventListeners": -195,
"totalBlockingTimeMs": 601,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1197.9000000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.4090000000001,
"heapDeltaBytes": 12918240,
"heapUsedBytes": 83665152,
"domNodes": 0,
"jsHeapTotalBytes": 20344832,
"scriptDurationMs": 74.18,
"eventListeners": 0,
"totalBlockingTimeMs": 588,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 855.372999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.7299999999997,
"heapDeltaBytes": 14876064,
"heapUsedBytes": 91546512,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.758,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.6879999999765,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.8320000000002,
"heapDeltaBytes": 14221700,
"heapUsedBytes": 90614516,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.773,
"eventListeners": 0,
"totalBlockingTimeMs": 230,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9683.23700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8867.347,
"heapDeltaBytes": 3401440,
"heapUsedBytes": 85381732,
"domNodes": -12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7516.064,
"eventListeners": 0,
"totalBlockingTimeMs": 1264,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10575.668999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9583.111,
"heapDeltaBytes": 9829480,
"heapUsedBytes": 91681316,
"domNodes": -14,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 7931.192,
"eventListeners": 0,
"totalBlockingTimeMs": 1162,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10790.141000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9834.476999999999,
"heapDeltaBytes": -692840,
"heapUsedBytes": 81134092,
"domNodes": -10,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8164.525,
"eventListeners": 0,
"totalBlockingTimeMs": 1350,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10993.243000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10022.976,
"heapDeltaBytes": 12069168,
"heapUsedBytes": 93990548,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8284.511,
"eventListeners": 0,
"totalBlockingTimeMs": 1117,
"frameDurationMs": 19.996666666666595,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2030.335999999977,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.034000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.318,
"heapDeltaBytes": -3372864,
"heapUsedBytes": 83092228,
"domNodes": -241,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 34.235,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2038.0729999999403,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.952999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 588.7379999999999,
"heapDeltaBytes": -3201740,
"heapUsedBytes": 83458348,
"domNodes": -244,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 33.336000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2588.978999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.914000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1745.9099999999999,
"heapDeltaBytes": -6986004,
"heapUsedBytes": 80408776,
"domNodes": -221,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 926.423,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2845.017999999982,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.230000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1826.057,
"heapDeltaBytes": -10802860,
"heapUsedBytes": 76941256,
"domNodes": -220,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 916.4730000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3620.783000000017,
"styleRecalcs": 63,
"styleRecalcDurationMs": 11.318999999999999,
"layouts": 60,
"layoutDurationMs": 13.278000000000002,
"taskDurationMs": 1689.419,
"heapDeltaBytes": 8099160,
"heapUsedBytes": 74173584,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 801.847,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3985.6829999999945,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.006999999999996,
"layouts": 60,
"layoutDurationMs": 14.812000000000001,
"taskDurationMs": 1895.616,
"heapDeltaBytes": 11675544,
"heapUsedBytes": 77859604,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 873.6030000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3156.1140000000023,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.293999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1952.244,
"heapDeltaBytes": 26200612,
"heapUsedBytes": 92230120,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1000.148,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3211.2200000000257,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.405000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2170.1319999999996,
"heapDeltaBytes": 29585872,
"heapUsedBytes": 95408720,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1099.096,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2021.325000000047,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.06,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.926,
"heapDeltaBytes": -4824296,
"heapUsedBytes": 84182168,
"domNodes": -245,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 31.337000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.729000000012,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.911,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.917,
"heapDeltaBytes": 20206540,
"heapUsedBytes": 84217244,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.045,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.7619999999561,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.35600000000005,
"heapDeltaBytes": 13781396,
"heapUsedBytes": 83697412,
"domNodes": 22,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 149.40699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 691.4070000000265,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.245,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.80600000000004,
"heapDeltaBytes": 14075180,
"heapUsedBytes": 83054128,
"domNodes": 21,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.162,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2005.078000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.898,
"heapDeltaBytes": 10454188,
"heapUsedBytes": 79363584,
"domNodes": -274,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.598999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1992.8750000000264,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.338999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.565,
"heapDeltaBytes": 6357592,
"heapUsedBytes": 76509344,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1738.0449999999996,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.889000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 771.076,
"heapDeltaBytes": 3834396,
"heapUsedBytes": 73773432,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 111.486,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.336000000033,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.684999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 810.268,
"heapDeltaBytes": 9976408,
"heapUsedBytes": 73800360,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 116.22500000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.457999999987,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.970000000000002,
"layouts": 5,
"layoutDurationMs": 13.402999999999999,
"taskDurationMs": 966.6730000000001,
"heapDeltaBytes": 20265044,
"heapUsedBytes": 103426528,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.002000000000002,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8299.24600000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 39.398,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5164.0199999999995,
"heapDeltaBytes": -10571872,
"heapUsedBytes": 76233040,
"domNodes": -240,
"jsHeapTotalBytes": 745472,
"scriptDurationMs": 2738.0440000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11417.45400000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.641,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6831.0650000000005,
"heapDeltaBytes": -1955408,
"heapUsedBytes": 84603260,
"domNodes": -244,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 3191.3650000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16974.617999999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16493.011,
"heapDeltaBytes": -50844456,
"heapUsedBytes": 167124760,
"domNodes": -8061,
"jsHeapTotalBytes": -11730944,
"scriptDurationMs": 274.393,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18095.367999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17785.65,
"heapDeltaBytes": -53341540,
"heapUsedBytes": 193846444,
"domNodes": -8061,
"jsHeapTotalBytes": -14049280,
"scriptDurationMs": 298.056,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20667.731000000003,
"styleRecalcs": 156,
"styleRecalcDurationMs": 16.789000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20453.277,
"heapDeltaBytes": -34840192,
"heapUsedBytes": 191671368,
"domNodes": -8061,
"jsHeapTotalBytes": -16183296,
"scriptDurationMs": 901.141,
"eventListeners": -14928,
"totalBlockingTimeMs": 68,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21201.126000000044,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.141999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20968.183,
"heapDeltaBytes": -69406972,
"heapUsedBytes": 171883040,
"domNodes": -8061,
"jsHeapTotalBytes": -16977920,
"scriptDurationMs": 906.1260000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 134,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 4850.463999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.59800000000003,
"layouts": 20,
"layoutDurationMs": 23.460000000000008,
"taskDurationMs": 4738.283,
"heapDeltaBytes": -53481484,
"heapUsedBytes": 186930600,
"domNodes": -8061,
"jsHeapTotalBytes": 17408000,
"scriptDurationMs": 93.587,
"eventListeners": -14928,
"totalBlockingTimeMs": 123,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6051.918999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.909,
"layouts": 20,
"layoutDurationMs": 22.635,
"taskDurationMs": 5959.618999999999,
"heapDeltaBytes": -43653508,
"heapUsedBytes": 176335044,
"domNodes": -8061,
"jsHeapTotalBytes": 14438400,
"scriptDurationMs": 108.36800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 414,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8518.903000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8351.511999999999,
"heapDeltaBytes": 5064936,
"heapUsedBytes": 178580852,
"domNodes": 0,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 132.776,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8626.616000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8425.048999999999,
"heapDeltaBytes": 11845952,
"heapUsedBytes": 183981320,
"domNodes": 0,
"jsHeapTotalBytes": -27525120,
"scriptDurationMs": 140.18399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 121.16000000003169,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.562,
"layouts": 3,
"layoutDurationMs": 0.947,
"taskDurationMs": 87.59500000000001,
"heapDeltaBytes": 3193576,
"heapUsedBytes": 68872104,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.639000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 457.559999999944,
"styleRecalcs": 15,
"styleRecalcDurationMs": 24.305,
"layouts": 4,
"layoutDurationMs": 1.875,
"taskDurationMs": 125.3,
"heapDeltaBytes": 4888520,
"heapUsedBytes": 70430284,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.462,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe changes-filter action now provides separate unit, e2e, and source outputs. CI workflows use the relevant category output. The ecosystem matrix and custom-nodes workflow retain conditions that enable runs for pull requests with at least 3,000 changed files. ChangesCI change filters
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~12 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established; merge after normal CI checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18648 +/- ##
==========================================
+ Coverage 83.72% 84.64% +0.92%
==========================================
Files 3020 2294 -726
Lines 149137 131368 -17769
Branches 38534 35446 -3088
==========================================
- Hits 124860 111201 -13659
+ Misses 22973 19867 -3106
+ Partials 1304 300 -1004
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
AustinMroz
left a comment
There was a problem hiding this comment.
Changes seem reasonable to me, but I remain ill versed in ci actions.
Summary
Narrow the
changes-filtergate so a PR that only touches one kind of test file no longer runs the suites that file cannot affect.Changes
changes-filtergainsshould-run-unit,should-run-e2e, andshould-run-source, eachshould-runminus one set of test files. Same event gating asshould-run: push and non-candidate merge_group still run everything.should-run-unitdropsbrowser_tests/**/*.spec.ts,browser_tests/**/*-snapshots/**,browser_tests/specs/**,playwright*.config.ts. Used by ci-tests-unit.should-run-e2edrops**/*.test.tsand**/__mocks__/**. Used by ci-tests-e2e, ci-perf-report (perf specs live inbrowser_tests), and the currently inert ci-tests-custom-nodes.should-run-sourcedrops both sets. Used by ci-ecosystem-matrix, ci-size-data, ci-dist-telemetry-scan, ci-oss-assets-validation.- *relevant,- *unit); dorny/paths-filter flattens nested rule arrays, so an exclusion added torelevantpropagates.should-runjob output.Split is by file kind, not directory. Vitest includes
browser_tests/**/*.test.ts, a unit test readsbrowser_tests/fixtures/data/agent/conversations, and the ecosystem matrix importsbrowser_tests/assets/default.jsonandvitest.setup.ts, sobrowser_tests/**as a whole cannot be excluded from anything. Playwright'stestIgnoreexcludes*.test.ts, which makes the.spec.ts/.test.tssuffix the ownership boundary.__mocks__modules are reachable only through a factory-lessvi.mock()in a test: no non-test source imports one today,vitest.setup.tssupplies its own factory, and the matrix runner never callsvi.mock.Review Focus
dot: true, the version the pinned action locks. Over the last 300 merged PRs: unit skips 12.7% (was 6.3%), E2E 11.7%, source-only jobs 18.3%.*.test.tsand*.test.ts+__mocks__PRs (e.g. test: migrate store tests to shared automocks #18488, test: add third automock foundation batch #18010) skip E2E, perf, ecosystem, size, and telemetry and still run unit; PRs that also touchcodecov.yml/knip.config.ts(test: adopt website auth and billing automocks #18020, test: share select component automocks #15100, test: centralize unit test isolation and shared automocks #15104) still run everything.e2e-statusand ci-ecosystem-matrix's status job already emit pass onshould-run == false; a skipped ci-tests-unittestjob satisfies branch protection the same way docs-only PRs do today.unitande2eflags alreadycarryforward: trueand project status is disabled, so a partial upload does not read as a coverage drop.workflow_dispatch.browser_testshelpers and fixtures (still run everything),.stories.ts-only PRs (0 of 300), PRs whose onlyshould-run-relevant files were under.github/**(4 of 300).