Repository navigation
refactor(account): cut the private utility dependencies and prep ingest-types for publish - #17839
MaanilVerma wants to merge 16 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2024 passed, 0 failed · 1 flaky📊 Browser Reports
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-17839.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-9ugbekups-comfyui.vercel.app Last updated: 2026-09-16T17:19:55Z for 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-16T17:29:22.570Z",
"gitSha": "2484bf06d5da2da854f580f80f3073fbf6513fb4",
"branch": "maanil/fe-2196-d2-consumability",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.9180000000415,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.322,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.23499999999996,
"heapDeltaBytes": 4017396,
"heapUsedBytes": 65815600,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.806000000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.6939999999963,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.2,
"heapDeltaBytes": 12877808,
"heapUsedBytes": 73786668,
"domNodes": -266,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 11.078000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2086.728999999991,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.129,
"layouts": 14,
"layoutDurationMs": 5.109,
"taskDurationMs": 1131.909,
"heapDeltaBytes": 12502384,
"heapUsedBytes": 73303140,
"domNodes": -263,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 189.882,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1856.3080000000127,
"styleRecalcs": 76,
"styleRecalcDurationMs": 30.595000000000002,
"layouts": 14,
"layoutDurationMs": 4.476,
"taskDurationMs": 949.767,
"heapDeltaBytes": 18371912,
"heapUsedBytes": 80066960,
"domNodes": -261,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 161.719,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.9569999999894,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.031999999999996,
"layouts": 6,
"layoutDurationMs": 1.543,
"taskDurationMs": 404.10599999999994,
"heapDeltaBytes": 2162120,
"heapUsedBytes": 63976356,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.701999999999995,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.1739999999672,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.116999999999997,
"layouts": 6,
"layoutDurationMs": 1.4089999999999998,
"taskDurationMs": 392.736,
"heapDeltaBytes": 2212124,
"heapUsedBytes": 63945664,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.394999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 728.507000000036,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.456,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.683,
"heapDeltaBytes": 18089116,
"heapUsedBytes": 78965316,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.244,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 738.5439999999903,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.503999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.871,
"heapDeltaBytes": 18110596,
"heapUsedBytes": 80044960,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.259,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2051.928999999973,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.7490000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.014,
"heapDeltaBytes": 3185220,
"heapUsedBytes": 81930400,
"domNodes": -252,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 38.869,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2017.1689999999671,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.691999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.0500000000001,
"heapDeltaBytes": 2333660,
"heapUsedBytes": 81967508,
"domNodes": -249,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 35.369,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 3061.590000000024,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.187999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1753.011,
"heapDeltaBytes": 3531568,
"heapUsedBytes": 84393400,
"domNodes": -250,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 942.966,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 3053.0770000000302,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.123000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1761.8799999999999,
"heapDeltaBytes": 19163200,
"heapUsedBytes": 83031628,
"domNodes": -255,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 844.096,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3905.6449999999927,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.936,
"layouts": 60,
"layoutDurationMs": 13.739,
"taskDurationMs": 1819.1999999999998,
"heapDeltaBytes": 10243804,
"heapUsedBytes": 74772944,
"domNodes": -252,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 800.985,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3909.1039999999566,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.439000000000004,
"layouts": 60,
"layoutDurationMs": 13.799999999999997,
"taskDurationMs": 1833.1009999999999,
"heapDeltaBytes": 9357084,
"heapUsedBytes": 74172288,
"domNodes": -260,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.61,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3122.351999999978,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.1539999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2017.4530000000002,
"heapDeltaBytes": 19238860,
"heapUsedBytes": 84979504,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 983.379,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3211.4250000000766,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.935999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2160.361,
"heapDeltaBytes": -111628,
"heapUsedBytes": 83105332,
"domNodes": -261,
"jsHeapTotalBytes": 409600,
"scriptDurationMs": 1025.0689999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.6420000000335,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.481000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.3690000000001,
"heapDeltaBytes": -4184956,
"heapUsedBytes": 82903584,
"domNodes": -249,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 40.131,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.8149999999614,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.647000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.4770000000001,
"heapDeltaBytes": -3651620,
"heapUsedBytes": 83304676,
"domNodes": -253,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 36.418000000000006,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.8039999999837,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.279999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.636,
"heapDeltaBytes": 13588816,
"heapUsedBytes": 76447156,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.28600000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 622.6779999999508,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.836,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.559,
"heapDeltaBytes": 13480988,
"heapUsedBytes": 76419136,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.173,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.4440000000168,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.093000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.158,
"heapDeltaBytes": 13117156,
"heapUsedBytes": 76135712,
"domNodes": -277,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.457,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.36600000001,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.32,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.1239999999999,
"heapDeltaBytes": 9681376,
"heapUsedBytes": 72687068,
"domNodes": -275,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.229000000000003,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.803999999996,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.288999999999994,
"layouts": 18,
"layoutDurationMs": 6.085,
"taskDurationMs": 867.4169999999999,
"heapDeltaBytes": -6525364,
"heapUsedBytes": 56310400,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 106.766,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.213000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.971000000000004,
"layouts": 18,
"layoutDurationMs": 5.984,
"taskDurationMs": 939.6039999999999,
"heapDeltaBytes": 9569480,
"heapUsedBytes": 72568712,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 116.76399999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0999999999854,
"styleRecalcs": 16,
"styleRecalcDurationMs": 26.630000000000003,
"layouts": 5,
"layoutDurationMs": 11.530999999999999,
"taskDurationMs": 942.4820000000001,
"heapDeltaBytes": -6489908,
"heapUsedBytes": 85816400,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 31.536,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9947.46299999997,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6360.692,
"heapDeltaBytes": -4284720,
"heapUsedBytes": 74844660,
"domNodes": -250,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 2840.8410000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9499.347000000056,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6314.793,
"heapDeltaBytes": 201104,
"heapUsedBytes": 78567744,
"domNodes": -247,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 2862.6580000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15607.732999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15244.931999999999,
"heapDeltaBytes": -51228968,
"heapUsedBytes": 186036544,
"domNodes": -8061,
"jsHeapTotalBytes": -3477504,
"scriptDurationMs": 229.96500000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15386.057999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15138.062000000002,
"heapDeltaBytes": -38258948,
"heapUsedBytes": 176795056,
"domNodes": -8061,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 245.18400000000003,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18882.93900000002,
"styleRecalcs": 139,
"styleRecalcDurationMs": 18.711000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18759.897,
"heapDeltaBytes": -46121244,
"heapUsedBytes": 167157560,
"domNodes": -8061,
"jsHeapTotalBytes": -16945152,
"scriptDurationMs": 869.832,
"eventListeners": -14928,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18569.76899999995,
"styleRecalcs": 136,
"styleRecalcDurationMs": 18.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18386.956,
"heapDeltaBytes": -33284344,
"heapUsedBytes": 176185348,
"domNodes": -8061,
"jsHeapTotalBytes": -12652544,
"scriptDurationMs": 862.607,
"eventListeners": -14928,
"totalBlockingTimeMs": 32,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5619.140999999956,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.911,
"layouts": 20,
"layoutDurationMs": 38.23000000000001,
"taskDurationMs": 5579.993999999999,
"heapDeltaBytes": -61454876,
"heapUsedBytes": 168396472,
"domNodes": -8061,
"jsHeapTotalBytes": 10952704,
"scriptDurationMs": 106.882,
"eventListeners": -14928,
"totalBlockingTimeMs": 294,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5600.142000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.31400000000002,
"layouts": 20,
"layoutDurationMs": 25.386999999999993,
"taskDurationMs": 5566.160999999999,
"heapDeltaBytes": -39245912,
"heapUsedBytes": 174840788,
"domNodes": -8061,
"jsHeapTotalBytes": 15093760,
"scriptDurationMs": 103.255,
"eventListeners": -14928,
"totalBlockingTimeMs": 313,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7731.625999999949,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7582.169000000001,
"heapDeltaBytes": 12297436,
"heapUsedBytes": 168043540,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 122.21199999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7818.614000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7668.784000000001,
"heapDeltaBytes": 35779884,
"heapUsedBytes": 196800168,
"domNodes": 0,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 120.10899999999991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 132.85200000001396,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.31,
"layouts": 4,
"layoutDurationMs": 1.866,
"taskDurationMs": 97.23900000000002,
"heapDeltaBytes": 3181708,
"heapUsedBytes": 64471648,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.844000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 468.93199999999524,
"styleRecalcs": 13,
"styleRecalcDurationMs": 23.403999999999996,
"layouts": 4,
"layoutDurationMs": 2.055,
"taskDurationMs": 130.96600000000004,
"heapDeltaBytes": 4867292,
"heapUsedBytes": 66084900,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.165,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## maanil/fe-2196-d2-packaging-prep #17839 +/- ##
====================================================================
- Coverage 82.64% 82.63% -0.02%
====================================================================
Files 2858 2860 +2
Lines 142043 142060 +17
Branches 36530 38365 +1835
====================================================================
- Hits 117394 117391 -3
- Misses 23449 23469 +20
Partials 1200 1200
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dante01yoon
left a comment
There was a problem hiding this comment.
Checked the three things that could actually bite here, and all three are fine:
- The
zodpeer range.ingest-typesdeclarespeerDependencies: { zod: "^3.23.8" }whileaccountkeepszod: "catalog:"as a normal dependency. The installed catalog resolution is3.25.76, which satisfies^3.23.8, so no peer conflict and no second zod copy — which is the whole point, since two copies breakinstanceofon the generated schemas. - The shared
networkUtil.tstrim. The file survives withcheckUrlReachable; only the 111-line region half is removed.src/components/common/UrlInput.vuestill importscheckUrlReachablefrom@/utils/networkUtiland resolves. - Region consumers.
getClientCountry/isInChinahave exactly one non-test consumer at this head,packages/account/src/vue/regionGate.ts, so there is genuinely one copy of the region check now rather than two.
The licensing rationale for copying rather than publishing is sound and worth restating: shared-frontend-utils would have dragged axios and a GPL-3.0-only package under an MIT manifest. Cutting two deps to avoid that is the right call even at the cost of duplication. One suggestion on the duplication inline.
Validation (head aed8ecdd): account package 46 files / 762 tests green; website src/config 79 files / 2464 tests green; cloud auth-area suites 134 files / 2888 tests green.
| @@ -0,0 +1,111 @@ | |||
| // Copy of packages/shared-frontend-utils/src/loadExternalScript.ts (three app callers keep that one); keep both in sync | |||
There was a problem hiding this comment.
suggestion (non-blocking): the copy is justified, but a comment is the weakest possible sync mechanism for 111 lines that three app callers still use from the shared package. These will drift, and the drift will be silent.
Since this one is byte-identical by construction, a tiny test that reads both files and asserts equality would turn drift into a CI failure instead of a production surprise:
// account-side test
const mine = readFileSync(resolve(__dirname, './loadExternalScript.ts'), 'utf8')
const shared = readFileSync(require.resolve('@comfyorg/shared-frontend-utils/src/loadExternalScript.ts'), 'utf8')
expect(mine).toBe(shared)That does depend on the package still being reachable from the workspace at test time, which it is today. If you would rather not couple the test to the sibling's path, the alternative is a note on FE-2196 to delete the shared copy once its three callers move — but then the comment should say "delete after the callers move" rather than "keep both in sync".
| import type { ClassArray } from 'clsx' | ||
| import { extendTailwindMerge } from 'tailwind-merge' | ||
|
|
||
| // Mirrors packages/tailwind-utils/src/index.ts; keep both configs in sync |
There was a problem hiding this comment.
suggestion (non-blocking): same point as loadExternalScript.ts, and slightly sharper here because the drift is silent and visual — if tailwind-utils gains a font-size key (the config currently carries text-xxs/text-xxxs and max-h-none) and this copy does not, class merging diverges and the symptom is a subtly wrong style, not an error.
Your four-row merge test covers the current config. Extending it to assert the full extendTailwindMerge option object matches the one tailwind-utils exports would catch an added key rather than just the behaviors you enumerated.
dante01yoon
left a comment
There was a problem hiding this comment.
Not blocking, one heads-up on packages/account/src/vue/cn.ts plus the clsx / tailwind-merge dependencies: they are the right call while the Vue pieces still live in this package, but they are Vue-layer concerns and will move out with them.
Context: the plan's first decision (Billing SDK implementation plan V2, "The Vue layer leaves @comfyorg/account") is that the core keeps zero Vue coupling by construction and the composables and components ship from @comfyorg/account-ui. The move is open as #17854 (stacked on the account-core rename #17851): src/vue/** → packages/account-ui/src/auth/**, exported as ./auth/*, and the core's package.json drops vue, @vueuse/core, vue-tsc and @vitejs/plugin-vue. When that lands after your stack, cn.ts goes to account-ui with PasswordRules.vue (account-ui already depends on @comfyorg/tailwind-utils, so it can just use the shared cn there), and clsx / tailwind-merge leave the core again.
Nothing to change here; just so the follow-up is not a surprise. Sequencing: your stack lands first, then #17851 and #17854 are regenerated on top of it (the rename is a replay script).
|
Sequencing update: #17851 (rename to |
|
Change of plan so nobody does this twice: the billing track is taking the publish preparation — files allowlist + pack smoke test (#17838), the private-dependency cut and ingest-types prep (#17839), and the compiled |
|
Follow-up: the private-utility cut is on the billing track as #17882. One deliberate divergence from this PR: no |
|
Superseded by #17882, which carries this work on the renamed, Vue-free tree. Kept open as a draft for reference. |
…contract and ingest-types (Comfy-Org#17882) ## Why `@comfyorg/account-core`, `@comfyorg/billing-contract` and `@comfyorg/ingest-types` are about to be installed by Platform from the public registry, and today none of them can be packed: `exports` point at `src/*.ts`, there is no `files` allowlist, no build, and the core still reaches into a private workspace utility. The release workflows on Comfy-Org#17881 assume `build` and `smoke:pack` exist; this PR is the part that makes a tarball installable in plain Node. Built on Comfy-Org#17854 (auth Vue surface → `account-ui`, now merged) so the core builds from a Vue-free tree, and it reproduces Maanil's Comfy-Org#17838 / Comfy-Org#17839 / Comfy-Org#17840 on the renamed tree as agreed in the review thread there. Base is `main`. ## How - **Private-utility cut** — the one remaining reach out of the core was `turnstileScript.ts` → `@comfyorg/shared-frontend-utils/loadExternalScript`. The loader is now package-owned (`packages/account-core/src/loadExternalScript.ts`, byte-identical) and `@comfyorg/shared-frontend-utils` leaves the core's dependencies. `publishBoundary.test.ts` fails on any future `workspace:` dependency that is not itself published (`@comfyorg/ingest-types` is the only allowed one). - **Manifests** — `files: ["dist"]`, `sideEffects: false`, `repository`/`homepage`/`author`, MIT `LICENSE` per package, `publishConfig.exports` mapping every dev `exports` entry to `dist/*.js` + `.d.ts`, `./package.json` export, `access: public`. `@comfyorg/ingest-types` moves `zod` to a peer so a consumer never gets two zod copies. `private: true` stays on all three (`ingest-types` had no `private` at all; it now has the latch). Flipping `private` is a one-line change per manifest in a later reviewed PR. - **Build** — `tsconfig.build.json` per package (`declaration`, `noEmitOnError`, `types: []`, tests and fixtures excluded), `build` = `clean` + `tsc -p`, `prepack` runs it. Relative imports carry `.js` so the emitted ESM resolves under `nodenext`; `openapi-ts.config.ts` sets `importFileExtension: '.js'` so regeneration keeps it. - **Smoke pack** — `scripts/smokePack.ts` (run as `pnpm --filter @comfyorg/account-core smoke:pack`) packs all three, checks each tarball (no source/test/fixture files, every export target present, no unrewritten `catalog:`/`workspace:`), installs them into a throwaway npm project, imports all 21 entries from plain Node ESM, and type-checks a `nodenext` consumer. Dropping one `.js` extension makes the typed step fail with `TS2835`, which the plain-Node step alone would not catch. - **CI** — `ci-packages-pack.yaml` on `pull_request` for the three package paths: matrix job per package (typecheck → build → `check:pack`) plus one `smoke-consumer` job. The tarball rules live in one pure module, `publishableTarball.ts`, with its own test file; the CLI and the smoke test are two entry points onto it, so CI and the smoke test cannot drift. Deliberate divergences from Comfy-Org#17839: no `region` export and no deletion in `shared-frontend-utils/networkUtil.ts` (the region gate moved to `account-ui` with the Vue surface and three app suites still import it); `createScriptLoader` stays in the shared package for its three `src/platform` callers. Open point: the root `LICENSE` is GPL-3.0 while all three manifests already declare MIT (as `@comfyorg/design-system` publishes). Without a per-package file pnpm would inject the GPL text into a tarball whose manifest says MIT, so the MIT files fix the actual defect; whether the SDK packages should be MIT at all is a call for the reviewer to confirm. ## AS-IS / TO-BE No UI change; packages, scripts and CI only. - AS-IS: `pnpm pack` on any of the three ships `src/*.ts` (or nothing) with `exports` a consumer cannot resolve, and the core depends on a private workspace package. - TO-BE: `smoke:pack` proves the three tarballs install and import from plain Node with types, and CI runs that proof on every change to the packages. ## Testing | Check | Result | | --- | --- | | `build` account-core / billing-contract / ingest-types | 92 / 18 / 6 dist files | | `smoke:pack` | 3 packed, 21 entries imported under Node ESM, `nodenext` tsc clean | | vitest account-core / account-ui / billing-contract / billing-web | 675 / 79 / 62 / 90 pass | | `pnpm typecheck`, `pnpm lint`, `pnpm format:check`, `pnpm knip` (with `dist` on disk) | exit 0 | | `yamllint` on the new workflow | clean | ## Where this sits in the plan Billing SDK track FE-2210 ([implementation plan V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid model: top-up in-app, subscription management / invoices / payment methods on the hosted billing app. | Phase | Item | Ticket | Status | | --- | --- | --- | --- | | 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged | | 3 | Operation lifecycle, commands, eight-state projection | FE-2227/2214/2223 | merged (Comfy-Org#17655) | | 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 | merged (Comfy-Org#17662, Comfy-Org#17663) | | 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled` | FE-2216 | merged (Comfy-Org#17665) | | rollout C | `hosted_billing_destination` server flag read by the host | FE-2218 | merged (Comfy-Org#17716) | | rollout C | `hostedDestination` port on the lifecycle, value on operation state | FE-2210/2218 | Comfy-Org#17783 (review, carries slice 2a) | | 7 prep | Scope-source port + credentialed transport (BFF / cookie hosts) | FE-2218 | merged (Comfy-Org#17782) | | 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename | FE-2218 | merged (Comfy-Org#17851) | | 7 prep | Auth Vue surface → `account-ui`; core Vue-free by construction | FE-2215 | merged (Comfy-Org#17854) | | 7 prep | `billing-contract` route builder + `return_to` registry | FE-2218 | merged (Comfy-Org#17795) | | 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 | merged (Comfy-Org#17793) | | 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) | | 8 core | Plans + saved payment-methods readers | FE-2331 | merged (Comfy-Org#17798) | | 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`, `usePreviewSubscribe`) | FE-2331 | merged (Comfy-Org#17798) | | 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218 | merged (Comfy-Org#17798) | | 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) | FE-2218 | merged (Comfy-Org#17827, Comfy-Org#17844) | | 7 | ingest CORS + top-up return hosts for billing.comfy.org and its previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) | | 8 ui | billing-web `/v1` entry routing + subscription / payment-method surfaces | FE-2331 | merged (Comfy-Org#17798) | | 7 | Package release workflows + versioning ADR (bump PR → publish on merge, snapshots) | FE-2218 | Comfy-Org#17881 (review) | | 7 | Publish readiness: dist build, files allowlist, pack smoke test, private-utility cut | FE-2218 | **this PR** | | 7 | First publish (`private` off), Platform install, billing-web live top-up | FE-2218 | todo | | 6 | Contract tests per generated schema (package layer) | FE-2217 | Comfy-Org#17829 (review) | | 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo (needs staging flags) | | 5 slice 2 | Subscription flows through the SDK | FE-2216 | Comfy-Org#17856 / Comfy-Org#17860 (review) | | follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665 review) | FE-2216 | merged (Comfy-Org#17792) | | follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) | FE-2227 | merged (Comfy-Org#17794) | | follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799 review) | FE-2215 | merged (Comfy-Org#17824) | | follow-up | credits / status / capabilities readers fence a late failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged (Comfy-Org#17828) | ```mermaid flowchart LR P3["Phase 3 core lifecycle (merged)"] P4["Phase 4 account-ui (merged)"] P5["Phase 5 slice 1 top-up flag (merged)"] FC["PR 17716 hosted_billing_destination flag (merged)"] HD["PR 17783 hostedDestination port"] SS["PR 17782 scope-source port + credentialed transport"] RN["account-core rename (merged)"] AV["auth Vue surface to account-ui (merged)"] RB["billing-contract route builder + return_to"] WS["Workshop adapter"] P8PV["previewSubscribe command"] P8RD["plans + payment-methods readers"] P8["account-ui hosted composables"] BWS["billing-web session + sign-in"] BWV["billing-web /v1 surfaces"] CORS["cloud PR 9512 ingest CORS + return hosts"] RW["PR 17881 release workflows + ADR"] PR["publish readiness: dist, files, smoke pack"] PUB["first publish account-core / billing-contract / ingest-types"] P7["Phase 7 host proof: Platform + billing-web live"] P6C["Phase 6 contract tests"] P6["Phase 6 live evidence"] S2["Phase 5 slice 2 subscription"] FU9["customer-attention predicate"] FU11["opaque BillingServerCode"] FU12["useCredits clears on SUPERSEDED"] FU13["reader late-failure fence"] P3 --> HD FC --> HD HD --> RB P3 --> SS SS --> P7 RB --> P7 P3 --> RN RN --> AV AV --> PR RW --> PUB PR --> PUB RB --> PUB PUB --> P7 P3 --> P8PV P3 --> P8RD P8PV --> P8 P8RD --> P8 P4 --> P8 P8 --> S2 P8 --> BWS BWS --> BWV RB --> BWV BWV --> P7 CORS --> P7 P5 --> P6 P3 --> P6C P5 --> WS P5 --> FU9 P3 --> FU11 P4 --> FU12 P3 --> FU13 style P3 fill:#d4edda,stroke:#155724 style P4 fill:#d4edda,stroke:#155724 style P5 fill:#d4edda,stroke:#155724 style FC fill:#d4edda,stroke:#155724 style SS fill:#d4edda,stroke:#155724 style RB fill:#d4edda,stroke:#155724 style WS fill:#d4edda,stroke:#155724 style FU9 fill:#d4edda,stroke:#155724 style BWV fill:#d4edda,stroke:#155724 style BWS fill:#d4edda,stroke:#155724 style P8 fill:#d4edda,stroke:#155724 style P8RD fill:#d4edda,stroke:#155724 style CORS fill:#d4edda,stroke:#155724 style FU13 fill:#d4edda,stroke:#155724 style FU12 fill:#d4edda,stroke:#155724 style FU11 fill:#d4edda,stroke:#155724 style P8PV fill:#d4edda,stroke:#155724 style RN fill:#d4edda,stroke:#155724 style AV fill:#d4edda,stroke:#155724 style PR stroke:#0366d6,stroke-width:4px ```
… boundary (Comfy-Org#17830) ## Summary The session client's state now changes in exactly one place, and the closure no longer owns the credential cache or single-flight minting. A pure `transition(state, event)` in the new `core/sessionState.ts` owns every commit, `createSessionClient` only runs the ordered effects it hands back, and the storage codec and in-flight dedup live in `credentialCache.ts` and `mintCoordinator.ts`. This is the decomposition DrJKL asked for before the client becomes the shared auth foundation, and it changes no behavior except the two tightenings called out under Review Focus. Fixes FE-2191 ## Changes - `packages/account-core/src/core/sessionState.ts` is new. It holds one `SessionState` record, a `SessionEvent` union (identity changed or detached, invalidated, mint started, mint committed or rejected by caller or scheduler, credential adopted or expired), and `transition`, which returns the next state plus an ordered list of effects (`persist`, `armScheduler`, `clearStorage`, `stopScheduler`, `abandonInFlight`, `publish`). Effects carry their own payload, so the runner never reads state after the fact. - The same module has `arbitrateMint`, which is `refreshWith`'s old guard ladder (invalidation epoch, mint sequence, popup path, settled-null block, joiner reuse) lifted out as a pure verdict, and `scheduledMintHolds`, the old inline `guardsHold`. The guards inside `arbitrateMint` are named by the verdict they return (`userMismatchBlocksCommit`, `popupSettled`, `lostRace`), not by the situation they detect. - `createSessionClient` in `session.ts` keeps one `let state` and one `commit(event)`. The eleven places that used to set `credential`, `credentialTarget`, `failure`, `committedMint` and the epochs by hand are gone; the scheduler's `RefreshHost` callbacks call `commit` with the matching event. `session.ts` goes from 742 lines to 541, and the closure body from 512 to 330. - `credentialCache.ts` owns the cached-credential schema, the pure encode and decode (uid-filtered for the cache, unfiltered for a cross-tab message), `createCredentialCache`, which wraps the host's `CredentialStorage` with the same swallowed read, write and clear failures as before, and the freshness policy: `isCredentialFresh` and `selectFreshCredential`, the memory-then-storage, exact-target, first-fresh-wins rule that `ensureCore` used to inline. `CredentialStorage` and `isCredentialFresh` are re-exported from `session.ts`, so nothing a host imports moved. - `mintCoordinator.ts` owns only the in-flight mint: `canJoin` and the `.finally` that clears it while it is still the same promise. - `RefreshHost.commitRefreshed` now takes the `mintId` the scheduler minted with, so the recorded `committedMint` names an explicit id instead of reading the sequence at commit time. - `identity.ts` imports `AccountUser` from `sessionContracts` instead of `session`, which removes a type cycle. - `core/__fixtures__/sessionFakes.ts` holds the storage, user, credential, identity and exchange fakes the session suites share. The three new suites and the two existing ones import from it instead of carrying their own copies; no assertion changed. - `sessionState.test.ts` is a table over state × event, including the pairs that must be no-ops (a preserved transient failure, expiry of a credential that is no longer live even when value-equal) and the reference-identity cases that `arbitrateMint` and `credential-expired` depend on. `credentialCache.test.ts` and `mintCoordinator.test.ts` cover the codec rejects, the join-versus-start matrix and the candidate order. ## Review Focus - The claim that nothing changed rests on `session.test.ts` and `session.scheduler.test.ts` passing with their assertions untouched; the only edits to those two files swap their local helpers for the shared fixture imports. If you want to spot-check one site, the asymmetries are the ones worth a look: a caller-side permanent failure stops the scheduler and clears the target, a scheduler-side one only clears storage (`sessionState.ts`, the `mint-rejected` case). Those match the old code on purpose. - `commitExpired` in `session.ts` commits only when the expiring credential is still the live one, by reference, and returns the failure the transition produced. The value-equal clone row in the table pins that a stale copy is a no-op. - `mint-started` is a separate event solely so `mintSequence` lives in the one state record. It has no effects. - Tightening one: the popup mint now requires exactly one identity event since it started. `popupSettled` in `sessionState.ts` checks `identityEpoch === startEpoch + 1`; the old code accepted any number of events as long as the uid matched. The `sessionState.test.ts` row "a popup mint that crossed two identity events is superseded even when the uid matches again" pins it. - Tightening two: the stored-credential read is lazy. `selectFreshCredential` takes thunks (`credentialCache.ts`), so storage is not touched when the in-memory credential is fresh; the old inline code read storage every time. `session.test.ts` "serves a fresh in-memory credential without touching storage" pins it. - `selectFreshCredential` checks the uid on both candidates where the old inline code checked only the in-memory one. The stored candidate is already uid-filtered by `decodeCached`, so no outcome changes; flagging it because it reads like a tightening. ## QA - [x] Unit: `pnpm --filter @comfyorg/account-core test` 39 files, 716 tests - [x] Test diff against the base (`git diff --numstat origin/maanil/fe-2188-localization-sso...HEAD -- '**/*.test.ts'`): `credentialCache.test.ts` +210/-0, `mintCoordinator.test.ts` +157/-0, `sessionState.test.ts` +541/-0 (new files), `session.test.ts` +31/-70 and `session.scheduler.test.ts` +43/-91 (helper definitions replaced by fixture imports, plus one new test in `session.test.ts`); the shared fixture `__fixtures__/sessionFakes.ts` is +110/-0. No assertion was removed from an existing test. - [x] Consumers: `src/platform/workspace/stores` 326 tests, website `src/config` 2459 tests, all green - [x] Coverage: the two new modules are fully covered; `session.ts` keeps the same three pre-existing uncovered items (the fetch fallback chain, the expiry no-op return, the no-user early return) and nothing new - [x] fallow cyclomatic on `session.ts`: `refreshWith` 38 → 10, `ensureCore` 12 → 7 - [x] `pnpm typecheck` (root and package), `pnpm lint`, `oxfmt --check`, `pnpm knip` all clean - Not covered: no e2e run. This change is package-internal and flag-independent; the cloud store's delegation call sites are unchanged. This PR stacks on Comfy-Org#17643 and merges after it. Resolves review comment from @DrJKL on Comfy-Org#17283: [r3976008869](Comfy-Org#17283 (comment)). Linear: [FE-2191](https://linear.app/comfyorg/issue/FE-2191/refactor-centralize-account-session-commit-ownership) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules ← this PR 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
…pose (Comfy-Org#17831) ## Summary `createSessionClient` can now take the identity as its second argument and subscribe to it at construction, with a `dispose()` to tear that down. `attachIdentity` still works and is still deprecated; this PR adds the shape the two hosts migrate onto next, and changes nothing for them yet. Part of FE-2196 ## Changes - `createSessionClient(options, identity?)` in `session.ts` subscribes at construction when an identity is passed. It runs the same closure function `attachIdentity` now delegates to, so the brand gate, the identity-changed commit and the auto-mint are one code path. - `SessionClientOptions.autoMint` (default true) controls the constructed identity only. `AttachIdentityOptions.autoMint` keeps governing `attachIdentity`, unchanged. - `SessionClient.dispose()` detaches whichever identity is current, constructed or attached, with today's detach semantics (epoch bump, scheduler stopped, snapshot back to pending). It's idempotent and a no-op when nothing is attached; the client stays attachable afterwards, as after a detach today. - `attachIdentity`'s deprecation note now points at the constructor argument, and the brand-guard error no longer names `attachIdentity`, since the constructor path throws it too. The one existing test that asserted the old text was updated to the new string. - `session.identity.test.ts` covers construction-with-identity and dispose. Its fakes live in `src/core/__fixtures__/sessionFakes.ts`, the same shared fixture the PR below introduces, so the merge-down reconciles onto one file; `session.test.ts` and `session.scheduler.test.ts` move onto it in that PR. One fixture in `packages/account-ui` grew a `dispose` stub because the interface member is required. - The subscription re-checks that it is still the current one after the identity-changed publish and before the auto-mint. A subscriber that disposes the client during that publish no longer gets an auto-mint fired at a disposed client. This is a deliberate tightening, covered by a new test in `session.test.ts`. - `dispose()` keeps the non-terminal detach semantics for explicit-user mints: `ensureFresh(user)` after dispose still resolves from the stored credential without publishing it, exactly as after a detach today, and that stays the contract until Comfy-Org#17835 retires `attachIdentity`. - The package is now `@comfyorg/account-core`. ## Review Focus - Construction subscribes after the scheduler is created (`session.ts`, just before the return). A port that fires synchronously during construction commits through the scheduler, so the order matters; a listener registered later gets the current snapshot from `subscribe` as before. - `dispose` is required on the interface rather than optional. Optional would let a host forget it; the only hand-built client in the repo is the account-ui billing fixture, updated here. - No telemetry hook was added to the options. Hosts keep deriving refresh telemetry from the snapshot and scheduler outcome, which is the current model. ## QA - [x] Red first: the new test file failed 9/9 against the base before the implementation (verbatim run saved with the PR notes; the red could not be committed separately because the pre-commit typecheck rejects references to members that do not exist yet) - [x] Unit: `pnpm --filter @comfyorg/account-core test` 40 files, 728 tests - [x] Mutation check: hardcoding the constructed identity to always auto-mint fails the `autoMint: false` row (the row settles time and asserts the full phase array plus the fetch count) - [x] `session.scheduler.test.ts` unmodified; `session.test.ts` +32/-2 (the guard-message substring plus the dispose-during-first-delivery test); `session.identity.test.ts` +208 new - [x] Consumers: `src/platform/workspace/stores` 326 tests, website `src/config` 2459 tests - [x] `pnpm typecheck` (root and package), `pnpm lint`, `oxfmt --check`, `pnpm knip` clean - Not covered: no host uses the new constructor argument yet; that is the cloud store PR and the website PR after it. This PR stacks on Comfy-Org#17830 and merges after it. Linear: [FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down ← this PR 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
…rkspace auth store (Comfy-Org#17832) ## Summary The cloud workspace auth store now hands its identity to the session client at construction and stops attaching and detaching it by hand. The `unified_cloud_auth` flag gates minting only; identity is bound for the store's lifetime. This deletes the host side of the transitional adapter that ADR-0028 marked for removal, and the ADR is amended in the same change. Part of FE-2196 ## Changes - `workspaceAuthStore.ts` constructs the client as `createSessionClient({ ..., autoMint: false }, useAuthStore().identity)`. `ensureUnifiedIdentityAttached`, `detachUnifiedIdentity` and the attach call inside `unifiedUser()` are gone. - The flag watch keeps its two jobs but not the attach half: on turns the rail on by minting the current target, off calls `clearUnifiedContext()`, whose `invalidate()` drops the credential, stops the scheduler and releases the cross-tab lease. The port stays subscribed but inert, because the store drives every mint itself. - The three flag-gated helpers (`mintAtLogin`, `remintUnifiedOnce`, `switchUnifiedWorkspace`) re-check `unified_cloud_auth` after awaiting `unifiedUser()`, not only before. A mint parked on the identity when a rollback flips the flag off now fails closed instead of committing a token, since `invalidate()` alone preserves the user. - `destroy()` calls `dispose()` on the client in place of the stored detach handle. Ordering is unchanged. - `docs/adr/AUTH-IDENTITY-0028` rules 1 and 4 are amended: identity is passed at construction, and with the flag off the port is subscribed but no token, network call or timer exists. - `src/utils/__tests__/stubAccountIdentityPort.ts` holds the two test seams for this binding: `stubAccountIdentityPort()` keeps a suite's construction-time subscription off Firebase (six suites use it), and `replayIdentityPort()` fakes the auth-state registration and replays the user on a microtask by default, the way the SDK does, or synchronously on request. Both `authStore.test.ts` blocks and `useWorkspaceAuth.test.ts` drive their identity events through it, so the first delivery is modelled one way. - `useWorkspaceAuth.test.ts` rewrites the four lifecycle cases to the new contract. - New tests: - `authStore.test.ts`, store construction order: building the workspace store first subscribes its port and mints once Firebase delivers on its microtask. - `authStore.test.ts`, unified identity source: now pins that both the store listener and the port registered at construction. - `useWorkspaceAuth.test.ts`: a port that delivers synchronously inside `onUserChanged` still leaves the store subscribed and minting for that user. - `useWorkspaceAuth.test.ts`, destroy: a mint after `destroy()` waits the settle ceiling and resolves false. ## Review Focus - Fail-closed on rollback: the flag-gated helpers re-check `unified_cloud_auth` after `await unifiedUser()`, so a mint that parked on the identity before the flip commits nothing. Pinned by `useWorkspaceAuth.test.ts` "refuses a mint that parked on the identity before the flag went off" (red without the re-check). - The flag-off contract changed on purpose: the port used to be detached, now it stays subscribed and the client is invalidated. The test at "turning the flag OFF keeps the identity subscribed..." pins the gate in `mintAtLogin`; removing that guard fails it. - Construction-order coupling: `workspaceAuthStore` reads `useAuthStore().identity` during its own setup while `authStore`'s listener calls back into `workspaceAuthStore`. This holds because Firebase delivers a new observer's first callback on a microtask, after persistence resolves, so each store finishes setup before the other can re-enter it. A synchronous identity source in that seat would re-enter a half-built store and leave the client unsubscribed, with every mint waiting its ceiling. The two-store failure is reproduced by the `store construction order` test in `authStore.test.ts` (which drives the real pair with `replayIdentityPort(..., 'sync')`); the `useWorkspaceAuth.test.ts` sync case pins only the session-client half, since its `onAuthStateChanged` is a no-op so `authStore`'s listener never re-enters. The comment at the call site and ADR-0028 rule 3 name the dependency. Comfy-Org#17834 removes the coupling by importing the identity module directly instead of reading it off `authStore`. - Under flag off with a signed-in user the client's snapshot reads `minting` instead of `pending`. The only phase reader outside the store is the billing transport, which runs only under a flag that requires unified auth. - `dispose()` is not terminal: a disposed client would still honor an explicit-user mint. Nothing calls the store after `destroy()` today, so this stays as it was; noted for the legacy-rail retirement. ## QA - [x] Unit: `pnpm exec vitest run src/platform/workspace src/stores src/platform/auth` 132 files, 2869 passed, 1 expected fail, 1 skipped; the one failure is `checkoutJourney.test.ts`, a known local-only failure unrelated to this change - [x] Mutation check: removing the `unifiedCloudAuthEnabled` guard in `mintAtLogin` fails the flag-off lifecycle test - [x] Package untouched: `pnpm --filter @comfyorg/account-core test` 42 files, 661 tests, no diff under `packages/` (the package is `@comfyorg/account-core`) - [x] Website consumers unaffected: `apps/website` `src/config` 2459 tests - [x] `pnpm typecheck`, `pnpm lint` (0 errors), `oxfmt --check`, `pnpm knip`, `fallow audit --changed-since` the parent branch: clean - [ ] Manual, cloud build with `unified_cloud_auth` on: sign in, switch workspace, wait past the refresh buffer, sign out; confirm the header keeps a token through the refresh and clears on sign-out - [ ] Manual, cloud build with the flag off: sign in and confirm no `/auth/token` request is issued - Not covered: no e2e in this PR; the auth e2e set is the gate for the Firebase-init PR that follows. This PR stacks on Comfy-Org#17831 and merges after it. Resolves review comment from @DrJKL on Comfy-Org#17283: [r3976008872](Comfy-Org#17283 (comment)). Linear: [FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only ← this PR 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
…identity (Comfy-Org#17833) ## Summary The website's workshop session client is now constructed with its identity, like the cloud store, and the last `attachIdentity` caller is gone. Because the website loads Firebase lazily and its flag can turn off and on again, the package gains a small lazily activated identity port; the website activates it when the flag settles on and deactivates it when the flag turns off. Part of FE-2196 ## Changes - `packages/account-core/src/core/lazyIdentity.ts` adds `createLazyIdentity(load)`. It returns a branded identity port whose `activate()` loads the real identity once, subscribes it, and resolves after that identity has delivered its current user. `deactivate()` unsubscribes and delivers null once. Repeated activation shares one load; a loader failure leaves a retry possible. Exported as `@comfyorg/account-core/lazyIdentity`. - `workshop-account.ts` builds the port with a dynamic import of `workshop-firebase` and passes it to `createSessionClient`. The Firebase chunk is still only reached through dynamic imports (verified in the build output). - `workshop-session-state.ts`: `begin()` awaits `activate()` before subscribing to the client, so the snapshot it replays is real post-delivery state, and `stopListeners()` deactivates after unsubscribing, so the host never observes the null. The flag-off path keeps clearing the stored credential. The `detachIdentity` handle is gone. - Five website suites replace the `attachIdentity` fake with `activate`/`deactivate` fakes; the Firebase-laziness proof moves to `workshop-account.test.ts`, which drives the real client through the port with `workshop-firebase` mocked. - `workshop-session-state.integration.test.ts` is new and drives the host over the real lazy port and real session client with only Firebase stubbed. It pins that flag off then on never shows a signed-out frame, that the stored credential is cleared on off, that a mint in flight across off cannot commit, that a flag turned off before the first Firebase answer installs nothing, and that a begin step failing after a signed-in delivery clears the stored credential. - The website session suites share one fakes module (`config/__fixtures__/workshopSessionFakes.ts`) for the test user and the token-exchange response, and read the storage keys from the modules that own them. ## Review Focus - After `deactivate()` the client's own snapshot is `signed-out` where the old detach left it `pending`. The host overrides its published snapshot to pending itself, and the three direct client consumers gate on `authenticated` only, so nothing observable changes; the OFF→ON test is the guard. - `activate()` resolving on first delivery means a Firebase that never answers leaves the page pending, which is today's behavior for an unanswered identity. - One effects change is deliberate: when a begin step fails after a signed-in delivery, the failed attempt now signs the client out and clears the stored credential, so the next attempt mints again instead of reviving the old credential. The old detach kept it. The new integration case pins the cleared storage. - This is the only new package surface in the stack. The alternative, a non-terminal detach on the session client, would have kept a host-driven attach lifecycle alive, which is what FE-2196 removes. ## QA - [x] Unit: `pnpm --filter @comfyorg/account-core test` 754 tests; website `src/config` 79 files, 2562 tests - [x] Security review fixes, each mutant-proven: the inner delivery callback drops events from a stale generation (a port that keeps emitting after unsubscribe, or the previous subscription after re-activation), and deactivate re-delivers null only after a signed-in user - [x] Mutation check: moving `deactivate()` above the snapshot unsubscribe in `stopListeners` fails the integration case (the host would publish signed-out on flag off) - [x] Mutation check: deleting the liveness guard after `activate()` in `begin` fails the new flag-off case (the host would publish signed-out); deleting the `deactivate()` call in `stopListeners` fails the new storage case (the cached credential survives the failed attempt) - [x] New tests: `lazyIdentity.test.ts` re-activation case now waits on the second inner subscription instead of bare microtask turns; integration suite gains the flag-off-before-first-answer case and the storage-cleared-after-failed-begin case; the abandoned-mint case awaits the released fetch before asserting on storage; the failure suite pins that the failed attempt reaches `deactivate()` - [x] `pnpm exec vitest run src/platform/workspace/stores` 326 tests, unchanged - [x] `pnpm --filter @comfyorg/website build` clean; `workshop-firebase` is a separate chunk with dynamic importers only - [x] `pnpm typecheck` (root and website), `pnpm lint`, `oxfmt --check`, `pnpm knip` clean - [x] `attachIdentity` has zero callers outside `packages/account-core` - [ ] Manual, website with `workshop-auth` on: load a Workshop page signed out, confirm no Firebase request until sign-in; sign in, reload, confirm the session and credits return; toggle the flag off and back on in a session and confirm the header never flashes the signed-out state - Not covered: no website e2e in this PR. This PR stacks on Comfy-Org#17832 and merges after it. Linear: [FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk ← this PR 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
…pping vuefire (Comfy-Org#17834) ## Summary The `@comfyorg/account-core` package now initializes Firebase for the cloud app. `main.ts` no longer creates the app or installs VueFire; one module builds the package identity from the runtime config under the default app name with an ordered persistence hierarchy, and `authStore` subscribes to it. This lifts ADR-0028 rule 5 and is the last piece of "the package owns identity" before the transitional seam is deleted. Part of FE-2196 ## Changes - `src/platform/auth/firebaseIdentity.ts` is the cloud app's one Firebase entry: `createFirebaseIdentity` with `appName: '[DEFAULT]'`, the config as a thunk, and an ordered persistence hierarchy: localStorage, then the IndexedDB store vuefire persisted sessions in, then session storage, with the popup resolver. Firebase restores a user from the first store that holds one and migrates it into localStorage, which is what keeps existing sign-ins alive. The package reads the config thunk once, at first resolution, so the read lands after `main.ts` has awaited remote config even though this module is evaluated earlier through the static import graph. Resolving before remote config has loaded throws in every environment: booting on build-time config could point auth at the wrong Firebase project, so the module fails closed instead of falling back. - The identity is no longer routed through `authStore`: `workspaceAuthStore` and the shared test stub import the module directly, which also removes the store's eager `useAuthStore()` at setup. - `authStore.ts` drops `useFirebaseAuth`, `setPersistence` and the direct `onAuthStateChanged`/`onIdTokenChanged` calls in favor of the identity's `onUserChanged` and `onTokenChanged`. Listener bodies are unchanged; `authStore` no longer holds or exports an identity, and `workspaceAuthStore` and the shared test stub import the module directly. - `main.ts` removes `initializeApp` and the VueFire plugin; the `startup/firebase-init` tracer phase now wraps an explicit `firebaseIdentity.initialize()` in a `try`/`finally`, so the phase is recorded even when initialization throws. - `sessionFeatureFlagOverride.ts` reads the current user from the identity instead of vuefire, keeping its no-`authStore` import rule. `currentUser()` never initializes Firebase, so a `?ff=` read before remote config cannot boot the app on build-time config; a test pins that. - The package entry passes `popupRedirectResolver` when it initializes with a persistence (otherwise popup sign-in would throw on the package-created `Auth`), accepts the options as a thunk, and exposes `initialize`, `onTokenChanged` and a non-initializing `currentUser`. - ADR-0028 rule 5 is replaced: the package initializes the cloud app's Firebase; nothing in `src` creates an app or `Auth`. - Tests: `firebaseIdentity.test.ts` pins the app name, the persistence order by identity (localStorage, IndexedDB, session storage) on both the fresh-app and the `[DEFAULT]` reuse path, the popup resolver, the deferred config read, and the unloaded guard as one table over DEV on and off. `useWorkspaceAuth.test.ts` adds a case that constructs the workspace store before `authStore` exists and shows `mintAtLogin()` still mints for the port's user, so port-first registration cannot strand the identity wait. `stubFirebaseAuthHarness()` in `src/utils/__tests__/stubAccountIdentityPort.ts` performs the three Firebase stubs (`initializeAuth`, `onAuthStateChanged`, `onIdTokenChanged`) once; the twelve suites that needed them because `initializeAuth` now really runs at store creation call it from `beforeEach`, with no assertion weakened, and the persistence assertion moved from `authStore.test.ts` to `firebaseIdentity.test.ts`. The `firebase/auth` automock drops `setPersistence` (no readers left) and mirrors every `AuthErrorCodes` key `src` reads; `TopbarSubscribeButton.test.ts` drops its hand-rolled Firebase factories since nothing under test imports Firebase. `vitest.setup.ts` defaults `remoteConfigState` to `anonymous` beside the runtime config it already installs, since the real `authStore` now resolves the identity at construction; suites that test the unloaded state set it explicitly. ## Review Focus - The config thunk and guard. An eager `options: getFirebaseConfig()` would have booted cloud on build-time config; `firebaseIdentity.test.ts` goes red on that form. A first resolution before remote config has loaded throws in every environment rather than booting on build-time config, which could point auth at the wrong Firebase project; the `main.ts` ordering (remote config awaited before `initialize()`) is the invariant and the cloud e2e set is what proves it. - The app name `[DEFAULT]` is load-bearing: persisted sign-ins and the e2e seed live under `firebase:authUser:<apiKey>:[DEFAULT]`. The package default would have been `comfy-account`. - `vuefire` stays in `package.json` for now: 28 suites still mock it. Dropping the dependency and those inert mocks is a follow-up sweep, not this PR. - The cloud auth e2e set (`authAccountSwitch`, `cloudOnboardingAuth*`, `workspaceAuthRefresh`, `wsReconnectAccountSwitch`, `workflowDraftForeignWindowSignIn`, `signInDialogAuthErrors`) is the real gate for this change and runs in CI only. ## QA - [x] Unit: account 43 files / 692 tests; scoped cloud suites (auth, workspace, stores, views, topbar, utils) 197 files / 3875 tests, with only the pre-existing local-only `checkoutJourney.test.ts` failure; full `pnpm test:unit` fails only the two pre-existing `scripts/cicd` shell suites - [x] Mutation checks: the eager config form fails three `firebaseIdentity.test.ts` cases; an initializing `currentUser` fails the feature-flag override test in a full-file run; removing the remote-config guard fails its test - [x] Error-state fallback pinned: with remote config in `error` (the fetch ran and failed), the app boots on the build-time config without asserting, as before; only the unloaded state throws - [x] `pnpm build:cloud` clean; one `initializeApp` call site outside the SDK, no vuefire strings in any chunk - [x] `grep` over non-test `src`: no `initializeApp`, `useFirebaseAuth`, `VueFire` - [x] `pnpm typecheck`, `pnpm lint`, `oxfmt --check`, `pnpm knip` clean - [x] CI: the seven cloud auth e2e specs above pass; the five `@cloud` specs in the `cloud` project, `wsReconnectAccountSwitch` and `signInDialogAuthErrors` in the `chromium` shards - [x] Manual, cloud build: sign in with Google (popup), reload and confirm the session persists, sign out, sign in with email, switch workspace, wait past the refresh buffer with the flag on and confirm the session cookie rotates - Not covered: no local e2e; Electron/desktop persistence path not exercised beyond the unit test. This PR stacks on Comfy-Org#17833 and merges after it. Linear: [FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does ← this PR 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
## Summary The transitional identity seam is gone from `@comfyorg/account-core`: `attachIdentity`, `AttachIdentityOptions`, and the runtime brand gate. Identity reaches the session client only at construction, which is what ADR-0028 called the transitional adapter's removal. ADR-0033 records the outcome of the whole stack. Along the way it fixes a real gap in the construction path: a listener that disposed the client during the first identity publish still started a mint. This closes FE-2196. Fixes FE-2196 ## Changes - `session.ts` loses `attachIdentity`, `AttachIdentityOptions`, the `isAccountIdentity` runtime throw and the replace-on-reattach slot. `subscribeIdentity` runs once at construction, reads `autoMint` from the client options, and `dispose()` stays idempotent. 557 lines to 533. - Regression fix: a listener that disposes the client during the identity publish no longer triggers a mint or re-arms the scheduler. Before, the identity callback checked for disposal only before committing the user, so a `dispose()` from inside that publish still started a post-dispose `getIdToken()` and exchange call, persisted a credential for a user the client no longer tracked, and re-armed the refresh timer. The callback now mints only when the delivered user is still the client's user after the publish. Pinned by `does not mint when a listener disposes the client during the identity publish` in `session.identity.test.ts`, written red first. - `identity.ts` loses `isAccountIdentity`; the brand type stays, so an unbranded port is a compile error rather than a runtime one. The `/testing` seam and the two production entries (`createFirebaseIdentity`, `createLazyIdentity`) still brand at runtime. `identity.test.ts` now also constructs `createSessionClient` with a plain port under `@ts-expect-error`, so widening the parameter fails the typecheck. - The package suites move their attach call sites (37 in `session.test.ts`, 34 in `session.scheduler.test.ts`, 2 in `session.identity.test.ts`) onto construction with the same identity fakes; `detach()` becomes `dispose()`. No mint, refresh or arbitration assertion value changed. - Test tally against the base branch, by name: 12 deleted, 1 added, 3 renamed, plus the regression test above. Deleted: the five `isAccountIdentity` cases in `identity.test.ts`, replaced by one compile-time brand case; in `session.identity.test.ts`, re-attach after dispose, replace-on-attach, and the runtime brand refusal; in `session.test.ts`, dispose-inside-first-delivery, callback-after-detach, stale detach from a superseded attach, and the runtime brand refusal again. Eleven pinned behavior the client no longer has. The twelfth, dispose-inside-first-delivery, also asserted that no mint follows such a dispose; dropping it is what let the regression in, and the regression test above restores that assertion on the construction path. Renamed: the three `session.test.ts` cases that said detach now say dispose. - `docs/adr/AUTH-IDENTITY-0033` (Accepted) supersedes ADR-0028's transitional rules and records the decomposition PR through the seam-deletion PR as shipped, the preserved credential invariants, and the rejected alternatives. It names the cloud app's ordered persistence hierarchy (localStorage, then the IndexedDB store vuefire persisted into, then session storage) and the popup resolver, and says the brand is a compile-time gate that the `testing` seam deliberately exposes; the `identity.ts` docblock says the same. ADR-0028's status block points at ADR-0033. Index updated. - The account-ui billing fixture drops its `attachIdentity` stub, and `billing-web` passes its identity at construction. The Firebase entry now mints its brand through `brandIdentity` like the lazy port, so there is one way to mint it. - The session suites and `credentialCache.test.ts` share their fakes through `core/__fixtures__/sessionFakes.ts` (memory storage, the exchange URL and ninety-minute constants, `testUser`, mint body and response builders, a manual identity with an unsubscribe spy) instead of drifting copies. The manual identity's `fire` now throws when no client has subscribed instead of silently doing nothing. ## Review Focus - The deleted-test tally above is the thing to check: each name says removed-behavior or covered-elsewhere. - The regression guard reads the post-publish state rather than the `active` flag because the type-aware lint narrows that flag to true across the commit call; the two are equivalent, and the state form also covers a re-entrant identity change. - ADR-0033 is `Accepted`, not `Proposed` like its AUTH neighbours, because the work it records has shipped across this stack; say so if you want the convention kept instead. - No runtime defense remains against a JavaScript consumer passing an unbranded port. The package is private and both consumers are in this repo; the ADR records the tradeoff for the day it is published. - Construction subscribes before a test registers its own `subscribe` listener; the migrated cases rely on `subscribe`'s replay of the current snapshot, which is the same contract hosts use. ## QA - [x] Unit: `@comfyorg/account-core` 41 files / 757 tests (base 767; twelve deleted, two added, three renamed); cloud auth-area suites 132 files / 2824; website config 79 / 2463; account-ui billing 23 - [x] The regression test fails on the base code (post-dispose `getIdToken()` and exchange call both fire once) and passes with the fix - [x] `grep` for the three deleted names across `packages`, `src`, `apps`: none - [x] `pnpm typecheck`, `pnpm lint`, `oxfmt --check`, `pnpm knip`, `pnpm adr:check`, `fallow audit` clean - Not covered: no e2e; nothing user-facing changes in this PR. This PR stacks on Comfy-Org#17834 and merges after it. Linear: [FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome ← this PR 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
…dule (Comfy-Org#17836) ## Summary The legacy workspace-token rail moves out of `workspaceAuthStore` into its own module. The store keeps the flag dispatcher and host projection; `legacyWorkspaceTokenRail.ts` holds the pre-unified mint, refresh timer, recovery and token getters as one removable unit. Nothing is deleted: `unified_cloud_auth` is a PostHog percentage rollout that defaults off, so this rail still serves production users. When the cut-over completes, retiring it becomes a file deletion plus a handful of store lines. The PR has two review surfaces. The first is a verbatim move. The second splits the rail's two long functions into named steps and, in this revision, restores the original guard order and exit points that the split had drifted from. Part of FE-951 (the cut-over ticket; this PR isolates, it does not delete) ## Commits 1. `c130ee50` refactor: move the legacy workspace-token rail into its own module. The code moves verbatim; review with `--color-moved`. 2. `ea210e34` refactor: construct the legacy rail before the computed that reads it. 3. `bdb1c152` test: pin the legacy rail seam (five cases in `useWorkspaceAuth.test.ts`). 4. `c0944e6b` test: cover the rail at the factory seam (`legacyWorkspaceTokenRail.test.ts`). 5. `35b68dae` test: cover the rail's mint, refresh and recovery branches directly (`legacyWorkspaceTokenRail.lifecycle.test.ts`). 6. `e0bbd162` refactor: split the rail's mint and refresh flows into named steps. 7. `def7dfa4` test: pin the post-mint owner guard and the foreign-token refresh exit. 8. `dff474cd` test: drive the seam through the shared feature flag mock. 9. `f0136ca7` refactor: keep the rail's guard order and return after an exhausted refresh. 10. `c4f7f3c5` test: run the rail suites on a stepped fake clock. ## Review surface 1: the move (`c130ee50`, `ea210e34`) - `legacyWorkspaceTokenRail.ts` is new: `createLegacyWorkspaceTokenRail(deps)` returns the legacy surface the store used to define inline (`workspaceToken`, `initializeFromSession`, the legacy `switchWorkspace` branch, `refreshToken`, `ensureWorkspaceToken`, `ensureWorkspaceAuthHeader`, the token getters, `retireLegacyToken`, `stopRefreshTimer`, `clearLegacyContext`). - The dependency interface is explicit: the shared refs (`currentWorkspace`, `isLoading`, `error`), the uid helpers, lazy `getIdToken`/`hasSignedInUser`/`activeWorkspaceId` closures, `endWorkspaceSession`, `persistWorkspaceIdentity`, `clearSessionStorage`, `surfacePermanentAuthError`, and the store's `switchWorkspace`. That last one matters: the rail's timer-driven refresh still routes through the flag dispatcher, so with the flag on it reaches the unified switch exactly as before. - `workspaceAuthStore.ts` drops from 1179 to 590 lines. Its returned names and module exports are unchanged; `switchWorkspace` is now only the flag dispatcher; `clearWorkspaceContext` calls `clearLegacyContext()` and then its own lines in the original order. - `WorkspaceAuthError` lives in `workspaceAuthError.ts` (both rails throw it) and is re-exported from the store. `MAX_SCHEDULED_REFRESH_RETRIES` moves to `workspaceConstants.ts` since both rails read it. - Only five lines inside the moved block differ from the original: three store reads become injected closures, the flag branch leaves the legacy switch, and one docblock clause that claimed the unified path reuses `requestToken` is gone. - The second commit only moves the rail construction above the `isAuthenticated` computed that reads it. ## Review surface 2: the named-steps split (`e0bbd162`, then `f0136ca7`) Why: the repo's complexity gate flagged the moved file. `performSwitchWorkspace` and `refreshToken` each carried the original store's two largest bodies, and `ensureWorkspaceToken` was close behind. The split extracts the steps those functions were already doing in sequence, with the names the log lines and comments were already using: `requestToken` (network plus parse, no store writes), `readStoredSession` and `isUnexpiredSession` under `initializeFromSession`, `canRecheckAfterInFlightSwitch`, `canStartRecoveryMint` and `recoverWorkspaceToken` under `ensureWorkspaceToken`, and `endRefreshOnPermanentError`, `waitForRefreshBackoff`, `preserveTokenAfterExhaustedRefresh` and `settleExhaustedRefresh` under `refreshToken`. The rail's highest per-function cyclomatic goes from 20 to 9. Behavior is meant to be preserved, and the two suites added in this PR were written against the original semantics. Review found three places where the first split drifted; `f0136ca7` puts them back: - Guard order on restore. `readStoredSession` parsed and schema-validated the stored workspace before checking who owned the session; the original short-circuited on the owner check first. The owner check is back in front of the parse, so a foreign user's blob is never parsed. Same outcomes in every row of the restore table. - Exit after an exhausted refresh. `settleExhaustedRefresh` was the last statement of the catch, so control fell back into the loop and termination depended on the transient guard. The original returned after the preserve branch; the `return` is back. - The recovery target. A one-line helper sat under the docblock that belongs to `ensureWorkspaceToken`; the expression is inlined, the helper is gone, and the docblock is back on the function. To keep the complexity gate green after the inline, the cooldown and active-workspace gate now opens `recoverWorkspaceToken` instead of sitting one line above its call, which is the same check in the same order. - Two smaller readability points from the same review: `REFRESH_MAX_RETRIES` is renamed `REFRESH_ATTEMPT_MAX_RETRIES` (it bounds in-loop attempts; `MAX_SCHEDULED_REFRESH_RETRIES` is the scheduled budget), and the hand-rolled promise-over-`setTimeout` in `waitForRefreshBackoff` is `delay` from es-toolkit. ## Review Focus - Read the move commit with `--color-moved`; every test file is untouched in it. - Read `e0bbd162` and `f0136ca7` together against the parent's `workspaceAuthStore.ts`, checking that every early return and guard lands in the same order. - The seam cases in `useWorkspaceAuth.test.ts` drive the rail through the real store: the legacy refresh deadline and an expired-token recovery route through the flag dispatcher when unified auth is on (a rail calling its own legacy switch fails both), the fail-closed return in `ensureWorkspaceToken` (returning the other workspace's token fails it), and the injected identity and active-workspace closures resolving at call time. The other store suites stub the rail's actions. - This exceeds the usual 300-line guideline on purpose. It is one verbatim move; a split would have added seven throwaway members to keep each half green and doubled the review. - The true boundary today: `WorkspaceTokenResponse` is re-exported from the store because four Playwright files import it from there (`browser_tests/tests/authAccountSwitch.spec.ts`, `browser_tests/tests/currentUserPopoverCredits.spec.ts`, `browser_tests/fixtures/workspaceSwitcherFixture.ts`, `browser_tests/fixtures/data/workspaceAuthFixtures.ts`). `WorkspaceAuthError` is re-exported because `useWorkspaceAuth.test.ts` imports it from the store; pointing that test at `workspaceAuthError.ts` would have edited a test file inside the move commit. - What the eventual deletion looks like, so the boundary can be judged (this list belongs on FE-951): delete the rail file; remove the twelve rail-originated names the store destructures (`workspaceToken`, `initializeFromSession`, `switchLegacyWorkspace`, `refreshToken`, `ensureWorkspaceToken`, `ensureWorkspaceAuthHeader`, `getWorkspaceAuthHeader`, `getWorkspaceToken`, `hasValidWorkspaceToken`, `retireLegacyToken`, `stopRefreshTimer`, `clearLegacyContext`), seven of which the store also returns; drop the `retireLegacyToken()` call in the unified snapshot subscriber; drop the three token keys in `clearSessionStorage`; re-add `currentWorkspace = null` in `clearWorkspaceContext` (it sits inside `clearLegacyContext` today to keep the clear order identical); collapse `switchWorkspace` to its unified branch; drop `initializeFromSession` from `init` and `stopRefreshTimer` from `destroy`; retarget the four Playwright imports of `WorkspaceTokenResponse` or drop the type with them, and drop `WorkspaceTokenResponseSchema` with the file rather than retargeting it (the generated `zExchangeTokenResponse` already covers this endpoint, and the unified rail consumes it); and decide what `isLoading` means once nothing writes it. ## QA Test files added or changed against the parent branch (`git diff --numstat <parent>...HEAD -- '**/*.test.ts'`): | file | added | removed | | --- | --- | --- | | `src/platform/workspace/stores/legacyWorkspaceTokenRail.lifecycle.test.ts` (new) | 657 | 0 | | `src/platform/workspace/stores/legacyWorkspaceTokenRail.test.ts` (new) | 123 | 0 | | `src/platform/workspace/stores/useWorkspaceAuth.test.ts` | 143 | 1 | - [x] Move commit: no test file changed in it; the suites are green on it - [x] `legacyWorkspaceTokenRail.test.ts`: 6 cases at the factory seam (mint, owner-scoped validity, clear, refresh timer armed and stopped) - [x] `legacyWorkspaceTokenRail.lifecycle.test.ts`: 46 cases covering the mint failure table, session restore, `ensureWorkspaceToken` (cooldown, coalescing, fail-closed, in-flight join, recovery classification) and `refreshToken` (permanent-error exit, the doubling backoff stepped at 999/1, 1999/1 and 3999/1 ms with a fetch count after each step, pre-exchange failure, expired and foreign held tokens, abandoned chain, scheduled retry cap). A halved base delay fails the backoff case at the first step - [x] `useWorkspaceAuth.test.ts`: five additive seam cases, each proven against a mutant (flag-dispatch bypass in `refreshToken` and in `ensureWorkspaceToken`, the downgrade return, eager capture of `getIdToken`, eager capture of `activeWorkspaceId`); the refresh-deadline advance now subtracts `TOKEN_REFRESH_BUFFER_MS` rather than a literal - [x] Both rail suites and the store suite opt out of the auto-advancing fake clock (`shouldAdvanceTime: false`), so the 1 ms margins in the timing rows are real - [x] `src/platform/workspace`, `src/stores`, `src/platform/auth`: 134 files, 2928 tests green at the tip (the one red case, `checkoutJourney.test.ts`, is a known local-only failure in a file this PR does not touch) - [x] Complexity audit against the parent: pass, nothing newly introduced; the rail's highest per-function cyclomatic is 9 - [x] `pnpm typecheck`, `pnpm lint` (0 errors), `oxfmt --check`, `pnpm knip` clean - Not covered: no e2e; the flag-off production path is exercised only by the unit suites above. A cloud build with the flag off (sign in, switch workspace, wait past the refresh buffer) is the manual check if you want one. This PR stacks on Comfy-Org#17835 and merges after it. Addresses the isolate half of [r3976008872](Comfy-Org#17283 (comment)); the shared exchange contract stays on FE-951. Linear: [FE-951](https://linear.app/comfyorg/issue/FE-951/unified-cloud-auth-phase-2-cut-over-to-single-cloud-jwt-remove-legacy) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps ← this PR 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go </details>
…#17837) ## Summary `vuefire` is gone. After the package-initialized Firebase change nothing in `src` imports it, so this removes the dependency and the 28 test mocks that stubbed a module nothing under test loads. Deletion only, no assertion changes. Part of FE-2196 ## Changes - `package.json` and the pnpm catalog drop `vuefire`; the lockfile loses `vuefire` and its optional peer `consola@3.4.2` (the older `consola@2.15.3` stays, other packages use it). - 26 suites lose the identical one-line `vi.mock(import('vuefire'), ...)`; two more (`authTokenPriority.test.ts`, `apiKeyAuthStore.integration.test.ts`) also lose the `mockReturnValue(... as unknown as ...)` blocks that only existed to feed that mock, taking one pre-existing double assertion (`as unknown as`) and one single `as` assertion with them. ## Review Focus - The diff is deletions only, lockfile included. If a removed mock had been load-bearing, the suite would import `vuefire` somewhere; none does. ## QA - [x] No `vuefire` imports in `src` (two prose mentions remain, in `firebaseIdentity.ts` and its test, describing where the old default persisted sessions); nothing in the manifests or the lockfile - [x] Unit: `src/stores src/platform src/utils src/composables` 597 files / 9785 tests; the 21 touched suites outside those directories 427 tests; all green - [x] `pnpm typecheck`, `pnpm lint`, `oxfmt --check`, `pnpm knip`, `pnpm build:cloud` clean This PR stacks on Comfy-Org#17836 and merges after it. Linear: [FE-2196](https://linear.app/comfyorg/issue/FE-2196/remove-the-pinia-identity-adapter-package-owned-identity) <details> <summary>Stack (merge bottom-up; each PR targets the one below it)</summary> Base: Comfy-Org#17643 hosts own the auth copy. The package is `@comfyorg/account-core` since the rename on main (Comfy-Org#17851); the Vue pieces live in `@comfyorg/account-ui` (Comfy-Org#17854). Publish preparation (files allowlist, dependency cut, `dist` build) now ships from the billing track in Comfy-Org#17882; the earlier Comfy-Org#17838, Comfy-Org#17839 and Comfy-Org#17840 are drafts kept for reference. 1. Comfy-Org#17830 the session client's state changes in one pure transition; cache and in-flight mint become their own modules 2. Comfy-Org#17831 identity is passed to `createSessionClient` at construction; `dispose()` tears it down 3. Comfy-Org#17832 the cloud store binds identity at construction; the flag gates minting only 4. Comfy-Org#17833 the website binds identity through a lazily activated port so Firebase stays a lazy chunk 5. Comfy-Org#17834 the package initializes the cloud app's Firebase; vuefire no longer does 6. Comfy-Org#17835 the transitional `attachIdentity` seam is deleted; ADR-0033 records the outcome 7. Comfy-Org#17836 the legacy workspace-token rail moves into its own removable module and its hot paths are split into named steps 8. Comfy-Org#17837 the dead `vuefire` dependency and its inert test mocks go ← this PR </details>
Summary
@comfyorg/accountnow depends on one workspace package instead of three, and that one,@comfyorg/ingest-types, is prepared for publish. The two utility dependencies are cut rather than published:shared-frontend-utilsdraggedaxiosand a GPL-3.0-only package under an MIT account, andtailwind-utilswas onecncall. Nothing is published and noprivateflag changes.Part of FE-2196 (publishability)
Changes
packages/account/src/loadExternalScript.tsis a byte-identical copy of the shared script loader;turnstileScript.tsimports it locally. Its behavior was already covered through the Turnstile loader tests, and the shared package never had a test of its own.packages/account/src/region.tsownsgetClientCountryandisInChina(the edge geo-IP read with the probe fallback). They already ran onfetch, so noaxioscomes along. The 18 behavioral tests moved over; their response fakes are realResponseobjects now instead of cast literals, same assertions../regionis a public entry: a non-Vue host needs the same China determination the Vue gate uses, and the three app suites that mock it for account's gate go through that path.shared-frontend-utils/networkUtil.tshad no consumer left, so it is deleted along with its test file and the./networkUtilexport; the file keepscheckUrlReachable, whichUrlInput.vuereaches through the@/utils/networkUtilalias. One copy of the region check exists.packages/account/src/vue/cn.tscarries the sameextendTailwindMergeconfig astailwind-utils(thetext-xxs/text-xxxsfont sizes andmax-h-none), with a four-row merge test.clsxandtailwind-mergejoin account's dependencies at the rangestailwind-utilsuses.shared-frontend-utilsandtailwind-utilsleavepackages/account/package.json; the lockfile follows. The packed smoke test's sibling override list is down toingest-typesand says so.packages/ingest-types/package.jsongetslicense: MIT,files: ["src"],publishConfig.access: public, andzodbecomes a peer dependency (with a dev dependency for its own checks) so a consumer never ends up with two zod copies and brokeninstanceofchecks on the schemas. Every workspace consumer already has zod. A pack dry-run lists the manifest, the root license and the three source files.ingest-typestarball too, not only on account.cnmerge config) carry a one-line pointer to the file they must stay in sync with.Review Focus
./regionexport exists for test mocking by public specifier; hosts have no reason to call it directly.CSS.escapenit on the loader's selector was left out: happy-dom rejects the escaped form too, so no unit test could prove it.QA
grep shared-frontend-utils|tailwind-utils packages/account: nothingpnpm --filter @comfyorg/account smoke:pack: account 58 files andingest-types5 files packed with specifiers rewritten, every export importedsrc/config+src/components/auth85 files / 2589; cloud dialog, onboarding and widget suites 40 files / 402pnpm typecheck,pnpm lint,oxfmt --check,pnpm knip,pnpm build:cloudcleaningest-typespack dry-run:LICENSE,package.json,src/index.ts,src/types.gen.ts,src/zod.gen.tsingest-typesand thenaccount(owner go), the provenance workflow, README and SECURITY docs.What this PR does not do
Deliberately not done here; each is gated on an explicit publish decision, none blocks merging:
private: truestays on. It is the latch that prevents any accidental publish and is removed only at the first publish.workflow_dispatchon thealphadist-tag, the same path as@comfyorg/design-system,ingest-typesfirst, thenaccount.📚 Stack of 11 · merge bottom-up · this PR is step 10
dispose()attachIdentityseam (ADR-0033)vuefiredependency + inert test mocksingest-types(MIT) for publish ← this PRdist(ESM + d.ts) for publishBase: #17643 (hosts own the auth copy)
This PR stacks on #17838 and merges after it.
Linear: FE-2196