Repository navigation
test(credits): pricing badge hides and returns when the setting is toggled - #17551
christian-byrne wants to merge 7 commits into
Conversation
…ggled ECS 1.53 Area 8 asks that turning "Show API node pricing badge" off and on makes the badge disappear and return on the same API node. Every existing test in this file sets Comfy.NodeBadge.ShowApiPricing to true and asserts the badge renders; nothing turns it off. The node is placed before the toggle, which is the case that can get stuck: the setting is read when the badge renders, so a badge that does not re-evaluate stays visible after the off, or stays hidden after the on. Asserts the badge is visible before turning the setting off. Without that precondition, "hidden" also holds for a node that never rendered a badge at all — the way this test would pass vacuously.
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-28T08:37:33.204Z",
"gitSha": "ad90dd25f29f642566c0caf6ffb7bd2efc68bbb7",
"branch": "test/api-pricing-badge-toggle",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.6070000000173,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8909999999999996,
"layouts": 9,
"layoutDurationMs": 2.595,
"taskDurationMs": 579.855,
"heapDeltaBytes": 4184844,
"heapUsedBytes": 64988960,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 10.910999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.4959999999464,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.973,
"layouts": 9,
"layoutDurationMs": 3.185,
"taskDurationMs": 572.226,
"heapDeltaBytes": 1652584,
"heapUsedBytes": 63278812,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 10.533000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1825.006000000002,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.091999999999999,
"layouts": 9,
"layoutDurationMs": 2.658000000000001,
"taskDurationMs": 901.807,
"heapDeltaBytes": 21529792,
"heapUsedBytes": 82836128,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 168.008,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665137614678894,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.6249999999827,
"styleRecalcs": 76,
"styleRecalcDurationMs": 12.959000000000001,
"layouts": 9,
"layoutDurationMs": 2.588,
"taskDurationMs": 885.3089999999999,
"heapDeltaBytes": 21665052,
"heapUsedBytes": 83602144,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 163.22,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064217,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.223000000005,
"styleRecalcs": 21,
"styleRecalcDurationMs": 5.3919999999999995,
"layouts": 11,
"layoutDurationMs": 2.97,
"taskDurationMs": 450.635,
"heapDeltaBytes": 333000,
"heapUsedBytes": 70233608,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 12.570000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.9490000000242,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.172,
"layouts": 11,
"layoutDurationMs": 2.841,
"taskDurationMs": 428.21400000000006,
"heapDeltaBytes": 739276,
"heapUsedBytes": 71887428,
"domNodes": 57,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 12.314000000000002,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.4100000000049,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.064000000000001,
"layouts": 9,
"layoutDurationMs": 2.6359999999999992,
"taskDurationMs": 502.34299999999996,
"heapDeltaBytes": 5711296,
"heapUsedBytes": 66686528,
"domNodes": 0,
"jsHeapTotalBytes": 9699328,
"scriptDurationMs": 172.08599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 646.0479999999507,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.7819999999999996,
"layouts": 9,
"layoutDurationMs": 2.364,
"taskDurationMs": 492.133,
"heapDeltaBytes": 5285500,
"heapUsedBytes": 66672060,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 169.56799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.207000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 882.3570000000001,
"heapDeltaBytes": -1655740,
"heapUsedBytes": 75404372,
"domNodes": -203,
"jsHeapTotalBytes": 14688256,
"scriptDurationMs": 68.47799999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 498,
"frameDurationMs": 31.978378378378373,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.18700000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.8459999999999,
"heapDeltaBytes": -12190816,
"heapUsedBytes": 74983796,
"domNodes": -203,
"jsHeapTotalBytes": 20193280,
"scriptDurationMs": 67.52399999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 519,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 928.6109999999894,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.6480000000004,
"heapDeltaBytes": -27489808,
"heapUsedBytes": 66423828,
"domNodes": -203,
"jsHeapTotalBytes": 3538944,
"scriptDurationMs": 165.48800000000003,
"eventListeners": -106,
"totalBlockingTimeMs": 246,
"frameDurationMs": 25.221621621621615,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 877.0600000000286,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.9540000000002,
"heapDeltaBytes": -28740576,
"heapUsedBytes": 65325504,
"domNodes": -203,
"jsHeapTotalBytes": 3276800,
"scriptDurationMs": 167.443,
"eventListeners": -106,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.536111111111115,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11599.068000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10840.096000000001,
"heapDeltaBytes": 50803244,
"heapUsedBytes": 144189800,
"domNodes": -269,
"jsHeapTotalBytes": 80605184,
"scriptDurationMs": 8710.331999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1549,
"frameDurationMs": 31.95482093663912,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10239.585999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9468.017,
"heapDeltaBytes": 49692788,
"heapUsedBytes": 144060404,
"domNodes": -269,
"jsHeapTotalBytes": 68808704,
"scriptDurationMs": 7588.607,
"eventListeners": -68,
"totalBlockingTimeMs": 808,
"frameDurationMs": 31.485846153846154,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10223.301000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9420.612000000001,
"heapDeltaBytes": 76942072,
"heapUsedBytes": 155652084,
"domNodes": -269,
"jsHeapTotalBytes": 75624448,
"scriptDurationMs": 7892.882,
"eventListeners": -68,
"totalBlockingTimeMs": 1192,
"frameDurationMs": 31.629411764705885,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10778.391,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06799999999999948,
"layouts": 1,
"layoutDurationMs": 0.23000000000000018,
"taskDurationMs": 10000.853,
"heapDeltaBytes": 55289756,
"heapUsedBytes": 149591020,
"domNodes": -269,
"jsHeapTotalBytes": 73265152,
"scriptDurationMs": 8047.505000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 1156,
"frameDurationMs": 31.388338192419823,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 251.4590000000112,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.491000000000001,
"layouts": 11,
"layoutDurationMs": 3.1380000000000003,
"taskDurationMs": 214.26899999999998,
"heapDeltaBytes": -7002364,
"heapUsedBytes": 68900500,
"domNodes": -2323,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 12.445999999999998,
"eventListeners": -573,
"totalBlockingTimeMs": 6,
"frameDurationMs": 22.727272727272727,
"p95FrameDurationMs": 83.30000000000018
},
{
"name": "large-combo-open",
"durationMs": 287.6640000000066,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.936000000000002,
"layouts": 11,
"layoutDurationMs": 4.137,
"taskDurationMs": 241.04700000000003,
"heapDeltaBytes": -7693356,
"heapUsedBytes": 68346644,
"domNodes": -2323,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 11.051,
"eventListeners": -573,
"totalBlockingTimeMs": 7,
"frameDurationMs": 24.236363636363627,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2055.2059999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6369999999999996,
"layouts": 8,
"layoutDurationMs": 2.751,
"taskDurationMs": 681.1949999999999,
"heapDeltaBytes": -9856736,
"heapUsedBytes": 77200744,
"domNodes": -293,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.711,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.1820000000353,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0410000000000004,
"layouts": 6,
"layoutDurationMs": 2.041,
"taskDurationMs": 676.041,
"heapDeltaBytes": -24695480,
"heapUsedBytes": 62633676,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 34.007999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2528.5109999999804,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.311,
"layouts": 7,
"layoutDurationMs": 1.6180000000000003,
"taskDurationMs": 1701.7599999999998,
"heapDeltaBytes": -3179768,
"heapUsedBytes": 71398732,
"domNodes": -269,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 824.237,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66513157894737,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2604.1830000000346,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.205,
"layouts": 8,
"layoutDurationMs": 2.2710000000000004,
"taskDurationMs": 1749.1790000000003,
"heapDeltaBytes": -11267380,
"heapUsedBytes": 76800676,
"domNodes": -269,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 837.456,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665605095541405,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3857.648999999981,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.061,
"layouts": 64,
"layoutDurationMs": 10.471,
"taskDurationMs": 1835.131,
"heapDeltaBytes": 6562944,
"heapUsedBytes": 82775992,
"domNodes": -245,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 803.6229999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3831.207999999947,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.669,
"layouts": 65,
"layoutDurationMs": 10.846,
"taskDurationMs": 1841.8840000000002,
"heapDeltaBytes": -10189952,
"heapUsedBytes": 79319100,
"domNodes": -245,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 802.5279999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665652173913045,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3074.598999999978,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.324999999999999,
"layouts": 5,
"layoutDurationMs": 1.3490000000000004,
"taskDurationMs": 2005.201,
"heapDeltaBytes": -2899484,
"heapUsedBytes": 90379308,
"domNodes": 0,
"jsHeapTotalBytes": 5959680,
"scriptDurationMs": 999.2429999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130438,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3083.1100000000333,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.242,
"layouts": 5,
"layoutDurationMs": 1.4390000000000003,
"taskDurationMs": 2028.095,
"heapDeltaBytes": -2352320,
"heapUsedBytes": 90892988,
"domNodes": 0,
"jsHeapTotalBytes": 5697536,
"scriptDurationMs": 1006.7710000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.846486486486484,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3122.776000000016,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9900000000000004,
"layouts": 7,
"layoutDurationMs": 1.8109999999999997,
"taskDurationMs": 803.7860000000001,
"heapDeltaBytes": -13175912,
"heapUsedBytes": 79487320,
"domNodes": -269,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 374.491,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665775401069517,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-geometry-cadence",
"durationMs": 3034.881999999982,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1139999999999994,
"layouts": 7,
"layoutDurationMs": 2.3,
"taskDurationMs": 712.82,
"heapDeltaBytes": -10774428,
"heapUsedBytes": 79218456,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 372.58200000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665934065934064,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2046.3110000000029,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.458,
"layouts": 8,
"layoutDurationMs": 2.457,
"taskDurationMs": 660.5049999999999,
"heapDeltaBytes": 964908,
"heapUsedBytes": 83568528,
"domNodes": -269,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 34.832,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.8200000000488,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0220000000000002,
"layouts": 7,
"layoutDurationMs": 1.9820000000000002,
"taskDurationMs": 644.5829999999999,
"heapDeltaBytes": -22020932,
"heapUsedBytes": 68712736,
"domNodes": -269,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 31.396000000000008,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2763.4410000000003,
"styleRecalcs": 25,
"styleRecalcDurationMs": 11.622999999999998,
"layouts": 6,
"layoutDurationMs": 1.9069999999999998,
"taskDurationMs": 606.053,
"heapDeltaBytes": -8386920,
"heapUsedBytes": 84518304,
"domNodes": -256,
"jsHeapTotalBytes": 5931008,
"scriptDurationMs": 191.069,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66566265060241,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-progress-execution-cadence",
"durationMs": 2961.579000000029,
"styleRecalcs": 26,
"styleRecalcDurationMs": 11.567999999999998,
"layouts": 7,
"layoutDurationMs": 1.8840000000000003,
"taskDurationMs": 630.444,
"heapDeltaBytes": -29352696,
"heapUsedBytes": 61920532,
"domNodes": -261,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 195.80599999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-topology-cadence",
"durationMs": 3295.9649999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0410000000000004,
"layouts": 7,
"layoutDurationMs": 2.1100000000000003,
"taskDurationMs": 973.304,
"heapDeltaBytes": -31296728,
"heapUsedBytes": 61220116,
"domNodes": -269,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 377.20099999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66616161616162,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-topology-cadence",
"durationMs": 3337.7810000000068,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8830000000000002,
"layouts": 7,
"layoutDurationMs": 1.7200000000000002,
"taskDurationMs": 970.841,
"heapDeltaBytes": -19771540,
"heapUsedBytes": 70188180,
"domNodes": -269,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 391.312,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.749748743718595,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.4150000000318,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.1930000000000005,
"layouts": 10,
"layoutDurationMs": 2.7720000000000002,
"taskDurationMs": 443.40899999999993,
"heapDeltaBytes": -1813696,
"heapUsedBytes": 60670240,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 147.98600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663888888888877,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.7989999999054,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.159000000000001,
"layouts": 9,
"layoutDurationMs": 2.421,
"taskDurationMs": 457.699,
"heapDeltaBytes": -892752,
"heapUsedBytes": 61751948,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 149.189,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2023.1670000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.058,
"layouts": 10,
"layoutDurationMs": 3.211,
"taskDurationMs": 541.748,
"heapDeltaBytes": 5017056,
"heapUsedBytes": 77033348,
"domNodes": 0,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 9.316,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.2609999999477,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.436,
"layouts": 8,
"layoutDurationMs": 2.381,
"taskDurationMs": 535.855,
"heapDeltaBytes": 2266760,
"heapUsedBytes": 64629528,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.106,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9880000000098,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.024,
"layouts": 9,
"layoutDurationMs": 2.363,
"taskDurationMs": 849.4630000000001,
"heapDeltaBytes": 17034492,
"heapUsedBytes": 79044744,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 113.274,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2909999999547,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.969,
"layouts": 9,
"layoutDurationMs": 2.565,
"taskDurationMs": 861.948,
"heapDeltaBytes": 17157708,
"heapUsedBytes": 79092748,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 113.282,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1467.6620000000185,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.218000000000004,
"layouts": 5,
"layoutDurationMs": 14.644999999999998,
"taskDurationMs": 1095.71,
"heapDeltaBytes": 14003120,
"heapUsedBytes": 116296988,
"domNodes": 16029,
"jsHeapTotalBytes": 10358784,
"scriptDurationMs": 35.932,
"eventListeners": 3246,
"totalBlockingTimeMs": 166,
"frameDurationMs": 20.044594594594596,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9538.23799999998,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.991999999999997,
"layouts": 8,
"layoutDurationMs": 2.1359999999999997,
"taskDurationMs": 6064.47,
"heapDeltaBytes": -5525828,
"heapUsedBytes": 81532712,
"domNodes": -269,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 2762.645,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9777.190000000019,
"styleRecalcs": 251,
"styleRecalcDurationMs": 29.369999999999997,
"layouts": 9,
"layoutDurationMs": 2.29,
"taskDurationMs": 6114.8369999999995,
"heapDeltaBytes": -13214216,
"heapUsedBytes": 77230960,
"domNodes": -269,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2787.467,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.694358974358973,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23204.966000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22712.599,
"heapDeltaBytes": -27194600,
"heapUsedBytes": 255757936,
"domNodes": -3343,
"jsHeapTotalBytes": 8642560,
"scriptDurationMs": 302.004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.346260869565214,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23284.967999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22772.786,
"heapDeltaBytes": -39814148,
"heapUsedBytes": 262576604,
"domNodes": -3343,
"jsHeapTotalBytes": 13881344,
"scriptDurationMs": 318.322,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.867123287671234,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28181.215000000007,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.411999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27789.513,
"heapDeltaBytes": -20140488,
"heapUsedBytes": 267584988,
"domNodes": -3343,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 880.098,
"eventListeners": -651,
"totalBlockingTimeMs": 43,
"frameDurationMs": 51.615750915750915,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 28146.611000000008,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.127000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27744.905000000002,
"heapDeltaBytes": 317688,
"heapUsedBytes": 277488184,
"domNodes": -3343,
"jsHeapTotalBytes": 15196160,
"scriptDurationMs": 890.916,
"eventListeners": -651,
"totalBlockingTimeMs": 36,
"frameDurationMs": 52.000369685767104,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8335.178000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.062,
"layouts": 20,
"layoutDurationMs": 23.032999999999983,
"taskDurationMs": 8217.017000000002,
"heapDeltaBytes": -31322396,
"heapUsedBytes": 260393288,
"domNodes": -3343,
"jsHeapTotalBytes": 20701184,
"scriptDurationMs": 129.31799999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.81460674157304,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8508.771000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.937,
"layouts": 20,
"layoutDurationMs": 22.507000000000012,
"taskDurationMs": 8379.722000000002,
"heapDeltaBytes": -26667192,
"heapUsedBytes": 265291684,
"domNodes": -3343,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 130.25300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.29375,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11839.289000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11493.386999999999,
"heapDeltaBytes": 14672772,
"heapUsedBytes": 276353476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.03599999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.47168458781361,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11601.134999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11279.284000000001,
"heapDeltaBytes": 23401672,
"heapUsedBytes": 282346552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.968,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.2797153024911,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 141.46599999997989,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.530000000000001,
"layouts": 10,
"layoutDurationMs": 4.3629999999999995,
"taskDurationMs": 108.271,
"heapDeltaBytes": -12265344,
"heapUsedBytes": 64022600,
"domNodes": 132,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.199,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000001,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 133.37400000000343,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.053999999999998,
"layouts": 9,
"layoutDurationMs": 3.882,
"taskDurationMs": 87.85700000000001,
"heapDeltaBytes": 4513348,
"heapUsedBytes": 64222808,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.726,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999966,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 508.7419999999838,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 15.934000000000001,
"taskDurationMs": 456.413,
"heapDeltaBytes": -4038664,
"heapUsedBytes": 39188748,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 218.285,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 552.2080000000642,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.691,
"layouts": 76,
"layoutDurationMs": 18.143,
"taskDurationMs": 501.6130000000001,
"heapDeltaBytes": -3993564,
"heapUsedBytes": 41105740,
"domNodes": 4,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 237.163,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 563.715000000002,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.408,
"layouts": 76,
"layoutDurationMs": 14.371,
"taskDurationMs": 532.9130000000001,
"heapDeltaBytes": 1013556,
"heapUsedBytes": 88956464,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 214.30599999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352926,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 759.1079999999693,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.626,
"layouts": 76,
"layoutDurationMs": 18.481,
"taskDurationMs": 719.724,
"heapDeltaBytes": 3313676,
"heapUsedBytes": 104909436,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 304.414,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.035555555555543,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 60.3% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3152 passed, 0 failed · 3 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 63e5610f25ff6fed23e76a7c733630ae70f74f68
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (236)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 11 minutes for your next included review. View limit details
No actionable comments were generated in the recent review. ℹ️ Recent review info
Walkthrough
Merge Risk:
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| End-To-End Regression Coverage For Fixes | ❓ Inconclusive | The required PR metadata is incomplete. The context identifies the changed file and provides the description, but it does not provide the PR title or the actual commit subjects. The custom check requi… | Provide the PR title and the complete list of commit subjects, then re-run this check. |
✅ Passed checks (6 passed)
-
Check name Status Explanation Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request. Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request. Website End-To-End Regression Coverage ✅ Passed The PR changes only browser_tests/tests/creditHelpers.spec.ts. It does not change files underapps/website/src/orapps/website/public/, so this website-specific check does not apply.Adr Compliance For Entity/Litegraph Changes ✅ Passed The PR changes only browser_tests/tests/creditHelpers.spec.ts. No changed file is undersrc/lib/litegraph/,src/ecs/, or a graph-entity path. The ADR compliance check is therefore not applicable…Title check ✅ Passed The title clearly identifies the test change and the pricing badge toggle behavior. Description check ✅ Passed The description explains the test purpose, live-toggle behavior, scope, rationale, and validation results. It does not use every template heading, but it provides the required review context for this …
Full details: End-To-End Regression Coverage For Fixes
-
Explanation
The required PR metadata is incomplete. The context identifies the changed file and provides the description, but it does not provide the PR title or the actual commit subjects. The custom check requires those fields to evaluate the bug-fix-language condition and requires an inconclusive result when commit subjects or the changed-file list are unavailable.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Create stacked PR
- Commit on current branch
🧪 Generate unit tests (beta)
-
- Create PR with unit tests
- Commit unit tests in branch
test/api-pricing-badge-toggle
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## main #17551 +/- ##
===========================================
- Coverage 87.55% 72.22% -15.33%
===========================================
Files 2902 3058 +156
Lines 158386 178872 +20486
Branches 43144 32972 -10172
===========================================
- Hits 138676 129198 -9478
- Misses 18833 49493 +30660
+ Partials 877 181 -696
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
No blocking defects. I found one material anti-flake convention violation and four minor cleanup/documentation issues.
Findings without an anchorable line
- P3, D1: The PR summary says all four prior tests set
Comfy.NodeBadge.ShowApiPricingand assert a badge. The base file has three Vue-node pricing tests that do this. The fourth test checks the API-node indicator in search results and does neither. Please correct the coverage inventory in the description.
Existing findings confirmed or contested
- CodeRabbit posted no actionable comments and approved this head. Its separate "End-To-End Regression Coverage For Fixes" result was inconclusive because the tool input lacked the title and commit subject. REST data contains both, so this is external review-tool metadata, not a PR defect (E1, rejected as not introduced).
Unverified candidates
None.
Checked and cleared
- B1: The first local repeat batch had one
comfyPageapp-readiness timeout during fixture setup after a cold backend image build. The other two cases passed, and a warm-service rerun passed 3/3. The timeout occurred before the changed test body and is not introduced by this PR. - C1 and T1: Correctness and tests lanes noted that live locators cannot prove graph-object identity. This is merged into M2 rather than treated as a missing behavioral assertion. The production setting path contains no graph mutation, and the intended regression is live badge visibility on a node created before the toggles. The smallest correction is to remove the unsupported identity claim and redundant header assertion, not add unrelated object-identity machinery.
- D2: Merged into M1. Both identify the same false one-time-read explanation.
- D3: Merged into M2. Both identify the same unsupported recreation claim.
Coverage and checks
- Depth: standard.
- Lanes run: correctness, maintainability, idiomaticity, Playwright tests, and documentation. No applicable lane was skipped. The one changed file was fully traced in every lane.
- Maintainability lenses: ponytail ultra, no-comments, principle-minimize-reader-load, principle-subtract-before-you-add, principle-laziness-protocol, and principle-migrate-callers-then-delete-legacy-apis. Fallow reported no issue in the changed file. The lane found M1 and M2. Its nested Comment Sicko dispatch was unavailable in the lane executor, so the lane applied the no-comments audit directly.
- Other standard lenses: blast-radius, regression-risk-reviewer, idempotency, shared-state separation, boundary discipline, root-cause analysis, TypeScript best practices, type-system discipline, unit-test review, mock-boundary analysis, proof, setup consolidation, flaky-E2E hardening, full Playwright-spec review, technical writing, unslop, and humanizer.
- Playwright review: 507 helper methods inventoried, 12 changed-test interaction rows traced, checks A-H completed, and all 23 repository rulebook items disposed.
- Local checks: browser typecheck, ESLint, type-aware oxlint, oxfmt check, Fallow audit, and Playwright discovery passed. The focused changed test passed 3/3 after services were warm.
- GitHub checks at review time: 76 successful and 18 skipped, with no failures or pending checks.
- Theme overlap: sibling ECS QA PRs #17455, #17456, #17457, #17459, #17460, and #17462 touch other specs. They were not included in this review.
- Ledger reconciliation: 11 received = 4 inline + 1 body + 4 merged + 2 rejected. No confirmed-existing, contested, question, or unverified rows.
Addresses review feedback: #17551 (comment)
Addresses review feedback: #17551 (comment)
Addresses review feedback: #17551 (comment)
Addresses review feedback: #17551 (comment)
Summary
ECS 1.53 Area 8: "In Settings → Comfy → API Nodes, turn Show API node pricing badge off
and on → verify the pricing badge disappears and returns on the same API node." Nothing in
the suite turns that setting off.
All four existing tests in
creditHelpers.spec.tssetComfy.NodeBadge.ShowApiPricingtotrueand assert a badge renders. They cover the formats (USD, range, list); they do not coverthe setting being a setting.
Why the node is placed before the toggle
That is the case that proves derived badge rows on an existing node react to live setting
changes. A test that toggles first and places the node afterwards would only verify
construction-time behavior.
Why the visible assertion comes first
toBeHidden()on its own is satisfied by a node that never rendered a badge — a broken mock,a changed testid, an API node that stopped being recognised as one. Asserting the badge is
visible before turning the setting off makes the hidden assertion mean what it says. The final
toBeVisible()on the badge proves it returns after the live setting change.Scope
Vue nodes only, and the tag says so. The legacy renderer draws badges onto the canvas, where
there is no DOM node to assert visibility on, so the plan's "both renderers" would need a
screenshot comparison rather than this assertion — a different test, not a wider version of
this one.
Test plan
Test-only change; no source files touched. Reuses the file's existing mocked
object_infofixture, so no new asset.