Repository navigation
[backport cloud/1.53] fix: resolve assigned input slot positions - #17386
Conversation
## Summary Resolve legacy input-slot references through the canonical store-backed slot view so `getInputSlotPos` remains correct after assignment and reordering. ## Changes - **What**: Record assigned-object to installed-view identity at the input descriptor boundary and resolve it before slot-position calculation. - **Dependencies**: None. ## Review Focus The installed `NodeInputSlot` remains authoritative. The weak facade mapping only preserves compatibility for callers retaining the plain object they assigned; after reordering, position follows the installed view rather than the original array index. Tests: focused Vitest 48/48; full typecheck; Knip; scoped ESLint and oxfmt. Related: #15973 Ruling: christian-byrne/blocked-on-christian#214 (comment) ## Screenshots (if applicable) Not applicable; no visual UI change. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit cc4df45)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-10T23:02:39.982Z",
"gitSha": "5a510873bc7696640350f6870b26447eb71dd9eb",
"branch": "christian-byrne/backport-16510-cloud-1-53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2056.779000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.346000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.84799999999996,
"heapDeltaBytes": -11359808,
"heapUsedBytes": 59147824,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.484,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2053.6460000000716,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.958999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.87100000000004,
"heapDeltaBytes": -11449508,
"heapUsedBytes": 58889468,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.485000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.4309999999587,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.07599999999999,
"layouts": 14,
"layoutDurationMs": 4.542999999999999,
"taskDurationMs": 879.61,
"heapDeltaBytes": 8420804,
"heapUsedBytes": 78738220,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 146.291,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.8130000000483,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.388000000000005,
"layouts": 14,
"layoutDurationMs": 4.234,
"taskDurationMs": 848.7159999999999,
"heapDeltaBytes": -7960868,
"heapUsedBytes": 62234488,
"domNodes": -281,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 137.678,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0060000000217,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.19,
"layouts": 6,
"layoutDurationMs": 1.022,
"taskDurationMs": 351.603,
"heapDeltaBytes": 4428828,
"heapUsedBytes": 75008764,
"domNodes": 77,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 11.005,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.8660000000673,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.216,
"layouts": 6,
"layoutDurationMs": 1.152,
"taskDurationMs": 362.079,
"heapDeltaBytes": 4408504,
"heapUsedBytes": 74935776,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.013000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 648.9090000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.510999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.65199999999993,
"heapDeltaBytes": 18077724,
"heapUsedBytes": 87749028,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 151.96900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 702.9560000000856,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.948000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.921,
"heapDeltaBytes": 18139784,
"heapUsedBytes": 88199580,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 158.556,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2051.039000000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.209999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.746,
"heapDeltaBytes": 10264276,
"heapUsedBytes": 86149100,
"domNodes": -271,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 36.778999999999996,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.720000000012,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.319,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.3570000000001,
"heapDeltaBytes": 9780044,
"heapUsedBytes": 85596488,
"domNodes": -273,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 39.523,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2111.8099999999913,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.760000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1485.8509999999999,
"heapDeltaBytes": 18566556,
"heapUsedBytes": 84060112,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 730.067,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2257.9769999999826,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1665.464,
"heapDeltaBytes": -16236996,
"heapUsedBytes": 85467188,
"domNodes": -271,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 797.999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3537.029000000018,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.739000000000003,
"layouts": 60,
"layoutDurationMs": 12.896,
"taskDurationMs": 1661.141,
"heapDeltaBytes": 11729296,
"heapUsedBytes": 79572980,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 753.4340000000001,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3452.900999999997,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.144000000000002,
"layouts": 60,
"layoutDurationMs": 12.896,
"taskDurationMs": 1639.6130000000003,
"heapDeltaBytes": 9903172,
"heapUsedBytes": 76719376,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 730.305,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3095.722999999964,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.9689999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1913.2149999999997,
"heapDeltaBytes": 22400812,
"heapUsedBytes": 89568464,
"domNodes": -279,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 933.896,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.361000000007,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.061999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1915.9569999999997,
"heapDeltaBytes": 17436992,
"heapUsedBytes": 85260028,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 941.01,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.4820000000145,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.085,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.6469999999999,
"heapDeltaBytes": 22102556,
"heapUsedBytes": 88180664,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.455,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2027.541000000042,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.7389999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.7909999999999,
"heapDeltaBytes": -15426716,
"heapUsedBytes": 87268940,
"domNodes": -272,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 33.513,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.2460000000042,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.459999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.12799999999993,
"heapDeltaBytes": 14845632,
"heapUsedBytes": 87452976,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 139.48499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.436000000007,
"styleRecalcs": 45,
"styleRecalcDurationMs": 8.916,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.781,
"heapDeltaBytes": 15131956,
"heapUsedBytes": 87389164,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 138.721,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.8790000000026,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.311,
"heapDeltaBytes": -6787064,
"heapUsedBytes": 65587980,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.85,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2013.8909999999441,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.939,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.079,
"heapDeltaBytes": -7371340,
"heapUsedBytes": 64979992,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.637999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.4880000000235,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.443000000000005,
"layouts": 18,
"layoutDurationMs": 5.341,
"taskDurationMs": 792.23,
"heapDeltaBytes": -11529076,
"heapUsedBytes": 60654188,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 99.60799999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.3340000000617,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.583999999999996,
"layouts": 18,
"layoutDurationMs": 6.078,
"taskDurationMs": 826.465,
"heapDeltaBytes": 2410148,
"heapUsedBytes": 74851172,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 101.89599999999999,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1386.2210000000914,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.667,
"layouts": 16,
"layoutDurationMs": 14.585000000000004,
"taskDurationMs": 936.7679999999998,
"heapDeltaBytes": 21064104,
"heapUsedBytes": 108571944,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.028,
"eventListeners": 2381,
"totalBlockingTimeMs": 128,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8314.909,
"styleRecalcs": 246,
"styleRecalcDurationMs": 38.186,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5556.933000000001,
"heapDeltaBytes": -12035260,
"heapUsedBytes": 88813716,
"domNodes": -273,
"jsHeapTotalBytes": -1392640,
"scriptDurationMs": 2529.271,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8288.557999999966,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.858999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5692.956,
"heapDeltaBytes": 4667712,
"heapUsedBytes": 80530400,
"domNodes": -271,
"jsHeapTotalBytes": -118784,
"scriptDurationMs": 2583.549,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17909.174000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17251.796,
"heapDeltaBytes": -40677252,
"heapUsedBytes": 162958088,
"domNodes": -6548,
"jsHeapTotalBytes": 2121728,
"scriptDurationMs": 311.905,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17831.998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17196.537,
"heapDeltaBytes": -17705044,
"heapUsedBytes": 176181084,
"domNodes": -6548,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 306.379,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21860.701999999947,
"styleRecalcs": 174,
"styleRecalcDurationMs": 20.384000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21579.391,
"heapDeltaBytes": -40147536,
"heapUsedBytes": 162644352,
"domNodes": -6548,
"jsHeapTotalBytes": 2121728,
"scriptDurationMs": 905.0149999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 195,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21840.438999999948,
"styleRecalcs": 171,
"styleRecalcDurationMs": 19.695000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21509.19,
"heapDeltaBytes": -42991912,
"heapUsedBytes": 166588848,
"domNodes": -6548,
"jsHeapTotalBytes": -5369856,
"scriptDurationMs": 937.9980000000002,
"eventListeners": -7473,
"totalBlockingTimeMs": 166,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6451.855999999963,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.44899999999998,
"layouts": 20,
"layoutDurationMs": 23.965,
"taskDurationMs": 6359.711000000001,
"heapDeltaBytes": -23833432,
"heapUsedBytes": 186565776,
"domNodes": -6548,
"jsHeapTotalBytes": 9310208,
"scriptDurationMs": 117.915,
"eventListeners": -7471,
"totalBlockingTimeMs": 465,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6340.953000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.32899999999998,
"layouts": 20,
"layoutDurationMs": 24.900999999999993,
"taskDurationMs": 6266.695,
"heapDeltaBytes": -11869280,
"heapUsedBytes": 191062708,
"domNodes": -6548,
"jsHeapTotalBytes": 17850368,
"scriptDurationMs": 119.30700000000002,
"eventListeners": -7471,
"totalBlockingTimeMs": 405,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 476.9170000000713,
"styleRecalcs": 20,
"styleRecalcDurationMs": 23.79,
"layouts": 3,
"layoutDurationMs": 1.4120000000000001,
"taskDurationMs": 114.661,
"heapDeltaBytes": 5203672,
"heapUsedBytes": 73834956,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.223,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 101.24099999995906,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.941000000000003,
"layouts": 2,
"layoutDurationMs": 1.4389999999999998,
"taskDurationMs": 74.377,
"heapDeltaBytes": 3129912,
"heapUsedBytes": 71839080,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.320000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #17386 +/- ##
=============================================
Coverage ? 83.35%
=============================================
Files ? 2025
Lines ? 117305
Branches ? 33137
=============================================
Hits ? 97778
Misses ? 19167
Partials ? 360
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
CodeJuggernaut
left a comment
There was a problem hiding this comment.
Byte-identical to a cherry-pick of the source merge commit onto its base; CI green.
…ort) (#17388) Backport of the slot-label refresh fix to the 1.53 release line. - Slot labels now refresh after an input or output rename when the node runs on ECS node state. - Clean cherry-pick of the original fix; regression test included and passing. - Merge after the slot-position backport this branch is stacked on (link below). <details><summary>Full context for agent readers</summary> Original fix on main: #17319 This backport is stacked on the 1.53 backport of the assigned-input-slot-position fix, because the regression test and the label refresh path depend on it: - core/1.53 dependency: #17385 - cloud/1.53 dependency: #17386 Merge order: land the dependency backport first, then this PR. Once the dependency merges, this PR's diff reduces to the single cherry-picked commit. Verification: cherry-pick applied cleanly (no conflicts); `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes locally on this branch; knip pre-push check passed. Tracking issue for the ECS migration follow-ups: #15973 <!-- authored-by:agent supreme-operator w3-w40 --> </details> Co-authored-by: Amp <amp@ampcode.com>
…ort) (#17389) Backport of the slot-label refresh fix to the 1.53 release line. - Slot labels now refresh after an input or output rename when the node runs on ECS node state. - Clean cherry-pick of the original fix; regression test included and passing. - Merge after the slot-position backport this branch is stacked on (link below). <details><summary>Full context for agent readers</summary> Original fix on main: #17319 This backport is stacked on the 1.53 backport of the assigned-input-slot-position fix, because the regression test and the label refresh path depend on it: - core/1.53 dependency: #17385 - cloud/1.53 dependency: #17386 Merge order: land the dependency backport first, then this PR. Once the dependency merges, this PR's diff reduces to the single cherry-picked commit. Verification: cherry-pick applied cleanly (no conflicts); `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes locally on this branch; knip pre-push check passed. Tracking issue for the ECS migration follow-ups: #15973 <!-- authored-by:agent supreme-operator w3-w40 --> </details> Co-authored-by: Amp <amp@ampcode.com>
Backport of #16510 (assigned input slot position resolution) to the 1.53 release branch.
Why now: the 1.53 backport of #17319 depends on the
assignedInputViewsplumbing introduced here. Merge this PR before that backport.Cherry-pick of merge commit
cc4df4532eaf0c6c038fe0622c5c96a364a92989(conflict-free).Full context for agent readers