Skip to content

[backport cloud/1.53] fix: resolve assigned input slot positions - #17386

Merged
DrJKL merged 1 commit into
cloud/1.53from
christian-byrne/backport-16510-cloud-1-53
Sep 10, 2026
Merged

DrJKL merged 1 commit into
cloud/1.53from
christian-byrne/backport-16510-cloud-1-53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #16510 (assigned input slot position resolution) to the 1.53 release branch.

Why now: the 1.53 backport of #17319 depends on the assignedInputViews plumbing introduced here. Merge this PR before that backport.

Cherry-pick of merge commit cc4df4532eaf0c6c038fe0622c5c96a364a92989 (conflict-free).

Full context for agent readers

## Summary

Resolve legacy input-slot references through the canonical store-backed
slot view so `getInputSlotPos` remains correct after assignment and
reordering.

## Changes

- **What**: Record assigned-object to installed-view identity at the
input descriptor boundary and resolve it before slot-position
calculation.
- **Dependencies**: None.

## Review Focus

The installed `NodeInputSlot` remains authoritative. The weak facade
mapping only preserves compatibility for callers retaining the plain
object they assigned; after reordering, position follows the installed
view rather than the original array index.

Tests: focused Vitest 48/48; full typecheck; Knip; scoped ESLint and
oxfmt.

Related: #15973
Ruling:
christian-byrne/blocked-on-christian#214 (comment)

## Screenshots (if applicable)

Not applicable; no visual UI change.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit cc4df45)
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 16e21038-5190-49ce-bf17-77b0097f3264

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/10/2026, 10:50:58 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 103.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 161.7 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 181ms TBT · 157.0 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 435ms TBT · 180.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 503ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.3 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 36ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 864ms
canvas-mouse-sweep: script duration 142ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.2 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 357ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.5 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 443ms
dom-widget-clipping: script duration 155ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.9 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 600ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 81.9 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -184
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1576ms
large-graph-pan: script duration 764ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.8 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -154
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1650ms
large-graph-zoom: script duration 742ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.5 MB
large-graph-zoom: DOM nodes -139
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1915ms
legacy-node-drag: script duration 937ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.4 MB
legacy-node-drag: DOM nodes -140
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 565ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -133
minimap-idle: event listeners -76
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 398ms
subgraph-dom-widget-clipping: script duration 139ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 487ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -199
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 809ms
subgraph-mouse-sweep: script duration 101ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.6 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 937ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 128ms
subgraph-transition-enter: heap used 103.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5625ms
viewport-pan-sweep: script duration 2556ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.7 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -154
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17224ms
vue-large-graph-idle: script duration 309ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 161.7 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 21544ms
vue-large-graph-pan: script duration 922ms
vue-large-graph-pan: TBT 181ms
vue-large-graph-pan: heap used 157.0 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7471
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 73ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6313ms
vue-node-resize-workload: script duration 119ms
vue-node-resize-workload: TBT 435ms
vue-node-resize-workload: heap used 180.1 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 95ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.5 MB
workflow-execution: DOM nodes 140
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-10T23:02:39.982Z",
  "gitSha": "5a510873bc7696640350f6870b26447eb71dd9eb",
  "branch": "christian-byrne/backport-16510-cloud-1-53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2056.779000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.346000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.84799999999996,
      "heapDeltaBytes": -11359808,
      "heapUsedBytes": 59147824,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.484,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2053.6460000000716,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.958999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.87100000000004,
      "heapDeltaBytes": -11449508,
      "heapUsedBytes": 58889468,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.485000000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1874.4309999999587,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.07599999999999,
      "layouts": 14,
      "layoutDurationMs": 4.542999999999999,
      "taskDurationMs": 879.61,
      "heapDeltaBytes": 8420804,
      "heapUsedBytes": 78738220,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 146.291,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1815.8130000000483,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 35.388000000000005,
      "layouts": 14,
      "layoutDurationMs": 4.234,
      "taskDurationMs": 848.7159999999999,
      "heapDeltaBytes": -7960868,
      "heapUsedBytes": 62234488,
      "domNodes": -281,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 137.678,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.0060000000217,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.19,
      "layouts": 6,
      "layoutDurationMs": 1.022,
      "taskDurationMs": 351.603,
      "heapDeltaBytes": 4428828,
      "heapUsedBytes": 75008764,
      "domNodes": 77,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 11.005,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.8660000000673,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.216,
      "layouts": 6,
      "layoutDurationMs": 1.152,
      "taskDurationMs": 362.079,
      "heapDeltaBytes": 4408504,
      "heapUsedBytes": 74935776,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.013000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 648.9090000000033,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.510999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.65199999999993,
      "heapDeltaBytes": 18077724,
      "heapUsedBytes": 87749028,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 151.96900000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 702.9560000000856,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.948000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.921,
      "heapDeltaBytes": 18139784,
      "heapUsedBytes": 88199580,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 158.556,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.039000000003,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.209999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.746,
      "heapDeltaBytes": 10264276,
      "heapUsedBytes": 86149100,
      "domNodes": -271,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 36.778999999999996,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.720000000012,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.319,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.3570000000001,
      "heapDeltaBytes": 9780044,
      "heapUsedBytes": 85596488,
      "domNodes": -273,
      "jsHeapTotalBytes": -2179072,
      "scriptDurationMs": 39.523,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2111.8099999999913,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.760000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1485.8509999999999,
      "heapDeltaBytes": 18566556,
      "heapUsedBytes": 84060112,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 730.067,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2257.9769999999826,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.84,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1665.464,
      "heapDeltaBytes": -16236996,
      "heapUsedBytes": 85467188,
      "domNodes": -271,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 797.999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3537.029000000018,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.739000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.896,
      "taskDurationMs": 1661.141,
      "heapDeltaBytes": 11729296,
      "heapUsedBytes": 79572980,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 753.4340000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3452.900999999997,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.144000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.896,
      "taskDurationMs": 1639.6130000000003,
      "heapDeltaBytes": 9903172,
      "heapUsedBytes": 76719376,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 730.305,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3095.722999999964,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.9689999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1913.2149999999997,
      "heapDeltaBytes": 22400812,
      "heapUsedBytes": 89568464,
      "domNodes": -279,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 933.896,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3115.361000000007,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.061999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1915.9569999999997,
      "heapDeltaBytes": 17436992,
      "heapUsedBytes": 85260028,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 941.01,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1996.4820000000145,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.085,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.6469999999999,
      "heapDeltaBytes": 22102556,
      "heapUsedBytes": 88180664,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.455,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2027.541000000042,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.7389999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.7909999999999,
      "heapDeltaBytes": -15426716,
      "heapUsedBytes": 87268940,
      "domNodes": -272,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 33.513,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 625.2460000000042,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.459999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 397.12799999999993,
      "heapDeltaBytes": 14845632,
      "heapUsedBytes": 87452976,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 139.48499999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.436000000007,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.916,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 398.781,
      "heapDeltaBytes": 15131956,
      "heapUsedBytes": 87389164,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 138.721,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.8790000000026,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.311,
      "heapDeltaBytes": -6787064,
      "heapUsedBytes": 65587980,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.85,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2013.8909999999441,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.939,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.079,
      "heapDeltaBytes": -7371340,
      "heapUsedBytes": 64979992,
      "domNodes": -297,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 7.637999999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1757.4880000000235,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.443000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.341,
      "taskDurationMs": 792.23,
      "heapDeltaBytes": -11529076,
      "heapUsedBytes": 60654188,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 99.60799999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1755.3340000000617,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 41.583999999999996,
      "layouts": 18,
      "layoutDurationMs": 6.078,
      "taskDurationMs": 826.465,
      "heapDeltaBytes": 2410148,
      "heapUsedBytes": 74851172,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 101.89599999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1386.2210000000914,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 30.667,
      "layouts": 16,
      "layoutDurationMs": 14.585000000000004,
      "taskDurationMs": 936.7679999999998,
      "heapDeltaBytes": 21064104,
      "heapUsedBytes": 108571944,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.028,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8314.909,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 38.186,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5556.933000000001,
      "heapDeltaBytes": -12035260,
      "heapUsedBytes": 88813716,
      "domNodes": -273,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 2529.271,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8288.557999999966,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 39.858999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5692.956,
      "heapDeltaBytes": 4667712,
      "heapUsedBytes": 80530400,
      "domNodes": -271,
      "jsHeapTotalBytes": -118784,
      "scriptDurationMs": 2583.549,
      "eventListeners": -169,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17909.174000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17251.796,
      "heapDeltaBytes": -40677252,
      "heapUsedBytes": 162958088,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2121728,
      "scriptDurationMs": 311.905,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17831.998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17196.537,
      "heapDeltaBytes": -17705044,
      "heapUsedBytes": 176181084,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1056768,
      "scriptDurationMs": 306.379,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21860.701999999947,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 20.384000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21579.391,
      "heapDeltaBytes": -40147536,
      "heapUsedBytes": 162644352,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2121728,
      "scriptDurationMs": 905.0149999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 195,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21840.438999999948,
      "styleRecalcs": 171,
      "styleRecalcDurationMs": 19.695000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21509.19,
      "heapDeltaBytes": -42991912,
      "heapUsedBytes": 166588848,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5369856,
      "scriptDurationMs": 937.9980000000002,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 166,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6451.855999999963,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 72.44899999999998,
      "layouts": 20,
      "layoutDurationMs": 23.965,
      "taskDurationMs": 6359.711000000001,
      "heapDeltaBytes": -23833432,
      "heapUsedBytes": 186565776,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9310208,
      "scriptDurationMs": 117.915,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 465,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6340.953000000013,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.32899999999998,
      "layouts": 20,
      "layoutDurationMs": 24.900999999999993,
      "taskDurationMs": 6266.695,
      "heapDeltaBytes": -11869280,
      "heapUsedBytes": 191062708,
      "domNodes": -6548,
      "jsHeapTotalBytes": 17850368,
      "scriptDurationMs": 119.30700000000002,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 405,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 476.9170000000713,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.79,
      "layouts": 3,
      "layoutDurationMs": 1.4120000000000001,
      "taskDurationMs": 114.661,
      "heapDeltaBytes": 5203672,
      "heapUsedBytes": 73834956,
      "domNodes": 153,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.223,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 101.24099999995906,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.941000000000003,
      "layouts": 2,
      "layoutDurationMs": 1.4389999999999998,
      "taskDurationMs": 74.377,
      "heapDeltaBytes": 3129912,
      "heapUsedBytes": 71839080,
      "domNodes": 127,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.320000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48129 70680 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.4% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 259
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@christian-byrne christian-byrne added cloud/1.53 Backport PRs for cloud 1.53 risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 10, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 10, 2026
@DrJKL
DrJKL enabled auto-merge (squash) September 10, 2026 23:01
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17386   +/-   ##
=============================================
  Coverage              ?   83.35%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117305           
  Branches              ?    33137           
=============================================
  Hits                  ?    97778           
  Misses                ?    19167           
  Partials              ?      360           
Flag Coverage Δ
e2e 66.59% <100.00%> (?)
unit 76.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphNode.ts 69.21% <100.00%> (ø)
src/lib/litegraph/src/node/slotDescriptorView.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit 14782b3 into cloud/1.53 Sep 10, 2026
117 of 118 checks passed
@DrJKL
DrJKL deleted the christian-byrne/backport-16510-cloud-1-53 branch September 10, 2026 23:09

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Byte-identical to a cherry-pick of the source merge commit onto its base; CI green.

christian-byrne added a commit that referenced this pull request Sep 11, 2026
…ort) (#17388)

Backport of the slot-label refresh fix to the 1.53 release line.

- Slot labels now refresh after an input or output rename when the node
runs on ECS node state.
- Clean cherry-pick of the original fix; regression test included and
passing.
- Merge after the slot-position backport this branch is stacked on (link
below).

<details><summary>Full context for agent readers</summary>

Original fix on main:
#17319

This backport is stacked on the 1.53 backport of the
assigned-input-slot-position fix, because the regression test and the
label refresh path depend on it:

- core/1.53 dependency:
#17385
- cloud/1.53 dependency:
#17386

Merge order: land the dependency backport first, then this PR. Once the
dependency merges, this PR's diff reduces to the single cherry-picked
commit.

Verification: cherry-pick applied cleanly (no conflicts);
`src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes
locally on this branch; knip pre-push check passed.

Tracking issue for the ECS migration follow-ups:
#15973

<!-- authored-by:agent supreme-operator w3-w40 -->
</details>

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne added a commit that referenced this pull request Sep 11, 2026
…ort) (#17389)

Backport of the slot-label refresh fix to the 1.53 release line.

- Slot labels now refresh after an input or output rename when the node
runs on ECS node state.
- Clean cherry-pick of the original fix; regression test included and
passing.
- Merge after the slot-position backport this branch is stacked on (link
below).

<details><summary>Full context for agent readers</summary>

Original fix on main:
#17319

This backport is stacked on the 1.53 backport of the
assigned-input-slot-position fix, because the regression test and the
label refresh path depend on it:

- core/1.53 dependency:
#17385
- cloud/1.53 dependency:
#17386

Merge order: land the dependency backport first, then this PR. Once the
dependency merges, this PR's diff reduces to the single cherry-picked
commit.

Verification: cherry-pick applied cleanly (no conflicts);
`src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes
locally on this branch; knip pre-push check passed.

Tracking issue for the ECS migration follow-ups:
#15973

<!-- authored-by:agent supreme-operator w3-w40 -->
</details>

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.53 Backport PRs for cloud 1.53 risk:R3 PR risk grade (advisory shadow check; grader-owned) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants