Skip to content

fix: refresh slot labels after rename with ECS node state (1.53 backport) - #17389

Merged
christian-byrne merged 1 commit into
cloud/1.53from
christian-byrne/backport-17319-cloud-1-53
Sep 11, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.53from
christian-byrne/backport-17319-cloud-1-53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of the slot-label refresh fix to the 1.53 release line.

  • Slot labels now refresh after an input or output rename when the node runs on ECS node state.
  • Clean cherry-pick of the original fix; regression test included and passing.
  • Merge after the slot-position backport this branch is stacked on (link below).
Full context for agent readers

Original fix on main: #17319

This backport is stacked on the 1.53 backport of the assigned-input-slot-position fix, because the regression test and the label refresh path depend on it:

Merge order: land the dependency backport first, then this PR. Once the dependency merges, this PR's diff reduces to the single cherry-picked commit.

Verification: cherry-pick applied cleanly (no conflicts); src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts passes locally on this branch; knip pre-push check passed.

Tracking issue for the ECS migration follow-ups: #15973

@coderabbitai

coderabbitai Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: a6ccb799-ab74-4ba8-a417-33cf1835c378

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/10/2026, 11:45:37 PM UTC

Links

🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 134ms TBT · 82.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.4 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 156ms TBT · 170.1 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 523ms TBT · 167.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 563ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.6 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 46ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1009ms
canvas-mouse-sweep: script duration 164ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.2 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -169
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 4ms
canvas-zoom-sweep: style recalc duration 17ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 371ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 458ms
dom-widget-clipping: script duration 157ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.8 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 633ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.0 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1573ms
large-graph-pan: script duration 773ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.4 MB
large-graph-pan: DOM nodes -275
large-graph-pan: event listeners -184
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1702ms
large-graph-zoom: script duration 771ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 75.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1953ms
legacy-node-drag: script duration 973ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.4 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 591ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.7 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -155
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 542ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 61.5 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -200
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 861ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.4 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 998ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 134ms
subgraph-transition-enter: heap used 82.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 40ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5825ms
viewport-pan-sweep: script duration 2600ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.6 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17371ms
vue-large-graph-idle: script duration 298ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.4 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 172
vue-large-graph-pan: task duration 21883ms
vue-large-graph-pan: script duration 919ms
vue-large-graph-pan: TBT 156ms
vue-large-graph-pan: heap used 170.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6329ms
vue-node-resize-workload: script duration 130ms
vue-node-resize-workload: TBT 523ms
vue-node-resize-workload: heap used 167.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 92ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.1 MB
workflow-execution: DOM nodes 117
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-09-10T23:57:30.716Z",
  "gitSha": "a9fceace505fe31d5509d1f2dfd2bc7ffc23c434",
  "branch": "christian-byrne/backport-17319-cloud-1-53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2030.5930000000103,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.872999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.7529999999999,
      "heapDeltaBytes": 11953788,
      "heapUsedBytes": 81739524,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.803,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2070.7559999999603,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.4860000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.7189999999999,
      "heapDeltaBytes": -10263088,
      "heapUsedBytes": 59990084,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.972,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2071.7050000000086,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 46.723,
      "layouts": 14,
      "layoutDurationMs": 5.588,
      "taskDurationMs": 1089.874,
      "heapDeltaBytes": 6262468,
      "heapUsedBytes": 76513572,
      "domNodes": -282,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 175.31,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1936.7679999999154,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 44.868,
      "layouts": 14,
      "layoutDurationMs": 4.67,
      "taskDurationMs": 928.258,
      "heapDeltaBytes": -7895648,
      "heapUsedBytes": 62297428,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 152.344,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1681.8930000000023,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 17.059,
      "layouts": 6,
      "layoutDurationMs": 1.0849999999999997,
      "taskDurationMs": 378.43799999999993,
      "heapDeltaBytes": 4430880,
      "heapUsedBytes": 74988624,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.674999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.0969999999916,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.767000000000003,
      "layouts": 6,
      "layoutDurationMs": 7.281,
      "taskDurationMs": 364.539,
      "heapDeltaBytes": 4465700,
      "heapUsedBytes": 75099408,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.88,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.6360000000304,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.188,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.35400000000004,
      "heapDeltaBytes": 17828060,
      "heapUsedBytes": 88094372,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 160.716,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 678.9129999999659,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.063,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.021,
      "heapDeltaBytes": -8104448,
      "heapUsedBytes": 62577756,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 153.303,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.6739999999677,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.083999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 678.1570000000002,
      "heapDeltaBytes": -14213244,
      "heapUsedBytes": 86888408,
      "domNodes": -267,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 36.329,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2026.4150000000427,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.934,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.4070000000002,
      "heapDeltaBytes": 22253776,
      "heapUsedBytes": 87253520,
      "domNodes": -270,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.788999999999998,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2198.0970000000184,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.304999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1534.707,
      "heapDeltaBytes": 19038896,
      "heapUsedBytes": 84118604,
      "domNodes": -277,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 748.582,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2180.6609999999864,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.281,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1611.597,
      "heapDeltaBytes": 5486060,
      "heapUsedBytes": 82456804,
      "domNodes": -272,
      "jsHeapTotalBytes": -905216,
      "scriptDurationMs": 796.633,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3707.065,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.978999999999996,
      "layouts": 60,
      "layoutDurationMs": 13.552999999999999,
      "taskDurationMs": 1756.8420000000003,
      "heapDeltaBytes": 11684132,
      "heapUsedBytes": 79181784,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 787.515,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3442.6519999999527,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.190000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.577000000000002,
      "taskDurationMs": 1646.535,
      "heapDeltaBytes": 11715632,
      "heapUsedBytes": 79596308,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 753.5000000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3097.3389999999767,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.295000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1995.616,
      "heapDeltaBytes": 26052552,
      "heapUsedBytes": 93047572,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 982.275,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3047.567000000072,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.1579999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1910.034,
      "heapDeltaBytes": 22378732,
      "heapUsedBytes": 90237168,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 963.0859999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2014.0250000000037,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.9979999999999989,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.764,
      "heapDeltaBytes": 22097988,
      "heapUsedBytes": 87963048,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.848,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2021.2699999999586,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.192999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 579.097,
      "heapDeltaBytes": -15298628,
      "heapUsedBytes": 87489956,
      "domNodes": -270,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 32.412,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 580.3290000000061,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.872,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.523,
      "heapDeltaBytes": 14773960,
      "heapUsedBytes": 87457436,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 147.87900000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 577.9509999999846,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.977000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.425,
      "heapDeltaBytes": 14852744,
      "heapUsedBytes": 87116644,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 138.87199999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.2119999999722,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.697000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 543.3760000000001,
      "heapDeltaBytes": -6529220,
      "heapUsedBytes": 65831644,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.13,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2070.064000000002,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.629000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 539.7030000000001,
      "heapDeltaBytes": -9476996,
      "heapUsedBytes": 63229060,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.318000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1772.9380000000106,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 40.532,
      "layouts": 18,
      "layoutDurationMs": 6.089,
      "taskDurationMs": 874.582,
      "heapDeltaBytes": -12076544,
      "heapUsedBytes": 60134008,
      "domNodes": -294,
      "jsHeapTotalBytes": 7331840,
      "scriptDurationMs": 118.36899999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1755.5459999999812,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.184999999999995,
      "layouts": 18,
      "layoutDurationMs": 5.726,
      "taskDurationMs": 846.8370000000001,
      "heapDeltaBytes": -12400232,
      "heapUsedBytes": 60235796,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 110.879,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1415.4770000000099,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.59800000000001,
      "layouts": 16,
      "layoutDurationMs": 15.077,
      "taskDurationMs": 998.2010000000001,
      "heapDeltaBytes": -5541788,
      "heapUsedBytes": 86579176,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 32.896,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 134,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8782.820000000014,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 42.84,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6066.015,
      "heapDeltaBytes": 13380208,
      "heapUsedBytes": 88575824,
      "domNodes": -273,
      "jsHeapTotalBytes": -643072,
      "scriptDurationMs": 2668.975,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8319.462999999927,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 37.583,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5583.852,
      "heapDeltaBytes": -20391860,
      "heapUsedBytes": 80538184,
      "domNodes": -268,
      "jsHeapTotalBytes": -1916928,
      "scriptDurationMs": 2531.483,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17981.294999999987,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17666.566,
      "heapDeltaBytes": -34522000,
      "heapUsedBytes": 175800484,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5369856,
      "scriptDurationMs": 306.095,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17842.243999999937,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17074.479999999996,
      "heapDeltaBytes": -34860388,
      "heapUsedBytes": 175195424,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2301952,
      "scriptDurationMs": 289.264,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22605.416999999987,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 24.812,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22434.221999999998,
      "heapDeltaBytes": -30943568,
      "heapUsedBytes": 166538488,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3022848,
      "scriptDurationMs": 953.9069999999998,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 94,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21607.68500000006,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 19.594999999999974,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21332.039,
      "heapDeltaBytes": -19597856,
      "heapUsedBytes": 190215804,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4653056,
      "scriptDurationMs": 884.679,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 217,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6534.486000000015,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.44899999999998,
      "layouts": 20,
      "layoutDurationMs": 25.419999999999998,
      "taskDurationMs": 6452.781,
      "heapDeltaBytes": -24868568,
      "heapUsedBytes": 178445352,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9957376,
      "scriptDurationMs": 145.59,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 480,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6316.913,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.92699999999996,
      "layouts": 20,
      "layoutDurationMs": 24.082999999999995,
      "taskDurationMs": 6204.89,
      "heapDeltaBytes": -37652204,
      "heapUsedBytes": 173141680,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12247040,
      "scriptDurationMs": 113.50099999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 565,
      "frameDurationMs": 18.33666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.3490000000793,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 23.337999999999997,
      "layouts": 4,
      "layoutDurationMs": 1.8960000000000001,
      "taskDurationMs": 116.57499999999999,
      "heapDeltaBytes": 5078440,
      "heapUsedBytes": 72694916,
      "domNodes": 124,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.537,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 105.84899999992103,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 12.921,
      "layouts": 2,
      "layoutDurationMs": 0.6819999999999998,
      "taskDurationMs": 66.68099999999998,
      "heapDeltaBytes": 3156436,
      "heapUsedBytes": 70161400,
      "domNodes": 109,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.186000000000001,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48137 70687 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 303
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 259
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@christian-byrne christian-byrne added the cloud/1.53 Backport PRs for cloud 1.53 label Sep 10, 2026
@christian-byrne christian-byrne added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 10, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 10, 2026
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17389   +/-   ##
=============================================
  Coverage              ?   83.34%           
=============================================
  Files                 ?     2025           
  Lines                 ?   117321           
  Branches              ?    32548           
=============================================
  Hits                  ?    97784           
  Misses                ?    19178           
  Partials              ?      359           
Flag Coverage Δ
e2e 66.59% <100.00%> (?)
unit 76.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphNode.ts 69.23% <100.00%> (ø)
src/lib/litegraph/src/node/slotDescriptorView.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut CodeJuggernaut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Byte-identical to a cherry-pick of the source merge commit onto its base; CI green.

Fixes #16642

- Renaming an input or output slot now refreshes the rendered label
immediately (regressed when the ECS node state landed in #14246).
- Slot descriptors are exposed to the node shell through a reactive
view, so any slot field edit propagates; no per-field handlers needed.
- Regression test added (fails on main, passes here).

<details><summary>Full context for agent readers</summary>

**Root cause.** Before ECS, `LGraphCanvas` listened for
`node:slot-label:changed` and redrew. The ECS merge removed that handler
and instead reads slot data through `createNodeShellState`. The plain
objects in `node.inputs` / `node.outputs` are not reactive, so label
writes never invalidated the shell state and the Vue node kept the old
label.

**Fix.** `src/lib/litegraph/src/node/slotDescriptorView.ts` adds a
generic `createSlotView<T>` Proxy (exported as `createInputSlotView` /
`createOutputSlotView`, plus `resolveInputSlotView` for lookups).
`createNodeShellState` in `src/core/graph/nodeShell/nodeShellState.ts`
takes the two view factories and derives its slot arrays from them;
`LGraphNode.ts` passes them through. Any write to a slot descriptor
(label, name, type) now triggers the shell to recompute.

**Tests.**
`src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` (5
cases: input rename, output rename, rename after link, rename of a
widget-backed input, rename via `renameSlot`). Written TDD: red on
`main`, green on this branch. The test lives under
`src/core/graph/nodeShell/` to satisfy the layer-boundary lint. `pnpm
vitest run` on the three touched test files: 18/18. `pnpm typecheck`
clean, `oxlint`/`eslint` clean.

**Disclosure.** Knip (pre-push hook) flagged an unused
`resolveOutputSlotView` export that I had added for symmetry; I removed
it rather than leave dead code. Add it back if a caller appears.

**Backport.** Labelled `needs-backport`, `core/1.53`, `cloud/1.53` per
program policy (every ECS fix goes to 1.53 before promotion).

<!-- authored-by:agent supreme-operator w3-520-followup -->
</details>

---------

Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit 928cd4a)
@christian-byrne
christian-byrne force-pushed the christian-byrne/backport-17319-cloud-1-53 branch from b686167 to 074bb07 Compare September 10, 2026 23:43
@christian-byrne
christian-byrne merged commit 740734d into cloud/1.53 Sep 11, 2026
95 checks passed
@christian-byrne
christian-byrne deleted the christian-byrne/backport-17319-cloud-1-53 branch September 11, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cloud/1.53 Backport PRs for cloud 1.53 risk:R3 PR risk grade (advisory shadow check; grader-owned) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants