Repository navigation
fix: refresh slot labels after rename with ECS node state (1.53 backport) - #17388
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Fixes #16642 - Renaming an input or output slot now refreshes the rendered label immediately (regressed when the ECS node state landed in #14246). - Slot descriptors are exposed to the node shell through a reactive view, so any slot field edit propagates; no per-field handlers needed. - Regression test added (fails on main, passes here). <details><summary>Full context for agent readers</summary> **Root cause.** Before ECS, `LGraphCanvas` listened for `node:slot-label:changed` and redrew. The ECS merge removed that handler and instead reads slot data through `createNodeShellState`. The plain objects in `node.inputs` / `node.outputs` are not reactive, so label writes never invalidated the shell state and the Vue node kept the old label. **Fix.** `src/lib/litegraph/src/node/slotDescriptorView.ts` adds a generic `createSlotView<T>` Proxy (exported as `createInputSlotView` / `createOutputSlotView`, plus `resolveInputSlotView` for lookups). `createNodeShellState` in `src/core/graph/nodeShell/nodeShellState.ts` takes the two view factories and derives its slot arrays from them; `LGraphNode.ts` passes them through. Any write to a slot descriptor (label, name, type) now triggers the shell to recompute. **Tests.** `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` (5 cases: input rename, output rename, rename after link, rename of a widget-backed input, rename via `renameSlot`). Written TDD: red on `main`, green on this branch. The test lives under `src/core/graph/nodeShell/` to satisfy the layer-boundary lint. `pnpm vitest run` on the three touched test files: 18/18. `pnpm typecheck` clean, `oxlint`/`eslint` clean. **Disclosure.** Knip (pre-push hook) flagged an unused `resolveOutputSlotView` export that I had added for symmetry; I removed it rather than leave dead code. Add it back if a caller appears. **Backport.** Labelled `needs-backport`, `core/1.53`, `cloud/1.53` per program policy (every ECS fix goes to 1.53 before promotion). <!-- authored-by:agent supreme-operator w3-520-followup --> </details> --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 928cd4a)
cd92452 to
b9a3097
Compare
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1894 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-10T23:55:10.825Z",
"gitSha": "a08c1b2c0dfc96ecc61135aeed40a20046f46358",
"branch": "christian-byrne/backport-17319-core-1-53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2088.3159999999634,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.189,
"heapDeltaBytes": -14647660,
"heapUsedBytes": 55391436,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.303,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.4999999999654,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.5310000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.9629999999999,
"heapDeltaBytes": 13007436,
"heapUsedBytes": 82711380,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.896,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2068.8499999999976,
"styleRecalcs": 81,
"styleRecalcDurationMs": 50.06099999999999,
"layouts": 14,
"layoutDurationMs": 4.552,
"taskDurationMs": 1054.964,
"heapDeltaBytes": 8588228,
"heapUsedBytes": 78856864,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 181.021,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1818.3800000000474,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.599999999999994,
"layouts": 14,
"layoutDurationMs": 4.194,
"taskDurationMs": 865.846,
"heapDeltaBytes": -8765052,
"heapUsedBytes": 61743276,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 159.216,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1732.5960000000578,
"styleRecalcs": 31,
"styleRecalcDurationMs": 19.259999999999998,
"layouts": 6,
"layoutDurationMs": 1.1009999999999998,
"taskDurationMs": 391.679,
"heapDeltaBytes": 4404328,
"heapUsedBytes": 74095032,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.191,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.1010000000288,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.988999999999997,
"layouts": 6,
"layoutDurationMs": 1.0819999999999999,
"taskDurationMs": 354.387,
"heapDeltaBytes": 4689316,
"heapUsedBytes": 74956652,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.780000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 648.7720000000081,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.594000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.69499999999994,
"heapDeltaBytes": -8068772,
"heapUsedBytes": 62635744,
"domNodes": 18,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 162.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 636.1739999999827,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.680999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.353,
"heapDeltaBytes": 17826908,
"heapUsedBytes": 88075592,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 157.045,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2038.8749999999618,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.9760000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.0060000000001,
"heapDeltaBytes": -14558884,
"heapUsedBytes": 85965932,
"domNodes": -267,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 41.555,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2036.279000000036,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.446,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.228,
"heapDeltaBytes": 11209524,
"heapUsedBytes": 86324876,
"domNodes": -270,
"jsHeapTotalBytes": -1916928,
"scriptDurationMs": 29.717000000000006,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2302.4239999999736,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.691999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1663.742,
"heapDeltaBytes": 23237988,
"heapUsedBytes": 89306872,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 864.4849999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2274.1309999998975,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.867,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1676.3719999999998,
"heapDeltaBytes": 7868408,
"heapUsedBytes": 84699412,
"domNodes": -275,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 839.445,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3735.9370000000354,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.871000000000002,
"layouts": 60,
"layoutDurationMs": 12.983000000000002,
"taskDurationMs": 1823.9229999999998,
"heapDeltaBytes": 12089024,
"heapUsedBytes": 79960588,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 826.3079999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3489.7059999999556,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.896999999999997,
"layouts": 60,
"layoutDurationMs": 11.967,
"taskDurationMs": 1670.9709999999998,
"heapDeltaBytes": 7717452,
"heapUsedBytes": 75025416,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.0830000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3101.128000000017,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.976,
"heapDeltaBytes": 18549264,
"heapUsedBytes": 84523172,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 933.9130000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3114.5549999999957,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.942000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1959.697,
"heapDeltaBytes": 21945192,
"heapUsedBytes": 89786324,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.0790000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2031.5850000000637,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.857999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 646.024,
"heapDeltaBytes": -15831712,
"heapUsedBytes": 87035376,
"domNodes": -270,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 38.879999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2054.6679999999924,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.795,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.243,
"heapDeltaBytes": -15945328,
"heapUsedBytes": 87160868,
"domNodes": -272,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 34.902,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.4209999999266,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.66700000000003,
"heapDeltaBytes": 14847796,
"heapUsedBytes": 87262480,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 147.768,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 601.2419999999565,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.858,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.175,
"heapDeltaBytes": 14802892,
"heapUsedBytes": 87094240,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.215,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2016.664999999989,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.199,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.104,
"heapDeltaBytes": -8356540,
"heapUsedBytes": 63972384,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.004000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2012.7969999999777,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.305,
"heapDeltaBytes": 704384,
"heapUsedBytes": 73082852,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.427,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.6579999999726,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.341,
"layouts": 18,
"layoutDurationMs": 5.764,
"taskDurationMs": 832.0989999999999,
"heapDeltaBytes": -12025048,
"heapUsedBytes": 60689052,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.94,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.7550000000201,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.899,
"layouts": 18,
"layoutDurationMs": 4.930000000000001,
"taskDurationMs": 815.7149999999999,
"heapDeltaBytes": -11837968,
"heapUsedBytes": 60700108,
"domNodes": -295,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 107.92599999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1465.6949999999824,
"styleRecalcs": 20,
"styleRecalcDurationMs": 35.14099999999999,
"layouts": 16,
"layoutDurationMs": 17.444,
"taskDurationMs": 1088.2369999999999,
"heapDeltaBytes": -9293832,
"heapUsedBytes": 82284864,
"domNodes": 13751,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 36.39099999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 163,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9020.80600000005,
"styleRecalcs": 246,
"styleRecalcDurationMs": 36.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6237.264,
"heapDeltaBytes": -12055164,
"heapUsedBytes": 88583284,
"domNodes": -271,
"jsHeapTotalBytes": -1425408,
"scriptDurationMs": 2804.2369999999996,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8523.258000000056,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.535,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5864.864,
"heapDeltaBytes": 13795292,
"heapUsedBytes": 88927156,
"domNodes": -274,
"jsHeapTotalBytes": -643072,
"scriptDurationMs": 2737.638,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17537.761000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16727.447,
"heapDeltaBytes": -39881880,
"heapUsedBytes": 175871704,
"domNodes": -6548,
"jsHeapTotalBytes": 2924544,
"scriptDurationMs": 304.473,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17438.91199999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16688.05,
"heapDeltaBytes": -25892752,
"heapUsedBytes": 180227396,
"domNodes": -6548,
"jsHeapTotalBytes": 3764224,
"scriptDurationMs": 294.76099999999997,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21212.27600000009,
"styleRecalcs": 176,
"styleRecalcDurationMs": 18.92100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20844.301000000003,
"heapDeltaBytes": -12105060,
"heapUsedBytes": 190247288,
"domNodes": -6548,
"jsHeapTotalBytes": 3649536,
"scriptDurationMs": 922.987,
"eventListeners": -7465,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21631.86200000007,
"styleRecalcs": 178,
"styleRecalcDurationMs": 19.43800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21292.069000000003,
"heapDeltaBytes": -22062036,
"heapUsedBytes": 180398052,
"domNodes": -6548,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 976.018,
"eventListeners": -7467,
"totalBlockingTimeMs": 55,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6419.967000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.06700000000001,
"layouts": 20,
"layoutDurationMs": 24.51000000000002,
"taskDurationMs": 6280.840999999999,
"heapDeltaBytes": -26733380,
"heapUsedBytes": 181569860,
"domNodes": -6548,
"jsHeapTotalBytes": 13164544,
"scriptDurationMs": 116.598,
"eventListeners": -7469,
"totalBlockingTimeMs": 420,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6170.500000000061,
"styleRecalcs": 20,
"styleRecalcDurationMs": 85.862,
"layouts": 20,
"layoutDurationMs": 23.281999999999996,
"taskDurationMs": 6098.418000000001,
"heapDeltaBytes": -31575596,
"heapUsedBytes": 181988840,
"domNodes": -6548,
"jsHeapTotalBytes": 4268032,
"scriptDurationMs": 108.691,
"eventListeners": -7469,
"totalBlockingTimeMs": 397,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 113.52799999997387,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.589000000000002,
"layouts": 3,
"layoutDurationMs": 0.731,
"taskDurationMs": 79.76399999999998,
"heapDeltaBytes": 3215492,
"heapUsedBytes": 72111052,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.479999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.35299999998824,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.349999999999998,
"layouts": 3,
"layoutDurationMs": 0.873,
"taskDurationMs": 102.218,
"heapDeltaBytes": 5064492,
"heapUsedBytes": 73837032,
"domNodes": 121,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.876999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #17388 +/- ##
=============================================
+ Coverage 83.34% 83.35% +0.01%
=============================================
Files 2025 2025
Lines 117249 117326 +77
Branches 33122 32559 -563
=============================================
+ Hits 97717 97799 +82
+ Misses 19172 19167 -5
Partials 360 360
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of the slot-label refresh fix to the 1.53 release line.
Full context for agent readers
Original fix on main: #17319
This backport is stacked on the 1.53 backport of the assigned-input-slot-position fix, because the regression test and the label refresh path depend on it:
Merge order: land the dependency backport first, then this PR. Once the dependency merges, this PR's diff reduces to the single cherry-picked commit.
Verification: cherry-pick applied cleanly (no conflicts);
src/core/graph/nodeShell/slotLabelReactivity.regression.test.tspasses locally on this branch; knip pre-push check passed.Tracking issue for the ECS migration follow-ups: #15973