Repository navigation
[backport core/1.53] fix: resolve assigned input slot positions - #17385
Merged
Merged
Conversation
## Summary Resolve legacy input-slot references through the canonical store-backed slot view so `getInputSlotPos` remains correct after assignment and reordering. ## Changes - **What**: Record assigned-object to installed-view identity at the input descriptor boundary and resolve it before slot-position calculation. - **Dependencies**: None. ## Review Focus The installed `NodeInputSlot` remains authoritative. The weak facade mapping only preserves compatibility for callers retaining the plain object they assigned; after reordering, position follows the installed view rather than the original array index. Tests: focused Vitest 48/48; full typecheck; Knip; scoped ESLint and oxfmt. Related: #15973 Ruling: christian-byrne/blocked-on-christian#214 (comment) ## Screenshots (if applicable) Not applicable; no visual UI change. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit cc4df45)
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Contributor
🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook |
DrJKL
approved these changes
Sep 10, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #17385 +/- ##
==========================================
Coverage 83.34% 83.34%
==========================================
Files 2025 2025
Lines 117242 117309 +67
Branches 32531 32550 +19
==========================================
+ Hits 97710 97775 +65
- Misses 19172 19184 +12
+ Partials 360 350 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 38 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This was referenced Sep 10, 2026
christian-byrne
added a commit
that referenced
this pull request
Sep 11, 2026
…ort) (#17388) Backport of the slot-label refresh fix to the 1.53 release line. - Slot labels now refresh after an input or output rename when the node runs on ECS node state. - Clean cherry-pick of the original fix; regression test included and passing. - Merge after the slot-position backport this branch is stacked on (link below). <details><summary>Full context for agent readers</summary> Original fix on main: #17319 This backport is stacked on the 1.53 backport of the assigned-input-slot-position fix, because the regression test and the label refresh path depend on it: - core/1.53 dependency: #17385 - cloud/1.53 dependency: #17386 Merge order: land the dependency backport first, then this PR. Once the dependency merges, this PR's diff reduces to the single cherry-picked commit. Verification: cherry-pick applied cleanly (no conflicts); `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes locally on this branch; knip pre-push check passed. Tracking issue for the ECS migration follow-ups: #15973 <!-- authored-by:agent supreme-operator w3-w40 --> </details> Co-authored-by: Amp <amp@ampcode.com>
christian-byrne
added a commit
that referenced
this pull request
Sep 11, 2026
…ort) (#17389) Backport of the slot-label refresh fix to the 1.53 release line. - Slot labels now refresh after an input or output rename when the node runs on ECS node state. - Clean cherry-pick of the original fix; regression test included and passing. - Merge after the slot-position backport this branch is stacked on (link below). <details><summary>Full context for agent readers</summary> Original fix on main: #17319 This backport is stacked on the 1.53 backport of the assigned-input-slot-position fix, because the regression test and the label refresh path depend on it: - core/1.53 dependency: #17385 - cloud/1.53 dependency: #17386 Merge order: land the dependency backport first, then this PR. Once the dependency merges, this PR's diff reduces to the single cherry-picked commit. Verification: cherry-pick applied cleanly (no conflicts); `src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes locally on this branch; knip pre-push check passed. Tracking issue for the ECS migration follow-ups: #15973 <!-- authored-by:agent supreme-operator w3-w40 --> </details> Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16510 (assigned input slot position resolution) to the 1.53 release branch.
Why now: the 1.53 backport of #17319 depends on the
assignedInputViewsplumbing introduced here. Merge this PR before that backport.Cherry-pick of merge commit
cc4df4532eaf0c6c038fe0622c5c96a364a92989(conflict-free).Full context for agent readers