Skip to content

[backport core/1.53] fix: resolve assigned input slot positions - #17385

Merged
DrJKL merged 1 commit into
core/1.53from
christian-byrne/backport-16510-core-1-53
Sep 10, 2026
Merged

DrJKL merged 1 commit into
core/1.53from
christian-byrne/backport-16510-core-1-53

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #16510 (assigned input slot position resolution) to the 1.53 release branch.

Why now: the 1.53 backport of #17319 depends on the assignedInputViews plumbing introduced here. Merge this PR before that backport.

Cherry-pick of merge commit cc4df4532eaf0c6c038fe0622c5c96a364a92989 (conflict-free).

Full context for agent readers

## Summary

Resolve legacy input-slot references through the canonical store-backed
slot view so `getInputSlotPos` remains correct after assignment and
reordering.

## Changes

- **What**: Record assigned-object to installed-view identity at the
input descriptor boundary and resolve it before slot-position
calculation.
- **Dependencies**: None.

## Review Focus

The installed `NodeInputSlot` remains authoritative. The weak facade
mapping only preserves compatibility for callers retaining the plain
object they assigned; after reordering, position follows the installed
view rather than the original array index.

Tests: focused Vitest 48/48; full typecheck; Knip; scoped ESLint and
oxfmt.

Related: #15973
Ruling:
christian-byrne/blocked-on-christian#214 (comment)

## Screenshots (if applicable)

Not applicable; no visual UI change.

---------

Co-authored-by: Alexander Brown <drjkl@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit cc4df45)
@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d961477f-d782-4eea-b458-45e53da1e95d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1892 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1871 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/10/2026, 10:49:39 PM UTC

Links

@christian-byrne christian-byrne added core/1.53 Backport PRs for core 1.53 risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 10, 2026
@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 10, 2026
@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##           core/1.53   #17385   +/-   ##
==========================================
  Coverage      83.34%   83.34%           
==========================================
  Files           2025     2025           
  Lines         117242   117309   +67     
  Branches       32531    32550   +19     
==========================================
+ Hits           97710    97775   +65     
- Misses         19172    19184   +12     
+ Partials         360      350   -10     
Flag Coverage Δ
e2e 66.61% <100.00%> (+0.04%) ⬆️
unit 76.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraphNode.ts 69.21% <100.00%> (+0.31%) ⬆️
src/lib/litegraph/src/node/slotDescriptorView.ts 100.00% <100.00%> (ø)

... and 38 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL
DrJKL merged commit 83a144f into core/1.53 Sep 10, 2026
116 checks passed
@DrJKL
DrJKL deleted the christian-byrne/backport-16510-core-1-53 branch September 10, 2026 23:02
christian-byrne added a commit that referenced this pull request Sep 11, 2026
…ort) (#17388)

Backport of the slot-label refresh fix to the 1.53 release line.

- Slot labels now refresh after an input or output rename when the node
runs on ECS node state.
- Clean cherry-pick of the original fix; regression test included and
passing.
- Merge after the slot-position backport this branch is stacked on (link
below).

<details><summary>Full context for agent readers</summary>

Original fix on main:
#17319

This backport is stacked on the 1.53 backport of the
assigned-input-slot-position fix, because the regression test and the
label refresh path depend on it:

- core/1.53 dependency:
#17385
- cloud/1.53 dependency:
#17386

Merge order: land the dependency backport first, then this PR. Once the
dependency merges, this PR's diff reduces to the single cherry-picked
commit.

Verification: cherry-pick applied cleanly (no conflicts);
`src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes
locally on this branch; knip pre-push check passed.

Tracking issue for the ECS migration follow-ups:
#15973

<!-- authored-by:agent supreme-operator w3-w40 -->
</details>

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne added a commit that referenced this pull request Sep 11, 2026
…ort) (#17389)

Backport of the slot-label refresh fix to the 1.53 release line.

- Slot labels now refresh after an input or output rename when the node
runs on ECS node state.
- Clean cherry-pick of the original fix; regression test included and
passing.
- Merge after the slot-position backport this branch is stacked on (link
below).

<details><summary>Full context for agent readers</summary>

Original fix on main:
#17319

This backport is stacked on the 1.53 backport of the
assigned-input-slot-position fix, because the regression test and the
label refresh path depend on it:

- core/1.53 dependency:
#17385
- cloud/1.53 dependency:
#17386

Merge order: land the dependency backport first, then this PR. Once the
dependency merges, this PR's diff reduces to the single cherry-picked
commit.

Verification: cherry-pick applied cleanly (no conflicts);
`src/core/graph/nodeShell/slotLabelReactivity.regression.test.ts` passes
locally on this branch; knip pre-push check passed.

Tracking issue for the ECS migration follow-ups:
#15973

<!-- authored-by:agent supreme-operator w3-w40 -->
</details>

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core/1.53 Backport PRs for core 1.53 risk:R3 PR risk grade (advisory shadow check; grader-owned) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants