Repository navigation
test: correct stale and false cross-references on disabled-test markers - #19927
Conversation
AgentPanelRoot.test.ts describes agentPanelLifecycle.spec.ts as "still test.fixme pending FE #16919". #16919 was closed unmerged; #17132 is what re-enabled the spec, and it carries no fixme today. agentNestedOutputSentPreview.spec.ts defers its decision to "open owner PRs (#16985, #17767)". Both merged. PM-1158 closed on a partial fix (#18104, image path only) and PM-1157 on this repro, so the non-image path the test pins is unowned. assetDownloadStore.test.ts labels PM-1302 / PM-1309 an OPEN design question; both are closed. Its title also claims the task is "never reconciled", and its inner comment that pollStaleDownloads() "only walks activeDownloads" - both false, and contradicted by the same block's own header and by the passing polling test below it. pollStaleDownloads() walks recheckableDownloads, which includes 'failed'. The gap the marker pins is real and still deliberate, so the marker stays; only the false consequence is dropped from its title. No assertion, marker, or product code is changed. No test.fail(), test.fixme() or it.fails() is added, removed or re-scoped.
🎨 Storybook: ✅ Built — View Storybook⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T20:45:09.770Z",
"gitSha": "3044c5abc34914d1fb3ef4fc5499ff9081dd4e1f",
"branch": "glary/stale-disabled-test-annotations",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.325000000032,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3450000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.3430000000001,
"heapDeltaBytes": 22312736,
"heapUsedBytes": 76169812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.564999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.547000000045,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.468999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.86699999999996,
"heapDeltaBytes": 580000,
"heapUsedBytes": 67862824,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.374000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.144000000037,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.57,
"layouts": 12,
"layoutDurationMs": 4.458,
"taskDurationMs": 842.319,
"heapDeltaBytes": -29904352,
"heapUsedBytes": 72770984,
"domNodes": -230,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 172.048,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.1440000000448,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.915,
"layouts": 12,
"layoutDurationMs": 4.854,
"taskDurationMs": 812.4420000000001,
"heapDeltaBytes": -2613416,
"heapUsedBytes": 64184928,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 165.32,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1695.6179999999677,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.827000000000002,
"layouts": 6,
"layoutDurationMs": 1.1759999999999997,
"taskDurationMs": 343.26499999999993,
"heapDeltaBytes": 25305072,
"heapUsedBytes": 79372696,
"domNodes": -177,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.364999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1744.6340000000191,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.64,
"layouts": 6,
"layoutDurationMs": 2.0149999999999997,
"taskDurationMs": 423.23600000000005,
"heapDeltaBytes": -26025212,
"heapUsedBytes": 77697080,
"domNodes": -199,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 13.995999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 721.8460000000277,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.899999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.042,
"heapDeltaBytes": -7091044,
"heapUsedBytes": 60507932,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 164.612,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667441860465132,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 712.7219999999852,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.633000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.20200000000006,
"heapDeltaBytes": 14539036,
"heapUsedBytes": 68283812,
"domNodes": -232,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.147,
"eventListeners": -119,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285704,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1149.8490000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 766.181,
"heapDeltaBytes": 38197840,
"heapUsedBytes": 107008452,
"domNodes": 0,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 70.93300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 516,
"frameDurationMs": 33.82058823529413,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1224.0399999999454,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.394,
"heapDeltaBytes": 16427112,
"heapUsedBytes": 84719296,
"domNodes": 0,
"jsHeapTotalBytes": 8552448,
"scriptDurationMs": 76.412,
"eventListeners": 0,
"totalBlockingTimeMs": 576,
"frameDurationMs": 35.782352941176484,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 857.231000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 493.63,
"heapDeltaBytes": 17550188,
"heapUsedBytes": 104781892,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 177.19399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 237,
"frameDurationMs": 25.485294117647058,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 892.4759999999878,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.8379999999997,
"heapDeltaBytes": 17615860,
"heapUsedBytes": 119033816,
"domNodes": 0,
"jsHeapTotalBytes": 2887680,
"scriptDurationMs": 193.62499999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 235,
"frameDurationMs": 25.714285714285715,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10483.647000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9538.502999999999,
"heapDeltaBytes": 8675764,
"heapUsedBytes": 92704288,
"domNodes": -142,
"jsHeapTotalBytes": -6688768,
"scriptDurationMs": 7874.188999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 1238,
"frameDurationMs": 33.65369774919614,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9157.152999999995,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6189999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8550.291000000001,
"heapDeltaBytes": -5336272,
"heapUsedBytes": 72120456,
"domNodes": -142,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 7256.209,
"eventListeners": -74,
"totalBlockingTimeMs": 1197,
"frameDurationMs": 36.452589641434265,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10327.188999999977,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.08700000000000027,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9418.564,
"heapDeltaBytes": 14138780,
"heapUsedBytes": 98573612,
"domNodes": -142,
"jsHeapTotalBytes": -1708032,
"scriptDurationMs": 7791.012,
"eventListeners": -78,
"totalBlockingTimeMs": 1349,
"frameDurationMs": 34.047194719471946,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9567.97800000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.42100000000000126,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8814.173999999999,
"heapDeltaBytes": 1273636,
"heapUsedBytes": 68855104,
"domNodes": -142,
"jsHeapTotalBytes": -6950912,
"scriptDurationMs": 7250.573,
"eventListeners": -70,
"totalBlockingTimeMs": 966,
"frameDurationMs": 33.101384083044984,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "large-graph-idle",
"durationMs": 2056.2630000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.757999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.608,
"heapDeltaBytes": -51606752,
"heapUsedBytes": 72325652,
"domNodes": -328,
"jsHeapTotalBytes": -3244032,
"scriptDurationMs": 35.947,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.174999999961,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.2909999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.1840000000001,
"heapDeltaBytes": 14584984,
"heapUsedBytes": 92945560,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 34.888,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2334.716999999955,
"styleRecalcs": 66,
"styleRecalcDurationMs": 9.505,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1564.25,
"heapDeltaBytes": 1111400,
"heapUsedBytes": 64324024,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 815.421,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7863309352518,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2752.9719999999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 10.921000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1682.7589999999998,
"heapDeltaBytes": 9861768,
"heapUsedBytes": 95446488,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 912.0780000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66545454545455,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3618.069999999989,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.589,
"layouts": 60,
"layoutDurationMs": 14.522,
"taskDurationMs": 1640.1940000000002,
"heapDeltaBytes": 113072,
"heapUsedBytes": 64611232,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.073,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666359447004606,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3676.2469999999894,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.045,
"layouts": 60,
"layoutDurationMs": 15.042,
"taskDurationMs": 1694.2090000000003,
"heapDeltaBytes": 2173236,
"heapUsedBytes": 78452616,
"domNodes": 24,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 805.846,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666063348416284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3098.1270000000336,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.4159999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1874.2340000000002,
"heapDeltaBytes": 8049104,
"heapUsedBytes": 73323716,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 974.434,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3115.2720000000045,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.282,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.2810000000002,
"heapDeltaBytes": 8606816,
"heapUsedBytes": 77300828,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 993.355,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75537634408602,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2013.9929999999708,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.8190000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.7419999999999,
"heapDeltaBytes": -10083108,
"heapUsedBytes": 77677020,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 33.858,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.0059999999994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.640000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.921,
"heapDeltaBytes": -9651792,
"heapUsedBytes": 79510060,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 37.352999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 643.1109999999762,
"styleRecalcs": 48,
"styleRecalcDurationMs": 7.092000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.1,
"heapDeltaBytes": -11641744,
"heapUsedBytes": 57034172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.673,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.5469999999596,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.822,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.345,
"heapDeltaBytes": 9528440,
"heapUsedBytes": 62965932,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.69800000000004,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.2820000000088,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.322000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.408,
"heapDeltaBytes": 21955732,
"heapUsedBytes": 74985808,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.329,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.4289999999783,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.437999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.474,
"heapDeltaBytes": 714804,
"heapUsedBytes": 70069836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.467000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.9680000000035,
"styleRecalcs": 78,
"styleRecalcDurationMs": 18.929999999999996,
"layouts": 16,
"layoutDurationMs": 5.976,
"taskDurationMs": 779.32,
"heapDeltaBytes": 14875072,
"heapUsedBytes": 68970372,
"domNodes": -249,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.87,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.7370000000037,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.194000000000003,
"layouts": 16,
"layoutDurationMs": 5.745,
"taskDurationMs": 775.01,
"heapDeltaBytes": -6357016,
"heapUsedBytes": 63416740,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.276,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.475000000005,
"styleRecalcs": 16,
"styleRecalcDurationMs": 30.506999999999998,
"layouts": 5,
"layoutDurationMs": 13.313999999999997,
"taskDurationMs": 941.9289999999997,
"heapDeltaBytes": 24055920,
"heapUsedBytes": 110287092,
"domNodes": 13747,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 31.10600000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 19.676388888888873,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8636.797000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5689.135,
"heapDeltaBytes": -59517480,
"heapUsedBytes": 64722568,
"domNodes": -328,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 2740.786,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8757.357999999953,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.316,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5713.928,
"heapDeltaBytes": -17141304,
"heapUsedBytes": 71203812,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2892.461,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.697900763358778,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18126.02800000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17274.608,
"heapDeltaBytes": -54753728,
"heapUsedBytes": 169182644,
"domNodes": -3045,
"jsHeapTotalBytes": 5947392,
"scriptDurationMs": 287.04999999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.75569176882662,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17585.51899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16787.043,
"heapDeltaBytes": -44772852,
"heapUsedBytes": 163930104,
"domNodes": -3045,
"jsHeapTotalBytes": 7622656,
"scriptDurationMs": 275.203,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.902551020408165,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22163.846999999976,
"styleRecalcs": 179,
"styleRecalcDurationMs": 23.29500000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21758.933,
"heapDeltaBytes": -46544656,
"heapUsedBytes": 178837528,
"domNodes": -3045,
"jsHeapTotalBytes": 5120000,
"scriptDurationMs": 941.4999999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 41,
"frameDurationMs": 40.715257352941165,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-pan",
"durationMs": 21227.299000000017,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.36799999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20749.702,
"heapDeltaBytes": -39607028,
"heapUsedBytes": 169357676,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 864.8359999999999,
"eventListeners": -14915,
"totalBlockingTimeMs": 36,
"frameDurationMs": 38.57418181818182,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6339.247,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.795,
"layouts": 20,
"layoutDurationMs": 26.62099999999999,
"taskDurationMs": 6247.591,
"heapDeltaBytes": 14391596,
"heapUsedBytes": 221367760,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 112.00800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.02275449101796,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6284.39000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.18599999999998,
"layouts": 20,
"layoutDurationMs": 26.078000000000003,
"taskDurationMs": 6161.491,
"heapDeltaBytes": -6066160,
"heapUsedBytes": 203616288,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 108.986,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.85060240963855,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9312.310000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8799.491999999998,
"heapDeltaBytes": -18094788,
"heapUsedBytes": 194991764,
"domNodes": -3045,
"jsHeapTotalBytes": 4112384,
"scriptDurationMs": 197.59099999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 32.0147766323024,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8810.137999999937,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8504.955,
"heapDeltaBytes": -56812164,
"heapUsedBytes": 170196088,
"domNodes": -3045,
"jsHeapTotalBytes": 8396800,
"scriptDurationMs": 138.205,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.767832167832164,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 136.35199999998804,
"styleRecalcs": 10,
"styleRecalcDurationMs": 14.388000000000002,
"layouts": 3,
"layoutDurationMs": 1.6649999999999998,
"taskDurationMs": 100.36199999999998,
"heapDeltaBytes": 4006728,
"heapUsedBytes": 57939248,
"domNodes": -108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.309,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 471.1779999998953,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.496,
"layouts": 3,
"layoutDurationMs": 0.8410000000000002,
"taskDurationMs": 98.28099999999998,
"heapDeltaBytes": 5549300,
"heapUsedBytes": 59174592,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.388,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 796.7139999999517,
"styleRecalcs": 78,
"styleRecalcDurationMs": 98.88900000000001,
"layouts": 76,
"layoutDurationMs": 24.355999999999998,
"taskDurationMs": 775.357,
"heapDeltaBytes": 17219988,
"heapUsedBytes": 81572936,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 310.531,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667346938775506,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1004.3739999999843,
"styleRecalcs": 78,
"styleRecalcDurationMs": 112.025,
"layouts": 76,
"layoutDurationMs": 27.224,
"taskDurationMs": 964.838,
"heapDeltaBytes": 18875196,
"heapUsedBytes": 86639312,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 400.353,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999996,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1419.257000000016,
"styleRecalcs": 78,
"styleRecalcDurationMs": 266.30199999999996,
"layouts": 76,
"layoutDurationMs": 29.513,
"taskDurationMs": 1405.984,
"heapDeltaBytes": -13214840,
"heapUsedBytes": 107092308,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 480.06800000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.143037974683534,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1453.9190000000417,
"styleRecalcs": 78,
"styleRecalcDurationMs": 273.95000000000005,
"layouts": 76,
"layoutDurationMs": 29.514,
"taskDurationMs": 1418.266,
"heapDeltaBytes": 8328916,
"heapUsedBytes": 114836092,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 465.051,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.353164556962042,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f0151eb88e202de92562852e3a968e336a3844cd
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2188 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughThe pull request updates comments and a test description in three test files. It clarifies issue status for an agent output test, polling reconciliation for failed downloads, and the status of an agent lifecycle test. ChangesTest commentary updates
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to This PR changes test commentary only; no material behavior or test-coverage issue was established, so it is ready to merge with normal checks. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19927 +/- ##
==========================================
+ Coverage 84.81% 85.53% +0.72%
==========================================
Files 3430 2409 -1021
Lines 164426 137570 -26856
Branches 44899 35356 -9543
==========================================
- Hits 139452 117669 -21783
+ Misses 23022 19525 -3497
+ Partials 1952 376 -1576
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Thanks — noting for the record that the completed review reported "No actionable comments were generated", with 0 inline comments and all 7 pre-merge checks passing. No code changes made in response; there was nothing to address. Declining both Finishing Touches offers deliberately:
CI is green, and it validates the PR's central claimAll checks finished on That Playwright result is the substantive outcome, not just a formality. The PR argues that none of the 20 The two Re: One item in the description is worth a maintainer's eye rather than mine: PM-1157 and PM-1158 are both |
|
Thanks for the review @benceruleanlu. Recording the state for anyone landing here later: the approval carried no review body and no inline comments, so no changes were made — the branch is unchanged at Final state: two approvals, CI complete at 70 success / 28 skipped / 0 failures (the 2 Ready to merge whenever you are. The one thing in the description that outlives this PR is a process item rather than a code one: PM-1157 / PM-1158 are both |
PR Created by the Glary-Bot Agent
Follow-up to an audit of disabled Playwright/Vitest tests. This lands only the low-risk housekeeping subset: annotations whose factual claims have gone stale or were wrong. No marker is added, removed or re-scoped, and no product code is touched.
The only non-comment line in the whole diff is one test title string:
What changed
src/workbench/extensions/agent/AgentPanelRoot.test.ts— describedagentPanelLifecycle.spec.tsas "still test.fixme pending FE #16919". #16919 was closed unmerged; #17132 is what re-enabled the spec (4a5b183249), and it carries nofixmetoday.browser_tests/tests/agent/agentNestedOutputSentPreview.spec.ts— deferred its decision to "open owner PRs (#16985, #17767)". Both merged (2026-09-22 / 09-23). PM-1158 then closed on a partial fix (#18104, image path only) and PM-1157 on this repro, so the non-image path this test pins is unowned. Thetest.fail()stays.src/stores/assetDownloadStore.test.ts— labelled PM-1302 / PM-1309 anOPEN DESIGN QUESTION; both areDone. Worse, the block contradicted itself: its header says polling "re-checksfaileddownloads too", while the inner comment saidpollStaleDownloads()"only walks activeDownloads" so the task is "never reconciled". Both are false —pollStaleDownloads()walksrecheckableDownloads, which includesfailed(assetDownloadStore.ts:23-27, 206-208), and the passing test at:350reconciles a failed download through polling. Theit.failsmarker stays (the gap it pins is still a live product decision); only the false consequence is dropped from its title.Why nothing else from the audit is here
The audit found 82 marker sites. Everything else was checked and deliberately left alone:
test.fail()sites are CI-enforced. Each lives in a spec tagged into a running project (@cloud→cloud,@smoke/@vue-nodes→chromium). Playwright fails atest.fail()that unexpectedly passes, so main being green proves none of them are stale. Removing any would be unjustified.In Reviewwith refactor: reduce pointer gestures with a pure state machine #17113/refactor: route Vue node pointer events through the gesture reducer #17116/refactor: resolve the primary-button target once per press #17122/fix: cancel the active pointer gesture on teardown and focus loss #17308 unmerged → the fourpointerGestures/selectionmarkers stay. Issues Agent CRDT: same-id node write collision is silently dropped (last-write-wins) with no error surfaced #18414 and Moving a Group selects nodes inside, but copying does not #7454 are open → those markers stay.test.fail()are deliberate fixture self-tests (networkIsolation,liveCloudBillingRouting) that assert the guard fixture fails at teardown. Correct as written. I considered adding clarifying comments and dropped it —AGENTS.mdsets a high bar against non-essential comments.test.fixme()are bodiless placeholder rows incrossOriginSession/**,testIgnored from the default config and gated byexpectStepsWritten. Not removable without deleting the QA plan's tracking rows.skip/skipIf/ctx.skipare data-, shard- and env-availability guards (one was added by test(website): guard the upcoming-events e2e when none are upcoming #15150 precisely so the suite survives event data rolling over). Verified actively skipping:LGraph.roundTrip.test.tsreports 5 skips against real fixture shapes.Two findings worth a look, not fixed here
Done, but the defect they describe is still pinned failing. PM-1157 was closed by test(agent): repro a nested video output sent by display name (PM-1157/PM-1158) #18201 — the PR that added the repro. PM-1158 got a partial fix (fix: prefer previewUrl over type=input lookup for dragged batch-output attachments #18104) covering the image path only. The non-imagepreview_urlpath has no open owner. cc @christian-byrneit.fails(.failing(was matched,.fails(was not) — 13 sites across 7 files, so the real total is 95, not 82.assetDownloadStore.test.tsis the only one of the 13 carrying an external ticket reference; the other 12 reference nothing that can go stale.Verification
pnpm exec vitest run src/stores/assetDownloadStore.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts→ 408 passed, 1 expected fail (theit.failsstill failing as designed), run in an interactive tmux session.oxfmt, type-awareoxlint,eslint,typecheck:app,typecheck:browser— all green.typecheck:browsercovers the Playwright spec.deep-reviewerrounds; the first caught a genuine error in my own first draft (I had misreadclosed_atas merged and written#16919where#17132belongs). Final verdict PASS.~/.cache/ms-playwrightholds only ffmpeg) with no torch for a ComfyUI backend, soagentNestedOutputSentPreview.spec.tscould not be executed. It is comment-only and covered bytypecheck:browser.