Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (17)
💤 Files with no reviewable changes (16)
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC. 📝 WalkthroughWalkthroughPointer gesture classification now uses a reducer to distinguish clicks and drags by movement distance. Click-buffer timing no longer controls drag detection and is deprecated in settings. Tests and documentation reflect the updated gesture behavior. ChangesPointer gesture classification
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant PointerEvent
participant CanvasPointer
participant reduceGesture
participant GestureCallbacks
PointerEvent->>CanvasPointer: Send down, move, or up event
CanvasPointer->>reduceGesture: Dispatch event with position and policy
reduceGesture-->>CanvasPointer: Return updated state and effects
CanvasPointer->>GestureCallbacks: Invoke callbacks for returned effects
Merge Risk: ⚪ Minimal · up to Slow movement within the click-distance threshold remains a click, so a number widget may adjust during movement and open its prompt on release. This behavior is documented, and the cancellation documentation matches the implementation; the change is ready to merge. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description explains the reducer, behavior changes, tests, and validation. However, it omits breaking public API changes and says public event fields are retained, while the changes remove Resolution Update the description to identify the public API changes under Breaking. Clarify that ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2237 passed, 0 failed📊 Browser Reports
📦 Bundle: 10.3 MB gzip 🟢 -1.72 kBDetailsSummary
Category Glance App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • 🟢 -781 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 664 kB (baseline 672 kB) • 🟢 -8.1 kBConfiguration panels, inspectors, and settings screens
Status: 27 added / 27 removed / 2 unchanged User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 7 unchanged Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 1 unchanged UI Components — 205 kB (baseline 205 kB) • ⚪ 0 BReusable component library chunks
Status: 9 added / 9 removed / 11 unchanged Data & Services — 4.19 MB (baseline 4.19 MB) • 🔴 +1.74 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 18 unchanged Vendor & Third-Party — 17.3 MB (baseline 17.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.6 MB (baseline 18.6 MB) • ⚪ 0 BBundles that do not match a named category
Status: 87 added / 87 removed / 229 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-06T23:58:02.859Z",
"gitSha": "8bf7ebc773c18d180cb39527bdc67d88863db95b",
"branch": "drjkl/fe-2040-gesture-reducer",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.4289999999842,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.6950000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.51900000000006,
"heapDeltaBytes": 3849948,
"heapUsedBytes": 66069120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.261000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.420000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8189999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.4669999999999,
"heapDeltaBytes": 7344724,
"heapUsedBytes": 76296796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.636999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1721.1220000000367,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.216,
"layouts": 12,
"layoutDurationMs": 4.38,
"taskDurationMs": 790.867,
"heapDeltaBytes": 3697592,
"heapUsedBytes": 72208728,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 145.646,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.1549999999297,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.888,
"layouts": 12,
"layoutDurationMs": 4.234,
"taskDurationMs": 750.897,
"heapDeltaBytes": 3266656,
"heapUsedBytes": 72161800,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 142.80300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.5550000000094,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.741999999999999,
"layouts": 3,
"layoutDurationMs": 1.0179999999999998,
"taskDurationMs": 351.59499999999997,
"heapDeltaBytes": 9616044,
"heapUsedBytes": 78174884,
"domNodes": 45,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.964000000000002,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.8449999999775,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.935,
"layouts": 3,
"layoutDurationMs": 0.8670000000000001,
"taskDurationMs": 337.62200000000007,
"heapDeltaBytes": 9741560,
"heapUsedBytes": 78560472,
"domNodes": 45,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.797000000000008,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 634.6139999999991,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.4529999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.601,
"heapDeltaBytes": -5637112,
"heapUsedBytes": 63433480,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 161.569,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684193,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 616.1829999999782,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.7619999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.13800000000003,
"heapDeltaBytes": -5310528,
"heapUsedBytes": 63122672,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 161.406,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567563,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1140.984000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.501,
"heapDeltaBytes": 16783948,
"heapUsedBytes": 87316476,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 55.68799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 498,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1129.7499999999445,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 792.1030000000001,
"heapDeltaBytes": 16815628,
"heapUsedBytes": 87602260,
"domNodes": 0,
"jsHeapTotalBytes": 2523136,
"scriptDurationMs": 63.915,
"eventListeners": 0,
"totalBlockingTimeMs": 494,
"frameDurationMs": 33.332352941176474,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.429999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.4820000000003,
"heapDeltaBytes": 19028148,
"heapUsedBytes": 102246672,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 139.106,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 863.5839999999462,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.7790000000005,
"heapDeltaBytes": 18296988,
"heapUsedBytes": 99775544,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 144.84400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 24.762857142857165,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8842.622000000007,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4010000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7897.761,
"heapDeltaBytes": 9950172,
"heapUsedBytes": 96920992,
"domNodes": -170,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 6697.877,
"eventListeners": -73,
"totalBlockingTimeMs": 350,
"frameDurationMs": 30.146757679180887,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8764.035000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7972.834,
"heapDeltaBytes": -1524476,
"heapUsedBytes": 80029216,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 6475.266,
"eventListeners": 0,
"totalBlockingTimeMs": 207,
"frameDurationMs": 30.38090277777778,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8923.080000000027,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7970000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7910.182,
"heapDeltaBytes": -2733004,
"heapUsedBytes": 83968856,
"domNodes": -172,
"jsHeapTotalBytes": -11669504,
"scriptDurationMs": 6407.398999999999,
"eventListeners": -81,
"totalBlockingTimeMs": 123,
"frameDurationMs": 27.863437500000003,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9455.619999999954,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8389999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8473.719000000001,
"heapDeltaBytes": -12429876,
"heapUsedBytes": 73006088,
"domNodes": -141,
"jsHeapTotalBytes": -10358784,
"scriptDurationMs": 6953.075,
"eventListeners": -73,
"totalBlockingTimeMs": 123,
"frameDurationMs": 28.04035608308605,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2011.0770000000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.720000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.7850000000001,
"heapDeltaBytes": -3254492,
"heapUsedBytes": 86211176,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.077,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.7489999999898,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2230000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.103,
"heapDeltaBytes": -2862256,
"heapUsedBytes": 86923404,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.379000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2256.6380000000095,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1530.5279999999998,
"heapDeltaBytes": -10217712,
"heapUsedBytes": 80186748,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 793.0429999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665925925925922,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2155.255999999895,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.9670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1443.7269999999999,
"heapDeltaBytes": -10617192,
"heapUsedBytes": 79820936,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 756.5820000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589147286822,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3601.3149999999996,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.375000000000002,
"layouts": 60,
"layoutDurationMs": 17.887,
"taskDurationMs": 1717.8090000000004,
"heapDeltaBytes": 10340240,
"heapUsedBytes": 80147516,
"domNodes": 24,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 819.372,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666203703703705,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3507.649000000015,
"styleRecalcs": 72,
"styleRecalcDurationMs": 8.652999999999999,
"layouts": 60,
"layoutDurationMs": 17.053,
"taskDurationMs": 1618.6380000000001,
"heapDeltaBytes": 11261136,
"heapUsedBytes": 93276772,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 762.1329999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665238095238095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3025.3809999999817,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.901999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.813,
"heapDeltaBytes": -9968368,
"heapUsedBytes": 73866720,
"domNodes": 0,
"jsHeapTotalBytes": 1085440,
"scriptDurationMs": 1015.4889999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75888888888889,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2641.572999999994,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.280000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1751.706,
"heapDeltaBytes": 11665844,
"heapUsedBytes": 77348584,
"domNodes": -167,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 917.495,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.880128205128205,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2023.633000000018,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.093,
"heapDeltaBytes": 20384640,
"heapUsedBytes": 89357476,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.26599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.729000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.406,
"heapDeltaBytes": -2495300,
"heapUsedBytes": 88025040,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 32.846000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.960999999993,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.233999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.425,
"heapDeltaBytes": -9557864,
"heapUsedBytes": 60924780,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 149.173,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.0689999999804,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.534000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.55,
"heapDeltaBytes": -10206972,
"heapUsedBytes": 59970344,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 145.344,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66470588235295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.840000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5309999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.83299999999997,
"heapDeltaBytes": 8058380,
"heapUsedBytes": 79603140,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.821000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.2100000000764,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.457,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.762,
"heapDeltaBytes": 3607936,
"heapUsedBytes": 66083900,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.882,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.4099999999912,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.076,
"layouts": 16,
"layoutDurationMs": 5.5040000000000004,
"taskDurationMs": 759.9870000000001,
"heapDeltaBytes": -619304,
"heapUsedBytes": 70660628,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 102.18000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.766000000007,
"styleRecalcs": 77,
"styleRecalcDurationMs": 14.52,
"layouts": 16,
"layoutDurationMs": 6.013000000000001,
"taskDurationMs": 725.1,
"heapDeltaBytes": -33501732,
"heapUsedBytes": 76535156,
"domNodes": -228,
"jsHeapTotalBytes": -4456448,
"scriptDurationMs": 94.171,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.4289999999546,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.829000000000004,
"layouts": 5,
"layoutDurationMs": 13.209999999999996,
"taskDurationMs": 919.3170000000001,
"heapDeltaBytes": 32254464,
"heapUsedBytes": 107245324,
"domNodes": 14570,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 29.239,
"eventListeners": 2458,
"totalBlockingTimeMs": 114,
"frameDurationMs": 18.917567567567573,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8337.431999999979,
"styleRecalcs": 248,
"styleRecalcDurationMs": 21.158000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5362.904,
"heapDeltaBytes": 3893984,
"heapUsedBytes": 67015384,
"domNodes": -328,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 2531.877,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665931863727458,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8332.370000000083,
"styleRecalcs": 250,
"styleRecalcDurationMs": 20.805000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5234.860000000001,
"heapDeltaBytes": -61580436,
"heapUsedBytes": 64905424,
"domNodes": -328,
"jsHeapTotalBytes": -2981888,
"scriptDurationMs": 2482.7090000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665931863727454,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18578.621,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17992.125,
"heapDeltaBytes": -36635736,
"heapUsedBytes": 181873860,
"domNodes": -3046,
"jsHeapTotalBytes": 5103616,
"scriptDurationMs": 332.785,
"eventListeners": -14915,
"totalBlockingTimeMs": 1,
"frameDurationMs": 32.17660311958405,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-large-graph-idle",
"durationMs": 18599.042000000052,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17778.519,
"heapDeltaBytes": -32127052,
"heapUsedBytes": 182953348,
"domNodes": -3046,
"jsHeapTotalBytes": 8146944,
"scriptDurationMs": 295.625,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.06775862068965,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 22633.009000000016,
"styleRecalcs": 176,
"styleRecalcDurationMs": 15.542,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22275.01,
"heapDeltaBytes": -27191552,
"heapUsedBytes": 188049308,
"domNodes": -3046,
"jsHeapTotalBytes": 7360512,
"scriptDurationMs": 823.761,
"eventListeners": -14913,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.357088122605376,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 22905.933000000005,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.454000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22554.483,
"heapDeltaBytes": -29779908,
"heapUsedBytes": 189174332,
"domNodes": -3096,
"jsHeapTotalBytes": 7507968,
"scriptDurationMs": 838.292,
"eventListeners": -14913,
"totalBlockingTimeMs": 14,
"frameDurationMs": 43.70076335877863,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 6657.425999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.50300000000001,
"layouts": 20,
"layoutDurationMs": 26.057999999999996,
"taskDurationMs": 6538.368,
"heapDeltaBytes": -2395580,
"heapUsedBytes": 216484920,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 117.23499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.14972067039107,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6643.404999999916,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.84299999999999,
"layouts": 20,
"layoutDurationMs": 24.937,
"taskDurationMs": 6493.950000000001,
"heapDeltaBytes": 1083768,
"heapUsedBytes": 216290756,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 111.38100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.6875,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9503.999999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9167.593,
"heapDeltaBytes": -42065264,
"heapUsedBytes": 173330040,
"domNodes": -3046,
"jsHeapTotalBytes": 6901760,
"scriptDurationMs": 144.37200000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.64501718213059,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9462.91599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8863.360000000002,
"heapDeltaBytes": -27935336,
"heapUsedBytes": 188279608,
"domNodes": -3046,
"jsHeapTotalBytes": 13127680,
"scriptDurationMs": 138.07099999999994,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.19795918367346,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "workflow-execution",
"durationMs": 512.5799999999572,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.661,
"layouts": 4,
"layoutDurationMs": 3.115,
"taskDurationMs": 178.31099999999998,
"heapDeltaBytes": -44617752,
"heapUsedBytes": 60569560,
"domNodes": -78,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 15.504,
"eventListeners": -58,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 103.50800000003346,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.830000000000002,
"layouts": 2,
"layoutDurationMs": 1.3610000000000002,
"taskDurationMs": 67.84299999999999,
"heapDeltaBytes": 3965328,
"heapUsedBytes": 62298116,
"domNodes": 118,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.487000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 926.9839999999476,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.427,
"layouts": 76,
"layoutDurationMs": 26.686999999999998,
"taskDurationMs": 893.614,
"heapDeltaBytes": 18549520,
"heapUsedBytes": 84547212,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 371.726,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.970909090909085,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 787.9269999999678,
"styleRecalcs": 78,
"styleRecalcDurationMs": 87.735,
"layouts": 76,
"layoutDurationMs": 24.551,
"taskDurationMs": 757.52,
"heapDeltaBytes": 17228524,
"heapUsedBytes": 83907280,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 308.32000000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664583333333326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1362.5990000000456,
"styleRecalcs": 78,
"styleRecalcDurationMs": 258.426,
"layouts": 76,
"layoutDurationMs": 28.846,
"taskDurationMs": 1348.5929999999998,
"heapDeltaBytes": 10380288,
"heapUsedBytes": 116003480,
"domNodes": 76,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 448.31100000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.298734177215195,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1339.4949999999426,
"styleRecalcs": 78,
"styleRecalcDurationMs": 249.965,
"layouts": 76,
"layoutDurationMs": 28.405,
"taskDurationMs": 1327.3640000000003,
"heapDeltaBytes": 10418676,
"heapUsedBytes": 115723276,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 442.65,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.088607594936708,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9d645524740e3b62f4c6f803fbab2d048389638e
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #17113 +/- ##
==========================================
+ Coverage 85.48% 86.28% +0.80%
==========================================
Files 3529 2487 -1042
Lines 169373 141446 -27927
Branches 44466 38445 -6021
==========================================
- Hits 144793 122053 -22740
+ Misses 22586 19012 -3574
+ Partials 1994 381 -1613
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1059 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the reducer against the pre-PR CanvasPointer, and cross-checked ADR-0029's design claims against Gecko, WebKit, the Pointer Events spec, Qt/GTK/Android/Flutter, and tldraw/Excalidraw/React Flow rather than Blink alone. The state machine itself is sound and the it.fails to it flip at LGraphCanvas.gesture.test.ts:241 is exactly the right way to retire a characterized bug. Three things are broken today and CI already shows all three.
CI is red on this PR, and all three failures are caused by it
pnpm typecheck:browserfails:browser_tests/tests/interaction.spec.ts:386:26 - error TS2339: Property 'eLastDown' does not exist on type 'CanvasPointer'. Notepnpm typecheckpasses, so the checklist in the description is green while a different vue-tsc project is red.typecheck:browserruns at.github/actions/lint-format-verify/action.yml:34.canvasSettings.spec.ts:430ClickBufferTime governs the click-vs-drag time thresholdfails at line 467. It nudges 2px under a 20pxClickDriftand asserts the node moved, which distance-only promotion makes unreachable. The test needs deleting in this PR.widget.spec.ts:145Number widget / Can drag adjust valuefails on theseed_widget_dragged.pngscreenshot. That one is the interesting failure, see themove()comment below.
groupColorPicker.spec.ts:32 also fails, but it already fails on 17110, so it is not yours.
On the ADR's supporting claims
Since this PR implements decision 4, worth recording that "distance-only" is not the universal it is presented as. WebKit gates text drags on TextDragDelay = 150ms on macOS (EventHandler.cpp:197), Qt's QStyleHints::startDragTime (500ms default) promotes a press with zero movement, and tldraw promotes on a 500ms long press in nine tool states (SelectTool/childStates/PointingShape.ts:244). Excalidraw has no press-to-drag threshold at all. React Flow is the one clean match. Separately, WebKit picks hysteresis per drag kind (Link 40 / Image 5 / Text 3), Flutter splits by device kind (mouse 1.0 vs touch 18.0), and Blender ships three thresholds. None of that blocks this PR, but a single user-tunable scalar shared across mouse, touch and pen is a choice worth naming as one.
Also: this repo already has docs/guidance/state-and-effects.md, which prescribes this exact shape. Its signature is reduce(state, event) with context folded into state, and it defines effects as strictly outward sync that "write nothing anything else reads". These effects drive selection and drag, so they are commands in that document's vocabulary. Worth reconciling before the pattern spreads.
Deferred work that is cheaper now than later
GestureEvent has no pointerId or pointerType, and no timer variant. Long press is not more of the same: it reacts to the absence of an event over an interval, which no timestamp on a real pointer event can express. Statecharts, XState and Elm all deliver the timer as an event in the union with the interpreter owning the clock. Adding a variant to a discriminated union later breaks every exhaustive switch and every construction site in the tests; adding an ignored one now costs nothing.
| /** Set to true when if the pointer moves far enough after a down event, before the corresponding up event is fired. */ | ||
| dragStarted: boolean = false | ||
| /** `true` once the pointer has moved far enough after a down event to be a drag, until the corresponding up event. */ | ||
| get dragStarted(): boolean { |
There was a problem hiding this comment.
issue: dragStarted reads false inside onDragEnd and finally, where it was true for the whole drag.
#dispatch assigns this.#state = state before running effects, so by the time endDrag reaches a callback the phase is already idle. On the release-beyond-drift path it is worse: ['startDrag','endDrag'] is emitted from an already-idle state, so dragStarted is false even inside onDragStart. The old code set the flag in _setDragStarted before invoking the callback, and reset() ran finally before clearing it.
Separately this went from a writable field to a getter with no setter. ES modules are strict, so an extension doing pointer.dragStarted = false to cancel a drag it started now throws a TypeError from inside litegraph's own handler. The description lists dragStarted as keeping its public surface. No in-repo reader, so the blast radius is external only.
There was a problem hiding this comment.
Restored writable compatibility with a setter and direct assignment coverage. The reducer-backed value remains the source of truth.
There was a problem hiding this comment.
Automated follow-up: commit 8b31443 removes the setter referenced above, so dragStarted remains read-only. Because CanvasPointer is exported, an extension assignment now throws in strict mode. Restore write compatibility or provide a supported migration before merge.
|
Two follow-ups that did not fit an inline anchor. A second double-detection authority the reducer does not see. That is the defect class the ADR exists to remove, and neither the ADR nor this PR mentions The open CodeRabbit finding on #17106 about invalidating click history on drag promotion is still unaddressed here. I checked whether this is a regression and it is not: old |
ef3ccc7 to
273d2ab
Compare
273d2ab to
272475f
Compare
2a3762f to
993c77e
Compare
c868e81 to
b2bcc3b
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
b2bcc3b to
9f02c21
Compare
9f02c21 to
da433dd
Compare
da433dd to
4f0d293
Compare
…rs (Comfy-Org#19927) *PR Created by the Glary-Bot Agent* --- Follow-up to an audit of disabled Playwright/Vitest tests. This lands **only** the low-risk housekeeping subset: annotations whose factual claims have gone stale or were wrong. No marker is added, removed or re-scoped, and no product code is touched. The only non-comment line in the whole diff is one test title string: ``` git diff main -U0 | grep -E '^[+-]' | grep -vE '^(\+\+\+|---)' | grep -vE '^[+-]\s*//' - it.fails('excludes a failed-then-actually-completed task from activeDownloads so it is never reconciled (PM-1302)', () => { + it.fails('excludes a failed-then-actually-completed task from activeDownloads (PM-1302)', () => { ``` ## What changed **`src/workbench/extensions/agent/AgentPanelRoot.test.ts`** — described `agentPanelLifecycle.spec.ts` as *"still test.fixme pending FE Comfy-Org#16919"*. Comfy-Org#16919 was **closed unmerged**; Comfy-Org#17132 is what re-enabled the spec (`4a5b183249`), and it carries no `fixme` today. **`browser_tests/tests/agent/agentNestedOutputSentPreview.spec.ts`** — deferred its decision to *"open owner PRs (Comfy-Org#16985, Comfy-Org#17767)"*. Both merged (2026-09-22 / 09-23). PM-1158 then closed on a partial fix (Comfy-Org#18104, image path only) and PM-1157 on this repro, so the **non-image path this test pins is unowned**. The `test.fail()` stays. **`src/stores/assetDownloadStore.test.ts`** — labelled PM-1302 / PM-1309 an `OPEN DESIGN QUESTION`; both are `Done`. Worse, the block contradicted itself: its header says polling *"re-checks `failed` downloads too"*, while the inner comment said `pollStaleDownloads()` *"only walks activeDownloads"* so the task is *"never reconciled"*. Both are false — `pollStaleDownloads()` walks `recheckableDownloads`, which includes `failed` (`assetDownloadStore.ts:23-27, 206-208`), and the passing test at `:350` reconciles a failed download through polling. The `it.fails` marker stays (the gap it pins is still a live product decision); only the false consequence is dropped from its title. ## Why nothing else from the audit is here The audit found 82 marker sites. Everything else was checked and deliberately left alone: - **All 20 `test.fail()` sites are CI-enforced.** Each lives in a spec tagged into a running project (`@cloud` → `cloud`, `@smoke`/`@vue-nodes` → `chromium`). Playwright fails a `test.fail()` that unexpectedly passes, so **main being green proves none of them are stale**. Removing any would be unjustified. - **FE-2040 is `In Review`** with Comfy-Org#17113/Comfy-Org#17116/Comfy-Org#17122/Comfy-Org#17308 unmerged → the four `pointerGestures`/`selection` markers stay. Issues Comfy-Org#18414 and Comfy-Org#7454 are open → those markers stay. - **7 of the 20 `test.fail()` are deliberate fixture self-tests** (`networkIsolation`, `liveCloudBillingRouting`) that assert the guard fixture fails at teardown. Correct as written. I considered adding clarifying comments and dropped it — `AGENTS.md` sets a high bar against non-essential comments. - **The 35 `test.fixme()`** are bodiless placeholder rows in `crossOriginSession/**`, `testIgnore`d from the default config and gated by `expectStepsWritten`. Not removable without deleting the QA plan's tracking rows. - **The 27 conditional `skip`/`skipIf`/`ctx.skip`** are data-, shard- and env-availability guards (one was added by Comfy-Org#15150 precisely so the suite survives event data rolling over). Verified actively skipping: `LGraph.roundTrip.test.ts` reports 5 skips against real fixture shapes. ## Two findings worth a look, not fixed here 1. **PM-1157 / PM-1158 are `Done`, but the defect they describe is still pinned failing.** PM-1157 was closed by Comfy-Org#18201 — the PR that *added the repro*. PM-1158 got a partial fix (Comfy-Org#18104) covering the image path only. The non-image `preview_url` path has no open owner. cc @christian-byrne 2. **The audit's own marker grep missed `it.fails`** (`.failing(` was matched, `.fails(` was not) — 13 sites across 7 files, so the real total is 95, not 82. `assetDownloadStore.test.ts` is the only one of the 13 carrying an external ticket reference; the other 12 reference nothing that can go stale. ## Verification - `pnpm exec vitest run src/stores/assetDownloadStore.test.ts src/workbench/extensions/agent/AgentPanelRoot.test.ts` → **408 passed, 1 expected fail** (the `it.fails` still failing as designed), run in an interactive tmux session. - Pre-commit hook: `oxfmt`, type-aware `oxlint`, `eslint`, `typecheck:app`, `typecheck:browser` — all green. `typecheck:browser` covers the Playwright spec. - Three `deep-reviewer` rounds; the first caught a genuine error in my own first draft (I had misread `closed_at` as merged and written `Comfy-Org#16919` where `Comfy-Org#17132` belongs). Final verdict PASS. - **Not possible in this sandbox:** no screenshots — the change has no UI surface, and Playwright browsers are not installed (`~/.cache/ms-playwright` holds only ffmpeg) with no torch for a ComfyUI backend, so `agentNestedOutputSentPreview.spec.ts` could not be executed. It is comment-only and covered by `typecheck:browser`. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
| this.eDown = e | ||
| this.pointerId = e.pointerId | ||
| this.element.setPointerCapture(e.pointerId) | ||
| this.dispatch( |
There was a problem hiding this comment.
issue: This adapter has no path for lostpointercapture, window blur, or a hidden document to dispatch cancel. Those interruptions do not necessarily emit pointercancel; a drag can keep its canvas cleanup and auto-pan active until another pointer-down arrives. Register interruption listeners for the active gesture and cancel them on completion, with regression coverage for at least lost pointer capture.
There was a problem hiding this comment.
Fixed in de3a536, with a narrower fix than the one proposed.
CanvasPointer now listens for lostpointercapture on the element it captured, for the active pointer only, and resets when it fires. That runs finally (stopping auto-pan) and skips onDragEnd, so an interrupted drag ends as a cancel, not a drop. reset() removes the listener.
I didn't add window blur or visibilitychange listeners. While the canvas holds capture, the browser delivers pointerup or pointercancel to it, and releases capture right after either one. So lostpointercapture is the browser's own signal for the cases you describe: capture taken or released elsewhere, the element removed, or a focus change that ends the stream. Blur and visibility are guesses at that signal, and they would also cancel gestures that the browser still finishes normally. If you have a browser where a gesture ends without lostpointercapture, send the repro and I'll add the listener for that case.
Coverage in LGraphCanvas.gesture.test.ts:
- Lost capture during a drag cancels it: no
onDragEnd, onefinally. This test fails without the fix. - Lost capture for a different pointer is ignored.
I also checked separately that a lostpointercapture arriving after a normal release doesn't run cleanup twice. The ADR now describes this rule.
christian-byrne
left a comment
There was a problem hiding this comment.
Two lifecycle regressions remain at this head:
-
CanvasPointer.dispatch()commits the reducer result before runningendDrag. ConsequentlydragStartedis alreadyfalseinside bothonDragEndandfinally; on a far release without a move it is alsofalseinsideonDragStart. Previously it stayed true untilreset()completed cleanup. Keep the active-drag surface true through the callback and cleanup lifecycle, and add focused coverage foronDragEndandfinally. -
The adapter still has no
lostpointercapture, window blur, or document-visibility interruption path. A captured drag can therefore retain its canvas cleanup state until a later pointerdown. The ADR explicitly requires those interrupts to dispatchcancel; wire them to the active gesture and cover at least lost pointer capture.
Focused validation at this commit: pnpm exec vitest run src/lib/litegraph/src/canvas/reduceGesture.test.ts src/lib/litegraph/src/LGraphCanvas.gesture.test.ts (48 passed, 1 expected failure).
christian-byrne
left a comment
There was a problem hiding this comment.
The open gesture-interruption finding is valid and should be addressed before merge. CanvasPointer.down() captures the pointer, but neither it nor LGraphCanvas handles lostpointercapture, window blur, or document visibility changes. Those paths can end an interaction without pointercancel, leaving a drag’s callbacks and canvas cleanup active until another pointer event resets it.
Please cancel the active gesture for interruption events, unregister any listeners on normal completion/reset, and add regression coverage for at least lostpointercapture. DrJKL is already assigned for the next action.
christian-byrne
left a comment
There was a problem hiding this comment.
Requesting the remaining lifecycle and contract fixes before approval:
CanvasPointer.dragStartedis still a getter only anddispatch()commits the idle reducer state beforeendDrag; it is therefore false insideonDragEndandfinally(and during start/end for a far release with no move). Please preserve the writable compatibility surface and keep it true through drag callbacks and cleanup, with focused coverage.- Wire active gestures to cancel on
lostpointercapture, window blur, and document visibility loss, then unregister those listeners on completion/reset. - Reconcile ADR-CANVAS-GESTURE-0029 with the shipped cancellation behavior: it still specifies
cancelDragand clearing the prior click for dragging cancellation, while the reducer emits no effect and preserves it. - Finish removing the deprecated
ClickBufferTimeUI metadata: the hidden setting still has a category and its English localization remains even though collection filters hidden settings.
christian-byrne
left a comment
There was a problem hiding this comment.
Validated at 8b31443. Requesting the remaining contract and lifecycle fixes before approval:
- Keep CanvasPointer.dragStarted writable and true through onDragEnd and finally. dispatch() currently stores idle before the start/end effects, so it is false in those callbacks, including a far release without a move. Add focused coverage.
- Cancel active gestures on lostpointercapture, window blur, and document visibility loss; remove the listeners during reset/completion. Cover at least lost pointer capture.
- Reconcile ADR-CANVAS-GESTURE-0029: dragging + cancel now preserves lastClick and emits no effect, with adapter reset handling cleanup.
- Remove remaining ClickBufferTime presentation metadata (category and English localization) while retaining the hidden deprecated registration for stored values.
I inspected the reducer, adapter, ADR, settings definition, and focused lifecycle tests. The isolated pinned worktree has no node_modules, so I could not rerun Vitest locally.
christian-byrne
left a comment
There was a problem hiding this comment.
Automated review: Changes requested. Active gestures are not cancelled when pointer capture is lost or the window or document becomes unavailable. Dispatch cancel for these interruptions and cover at least lost pointer capture.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 96 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
Move click, double click, and drag classification out of CanvasPointer into reduceGesture, a pure function of (state, event, policy) that returns the next state and a list of effects. CanvasPointer keeps its public callback surface and becomes an adapter that runs those effects. A press now becomes a drag only when the pointer travels further than Comfy.Pointer.ClickDrift. The time based bufferTime promotion is removed, so a slow, still click no longer moves its target by a pixel. Comfy.Pointer.ClickBufferTime is hidden and marked deprecated. Part of FE-2040. Amp-Thread-ID: https://ampcode.com/threads/T-01a0d64f-7e18-71c9-a617-8fd02a7e98a5
Summary
Extracts pointer gesture state into the pure
reduceGesture(state, event, policy)reducer from ADR-CANVAS-GESTURE-0029 (#17106).CanvasPointerremains the compatibility adapter and retains its public callbacks, event fields, reset behavior, and read-onlydragStartedcompatibility view.idle,pressed,dragging.down,move,up,cancel.click,doubleClick,startDrag,movePress,moveDrag,endDrag.eUpbefore dispatch.Moves within the drift radius still invoke the compatibility adapter's
onDragthroughmovePress. Cancelling a drag emits no normal completion effect; the adapter still runsfinally, matching the compatible base behavior.Stacked on #17110. Part of FE-2040.
Checklist
pnpm typecheck:appandpnpm typecheck:browser